eslint-plugin-react-rsc 5.3.3-next.0 → 5.3.4-beta.0

package/dist/index.js

@@ -34,7 +34,7 @@ const rules$4 = { "react-rsc/function-definition": "off" };
 //#endregion
 //#region package.json
 var name$4 = "eslint-plugin-react-rsc";
-var version = "5.3.3-next.0";
+var version = "5.3.4-beta.0";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -53,7 +53,12 @@ var function_definition_default = createRule({
 		fixable: "code",
 		messages: {
 			file: "Functions exported from files with `use server` directive are React Server Functions and therefore must be async.",
-			local: "Functions with `use server` directive are React Server Functions and therefore must be async."
+			fileDirectivePosition: "The '{{name}}' directive must be at the very beginning of the file, before any imports or other code.",
+			fileDirectiveQuote: "The '{{name}}' directive must be written with single or double quotes, not backticks.",
+			local: "Functions with `use server` directive are React Server Functions and therefore must be async.",
+			localDirectivePosition: "The '{{name}}' directive must be at the very beginning of the function body.",
+			localDirectiveQuote: "The '{{name}}' directive must be written with single or double quotes, not backticks.",
+			localDirectiveUnexpected: "The '{{name}}' directive can only be used at the top of a file, not inside a function body."
 		},
 		schema: []
 	},
@@ -62,7 +67,9 @@ var function_definition_default = createRule({
 	defaultOptions: []
 });
 function create(context) {
-	if (!context.sourceCode.text.includes("use server")) return {};
+	const hasUseServer = context.sourceCode.text.includes("use server");
+	const hasUseClient = context.sourceCode.text.includes("use client");
+	if (!hasUseServer && !hasUseClient) return {};
 	const hasFileLevelUseServerDirective = context.sourceCode.ast.body.some(Check.isDirective("use server"));
 	/**
 	* Check if `node` is an async function, and report if not
@@ -102,24 +109,83 @@ function create(context) {
 	/**
 	* Find function declarations from exports and check them
 	* @param id The identifier of the exported function
-	* @param node The export declaration node
 	*/
-	function findAndCheckExportedFunctionDeclarations(id, node) {
+	function findAndCheckExportedFunctionDeclarations(id) {
 		const initNode = resolve(context, id);
 		if (initNode == null) return;
 		const unwrapped = Extract.unwrap(initNode);
 		if (!Check.isFunction(unwrapped)) return;
 		reportNonAsyncFunction(unwrapped, "file");
 	}
+	/**
+	* Check file-level directives for correct position and quote style.
+	* Well-formed directives at the beginning of the file will have a `directive` property.
+	* If they appear after other code, the parser will not set `directive`.
+	*/
+	function checkFileLevelDirectives() {
+		for (const node of context.sourceCode.ast.body) {
+			if (node.type !== AST_NODE_TYPES.ExpressionStatement) continue;
+			if (Check.isLiteral("string")(node.expression)) {
+				const value = node.expression.value;
+				if ((value === "use server" || value === "use client") && node.directive == null) context.report({
+					data: { name: value },
+					messageId: "fileDirectivePosition",
+					node
+				});
+				continue;
+			}
+			if (node.expression.type === AST_NODE_TYPES.TemplateLiteral && node.expression.quasis.length === 1 && node.expression.expressions.length === 0) {
+				const value = node.expression.quasis[0]?.value.cooked;
+				if (value === "use server" || value === "use client") context.report({
+					data: { name: value },
+					messageId: "fileDirectiveQuote",
+					node
+				});
+			}
+		}
+	}
+	/**
+	* Check function-level directives for correct position and quote style.
+	* @param node The function node to check
+	*/
+	function checkFunctionDirectives(node) {
+		if (node.body.type !== AST_NODE_TYPES.BlockStatement) return;
+		for (const stmt of node.body.body) {
+			if (stmt.type !== AST_NODE_TYPES.ExpressionStatement) continue;
+			if (Check.isLiteral("string")(stmt.expression)) {
+				const value = stmt.expression.value;
+				if (value === "use server" && stmt.directive == null) context.report({
+					data: { name: value },
+					messageId: "localDirectivePosition",
+					node: stmt
+				});
+				if (value === "use client") context.report({
+					data: { name: value },
+					messageId: "localDirectiveUnexpected",
+					node: stmt
+				});
+				continue;
+			}
+			if (stmt.expression.type === AST_NODE_TYPES.TemplateLiteral && stmt.expression.quasis.length === 1 && stmt.expression.expressions.length === 0) {
+				const value = stmt.expression.quasis[0]?.value.cooked;
+				if (value === "use server" || value === "use client") context.report({
+					data: { name: value },
+					messageId: "localDirectiveQuote",
+					node: stmt
+				});
+			}
+		}
+	}
 	return merge({
 		ArrowFunctionExpression(node) {
+			checkFunctionDirectives(node);
 			checkLocalServerFunction(node);
 		},
 		ExportDefaultDeclaration(node) {
 			if (!hasFileLevelUseServerDirective) return;
 			const decl = node.declaration;
 			if (reportNonAsyncFunction(decl, "file")) return;
-			if (decl.type === AST_NODE_TYPES.Identifier) findAndCheckExportedFunctionDeclarations(decl, node);
+			if (decl.type === AST_NODE_TYPES.Identifier) findAndCheckExportedFunctionDeclarations(decl);
 		},
 		ExportNamedDeclaration(node) {
 			if (!hasFileLevelUseServerDirective) return;
@@ -129,13 +195,18 @@ function create(context) {
 				if (decl.type === AST_NODE_TYPES.VariableDeclaration) for (const declarator of decl.declarations) reportNonAsyncFunction(declarator.init, "file");
 				return;
 			}
-			if (node.source == null && node.specifiers.length > 0) for (const spec of node.specifiers) findAndCheckExportedFunctionDeclarations(spec.local, node);
+			if (node.source == null && node.specifiers.length > 0) for (const spec of node.specifiers) findAndCheckExportedFunctionDeclarations(spec.local);
 		},
 		FunctionDeclaration(node) {
+			checkFunctionDirectives(node);
 			checkLocalServerFunction(node);
 		},
 		FunctionExpression(node) {
+			checkFunctionDirectives(node);
 			checkLocalServerFunction(node);
+		},
+		Program() {
+			checkFileLevelDirectives();
 		}
 	});
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-rsc",
-  "version": "5.3.3-next.0",
+  "version": "5.3.4-beta.0",
   "description": "ESLint React's ESLint plugin for RSC related rules.",
   "keywords": [
     "react",
@@ -37,16 +37,16 @@
     "./package.json"
   ],
   "dependencies": {
-    "@typescript-eslint/scope-manager": "^8.58.2",
-    "@typescript-eslint/type-utils": "^8.58.2",
-    "@typescript-eslint/types": "^8.58.2",
-    "@typescript-eslint/utils": "^8.58.2",
+    "@typescript-eslint/scope-manager": "^8.59.0",
+    "@typescript-eslint/type-utils": "^8.59.0",
+    "@typescript-eslint/types": "^8.59.0",
+    "@typescript-eslint/utils": "^8.59.0",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/ast": "5.3.3-next.0",
-    "@eslint-react/core": "5.3.3-next.0",
-    "@eslint-react/eslint": "5.3.3-next.0",
-    "@eslint-react/shared": "5.3.3-next.0",
-    "@eslint-react/var": "5.3.3-next.0"
+    "@eslint-react/ast": "5.3.4-beta.0",
+    "@eslint-react/core": "5.3.4-beta.0",
+    "@eslint-react/var": "5.3.4-beta.0",
+    "@eslint-react/eslint": "5.3.4-beta.0",
+    "@eslint-react/shared": "5.3.4-beta.0"
   },
   "devDependencies": {
     "@types/react": "^19.2.14",