eslint-plugin-react-naming-convention 1.28.1-next.3 → 1.28.1-next.5

package/dist/index.d.mts

@@ -34,7 +34,7 @@ declare const _default: {
                             extensions?: readonly string[];
                             ignoreFilesWithoutCode?: boolean;
                         } | undefined], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
-                        readonly "use-state": _typescript_eslint_utils_ts_eslint.RuleModule<"unexpected", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
+                        readonly "use-state": _typescript_eslint_utils_ts_eslint.RuleModule<"badValueOrSetterName", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
                     };
                 };
             };
@@ -68,7 +68,7 @@ declare const _default: {
             extensions?: readonly string[];
             ignoreFilesWithoutCode?: boolean;
         } | undefined], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
-        readonly "use-state": _typescript_eslint_utils_ts_eslint.RuleModule<"unexpected", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
+        readonly "use-state": _typescript_eslint_utils_ts_eslint.RuleModule<"badValueOrSetterName", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
     };
 };
 

package/dist/index.d.ts

@@ -34,7 +34,7 @@ declare const _default: {
                             extensions?: readonly string[];
                             ignoreFilesWithoutCode?: boolean;
                         } | undefined], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
-                        readonly "use-state": _typescript_eslint_utils_ts_eslint.RuleModule<"unexpected", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
+                        readonly "use-state": _typescript_eslint_utils_ts_eslint.RuleModule<"badValueOrSetterName", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
                     };
                 };
             };
@@ -68,7 +68,7 @@ declare const _default: {
             extensions?: readonly string[];
             ignoreFilesWithoutCode?: boolean;
         } | undefined], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
-        readonly "use-state": _typescript_eslint_utils_ts_eslint.RuleModule<"unexpected", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
+        readonly "use-state": _typescript_eslint_utils_ts_eslint.RuleModule<"badValueOrSetterName", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
     };
 };
 

package/dist/index.js

@@ -8,6 +8,7 @@ var shared = require('@eslint-react/shared');
 var tsPattern = require('ts-pattern');
 var path = require('path');
 var stringTs = require('string-ts');
+var VAR = require('@eslint-react/var');
 var types = require('@typescript-eslint/types');
 
 function _interopDefault (e) { return e && e.__esModule ? e : { default: e }; }
@@ -33,6 +34,7 @@ function _interopNamespace(e) {
 var AST__namespace = /*#__PURE__*/_interopNamespace(AST);
 var JSX__namespace = /*#__PURE__*/_interopNamespace(JSX);
 var path__default = /*#__PURE__*/_interopDefault(path);
+var VAR__namespace = /*#__PURE__*/_interopNamespace(VAR);
 
 var __defProp = Object.defineProperty;
 var __export = (target, all) => {
@@ -51,7 +53,7 @@ var rules = {};
 
 // package.json
 var name2 = "eslint-plugin-react-naming-convention";
-var version = "1.28.1-next.3";
+var version = "1.28.1-next.5";
 var createRule = shared.createRuleForPlugin("naming-convention");
 
 // src/rules/component-name.ts
@@ -391,10 +393,6 @@ var RULE_NAME4 = "use-state";
 var RULE_FEATURES = [
   "CHK"
 ];
-function isSetterNameLoose(name3) {
-  const fourthChar = [...name3][3];
-  return name3.startsWith("set") && fourthChar === fourthChar?.toUpperCase();
-}
 var use_state_default = createRule({
   meta: {
     type: "problem",
@@ -403,65 +401,44 @@ var use_state_default = createRule({
       [Symbol.for("rule_features")]: RULE_FEATURES
     },
     messages: {
-      unexpected: "An useState call is not destructured into value + setter pair."
+      badValueOrSetterName: "An useState call is not destructured into value + setter pair."
     },
     schema: []
   },
   name: RULE_NAME4,
   create(context) {
-    const alias = shared.getSettingsFromContext(context).additionalHooks.useState ?? [];
-    const {
-      ctx,
-      listeners
-    } = core.useComponentCollector(
-      context,
-      {
-        collectDisplayName: false,
-        collectHookCalls: true,
-        hint: core.DEFAULT_COMPONENT_HINT
-      }
-    );
     return {
-      ...listeners,
-      "Program:exit"(node) {
-        const components = ctx.getAllComponents(node);
-        for (const { hookCalls } of components.values()) {
-          if (hookCalls.length === 0) {
-            continue;
-          }
-          for (const hookCall of hookCalls) {
-            if (!core.isUseStateCall(context, hookCall) && !alias.some(core.isReactHookCallWithNameLoose(hookCall))) {
-              continue;
-            }
-            if (hookCall.parent.type !== types.AST_NODE_TYPES.VariableDeclarator) {
-              continue;
-            }
-            const { id } = hookCall.parent;
-            switch (id.type) {
-              case types.AST_NODE_TYPES.Identifier: {
-                context.report({ messageId: "unexpected", node: id });
-                break;
-              }
-              case types.AST_NODE_TYPES.ArrayPattern: {
-                const [state, setState] = id.elements;
-                if (state?.type === types.AST_NODE_TYPES.ObjectPattern && setState?.type === types.AST_NODE_TYPES.Identifier) {
-                  if (!isSetterNameLoose(setState.name)) {
-                    context.report({ messageId: "unexpected", node: id });
-                  }
-                  break;
-                }
-                if (state?.type !== types.AST_NODE_TYPES.Identifier || setState?.type !== types.AST_NODE_TYPES.Identifier) {
-                  return;
-                }
-                const [stateName, setStateName] = [state.name, setState.name];
-                const expectedSetterName = `set${stringTs.capitalize(stateName)}`;
-                if (setStateName === expectedSetterName) {
-                  return;
-                }
-                context.report({ messageId: "unexpected", node: id });
-              }
+      "CallExpression[callee.name='useState']"(node) {
+        if (node.parent.type !== types.AST_NODE_TYPES.VariableDeclarator) {
+          context.report({ messageId: "badValueOrSetterName", node });
+        }
+        const id = VAR__namespace.getVariableId(node);
+        if (id?.type !== types.AST_NODE_TYPES.ArrayPattern) {
+          context.report({ messageId: "badValueOrSetterName", node });
+          return;
+        }
+        const [value, setter] = id.elements;
+        if (value == null || setter == null) {
+          context.report({ messageId: "badValueOrSetterName", node });
+          return;
+        }
+        const setterName = tsPattern.match(setter).with({ type: types.AST_NODE_TYPES.Identifier }, (id2) => id2.name).otherwise(() => eff._);
+        if (setterName == null || !setterName.startsWith("set")) {
+          context.report({ messageId: "badValueOrSetterName", node });
+          return;
+        }
+        const valueName = tsPattern.match(value).with({ type: types.AST_NODE_TYPES.Identifier }, (id2) => id2.name).with({ type: types.AST_NODE_TYPES.ObjectPattern }, ({ properties }) => {
+          const values = properties.reduce((acc, prop) => {
+            if (prop.type === types.AST_NODE_TYPES.Property && prop.key.type === types.AST_NODE_TYPES.Identifier) {
+              return [...acc, prop.key.name];
             }
-          }
+            return acc;
+          }, []);
+          return values.join("_");
+        }).otherwise(() => eff._);
+        if (valueName == null || `set_${valueName}` !== stringTs.snakeCase(setterName)) {
+          context.report({ messageId: "badValueOrSetterName", node });
+          return;
         }
       }
     };

package/dist/index.mjs

@@ -1,11 +1,12 @@
 import * as AST from '@eslint-react/ast';
-import { useComponentCollector, useComponentCollectorLegacy, DEFAULT_COMPONENT_HINT, isUseStateCall, isReactHookCallWithNameLoose } from '@eslint-react/core';
+import { useComponentCollector, useComponentCollectorLegacy } from '@eslint-react/core';
 import { isObject, _ } from '@eslint-react/eff';
 import * as JSX from '@eslint-react/jsx';
-import { createRuleForPlugin, getSettingsFromContext, RE_CONSTANT_CASE, RE_PASCAL_CASE, RE_CAMEL_CASE, RE_KEBAB_CASE, RE_SNAKE_CASE } from '@eslint-react/shared';
+import { createRuleForPlugin, RE_CONSTANT_CASE, RE_PASCAL_CASE, RE_CAMEL_CASE, RE_KEBAB_CASE, RE_SNAKE_CASE } from '@eslint-react/shared';
 import { match } from 'ts-pattern';
 import path from 'node:path';
-import { capitalize, pascalCase, camelCase, kebabCase, snakeCase } from 'string-ts';
+import { snakeCase, pascalCase, camelCase, kebabCase } from 'string-ts';
+import * as VAR from '@eslint-react/var';
 import { AST_NODE_TYPES } from '@typescript-eslint/types';
 
 var __defProp = Object.defineProperty;
@@ -25,7 +26,7 @@ var rules = {};
 
 // package.json
 var name2 = "eslint-plugin-react-naming-convention";
-var version = "1.28.1-next.3";
+var version = "1.28.1-next.5";
 var createRule = createRuleForPlugin("naming-convention");
 
 // src/rules/component-name.ts
@@ -365,10 +366,6 @@ var RULE_NAME4 = "use-state";
 var RULE_FEATURES = [
   "CHK"
 ];
-function isSetterNameLoose(name3) {
-  const fourthChar = [...name3][3];
-  return name3.startsWith("set") && fourthChar === fourthChar?.toUpperCase();
-}
 var use_state_default = createRule({
   meta: {
     type: "problem",
@@ -377,65 +374,44 @@ var use_state_default = createRule({
       [Symbol.for("rule_features")]: RULE_FEATURES
     },
     messages: {
-      unexpected: "An useState call is not destructured into value + setter pair."
+      badValueOrSetterName: "An useState call is not destructured into value + setter pair."
     },
     schema: []
   },
   name: RULE_NAME4,
   create(context) {
-    const alias = getSettingsFromContext(context).additionalHooks.useState ?? [];
-    const {
-      ctx,
-      listeners
-    } = useComponentCollector(
-      context,
-      {
-        collectDisplayName: false,
-        collectHookCalls: true,
-        hint: DEFAULT_COMPONENT_HINT
-      }
-    );
     return {
-      ...listeners,
-      "Program:exit"(node) {
-        const components = ctx.getAllComponents(node);
-        for (const { hookCalls } of components.values()) {
-          if (hookCalls.length === 0) {
-            continue;
-          }
-          for (const hookCall of hookCalls) {
-            if (!isUseStateCall(context, hookCall) && !alias.some(isReactHookCallWithNameLoose(hookCall))) {
-              continue;
-            }
-            if (hookCall.parent.type !== AST_NODE_TYPES.VariableDeclarator) {
-              continue;
-            }
-            const { id } = hookCall.parent;
-            switch (id.type) {
-              case AST_NODE_TYPES.Identifier: {
-                context.report({ messageId: "unexpected", node: id });
-                break;
-              }
-              case AST_NODE_TYPES.ArrayPattern: {
-                const [state, setState] = id.elements;
-                if (state?.type === AST_NODE_TYPES.ObjectPattern && setState?.type === AST_NODE_TYPES.Identifier) {
-                  if (!isSetterNameLoose(setState.name)) {
-                    context.report({ messageId: "unexpected", node: id });
-                  }
-                  break;
-                }
-                if (state?.type !== AST_NODE_TYPES.Identifier || setState?.type !== AST_NODE_TYPES.Identifier) {
-                  return;
-                }
-                const [stateName, setStateName] = [state.name, setState.name];
-                const expectedSetterName = `set${capitalize(stateName)}`;
-                if (setStateName === expectedSetterName) {
-                  return;
-                }
-                context.report({ messageId: "unexpected", node: id });
-              }
+      "CallExpression[callee.name='useState']"(node) {
+        if (node.parent.type !== AST_NODE_TYPES.VariableDeclarator) {
+          context.report({ messageId: "badValueOrSetterName", node });
+        }
+        const id = VAR.getVariableId(node);
+        if (id?.type !== AST_NODE_TYPES.ArrayPattern) {
+          context.report({ messageId: "badValueOrSetterName", node });
+          return;
+        }
+        const [value, setter] = id.elements;
+        if (value == null || setter == null) {
+          context.report({ messageId: "badValueOrSetterName", node });
+          return;
+        }
+        const setterName = match(setter).with({ type: AST_NODE_TYPES.Identifier }, (id2) => id2.name).otherwise(() => _);
+        if (setterName == null || !setterName.startsWith("set")) {
+          context.report({ messageId: "badValueOrSetterName", node });
+          return;
+        }
+        const valueName = match(value).with({ type: AST_NODE_TYPES.Identifier }, (id2) => id2.name).with({ type: AST_NODE_TYPES.ObjectPattern }, ({ properties }) => {
+          const values = properties.reduce((acc, prop) => {
+            if (prop.type === AST_NODE_TYPES.Property && prop.key.type === AST_NODE_TYPES.Identifier) {
+              return [...acc, prop.key.name];
             }
-          }
+            return acc;
+          }, []);
+          return values.join("_");
+        }).otherwise(() => _);
+        if (valueName == null || `set_${valueName}` !== snakeCase(setterName)) {
+          context.report({ messageId: "badValueOrSetterName", node });
+          return;
         }
       }
     };

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-naming-convention",
-  "version": "1.28.1-next.3",
+  "version": "1.28.1-next.5",
   "description": "ESLint React's ESLint plugin for naming convention related rules.",
   "keywords": [
     "react",
@@ -49,11 +49,12 @@
     "@typescript-eslint/utils": "^8.25.0",
     "string-ts": "^2.2.1",
     "ts-pattern": "^5.6.2",
-    "@eslint-react/ast": "1.28.1-next.3",
-    "@eslint-react/core": "1.28.1-next.3",
-    "@eslint-react/eff": "1.28.1-next.3",
-    "@eslint-react/jsx": "1.28.1-next.3",
-    "@eslint-react/shared": "1.28.1-next.3"
+    "@eslint-react/ast": "1.28.1-next.5",
+    "@eslint-react/core": "1.28.1-next.5",
+    "@eslint-react/jsx": "1.28.1-next.5",
+    "@eslint-react/var": "1.28.1-next.5",
+    "@eslint-react/shared": "1.28.1-next.5",
+    "@eslint-react/eff": "1.28.1-next.5"
   },
   "devDependencies": {
     "@types/react": "^19.0.10",