eslint-plugin-react-hooks 7.1.0-canary-93fc5740-20251113 → 7.1.0-canary-fb2177c1-20251114

package/cjs/eslint-plugin-react-hooks.development.js

@@ -22085,8 +22085,9 @@ const BuiltInStartTransitionId = 'BuiltInStartTransition';
 const BuiltInFireId = 'BuiltInFire';
 const BuiltInFireFunctionId = 'BuiltInFireFunction';
 const BuiltInUseEffectEventId = 'BuiltInUseEffectEvent';
-const BuiltinEffectEventId = 'BuiltInEffectEventFunction';
+const BuiltInEffectEventId = 'BuiltInEffectEventFunction';
 const BuiltInAutodepsId = 'BuiltInAutoDepsId';
+const BuiltInEventHandlerId = 'BuiltInEventHandlerId';
 const ReanimatedSharedValueId = 'ReanimatedSharedValueId';
 const BUILTIN_SHAPES = new Map();
 addObject(BUILTIN_SHAPES, BuiltInPropsId, [
@@ -22733,7 +22734,14 @@ addFunction(BUILTIN_SHAPES, [], {
     returnType: { kind: 'Poly' },
     calleeEffect: Effect.ConditionallyMutate,
     returnValueKind: ValueKind.Mutable,
-}, BuiltinEffectEventId);
+}, BuiltInEffectEventId);
+addFunction(BUILTIN_SHAPES, [], {
+    positionalParams: [],
+    restParam: Effect.ConditionallyMutate,
+    returnType: { kind: 'Poly' },
+    calleeEffect: Effect.ConditionallyMutate,
+    returnValueKind: ValueKind.Mutable,
+}, BuiltInEventHandlerId);
 addObject(BUILTIN_SHAPES, BuiltInMixedReadonlyId, [
     [
         'toString',
@@ -31121,7 +31129,7 @@ const REACT_APIS = [
             returnType: {
                 kind: 'Function',
                 return: { kind: 'Poly' },
-                shapeId: BuiltinEffectEventId,
+                shapeId: BuiltInEffectEventId,
                 isConstructor: false,
             },
             calleeEffect: Effect.Read,
@@ -32144,6 +32152,7 @@ const EnvironmentConfigSchema = v4.z.object({
     validateNoVoidUseMemo: v4.z.boolean().default(true),
     validateNoDynamicallyCreatedComponentsOrHooks: v4.z.boolean().default(false),
     enableAllowSetStateFromRefsInEffects: v4.z.boolean().default(true),
+    enableInferEventHandlers: v4.z.boolean().default(false),
 });
 class Environment {
     constructor(scope, fnType, compilerMode, config, contextIdentifiers, parentFunction, logger, filename, code, programContext) {
@@ -41052,6 +41061,7 @@ function applyEffect(context, state, _effect, initialized, effects) {
                 case ValueKind.Primitive: {
                     break;
                 }
+                case ValueKind.MaybeFrozen:
                 case ValueKind.Frozen: {
                     sourceType = 'frozen';
                     break;
@@ -48306,6 +48316,25 @@ function* generateInstructionTypes(env, names, instr) {
                     }
                 }
             }
+            if (env.config.enableInferEventHandlers) {
+                if (value.kind === 'JsxExpression' &&
+                    value.tag.kind === 'BuiltinTag' &&
+                    !value.tag.name.includes('-')) {
+                    for (const prop of value.props) {
+                        if (prop.kind === 'JsxAttribute' &&
+                            prop.name.startsWith('on') &&
+                            prop.name.length > 2 &&
+                            prop.name[2] === prop.name[2].toUpperCase()) {
+                            yield equation(prop.place.identifier.type, {
+                                kind: 'Function',
+                                shapeId: BuiltInEventHandlerId,
+                                return: makeType(),
+                                isConstructor: false,
+                            });
+                        }
+                    }
+                }
+            }
             yield equation(left, { kind: 'Object', shapeId: BuiltInJsxId });
             break;
         }
@@ -49229,6 +49258,10 @@ function refTypeOfType(place) {
         return { kind: 'None' };
     }
 }
+function isEventHandlerType(identifier) {
+    const type = identifier.type;
+    return type.kind === 'Function' && type.shapeId === BuiltInEventHandlerId;
+}
 function tyEqual(a, b) {
     if (a.kind !== b.kind) {
         return false;
@@ -49515,8 +49548,10 @@ function validateNoRefAccessInRenderImpl(fn, env) {
                         }
                         if (!didError) {
                             const isRefLValue = isUseRefType(instr.lvalue.identifier);
+                            const isEventHandlerLValue = isEventHandlerType(instr.lvalue.identifier);
                             for (const operand of eachInstructionValueOperand(instr.value)) {
                                 if (isRefLValue ||
+                                    isEventHandlerLValue ||
                                     (hookKind != null &&
                                         hookKind !== 'useState' &&
                                         hookKind !== 'useReducer')) {
@@ -52370,16 +52405,18 @@ function isNamedIdentifier(place) {
 }
 function validateNoDerivedComputationsInEffects_exp(fn) {
     const functions = new Map();
+    const candidateDependencies = new Map();
     const derivationCache = new DerivationCache();
     const errors = new CompilerError();
-    const effects = new Set();
+    const effectsCache = new Map();
     const setStateLoads = new Map();
     const setStateUsages = new Map();
     const context = {
         functions,
+        candidateDependencies,
         errors,
         derivationCache,
-        effects,
+        effectsCache,
         setStateLoads,
         setStateUsages,
     };
@@ -52416,8 +52453,8 @@ function validateNoDerivedComputationsInEffects_exp(fn) {
         }
         context.derivationCache.checkForChanges();
     } while (context.derivationCache.snapshot());
-    for (const effect of effects) {
-        validateEffect(effect, context);
+    for (const [, effect] of effectsCache) {
+        validateEffect(effect.effect, effect.dependencies, context);
     }
     return errors.asResult();
 }
@@ -52501,8 +52538,12 @@ function recordInstructionDerivations(instr, context, isFirstPass) {
             value.args[0].kind === 'Identifier' &&
             value.args[1].kind === 'Identifier') {
             const effectFunction = context.functions.get(value.args[0].identifier.id);
-            if (effectFunction != null) {
-                context.effects.add(effectFunction.loweredFunc.func);
+            const deps = context.candidateDependencies.get(value.args[1].identifier.id);
+            if (effectFunction != null && deps != null) {
+                context.effectsCache.set(value.args[0].identifier.id, {
+                    effect: effectFunction.loweredFunc.func,
+                    dependencies: deps,
+                });
             }
         }
         else if (isUseStateType(lvalue.identifier) && value.args.length > 0) {
@@ -52511,6 +52552,9 @@ function recordInstructionDerivations(instr, context, isFirstPass) {
             return;
         }
     }
+    else if (value.kind === 'ArrayExpression') {
+        context.candidateDependencies.set(lvalue.identifier.id, value);
+    }
     for (const operand of eachInstructionOperand(instr)) {
         if (context.setStateLoads.has(operand.identifier.id)) {
             const rootSetStateId = getRootSetState(operand.identifier.id, context.setStateLoads);
@@ -52667,11 +52711,19 @@ function getFnLocalDeps(fn) {
     }
     return deps;
 }
-function validateEffect(effectFunction, context) {
+function validateEffect(effectFunction, dependencies, context) {
     var _a;
     const seenBlocks = new Set();
     const effectDerivedSetStateCalls = [];
     const effectSetStateUsages = new Map();
+    for (const dep of dependencies.elements) {
+        if (dep.kind === 'Identifier') {
+            const root = getRootSetState(dep.identifier.id, context.setStateLoads);
+            if (root !== null) {
+                effectSetStateUsages.set(root, new Set([dep.loc]));
+            }
+        }
+    }
     let cleanUpFunctionDeps;
     const globals = new Set();
     for (const block of effectFunction.body.blocks.values()) {
@@ -52701,6 +52753,10 @@ function validateEffect(effectFunction, context) {
                 isSetStateType(instr.value.callee.identifier) &&
                 instr.value.args.length === 1 &&
                 instr.value.args[0].kind === 'Identifier') {
+                const calleeMetadata = context.derivationCache.cache.get(instr.value.callee.identifier.id);
+                if ((calleeMetadata === null || calleeMetadata === void 0 ? void 0 : calleeMetadata.typeOfValue) != 'fromState') {
+                    continue;
+                }
                 const argMetadata = context.derivationCache.cache.get(instr.value.args[0].identifier.id);
                 if (argMetadata !== undefined) {
                     effectDerivedSetStateCalls.push({

package/cjs/eslint-plugin-react-hooks.production.js

@@ -22076,8 +22076,9 @@ const BuiltInStartTransitionId = 'BuiltInStartTransition';
 const BuiltInFireId = 'BuiltInFire';
 const BuiltInFireFunctionId = 'BuiltInFireFunction';
 const BuiltInUseEffectEventId = 'BuiltInUseEffectEvent';
-const BuiltinEffectEventId = 'BuiltInEffectEventFunction';
+const BuiltInEffectEventId = 'BuiltInEffectEventFunction';
 const BuiltInAutodepsId = 'BuiltInAutoDepsId';
+const BuiltInEventHandlerId = 'BuiltInEventHandlerId';
 const ReanimatedSharedValueId = 'ReanimatedSharedValueId';
 const BUILTIN_SHAPES = new Map();
 addObject(BUILTIN_SHAPES, BuiltInPropsId, [
@@ -22724,7 +22725,14 @@ addFunction(BUILTIN_SHAPES, [], {
     returnType: { kind: 'Poly' },
     calleeEffect: Effect.ConditionallyMutate,
     returnValueKind: ValueKind.Mutable,
-}, BuiltinEffectEventId);
+}, BuiltInEffectEventId);
+addFunction(BUILTIN_SHAPES, [], {
+    positionalParams: [],
+    restParam: Effect.ConditionallyMutate,
+    returnType: { kind: 'Poly' },
+    calleeEffect: Effect.ConditionallyMutate,
+    returnValueKind: ValueKind.Mutable,
+}, BuiltInEventHandlerId);
 addObject(BUILTIN_SHAPES, BuiltInMixedReadonlyId, [
     [
         'toString',
@@ -30948,7 +30956,7 @@ const REACT_APIS = [
             returnType: {
                 kind: 'Function',
                 return: { kind: 'Poly' },
-                shapeId: BuiltinEffectEventId,
+                shapeId: BuiltInEffectEventId,
                 isConstructor: false,
             },
             calleeEffect: Effect.Read,
@@ -31971,6 +31979,7 @@ const EnvironmentConfigSchema = v4.z.object({
     validateNoVoidUseMemo: v4.z.boolean().default(true),
     validateNoDynamicallyCreatedComponentsOrHooks: v4.z.boolean().default(false),
     enableAllowSetStateFromRefsInEffects: v4.z.boolean().default(true),
+    enableInferEventHandlers: v4.z.boolean().default(false),
 });
 class Environment {
     constructor(scope, fnType, compilerMode, config, contextIdentifiers, parentFunction, logger, filename, code, programContext) {
@@ -40879,6 +40888,7 @@ function applyEffect(context, state, _effect, initialized, effects) {
                 case ValueKind.Primitive: {
                     break;
                 }
+                case ValueKind.MaybeFrozen:
                 case ValueKind.Frozen: {
                     sourceType = 'frozen';
                     break;
@@ -48133,6 +48143,25 @@ function* generateInstructionTypes(env, names, instr) {
                     }
                 }
             }
+            if (env.config.enableInferEventHandlers) {
+                if (value.kind === 'JsxExpression' &&
+                    value.tag.kind === 'BuiltinTag' &&
+                    !value.tag.name.includes('-')) {
+                    for (const prop of value.props) {
+                        if (prop.kind === 'JsxAttribute' &&
+                            prop.name.startsWith('on') &&
+                            prop.name.length > 2 &&
+                            prop.name[2] === prop.name[2].toUpperCase()) {
+                            yield equation(prop.place.identifier.type, {
+                                kind: 'Function',
+                                shapeId: BuiltInEventHandlerId,
+                                return: makeType(),
+                                isConstructor: false,
+                            });
+                        }
+                    }
+                }
+            }
             yield equation(left, { kind: 'Object', shapeId: BuiltInJsxId });
             break;
         }
@@ -49056,6 +49085,10 @@ function refTypeOfType(place) {
         return { kind: 'None' };
     }
 }
+function isEventHandlerType(identifier) {
+    const type = identifier.type;
+    return type.kind === 'Function' && type.shapeId === BuiltInEventHandlerId;
+}
 function tyEqual(a, b) {
     if (a.kind !== b.kind) {
         return false;
@@ -49342,8 +49375,10 @@ function validateNoRefAccessInRenderImpl(fn, env) {
                         }
                         if (!didError) {
                             const isRefLValue = isUseRefType(instr.lvalue.identifier);
+                            const isEventHandlerLValue = isEventHandlerType(instr.lvalue.identifier);
                             for (const operand of eachInstructionValueOperand(instr.value)) {
                                 if (isRefLValue ||
+                                    isEventHandlerLValue ||
                                     (hookKind != null &&
                                         hookKind !== 'useState' &&
                                         hookKind !== 'useReducer')) {
@@ -52197,16 +52232,18 @@ function isNamedIdentifier(place) {
 }
 function validateNoDerivedComputationsInEffects_exp(fn) {
     const functions = new Map();
+    const candidateDependencies = new Map();
     const derivationCache = new DerivationCache();
     const errors = new CompilerError();
-    const effects = new Set();
+    const effectsCache = new Map();
     const setStateLoads = new Map();
     const setStateUsages = new Map();
     const context = {
         functions,
+        candidateDependencies,
         errors,
         derivationCache,
-        effects,
+        effectsCache,
         setStateLoads,
         setStateUsages,
     };
@@ -52243,8 +52280,8 @@ function validateNoDerivedComputationsInEffects_exp(fn) {
         }
         context.derivationCache.checkForChanges();
     } while (context.derivationCache.snapshot());
-    for (const effect of effects) {
-        validateEffect(effect, context);
+    for (const [, effect] of effectsCache) {
+        validateEffect(effect.effect, effect.dependencies, context);
     }
     return errors.asResult();
 }
@@ -52328,8 +52365,12 @@ function recordInstructionDerivations(instr, context, isFirstPass) {
             value.args[0].kind === 'Identifier' &&
             value.args[1].kind === 'Identifier') {
             const effectFunction = context.functions.get(value.args[0].identifier.id);
-            if (effectFunction != null) {
-                context.effects.add(effectFunction.loweredFunc.func);
+            const deps = context.candidateDependencies.get(value.args[1].identifier.id);
+            if (effectFunction != null && deps != null) {
+                context.effectsCache.set(value.args[0].identifier.id, {
+                    effect: effectFunction.loweredFunc.func,
+                    dependencies: deps,
+                });
             }
         }
         else if (isUseStateType(lvalue.identifier) && value.args.length > 0) {
@@ -52338,6 +52379,9 @@ function recordInstructionDerivations(instr, context, isFirstPass) {
             return;
         }
     }
+    else if (value.kind === 'ArrayExpression') {
+        context.candidateDependencies.set(lvalue.identifier.id, value);
+    }
     for (const operand of eachInstructionOperand(instr)) {
         if (context.setStateLoads.has(operand.identifier.id)) {
             const rootSetStateId = getRootSetState(operand.identifier.id, context.setStateLoads);
@@ -52494,11 +52538,19 @@ function getFnLocalDeps(fn) {
     }
     return deps;
 }
-function validateEffect(effectFunction, context) {
+function validateEffect(effectFunction, dependencies, context) {
     var _a;
     const seenBlocks = new Set();
     const effectDerivedSetStateCalls = [];
     const effectSetStateUsages = new Map();
+    for (const dep of dependencies.elements) {
+        if (dep.kind === 'Identifier') {
+            const root = getRootSetState(dep.identifier.id, context.setStateLoads);
+            if (root !== null) {
+                effectSetStateUsages.set(root, new Set([dep.loc]));
+            }
+        }
+    }
     let cleanUpFunctionDeps;
     const globals = new Set();
     for (const block of effectFunction.body.blocks.values()) {
@@ -52528,6 +52580,10 @@ function validateEffect(effectFunction, context) {
                 isSetStateType(instr.value.callee.identifier) &&
                 instr.value.args.length === 1 &&
                 instr.value.args[0].kind === 'Identifier') {
+                const calleeMetadata = context.derivationCache.cache.get(instr.value.callee.identifier.id);
+                if ((calleeMetadata === null || calleeMetadata === void 0 ? void 0 : calleeMetadata.typeOfValue) != 'fromState') {
+                    continue;
+                }
                 const argMetadata = context.derivationCache.cache.get(instr.value.args[0].identifier.id);
                 if (argMetadata !== undefined) {
                     effectDerivedSetStateCalls.push({

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "eslint-plugin-react-hooks",
   "description": "ESLint rules for React Hooks",
-  "version": "7.1.0-canary-93fc5740-20251113",
+  "version": "7.1.0-canary-fb2177c1-20251114",
   "repository": {
     "type": "git",
     "url": "https://github.com/facebook/react.git",