eslint-plugin-react-hooks 7.1.0-canary-378973b3-20251205 → 7.1.0-canary-55480b4d-20251208

package/cjs/eslint-plugin-react-hooks.development.js

@@ -18033,7 +18033,8 @@ function printErrorSummary(category, message) {
         case ErrorCategory.Syntax:
         case ErrorCategory.UseMemo:
         case ErrorCategory.VoidUseMemo:
-        case ErrorCategory.MemoDependencies: {
+        case ErrorCategory.MemoDependencies:
+        case ErrorCategory.EffectExhaustiveDependencies: {
             heading = 'Error';
             break;
         }
@@ -18073,6 +18074,7 @@ var ErrorCategory;
     ErrorCategory["Globals"] = "Globals";
     ErrorCategory["Refs"] = "Refs";
     ErrorCategory["EffectDependencies"] = "EffectDependencies";
+    ErrorCategory["EffectExhaustiveDependencies"] = "EffectExhaustiveDependencies";
     ErrorCategory["EffectSetState"] = "EffectSetState";
     ErrorCategory["EffectDerivationsOfState"] = "EffectDerivationsOfState";
     ErrorCategory["ErrorBoundaries"] = "ErrorBoundaries";
@@ -18139,6 +18141,15 @@ function getRuleForCategoryImpl(category) {
                 preset: LintRulePreset.Off,
             };
         }
+        case ErrorCategory.EffectExhaustiveDependencies: {
+            return {
+                category,
+                severity: ErrorSeverity.Error,
+                name: 'exhaustive-effect-dependencies',
+                description: 'Validates that effect dependencies are exhaustive and without extraneous values',
+                preset: LintRulePreset.Off,
+            };
+        }
         case ErrorCategory.EffectDerivationsOfState: {
             return {
                 category,
@@ -18153,7 +18164,9 @@ function getRuleForCategoryImpl(category) {
                 category,
                 severity: ErrorSeverity.Error,
                 name: 'set-state-in-effect',
-                description: 'Validates against calling setState synchronously in an effect, which can lead to re-renders that degrade performance',
+                description: 'Validates against calling setState synchronously in an effect. ' +
+                    'This can indicate non-local derived data, a derived event pattern, or ' +
+                    'improper external data synchronization.',
                 preset: LintRulePreset.Recommended,
             };
         }
@@ -32206,6 +32219,7 @@ const EnvironmentConfigSchema = v4.z.object({
     enablePreserveExistingMemoizationGuarantees: v4.z.boolean().default(true),
     validatePreserveExistingMemoizationGuarantees: v4.z.boolean().default(true),
     validateExhaustiveMemoizationDependencies: v4.z.boolean().default(true),
+    validateExhaustiveEffectDependencies: v4.z.boolean().default(false),
     enablePreserveExistingManualUseMemo: v4.z.boolean().default(false),
     enableForest: v4.z.boolean().default(false),
     enableUseTypeAnnotations: v4.z.boolean().default(false),
@@ -32258,6 +32272,7 @@ const EnvironmentConfigSchema = v4.z.object({
     validateNoVoidUseMemo: v4.z.boolean().default(true),
     validateNoDynamicallyCreatedComponentsOrHooks: v4.z.boolean().default(false),
     enableAllowSetStateFromRefsInEffects: v4.z.boolean().default(true),
+    enableVerboseNoSetStateInEffect: v4.z.boolean().default(false),
     enableInferEventHandlers: v4.z.boolean().default(false),
 });
 class Environment {
@@ -33139,12 +33154,6 @@ function findDisjointMutableValues(fn) {
                 for (const operand of eachInstructionOperand(instr)) {
                     if (isMutable(instr, operand) &&
                         operand.identifier.mutableRange.start > 0) {
-                        if (instr.value.kind === 'FunctionExpression' ||
-                            instr.value.kind === 'ObjectMethod') {
-                            if (operand.identifier.type.kind === 'Primitive') {
-                                continue;
-                            }
-                        }
                         operands.push(operand.identifier);
                     }
                 }
@@ -51239,21 +51248,48 @@ function validateNoSetStateInEffects(fn, env) {
                         if (arg !== undefined && arg.kind === 'Identifier') {
                             const setState = setStateFunctions.get(arg.identifier.id);
                             if (setState !== undefined) {
-                                errors.pushDiagnostic(CompilerDiagnostic.create({
-                                    category: ErrorCategory.EffectSetState,
-                                    reason: 'Calling setState synchronously within an effect can trigger cascading renders',
-                                    description: 'Effects are intended to synchronize state between React and external systems such as manually updating the DOM, state management libraries, or other platform APIs. ' +
-                                        'In general, the body of an effect should do one or both of the following:\n' +
-                                        '* Update external systems with the latest state from React.\n' +
-                                        '* Subscribe for updates from some external system, calling setState in a callback function when external state changes.\n\n' +
-                                        'Calling setState synchronously within an effect body causes cascading renders that can hurt performance, and is not recommended. ' +
-                                        '(https://react.dev/learn/you-might-not-need-an-effect)',
-                                    suggestions: null,
-                                }).withDetails({
-                                    kind: 'error',
-                                    loc: setState.loc,
-                                    message: 'Avoid calling setState() directly within an effect',
-                                }));
+                                const enableVerbose = env.config.enableVerboseNoSetStateInEffect;
+                                if (enableVerbose) {
+                                    errors.pushDiagnostic(CompilerDiagnostic.create({
+                                        category: ErrorCategory.EffectSetState,
+                                        reason: 'Calling setState synchronously within an effect can trigger cascading renders',
+                                        description: 'Effects are intended to synchronize state between React and external systems. ' +
+                                            'Calling setState synchronously causes cascading renders that hurt performance.\n\n' +
+                                            'This pattern may indicate one of several issues:\n\n' +
+                                            '**1. Non-local derived data**: If the value being set could be computed from props/state ' +
+                                            'but requires data from a parent component, consider restructuring state ownership so the ' +
+                                            'derivation can happen during render in the component that owns the relevant state.\n\n' +
+                                            "**2. Derived event pattern**: If you're detecting when a prop changes (e.g., `isPlaying` " +
+                                            'transitioning from false to true), this often indicates the parent should provide an event ' +
+                                            'callback (like `onPlay`) instead of just the current state. Request access to the original event.\n\n' +
+                                            "**3. Force update / external sync**: If you're forcing a re-render to sync with an external " +
+                                            'data source (mutable values outside React), use `useSyncExternalStore` to properly subscribe ' +
+                                            'to external state changes.\n\n' +
+                                            'See: https://react.dev/learn/you-might-not-need-an-effect',
+                                        suggestions: null,
+                                    }).withDetails({
+                                        kind: 'error',
+                                        loc: setState.loc,
+                                        message: 'Avoid calling setState() directly within an effect',
+                                    }));
+                                }
+                                else {
+                                    errors.pushDiagnostic(CompilerDiagnostic.create({
+                                        category: ErrorCategory.EffectSetState,
+                                        reason: 'Calling setState synchronously within an effect can trigger cascading renders',
+                                        description: 'Effects are intended to synchronize state between React and external systems such as manually updating the DOM, state management libraries, or other platform APIs. ' +
+                                            'In general, the body of an effect should do one or both of the following:\n' +
+                                            '* Update external systems with the latest state from React.\n' +
+                                            '* Subscribe for updates from some external system, calling setState in a callback function when external state changes.\n\n' +
+                                            'Calling setState synchronously within an effect body causes cascading renders that can hurt performance, and is not recommended. ' +
+                                            '(https://react.dev/learn/you-might-not-need-an-effect)',
+                                        suggestions: null,
+                                    }).withDetails({
+                                        kind: 'error',
+                                        loc: setState.loc,
+                                        message: 'Avoid calling setState() directly within an effect',
+                                    }));
+                                }
                             }
                         }
                     }
@@ -53483,6 +53519,7 @@ function isKnownEventHandler(_tag, prop) {
 }
 
 function validateExhaustiveDependencies(fn) {
+    const env = fn.env;
     const reactive = collectReactiveIdentifiersHIR(fn);
     const temporaries = new Map();
     for (const param of fn.params) {
@@ -53507,215 +53544,259 @@ function validateExhaustiveDependencies(fn) {
         locals.clear();
     }
     function onFinishMemoize(value, dependencies, locals) {
-        var _b, _c, _d, _e, _f, _g, _h, _j;
+        var _a;
         CompilerError.simpleInvariant(startMemo != null && startMemo.manualMemoId === value.manualMemoId, {
             reason: 'Found FinishMemoize without corresponding StartMemoize',
             loc: value.loc,
         });
-        visitCandidateDependency(value.decl, temporaries, dependencies, locals);
-        const inferred = Array.from(dependencies);
-        inferred.sort((a, b) => {
-            var _a, _b;
-            if (a.kind === 'Global' && b.kind == 'Global') {
-                return a.binding.name.localeCompare(b.binding.name);
-            }
-            else if (a.kind == 'Local' && b.kind == 'Local') {
-                CompilerError.simpleInvariant(a.identifier.name != null &&
-                    a.identifier.name.kind === 'named' &&
-                    b.identifier.name != null &&
-                    b.identifier.name.kind === 'named', {
-                    reason: 'Expected dependencies to be named variables',
-                    loc: a.loc,
-                });
-                if (a.identifier.id !== b.identifier.id) {
-                    return a.identifier.name.value.localeCompare(b.identifier.name.value);
-                }
-                if (a.path.length !== b.path.length) {
-                    return a.path.length - b.path.length;
+        if (env.config.validateExhaustiveMemoizationDependencies) {
+            visitCandidateDependency(value.decl, temporaries, dependencies, locals);
+            const inferred = Array.from(dependencies);
+            const diagnostic = validateDependencies(inferred, (_a = startMemo.deps) !== null && _a !== void 0 ? _a : [], reactive, startMemo.depsLoc, ErrorCategory.MemoDependencies);
+            if (diagnostic != null) {
+                error.pushDiagnostic(diagnostic);
+            }
+        }
+        dependencies.clear();
+        locals.clear();
+        startMemo = null;
+    }
+    collectDependencies(fn, temporaries, {
+        onStartMemoize,
+        onFinishMemoize,
+        onEffect: (inferred, manual, manualMemoLoc) => {
+            if (env.config.validateExhaustiveEffectDependencies === false) {
+                return;
+            }
+            const manualDeps = [];
+            for (const dep of manual) {
+                if (dep.kind === 'Local') {
+                    manualDeps.push({
+                        root: {
+                            kind: 'NamedLocal',
+                            constant: false,
+                            value: {
+                                effect: Effect.Read,
+                                identifier: dep.identifier,
+                                kind: 'Identifier',
+                                loc: dep.loc,
+                                reactive: reactive.has(dep.identifier.id),
+                            },
+                        },
+                        path: dep.path,
+                        loc: dep.loc,
+                    });
                 }
-                for (let i = 0; i < a.path.length; i++) {
-                    const aProperty = a.path[i];
-                    const bProperty = b.path[i];
-                    const aOptional = aProperty.optional ? 0 : 1;
-                    const bOptional = bProperty.optional ? 0 : 1;
-                    if (aOptional !== bOptional) {
-                        return aOptional - bOptional;
-                    }
-                    else if (aProperty.property !== bProperty.property) {
-                        return String(aProperty.property).localeCompare(String(bProperty.property));
-                    }
+                else {
+                    manualDeps.push({
+                        root: {
+                            kind: 'Global',
+                            identifierName: dep.binding.name,
+                        },
+                        path: [],
+                        loc: GeneratedSource,
+                    });
                 }
-                return 0;
             }
-            else {
-                const aName = a.kind === 'Global' ? a.binding.name : (_a = a.identifier.name) === null || _a === void 0 ? void 0 : _a.value;
-                const bName = b.kind === 'Global' ? b.binding.name : (_b = b.identifier.name) === null || _b === void 0 ? void 0 : _b.value;
-                if (aName != null && bName != null) {
-                    return aName.localeCompare(bName);
-                }
-                return 0;
+            const diagnostic = validateDependencies(Array.from(inferred), manualDeps, reactive, manualMemoLoc, ErrorCategory.EffectExhaustiveDependencies);
+            if (diagnostic != null) {
+                error.pushDiagnostic(diagnostic);
             }
-        });
-        retainWhere(inferred, (dep, ix) => {
-            const match = inferred.findIndex(prevDep => {
-                return (isEqualTemporary(prevDep, dep) ||
-                    (prevDep.kind === 'Local' &&
-                        dep.kind === 'Local' &&
-                        prevDep.identifier.id === dep.identifier.id &&
-                        isSubPath(prevDep.path, dep.path)));
+        },
+    }, false);
+    return error.asResult();
+}
+function validateDependencies(inferred, manualDependencies, reactive, manualMemoLoc, category) {
+    var _a, _b, _c, _d;
+    inferred.sort((a, b) => {
+        var _a, _b;
+        if (a.kind === 'Global' && b.kind == 'Global') {
+            return a.binding.name.localeCompare(b.binding.name);
+        }
+        else if (a.kind == 'Local' && b.kind == 'Local') {
+            CompilerError.simpleInvariant(a.identifier.name != null &&
+                a.identifier.name.kind === 'named' &&
+                b.identifier.name != null &&
+                b.identifier.name.kind === 'named', {
+                reason: 'Expected dependencies to be named variables',
+                loc: a.loc,
             });
-            return match === -1 || match >= ix;
-        });
-        const manualDependencies = (_b = startMemo.deps) !== null && _b !== void 0 ? _b : [];
-        const matched = new Set();
-        const missing = [];
-        const extra = [];
-        for (const inferredDependency of inferred) {
-            if (inferredDependency.kind === 'Global') {
-                for (const manualDependency of manualDependencies) {
-                    if (manualDependency.root.kind === 'Global' &&
-                        manualDependency.root.identifierName ===
-                            inferredDependency.binding.name) {
-                        matched.add(manualDependency);
-                        extra.push(manualDependency);
-                    }
+            if (a.identifier.id !== b.identifier.id) {
+                return a.identifier.name.value.localeCompare(b.identifier.name.value);
+            }
+            if (a.path.length !== b.path.length) {
+                return a.path.length - b.path.length;
+            }
+            for (let i = 0; i < a.path.length; i++) {
+                const aProperty = a.path[i];
+                const bProperty = b.path[i];
+                const aOptional = aProperty.optional ? 0 : 1;
+                const bOptional = bProperty.optional ? 0 : 1;
+                if (aOptional !== bOptional) {
+                    return aOptional - bOptional;
+                }
+                else if (aProperty.property !== bProperty.property) {
+                    return String(aProperty.property).localeCompare(String(bProperty.property));
                 }
-                continue;
             }
-            CompilerError.simpleInvariant(inferredDependency.kind === 'Local', {
-                reason: 'Unexpected function dependency',
-                loc: value.loc,
-            });
-            let hasMatchingManualDependency = false;
+            return 0;
+        }
+        else {
+            const aName = a.kind === 'Global' ? a.binding.name : (_a = a.identifier.name) === null || _a === void 0 ? void 0 : _a.value;
+            const bName = b.kind === 'Global' ? b.binding.name : (_b = b.identifier.name) === null || _b === void 0 ? void 0 : _b.value;
+            if (aName != null && bName != null) {
+                return aName.localeCompare(bName);
+            }
+            return 0;
+        }
+    });
+    retainWhere(inferred, (dep, ix) => {
+        const match = inferred.findIndex(prevDep => {
+            return (isEqualTemporary(prevDep, dep) ||
+                (prevDep.kind === 'Local' &&
+                    dep.kind === 'Local' &&
+                    prevDep.identifier.id === dep.identifier.id &&
+                    isSubPath(prevDep.path, dep.path)));
+        });
+        return match === -1 || match >= ix;
+    });
+    const matched = new Set();
+    const missing = [];
+    const extra = [];
+    for (const inferredDependency of inferred) {
+        if (inferredDependency.kind === 'Global') {
             for (const manualDependency of manualDependencies) {
-                if (manualDependency.root.kind === 'NamedLocal' &&
-                    manualDependency.root.value.identifier.id ===
-                        inferredDependency.identifier.id &&
-                    (areEqualPaths(manualDependency.path, inferredDependency.path) ||
-                        isSubPathIgnoringOptionals(manualDependency.path, inferredDependency.path))) {
-                    hasMatchingManualDependency = true;
+                if (manualDependency.root.kind === 'Global' &&
+                    manualDependency.root.identifierName ===
+                        inferredDependency.binding.name) {
                     matched.add(manualDependency);
+                    extra.push(manualDependency);
                 }
             }
-            if (hasMatchingManualDependency ||
-                isOptionalDependency(inferredDependency, reactive)) {
-                continue;
-            }
-            missing.push(inferredDependency);
+            continue;
         }
-        for (const dep of (_c = startMemo.deps) !== null && _c !== void 0 ? _c : []) {
-            if (matched.has(dep)) {
-                continue;
-            }
-            if (dep.root.kind === 'NamedLocal' && dep.root.constant) {
-                CompilerError.simpleInvariant(!dep.root.value.reactive &&
-                    isPrimitiveType(dep.root.value.identifier), {
-                    reason: 'Expected constant-folded dependency to be non-reactive',
-                    loc: dep.root.value.loc,
-                });
-                continue;
+        CompilerError.simpleInvariant(inferredDependency.kind === 'Local', {
+            reason: 'Unexpected function dependency',
+            loc: inferredDependency.loc,
+        });
+        if (isEffectEventFunctionType(inferredDependency.identifier)) {
+            continue;
+        }
+        let hasMatchingManualDependency = false;
+        for (const manualDependency of manualDependencies) {
+            if (manualDependency.root.kind === 'NamedLocal' &&
+                manualDependency.root.value.identifier.id ===
+                    inferredDependency.identifier.id &&
+                (areEqualPaths(manualDependency.path, inferredDependency.path) ||
+                    isSubPathIgnoringOptionals(manualDependency.path, inferredDependency.path))) {
+                hasMatchingManualDependency = true;
+                matched.add(manualDependency);
             }
-            extra.push(dep);
-        }
-        if (missing.length !== 0 || extra.length !== 0) {
-            let suggestion = null;
-            if (startMemo.depsLoc != null && typeof startMemo.depsLoc !== 'symbol') {
-                suggestion = {
-                    description: 'Update dependencies',
-                    range: [startMemo.depsLoc.start.index, startMemo.depsLoc.end.index],
-                    op: CompilerSuggestionOperation.Replace,
-                    text: `[${inferred
-                        .filter(dep => dep.kind === 'Local' && !isOptionalDependency(dep, reactive))
-                        .map(printInferredDependency)
-                        .join(', ')}]`,
-                };
+        }
+        if (hasMatchingManualDependency ||
+            isOptionalDependency(inferredDependency, reactive)) {
+            continue;
+        }
+        missing.push(inferredDependency);
+    }
+    for (const dep of manualDependencies) {
+        if (matched.has(dep)) {
+            continue;
+        }
+        if (dep.root.kind === 'NamedLocal' && dep.root.constant) {
+            CompilerError.simpleInvariant(!dep.root.value.reactive && isPrimitiveType(dep.root.value.identifier), {
+                reason: 'Expected constant-folded dependency to be non-reactive',
+                loc: dep.root.value.loc,
+            });
+            continue;
+        }
+        extra.push(dep);
+    }
+    if (missing.length !== 0 || extra.length !== 0) {
+        let suggestion = null;
+        if (manualMemoLoc != null && typeof manualMemoLoc !== 'symbol') {
+            suggestion = {
+                description: 'Update dependencies',
+                range: [manualMemoLoc.start.index, manualMemoLoc.end.index],
+                op: CompilerSuggestionOperation.Replace,
+                text: `[${inferred
+                    .filter(dep => dep.kind === 'Local' &&
+                    !isOptionalDependency(dep, reactive) &&
+                    !isEffectEventFunctionType(dep.identifier))
+                    .map(printInferredDependency)
+                    .join(', ')}]`,
+            };
+        }
+        const diagnostic = createDiagnostic(category, missing, extra, suggestion);
+        for (const dep of missing) {
+            let reactiveStableValueHint = '';
+            if (isStableType(dep.identifier)) {
+                reactiveStableValueHint =
+                    '. Refs, setState functions, and other "stable" values generally do not need to be added ' +
+                        'as dependencies, but this variable may change over time to point to different values';
             }
-            const diagnostic = CompilerDiagnostic.create({
-                category: ErrorCategory.MemoDependencies,
-                reason: 'Found missing/extra memoization dependencies',
-                description: [
-                    missing.length !== 0
-                        ? 'Missing dependencies can cause a value to update less often than it should, ' +
-                            'resulting in stale UI'
-                        : null,
-                    extra.length !== 0
-                        ? 'Extra dependencies can cause a value to update more often than it should, ' +
-                            'resulting in performance problems such as excessive renders or effects firing too often'
-                        : null,
-                ]
-                    .filter(Boolean)
-                    .join('. '),
-                suggestions: suggestion != null ? [suggestion] : null,
+            diagnostic.withDetails({
+                kind: 'error',
+                message: `Missing dependency \`${printInferredDependency(dep)}\`${reactiveStableValueHint}`,
+                loc: dep.loc,
             });
-            for (const dep of missing) {
-                let reactiveStableValueHint = '';
-                if (isStableType(dep.identifier)) {
-                    reactiveStableValueHint =
-                        '. Refs, setState functions, and other "stable" values generally do not need to be added ' +
-                            'as dependencies, but this variable may change over time to point to different values';
-                }
+        }
+        for (const dep of extra) {
+            if (dep.root.kind === 'Global') {
                 diagnostic.withDetails({
                     kind: 'error',
-                    message: `Missing dependency \`${printInferredDependency(dep)}\`${reactiveStableValueHint}`,
-                    loc: dep.loc,
+                    message: `Unnecessary dependency \`${printManualMemoDependency(dep)}\`. ` +
+                        'Values declared outside of a component/hook should not be listed as ' +
+                        'dependencies as the component will not re-render if they change',
+                    loc: (_a = dep.loc) !== null && _a !== void 0 ? _a : manualMemoLoc,
                 });
             }
-            for (const dep of extra) {
-                if (dep.root.kind === 'Global') {
+            else {
+                const root = dep.root.value;
+                const matchingInferred = inferred.find((inferredDep) => {
+                    return (inferredDep.kind === 'Local' &&
+                        inferredDep.identifier.id === root.identifier.id &&
+                        isSubPathIgnoringOptionals(inferredDep.path, dep.path));
+                });
+                if (matchingInferred != null &&
+                    isEffectEventFunctionType(matchingInferred.identifier)) {
+                    diagnostic.withDetails({
+                        kind: 'error',
+                        message: `Functions returned from \`useEffectEvent\` must not be included in the dependency array. ` +
+                            `Remove \`${printManualMemoDependency(dep)}\` from the dependencies.`,
+                        loc: (_b = dep.loc) !== null && _b !== void 0 ? _b : manualMemoLoc,
+                    });
+                }
+                else if (matchingInferred != null &&
+                    !isOptionalDependency(matchingInferred, reactive)) {
                     diagnostic.withDetails({
                         kind: 'error',
-                        message: `Unnecessary dependency \`${printManualMemoDependency(dep)}\`. ` +
-                            'Values declared outside of a component/hook should not be listed as ' +
-                            'dependencies as the component will not re-render if they change',
-                        loc: (_e = (_d = dep.loc) !== null && _d !== void 0 ? _d : startMemo.depsLoc) !== null && _e !== void 0 ? _e : value.loc,
+                        message: `Overly precise dependency \`${printManualMemoDependency(dep)}\`, ` +
+                            `use \`${printInferredDependency(matchingInferred)}\` instead`,
+                        loc: (_c = dep.loc) !== null && _c !== void 0 ? _c : manualMemoLoc,
                     });
-                    error.pushDiagnostic(diagnostic);
                 }
                 else {
-                    const root = dep.root.value;
-                    const matchingInferred = inferred.find((inferredDep) => {
-                        return (inferredDep.kind === 'Local' &&
-                            inferredDep.identifier.id === root.identifier.id &&
-                            isSubPathIgnoringOptionals(inferredDep.path, dep.path));
+                    diagnostic.withDetails({
+                        kind: 'error',
+                        message: `Unnecessary dependency \`${printManualMemoDependency(dep)}\``,
+                        loc: (_d = dep.loc) !== null && _d !== void 0 ? _d : manualMemoLoc,
                     });
-                    if (matchingInferred != null &&
-                        !isOptionalDependency(matchingInferred, reactive)) {
-                        diagnostic.withDetails({
-                            kind: 'error',
-                            message: `Overly precise dependency \`${printManualMemoDependency(dep)}\`, ` +
-                                `use \`${printInferredDependency(matchingInferred)}\` instead`,
-                            loc: (_g = (_f = dep.loc) !== null && _f !== void 0 ? _f : startMemo.depsLoc) !== null && _g !== void 0 ? _g : value.loc,
-                        });
-                    }
-                    else {
-                        diagnostic.withDetails({
-                            kind: 'error',
-                            message: `Unnecessary dependency \`${printManualMemoDependency(dep)}\``,
-                            loc: (_j = (_h = dep.loc) !== null && _h !== void 0 ? _h : startMemo.depsLoc) !== null && _j !== void 0 ? _j : value.loc,
-                        });
-                    }
                 }
             }
-            if (suggestion != null) {
-                diagnostic.withDetails({
-                    kind: 'hint',
-                    message: `Inferred dependencies: \`${suggestion.text}\``,
-                });
-            }
-            error.pushDiagnostic(diagnostic);
         }
-        dependencies.clear();
-        locals.clear();
-        startMemo = null;
+        if (suggestion != null) {
+            diagnostic.withDetails({
+                kind: 'hint',
+                message: `Inferred dependencies: \`${suggestion.text}\``,
+            });
+        }
+        return diagnostic;
     }
-    collectDependencies(fn, temporaries, {
-        onStartMemoize,
-        onFinishMemoize,
-    }, false);
-    return error.asResult();
+    return null;
 }
 function addDependency(dep, dependencies, locals) {
-    if (dep.kind === 'Function') {
+    if (dep.kind === 'Aggregate') {
         for (const x of dep.dependencies) {
             addDependency(x, dependencies, locals);
         }
@@ -53734,7 +53815,7 @@ function visitCandidateDependency(place, temporaries, dependencies, locals) {
     }
 }
 function collectDependencies(fn, temporaries, callbacks, isFunctionExpression) {
-    var _a;
+    var _a, _b;
     const optionals = findOptionalPlaces(fn);
     const locals = new Set();
     if (isFunctionExpression) {
@@ -53749,20 +53830,20 @@ function collectDependencies(fn, temporaries, callbacks, isFunctionExpression) {
     }
     for (const block of fn.body.blocks.values()) {
         for (const phi of block.phis) {
-            let deps = null;
+            const deps = [];
             for (const operand of phi.operands.values()) {
                 const dep = temporaries.get(operand.identifier.id);
                 if (dep == null) {
                     continue;
                 }
-                if (deps == null) {
-                    deps = [dep];
+                if (dep.kind === 'Aggregate') {
+                    deps.push(...dep.dependencies);
                 }
                 else {
                     deps.push(dep);
                 }
             }
-            if (deps == null) {
+            if (deps.length === 0) {
                 continue;
             }
             else if (deps.length === 1) {
@@ -53770,7 +53851,7 @@ function collectDependencies(fn, temporaries, callbacks, isFunctionExpression) {
             }
             else {
                 temporaries.set(phi.place.identifier.id, {
-                    kind: 'Function',
+                    kind: 'Aggregate',
                     dependencies: new Set(deps),
                 });
             }
@@ -53787,9 +53868,6 @@ function collectDependencies(fn, temporaries, callbacks, isFunctionExpression) {
                 }
                 case 'LoadContext':
                 case 'LoadLocal': {
-                    if (locals.has(value.place.identifier.id)) {
-                        break;
-                    }
                     const temp = temporaries.get(value.place.identifier.id);
                     if (temp != null) {
                         if (temp.kind === 'Local') {
@@ -53799,6 +53877,9 @@ function collectDependencies(fn, temporaries, callbacks, isFunctionExpression) {
                         else {
                             temporaries.set(lvalue.identifier.id, temp);
                         }
+                        if (locals.has(value.place.identifier.id)) {
+                            locals.add(lvalue.identifier.id);
+                        }
                     }
                     break;
                 }
@@ -53927,9 +54008,41 @@ function collectDependencies(fn, temporaries, callbacks, isFunctionExpression) {
                     }
                     break;
                 }
+                case 'ArrayExpression': {
+                    const arrayDeps = new Set();
+                    for (const item of value.elements) {
+                        if (item.kind === 'Hole') {
+                            continue;
+                        }
+                        const place = item.kind === 'Identifier' ? item : item.place;
+                        visitCandidateDependency(place, temporaries, arrayDeps, new Set());
+                        visit(place);
+                    }
+                    temporaries.set(lvalue.identifier.id, {
+                        kind: 'Aggregate',
+                        dependencies: arrayDeps,
+                        loc: value.loc,
+                    });
+                    break;
+                }
+                case 'CallExpression':
                 case 'MethodCall': {
+                    const receiver = value.kind === 'CallExpression' ? value.callee : value.property;
+                    const onEffect = callbacks === null || callbacks === void 0 ? void 0 : callbacks.onEffect;
+                    if (onEffect != null && isEffectHook(receiver.identifier)) {
+                        const [fn, deps] = value.args;
+                        if ((fn === null || fn === void 0 ? void 0 : fn.kind) === 'Identifier' && (deps === null || deps === void 0 ? void 0 : deps.kind) === 'Identifier') {
+                            const fnDeps = temporaries.get(fn.identifier.id);
+                            const manualDeps = temporaries.get(deps.identifier.id);
+                            if ((fnDeps === null || fnDeps === void 0 ? void 0 : fnDeps.kind) === 'Aggregate' &&
+                                (manualDeps === null || manualDeps === void 0 ? void 0 : manualDeps.kind) === 'Aggregate') {
+                                onEffect(fnDeps.dependencies, manualDeps.dependencies, (_b = manualDeps.loc) !== null && _b !== void 0 ? _b : null);
+                            }
+                        }
+                    }
                     for (const operand of eachInstructionValueOperand(value)) {
-                        if (operand.identifier.id === value.property.identifier.id) {
+                        if (value.kind === 'MethodCall' &&
+                            operand.identifier.id === value.property.identifier.id) {
                             continue;
                         }
                         visit(operand);
@@ -53953,7 +54066,7 @@ function collectDependencies(fn, temporaries, callbacks, isFunctionExpression) {
             visit(operand);
         }
     }
-    return { kind: 'Function', dependencies };
+    return { kind: 'Aggregate', dependencies };
 }
 function printInferredDependency(dep) {
     switch (dep.kind) {
@@ -53986,7 +54099,7 @@ function printManualMemoDependency(dep) {
 }
 function isEqualTemporary(a, b) {
     switch (a.kind) {
-        case 'Function': {
+        case 'Aggregate': {
             return false;
         }
         case 'Global': {
@@ -54098,6 +54211,44 @@ function isOptionalDependency(inferredDependency, reactive) {
         (isStableType(inferredDependency.identifier) ||
             isPrimitiveType(inferredDependency.identifier)));
 }
+function createDiagnostic(category, missing, extra, suggestion) {
+    let reason;
+    let description;
+    function joinMissingExtraDetail(missingString, extraString, joinStr) {
+        return [
+            missing.length !== 0 ? missingString : null,
+            extra.length !== 0 ? extraString : null,
+        ]
+            .filter(Boolean)
+            .join(joinStr);
+    }
+    switch (category) {
+        case ErrorCategory.MemoDependencies: {
+            reason = `Found ${joinMissingExtraDetail('missing', 'extra', '/')} memoization dependencies`;
+            description = joinMissingExtraDetail('Missing dependencies can cause a value to update less often than it should, resulting in stale UI', 'Extra dependencies can cause a value to update more often than it should, resulting in performance' +
+                ' problems such as excessive renders or effects firing too often', '. ');
+            break;
+        }
+        case ErrorCategory.EffectExhaustiveDependencies: {
+            reason = `Found ${joinMissingExtraDetail('missing', 'extra', '/')} effect dependencies`;
+            description = joinMissingExtraDetail('Missing dependencies can cause an effect to fire less often than it should', 'Extra dependencies can cause an effect to fire more often than it should, resulting' +
+                ' in performance problems such as excessive renders and side effects', '. ');
+            break;
+        }
+        default: {
+            CompilerError.simpleInvariant(false, {
+                reason: `Unexpected error category: ${category}`,
+                loc: GeneratedSource,
+            });
+        }
+    }
+    return CompilerDiagnostic.create({
+        category,
+        reason,
+        description,
+        suggestions: suggestion != null ? [suggestion] : null,
+    });
+}
 
 function run(func, config, fnType, mode, programContext, logger, filename, code) {
     var _a, _b;
@@ -54225,7 +54376,8 @@ function runWithEnvironment(func, env) {
     inferReactivePlaces(hir);
     log({ kind: 'hir', name: 'InferReactivePlaces', value: hir });
     if (env.enableValidations) {
-        if (env.config.validateExhaustiveMemoizationDependencies) {
+        if (env.config.validateExhaustiveMemoizationDependencies ||
+            env.config.validateExhaustiveEffectDependencies) {
             validateExhaustiveDependencies(hir).unwrap();
         }
     }