npm - eslint-plugin-react-hooks - Versions diffs - 7.0.0-canary-f6a48828-20251019 → 7.0.0-canary-71b3a03c-20251021 - Mend

eslint-plugin-react-hooks 7.0.0-canary-f6a48828-20251019 → 7.0.0-canary-71b3a03c-20251021

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.

Files changed (3) hide show

package/cjs/eslint-plugin-react-hooks.development.js +15 -21
package/cjs/eslint-plugin-react-hooks.production.js +15 -21
package/package.json +1 -1

package/cjs/eslint-plugin-react-hooks.development.js CHANGED Viewed

@@ -24145,7 +24145,7 @@ function lowerObjectMethod(builder, property) {
     };
 }
 function lowerObjectPropertyKey(builder, property) {
-    var _a, _b;
+    var _a;
     const key = property.get('key');
     if (key.isStringLiteral()) {
         return {
@@ -24154,15 +24154,6 @@ function lowerObjectPropertyKey(builder, property) {
         };
     }
     else if (property.node.computed && key.isExpression()) {
-        if (!key.isIdentifier() && !key.isMemberExpression()) {
-            builder.errors.push({
-                reason: `(BuildHIR::lowerExpression) Expected Identifier, got ${key.type} key in ObjectExpression`,
-                category: ErrorCategory.Todo,
-                loc: (_a = key.node.loc) !== null && _a !== void 0 ? _a : null,
-                suggestions: null,
-            });
-            return null;
-        }
         const place = lowerExpressionToTemporary(builder, key);
         return {
             kind: 'computed',
@@ -24184,7 +24175,7 @@ function lowerObjectPropertyKey(builder, property) {
     builder.errors.push({
         reason: `(BuildHIR::lowerExpression) Expected Identifier, got ${key.type} key in ObjectExpression`,
         category: ErrorCategory.Todo,
-        loc: (_b = key.node.loc) !== null && _b !== void 0 ? _b : null,
+        loc: (_a = key.node.loc) !== null && _a !== void 0 ? _a : null,
         suggestions: null,
     });
     return null;
@@ -50387,21 +50378,24 @@ function validateUseMemo(fn) {
     return errors.asResult();
 }
 function validateNoContextVariableAssignment(fn, errors) {
+    const context = new Set(fn.context.map(place => place.identifier.id));
     for (const block of fn.body.blocks.values()) {
         for (const instr of block.instructions) {
             const value = instr.value;
             switch (value.kind) {
                 case 'StoreContext': {
-                    errors.pushDiagnostic(CompilerDiagnostic.create({
-                        category: ErrorCategory.UseMemo,
-                        reason: 'useMemo() callbacks may not reassign variables declared outside of the callback',
-                        description: 'useMemo() callbacks must be pure functions and cannot reassign variables defined outside of the callback function',
-                        suggestions: null,
-                    }).withDetails({
-                        kind: 'error',
-                        loc: value.lvalue.place.loc,
-                        message: 'Cannot reassign variable',
-                    }));
+                    if (context.has(value.lvalue.place.identifier.id)) {
+                        errors.pushDiagnostic(CompilerDiagnostic.create({
+                            category: ErrorCategory.UseMemo,
+                            reason: 'useMemo() callbacks may not reassign variables declared outside of the callback',
+                            description: 'useMemo() callbacks must be pure functions and cannot reassign variables defined outside of the callback function',
+                            suggestions: null,
+                        }).withDetails({
+                            kind: 'error',
+                            loc: value.lvalue.place.loc,
+                            message: 'Cannot reassign variable',
+                        }));
+                    }
                     break;
                 }
             }

package/cjs/eslint-plugin-react-hooks.production.js CHANGED Viewed

@@ -24136,7 +24136,7 @@ function lowerObjectMethod(builder, property) {
     };
 }
 function lowerObjectPropertyKey(builder, property) {
-    var _a, _b;
+    var _a;
     const key = property.get('key');
     if (key.isStringLiteral()) {
         return {
@@ -24145,15 +24145,6 @@ function lowerObjectPropertyKey(builder, property) {
         };
     }
     else if (property.node.computed && key.isExpression()) {
-        if (!key.isIdentifier() && !key.isMemberExpression()) {
-            builder.errors.push({
-                reason: `(BuildHIR::lowerExpression) Expected Identifier, got ${key.type} key in ObjectExpression`,
-                category: ErrorCategory.Todo,
-                loc: (_a = key.node.loc) !== null && _a !== void 0 ? _a : null,
-                suggestions: null,
-            });
-            return null;
-        }
         const place = lowerExpressionToTemporary(builder, key);
         return {
             kind: 'computed',
@@ -24175,7 +24166,7 @@ function lowerObjectPropertyKey(builder, property) {
     builder.errors.push({
         reason: `(BuildHIR::lowerExpression) Expected Identifier, got ${key.type} key in ObjectExpression`,
         category: ErrorCategory.Todo,
-        loc: (_b = key.node.loc) !== null && _b !== void 0 ? _b : null,
+        loc: (_a = key.node.loc) !== null && _a !== void 0 ? _a : null,
         suggestions: null,
     });
     return null;
@@ -50214,21 +50205,24 @@ function validateUseMemo(fn) {
     return errors.asResult();
 }
 function validateNoContextVariableAssignment(fn, errors) {
+    const context = new Set(fn.context.map(place => place.identifier.id));
     for (const block of fn.body.blocks.values()) {
         for (const instr of block.instructions) {
             const value = instr.value;
             switch (value.kind) {
                 case 'StoreContext': {
-                    errors.pushDiagnostic(CompilerDiagnostic.create({
-                        category: ErrorCategory.UseMemo,
-                        reason: 'useMemo() callbacks may not reassign variables declared outside of the callback',
-                        description: 'useMemo() callbacks must be pure functions and cannot reassign variables defined outside of the callback function',
-                        suggestions: null,
-                    }).withDetails({
-                        kind: 'error',
-                        loc: value.lvalue.place.loc,
-                        message: 'Cannot reassign variable',
-                    }));
+                    if (context.has(value.lvalue.place.identifier.id)) {
+                        errors.pushDiagnostic(CompilerDiagnostic.create({
+                            category: ErrorCategory.UseMemo,
+                            reason: 'useMemo() callbacks may not reassign variables declared outside of the callback',
+                            description: 'useMemo() callbacks must be pure functions and cannot reassign variables defined outside of the callback function',
+                            suggestions: null,
+                        }).withDetails({
+                            kind: 'error',
+                            loc: value.lvalue.place.loc,
+                            message: 'Cannot reassign variable',
+                        }));
+                    }
                     break;
                 }
             }

package/package.json CHANGED Viewed

@@ -1,7 +1,7 @@
 {
   "name": "eslint-plugin-react-hooks",
   "description": "ESLint rules for React Hooks",
-  "version": "7.0.0-canary-f6a48828-20251019",
+  "version": "7.0.0-canary-71b3a03c-20251021",
   "repository": {
     "type": "git",
     "url": "https://github.com/facebook/react.git",