eslint-plugin-react-hooks 6.1.0-canary-6de32a5a-20250822 → 6.1.0-canary-33a1095d-20250827

package/cjs/eslint-plugin-react-hooks.development.js

@@ -17993,14 +17993,20 @@ var ErrorCategory;
     ErrorCategory["Fire"] = "Fire";
     ErrorCategory["FBT"] = "FBT";
 })(ErrorCategory || (ErrorCategory = {}));
+const RULE_NAME_PATTERN = /^[a-z]+(-[a-z]+)*$/;
 function getRuleForCategory(category) {
+    const rule = getRuleForCategoryImpl(category);
+    invariant(RULE_NAME_PATTERN.test(rule.name), `Invalid rule name, got '${rule.name}' but rules must match ${RULE_NAME_PATTERN.toString()}`);
+    return rule;
+}
+function getRuleForCategoryImpl(category) {
     switch (category) {
         case ErrorCategory.AutomaticEffectDependencies: {
             return {
                 category,
                 name: 'automatic-effect-dependencies',
                 description: 'Verifies that automatic effect dependencies are compiled if opted-in',
-                recommended: true,
+                recommended: false,
             };
         }
         case ErrorCategory.CapitalizedCalls: {
@@ -18015,7 +18021,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'config',
-                description: 'Validates the configuration',
+                description: 'Validates the compiler configuration options',
                 recommended: true,
             };
         }
@@ -18039,7 +18045,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'set-state-in-effect',
-                description: 'Validates against calling setState synchronously in an effect',
+                description: 'Validates against calling setState synchronously in an effect, which can lead to re-renders that degrade performance',
                 recommended: true,
             };
         }
@@ -18047,7 +18053,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'error-boundaries',
-                description: 'Validates usage of error boundaries instead of try/catch for errors in JSX',
+                description: 'Validates usage of error boundaries instead of try/catch for errors in child components',
                 recommended: true,
             };
         }
@@ -18071,7 +18077,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'gating',
-                description: 'Validates configuration of gating mode',
+                description: 'Validates configuration of [gating mode](https://react.dev/reference/react-compiler/gating)',
                 recommended: true,
             };
         }
@@ -18079,7 +18085,8 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'globals',
-                description: 'Validates against assignment/mutation of globals during render',
+                description: 'Validates against assignment/mutation of globals during render, part of ensuring that ' +
+                    '[side effects must render outside of render](https://react.dev/reference/rules/components-and-hooks-must-be-pure#side-effects-must-run-outside-of-render)',
                 recommended: true,
             };
         }
@@ -18095,7 +18102,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'immutability',
-                description: 'Validates that immutable values (props, state, etc) are not mutated',
+                description: 'Validates against mutating props, state, and other values that [are immutable](https://react.dev/reference/rules/components-and-hooks-must-be-pure#props-and-state-are-immutable)',
                 recommended: true,
             };
         }
@@ -18111,7 +18118,9 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'preserve-manual-memoization',
-                description: 'Validates that existing manual memoized is preserved by the compiler',
+                description: 'Validates that existing manual memoized is preserved by the compiler. ' +
+                    'React Compiler will only compile components and hooks if its inference ' +
+                    '[matches or exceeds the existing manual memoization](https://react.dev/learn/react-compiler/introduction#what-should-i-do-about-usememo-usecallback-and-reactmemo)',
                 recommended: true,
             };
         }
@@ -18119,7 +18128,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'purity',
-                description: 'Validates that the component/hook is pure, and does not call known-impure functions',
+                description: 'Validates that [components/hooks are pure](https://react.dev/reference/rules/components-and-hooks-must-be-pure) by checking that they do not call known-impure functions',
                 recommended: true,
             };
         }
@@ -18127,7 +18136,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'refs',
-                description: 'Validates correct usage of refs, not reading/writing during render',
+                description: 'Validates correct usage of refs, not reading/writing during render. See the "pitfalls" section in [`useRef()` usage](https://react.dev/reference/react/useRef#usage)',
                 recommended: true,
             };
         }
@@ -18135,7 +18144,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'set-state-in-render',
-                description: 'Validates against setting state during render',
+                description: 'Validates against setting state during render, which can trigger additional renders and potential infinite render loops',
                 recommended: true,
             };
         }
@@ -18143,7 +18152,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'static-components',
-                description: 'Validates that components are static, not recreated every render',
+                description: 'Validates that components are static, not recreated every render. Components that are recreated dynamically can reset state and trigger excessive re-rendering',
                 recommended: true,
             };
         }
@@ -18175,7 +18184,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'unsupported-syntax',
-                description: 'Validates against syntax that we do not plan to support',
+                description: 'Validates against syntax that we do not plan to support in React Compiler',
                 recommended: true,
             };
         }
@@ -18183,7 +18192,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'use-memo',
-                description: 'Validates usage of the useMemo() hook',
+                description: 'Validates usage of the useMemo() hook against common mistakes. See [`useMemo()` docs](https://react.dev/reference/react/useMemo) for more information.',
                 recommended: true,
             };
         }
@@ -19458,7 +19467,8 @@ function printType(type) {
         return `:T${type.kind}<${type.shapeId}>`;
     }
     else if (type.kind === 'Function' && type.shapeId != null) {
-        return `:T${type.kind}<${type.shapeId}>`;
+        const returnType = printType(type.return);
+        return `:T${type.kind}<${type.shapeId}>()${returnType !== '' ? `:  ${returnType}` : ''}`;
     }
     else {
         return `:T${type.kind}`;
@@ -40443,6 +40453,18 @@ function computeSignatureForInstruction(context, env, instr) {
                         });
                     }
                 }
+                for (const prop of value.props) {
+                    if (prop.kind === 'JsxAttribute' &&
+                        prop.place.identifier.type.kind === 'Function' &&
+                        (isJsxType(prop.place.identifier.type.return) ||
+                            (prop.place.identifier.type.return.kind === 'Phi' &&
+                                prop.place.identifier.type.return.operands.some(operand => isJsxType(operand))))) {
+                        effects.push({
+                            kind: 'Render',
+                            place: prop.place,
+                        });
+                    }
+                }
             }
             break;
         }
@@ -46736,6 +46758,14 @@ class Unifier {
         if (type.kind === 'Phi') {
             return { kind: 'Phi', operands: type.operands.map(o => this.get(o)) };
         }
+        if (type.kind === 'Function') {
+            return {
+                kind: 'Function',
+                isConstructor: type.isConstructor,
+                shapeId: type.shapeId,
+                return: this.get(type.return),
+            };
+        }
         return type;
     }
 }

package/cjs/eslint-plugin-react-hooks.production.js

@@ -17984,14 +17984,20 @@ var ErrorCategory;
     ErrorCategory["Fire"] = "Fire";
     ErrorCategory["FBT"] = "FBT";
 })(ErrorCategory || (ErrorCategory = {}));
+const RULE_NAME_PATTERN = /^[a-z]+(-[a-z]+)*$/;
 function getRuleForCategory(category) {
+    const rule = getRuleForCategoryImpl(category);
+    invariant(RULE_NAME_PATTERN.test(rule.name), `Invalid rule name, got '${rule.name}' but rules must match ${RULE_NAME_PATTERN.toString()}`);
+    return rule;
+}
+function getRuleForCategoryImpl(category) {
     switch (category) {
         case ErrorCategory.AutomaticEffectDependencies: {
             return {
                 category,
                 name: 'automatic-effect-dependencies',
                 description: 'Verifies that automatic effect dependencies are compiled if opted-in',
-                recommended: true,
+                recommended: false,
             };
         }
         case ErrorCategory.CapitalizedCalls: {
@@ -18006,7 +18012,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'config',
-                description: 'Validates the configuration',
+                description: 'Validates the compiler configuration options',
                 recommended: true,
             };
         }
@@ -18030,7 +18036,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'set-state-in-effect',
-                description: 'Validates against calling setState synchronously in an effect',
+                description: 'Validates against calling setState synchronously in an effect, which can lead to re-renders that degrade performance',
                 recommended: true,
             };
         }
@@ -18038,7 +18044,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'error-boundaries',
-                description: 'Validates usage of error boundaries instead of try/catch for errors in JSX',
+                description: 'Validates usage of error boundaries instead of try/catch for errors in child components',
                 recommended: true,
             };
         }
@@ -18062,7 +18068,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'gating',
-                description: 'Validates configuration of gating mode',
+                description: 'Validates configuration of [gating mode](https://react.dev/reference/react-compiler/gating)',
                 recommended: true,
             };
         }
@@ -18070,7 +18076,8 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'globals',
-                description: 'Validates against assignment/mutation of globals during render',
+                description: 'Validates against assignment/mutation of globals during render, part of ensuring that ' +
+                    '[side effects must render outside of render](https://react.dev/reference/rules/components-and-hooks-must-be-pure#side-effects-must-run-outside-of-render)',
                 recommended: true,
             };
         }
@@ -18086,7 +18093,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'immutability',
-                description: 'Validates that immutable values (props, state, etc) are not mutated',
+                description: 'Validates against mutating props, state, and other values that [are immutable](https://react.dev/reference/rules/components-and-hooks-must-be-pure#props-and-state-are-immutable)',
                 recommended: true,
             };
         }
@@ -18102,7 +18109,9 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'preserve-manual-memoization',
-                description: 'Validates that existing manual memoized is preserved by the compiler',
+                description: 'Validates that existing manual memoized is preserved by the compiler. ' +
+                    'React Compiler will only compile components and hooks if its inference ' +
+                    '[matches or exceeds the existing manual memoization](https://react.dev/learn/react-compiler/introduction#what-should-i-do-about-usememo-usecallback-and-reactmemo)',
                 recommended: true,
             };
         }
@@ -18110,7 +18119,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'purity',
-                description: 'Validates that the component/hook is pure, and does not call known-impure functions',
+                description: 'Validates that [components/hooks are pure](https://react.dev/reference/rules/components-and-hooks-must-be-pure) by checking that they do not call known-impure functions',
                 recommended: true,
             };
         }
@@ -18118,7 +18127,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'refs',
-                description: 'Validates correct usage of refs, not reading/writing during render',
+                description: 'Validates correct usage of refs, not reading/writing during render. See the "pitfalls" section in [`useRef()` usage](https://react.dev/reference/react/useRef#usage)',
                 recommended: true,
             };
         }
@@ -18126,7 +18135,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'set-state-in-render',
-                description: 'Validates against setting state during render',
+                description: 'Validates against setting state during render, which can trigger additional renders and potential infinite render loops',
                 recommended: true,
             };
         }
@@ -18134,7 +18143,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'static-components',
-                description: 'Validates that components are static, not recreated every render',
+                description: 'Validates that components are static, not recreated every render. Components that are recreated dynamically can reset state and trigger excessive re-rendering',
                 recommended: true,
             };
         }
@@ -18166,7 +18175,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'unsupported-syntax',
-                description: 'Validates against syntax that we do not plan to support',
+                description: 'Validates against syntax that we do not plan to support in React Compiler',
                 recommended: true,
             };
         }
@@ -18174,7 +18183,7 @@ function getRuleForCategory(category) {
             return {
                 category,
                 name: 'use-memo',
-                description: 'Validates usage of the useMemo() hook',
+                description: 'Validates usage of the useMemo() hook against common mistakes. See [`useMemo()` docs](https://react.dev/reference/react/useMemo) for more information.',
                 recommended: true,
             };
         }
@@ -19449,7 +19458,8 @@ function printType(type) {
         return `:T${type.kind}<${type.shapeId}>`;
     }
     else if (type.kind === 'Function' && type.shapeId != null) {
-        return `:T${type.kind}<${type.shapeId}>`;
+        const returnType = printType(type.return);
+        return `:T${type.kind}<${type.shapeId}>()${returnType !== '' ? `:  ${returnType}` : ''}`;
     }
     else {
         return `:T${type.kind}`;
@@ -40270,6 +40280,18 @@ function computeSignatureForInstruction(context, env, instr) {
                         });
                     }
                 }
+                for (const prop of value.props) {
+                    if (prop.kind === 'JsxAttribute' &&
+                        prop.place.identifier.type.kind === 'Function' &&
+                        (isJsxType(prop.place.identifier.type.return) ||
+                            (prop.place.identifier.type.return.kind === 'Phi' &&
+                                prop.place.identifier.type.return.operands.some(operand => isJsxType(operand))))) {
+                        effects.push({
+                            kind: 'Render',
+                            place: prop.place,
+                        });
+                    }
+                }
             }
             break;
         }
@@ -46563,6 +46585,14 @@ class Unifier {
         if (type.kind === 'Phi') {
             return { kind: 'Phi', operands: type.operands.map(o => this.get(o)) };
         }
+        if (type.kind === 'Function') {
+            return {
+                kind: 'Function',
+                isConstructor: type.isConstructor,
+                shapeId: type.shapeId,
+                return: this.get(type.return),
+            };
+        }
         return type;
     }
 }

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "eslint-plugin-react-hooks",
   "description": "ESLint rules for React Hooks",
-  "version": "6.1.0-canary-6de32a5a-20250822",
+  "version": "6.1.0-canary-33a1095d-20250827",
   "repository": {
     "type": "git",
     "url": "https://github.com/facebook/react.git",
@@ -41,7 +41,7 @@
   "dependencies": {
     "@babel/core": "^7.24.4",
     "@babel/parser": "^7.24.4",
-    "@babel/plugin-transform-private-methods": "^7.24.4",
+    "@babel/plugin-proposal-private-methods": "^7.18.6",
     "hermes-parser": "^0.25.1",
     "zod": "^3.22.4",
     "zod-validation-error": "^3.0.3"