eslint-plugin-react-hooks-extra 1.53.1-next.0 → 1.53.1-next.2

package/dist/index.js

@@ -5,11 +5,13 @@ var __getOwnPropDesc = Object.getOwnPropertyDescriptor;
 var __getOwnPropNames = Object.getOwnPropertyNames;
 var __getProtoOf = Object.getPrototypeOf;
 var __hasOwnProp = Object.prototype.hasOwnProperty;
-var __export = (target, all) => {
+var __export = (all) => {
+	let target = {};
 	for (var name$2 in all) __defProp(target, name$2, {
 		get: all[name$2],
 		enumerable: true
 	});
+	return target;
 };
 var __copyProps = (to, from, except, desc) => {
 	if (from && typeof from === "object" || typeof from === "function") for (var keys = __getOwnPropNames(from), i = 0, n = keys.length, key; i < n; i++) {
@@ -27,18 +29,25 @@ var __toESM = (mod, isNodeMode, target) => (target = mod != null ? __create(__ge
 }) : target, mod));
 
 //#endregion
-const __eslint_react_shared = __toESM(require("@eslint-react/shared"));
-const __eslint_react_ast = __toESM(require("@eslint-react/ast"));
-const __eslint_react_core = __toESM(require("@eslint-react/core"));
-const __eslint_react_eff = __toESM(require("@eslint-react/eff"));
-const __eslint_react_var = __toESM(require("@eslint-react/var"));
-const __typescript_eslint_types = __toESM(require("@typescript-eslint/types"));
-const ts_pattern = __toESM(require("ts-pattern"));
-const __typescript_eslint_utils = __toESM(require("@typescript-eslint/utils"));
+let __eslint_react_shared = require("@eslint-react/shared");
+__eslint_react_shared = __toESM(__eslint_react_shared);
+let __eslint_react_ast = require("@eslint-react/ast");
+__eslint_react_ast = __toESM(__eslint_react_ast);
+let __eslint_react_core = require("@eslint-react/core");
+__eslint_react_core = __toESM(__eslint_react_core);
+let __eslint_react_eff = require("@eslint-react/eff");
+__eslint_react_eff = __toESM(__eslint_react_eff);
+let __eslint_react_var = require("@eslint-react/var");
+__eslint_react_var = __toESM(__eslint_react_var);
+let __typescript_eslint_types = require("@typescript-eslint/types");
+__typescript_eslint_types = __toESM(__typescript_eslint_types);
+let ts_pattern = require("ts-pattern");
+ts_pattern = __toESM(ts_pattern);
+let __typescript_eslint_utils = require("@typescript-eslint/utils");
+__typescript_eslint_utils = __toESM(__typescript_eslint_utils);
 
 //#region src/configs/recommended.ts
-var recommended_exports = {};
-__export(recommended_exports, {
+var recommended_exports = __export({
 	name: () => name$1,
 	rules: () => rules
 });
@@ -52,7 +61,7 @@ const rules = {
 //#endregion
 //#region package.json
 var name = "eslint-plugin-react-hooks-extra";
-var version = "1.53.1-next.0";
+var version = "1.53.1-next.2";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -97,24 +106,22 @@ function isSetFunctionCall(context, settings) {
 				const [index] = node.callee.arguments;
 				if (!isAt || index == null) return false;
 				const indexScope = context.sourceCode.getScope(node);
-				const indexValue = __eslint_react_var.toStaticValue({
+				return __eslint_react_var.toStaticValue({
 					kind: "lazy",
 					node: index,
 					initialScope: indexScope
-				}).value;
-				return indexValue === 1 && isIdFromUseStateCall(callee.object);
+				}).value === 1 && isIdFromUseStateCall(callee.object);
 			}
 			case __typescript_eslint_types.AST_NODE_TYPES.Identifier: return isIdFromUseStateCall(node.callee);
 			case __typescript_eslint_types.AST_NODE_TYPES.MemberExpression: {
 				if (!("name" in node.callee.object)) return false;
 				const property = node.callee.property;
 				const propertyScope = context.sourceCode.getScope(node);
-				const propertyValue = __eslint_react_var.toStaticValue({
+				return __eslint_react_var.toStaticValue({
 					kind: "lazy",
 					node: property,
 					initialScope: propertyScope
-				}).value;
-				return propertyValue === 1 && isIdFromUseStateCall(node.callee.object);
+				}).value === 1 && isIdFromUseStateCall(node.callee.object);
 			}
 			default: return false;
 		}
@@ -365,18 +372,16 @@ function create$3(context) {
 		if (!__eslint_react_core.isReactHookCall(node)) return;
 		const initialScope = context.sourceCode.getScope(node);
 		if (!isUseCallbackCall(node)) return;
-		const scope = context.sourceCode.getScope(node);
-		const component = scope.block;
+		const component = context.sourceCode.getScope(node).block;
 		if (!__eslint_react_ast.isFunction(component)) return;
 		const [arg0, arg1] = node.arguments;
 		if (arg0 == null || arg1 == null) return;
-		const hasEmptyDeps = (0, ts_pattern.match)(arg1).with({ type: __typescript_eslint_types.AST_NODE_TYPES.ArrayExpression }, (n) => n.elements.length === 0).with({ type: __typescript_eslint_types.AST_NODE_TYPES.Identifier }, (n) => {
+		if (!(0, ts_pattern.match)(arg1).with({ type: __typescript_eslint_types.AST_NODE_TYPES.ArrayExpression }, (n) => n.elements.length === 0).with({ type: __typescript_eslint_types.AST_NODE_TYPES.Identifier }, (n) => {
 			const variable = __eslint_react_var.findVariable(n.name, initialScope);
 			const variableNode = __eslint_react_var.getVariableInitNode(variable, 0);
 			if (variableNode?.type !== __typescript_eslint_types.AST_NODE_TYPES.ArrayExpression) return false;
 			return variableNode.elements.length === 0;
-		}).otherwise(() => false);
-		if (!hasEmptyDeps) return;
+		}).otherwise(() => false)) return;
 		const arg0Node = (0, ts_pattern.match)(arg0).with({ type: __typescript_eslint_types.AST_NODE_TYPES.ArrowFunctionExpression }, (n) => {
 			if (n.body.type === __typescript_eslint_types.AST_NODE_TYPES.ArrowFunctionExpression) return n.body;
 			return n;
@@ -388,9 +393,7 @@ function create$3(context) {
 		}).otherwise(() => null);
 		if (arg0Node == null) return;
 		const arg0NodeScope = context.sourceCode.getScope(arg0Node);
-		const arg0NodeReferences = __eslint_react_var.getChidScopes(arg0NodeScope).flatMap((x) => x.references);
-		const isReferencedToComponentScope = arg0NodeReferences.some((x) => x.resolved?.scope.block === component);
-		if (!isReferencedToComponentScope) context.report({
+		if (!__eslint_react_var.getChidScopes(arg0NodeScope).flatMap((x) => x.references).some((x) => x.resolved?.scope.block === component)) context.report({
 			messageId: "noUnnecessaryUseCallback",
 			node
 		});
@@ -423,20 +426,17 @@ function create$2(context) {
 		if (!__eslint_react_core.isReactHookCall(node)) return;
 		const initialScope = context.sourceCode.getScope(node);
 		if (!isUseMemoCall(node)) return;
-		const scope = context.sourceCode.getScope(node);
-		const component = scope.block;
+		const component = context.sourceCode.getScope(node).block;
 		if (!__eslint_react_ast.isFunction(component)) return;
 		const [arg0, arg1] = node.arguments;
 		if (arg0 == null || arg1 == null) return;
-		const hasCallInArg0 = __eslint_react_ast.isFunction(arg0) && [...__eslint_react_ast.getNestedCallExpressions(arg0.body), ...__eslint_react_ast.getNestedNewExpressions(arg0.body)].length > 0;
-		if (hasCallInArg0) return;
-		const hasEmptyDeps = (0, ts_pattern.match)(arg1).with({ type: __typescript_eslint_types.AST_NODE_TYPES.ArrayExpression }, (n) => n.elements.length === 0).with({ type: __typescript_eslint_types.AST_NODE_TYPES.Identifier }, (n) => {
+		if (__eslint_react_ast.isFunction(arg0) && [...__eslint_react_ast.getNestedCallExpressions(arg0.body), ...__eslint_react_ast.getNestedNewExpressions(arg0.body)].length > 0) return;
+		if (!(0, ts_pattern.match)(arg1).with({ type: __typescript_eslint_types.AST_NODE_TYPES.ArrayExpression }, (n) => n.elements.length === 0).with({ type: __typescript_eslint_types.AST_NODE_TYPES.Identifier }, (n) => {
 			const variable = __eslint_react_var.findVariable(n.name, initialScope);
 			const variableNode = __eslint_react_var.getVariableInitNode(variable, 0);
 			if (variableNode?.type !== __typescript_eslint_types.AST_NODE_TYPES.ArrayExpression) return false;
 			return variableNode.elements.length === 0;
-		}).otherwise(() => false);
-		if (!hasEmptyDeps) return;
+		}).otherwise(() => false)) return;
 		const arg0Node = (0, ts_pattern.match)(arg0).with({ type: __typescript_eslint_types.AST_NODE_TYPES.ArrowFunctionExpression }, (n) => {
 			if (n.body.type === __typescript_eslint_types.AST_NODE_TYPES.ArrowFunctionExpression) return n.body;
 			return n;
@@ -448,9 +448,7 @@ function create$2(context) {
 		}).otherwise(() => null);
 		if (arg0Node == null) return;
 		const arg0NodeScope = context.sourceCode.getScope(arg0Node);
-		const arg0NodeReferences = __eslint_react_var.getChidScopes(arg0NodeScope).flatMap((x) => x.references);
-		const isReferencedToComponentScope = arg0NodeReferences.some((x) => x.resolved?.scope.block === component);
-		if (!isReferencedToComponentScope) context.report({
+		if (!__eslint_react_var.getChidScopes(arg0NodeScope).flatMap((x) => x.references).some((x) => x.resolved?.scope.block === component)) context.report({
 			messageId: "noUnnecessaryUseMemo",
 			node
 		});

package/dist/index.mjs

@@ -9,17 +9,18 @@ import { ESLintUtils } from "@typescript-eslint/utils";
 
 //#region rolldown:runtime
 var __defProp = Object.defineProperty;
-var __export = (target, all) => {
+var __export = (all) => {
+	let target = {};
 	for (var name$2 in all) __defProp(target, name$2, {
 		get: all[name$2],
 		enumerable: true
 	});
+	return target;
 };
 
 //#endregion
 //#region src/configs/recommended.ts
-var recommended_exports = {};
-__export(recommended_exports, {
+var recommended_exports = __export({
 	name: () => name$1,
 	rules: () => rules
 });
@@ -33,7 +34,7 @@ const rules = {
 //#endregion
 //#region package.json
 var name = "eslint-plugin-react-hooks-extra";
-var version = "1.53.1-next.0";
+var version = "1.53.1-next.2";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -78,24 +79,22 @@ function isSetFunctionCall(context, settings) {
 				const [index] = node.callee.arguments;
 				if (!isAt || index == null) return false;
 				const indexScope = context.sourceCode.getScope(node);
-				const indexValue = VAR.toStaticValue({
+				return VAR.toStaticValue({
 					kind: "lazy",
 					node: index,
 					initialScope: indexScope
-				}).value;
-				return indexValue === 1 && isIdFromUseStateCall(callee.object);
+				}).value === 1 && isIdFromUseStateCall(callee.object);
 			}
 			case AST_NODE_TYPES.Identifier: return isIdFromUseStateCall(node.callee);
 			case AST_NODE_TYPES.MemberExpression: {
 				if (!("name" in node.callee.object)) return false;
 				const property = node.callee.property;
 				const propertyScope = context.sourceCode.getScope(node);
-				const propertyValue = VAR.toStaticValue({
+				return VAR.toStaticValue({
 					kind: "lazy",
 					node: property,
 					initialScope: propertyScope
-				}).value;
-				return propertyValue === 1 && isIdFromUseStateCall(node.callee.object);
+				}).value === 1 && isIdFromUseStateCall(node.callee.object);
 			}
 			default: return false;
 		}
@@ -346,18 +345,16 @@ function create$3(context) {
 		if (!ER.isReactHookCall(node)) return;
 		const initialScope = context.sourceCode.getScope(node);
 		if (!isUseCallbackCall(node)) return;
-		const scope = context.sourceCode.getScope(node);
-		const component = scope.block;
+		const component = context.sourceCode.getScope(node).block;
 		if (!AST.isFunction(component)) return;
 		const [arg0, arg1] = node.arguments;
 		if (arg0 == null || arg1 == null) return;
-		const hasEmptyDeps = match(arg1).with({ type: AST_NODE_TYPES.ArrayExpression }, (n) => n.elements.length === 0).with({ type: AST_NODE_TYPES.Identifier }, (n) => {
+		if (!match(arg1).with({ type: AST_NODE_TYPES.ArrayExpression }, (n) => n.elements.length === 0).with({ type: AST_NODE_TYPES.Identifier }, (n) => {
 			const variable = VAR.findVariable(n.name, initialScope);
 			const variableNode = VAR.getVariableInitNode(variable, 0);
 			if (variableNode?.type !== AST_NODE_TYPES.ArrayExpression) return false;
 			return variableNode.elements.length === 0;
-		}).otherwise(() => false);
-		if (!hasEmptyDeps) return;
+		}).otherwise(() => false)) return;
 		const arg0Node = match(arg0).with({ type: AST_NODE_TYPES.ArrowFunctionExpression }, (n) => {
 			if (n.body.type === AST_NODE_TYPES.ArrowFunctionExpression) return n.body;
 			return n;
@@ -369,9 +366,7 @@ function create$3(context) {
 		}).otherwise(() => null);
 		if (arg0Node == null) return;
 		const arg0NodeScope = context.sourceCode.getScope(arg0Node);
-		const arg0NodeReferences = VAR.getChidScopes(arg0NodeScope).flatMap((x) => x.references);
-		const isReferencedToComponentScope = arg0NodeReferences.some((x) => x.resolved?.scope.block === component);
-		if (!isReferencedToComponentScope) context.report({
+		if (!VAR.getChidScopes(arg0NodeScope).flatMap((x) => x.references).some((x) => x.resolved?.scope.block === component)) context.report({
 			messageId: "noUnnecessaryUseCallback",
 			node
 		});
@@ -404,20 +399,17 @@ function create$2(context) {
 		if (!ER.isReactHookCall(node)) return;
 		const initialScope = context.sourceCode.getScope(node);
 		if (!isUseMemoCall(node)) return;
-		const scope = context.sourceCode.getScope(node);
-		const component = scope.block;
+		const component = context.sourceCode.getScope(node).block;
 		if (!AST.isFunction(component)) return;
 		const [arg0, arg1] = node.arguments;
 		if (arg0 == null || arg1 == null) return;
-		const hasCallInArg0 = AST.isFunction(arg0) && [...AST.getNestedCallExpressions(arg0.body), ...AST.getNestedNewExpressions(arg0.body)].length > 0;
-		if (hasCallInArg0) return;
-		const hasEmptyDeps = match(arg1).with({ type: AST_NODE_TYPES.ArrayExpression }, (n) => n.elements.length === 0).with({ type: AST_NODE_TYPES.Identifier }, (n) => {
+		if (AST.isFunction(arg0) && [...AST.getNestedCallExpressions(arg0.body), ...AST.getNestedNewExpressions(arg0.body)].length > 0) return;
+		if (!match(arg1).with({ type: AST_NODE_TYPES.ArrayExpression }, (n) => n.elements.length === 0).with({ type: AST_NODE_TYPES.Identifier }, (n) => {
 			const variable = VAR.findVariable(n.name, initialScope);
 			const variableNode = VAR.getVariableInitNode(variable, 0);
 			if (variableNode?.type !== AST_NODE_TYPES.ArrayExpression) return false;
 			return variableNode.elements.length === 0;
-		}).otherwise(() => false);
-		if (!hasEmptyDeps) return;
+		}).otherwise(() => false)) return;
 		const arg0Node = match(arg0).with({ type: AST_NODE_TYPES.ArrowFunctionExpression }, (n) => {
 			if (n.body.type === AST_NODE_TYPES.ArrowFunctionExpression) return n.body;
 			return n;
@@ -429,9 +421,7 @@ function create$2(context) {
 		}).otherwise(() => null);
 		if (arg0Node == null) return;
 		const arg0NodeScope = context.sourceCode.getScope(arg0Node);
-		const arg0NodeReferences = VAR.getChidScopes(arg0NodeScope).flatMap((x) => x.references);
-		const isReferencedToComponentScope = arg0NodeReferences.some((x) => x.resolved?.scope.block === component);
-		if (!isReferencedToComponentScope) context.report({
+		if (!VAR.getChidScopes(arg0NodeScope).flatMap((x) => x.references).some((x) => x.resolved?.scope.block === component)) context.report({
 			messageId: "noUnnecessaryUseMemo",
 			node
 		});

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-hooks-extra",
-  "version": "1.53.1-next.0",
+  "version": "1.53.1-next.2",
   "description": "ESLint React's ESLint plugin for React Hooks related rules.",
   "keywords": [
     "react",
@@ -44,23 +44,23 @@
     "./package.json"
   ],
   "dependencies": {
-    "@typescript-eslint/scope-manager": "^8.42.0",
-    "@typescript-eslint/type-utils": "^8.42.0",
-    "@typescript-eslint/types": "^8.42.0",
-    "@typescript-eslint/utils": "^8.42.0",
+    "@typescript-eslint/scope-manager": "^8.43.0",
+    "@typescript-eslint/type-utils": "^8.43.0",
+    "@typescript-eslint/types": "^8.43.0",
+    "@typescript-eslint/utils": "^8.43.0",
     "string-ts": "^2.2.1",
     "ts-pattern": "^5.8.0",
-    "@eslint-react/ast": "1.53.1-next.0",
-    "@eslint-react/core": "1.53.1-next.0",
-    "@eslint-react/eff": "1.53.1-next.0",
-    "@eslint-react/kit": "1.53.1-next.0",
-    "@eslint-react/shared": "1.53.1-next.0",
-    "@eslint-react/var": "1.53.1-next.0"
+    "@eslint-react/ast": "1.53.1-next.2",
+    "@eslint-react/eff": "1.53.1-next.2",
+    "@eslint-react/core": "1.53.1-next.2",
+    "@eslint-react/kit": "1.53.1-next.2",
+    "@eslint-react/var": "1.53.1-next.2",
+    "@eslint-react/shared": "1.53.1-next.2"
   },
   "devDependencies": {
     "@types/react": "^19.1.12",
     "@types/react-dom": "^19.1.9",
-    "tsdown": "^0.14.2",
+    "tsdown": "^0.15.0",
     "@local/configs": "0.0.0"
   },
   "peerDependencies": {