eslint-plugin-react-hooks-extra 1.37.1-next.3 → 1.37.1-next.5

package/dist/index.js

@@ -49,7 +49,7 @@ var rules = {
 
 // package.json
 var name2 = "eslint-plugin-react-hooks-extra";
-var version = "1.37.1-next.3";
+var version = "1.37.1-next.5";
 var createRule = shared.createRuleForPlugin("hooks-extra");
 function isFromHookCall(context, name3, settings, predicate = eff.constTrue) {
   const hookAlias = settings.additionalHooks[name3] ?? [];
@@ -319,7 +319,7 @@ var no_direct_set_state_in_use_effect_default = createRule({
   meta: {
     type: "problem",
     docs: {
-      description: "disallow direct calls to the 'set' function of 'useState' in 'useEffect'",
+      description: "Disallow direct calls to the `set` function of `useState` in `useEffect`.",
       [Symbol.for("rule_features")]: RULE_FEATURES
     },
     messages: {
@@ -348,7 +348,7 @@ var no_direct_set_state_in_use_layout_effect_default = createRule({
   meta: {
     type: "problem",
     docs: {
-      description: "disallow direct calls to the 'set' function of 'useState' in 'useLayoutEffect'",
+      description: "Disallow direct calls to the `set` function of `useState` in `useLayoutEffect`.",
       [Symbol.for("rule_features")]: RULE_FEATURES2
     },
     messages: {
@@ -375,7 +375,7 @@ var no_unnecessary_use_callback_default = createRule({
   meta: {
     type: "problem",
     docs: {
-      description: "disallow unnecessary usage of 'useCallback'",
+      description: "Disallow unnecessary usage of `useCallback`.",
       [Symbol.for("rule_features")]: RULE_FEATURES3
     },
     messages: {
@@ -451,7 +451,7 @@ var no_unnecessary_use_memo_default = createRule({
   meta: {
     type: "problem",
     docs: {
-      description: "disallow unnecessary usage of 'useMemo'",
+      description: "Disallow unnecessary usage of `useMemo`.",
       [Symbol.for("rule_features")]: RULE_FEATURES4
     },
     messages: {
@@ -534,7 +534,7 @@ var no_unnecessary_use_prefix_default = createRule({
   meta: {
     type: "problem",
     docs: {
-      description: "enforce that a function with the 'use' prefix should use at least one Hook inside of it",
+      description: "Enforces that a function with the `use` prefix should use at least one Hook inside of it.",
       [Symbol.for("rule_features")]: RULE_FEATURES5
     },
     messages: {
@@ -580,14 +580,11 @@ var ALLOW_LIST = [
   "String",
   "Number"
 ];
-function isAllowedName(name3) {
-  return ALLOW_LIST.includes(name3) || core.isReactHookName(name3);
-}
 var prefer_use_state_lazy_initialization_default = createRule({
   meta: {
     type: "problem",
     docs: {
-      description: "disallow function calls in 'useState' that aren't wrapped in an initializer function",
+      description: "Enforces function calls made inside `useState` to be wrapped in an `initializer function`.",
       [Symbol.for("rule_features")]: RULE_FEATURES6
     },
     messages: {
@@ -614,20 +611,25 @@ function create6(context) {
       if (useStateInput == null) {
         return;
       }
-      const nestedCallExpressions = AST__namespace.getNestedCallExpressions(useStateInput);
-      const hasFunctionCall = nestedCallExpressions.some((n) => {
-        return "name" in n.callee && !isAllowedName(n.callee.name);
-      });
-      const hasNewCall = AST__namespace.getNestedNewExpressions(useStateInput).some((n) => {
-        return "name" in n.callee && !isAllowedName(n.callee.name);
-      });
-      if (!hasFunctionCall && !hasNewCall) {
-        return;
+      for (const expr of AST__namespace.getNestedNewExpressions(useStateInput)) {
+        if (!("name" in expr.callee)) continue;
+        if (ALLOW_LIST.includes(expr.callee.name)) continue;
+        if (AST__namespace.findParentNode(expr, (n) => core.isUseCall(context, n)) != null) continue;
+        context.report({
+          messageId: "preferUseStateLazyInitialization",
+          node: expr
+        });
+      }
+      for (const expr of AST__namespace.getNestedCallExpressions(useStateInput)) {
+        if (!("name" in expr.callee)) continue;
+        if (core.isReactHookNameLoose(expr.callee.name)) continue;
+        if (ALLOW_LIST.includes(expr.callee.name)) continue;
+        if (AST__namespace.findParentNode(expr, (n) => core.isUseCall(context, n)) != null) continue;
+        context.report({
+          messageId: "preferUseStateLazyInitialization",
+          node: expr
+        });
       }
-      context.report({
-        messageId: "preferUseStateLazyInitialization",
-        node: useStateInput
-      });
     }
   };
 }

package/dist/index.mjs

@@ -1,5 +1,5 @@
 import * as AST from '@eslint-react/ast';
-import { isReactHookCall, isUseCallbackCall, isReactHookCallWithNameLoose, isUseMemoCall, useHookCollector, isUseStateCall, isReactHookCallWithNameAlias, isReactHookName } from '@eslint-react/core';
+import { isReactHookCall, isUseCallbackCall, isReactHookCallWithNameLoose, isUseMemoCall, useHookCollector, isUseStateCall, isUseCall, isReactHookNameLoose, isReactHookCallWithNameAlias, isReactHookName } from '@eslint-react/core';
 import { identity, _, getOrUpdate, constTrue } from '@eslint-react/eff';
 import { createRuleForPlugin, getSettingsFromContext } from '@eslint-react/shared';
 import * as VAR4 from '@eslint-react/var';
@@ -26,7 +26,7 @@ var rules = {
 
 // package.json
 var name2 = "eslint-plugin-react-hooks-extra";
-var version = "1.37.1-next.3";
+var version = "1.37.1-next.5";
 var createRule = createRuleForPlugin("hooks-extra");
 function isFromHookCall(context, name3, settings, predicate = constTrue) {
   const hookAlias = settings.additionalHooks[name3] ?? [];
@@ -296,7 +296,7 @@ var no_direct_set_state_in_use_effect_default = createRule({
   meta: {
     type: "problem",
     docs: {
-      description: "disallow direct calls to the 'set' function of 'useState' in 'useEffect'",
+      description: "Disallow direct calls to the `set` function of `useState` in `useEffect`.",
       [Symbol.for("rule_features")]: RULE_FEATURES
     },
     messages: {
@@ -325,7 +325,7 @@ var no_direct_set_state_in_use_layout_effect_default = createRule({
   meta: {
     type: "problem",
     docs: {
-      description: "disallow direct calls to the 'set' function of 'useState' in 'useLayoutEffect'",
+      description: "Disallow direct calls to the `set` function of `useState` in `useLayoutEffect`.",
       [Symbol.for("rule_features")]: RULE_FEATURES2
     },
     messages: {
@@ -352,7 +352,7 @@ var no_unnecessary_use_callback_default = createRule({
   meta: {
     type: "problem",
     docs: {
-      description: "disallow unnecessary usage of 'useCallback'",
+      description: "Disallow unnecessary usage of `useCallback`.",
       [Symbol.for("rule_features")]: RULE_FEATURES3
     },
     messages: {
@@ -428,7 +428,7 @@ var no_unnecessary_use_memo_default = createRule({
   meta: {
     type: "problem",
     docs: {
-      description: "disallow unnecessary usage of 'useMemo'",
+      description: "Disallow unnecessary usage of `useMemo`.",
       [Symbol.for("rule_features")]: RULE_FEATURES4
     },
     messages: {
@@ -511,7 +511,7 @@ var no_unnecessary_use_prefix_default = createRule({
   meta: {
     type: "problem",
     docs: {
-      description: "enforce that a function with the 'use' prefix should use at least one Hook inside of it",
+      description: "Enforces that a function with the `use` prefix should use at least one Hook inside of it.",
       [Symbol.for("rule_features")]: RULE_FEATURES5
     },
     messages: {
@@ -557,14 +557,11 @@ var ALLOW_LIST = [
   "String",
   "Number"
 ];
-function isAllowedName(name3) {
-  return ALLOW_LIST.includes(name3) || isReactHookName(name3);
-}
 var prefer_use_state_lazy_initialization_default = createRule({
   meta: {
     type: "problem",
     docs: {
-      description: "disallow function calls in 'useState' that aren't wrapped in an initializer function",
+      description: "Enforces function calls made inside `useState` to be wrapped in an `initializer function`.",
       [Symbol.for("rule_features")]: RULE_FEATURES6
     },
     messages: {
@@ -591,20 +588,25 @@ function create6(context) {
       if (useStateInput == null) {
         return;
       }
-      const nestedCallExpressions = AST.getNestedCallExpressions(useStateInput);
-      const hasFunctionCall = nestedCallExpressions.some((n) => {
-        return "name" in n.callee && !isAllowedName(n.callee.name);
-      });
-      const hasNewCall = AST.getNestedNewExpressions(useStateInput).some((n) => {
-        return "name" in n.callee && !isAllowedName(n.callee.name);
-      });
-      if (!hasFunctionCall && !hasNewCall) {
-        return;
+      for (const expr of AST.getNestedNewExpressions(useStateInput)) {
+        if (!("name" in expr.callee)) continue;
+        if (ALLOW_LIST.includes(expr.callee.name)) continue;
+        if (AST.findParentNode(expr, (n) => isUseCall(context, n)) != null) continue;
+        context.report({
+          messageId: "preferUseStateLazyInitialization",
+          node: expr
+        });
+      }
+      for (const expr of AST.getNestedCallExpressions(useStateInput)) {
+        if (!("name" in expr.callee)) continue;
+        if (isReactHookNameLoose(expr.callee.name)) continue;
+        if (ALLOW_LIST.includes(expr.callee.name)) continue;
+        if (AST.findParentNode(expr, (n) => isUseCall(context, n)) != null) continue;
+        context.report({
+          messageId: "preferUseStateLazyInitialization",
+          node: expr
+        });
       }
-      context.report({
-        messageId: "preferUseStateLazyInitialization",
-        node: useStateInput
-      });
     }
   };
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-hooks-extra",
-  "version": "1.37.1-next.3",
+  "version": "1.37.1-next.5",
   "description": "ESLint React's ESLint plugin for React Hooks related rules.",
   "keywords": [
     "react",
@@ -50,12 +50,12 @@
     "@typescript-eslint/utils": "^8.27.0",
     "string-ts": "^2.2.1",
     "ts-pattern": "^5.6.2",
-    "@eslint-react/ast": "1.37.1-next.3",
-    "@eslint-react/core": "1.37.1-next.3",
-    "@eslint-react/eff": "1.37.1-next.3",
-    "@eslint-react/jsx": "1.37.1-next.3",
-    "@eslint-react/shared": "1.37.1-next.3",
-    "@eslint-react/var": "1.37.1-next.3"
+    "@eslint-react/ast": "1.37.1-next.5",
+    "@eslint-react/core": "1.37.1-next.5",
+    "@eslint-react/eff": "1.37.1-next.5",
+    "@eslint-react/jsx": "1.37.1-next.5",
+    "@eslint-react/shared": "1.37.1-next.5",
+    "@eslint-react/var": "1.37.1-next.5"
   },
   "devDependencies": {
     "@types/react": "^19.0.12",