eslint-plugin-react-hooks-extra 1.20.2-next.7 → 1.21.0-beta.0

package/README.md

@@ -30,7 +30,7 @@ export default [
     rules: {
       // react-hooks-extra recommended rules
       "react-hooks-extra/no-direct-set-state-in-use-effect": "warn",
-      "react-hooks-extra/no-redundant-custom-hook": "warn",
+      "react-hooks-extra/no-useless-custom-hooks": "warn",
       "react-hooks-extra/prefer-use-state-lazy-initialization": "warn",
     },
   },

package/dist/index.d.mts

@@ -8,14 +8,18 @@ declare const _default: {
     readonly rules: {
         readonly "no-direct-set-state-in-use-effect": _typescript_eslint_utils_ts_eslint.RuleModule<"noDirectSetStateInUseEffect", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
         readonly "no-direct-set-state-in-use-layout-effect": _typescript_eslint_utils_ts_eslint.RuleModule<"noDirectSetStateInUseLayoutEffect", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
-        readonly "no-redundant-custom-hook": _typescript_eslint_utils_ts_eslint.RuleModule<"noRedundantCustomHook", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
+        readonly "no-useless-custom-hooks": _typescript_eslint_utils_ts_eslint.RuleModule<"noUselessCustomHooks", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
         readonly "no-unnecessary-use-callback": _typescript_eslint_utils_ts_eslint.RuleModule<"noUnnecessaryUseCallback", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
         readonly "no-unnecessary-use-memo": _typescript_eslint_utils_ts_eslint.RuleModule<"noUnnecessaryUseMemo", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
         readonly "prefer-use-state-lazy-initialization": _typescript_eslint_utils_ts_eslint.RuleModule<"preferUseStateLazyInitialization", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
-        /** @deprecated Use `no-redundant-custom-hook` instead */
-        readonly "ensure-custom-hooks-using-other-hooks": _typescript_eslint_utils_ts_eslint.RuleModule<"noRedundantCustomHook", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
+        /** @deprecated Use `no-useless-custom-hooks` instead */
+        readonly "no-redundant-custom-hook": _typescript_eslint_utils_ts_eslint.RuleModule<"noUselessCustomHooks", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
+        /** @deprecated Use `no-useless-custom-hooks` instead */
+        readonly "ensure-custom-hooks-using-other-hooks": _typescript_eslint_utils_ts_eslint.RuleModule<"noUselessCustomHooks", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
         /** @deprecated Use `no-unnecessary-use-memo` instead */
         readonly "ensure-use-memo-has-non-empty-deps": _typescript_eslint_utils_ts_eslint.RuleModule<"noUnnecessaryUseMemo", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
+        /** @deprecated Use `no-unnecessary-use-callback` instead */
+        readonly "ensure-use-callback-has-non-empty-deps": _typescript_eslint_utils_ts_eslint.RuleModule<"noUnnecessaryUseCallback", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
     };
 };
 

package/dist/index.d.ts

@@ -8,14 +8,18 @@ declare const _default: {
     readonly rules: {
         readonly "no-direct-set-state-in-use-effect": _typescript_eslint_utils_ts_eslint.RuleModule<"noDirectSetStateInUseEffect", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
         readonly "no-direct-set-state-in-use-layout-effect": _typescript_eslint_utils_ts_eslint.RuleModule<"noDirectSetStateInUseLayoutEffect", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
-        readonly "no-redundant-custom-hook": _typescript_eslint_utils_ts_eslint.RuleModule<"noRedundantCustomHook", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
+        readonly "no-useless-custom-hooks": _typescript_eslint_utils_ts_eslint.RuleModule<"noUselessCustomHooks", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
         readonly "no-unnecessary-use-callback": _typescript_eslint_utils_ts_eslint.RuleModule<"noUnnecessaryUseCallback", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
         readonly "no-unnecessary-use-memo": _typescript_eslint_utils_ts_eslint.RuleModule<"noUnnecessaryUseMemo", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
         readonly "prefer-use-state-lazy-initialization": _typescript_eslint_utils_ts_eslint.RuleModule<"preferUseStateLazyInitialization", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
-        /** @deprecated Use `no-redundant-custom-hook` instead */
-        readonly "ensure-custom-hooks-using-other-hooks": _typescript_eslint_utils_ts_eslint.RuleModule<"noRedundantCustomHook", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
+        /** @deprecated Use `no-useless-custom-hooks` instead */
+        readonly "no-redundant-custom-hook": _typescript_eslint_utils_ts_eslint.RuleModule<"noUselessCustomHooks", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
+        /** @deprecated Use `no-useless-custom-hooks` instead */
+        readonly "ensure-custom-hooks-using-other-hooks": _typescript_eslint_utils_ts_eslint.RuleModule<"noUselessCustomHooks", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
         /** @deprecated Use `no-unnecessary-use-memo` instead */
         readonly "ensure-use-memo-has-non-empty-deps": _typescript_eslint_utils_ts_eslint.RuleModule<"noUnnecessaryUseMemo", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
+        /** @deprecated Use `no-unnecessary-use-callback` instead */
+        readonly "ensure-use-callback-has-non-empty-deps": _typescript_eslint_utils_ts_eslint.RuleModule<"noUnnecessaryUseCallback", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
     };
 };
 

package/dist/index.js

@@ -31,7 +31,7 @@ var VAR5__namespace = /*#__PURE__*/_interopNamespace(VAR5);
 
 // package.json
 var name = "eslint-plugin-react-hooks-extra";
-var version = "1.20.2-next.7";
+var version = "1.21.0-beta.0";
 var createRule = shared.createRuleForPlugin("hooks-extra");
 function isFromHookCall(name2, context, settings, predicate = eff.F.constTrue) {
   const hookAlias = settings.additionalHooks?.[name2] ?? [];
@@ -475,62 +475,23 @@ var no_direct_set_state_in_use_layout_effect_default = createRule({
   },
   defaultOptions: []
 });
-var RULE_NAME3 = "no-redundant-custom-hook";
+var RULE_NAME3 = "no-unnecessary-use-callback";
 var RULE_FEATURES3 = [
   "CHK"
 ];
-var no_redundant_custom_hook_default = createRule({
-  meta: {
-    type: "problem",
-    docs: {
-      description: "enforce custom hooks to use at least one other hook inside",
-      [Symbol.for("rule_features")]: RULE_FEATURES3
-    },
-    messages: {
-      noRedundantCustomHook: "A custom hook '{{name}}' should use at least one other hook."
-    },
-    schema: []
-  },
-  name: RULE_NAME3,
-  create(context) {
-    const { ctx, listeners } = core.useHookCollector();
-    return {
-      ...listeners,
-      "Program:exit"(node) {
-        const allHooks = ctx.getAllHooks(node);
-        for (const { name: name2, node: node2, hookCalls } of allHooks.values()) {
-          if (AST2__namespace.isEmptyFunction(node2)) continue;
-          if (hookCalls.length > 0) continue;
-          context.report({
-            messageId: "noRedundantCustomHook",
-            node: node2,
-            data: {
-              name: name2.value
-            }
-          });
-        }
-      }
-    };
-  },
-  defaultOptions: []
-});
-var RULE_NAME4 = "no-unnecessary-use-callback";
-var RULE_FEATURES4 = [
-  "CHK"
-];
 var no_unnecessary_use_callback_default = createRule({
   meta: {
     type: "problem",
     docs: {
       description: "disallow unnecessary usage of 'useCallback'",
-      [Symbol.for("rule_features")]: RULE_FEATURES4
+      [Symbol.for("rule_features")]: RULE_FEATURES3
     },
     messages: {
       noUnnecessaryUseCallback: "An 'useCallback' with empty deps and no references to the component scope may be unnecessary."
     },
     schema: []
   },
-  name: RULE_NAME4,
+  name: RULE_NAME3,
   create(context) {
     if (!context.sourceCode.text.includes("use")) return {};
     const alias = shared.decodeSettings(context.settings).additionalHooks?.useCallback ?? [];
@@ -597,8 +558,8 @@ var no_unnecessary_use_callback_default = createRule({
   },
   defaultOptions: []
 });
-var RULE_NAME5 = "no-unnecessary-use-memo";
-var RULE_FEATURES5 = [
+var RULE_NAME4 = "no-unnecessary-use-memo";
+var RULE_FEATURES4 = [
   "CHK"
 ];
 var no_unnecessary_use_memo_default = createRule({
@@ -606,14 +567,14 @@ var no_unnecessary_use_memo_default = createRule({
     type: "problem",
     docs: {
       description: "disallow unnecessary usage of 'useMemo'",
-      [Symbol.for("rule_features")]: RULE_FEATURES5
+      [Symbol.for("rule_features")]: RULE_FEATURES4
     },
     messages: {
       noUnnecessaryUseMemo: "An 'useMemo' with empty deps and no references to the component scope may be unnecessary."
     },
     schema: []
   },
-  name: RULE_NAME5,
+  name: RULE_NAME4,
   create(context) {
     if (!context.sourceCode.text.includes("use")) return {};
     const alias = shared.decodeSettings(context.settings).additionalHooks?.useMemo ?? [];
@@ -680,6 +641,49 @@ var no_unnecessary_use_memo_default = createRule({
   },
   defaultOptions: []
 });
+var RULE_NAME5 = "no-useless-custom-hooks";
+var RULE_FEATURES5 = [
+  "CHK"
+];
+function isNodeContainsUseCallComments(node, context) {
+  return context.sourceCode.getCommentsInside(node).some((comment) => /use\w+\(/u.test(comment.value));
+}
+var no_useless_custom_hooks_default = createRule({
+  meta: {
+    type: "problem",
+    docs: {
+      description: "enforce custom hooks to use at least one other hook inside",
+      [Symbol.for("rule_features")]: RULE_FEATURES5
+    },
+    messages: {
+      noUselessCustomHooks: "A custom hook '{{name}}' should use at least one other hook."
+    },
+    schema: []
+  },
+  name: RULE_NAME5,
+  create(context) {
+    const { ctx, listeners } = core.useHookCollector();
+    return {
+      ...listeners,
+      "Program:exit"(node) {
+        const allHooks = ctx.getAllHooks(node);
+        for (const { name: name2, node: node2, hookCalls } of allHooks.values()) {
+          if (AST2__namespace.isEmptyFunction(node2)) continue;
+          if (hookCalls.length > 0) continue;
+          if (isNodeContainsUseCallComments(node2, context)) continue;
+          context.report({
+            messageId: "noUselessCustomHooks",
+            node: node2,
+            data: {
+              name: name2.value
+            }
+          });
+        }
+      }
+    };
+  },
+  defaultOptions: []
+});
 var RULE_NAME6 = "prefer-use-state-lazy-initialization";
 var RULE_FEATURES6 = [
   "CHK"
@@ -734,15 +738,19 @@ var src_default = {
   rules: {
     "no-direct-set-state-in-use-effect": no_direct_set_state_in_use_effect_default,
     "no-direct-set-state-in-use-layout-effect": no_direct_set_state_in_use_layout_effect_default,
-    "no-redundant-custom-hook": no_redundant_custom_hook_default,
+    "no-useless-custom-hooks": no_useless_custom_hooks_default,
     "no-unnecessary-use-callback": no_unnecessary_use_callback_default,
     "no-unnecessary-use-memo": no_unnecessary_use_memo_default,
     "prefer-use-state-lazy-initialization": prefer_use_state_lazy_initialization_default,
-    // Deprecated Rules
-    /** @deprecated Use `no-redundant-custom-hook` instead */
-    "ensure-custom-hooks-using-other-hooks": no_redundant_custom_hook_default,
+    // Deprecated rules
+    /** @deprecated Use `no-useless-custom-hooks` instead */
+    "no-redundant-custom-hook": no_useless_custom_hooks_default,
+    /** @deprecated Use `no-useless-custom-hooks` instead */
+    "ensure-custom-hooks-using-other-hooks": no_useless_custom_hooks_default,
     /** @deprecated Use `no-unnecessary-use-memo` instead */
-    "ensure-use-memo-has-non-empty-deps": no_unnecessary_use_memo_default
+    "ensure-use-memo-has-non-empty-deps": no_unnecessary_use_memo_default,
+    /** @deprecated Use `no-unnecessary-use-callback` instead */
+    "ensure-use-callback-has-non-empty-deps": no_unnecessary_use_callback_default
   }
 };
 

package/dist/index.mjs

@@ -1,5 +1,5 @@
 import * as AST2 from '@eslint-react/ast';
-import { isReactHookCallWithNameAlias, useHookCollector, isReactHookCall, isUseCallbackCall, isReactHookCallWithNameLoose, isUseMemoCall, isUseStateCall, isReactHookName } from '@eslint-react/core';
+import { isReactHookCallWithNameAlias, isReactHookCall, isUseCallbackCall, isReactHookCallWithNameLoose, isUseMemoCall, useHookCollector, isUseStateCall, isReactHookName } from '@eslint-react/core';
 import { MutRef, O, F } from '@eslint-react/eff';
 import { createRuleForPlugin, decodeSettings } from '@eslint-react/shared';
 import * as VAR5 from '@eslint-react/var';
@@ -8,7 +8,7 @@ import { match, isMatching } from 'ts-pattern';
 
 // package.json
 var name = "eslint-plugin-react-hooks-extra";
-var version = "1.20.2-next.7";
+var version = "1.21.0-beta.0";
 var createRule = createRuleForPlugin("hooks-extra");
 function isFromHookCall(name2, context, settings, predicate = F.constTrue) {
   const hookAlias = settings.additionalHooks?.[name2] ?? [];
@@ -452,62 +452,23 @@ var no_direct_set_state_in_use_layout_effect_default = createRule({
   },
   defaultOptions: []
 });
-var RULE_NAME3 = "no-redundant-custom-hook";
+var RULE_NAME3 = "no-unnecessary-use-callback";
 var RULE_FEATURES3 = [
   "CHK"
 ];
-var no_redundant_custom_hook_default = createRule({
-  meta: {
-    type: "problem",
-    docs: {
-      description: "enforce custom hooks to use at least one other hook inside",
-      [Symbol.for("rule_features")]: RULE_FEATURES3
-    },
-    messages: {
-      noRedundantCustomHook: "A custom hook '{{name}}' should use at least one other hook."
-    },
-    schema: []
-  },
-  name: RULE_NAME3,
-  create(context) {
-    const { ctx, listeners } = useHookCollector();
-    return {
-      ...listeners,
-      "Program:exit"(node) {
-        const allHooks = ctx.getAllHooks(node);
-        for (const { name: name2, node: node2, hookCalls } of allHooks.values()) {
-          if (AST2.isEmptyFunction(node2)) continue;
-          if (hookCalls.length > 0) continue;
-          context.report({
-            messageId: "noRedundantCustomHook",
-            node: node2,
-            data: {
-              name: name2.value
-            }
-          });
-        }
-      }
-    };
-  },
-  defaultOptions: []
-});
-var RULE_NAME4 = "no-unnecessary-use-callback";
-var RULE_FEATURES4 = [
-  "CHK"
-];
 var no_unnecessary_use_callback_default = createRule({
   meta: {
     type: "problem",
     docs: {
       description: "disallow unnecessary usage of 'useCallback'",
-      [Symbol.for("rule_features")]: RULE_FEATURES4
+      [Symbol.for("rule_features")]: RULE_FEATURES3
     },
     messages: {
       noUnnecessaryUseCallback: "An 'useCallback' with empty deps and no references to the component scope may be unnecessary."
     },
     schema: []
   },
-  name: RULE_NAME4,
+  name: RULE_NAME3,
   create(context) {
     if (!context.sourceCode.text.includes("use")) return {};
     const alias = decodeSettings(context.settings).additionalHooks?.useCallback ?? [];
@@ -574,8 +535,8 @@ var no_unnecessary_use_callback_default = createRule({
   },
   defaultOptions: []
 });
-var RULE_NAME5 = "no-unnecessary-use-memo";
-var RULE_FEATURES5 = [
+var RULE_NAME4 = "no-unnecessary-use-memo";
+var RULE_FEATURES4 = [
   "CHK"
 ];
 var no_unnecessary_use_memo_default = createRule({
@@ -583,14 +544,14 @@ var no_unnecessary_use_memo_default = createRule({
     type: "problem",
     docs: {
       description: "disallow unnecessary usage of 'useMemo'",
-      [Symbol.for("rule_features")]: RULE_FEATURES5
+      [Symbol.for("rule_features")]: RULE_FEATURES4
     },
     messages: {
       noUnnecessaryUseMemo: "An 'useMemo' with empty deps and no references to the component scope may be unnecessary."
     },
     schema: []
   },
-  name: RULE_NAME5,
+  name: RULE_NAME4,
   create(context) {
     if (!context.sourceCode.text.includes("use")) return {};
     const alias = decodeSettings(context.settings).additionalHooks?.useMemo ?? [];
@@ -657,6 +618,49 @@ var no_unnecessary_use_memo_default = createRule({
   },
   defaultOptions: []
 });
+var RULE_NAME5 = "no-useless-custom-hooks";
+var RULE_FEATURES5 = [
+  "CHK"
+];
+function isNodeContainsUseCallComments(node, context) {
+  return context.sourceCode.getCommentsInside(node).some((comment) => /use\w+\(/u.test(comment.value));
+}
+var no_useless_custom_hooks_default = createRule({
+  meta: {
+    type: "problem",
+    docs: {
+      description: "enforce custom hooks to use at least one other hook inside",
+      [Symbol.for("rule_features")]: RULE_FEATURES5
+    },
+    messages: {
+      noUselessCustomHooks: "A custom hook '{{name}}' should use at least one other hook."
+    },
+    schema: []
+  },
+  name: RULE_NAME5,
+  create(context) {
+    const { ctx, listeners } = useHookCollector();
+    return {
+      ...listeners,
+      "Program:exit"(node) {
+        const allHooks = ctx.getAllHooks(node);
+        for (const { name: name2, node: node2, hookCalls } of allHooks.values()) {
+          if (AST2.isEmptyFunction(node2)) continue;
+          if (hookCalls.length > 0) continue;
+          if (isNodeContainsUseCallComments(node2, context)) continue;
+          context.report({
+            messageId: "noUselessCustomHooks",
+            node: node2,
+            data: {
+              name: name2.value
+            }
+          });
+        }
+      }
+    };
+  },
+  defaultOptions: []
+});
 var RULE_NAME6 = "prefer-use-state-lazy-initialization";
 var RULE_FEATURES6 = [
   "CHK"
@@ -711,15 +715,19 @@ var src_default = {
   rules: {
     "no-direct-set-state-in-use-effect": no_direct_set_state_in_use_effect_default,
     "no-direct-set-state-in-use-layout-effect": no_direct_set_state_in_use_layout_effect_default,
-    "no-redundant-custom-hook": no_redundant_custom_hook_default,
+    "no-useless-custom-hooks": no_useless_custom_hooks_default,
     "no-unnecessary-use-callback": no_unnecessary_use_callback_default,
     "no-unnecessary-use-memo": no_unnecessary_use_memo_default,
     "prefer-use-state-lazy-initialization": prefer_use_state_lazy_initialization_default,
-    // Deprecated Rules
-    /** @deprecated Use `no-redundant-custom-hook` instead */
-    "ensure-custom-hooks-using-other-hooks": no_redundant_custom_hook_default,
+    // Deprecated rules
+    /** @deprecated Use `no-useless-custom-hooks` instead */
+    "no-redundant-custom-hook": no_useless_custom_hooks_default,
+    /** @deprecated Use `no-useless-custom-hooks` instead */
+    "ensure-custom-hooks-using-other-hooks": no_useless_custom_hooks_default,
     /** @deprecated Use `no-unnecessary-use-memo` instead */
-    "ensure-use-memo-has-non-empty-deps": no_unnecessary_use_memo_default
+    "ensure-use-memo-has-non-empty-deps": no_unnecessary_use_memo_default,
+    /** @deprecated Use `no-unnecessary-use-callback` instead */
+    "ensure-use-callback-has-non-empty-deps": no_unnecessary_use_callback_default
   }
 };
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-hooks-extra",
-  "version": "1.20.2-next.7",
+  "version": "1.21.0-beta.0",
   "description": "ESLint React's ESLint plugin for React Hooks related rules.",
   "keywords": [
     "react",
@@ -49,13 +49,13 @@
     "@typescript-eslint/types": "^8.18.1",
     "@typescript-eslint/utils": "^8.18.1",
     "ts-pattern": "^5.6.0",
-    "@eslint-react/ast": "1.20.2-next.7",
-    "@eslint-react/core": "1.20.2-next.7",
-    "@eslint-react/jsx": "1.20.2-next.7",
-    "@eslint-react/shared": "1.20.2-next.7",
-    "@eslint-react/eff": "1.20.2-next.7",
-    "@eslint-react/types": "1.20.2-next.7",
-    "@eslint-react/var": "1.20.2-next.7"
+    "@eslint-react/core": "1.21.0-beta.0",
+    "@eslint-react/ast": "1.21.0-beta.0",
+    "@eslint-react/jsx": "1.21.0-beta.0",
+    "@eslint-react/eff": "1.21.0-beta.0",
+    "@eslint-react/types": "1.21.0-beta.0",
+    "@eslint-react/shared": "1.21.0-beta.0",
+    "@eslint-react/var": "1.21.0-beta.0"
   },
   "devDependencies": {
     "@types/react": "^19.0.2",