eslint-plugin-react-hooks-extra 1.12.3 → 1.12.4-beta.3

package/README.md

@@ -33,7 +33,6 @@ export default [
       // react-hooks-extra recommended rules
       "hooks-extra/ensure-custom-hooks-using-other-hooks": "warn",
       "hooks-extra/no-direct-set-state-in-use-effect": "warn",
-      "hooks-extra/no-direct-set-state-in-use-layout-effect": "warn",
       "hooks-extra/prefer-use-state-lazy-initialization": "warn",
     },
   },
@@ -42,11 +41,10 @@ export default [
 
 ## Rules
 
-| Rule                                       | Description                                                                     | 💼  | 💭  |     |
-| :----------------------------------------- | :------------------------------------------------------------------------------ | :-: | :-: | :-: |
-| `ensure-custom-hooks-using-other-hooks`    | Warns when custom Hooks that don't use other Hooks.                             |  ✔️  |     |     |
-| `ensure-use-callback-has-non-empty-deps`   | Warns when `useCallback` is called with empty dependencies array.               | 🧐  |     |     |
-| `ensure-use-memo-has-non-empty-deps`       | Warns when `useMemo` is called with empty dependencies array.                   | 🧐  |     |     |
-| `no-direct-set-state-in-use-effect`        | Disallow direct calls to the `set` function of `useState` in `useEffect`.       |  ✔️  |     |     |
-| `no-direct-set-state-in-use-layout-effect` | Disallow direct calls to the `set` function of `useState` in `useLayoutEffect`. |  ✔️  |     |     |
-| `prefer-use-state-lazy-initialization`     | Warns function calls made inside `useState` calls.                              | 🚀  |     |     |
+| Rule                                     | Description                                                               | 💼  | 💭  |     |
+| :--------------------------------------- | :------------------------------------------------------------------------ | :-: | :-: | :-: |
+| `ensure-custom-hooks-using-other-hooks`  | Warns when custom Hooks that don't use other Hooks.                       |  ✔️  |     |     |
+| `ensure-use-callback-has-non-empty-deps` | Warns when `useCallback` is called with empty dependencies array.         | 🧐  |     |     |
+| `ensure-use-memo-has-non-empty-deps`     | Warns when `useMemo` is called with empty dependencies array.             | 🧐  |     |     |
+| `no-direct-set-state-in-use-effect`      | Disallow direct calls to the `set` function of `useState` in `useEffect`. |  ✔️  |     |     |
+| `prefer-use-state-lazy-initialization`   | Warns function calls made inside `useState` calls.                        | 🚀  |     |     |

package/dist/index.d.mts

@@ -9,7 +9,8 @@ declare const rules: {
     readonly "ensure-use-callback-has-non-empty-deps": _typescript_eslint_utils_ts_eslint.RuleModule<"ensureUseCallbackHasNonEmptyDeps", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
     readonly "ensure-use-memo-has-non-empty-deps": _typescript_eslint_utils_ts_eslint.RuleModule<"ensureUseMemoHasNonEmptyDeps", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
     readonly "no-direct-set-state-in-use-effect": _typescript_eslint_utils_ts_eslint.RuleModule<"noDirectSetStateInUseEffect", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
-    readonly "no-direct-set-state-in-use-layout-effect": _typescript_eslint_utils_ts_eslint.RuleModule<"noDirectSetStateInUseLayoutEffect", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
+    /** @deprecated Use `no-direct-set-state-in-use-effect` instead */
+    readonly "no-direct-set-state-in-use-layout-effect": _typescript_eslint_utils_ts_eslint.RuleModule<"noDirectSetStateInUseEffect", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
     readonly "prefer-use-state-lazy-initialization": _typescript_eslint_utils_ts_eslint.RuleModule<"preferUseStateLazyInitialization", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
 };
 

package/dist/index.d.ts

@@ -9,7 +9,8 @@ declare const rules: {
     readonly "ensure-use-callback-has-non-empty-deps": _typescript_eslint_utils_ts_eslint.RuleModule<"ensureUseCallbackHasNonEmptyDeps", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
     readonly "ensure-use-memo-has-non-empty-deps": _typescript_eslint_utils_ts_eslint.RuleModule<"ensureUseMemoHasNonEmptyDeps", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
     readonly "no-direct-set-state-in-use-effect": _typescript_eslint_utils_ts_eslint.RuleModule<"noDirectSetStateInUseEffect", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
-    readonly "no-direct-set-state-in-use-layout-effect": _typescript_eslint_utils_ts_eslint.RuleModule<"noDirectSetStateInUseLayoutEffect", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
+    /** @deprecated Use `no-direct-set-state-in-use-effect` instead */
+    readonly "no-direct-set-state-in-use-layout-effect": _typescript_eslint_utils_ts_eslint.RuleModule<"noDirectSetStateInUseEffect", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
     readonly "prefer-use-state-lazy-initialization": _typescript_eslint_utils_ts_eslint.RuleModule<"preferUseStateLazyInitialization", [], unknown, _typescript_eslint_utils_ts_eslint.RuleListener>;
 };
 

package/dist/index.js

@@ -11,7 +11,7 @@ var tsPattern = require('ts-pattern');
 
 // package.json
 var name = "eslint-plugin-react-hooks-extra";
-var version = "1.12.3";
+var version = "1.12.4-beta.3";
 var createRule = shared.createRuleForPlugin("hooks-extra");
 function isFromHookCall(name2, context, settings, predicate = tools.F.constTrue) {
   const hookAlias = settings.additionalHooks?.[name2] ?? [];
@@ -303,7 +303,17 @@ var no_direct_set_state_in_use_effect_default = createRule({
     if (!/use\w*Effect/u.test(context.sourceCode.text)) return {};
     const settings = shared.decodeSettings(context.settings);
     const additionalHooks = settings.additionalHooks ?? {};
-    const isUseEffectCall = core.isReactHookCallWithNameAlias("useEffect", context, additionalHooks.useEffect ?? []);
+    const isUseEffectLikeCall = core.isReactHookCallWithNameAlias(
+      "useEffect",
+      context,
+      [
+        "useLayoutEffect",
+        "useInsertionEffect",
+        ...additionalHooks.useEffect ?? [],
+        ...additionalHooks.useLayoutEffect ?? [],
+        ...additionalHooks.useInsertionEffect ?? []
+      ]
+    );
     const isUseStateCall2 = core.isReactHookCallWithNameAlias("useState", context, additionalHooks.useState ?? []);
     const isUseMemoCall2 = core.isReactHookCallWithNameAlias("useMemo", context, additionalHooks.useMemo ?? []);
     const isUseCallbackCall2 = core.isReactHookCallWithNameAlias("useCallback", context, additionalHooks.useCallback ?? []);
@@ -324,10 +334,10 @@ var no_direct_set_state_in_use_effect_default = createRule({
       tools.MutRef.update(setupFunctionRef, (current) => current === node ? null : current);
     };
     function isSetupFunction(node) {
-      return node.parent?.type === types.AST_NODE_TYPES.CallExpression && node.parent.callee !== node && isUseEffectCall(node.parent);
+      return node.parent?.type === types.AST_NODE_TYPES.CallExpression && node.parent.callee !== node && isUseEffectLikeCall(node.parent);
     }
     function getCallKind(node) {
-      return tsPattern.match(node).when(isUseStateCall2, () => "useState").when(isUseEffectCall, () => "useEffect").when(isSetStateCall, () => "setState").when(isThenCall, () => "then").otherwise(() => "other");
+      return tsPattern.match(node).when(isUseStateCall2, () => "useState").when(isUseEffectLikeCall, () => "useEffect").when(isSetStateCall, () => "setState").when(isThenCall, () => "then").otherwise(() => "other");
     }
     function getFunctionKind(node) {
       return tsPattern.match(node).when(isSetupFunction, () => "setup").when(ast.isFunctionOfImmediatelyInvoked, () => "immediate").otherwise(() => "other");
@@ -391,7 +401,7 @@ var no_direct_set_state_in_use_effect_default = createRule({
               const calls = indirectSetStateCallsAsArgs.get(vd.init) ?? [];
               indirectSetStateCallsAsArgs.set(vd.init, [...calls, node]);
             }
-            if (isUseEffectCall(node.parent)) {
+            if (isUseEffectLikeCall(node.parent)) {
               const calls = indirectSetStateCallsAsArgs.get(node.parent) ?? [];
               indirectSetStateCallsAsSetups.set(node.parent, [...calls, node]);
             }
@@ -462,189 +472,7 @@ var no_direct_set_state_in_use_effect_default = createRule({
   },
   defaultOptions: []
 });
-var RULE_NAME5 = "no-direct-set-state-in-use-layout-effect";
-var no_direct_set_state_in_use_layout_effect_default = createRule({
-  meta: {
-    type: "problem",
-    docs: {
-      description: "disallow direct calls to the 'set' function of 'useState' in 'useLayoutEffect'"
-    },
-    messages: {
-      noDirectSetStateInUseLayoutEffect: "Do not call the 'set' function '{{name}}' of 'useState' directly in 'useLayoutEffect'."
-    },
-    schema: []
-  },
-  name: RULE_NAME5,
-  create(context) {
-    if (!/use\w*Effect/u.test(context.sourceCode.text)) return {};
-    const settings = shared.decodeSettings(context.settings);
-    const additionalHooks = settings.additionalHooks ?? {};
-    const isUseEffectCall = core.isReactHookCallWithNameAlias(
-      "useLayoutEffect",
-      context,
-      additionalHooks.useLayoutEffect ?? []
-    );
-    const isUseStateCall2 = core.isReactHookCallWithNameAlias("useState", context, additionalHooks.useState ?? []);
-    const isUseMemoCall2 = core.isReactHookCallWithNameAlias("useMemo", context, additionalHooks.useMemo ?? []);
-    const isUseCallbackCall2 = core.isReactHookCallWithNameAlias("useCallback", context, additionalHooks.useCallback ?? []);
-    const isSetStateCall = isSetFunctionCall(context, settings);
-    const isIdFromUseStateCall = isFromUseStateCall(context, settings);
-    const functionStack = [];
-    const setupFunctionRef = tools.MutRef.make(null);
-    const setupFunctionIdentifiers = [];
-    const indirectFunctionCalls = [];
-    const indirectSetStateCalls = /* @__PURE__ */ new WeakMap();
-    const indirectSetStateCallsAsSetups = /* @__PURE__ */ new Map();
-    const indirectSetStateCallsAsArgs = /* @__PURE__ */ new WeakMap();
-    const indirectSetStateCallsInHooks = /* @__PURE__ */ new WeakMap();
-    const onSetupFunctionEnter = (node) => {
-      tools.MutRef.set(setupFunctionRef, node);
-    };
-    const onSetupFunctionExit = (node) => {
-      tools.MutRef.update(setupFunctionRef, (current) => current === node ? null : current);
-    };
-    function isSetupFunction(node) {
-      return node.parent?.type === types.AST_NODE_TYPES.CallExpression && node.parent.callee !== node && isUseEffectCall(node.parent);
-    }
-    function getCallKind(node) {
-      return tsPattern.match(node).when(isUseStateCall2, () => "useState").when(isUseEffectCall, () => "useLayoutEffect").when(isSetStateCall, () => "setState").when(isThenCall, () => "then").otherwise(() => "other");
-    }
-    function getFunctionKind(node) {
-      return tsPattern.match(node).when(isSetupFunction, () => "setup").when(ast.isFunctionOfImmediatelyInvoked, () => "immediate").otherwise(() => "other");
-    }
-    return {
-      ":function"(node) {
-        const functionKind = getFunctionKind(node);
-        functionStack.push([node, functionKind]);
-        if (functionKind === "setup") onSetupFunctionEnter(node);
-      },
-      ":function:exit"(node) {
-        const [_, functionKind] = functionStack.at(-1) ?? [];
-        functionStack.pop();
-        if (functionKind === "setup") onSetupFunctionExit(node);
-      },
-      CallExpression(node) {
-        const effectFn = tools.MutRef.get(setupFunctionRef);
-        const [parentFn, parentFnKind] = functionStack.at(-1) ?? [];
-        if (parentFn?.async) return;
-        tsPattern.match(getCallKind(node)).with("setState", () => {
-          if (!parentFn) return;
-          if (parentFn !== effectFn && parentFnKind !== "immediate") {
-            const maybeVd = ast.traverseUpGuard(node, isVariableDeclaratorFromHookCall);
-            if (tools.O.isSome(maybeVd)) {
-              const vd = maybeVd.value;
-              const calls2 = indirectSetStateCallsInHooks.get(vd.init) ?? [];
-              indirectSetStateCallsInHooks.set(vd.init, [...calls2, node]);
-              return;
-            }
-            const calls = indirectSetStateCalls.get(parentFn) ?? [];
-            indirectSetStateCalls.set(parentFn, [...calls, node]);
-            return;
-          }
-          context.report({
-            messageId: "noDirectSetStateInUseLayoutEffect",
-            node,
-            data: {
-              name: context.sourceCode.getText(node.callee)
-            }
-          });
-        }).with("useLayoutEffect", () => {
-          const [firstArg] = node.arguments;
-          if (ast.isFunction(firstArg)) return;
-          const identifiers = ast.getNestedIdentifiers(node);
-          setupFunctionIdentifiers.push(...identifiers);
-        }).with("other", () => {
-          const isInSetupFunction = effectFn === parentFn;
-          if (!isInSetupFunction) return;
-          indirectFunctionCalls.push(node);
-        }).otherwise(tools.F.constVoid);
-      },
-      Identifier(node) {
-        if (node.parent.type === types.AST_NODE_TYPES.CallExpression && node.parent.callee === node) return;
-        if (!isIdFromUseStateCall(node)) return;
-        switch (node.parent.type) {
-          case types.AST_NODE_TYPES.CallExpression: {
-            const [firstArg] = node.parent.arguments;
-            if (node !== firstArg) break;
-            if (isUseCallbackCall2(node.parent)) {
-              const maybeVd = ast.traverseUpGuard(node.parent, isVariableDeclaratorFromHookCall);
-              if (tools.O.isNone(maybeVd)) break;
-              const vd = maybeVd.value;
-              const calls = indirectSetStateCallsAsArgs.get(vd.init) ?? [];
-              indirectSetStateCallsAsArgs.set(vd.init, [...calls, node]);
-            }
-            if (isUseEffectCall(node.parent)) {
-              const calls = indirectSetStateCallsAsArgs.get(node.parent) ?? [];
-              indirectSetStateCallsAsSetups.set(node.parent, [...calls, node]);
-            }
-            break;
-          }
-          case types.AST_NODE_TYPES.ArrowFunctionExpression: {
-            const parent = node.parent.parent;
-            if (parent.type !== types.AST_NODE_TYPES.CallExpression) break;
-            if (!isUseMemoCall2(parent)) break;
-            const maybeVd = ast.traverseUpGuard(parent, isVariableDeclaratorFromHookCall);
-            if (tools.O.isNone(maybeVd)) break;
-            const vd = maybeVd.value;
-            const calls = indirectSetStateCallsAsArgs.get(vd.init) ?? [];
-            indirectSetStateCallsAsArgs.set(vd.init, [...calls, node]);
-          }
-        }
-      },
-      "Program:exit"() {
-        const getSetStateCalls = (id, initialScope) => {
-          const node = tools.O.flatMap(_var.findVariable(id, initialScope), _var.getVariableNode(0)).pipe(tools.O.getOrNull);
-          switch (node?.type) {
-            case types.AST_NODE_TYPES.FunctionDeclaration:
-            case types.AST_NODE_TYPES.FunctionExpression:
-            case types.AST_NODE_TYPES.ArrowFunctionExpression:
-              return indirectSetStateCalls.get(node) ?? [];
-            case types.AST_NODE_TYPES.CallExpression:
-              return indirectSetStateCallsInHooks.get(node) ?? indirectSetStateCallsAsArgs.get(node) ?? [];
-          }
-          return [];
-        };
-        for (const [_, calls] of indirectSetStateCallsAsSetups) {
-          for (const call of calls) {
-            context.report({
-              messageId: "noDirectSetStateInUseLayoutEffect",
-              node: call,
-              data: { name: call.name }
-            });
-          }
-        }
-        for (const { callee } of indirectFunctionCalls) {
-          if (!("name" in callee)) continue;
-          const { name: name2 } = callee;
-          const setStateCalls = getSetStateCalls(name2, context.sourceCode.getScope(callee));
-          for (const setStateCall of setStateCalls) {
-            context.report({
-              messageId: "noDirectSetStateInUseLayoutEffect",
-              node: setStateCall,
-              data: {
-                name: ast.toReadableNodeName(setStateCall, (n) => context.sourceCode.getText(n))
-              }
-            });
-          }
-        }
-        for (const id of setupFunctionIdentifiers) {
-          const setStateCalls = getSetStateCalls(id.name, context.sourceCode.getScope(id));
-          for (const setStateCall of setStateCalls) {
-            context.report({
-              messageId: "noDirectSetStateInUseLayoutEffect",
-              node: setStateCall,
-              data: {
-                name: ast.toReadableNodeName(setStateCall, (n) => context.sourceCode.getText(n))
-              }
-            });
-          }
-        }
-      }
-    };
-  },
-  defaultOptions: []
-});
-var RULE_NAME6 = "prefer-use-state-lazy-initialization";
+var RULE_NAME5 = "prefer-use-state-lazy-initialization";
 var ALLOW_LIST = ["Boolean", "String", "Number"];
 var prefer_use_state_lazy_initialization_default = createRule({
   meta: {
@@ -657,7 +485,7 @@ var prefer_use_state_lazy_initialization_default = createRule({
     },
     schema: []
   },
-  name: RULE_NAME6,
+  name: RULE_NAME5,
   create(context) {
     if (!context.sourceCode.text.includes("use")) return {};
     const alias = shared.decodeSettings(context.settings).additionalHooks?.useState ?? [];
@@ -692,7 +520,8 @@ var rules = {
   "ensure-use-callback-has-non-empty-deps": ensure_use_callback_has_non_empty_deps_default,
   "ensure-use-memo-has-non-empty-deps": ensure_use_memo_has_non_empty_deps_default,
   "no-direct-set-state-in-use-effect": no_direct_set_state_in_use_effect_default,
-  "no-direct-set-state-in-use-layout-effect": no_direct_set_state_in_use_layout_effect_default,
+  /** @deprecated Use `no-direct-set-state-in-use-effect` instead */
+  "no-direct-set-state-in-use-layout-effect": no_direct_set_state_in_use_effect_default,
   "prefer-use-state-lazy-initialization": prefer_use_state_lazy_initialization_default
 };
 

package/dist/index.mjs

@@ -9,7 +9,7 @@ import { match, isMatching } from 'ts-pattern';
 
 // package.json
 var name = "eslint-plugin-react-hooks-extra";
-var version = "1.12.3";
+var version = "1.12.4-beta.3";
 var createRule = createRuleForPlugin("hooks-extra");
 function isFromHookCall(name2, context, settings, predicate = F.constTrue) {
   const hookAlias = settings.additionalHooks?.[name2] ?? [];
@@ -301,7 +301,17 @@ var no_direct_set_state_in_use_effect_default = createRule({
     if (!/use\w*Effect/u.test(context.sourceCode.text)) return {};
     const settings = decodeSettings(context.settings);
     const additionalHooks = settings.additionalHooks ?? {};
-    const isUseEffectCall = isReactHookCallWithNameAlias("useEffect", context, additionalHooks.useEffect ?? []);
+    const isUseEffectLikeCall = isReactHookCallWithNameAlias(
+      "useEffect",
+      context,
+      [
+        "useLayoutEffect",
+        "useInsertionEffect",
+        ...additionalHooks.useEffect ?? [],
+        ...additionalHooks.useLayoutEffect ?? [],
+        ...additionalHooks.useInsertionEffect ?? []
+      ]
+    );
     const isUseStateCall2 = isReactHookCallWithNameAlias("useState", context, additionalHooks.useState ?? []);
     const isUseMemoCall2 = isReactHookCallWithNameAlias("useMemo", context, additionalHooks.useMemo ?? []);
     const isUseCallbackCall2 = isReactHookCallWithNameAlias("useCallback", context, additionalHooks.useCallback ?? []);
@@ -322,10 +332,10 @@ var no_direct_set_state_in_use_effect_default = createRule({
       MutRef.update(setupFunctionRef, (current) => current === node ? null : current);
     };
     function isSetupFunction(node) {
-      return node.parent?.type === AST_NODE_TYPES.CallExpression && node.parent.callee !== node && isUseEffectCall(node.parent);
+      return node.parent?.type === AST_NODE_TYPES.CallExpression && node.parent.callee !== node && isUseEffectLikeCall(node.parent);
     }
     function getCallKind(node) {
-      return match(node).when(isUseStateCall2, () => "useState").when(isUseEffectCall, () => "useEffect").when(isSetStateCall, () => "setState").when(isThenCall, () => "then").otherwise(() => "other");
+      return match(node).when(isUseStateCall2, () => "useState").when(isUseEffectLikeCall, () => "useEffect").when(isSetStateCall, () => "setState").when(isThenCall, () => "then").otherwise(() => "other");
     }
     function getFunctionKind(node) {
       return match(node).when(isSetupFunction, () => "setup").when(isFunctionOfImmediatelyInvoked, () => "immediate").otherwise(() => "other");
@@ -389,7 +399,7 @@ var no_direct_set_state_in_use_effect_default = createRule({
               const calls = indirectSetStateCallsAsArgs.get(vd.init) ?? [];
               indirectSetStateCallsAsArgs.set(vd.init, [...calls, node]);
             }
-            if (isUseEffectCall(node.parent)) {
+            if (isUseEffectLikeCall(node.parent)) {
               const calls = indirectSetStateCallsAsArgs.get(node.parent) ?? [];
               indirectSetStateCallsAsSetups.set(node.parent, [...calls, node]);
             }
@@ -460,189 +470,7 @@ var no_direct_set_state_in_use_effect_default = createRule({
   },
   defaultOptions: []
 });
-var RULE_NAME5 = "no-direct-set-state-in-use-layout-effect";
-var no_direct_set_state_in_use_layout_effect_default = createRule({
-  meta: {
-    type: "problem",
-    docs: {
-      description: "disallow direct calls to the 'set' function of 'useState' in 'useLayoutEffect'"
-    },
-    messages: {
-      noDirectSetStateInUseLayoutEffect: "Do not call the 'set' function '{{name}}' of 'useState' directly in 'useLayoutEffect'."
-    },
-    schema: []
-  },
-  name: RULE_NAME5,
-  create(context) {
-    if (!/use\w*Effect/u.test(context.sourceCode.text)) return {};
-    const settings = decodeSettings(context.settings);
-    const additionalHooks = settings.additionalHooks ?? {};
-    const isUseEffectCall = isReactHookCallWithNameAlias(
-      "useLayoutEffect",
-      context,
-      additionalHooks.useLayoutEffect ?? []
-    );
-    const isUseStateCall2 = isReactHookCallWithNameAlias("useState", context, additionalHooks.useState ?? []);
-    const isUseMemoCall2 = isReactHookCallWithNameAlias("useMemo", context, additionalHooks.useMemo ?? []);
-    const isUseCallbackCall2 = isReactHookCallWithNameAlias("useCallback", context, additionalHooks.useCallback ?? []);
-    const isSetStateCall = isSetFunctionCall(context, settings);
-    const isIdFromUseStateCall = isFromUseStateCall(context, settings);
-    const functionStack = [];
-    const setupFunctionRef = MutRef.make(null);
-    const setupFunctionIdentifiers = [];
-    const indirectFunctionCalls = [];
-    const indirectSetStateCalls = /* @__PURE__ */ new WeakMap();
-    const indirectSetStateCallsAsSetups = /* @__PURE__ */ new Map();
-    const indirectSetStateCallsAsArgs = /* @__PURE__ */ new WeakMap();
-    const indirectSetStateCallsInHooks = /* @__PURE__ */ new WeakMap();
-    const onSetupFunctionEnter = (node) => {
-      MutRef.set(setupFunctionRef, node);
-    };
-    const onSetupFunctionExit = (node) => {
-      MutRef.update(setupFunctionRef, (current) => current === node ? null : current);
-    };
-    function isSetupFunction(node) {
-      return node.parent?.type === AST_NODE_TYPES.CallExpression && node.parent.callee !== node && isUseEffectCall(node.parent);
-    }
-    function getCallKind(node) {
-      return match(node).when(isUseStateCall2, () => "useState").when(isUseEffectCall, () => "useLayoutEffect").when(isSetStateCall, () => "setState").when(isThenCall, () => "then").otherwise(() => "other");
-    }
-    function getFunctionKind(node) {
-      return match(node).when(isSetupFunction, () => "setup").when(isFunctionOfImmediatelyInvoked, () => "immediate").otherwise(() => "other");
-    }
-    return {
-      ":function"(node) {
-        const functionKind = getFunctionKind(node);
-        functionStack.push([node, functionKind]);
-        if (functionKind === "setup") onSetupFunctionEnter(node);
-      },
-      ":function:exit"(node) {
-        const [_, functionKind] = functionStack.at(-1) ?? [];
-        functionStack.pop();
-        if (functionKind === "setup") onSetupFunctionExit(node);
-      },
-      CallExpression(node) {
-        const effectFn = MutRef.get(setupFunctionRef);
-        const [parentFn, parentFnKind] = functionStack.at(-1) ?? [];
-        if (parentFn?.async) return;
-        match(getCallKind(node)).with("setState", () => {
-          if (!parentFn) return;
-          if (parentFn !== effectFn && parentFnKind !== "immediate") {
-            const maybeVd = traverseUpGuard(node, isVariableDeclaratorFromHookCall);
-            if (O.isSome(maybeVd)) {
-              const vd = maybeVd.value;
-              const calls2 = indirectSetStateCallsInHooks.get(vd.init) ?? [];
-              indirectSetStateCallsInHooks.set(vd.init, [...calls2, node]);
-              return;
-            }
-            const calls = indirectSetStateCalls.get(parentFn) ?? [];
-            indirectSetStateCalls.set(parentFn, [...calls, node]);
-            return;
-          }
-          context.report({
-            messageId: "noDirectSetStateInUseLayoutEffect",
-            node,
-            data: {
-              name: context.sourceCode.getText(node.callee)
-            }
-          });
-        }).with("useLayoutEffect", () => {
-          const [firstArg] = node.arguments;
-          if (isFunction(firstArg)) return;
-          const identifiers = getNestedIdentifiers(node);
-          setupFunctionIdentifiers.push(...identifiers);
-        }).with("other", () => {
-          const isInSetupFunction = effectFn === parentFn;
-          if (!isInSetupFunction) return;
-          indirectFunctionCalls.push(node);
-        }).otherwise(F.constVoid);
-      },
-      Identifier(node) {
-        if (node.parent.type === AST_NODE_TYPES.CallExpression && node.parent.callee === node) return;
-        if (!isIdFromUseStateCall(node)) return;
-        switch (node.parent.type) {
-          case AST_NODE_TYPES.CallExpression: {
-            const [firstArg] = node.parent.arguments;
-            if (node !== firstArg) break;
-            if (isUseCallbackCall2(node.parent)) {
-              const maybeVd = traverseUpGuard(node.parent, isVariableDeclaratorFromHookCall);
-              if (O.isNone(maybeVd)) break;
-              const vd = maybeVd.value;
-              const calls = indirectSetStateCallsAsArgs.get(vd.init) ?? [];
-              indirectSetStateCallsAsArgs.set(vd.init, [...calls, node]);
-            }
-            if (isUseEffectCall(node.parent)) {
-              const calls = indirectSetStateCallsAsArgs.get(node.parent) ?? [];
-              indirectSetStateCallsAsSetups.set(node.parent, [...calls, node]);
-            }
-            break;
-          }
-          case AST_NODE_TYPES.ArrowFunctionExpression: {
-            const parent = node.parent.parent;
-            if (parent.type !== AST_NODE_TYPES.CallExpression) break;
-            if (!isUseMemoCall2(parent)) break;
-            const maybeVd = traverseUpGuard(parent, isVariableDeclaratorFromHookCall);
-            if (O.isNone(maybeVd)) break;
-            const vd = maybeVd.value;
-            const calls = indirectSetStateCallsAsArgs.get(vd.init) ?? [];
-            indirectSetStateCallsAsArgs.set(vd.init, [...calls, node]);
-          }
-        }
-      },
-      "Program:exit"() {
-        const getSetStateCalls = (id, initialScope) => {
-          const node = O.flatMap(findVariable(id, initialScope), getVariableNode(0)).pipe(O.getOrNull);
-          switch (node?.type) {
-            case AST_NODE_TYPES.FunctionDeclaration:
-            case AST_NODE_TYPES.FunctionExpression:
-            case AST_NODE_TYPES.ArrowFunctionExpression:
-              return indirectSetStateCalls.get(node) ?? [];
-            case AST_NODE_TYPES.CallExpression:
-              return indirectSetStateCallsInHooks.get(node) ?? indirectSetStateCallsAsArgs.get(node) ?? [];
-          }
-          return [];
-        };
-        for (const [_, calls] of indirectSetStateCallsAsSetups) {
-          for (const call of calls) {
-            context.report({
-              messageId: "noDirectSetStateInUseLayoutEffect",
-              node: call,
-              data: { name: call.name }
-            });
-          }
-        }
-        for (const { callee } of indirectFunctionCalls) {
-          if (!("name" in callee)) continue;
-          const { name: name2 } = callee;
-          const setStateCalls = getSetStateCalls(name2, context.sourceCode.getScope(callee));
-          for (const setStateCall of setStateCalls) {
-            context.report({
-              messageId: "noDirectSetStateInUseLayoutEffect",
-              node: setStateCall,
-              data: {
-                name: toReadableNodeName(setStateCall, (n) => context.sourceCode.getText(n))
-              }
-            });
-          }
-        }
-        for (const id of setupFunctionIdentifiers) {
-          const setStateCalls = getSetStateCalls(id.name, context.sourceCode.getScope(id));
-          for (const setStateCall of setStateCalls) {
-            context.report({
-              messageId: "noDirectSetStateInUseLayoutEffect",
-              node: setStateCall,
-              data: {
-                name: toReadableNodeName(setStateCall, (n) => context.sourceCode.getText(n))
-              }
-            });
-          }
-        }
-      }
-    };
-  },
-  defaultOptions: []
-});
-var RULE_NAME6 = "prefer-use-state-lazy-initialization";
+var RULE_NAME5 = "prefer-use-state-lazy-initialization";
 var ALLOW_LIST = ["Boolean", "String", "Number"];
 var prefer_use_state_lazy_initialization_default = createRule({
   meta: {
@@ -655,7 +483,7 @@ var prefer_use_state_lazy_initialization_default = createRule({
     },
     schema: []
   },
-  name: RULE_NAME6,
+  name: RULE_NAME5,
   create(context) {
     if (!context.sourceCode.text.includes("use")) return {};
     const alias = decodeSettings(context.settings).additionalHooks?.useState ?? [];
@@ -690,7 +518,8 @@ var rules = {
   "ensure-use-callback-has-non-empty-deps": ensure_use_callback_has_non_empty_deps_default,
   "ensure-use-memo-has-non-empty-deps": ensure_use_memo_has_non_empty_deps_default,
   "no-direct-set-state-in-use-effect": no_direct_set_state_in_use_effect_default,
-  "no-direct-set-state-in-use-layout-effect": no_direct_set_state_in_use_layout_effect_default,
+  /** @deprecated Use `no-direct-set-state-in-use-effect` instead */
+  "no-direct-set-state-in-use-layout-effect": no_direct_set_state_in_use_effect_default,
   "prefer-use-state-lazy-initialization": prefer_use_state_lazy_initialization_default
 };
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-hooks-extra",
-  "version": "1.12.3",
+  "version": "1.12.4-beta.3",
   "description": "ESLint React's ESLint plugin for React Hooks related rules.",
   "keywords": [
     "eslint",
@@ -46,16 +46,16 @@
     "@typescript-eslint/types": "^8.3.0",
     "@typescript-eslint/utils": "^8.3.0",
     "ts-pattern": "^5.3.1",
-    "@eslint-react/ast": "1.12.3",
-    "@eslint-react/core": "1.12.3",
-    "@eslint-react/shared": "1.12.3",
-    "@eslint-react/tools": "1.12.3",
-    "@eslint-react/jsx": "1.12.3",
-    "@eslint-react/types": "1.12.3",
-    "@eslint-react/var": "1.12.3"
+    "@eslint-react/ast": "1.12.4-beta.3",
+    "@eslint-react/core": "1.12.4-beta.3",
+    "@eslint-react/jsx": "1.12.4-beta.3",
+    "@eslint-react/shared": "1.12.4-beta.3",
+    "@eslint-react/tools": "1.12.4-beta.3",
+    "@eslint-react/var": "1.12.4-beta.3",
+    "@eslint-react/types": "1.12.4-beta.3"
   },
   "devDependencies": {
-    "@types/react": "^18.3.4",
+    "@types/react": "^18.3.5",
     "@types/react-dom": "^18.3.0",
     "string-ts": "^2.2.0",
     "tsup": "^8.2.4"