eslint-plugin-react-features 1.2.9 → 1.2.10

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (65) hide show
  1. package/package.json +2 -2
  2. package/src/index.js +1 -179
  3. package/src/oxlint.js +1 -3
  4. package/src/rules/component-api/no-arbitrary-token-class.js +1 -74
  5. package/src/rules/component-api/no-default-test-id.js +1 -46
  6. package/src/rules/component-api/no-inline-style.js +1 -57
  7. package/src/rules/component-api/no-is-prefix-prop.js +1 -59
  8. package/src/rules/component-api/no-kind-prop-discriminator.js +1 -57
  9. package/src/rules/component-api/no-raw-color-literal.js +1 -55
  10. package/src/rules/component-api/no-wrapper-sub-component.js +1 -95
  11. package/src/rules/component-api/require-data-slot.js +1 -40
  12. package/src/rules/migration/react-class-to-hooks.js +1 -159
  13. package/src/rules/performance/no-unnecessary-rerenders.js +1 -185
  14. package/src/rules/performance/react-no-inline-functions.js +1 -187
  15. package/src/rules/performance/react-render-optimization.js +1 -256
  16. package/src/rules/react/checked-requires-onchange-or-readonly.js +1 -68
  17. package/src/rules/react/default-props-match-prop-types.js +1 -99
  18. package/src/rules/react/display-name.js +1 -133
  19. package/src/rules/react/hooks-exhaustive-deps.js +1 -466
  20. package/src/rules/react/jsx-handler-names.js +1 -50
  21. package/src/rules/react/jsx-key.js +1 -323
  22. package/src/rules/react/jsx-max-depth.js +1 -71
  23. package/src/rules/react/jsx-no-bind.js +1 -55
  24. package/src/rules/react/jsx-no-duplicate-props.js +1 -66
  25. package/src/rules/react/jsx-no-literals.js +1 -79
  26. package/src/rules/react/jsx-no-script-url.js +1 -119
  27. package/src/rules/react/jsx-no-target-blank.js +1 -163
  28. package/src/rules/react/no-access-state-in-setstate.js +1 -80
  29. package/src/rules/react/no-adjacent-inline-elements.js +1 -72
  30. package/src/rules/react/no-arrow-function-lifecycle.js +1 -57
  31. package/src/rules/react/no-children-prop.js +1 -54
  32. package/src/rules/react/no-danger-with-children.js +1 -99
  33. package/src/rules/react/no-danger.js +1 -43
  34. package/src/rules/react/no-deprecated.js +1 -130
  35. package/src/rules/react/no-did-mount-set-state.js +1 -50
  36. package/src/rules/react/no-did-update-set-state.js +1 -71
  37. package/src/rules/react/no-direct-mutation-state.js +3 -211
  38. package/src/rules/react/no-find-dom-node.js +1 -50
  39. package/src/rules/react/no-invalid-html-attribute.js +1 -80
  40. package/src/rules/react/no-is-mounted.js +1 -46
  41. package/src/rules/react/no-multi-comp.js +1 -150
  42. package/src/rules/react/no-namespace.js +1 -37
  43. package/src/rules/react/no-object-type-as-default-prop.js +1 -53
  44. package/src/rules/react/no-redundant-should-component-update.js +1 -50
  45. package/src/rules/react/no-render-return-value.js +1 -67
  46. package/src/rules/react/no-set-state.js +1 -45
  47. package/src/rules/react/no-string-refs.js +1 -61
  48. package/src/rules/react/no-this-in-sfc.js +1 -55
  49. package/src/rules/react/no-typos.js +1 -90
  50. package/src/rules/react/no-unescaped-entities.js +1 -44
  51. package/src/rules/react/no-unknown-property.js +1 -124
  52. package/src/rules/react/no-unsafe.js +1 -106
  53. package/src/rules/react/prefer-es6-class.js +1 -50
  54. package/src/rules/react/prefer-stateless-function.js +1 -126
  55. package/src/rules/react/prop-types.js +1 -143
  56. package/src/rules/react/react-in-jsx-scope.js +1 -86
  57. package/src/rules/react/require-default-props.js +1 -134
  58. package/src/rules/react/require-optimization.js +1 -397
  59. package/src/rules/react/require-render-return.js +1 -79
  60. package/src/rules/react/required-attributes.js +1 -185
  61. package/src/rules/react/sort-comp.js +1 -146
  62. package/src/rules/react/state-in-constructor.js +1 -95
  63. package/src/rules/react/static-property-placement.js +1 -122
  64. package/src/rules/react/void-dom-elements-no-children.js +1 -89
  65. package/src/types/index.js +1 -2
@@ -1,79 +1 @@
1
- "use strict";
2
- Object.defineProperty(exports, "__esModule", { value: true });
3
- exports.requireRenderReturn = void 0;
4
- const eslint_devkit_1 = require("@interlace/eslint-devkit");
5
- const eslint_devkit_2 = require("@interlace/eslint-devkit");
6
- exports.requireRenderReturn = (0, eslint_devkit_1.createRule)({
7
- name: 'require-render-return',
8
- meta: {
9
- type: 'problem',
10
- docs: {
11
- url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-react-features/docs/rules/require-render-return.md',
12
- description: 'Require render methods to return',
13
- },
14
- schema: [],
15
- messages: {
16
- requireRenderReturn: (0, eslint_devkit_2.formatLLMMessage)({
17
- icon: eslint_devkit_2.MessageIcons.WARNING,
18
- issueName: 'Missing Render Return',
19
- description: 'Render method must return a value',
20
- severity: 'CRITICAL',
21
- fix: 'Add return statement or return JSX/null',
22
- documentationLink: 'https://react.dev/reference/react/Component#render',
23
- }),
24
- },
25
- },
26
- defaultOptions: [],
27
- create(context) {
28
- return {
29
- MethodDefinition(node) {
30
- if (node.key.type === 'Identifier' &&
31
- node.key.name === 'render' &&
32
- node.value.type === 'FunctionExpression') {
33
- const body = node.value.body;
34
- if (!hasReturnStatement(body)) {
35
- context.report({
36
- node: node.key,
37
- messageId: 'requireRenderReturn',
38
- });
39
- }
40
- }
41
- },
42
- };
43
- function hasReturnStatement(node) {
44
- if (node.type === 'BlockStatement') {
45
- for (const statement of node.body) {
46
- if (checkStatement(statement)) {
47
- return true;
48
- }
49
- }
50
- return false;
51
- }
52
- return checkStatement(node);
53
- }
54
- function checkStatement(statement) {
55
- if (statement.type === 'ReturnStatement') {
56
- return true;
57
- }
58
- if (statement.type === 'IfStatement') {
59
- if (hasReturnStatement(statement.consequent) ||
60
- (statement.alternate && hasReturnStatement(statement.alternate))) {
61
- return true;
62
- }
63
- }
64
- if (statement.type === 'BlockStatement') {
65
- return hasReturnStatement(statement);
66
- }
67
- if (statement.type === 'SwitchStatement') {
68
- for (const switchCase of statement.cases) {
69
- for (const caseStatement of switchCase.consequent) {
70
- if (caseStatement.type === 'ReturnStatement') {
71
- return true;
72
- }
73
- }
74
- }
75
- }
76
- return false;
77
- }
78
- },
79
- });
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requireRenderReturn=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");exports.requireRenderReturn=(0,eslint_devkit_1.createRule)({name:"require-render-return",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-react-features/docs/rules/require-render-return.md",description:"Require render methods to return"},schema:[],messages:{requireRenderReturn:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.WARNING,issueName:"Missing Render Return",description:"Render method must return a value",severity:"CRITICAL",fix:"Add return statement or return JSX/null",documentationLink:"https://react.dev/reference/react/Component#render"})}},defaultOptions:[],create(context){return{MethodDefinition(node){if(node.key.type==="Identifier"&&node.key.name==="render"&&node.value.type==="FunctionExpression"){const body=node.value.body;if(!hasReturnStatement(body)){context.report({node:node.key,messageId:"requireRenderReturn"})}}}};function hasReturnStatement(node){if(node.type==="BlockStatement"){for(const statement of node.body){if(checkStatement(statement)){return true}}return false}return checkStatement(node)}function checkStatement(statement){if(statement.type==="ReturnStatement"){return true}if(statement.type==="IfStatement"){if(hasReturnStatement(statement.consequent)||statement.alternate&&hasReturnStatement(statement.alternate)){return true}}if(statement.type==="BlockStatement"){return hasReturnStatement(statement)}if(statement.type==="SwitchStatement"){for(const switchCase of statement.cases){for(const caseStatement of switchCase.consequent){if(caseStatement.type==="ReturnStatement"){return true}}}}return false}}});
@@ -1,185 +1 @@
1
- "use strict";
2
- Object.defineProperty(exports, "__esModule", { value: true });
3
- exports.requiredAttributes = void 0;
4
- const eslint_devkit_1 = require("@interlace/eslint-devkit");
5
- const eslint_devkit_2 = require("@interlace/eslint-devkit");
6
- exports.requiredAttributes = (0, eslint_devkit_2.createRule)({
7
- name: 'required-attributes',
8
- meta: {
9
- type: 'problem',
10
- docs: {
11
- url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-react-features/docs/rules/required-attributes.md',
12
- description: 'Enforce required attributes on React components with customizable ignore lists',
13
- cwe: 'CWE-252',
14
- cvss: 5,
15
- },
16
- fixable: 'code',
17
- hasSuggestions: true,
18
- messages: {
19
- missingAttribute: (0, eslint_devkit_1.formatLLMMessage)({
20
- icon: '📝',
21
- issueName: 'Missing required attribute',
22
- cwe: 'CWE-252',
23
- description: '{{element}} missing {{attribute}}',
24
- severity: 'MEDIUM',
25
- fix: 'Add {{attribute}}="{{suggestedValue}}" ({{purpose}})',
26
- documentationLink: 'https://www.w3.org/WAI/fundamentals/accessibility-intro/',
27
- }),
28
- addAttribute: (0, eslint_devkit_1.formatLLMMessage)({
29
- icon: eslint_devkit_1.MessageIcons.INFO,
30
- issueName: 'Add Attribute',
31
- description: 'Add required attribute',
32
- severity: 'LOW',
33
- fix: '{{attribute}}="{{suggestedValue}}"',
34
- documentationLink: 'https://www.w3.org/WAI/fundamentals/accessibility-intro/',
35
- }),
36
- },
37
- schema: [
38
- {
39
- type: 'object',
40
- properties: {
41
- attributes: {
42
- type: 'array',
43
- items: {
44
- type: 'object',
45
- properties: {
46
- attribute: { type: 'string' },
47
- ignoreTags: {
48
- type: 'array',
49
- items: { type: 'string' },
50
- },
51
- message: { type: 'string' },
52
- suggestedValue: { type: 'string' },
53
- },
54
- required: ['attribute'],
55
- },
56
- default: [],
57
- },
58
- ignoreComponents: {
59
- type: 'array',
60
- items: { type: 'string' },
61
- default: [],
62
- description: 'Components to ignore globally',
63
- },
64
- },
65
- additionalProperties: false,
66
- },
67
- ],
68
- },
69
- defaultOptions: [
70
- {
71
- attributes: [],
72
- ignoreComponents: [],
73
- },
74
- ],
75
- create(context) {
76
- const options = context.options[0] || {};
77
- const { attributes = [], ignoreComponents = [] } = options;
78
- const getElementName = (node) => {
79
- if (node.name.type === 'JSXIdentifier') {
80
- return node.name.name;
81
- }
82
- if (node.name.type === 'JSXMemberExpression') {
83
- let current = node.name;
84
- const parts = [];
85
- while (current.type === 'JSXMemberExpression') {
86
- if (current.property.type === 'JSXIdentifier') {
87
- parts.unshift(current.property.name);
88
- }
89
- current = current.object;
90
- }
91
- if (current.type === 'JSXIdentifier') {
92
- parts.unshift(current.name);
93
- }
94
- return parts.join('.');
95
- }
96
- return null;
97
- };
98
- const hasAttribute = (node, attrName) => {
99
- return node.attributes.some((attr) => {
100
- if (attr.type !== 'JSXAttribute')
101
- return false;
102
- if (attr.name.type !== 'JSXIdentifier')
103
- return false;
104
- return attr.name.name === attrName;
105
- });
106
- };
107
- const getAttributePurpose = (attribute) => {
108
- const purposes = {
109
- 'data-testid': 'Testing & QA automation',
110
- 'aria-label': 'Accessibility for screen readers',
111
- 'aria-describedby': 'Accessibility description',
112
- 'aria-labelledby': 'Accessibility label reference',
113
- 'role': 'Accessibility role definition',
114
- 'tabIndex': 'Keyboard navigation order',
115
- 'alt': 'Image accessibility',
116
- 'title': 'Tooltip / additional context',
117
- 'id': 'Element identification',
118
- };
119
- return purposes[attribute] || 'Required for consistency';
120
- };
121
- const isFormElement = (elementName) => {
122
- return ['input', 'button', 'select', 'textarea'].includes(elementName.toLowerCase());
123
- };
124
- const getDefaultSuggestedValue = (attribute, elementName) => {
125
- if (attribute === 'data-testid') {
126
- const kebab = elementName.replace(/([a-z])([A-Z])/g, '$1-$2').toLowerCase();
127
- return kebab;
128
- }
129
- if (attribute.startsWith('aria-')) {
130
- return 'TODO: Add descriptive label';
131
- }
132
- if (attribute === 'tabIndex') {
133
- return '0';
134
- }
135
- return 'TODO';
136
- };
137
- return {
138
- JSXOpeningElement(node) {
139
- const elementName = getElementName(node);
140
- if (!elementName)
141
- return;
142
- if (ignoreComponents.includes(elementName)) {
143
- return;
144
- }
145
- for (const attrRule of attributes) {
146
- const { attribute, ignoreTags = [], message, suggestedValue } = attrRule;
147
- if (ignoreTags.includes(elementName)) {
148
- continue;
149
- }
150
- if ((attribute === 'type' || attribute === 'name') && !isFormElement(elementName)) {
151
- continue;
152
- }
153
- if (hasAttribute(node, attribute)) {
154
- continue;
155
- }
156
- const purpose = message || getAttributePurpose(attribute);
157
- const defaultValue = suggestedValue || getDefaultSuggestedValue(attribute, elementName);
158
- context.report({
159
- node,
160
- messageId: 'missingAttribute',
161
- data: {
162
- element: elementName,
163
- attribute,
164
- suggestedValue: defaultValue,
165
- purpose,
166
- },
167
- suggest: [
168
- {
169
- messageId: 'addAttribute',
170
- data: {
171
- attribute,
172
- suggestedValue: defaultValue,
173
- },
174
- fix: (fixer) => {
175
- const nameNode = node.name;
176
- return fixer.insertTextAfter(nameNode, ` ${attribute}="${defaultValue}"`);
177
- },
178
- },
179
- ],
180
- });
181
- }
182
- },
183
- };
184
- },
185
- });
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.requiredAttributes=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");exports.requiredAttributes=(0,eslint_devkit_2.createRule)({name:"required-attributes",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-react-features/docs/rules/required-attributes.md",description:"Enforce required attributes on React components with customizable ignore lists",cwe:"CWE-252",cvss:5},fixable:"code",hasSuggestions:true,messages:{missingAttribute:(0,eslint_devkit_1.formatLLMMessage)({icon:"\u{1F4DD}",issueName:"Missing required attribute",cwe:"CWE-252",description:"{{element}} missing {{attribute}}",severity:"MEDIUM",fix:'Add {{attribute}}="{{suggestedValue}}" ({{purpose}})',documentationLink:"https://www.w3.org/WAI/fundamentals/accessibility-intro/"}),addAttribute:(0,eslint_devkit_1.formatLLMMessage)({icon:eslint_devkit_1.MessageIcons.INFO,issueName:"Add Attribute",description:"Add required attribute",severity:"LOW",fix:'{{attribute}}="{{suggestedValue}}"',documentationLink:"https://www.w3.org/WAI/fundamentals/accessibility-intro/"})},schema:[{type:"object",properties:{attributes:{type:"array",items:{type:"object",properties:{attribute:{type:"string"},ignoreTags:{type:"array",items:{type:"string"}},message:{type:"string"},suggestedValue:{type:"string"}},required:["attribute"]},default:[]},ignoreComponents:{type:"array",items:{type:"string"},default:[],description:"Components to ignore globally"}},additionalProperties:false}]},defaultOptions:[{attributes:[],ignoreComponents:[]}],create(context){const options=context.options[0]||{};const{attributes=[],ignoreComponents=[]}=options;const getElementName=node=>{if(node.name.type==="JSXIdentifier"){return node.name.name}if(node.name.type==="JSXMemberExpression"){let current=node.name;const parts=[];while(current.type==="JSXMemberExpression"){if(current.property.type==="JSXIdentifier"){parts.unshift(current.property.name)}current=current.object}if(current.type==="JSXIdentifier"){parts.unshift(current.name)}return parts.join(".")}return null};const hasAttribute=(node,attrName)=>{return node.attributes.some(attr=>{if(attr.type!=="JSXAttribute")return false;if(attr.name.type!=="JSXIdentifier")return false;return attr.name.name===attrName})};const getAttributePurpose=attribute=>{const purposes={"data-testid":"Testing & QA automation","aria-label":"Accessibility for screen readers","aria-describedby":"Accessibility description","aria-labelledby":"Accessibility label reference","role":"Accessibility role definition","tabIndex":"Keyboard navigation order","alt":"Image accessibility","title":"Tooltip / additional context","id":"Element identification"};return purposes[attribute]||"Required for consistency"};const isFormElement=elementName=>{return["input","button","select","textarea"].includes(elementName.toLowerCase())};const getDefaultSuggestedValue=(attribute,elementName)=>{if(attribute==="data-testid"){const kebab=elementName.replace(/([a-z])([A-Z])/g,"$1-$2").toLowerCase();return kebab}if(attribute.startsWith("aria-")){return"TODO: Add descriptive label"}if(attribute==="tabIndex"){return"0"}return"TODO"};return{JSXOpeningElement(node){const elementName=getElementName(node);if(!elementName)return;if(ignoreComponents.includes(elementName)){return}for(const attrRule of attributes){const{attribute,ignoreTags=[],message,suggestedValue}=attrRule;if(ignoreTags.includes(elementName)){continue}if((attribute==="type"||attribute==="name")&&!isFormElement(elementName)){continue}if(hasAttribute(node,attribute)){continue}const purpose=message||getAttributePurpose(attribute);const defaultValue=suggestedValue||getDefaultSuggestedValue(attribute,elementName);context.report({node,messageId:"missingAttribute",data:{element:elementName,attribute,suggestedValue:defaultValue,purpose},suggest:[{messageId:"addAttribute",data:{attribute,suggestedValue:defaultValue},fix:fixer=>{const nameNode=node.name;return fixer.insertTextAfter(nameNode,` ${attribute}="${defaultValue}"`)}}]})}}}}});
@@ -1,146 +1 @@
1
- "use strict";
2
- Object.defineProperty(exports, "__esModule", { value: true });
3
- exports.sortComp = void 0;
4
- const eslint_devkit_1 = require("@interlace/eslint-devkit");
5
- const eslint_devkit_2 = require("@interlace/eslint-devkit");
6
- const DEFAULT_ORDER = [
7
- 'static-variables',
8
- 'static-methods',
9
- 'instance-variables',
10
- 'lifecycle',
11
- 'everything-else',
12
- 'render'
13
- ];
14
- const LIFECYCLE_METHODS = new Set([
15
- 'constructor',
16
- 'getDerivedStateFromProps',
17
- 'componentWillMount',
18
- 'UNSAFE_componentWillMount',
19
- 'componentDidMount',
20
- 'componentWillReceiveProps',
21
- 'UNSAFE_componentWillReceiveProps',
22
- 'shouldComponentUpdate',
23
- 'componentWillUpdate',
24
- 'UNSAFE_componentWillUpdate',
25
- 'getSnapshotBeforeUpdate',
26
- 'componentDidUpdate',
27
- 'componentDidCatch',
28
- 'componentWillUnmount',
29
- ]);
30
- exports.sortComp = (0, eslint_devkit_1.createRule)({
31
- name: 'sort-comp',
32
- meta: {
33
- type: 'problem',
34
- docs: {
35
- url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-react-features/docs/rules/sort-comp.md',
36
- description: 'Enforce component method ordering',
37
- },
38
- messages: {
39
- sortComp: (0, eslint_devkit_2.formatLLMMessage)({
40
- icon: eslint_devkit_2.MessageIcons.WARNING,
41
- issueName: 'Method Order Violation',
42
- description: 'Component methods are not in the correct order',
43
- severity: 'LOW',
44
- fix: 'Reorder methods according to component lifecycle',
45
- documentationLink: 'https://react.dev/reference/react/Component',
46
- }),
47
- },
48
- schema: [
49
- {
50
- type: 'object',
51
- properties: {
52
- order: {
53
- type: 'array',
54
- items: { type: 'string' },
55
- },
56
- },
57
- additionalProperties: false,
58
- },
59
- ],
60
- },
61
- defaultOptions: [{ order: DEFAULT_ORDER }],
62
- create(context) {
63
- const [options] = context.options;
64
- const order = options?.order ?? DEFAULT_ORDER;
65
- return {
66
- ClassDeclaration(node) {
67
- if (isReactComponent(node)) {
68
- checkMethodOrder(node, order);
69
- }
70
- },
71
- };
72
- function isReactComponent(node) {
73
- if (!node.superClass)
74
- return false;
75
- if (node.superClass.type === 'Identifier') {
76
- return node.superClass.name === 'Component' || node.superClass.name === 'PureComponent';
77
- }
78
- if (node.superClass.type === 'MemberExpression') {
79
- return (node.superClass.object.type === 'Identifier' &&
80
- node.superClass.object.name === 'React' &&
81
- node.superClass.property.type === 'Identifier' &&
82
- (node.superClass.property.name === 'Component' || node.superClass.property.name === 'PureComponent'));
83
- }
84
- return false;
85
- }
86
- function checkMethodOrder(node, sortOrder) {
87
- const members = node.body.body;
88
- const methodOrder = [];
89
- for (let i = 0; i < members.length; i++) {
90
- const member = members[i];
91
- const methodName = getMemberName(member);
92
- if (methodName) {
93
- const orderIndex = getOrderIndex(methodName, member, sortOrder);
94
- methodOrder.push({ name: methodName, index: orderIndex, node: member });
95
- }
96
- }
97
- for (let i = 1; i < methodOrder.length; i++) {
98
- if (methodOrder[i].index < methodOrder[i - 1].index) {
99
- context.report({
100
- node: getMemberKeyNode(methodOrder[i].node),
101
- messageId: 'sortComp',
102
- });
103
- break;
104
- }
105
- }
106
- }
107
- function getMemberName(member) {
108
- if (member.type === 'MethodDefinition' && member.key.type === 'Identifier') {
109
- return member.key.name;
110
- }
111
- if (member.type === 'PropertyDefinition' && member.key.type === 'Identifier') {
112
- return member.key.name;
113
- }
114
- return null;
115
- }
116
- function getMemberKeyNode(member) {
117
- if (member.type === 'MethodDefinition' && member.key.type === 'Identifier') {
118
- return member.key;
119
- }
120
- if (member.type === 'PropertyDefinition' && member.key.type === 'Identifier') {
121
- return member.key;
122
- }
123
- return member;
124
- }
125
- function getOrderIndex(name, member, sortOrder) {
126
- if (member.type === 'MethodDefinition' && member.static) {
127
- if (name === 'render')
128
- return sortOrder.indexOf('render');
129
- return sortOrder.indexOf('static-methods');
130
- }
131
- if (member.type === 'PropertyDefinition' && member.static) {
132
- return sortOrder.indexOf('static-variables');
133
- }
134
- if (member.type === 'PropertyDefinition' && !member.static) {
135
- return sortOrder.indexOf('instance-variables');
136
- }
137
- if (LIFECYCLE_METHODS.has(name)) {
138
- return sortOrder.indexOf('lifecycle');
139
- }
140
- if (name === 'render') {
141
- return sortOrder.indexOf('render');
142
- }
143
- return sortOrder.indexOf('everything-else');
144
- }
145
- },
146
- });
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.sortComp=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const DEFAULT_ORDER=["static-variables","static-methods","instance-variables","lifecycle","everything-else","render"];const LIFECYCLE_METHODS=new Set(["constructor","getDerivedStateFromProps","componentWillMount","UNSAFE_componentWillMount","componentDidMount","componentWillReceiveProps","UNSAFE_componentWillReceiveProps","shouldComponentUpdate","componentWillUpdate","UNSAFE_componentWillUpdate","getSnapshotBeforeUpdate","componentDidUpdate","componentDidCatch","componentWillUnmount"]);exports.sortComp=(0,eslint_devkit_1.createRule)({name:"sort-comp",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-react-features/docs/rules/sort-comp.md",description:"Enforce component method ordering"},messages:{sortComp:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.WARNING,issueName:"Method Order Violation",description:"Component methods are not in the correct order",severity:"LOW",fix:"Reorder methods according to component lifecycle",documentationLink:"https://react.dev/reference/react/Component"})},schema:[{type:"object",properties:{order:{type:"array",items:{type:"string"}}},additionalProperties:false}]},defaultOptions:[{order:DEFAULT_ORDER}],create(context){const[options]=context.options;const order=options?.order??DEFAULT_ORDER;return{ClassDeclaration(node){if(isReactComponent(node)){checkMethodOrder(node,order)}}};function isReactComponent(node){if(!node.superClass)return false;if(node.superClass.type==="Identifier"){return node.superClass.name==="Component"||node.superClass.name==="PureComponent"}if(node.superClass.type==="MemberExpression"){return node.superClass.object.type==="Identifier"&&node.superClass.object.name==="React"&&node.superClass.property.type==="Identifier"&&(node.superClass.property.name==="Component"||node.superClass.property.name==="PureComponent")}return false}function checkMethodOrder(node,sortOrder){const members=node.body.body;const methodOrder=[];for(let i=0;i<members.length;i++){const member=members[i];const methodName=getMemberName(member);if(methodName){const orderIndex=getOrderIndex(methodName,member,sortOrder);methodOrder.push({name:methodName,index:orderIndex,node:member})}}for(let i=1;i<methodOrder.length;i++){if(methodOrder[i].index<methodOrder[i-1].index){context.report({node:getMemberKeyNode(methodOrder[i].node),messageId:"sortComp"});break}}}function getMemberName(member){if(member.type==="MethodDefinition"&&member.key.type==="Identifier"){return member.key.name}if(member.type==="PropertyDefinition"&&member.key.type==="Identifier"){return member.key.name}return null}function getMemberKeyNode(member){if(member.type==="MethodDefinition"&&member.key.type==="Identifier"){return member.key}if(member.type==="PropertyDefinition"&&member.key.type==="Identifier"){return member.key}return member}function getOrderIndex(name,member,sortOrder){if(member.type==="MethodDefinition"&&member.static){if(name==="render")return sortOrder.indexOf("render");return sortOrder.indexOf("static-methods")}if(member.type==="PropertyDefinition"&&member.static){return sortOrder.indexOf("static-variables")}if(member.type==="PropertyDefinition"&&!member.static){return sortOrder.indexOf("instance-variables")}if(LIFECYCLE_METHODS.has(name)){return sortOrder.indexOf("lifecycle")}if(name==="render"){return sortOrder.indexOf("render")}return sortOrder.indexOf("everything-else")}}});
@@ -1,95 +1 @@
1
- "use strict";
2
- Object.defineProperty(exports, "__esModule", { value: true });
3
- exports.stateInConstructor = void 0;
4
- const eslint_devkit_1 = require("@interlace/eslint-devkit");
5
- const eslint_devkit_2 = require("@interlace/eslint-devkit");
6
- exports.stateInConstructor = (0, eslint_devkit_1.createRule)({
7
- name: 'state-in-constructor',
8
- meta: {
9
- type: 'problem',
10
- docs: {
11
- url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-react-features/docs/rules/state-in-constructor.md',
12
- description: 'Enforce state initialization in constructor',
13
- },
14
- schema: [],
15
- messages: {
16
- stateInConstructor: (0, eslint_devkit_2.formatLLMMessage)({
17
- icon: eslint_devkit_2.MessageIcons.WARNING,
18
- issueName: 'State Not in Constructor',
19
- description: 'State should be initialized in constructor',
20
- severity: 'MEDIUM',
21
- fix: 'Move state initialization to constructor method',
22
- documentationLink: 'https://react.dev/reference/react/Component#constructor',
23
- }),
24
- },
25
- },
26
- defaultOptions: [],
27
- create(context) {
28
- return {
29
- ClassDeclaration(node) {
30
- if (isReactComponent(node)) {
31
- checkStateInitialization(node);
32
- }
33
- },
34
- };
35
- function isReactComponent(node) {
36
- if (!node.superClass)
37
- return false;
38
- if (node.superClass.type === 'Identifier') {
39
- return node.superClass.name === 'Component' || node.superClass.name === 'PureComponent';
40
- }
41
- if (node.superClass.type === 'MemberExpression') {
42
- return (node.superClass.object.type === 'Identifier' &&
43
- node.superClass.object.name === 'React' &&
44
- node.superClass.property.type === 'Identifier' &&
45
- (node.superClass.property.name === 'Component' || node.superClass.property.name === 'PureComponent'));
46
- }
47
- return false;
48
- }
49
- function checkStateInitialization(node) {
50
- let hasConstructorWithState = false;
51
- let hasStateProperty = false;
52
- for (const member of node.body.body) {
53
- if (member.type === 'PropertyDefinition' &&
54
- member.key.type === 'Identifier' &&
55
- member.key.name === 'state') {
56
- hasStateProperty = true;
57
- }
58
- if (member.type === 'MethodDefinition' &&
59
- member.key.type === 'Identifier' &&
60
- member.key.name === 'constructor') {
61
- hasConstructorWithState = hasStateInitializationInConstructor(member);
62
- }
63
- }
64
- if (hasStateProperty && !hasConstructorWithState) {
65
- for (const member of node.body.body) {
66
- if (member.type === 'PropertyDefinition' &&
67
- member.key.type === 'Identifier' &&
68
- member.key.name === 'state') {
69
- context.report({
70
- node: member.key,
71
- messageId: 'stateInConstructor',
72
- });
73
- break;
74
- }
75
- }
76
- }
77
- }
78
- function hasStateInitializationInConstructor(constructor) {
79
- if (constructor.value.type === 'FunctionExpression') {
80
- const body = constructor.value.body;
81
- for (const statement of body.body) {
82
- if (statement.type === 'ExpressionStatement' &&
83
- statement.expression.type === 'AssignmentExpression' &&
84
- statement.expression.left.type === 'MemberExpression' &&
85
- statement.expression.left.object.type === 'ThisExpression' &&
86
- statement.expression.left.property.type === 'Identifier' &&
87
- statement.expression.left.property.name === 'state') {
88
- return true;
89
- }
90
- }
91
- }
92
- return false;
93
- }
94
- },
95
- });
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.stateInConstructor=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");exports.stateInConstructor=(0,eslint_devkit_1.createRule)({name:"state-in-constructor",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-react-features/docs/rules/state-in-constructor.md",description:"Enforce state initialization in constructor"},schema:[],messages:{stateInConstructor:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.WARNING,issueName:"State Not in Constructor",description:"State should be initialized in constructor",severity:"MEDIUM",fix:"Move state initialization to constructor method",documentationLink:"https://react.dev/reference/react/Component#constructor"})}},defaultOptions:[],create(context){return{ClassDeclaration(node){if(isReactComponent(node)){checkStateInitialization(node)}}};function isReactComponent(node){if(!node.superClass)return false;if(node.superClass.type==="Identifier"){return node.superClass.name==="Component"||node.superClass.name==="PureComponent"}if(node.superClass.type==="MemberExpression"){return node.superClass.object.type==="Identifier"&&node.superClass.object.name==="React"&&node.superClass.property.type==="Identifier"&&(node.superClass.property.name==="Component"||node.superClass.property.name==="PureComponent")}return false}function checkStateInitialization(node){let hasConstructorWithState=false;let hasStateProperty=false;for(const member of node.body.body){if(member.type==="PropertyDefinition"&&member.key.type==="Identifier"&&member.key.name==="state"){hasStateProperty=true}if(member.type==="MethodDefinition"&&member.key.type==="Identifier"&&member.key.name==="constructor"){hasConstructorWithState=hasStateInitializationInConstructor(member)}}if(hasStateProperty&&!hasConstructorWithState){for(const member of node.body.body){if(member.type==="PropertyDefinition"&&member.key.type==="Identifier"&&member.key.name==="state"){context.report({node:member.key,messageId:"stateInConstructor"});break}}}}function hasStateInitializationInConstructor(constructor){if(constructor.value.type==="FunctionExpression"){const body=constructor.value.body;for(const statement of body.body){if(statement.type==="ExpressionStatement"&&statement.expression.type==="AssignmentExpression"&&statement.expression.left.type==="MemberExpression"&&statement.expression.left.object.type==="ThisExpression"&&statement.expression.left.property.type==="Identifier"&&statement.expression.left.property.name==="state"){return true}}}return false}}});
@@ -1,122 +1 @@
1
- "use strict";
2
- Object.defineProperty(exports, "__esModule", { value: true });
3
- exports.staticPropertyPlacement = void 0;
4
- const eslint_devkit_1 = require("@interlace/eslint-devkit");
5
- const eslint_devkit_2 = require("@interlace/eslint-devkit");
6
- const DEFAULT_GROUPS = [
7
- {
8
- name: 'propTypes',
9
- properties: ['propTypes', 'defaultProps', 'childContextTypes', 'contextTypes', 'contextType'],
10
- },
11
- {
12
- name: 'lifecycle',
13
- properties: ['getDerivedStateFromProps', 'getDerivedStateFromError'],
14
- },
15
- ];
16
- exports.staticPropertyPlacement = (0, eslint_devkit_1.createRule)({
17
- name: 'static-property-placement',
18
- meta: {
19
- type: 'problem',
20
- docs: {
21
- url: 'https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-react-features/docs/rules/static-property-placement.md',
22
- description: 'Enforce static property placement',
23
- },
24
- schema: [
25
- {
26
- type: 'object',
27
- properties: {
28
- propertyGroups: {
29
- type: 'array',
30
- items: {
31
- type: 'object',
32
- properties: {
33
- name: { type: 'string' },
34
- properties: { type: 'array', items: { type: 'string' } },
35
- },
36
- },
37
- },
38
- childClass: {
39
- type: 'string',
40
- enum: ['first', 'last'],
41
- },
42
- },
43
- additionalProperties: false,
44
- },
45
- ],
46
- messages: {
47
- staticPropertyPlacement: (0, eslint_devkit_2.formatLLMMessage)({
48
- icon: eslint_devkit_2.MessageIcons.WARNING,
49
- issueName: 'Static Property Placement',
50
- description: 'Static properties should be grouped together',
51
- severity: 'LOW',
52
- fix: 'Group static properties together by category',
53
- documentationLink: 'https://react.dev/reference/react/Component#static-properties',
54
- }),
55
- },
56
- },
57
- defaultOptions: [{ propertyGroups: DEFAULT_GROUPS, childClass: 'first' }],
58
- create(context) {
59
- const [options] = context.options;
60
- const propertyGroups = options?.propertyGroups ?? DEFAULT_GROUPS;
61
- return {
62
- ClassDeclaration(node) {
63
- if (isReactComponent(node)) {
64
- checkStaticPropertyPlacement(node, propertyGroups);
65
- }
66
- },
67
- };
68
- function isReactComponent(node) {
69
- if (!node.superClass)
70
- return false;
71
- if (node.superClass.type === 'Identifier') {
72
- return node.superClass.name === 'Component' || node.superClass.name === 'PureComponent';
73
- }
74
- if (node.superClass.type === 'MemberExpression') {
75
- return (node.superClass.object.type === 'Identifier' &&
76
- node.superClass.object.name === 'React' &&
77
- node.superClass.property.type === 'Identifier' &&
78
- (node.superClass.property.name === 'Component' || node.superClass.property.name === 'PureComponent'));
79
- }
80
- return false;
81
- }
82
- function checkStaticPropertyPlacement(node, groups) {
83
- const members = node.body.body;
84
- const staticProperties = [];
85
- for (let i = 0; i < members.length; i++) {
86
- const member = members[i];
87
- if (isStaticProperty(member)) {
88
- const name = getPropertyName(member);
89
- if (name) {
90
- staticProperties.push({ name, index: i, node: member });
91
- }
92
- }
93
- }
94
- if (staticProperties.length < 2)
95
- return;
96
- for (let i = 1; i < staticProperties.length; i++) {
97
- const current = staticProperties[i];
98
- const previous = staticProperties[i - 1];
99
- if (!areInSameGroup(current.name, previous.name, groups)) {
100
- }
101
- }
102
- }
103
- function isStaticProperty(member) {
104
- return ((member.type === 'PropertyDefinition' || member.type === 'MethodDefinition') &&
105
- member.static);
106
- }
107
- function getPropertyName(member) {
108
- if (member.key.type === 'Identifier') {
109
- return member.key.name;
110
- }
111
- return null;
112
- }
113
- function areInSameGroup(name1, name2, groups) {
114
- for (const group of groups) {
115
- if (group.properties.includes(name1) && group.properties.includes(name2)) {
116
- return true;
117
- }
118
- }
119
- return false;
120
- }
121
- },
122
- });
1
+ "use strict";Object.defineProperty(exports,"__esModule",{value:true});exports.staticPropertyPlacement=void 0;const eslint_devkit_1=require("@interlace/eslint-devkit");const eslint_devkit_2=require("@interlace/eslint-devkit");const DEFAULT_GROUPS=[{name:"propTypes",properties:["propTypes","defaultProps","childContextTypes","contextTypes","contextType"]},{name:"lifecycle",properties:["getDerivedStateFromProps","getDerivedStateFromError"]}];exports.staticPropertyPlacement=(0,eslint_devkit_1.createRule)({name:"static-property-placement",meta:{type:"problem",docs:{url:"https://github.com/ofri-peretz/eslint/blob/main/packages/eslint-plugin-react-features/docs/rules/static-property-placement.md",description:"Enforce static property placement"},schema:[{type:"object",properties:{propertyGroups:{type:"array",items:{type:"object",properties:{name:{type:"string"},properties:{type:"array",items:{type:"string"}}}}},childClass:{type:"string",enum:["first","last"]}},additionalProperties:false}],messages:{staticPropertyPlacement:(0,eslint_devkit_2.formatLLMMessage)({icon:eslint_devkit_2.MessageIcons.WARNING,issueName:"Static Property Placement",description:"Static properties should be grouped together",severity:"LOW",fix:"Group static properties together by category",documentationLink:"https://react.dev/reference/react/Component#static-properties"})}},defaultOptions:[{propertyGroups:DEFAULT_GROUPS,childClass:"first"}],create(context){const[options]=context.options;const propertyGroups=options?.propertyGroups??DEFAULT_GROUPS;return{ClassDeclaration(node){if(isReactComponent(node)){checkStaticPropertyPlacement(node,propertyGroups)}}};function isReactComponent(node){if(!node.superClass)return false;if(node.superClass.type==="Identifier"){return node.superClass.name==="Component"||node.superClass.name==="PureComponent"}if(node.superClass.type==="MemberExpression"){return node.superClass.object.type==="Identifier"&&node.superClass.object.name==="React"&&node.superClass.property.type==="Identifier"&&(node.superClass.property.name==="Component"||node.superClass.property.name==="PureComponent")}return false}function checkStaticPropertyPlacement(node,groups){const members=node.body.body;const staticProperties=[];for(let i=0;i<members.length;i++){const member=members[i];if(isStaticProperty(member)){const name=getPropertyName(member);if(name){staticProperties.push({name,index:i,node:member})}}}if(staticProperties.length<2)return;for(let i=1;i<staticProperties.length;i++){const current=staticProperties[i];const previous=staticProperties[i-1];if(!areInSameGroup(current.name,previous.name,groups)){}}}function isStaticProperty(member){return(member.type==="PropertyDefinition"||member.type==="MethodDefinition")&&member.static}function getPropertyName(member){if(member.key.type==="Identifier"){return member.key.name}return null}function areInSameGroup(name1,name2,groups){for(const group of groups){if(group.properties.includes(name1)&&group.properties.includes(name2)){return true}}return false}}});