eslint-plugin-react-dom 5.20.1 → 5.20.3

package/dist/index.js

@@ -2,8 +2,8 @@ import { DEFAULT_ESLINT_REACT_SETTINGS, RE_JAVASCRIPT_PROTOCOL, getSettingsFromC
 import { ESLintUtils } from "@typescript-eslint/utils";
 import "@eslint-react/eslint";
 import { findAttribute, getAttributeStaticValue, getElementFullType, hasAnyAttribute, hasAttribute, isHostElement, isPaddingWhitespace, resolveAttributeValue } from "@eslint-react/jsx";
-import * as core from "@eslint-react/core";
 import { Check, Extract } from "@eslint-react/ast";
+import { createImportLookup } from "@eslint-react/var";
 import { AST_NODE_TYPES } from "@typescript-eslint/types";
 import { compare } from "compare-versions";
 
@@ -26,7 +26,7 @@ var __exportAll = (all, no_symbols) => {
 //#endregion
 //#region package.json
 var name$2 = "eslint-plugin-react-dom";
-var version = "5.20.1";
+var version = "5.20.3";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -53,11 +53,11 @@ function create$15(context) {
 	if (!context.sourceCode.text.includes("dangerouslySetInnerHTML")) return {};
 	return { JSXElement(node) {
 		if (!hasAttribute(context, node, "dangerouslySetInnerHTML")) return;
-		const childrenPropOrNode = findAttribute(context, node, "children") ?? node.children.find((child) => !isPaddingWhitespace(child));
-		if (childrenPropOrNode == null) return;
+		const fact = findAttribute(context, node, "children") ?? node.children.find((child) => !isPaddingWhitespace(child));
+		if (fact == null) return;
 		context.report({
 			messageId: "default",
-			node: childrenPropOrNode
+			node: fact
 		});
 	} };
 }
@@ -79,18 +79,17 @@ var no_dangerously_set_innerhtml_default = createRule({
 function create$14(context) {
 	if (!context.sourceCode.text.includes("dangerouslySetInnerHTML")) return {};
 	return { JSXElement(node) {
-		const dsihProp = findAttribute(context, node, "dangerouslySetInnerHTML");
-		if (dsihProp == null) return;
+		const prop = findAttribute(context, node, "dangerouslySetInnerHTML");
+		if (prop == null) return;
 		context.report({
 			messageId: "default",
-			node: dsihProp
+			node: prop
 		});
 	} };
 }
 
 //#endregion
 //#region src/rules/no-find-dom-node/no-find-dom-node.ts
-const isFindDOMNodeCall = core.isAPICall("findDOMNode");
 const RULE_NAME$13 = "no-find-dom-node";
 var no_find_dom_node_default = createRule({
 	meta: {
@@ -105,11 +104,26 @@ var no_find_dom_node_default = createRule({
 });
 function create$13(context) {
 	if (!context.sourceCode.text.includes("findDOMNode")) return {};
+	const imports = createImportLookup(context.sourceCode.ast, {
+		builtinNamespaces: ["React", "ReactDOM"],
+		source: "react-dom"
+	});
 	return { CallExpression(node) {
-		if (isFindDOMNodeCall(context, node)) context.report({
-			messageId: "default",
-			node
-		});
+		const callee = Extract.unwrap(node.callee);
+		switch (true) {
+			case Check.isIdentifier(callee) && (callee.name === "findDOMNode" || imports.has(callee.name, "findDOMNode")):
+				context.report({
+					messageId: "default",
+					node
+				});
+				return;
+			case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "findDOMNode" && imports.hasNamespace(callee.object.name):
+				context.report({
+					messageId: "default",
+					node
+				});
+				return;
+		}
 	} };
 }
 
@@ -129,41 +143,24 @@ var no_flush_sync_default = createRule({
 });
 function create$12(context) {
 	if (!context.sourceCode.text.includes("flushSync")) return {};
-	const reactDomNames = /* @__PURE__ */ new Set();
-	const flushSyncNames = /* @__PURE__ */ new Set();
-	return {
-		CallExpression(node) {
-			const callee = Extract.unwrap(node.callee);
-			switch (true) {
-				case Check.isIdentifier(callee) && flushSyncNames.has(callee.name):
-					context.report({
-						messageId: "default",
-						node
-					});
-					return;
-				case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "flushSync" && reactDomNames.has(callee.object.name):
-					context.report({
-						messageId: "default",
-						node
-					});
-					return;
-			}
-		},
-		ImportDeclaration(node) {
-			const [baseSource] = node.source.value.split("/");
-			if (baseSource !== "react-dom") return;
-			for (const specifier of node.specifiers) switch (specifier.type) {
-				case AST_NODE_TYPES.ImportSpecifier:
-					if (!Check.isIdentifier(specifier.imported)) continue;
-					if (specifier.imported.name === "flushSync") flushSyncNames.add(specifier.local.name);
-					continue;
-				case AST_NODE_TYPES.ImportDefaultSpecifier:
-				case AST_NODE_TYPES.ImportNamespaceSpecifier:
-					reactDomNames.add(specifier.local.name);
-					continue;
-			}
+	const imports = createImportLookup(context.sourceCode.ast, { source: "react-dom" });
+	return { CallExpression(node) {
+		const callee = Extract.unwrap(node.callee);
+		switch (true) {
+			case Check.isIdentifier(callee) && imports.has(callee.name, "flushSync"):
+				context.report({
+					messageId: "default",
+					node
+				});
+				return;
+			case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "flushSync" && imports.hasNamespace(callee.object.name):
+				context.report({
+					messageId: "default",
+					node
+				});
+				return;
 		}
-	};
+	} };
 }
 
 //#endregion
@@ -185,43 +182,26 @@ function create$11(context) {
 	if (!context.sourceCode.text.includes("hydrate")) return {};
 	const settings = getSettingsFromContext(context);
 	if (compare(settings.version, "18.0.0", "<")) return {};
-	const reactDomNames = /* @__PURE__ */ new Set();
-	const hydrateNames = /* @__PURE__ */ new Set();
-	return {
-		CallExpression(node) {
-			const callee = Extract.unwrap(node.callee);
-			switch (true) {
-				case Check.isIdentifier(callee) && hydrateNames.has(callee.name):
-					context.report({
-						fix: buildFix$2(context, node),
-						messageId: "default",
-						node
-					});
-					return;
-				case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "hydrate" && reactDomNames.has(callee.object.name):
-					context.report({
-						fix: buildFix$2(context, node),
-						messageId: "default",
-						node
-					});
-					return;
-			}
-		},
-		ImportDeclaration(node) {
-			const [baseSource] = node.source.value.split("/");
-			if (baseSource !== "react-dom") return;
-			for (const specifier of node.specifiers) switch (specifier.type) {
-				case AST_NODE_TYPES.ImportSpecifier:
-					if (!Check.isIdentifier(specifier.imported)) continue;
-					if (specifier.imported.name === "hydrate") hydrateNames.add(specifier.local.name);
-					continue;
-				case AST_NODE_TYPES.ImportDefaultSpecifier:
-				case AST_NODE_TYPES.ImportNamespaceSpecifier:
-					reactDomNames.add(specifier.local.name);
-					continue;
-			}
+	const imports = createImportLookup(context.sourceCode.ast, { source: "react-dom" });
+	return { CallExpression(node) {
+		const callee = Extract.unwrap(node.callee);
+		switch (true) {
+			case Check.isIdentifier(callee) && imports.has(callee.name, "hydrate"):
+				context.report({
+					fix: buildFix$2(context, node),
+					messageId: "default",
+					node
+				});
+				return;
+			case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "hydrate" && imports.hasNamespace(callee.object.name):
+				context.report({
+					fix: buildFix$2(context, node),
+					messageId: "default",
+					node
+				});
+				return;
 		}
-	};
+	} };
 }
 function buildFix$2(context, node) {
 	const getText = (n) => context.sourceCode.getText(n);
@@ -235,15 +215,17 @@ function buildFix$2(context, node) {
 //#endregion
 //#region src/utils/create-jsx-element-resolver.ts
 /**
-* Creates a resolver for JSX elements that determines both the JSX element type
-* and the underlying DOM element type.
+* Creates a resolver for JSX elements that determines the underlying DOM element type.
 *
 * This resolver handles:
 * 1. Regular HTML elements (div, span, etc.)
-* 2. Polymorphic components (components that can render as different elements via a prop)
+* 2. Polymorphic components (components that render as a different element via a prop,
+*    ex: `<Box as="a">`). Only static string values of the polymorphic prop are
+*    supported; `<Box as={Component}>` cannot be resolved statically and falls back
+*    to the JSX element's own name.
 *
 * @param context The ESLint rule context
-* @returns An object with a resolve method to determine element types
+* @returns An object with a resolve method to determine the element type
 */
 function createJsxElementResolver(context) {
 	const { polymorphicPropName } = getSettingsFromContext(context);
@@ -260,11 +242,12 @@ resolve(node) {
 			domElementType: elementName,
 			jsxElementType: elementName
 		};
-		if (elementName === elementName.toLowerCase() || polymorphicPropName == null) return result;
+		const nameNode = node.openingElement.name;
+		if (nameNode.type === AST_NODE_TYPES.JSXIdentifier && nameNode.name.charAt(0) === nameNode.name.charAt(0).toLowerCase()) return result;
 		const polyPropValue = getAttributeStaticValue(context, node, polymorphicPropName);
 		if (typeof polyPropValue === "string") return {
 			...result,
-			domElementType: polyPropValue
+			domElementType: polyPropValue.toLowerCase()
 		};
 		return result;
 	} };
@@ -296,14 +279,17 @@ var no_missing_button_type_default = createRule({
 function create$10(context) {
 	const resolver = createJsxElementResolver(context);
 	return { JSXElement(node) {
-		if (resolver.resolve(node).domElementType !== "button") return;
+		const { domElementType } = resolver.resolve(node);
+		if (domElementType !== "button") return;
 		if (hasAttribute(context, node, "type")) return;
 		context.report({
 			messageId: "missingTypeAttribute",
 			node: node.openingElement,
 			suggest: BUTTON_TYPES.map((type) => ({
 				data: { type },
-				fix: (fixer) => fixer.insertTextAfter(node.openingElement.name, ` type="${type}"`),
+				fix(fixer) {
+					return fixer.insertTextAfter(node.openingElement.name, ` type="${type}"`);
+				},
 				messageId: "addTypeAttribute"
 			}))
 		});
@@ -369,18 +355,13 @@ function create$9(context) {
 //#endregion
 //#region src/rules/no-render-return-value/no-render-return-value.ts
 const RULE_NAME$8 = "no-render-return-value";
-const banParentTypes = [
+const BANNED_PARENT_TYPES = [
 	AST_NODE_TYPES.VariableDeclarator,
 	AST_NODE_TYPES.Property,
 	AST_NODE_TYPES.ReturnStatement,
 	AST_NODE_TYPES.ArrowFunctionExpression,
 	AST_NODE_TYPES.AssignmentExpression
 ];
-function isReturnValueUsed(node) {
-	let parent = node.parent;
-	while (Check.isTypeExpression(parent)) parent = parent.parent;
-	return banParentTypes.includes(parent.type);
-}
 var no_render_return_value_default = createRule({
 	meta: {
 		type: "problem",
@@ -393,41 +374,33 @@ var no_render_return_value_default = createRule({
 	defaultOptions: []
 });
 function create$8(context) {
-	const reactDomNames = /* @__PURE__ */ new Set(["ReactDOM", "ReactDOM"]);
-	const renderNames = /* @__PURE__ */ new Set();
-	return {
-		CallExpression(node) {
-			const callee = Extract.unwrap(node.callee);
-			switch (true) {
-				case Check.isIdentifier(callee) && renderNames.has(callee.name) && isReturnValueUsed(node):
-					context.report({
-						messageId: "default",
-						node
-					});
-					return;
-				case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "render" && reactDomNames.has(callee.object.name) && isReturnValueUsed(node):
-					context.report({
-						messageId: "default",
-						node
-					});
-					return;
-			}
-		},
-		ImportDeclaration(node) {
-			const [baseSource] = node.source.value.split("/");
-			if (baseSource !== "react-dom") return;
-			for (const specifier of node.specifiers) switch (specifier.type) {
-				case AST_NODE_TYPES.ImportSpecifier:
-					if (!Check.isIdentifier(specifier.imported)) continue;
-					if (specifier.imported.name === "render") renderNames.add(specifier.local.name);
-					continue;
-				case AST_NODE_TYPES.ImportDefaultSpecifier:
-				case AST_NODE_TYPES.ImportNamespaceSpecifier:
-					reactDomNames.add(specifier.local.name);
-					continue;
-			}
+	if (!context.sourceCode.text.includes("render")) return {};
+	const imports = createImportLookup(context.sourceCode.ast, {
+		builtinNamespaces: ["ReactDOM"],
+		source: "react-dom"
+	});
+	return { CallExpression(node) {
+		const callee = Extract.unwrap(node.callee);
+		switch (true) {
+			case Check.isIdentifier(callee) && imports.has(callee.name, "render") && isReturnValueUsed(node):
+				context.report({
+					messageId: "default",
+					node
+				});
+				return;
+			case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "render" && imports.hasNamespace(callee.object.name) && isReturnValueUsed(node):
+				context.report({
+					messageId: "default",
+					node
+				});
+				return;
 		}
-	};
+	} };
+}
+function isReturnValueUsed(node) {
+	let parent = node.parent;
+	while (Check.isTypeExpression(parent)) parent = parent.parent;
+	return BANNED_PARENT_TYPES.includes(parent.type);
 }
 
 //#endregion
@@ -449,50 +422,30 @@ function create$7(context) {
 	if (!context.sourceCode.text.includes("render")) return {};
 	const settings = getSettingsFromContext(context);
 	if (compare(settings.version, "18.0.0", "<")) return {};
-	const reactDomNames = /* @__PURE__ */ new Set(["ReactDOM", "ReactDOM"]);
-	const renderNames = /* @__PURE__ */ new Set();
-	return {
-		CallExpression(node) {
-			const callee = Extract.unwrap(node.callee);
-			switch (true) {
-				case Check.isIdentifier(callee) && renderNames.has(callee.name):
-					context.report({
-						fix: buildFix$1(context, node),
-						messageId: "default",
-						node
-					});
-					return;
-				case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "render" && reactDomNames.has(callee.object.name):
-					context.report({
-						fix: buildFix$1(context, node),
-						messageId: "default",
-						node
-					});
-					return;
-			}
-		},
-		ImportDeclaration(node) {
-			const [baseSource] = node.source.value.split("/");
-			if (baseSource !== "react-dom") return;
-			for (const specifier of node.specifiers) switch (specifier.type) {
-				case AST_NODE_TYPES.ImportSpecifier:
-					if (!Check.isIdentifier(specifier.imported)) continue;
-					if (specifier.imported.name === "render") renderNames.add(specifier.local.name);
-					continue;
-				case AST_NODE_TYPES.ImportDefaultSpecifier:
-				case AST_NODE_TYPES.ImportNamespaceSpecifier:
-					reactDomNames.add(specifier.local.name);
-					continue;
-			}
+	const imports = createImportLookup(context.sourceCode.ast, {
+		builtinNamespaces: ["ReactDOM"],
+		source: "react-dom"
+	});
+	return { CallExpression(node) {
+		const callee = Extract.unwrap(node.callee);
+		switch (true) {
+			case Check.isIdentifier(callee) && imports.has(callee.name, "render"):
+				context.report({
+					fix: buildFix$1(context, node),
+					messageId: "default",
+					node
+				});
+				return;
+			case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "render" && imports.hasNamespace(callee.object.name):
+				context.report({
+					fix: buildFix$1(context, node),
+					messageId: "default",
+					node
+				});
+				return;
 		}
-	};
+	} };
 }
-/**
-* Provides a fixer function to replace `render(app, container)` with `createRoot(container).render(app)`
-* @param context The rule context
-* @param node The `CallExpression` node to fix
-* @returns A fixer function or null if the fix cannot be applied
-*/
 function buildFix$1(context, node) {
 	const getText = (n) => context.sourceCode.getText(n);
 	return (fixer) => {
@@ -547,7 +500,8 @@ function create$5(context) {
 		const styleProp = findAttribute(context, node, "style");
 		if (styleProp == null) return;
 		const styleValue = resolveAttributeValue(context, styleProp);
-		if (typeof styleValue.toStatic() === "string") context.report({
+		if (typeof styleValue.toStatic() !== "string") return;
+		context.report({
 			messageId: "default",
 			node: styleValue.node ?? styleProp
 		});
@@ -1637,23 +1591,10 @@ var no_unknown_property_default = createRule({
 	create: create$4,
 	defaultOptions: []
 });
-/**
-* Create function for the ESLint rule
-* @param context ESLint rule context
-* @returns Rule listener
-*/
 function create$4(context) {
-	/**
-	* Gets the ignore configuration from rule options
-	* @returns Array of attribute names to ignore
-	*/
 	function getIgnoreConfig() {
 		return context.options[0]?.ignore ?? DEFAULTS.ignore;
 	}
-	/**
-	* Gets the requireDataLowercase option from rule options
-	* @returns Whether data attributes must be lowercase
-	*/
 	function getRequireDataLowercase() {
 		return context.options[0]?.requireDataLowercase ?? DEFAULTS.requireDataLowercase;
 	}
@@ -1749,11 +1690,13 @@ var no_unsafe_iframe_sandbox_default = createRule({
 function create$3(context) {
 	const resolver = createJsxElementResolver(context);
 	return { JSXElement(node) {
-		if (resolver.resolve(node).domElementType !== "iframe") return;
+		const { domElementType } = resolver.resolve(node);
+		if (domElementType !== "iframe") return;
 		const sandboxProp = findAttribute(context, node, "sandbox");
 		if (sandboxProp == null) return;
 		const sandboxValue = resolveAttributeValue(context, sandboxProp, "sandbox");
-		if (isUnsafeSandboxCombination(sandboxValue.toStatic())) context.report({
+		if (!isUnsafeSandboxCombination(sandboxValue.toStatic())) return;
+		context.report({
 			messageId: "default",
 			node: sandboxValue.node ?? sandboxProp
 		});
@@ -1808,8 +1751,8 @@ function create$2(context) {
 		const { domElementType } = resolver.resolve(node);
 		if (domElementType !== "a") return;
 		if (getAttributeStaticValue(context, node, "target") !== "_blank") return;
-		const hrefValueString = getAttributeStaticValue(context, node, "href");
-		if (!isExternalLinkLike(hrefValueString)) return;
+		const hrefValue = getAttributeStaticValue(context, node, "href");
+		if (!isExternalLinkLike(hrefValue)) return;
 		const relProp = findAttribute(context, node, "rel");
 		if (relProp == null) {
 			context.report({
@@ -1824,8 +1767,8 @@ function create$2(context) {
 			});
 			return;
 		}
-		const relValueString = getAttributeStaticValue(context, node, "rel");
-		if (isSafeRel(relValueString)) return;
+		const relValue = getAttributeStaticValue(context, node, "rel");
+		if (isSafeRel(relValue)) return;
 		context.report({
 			messageId: "default",
 			node: relProp,
@@ -1858,43 +1801,26 @@ function create$1(context) {
 	if (!context.sourceCode.text.includes("useFormState")) return {};
 	const settings = getSettingsFromContext(context);
 	if (compare(settings.version, "19.0.0", "<")) return {};
-	const reactDomNames = /* @__PURE__ */ new Set();
-	const useFormStateNames = /* @__PURE__ */ new Set();
-	return {
-		CallExpression(node) {
-			const callee = Extract.unwrap(node.callee);
-			switch (true) {
-				case Check.isIdentifier(callee) && useFormStateNames.has(callee.name):
-					context.report({
-						fix: buildFix(context, node),
-						messageId: "default",
-						node
-					});
-					return;
-				case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "useFormState" && reactDomNames.has(callee.object.name):
-					context.report({
-						fix: buildFix(context, node),
-						messageId: "default",
-						node
-					});
-					return;
-			}
-		},
-		ImportDeclaration(node) {
-			const [baseSource] = node.source.value.split("/");
-			if (baseSource !== "react-dom") return;
-			for (const specifier of node.specifiers) switch (specifier.type) {
-				case AST_NODE_TYPES.ImportSpecifier:
-					if (!Check.isIdentifier(specifier.imported)) continue;
-					if (specifier.imported.name === "useFormState") useFormStateNames.add(specifier.local.name);
-					continue;
-				case AST_NODE_TYPES.ImportDefaultSpecifier:
-				case AST_NODE_TYPES.ImportNamespaceSpecifier:
-					reactDomNames.add(specifier.local.name);
-					continue;
-			}
+	const imports = createImportLookup(context.sourceCode.ast, { source: "react-dom" });
+	return { CallExpression(node) {
+		const callee = Extract.unwrap(node.callee);
+		switch (true) {
+			case Check.isIdentifier(callee) && imports.has(callee.name, "useFormState"):
+				context.report({
+					fix: buildFix(context, node),
+					messageId: "default",
+					node
+				});
+				return;
+			case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "useFormState" && imports.hasNamespace(callee.object.name):
+				context.report({
+					fix: buildFix(context, node),
+					messageId: "default",
+					node
+				});
+				return;
 		}
-	};
+	} };
 }
 function buildFix(context, node) {
 	const { importSource } = getSettingsFromContext(context);
@@ -1905,7 +1831,7 @@ function buildFix(context, node) {
 
 //#endregion
 //#region src/rules/no-void-elements-with-children/lib.ts
-const VOID_ELEMENTS = /* @__PURE__ */ new Set([
+const KNOWN_VOID_ELEMENTS = /* @__PURE__ */ new Set([
 	"area",
 	"base",
 	"br",
@@ -1942,7 +1868,7 @@ function create(context) {
 	const resolver = createJsxElementResolver(context);
 	return { JSXElement(node) {
 		const { domElementType } = resolver.resolve(node);
-		if (!VOID_ELEMENTS.has(domElementType)) return;
+		if (!KNOWN_VOID_ELEMENTS.has(domElementType)) return;
 		if (node.children.length > 0 || hasAnyAttribute(context, node, ["children", "dangerouslySetInnerHTML"])) context.report({
 			data: { elementType: domElementType },
 			messageId: "default",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-dom",
-  "version": "5.20.1",
+  "version": "5.20.3",
   "description": "ESLint React's ESLint plugin for DOM related rules.",
   "keywords": [
     "react",
@@ -37,11 +37,12 @@
     "dist"
   ],
   "dependencies": {
-    "@eslint-react/ast": "5.20.1",
-    "@eslint-react/core": "5.20.1",
-    "@eslint-react/eslint": "5.20.1",
-    "@eslint-react/jsx": "5.20.1",
-    "@eslint-react/shared": "5.20.1",
+    "@eslint-react/ast": "5.20.3",
+    "@eslint-react/core": "5.20.3",
+    "@eslint-react/eslint": "5.20.3",
+    "@eslint-react/jsx": "5.20.3",
+    "@eslint-react/shared": "5.20.3",
+    "@eslint-react/var": "5.20.3",
     "@typescript-eslint/types": "^8.70.0",
     "@typescript-eslint/utils": "^8.70.0",
     "compare-versions": "^6.1.1"