eslint-plugin-react-dom 5.20.0 → 5.20.2

package/dist/index.js

@@ -2,7 +2,9 @@ import { DEFAULT_ESLINT_REACT_SETTINGS, RE_JAVASCRIPT_PROTOCOL, getSettingsFromC
 import { ESLintUtils } from "@typescript-eslint/utils";
 import "@eslint-react/eslint";
 import { findAttribute, getAttributeStaticValue, getElementFullType, hasAnyAttribute, hasAttribute, isHostElement, isPaddingWhitespace, resolveAttributeValue } from "@eslint-react/jsx";
+import * as core from "@eslint-react/core";
 import { Check, Extract } from "@eslint-react/ast";
+import { createImportLookup } from "@eslint-react/var";
 import { AST_NODE_TYPES } from "@typescript-eslint/types";
 import { compare } from "compare-versions";
 
@@ -25,7 +27,7 @@ var __exportAll = (all, no_symbols) => {
 //#endregion
 //#region package.json
 var name$2 = "eslint-plugin-react-dom";
-var version = "5.20.0";
+var version = "5.20.2";
 
 //#endregion
 //#region src/utils/create-rule.ts
@@ -89,6 +91,7 @@ function create$14(context) {
 
 //#endregion
 //#region src/rules/no-find-dom-node/no-find-dom-node.ts
+const isFindDOMNodeCall = core.isAPICall("findDOMNode");
 const RULE_NAME$13 = "no-find-dom-node";
 var no_find_dom_node_default = createRule({
 	meta: {
@@ -104,7 +107,7 @@ var no_find_dom_node_default = createRule({
 function create$13(context) {
 	if (!context.sourceCode.text.includes("findDOMNode")) return {};
 	return { CallExpression(node) {
-		if (Extract.getCalleeName(node) === "findDOMNode") context.report({
+		if (isFindDOMNodeCall(context, node)) context.report({
 			messageId: "default",
 			node
 		});
@@ -127,11 +130,23 @@ var no_flush_sync_default = createRule({
 });
 function create$12(context) {
 	if (!context.sourceCode.text.includes("flushSync")) return {};
+	const imports = createImportLookup(context.sourceCode.ast, { source: "react-dom" });
 	return { CallExpression(node) {
-		if (Extract.getCalleeName(node) === "flushSync") context.report({
-			messageId: "default",
-			node
-		});
+		const callee = Extract.unwrap(node.callee);
+		switch (true) {
+			case Check.isIdentifier(callee) && imports.has(callee.name, "flushSync"):
+				context.report({
+					messageId: "default",
+					node
+				});
+				return;
+			case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "flushSync" && imports.hasNamespace(callee.object.name):
+				context.report({
+					messageId: "default",
+					node
+				});
+				return;
+		}
 	} };
 }
 
@@ -154,43 +169,26 @@ function create$11(context) {
 	if (!context.sourceCode.text.includes("hydrate")) return {};
 	const settings = getSettingsFromContext(context);
 	if (compare(settings.version, "18.0.0", "<")) return {};
-	const reactDomNames = /* @__PURE__ */ new Set();
-	const hydrateNames = /* @__PURE__ */ new Set();
-	return {
-		CallExpression(node) {
-			const callee = Extract.unwrap(node.callee);
-			switch (true) {
-				case Check.isIdentifier(callee) && hydrateNames.has(callee.name):
-					context.report({
-						fix: buildFix$2(context, node),
-						messageId: "default",
-						node
-					});
-					return;
-				case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "hydrate" && reactDomNames.has(callee.object.name):
-					context.report({
-						fix: buildFix$2(context, node),
-						messageId: "default",
-						node
-					});
-					return;
-			}
-		},
-		ImportDeclaration(node) {
-			const [baseSource] = node.source.value.split("/");
-			if (baseSource !== "react-dom") return;
-			for (const specifier of node.specifiers) switch (specifier.type) {
-				case AST_NODE_TYPES.ImportSpecifier:
-					if (!Check.isIdentifier(specifier.imported)) continue;
-					if (specifier.imported.name === "hydrate") hydrateNames.add(specifier.local.name);
-					continue;
-				case AST_NODE_TYPES.ImportDefaultSpecifier:
-				case AST_NODE_TYPES.ImportNamespaceSpecifier:
-					reactDomNames.add(specifier.local.name);
-					continue;
-			}
+	const imports = createImportLookup(context.sourceCode.ast, { source: "react-dom" });
+	return { CallExpression(node) {
+		const callee = Extract.unwrap(node.callee);
+		switch (true) {
+			case Check.isIdentifier(callee) && imports.has(callee.name, "hydrate"):
+				context.report({
+					fix: buildFix$2(context, node),
+					messageId: "default",
+					node
+				});
+				return;
+			case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "hydrate" && imports.hasNamespace(callee.object.name):
+				context.report({
+					fix: buildFix$2(context, node),
+					messageId: "default",
+					node
+				});
+				return;
 		}
-	};
+	} };
 }
 function buildFix$2(context, node) {
 	const getText = (n) => context.sourceCode.getText(n);
@@ -204,15 +202,17 @@ function buildFix$2(context, node) {
 //#endregion
 //#region src/utils/create-jsx-element-resolver.ts
 /**
-* Creates a resolver for JSX elements that determines both the JSX element type
-* and the underlying DOM element type.
+* Creates a resolver for JSX elements that determines the underlying DOM element type.
 *
 * This resolver handles:
 * 1. Regular HTML elements (div, span, etc.)
-* 2. Polymorphic components (components that can render as different elements via a prop)
+* 2. Polymorphic components (components that render as a different element via a prop,
+*    ex: `<Box as="a">`). Only static string values of the polymorphic prop are
+*    supported; `<Box as={Component}>` cannot be resolved statically and falls back
+*    to the JSX element's own name.
 *
 * @param context The ESLint rule context
-* @returns An object with a resolve method to determine element types
+* @returns An object with a resolve method to determine the element type
 */
 function createJsxElementResolver(context) {
 	const { polymorphicPropName } = getSettingsFromContext(context);
@@ -229,11 +229,12 @@ resolve(node) {
 			domElementType: elementName,
 			jsxElementType: elementName
 		};
-		if (elementName === elementName.toLowerCase() || polymorphicPropName == null) return result;
+		const nameNode = node.openingElement.name;
+		if (nameNode.type === AST_NODE_TYPES.JSXIdentifier && nameNode.name.charAt(0) === nameNode.name.charAt(0).toLowerCase()) return result;
 		const polyPropValue = getAttributeStaticValue(context, node, polymorphicPropName);
 		if (typeof polyPropValue === "string") return {
 			...result,
-			domElementType: polyPropValue
+			domElementType: polyPropValue.toLowerCase()
 		};
 		return result;
 	} };
@@ -362,41 +363,27 @@ var no_render_return_value_default = createRule({
 	defaultOptions: []
 });
 function create$8(context) {
-	const reactDomNames = /* @__PURE__ */ new Set(["ReactDOM", "ReactDOM"]);
-	const renderNames = /* @__PURE__ */ new Set();
-	return {
-		CallExpression(node) {
-			const callee = Extract.unwrap(node.callee);
-			switch (true) {
-				case Check.isIdentifier(callee) && renderNames.has(callee.name) && isReturnValueUsed(node):
-					context.report({
-						messageId: "default",
-						node
-					});
-					return;
-				case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "render" && reactDomNames.has(callee.object.name) && isReturnValueUsed(node):
-					context.report({
-						messageId: "default",
-						node
-					});
-					return;
-			}
-		},
-		ImportDeclaration(node) {
-			const [baseSource] = node.source.value.split("/");
-			if (baseSource !== "react-dom") return;
-			for (const specifier of node.specifiers) switch (specifier.type) {
-				case AST_NODE_TYPES.ImportSpecifier:
-					if (!Check.isIdentifier(specifier.imported)) continue;
-					if (specifier.imported.name === "render") renderNames.add(specifier.local.name);
-					continue;
-				case AST_NODE_TYPES.ImportDefaultSpecifier:
-				case AST_NODE_TYPES.ImportNamespaceSpecifier:
-					reactDomNames.add(specifier.local.name);
-					continue;
-			}
+	const imports = createImportLookup(context.sourceCode.ast, {
+		source: "react-dom",
+		builtinNamespaces: ["ReactDOM"]
+	});
+	return { CallExpression(node) {
+		const callee = Extract.unwrap(node.callee);
+		switch (true) {
+			case Check.isIdentifier(callee) && imports.has(callee.name, "render") && isReturnValueUsed(node):
+				context.report({
+					messageId: "default",
+					node
+				});
+				return;
+			case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "render" && imports.hasNamespace(callee.object.name) && isReturnValueUsed(node):
+				context.report({
+					messageId: "default",
+					node
+				});
+				return;
 		}
-	};
+	} };
 }
 
 //#endregion
@@ -418,43 +405,29 @@ function create$7(context) {
 	if (!context.sourceCode.text.includes("render")) return {};
 	const settings = getSettingsFromContext(context);
 	if (compare(settings.version, "18.0.0", "<")) return {};
-	const reactDomNames = /* @__PURE__ */ new Set(["ReactDOM", "ReactDOM"]);
-	const renderNames = /* @__PURE__ */ new Set();
-	return {
-		CallExpression(node) {
-			const callee = Extract.unwrap(node.callee);
-			switch (true) {
-				case Check.isIdentifier(callee) && renderNames.has(callee.name):
-					context.report({
-						fix: buildFix$1(context, node),
-						messageId: "default",
-						node
-					});
-					return;
-				case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "render" && reactDomNames.has(callee.object.name):
-					context.report({
-						fix: buildFix$1(context, node),
-						messageId: "default",
-						node
-					});
-					return;
-			}
-		},
-		ImportDeclaration(node) {
-			const [baseSource] = node.source.value.split("/");
-			if (baseSource !== "react-dom") return;
-			for (const specifier of node.specifiers) switch (specifier.type) {
-				case AST_NODE_TYPES.ImportSpecifier:
-					if (!Check.isIdentifier(specifier.imported)) continue;
-					if (specifier.imported.name === "render") renderNames.add(specifier.local.name);
-					continue;
-				case AST_NODE_TYPES.ImportDefaultSpecifier:
-				case AST_NODE_TYPES.ImportNamespaceSpecifier:
-					reactDomNames.add(specifier.local.name);
-					continue;
-			}
+	const imports = createImportLookup(context.sourceCode.ast, {
+		source: "react-dom",
+		builtinNamespaces: ["ReactDOM"]
+	});
+	return { CallExpression(node) {
+		const callee = Extract.unwrap(node.callee);
+		switch (true) {
+			case Check.isIdentifier(callee) && imports.has(callee.name, "render"):
+				context.report({
+					fix: buildFix$1(context, node),
+					messageId: "default",
+					node
+				});
+				return;
+			case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "render" && imports.hasNamespace(callee.object.name):
+				context.report({
+					fix: buildFix$1(context, node),
+					messageId: "default",
+					node
+				});
+				return;
 		}
-	};
+	} };
 }
 /**
 * Provides a fixer function to replace `render(app, container)` with `createRoot(container).render(app)`
@@ -1827,43 +1800,26 @@ function create$1(context) {
 	if (!context.sourceCode.text.includes("useFormState")) return {};
 	const settings = getSettingsFromContext(context);
 	if (compare(settings.version, "19.0.0", "<")) return {};
-	const reactDomNames = /* @__PURE__ */ new Set();
-	const useFormStateNames = /* @__PURE__ */ new Set();
-	return {
-		CallExpression(node) {
-			const callee = Extract.unwrap(node.callee);
-			switch (true) {
-				case Check.isIdentifier(callee) && useFormStateNames.has(callee.name):
-					context.report({
-						fix: buildFix(context, node),
-						messageId: "default",
-						node
-					});
-					return;
-				case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "useFormState" && reactDomNames.has(callee.object.name):
-					context.report({
-						fix: buildFix(context, node),
-						messageId: "default",
-						node
-					});
-					return;
-			}
-		},
-		ImportDeclaration(node) {
-			const [baseSource] = node.source.value.split("/");
-			if (baseSource !== "react-dom") return;
-			for (const specifier of node.specifiers) switch (specifier.type) {
-				case AST_NODE_TYPES.ImportSpecifier:
-					if (!Check.isIdentifier(specifier.imported)) continue;
-					if (specifier.imported.name === "useFormState") useFormStateNames.add(specifier.local.name);
-					continue;
-				case AST_NODE_TYPES.ImportDefaultSpecifier:
-				case AST_NODE_TYPES.ImportNamespaceSpecifier:
-					reactDomNames.add(specifier.local.name);
-					continue;
-			}
+	const imports = createImportLookup(context.sourceCode.ast, { source: "react-dom" });
+	return { CallExpression(node) {
+		const callee = Extract.unwrap(node.callee);
+		switch (true) {
+			case Check.isIdentifier(callee) && imports.has(callee.name, "useFormState"):
+				context.report({
+					fix: buildFix(context, node),
+					messageId: "default",
+					node
+				});
+				return;
+			case callee.type === AST_NODE_TYPES.MemberExpression && Check.isIdentifier(callee.object) && Extract.getCalleeName(node) === "useFormState" && imports.hasNamespace(callee.object.name):
+				context.report({
+					fix: buildFix(context, node),
+					messageId: "default",
+					node
+				});
+				return;
 		}
-	};
+	} };
 }
 function buildFix(context, node) {
 	const { importSource } = getSettingsFromContext(context);

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-dom",
-  "version": "5.20.0",
+  "version": "5.20.2",
   "description": "ESLint React's ESLint plugin for DOM related rules.",
   "keywords": [
     "react",
@@ -37,10 +37,12 @@
     "dist"
   ],
   "dependencies": {
-    "@eslint-react/ast": "5.20.0",
-    "@eslint-react/eslint": "5.20.0",
-    "@eslint-react/jsx": "5.20.0",
-    "@eslint-react/shared": "5.20.0",
+    "@eslint-react/ast": "5.20.2",
+    "@eslint-react/core": "5.20.2",
+    "@eslint-react/eslint": "5.20.2",
+    "@eslint-react/jsx": "5.20.2",
+    "@eslint-react/shared": "5.20.2",
+    "@eslint-react/var": "5.20.2",
     "@typescript-eslint/types": "^8.70.0",
     "@typescript-eslint/utils": "^8.70.0",
     "compare-versions": "^6.1.1"
@@ -51,7 +53,7 @@
     "@types/react": "^19.3.0",
     "@types/react-dom": "^19.3.0",
     "dedent": "^1.7.2",
-    "eslint": "^10.10.0",
+    "eslint": "^10.11.0",
     "tsdown": "^0.23.0",
     "typescript": "6.0.3"
   },