eslint-plugin-react-dom 3.0.0 → 4.0.0-beta.1

package/README.md

@@ -13,7 +13,7 @@ npm install --save-dev eslint-plugin-react-dom
 
 ```ts
 import js from "@eslint/js";
-import dom from "eslint-plugin-react-dom";
+import reactDom from "eslint-plugin-react-dom";
 import { defineConfig } from "eslint/config";
 import tseslint from "typescript-eslint";
 
@@ -24,7 +24,7 @@ export default defineConfig(
       js.configs.recommended,
       tseslint.configs.recommended,
       // Add configs from eslint-plugin-react-dom
-      dom.configs.recommended,
+      reactDom.configs.recommended,
     ],
     rules: {
       // Put rules you want to override here

package/dist/index.js

@@ -1,5 +1,5 @@
 import { DEFAULT_ESLINT_REACT_SETTINGS, RE_JAVASCRIPT_PROTOCOL, WEBSITE_URL, defineRuleListener, getSettingsFromContext } from "@eslint-react/shared";
-import { JsxInspector } from "@eslint-react/core";
+import { findAttribute, getAttributeStaticValue, getElementFullType, hasAnyAttribute, hasAttribute, isHostElement, isWhitespace, resolveAttributeValue } from "@eslint-react/jsx";
 import { ESLintUtils } from "@typescript-eslint/utils";
 import { AST_NODE_TYPES } from "@typescript-eslint/types";
 import { compare } from "compare-versions";
@@ -24,7 +24,7 @@ var __exportAll = (all, no_symbols) => {
 //#endregion
 //#region package.json
 var name$2 = "eslint-plugin-react-dom";
-var version = "3.0.0";
+var version = "4.0.0-beta.1";
 
 //#endregion
 //#region src/utils/create-jsx-element-resolver.ts
@@ -41,15 +41,14 @@ var version = "3.0.0";
 */
 function createJsxElementResolver(context) {
 	const { polymorphicPropName } = getSettingsFromContext(context);
-	const jsx = JsxInspector.from(context);
 	return { resolve(node) {
-		const elementName = jsx.getElementType(node);
+		const elementName = getElementFullType(node);
 		const result = {
 			domElementType: elementName,
 			jsxElementType: elementName
 		};
 		if (elementName === elementName.toLowerCase() || polymorphicPropName == null) return result;
-		const polyPropValue = jsx.getAttributeValue(node, polymorphicPropName)?.toStatic();
+		const polyPropValue = getAttributeStaticValue(context, node, polymorphicPropName);
 		if (typeof polyPropValue === "string") return {
 			...result,
 			domElementType: polyPropValue
@@ -67,7 +66,7 @@ const createRule = ESLintUtils.RuleCreator(getDocsUrl);
 
 //#endregion
 //#region src/rules/no-dangerously-set-innerhtml-with-children/no-dangerously-set-innerhtml-with-children.ts
-const RULE_NAME$17 = "no-dangerously-set-innerhtml-with-children";
+const RULE_NAME$16 = "no-dangerously-set-innerhtml-with-children";
 var no_dangerously_set_innerhtml_with_children_default = createRule({
 	meta: {
 		type: "problem",
@@ -75,26 +74,16 @@ var no_dangerously_set_innerhtml_with_children_default = createRule({
 		messages: { default: "A DOM component cannot use both children and 'dangerouslySetInnerHTML'." },
 		schema: []
 	},
-	name: RULE_NAME$17,
-	create: create$17,
+	name: RULE_NAME$16,
+	create: create$16,
 	defaultOptions: []
 });
 const DSIH$1 = "dangerouslySetInnerHTML";
-/**
-* Check if a JSX child node is considered significant (i.e., not just whitespace for formatting)
-* @param node The JSX child node to check
-* @returns `true` if the node is significant, `false` otherwise
-*/
-function isSignificantChildren(node) {
-	if (!JsxInspector.isJsxText(node)) return true;
-	return !(node.raw.trim() === "" && node.raw.includes("\n"));
-}
-function create$17(context) {
+function create$16(context) {
 	if (!context.sourceCode.text.includes(DSIH$1)) return {};
-	const jsx = JsxInspector.from(context);
 	return defineRuleListener({ JSXElement(node) {
-		if (!jsx.hasAttribute(node, DSIH$1)) return;
-		const childrenPropOrNode = jsx.findAttribute(node, "children") ?? node.children.find(isSignificantChildren);
+		if (!hasAttribute(context, node, DSIH$1)) return;
+		const childrenPropOrNode = findAttribute(context, node, "children") ?? node.children.find((child) => !isWhitespace(child));
 		if (childrenPropOrNode == null) return;
 		context.report({
 			messageId: "default",
@@ -105,7 +94,7 @@ function create$17(context) {
 
 //#endregion
 //#region src/rules/no-dangerously-set-innerhtml/no-dangerously-set-innerhtml.ts
-const RULE_NAME$16 = "no-dangerously-set-innerhtml";
+const RULE_NAME$15 = "no-dangerously-set-innerhtml";
 const DSIH = "dangerouslySetInnerHTML";
 var no_dangerously_set_innerhtml_default = createRule({
 	meta: {
@@ -114,15 +103,14 @@ var no_dangerously_set_innerhtml_default = createRule({
 		messages: { default: "Using 'dangerouslySetInnerHTML' may have security implications." },
 		schema: []
 	},
-	name: RULE_NAME$16,
-	create: create$16,
+	name: RULE_NAME$15,
+	create: create$15,
 	defaultOptions: []
 });
-function create$16(context) {
+function create$15(context) {
 	if (!context.sourceCode.text.includes(DSIH)) return {};
-	const jsx = JsxInspector.from(context);
 	return defineRuleListener({ JSXElement(node) {
-		const dsihProp = jsx.findAttribute(node, DSIH);
+		const dsihProp = findAttribute(context, node, DSIH);
 		if (dsihProp == null) return;
 		context.report({
 			messageId: "default",
@@ -133,7 +121,7 @@ function create$16(context) {
 
 //#endregion
 //#region src/rules/no-find-dom-node/no-find-dom-node.ts
-const RULE_NAME$15 = "no-find-dom-node";
+const RULE_NAME$14 = "no-find-dom-node";
 var no_find_dom_node_default = createRule({
 	meta: {
 		type: "problem",
@@ -141,12 +129,12 @@ var no_find_dom_node_default = createRule({
 		messages: { default: "[Deprecated] Use alternatives instead." },
 		schema: []
 	},
-	name: RULE_NAME$15,
-	create: create$15,
+	name: RULE_NAME$14,
+	create: create$14,
 	defaultOptions: []
 });
 const findDOMNode = "findDOMNode";
-function create$15(context) {
+function create$14(context) {
 	if (!context.sourceCode.text.includes(findDOMNode)) return {};
 	return defineRuleListener({ CallExpression(node) {
 		const { callee } = node;
@@ -169,7 +157,7 @@ function create$15(context) {
 
 //#endregion
 //#region src/rules/no-flush-sync/no-flush-sync.ts
-const RULE_NAME$14 = "no-flush-sync";
+const RULE_NAME$13 = "no-flush-sync";
 var no_flush_sync_default = createRule({
 	meta: {
 		type: "problem",
@@ -177,12 +165,12 @@ var no_flush_sync_default = createRule({
 		messages: { default: "Using 'flushSync' is uncommon and can hurt the performance of your app." },
 		schema: []
 	},
-	name: RULE_NAME$14,
-	create: create$14,
+	name: RULE_NAME$13,
+	create: create$13,
 	defaultOptions: []
 });
 const flushSync = "flushSync";
-function create$14(context) {
+function create$13(context) {
 	if (!context.sourceCode.text.includes(flushSync)) return {};
 	return defineRuleListener({ CallExpression(node) {
 		const { callee } = node;
@@ -205,7 +193,7 @@ function create$14(context) {
 
 //#endregion
 //#region src/rules/no-hydrate/no-hydrate.ts
-const RULE_NAME$13 = "no-hydrate";
+const RULE_NAME$12 = "no-hydrate";
 var no_hydrate_default = createRule({
 	meta: {
 		type: "problem",
@@ -214,12 +202,12 @@ var no_hydrate_default = createRule({
 		messages: { default: "[Deprecated] Use 'hydrateRoot()' instead." },
 		schema: []
 	},
-	name: RULE_NAME$13,
-	create: create$13,
+	name: RULE_NAME$12,
+	create: create$12,
 	defaultOptions: []
 });
 const hydrate = "hydrate";
-function create$13(context) {
+function create$12(context) {
 	if (!context.sourceCode.text.includes(hydrate)) return {};
 	if (compare(getSettingsFromContext(context).version, "18.0.0", "<")) return {};
 	const reactDomNames = /* @__PURE__ */ new Set();
@@ -270,7 +258,7 @@ function getFix$2(context, node) {
 
 //#endregion
 //#region src/rules/no-missing-button-type/no-missing-button-type.ts
-const RULE_NAME$12 = "no-missing-button-type";
+const RULE_NAME$11 = "no-missing-button-type";
 const BUTTON_TYPES = [
 	"button",
 	"submit",
@@ -287,16 +275,15 @@ var no_missing_button_type_default = createRule({
 		},
 		schema: []
 	},
-	name: RULE_NAME$12,
-	create: create$12,
+	name: RULE_NAME$11,
+	create: create$11,
 	defaultOptions: []
 });
-function create$12(context) {
+function create$11(context) {
 	const resolver = createJsxElementResolver(context);
-	const jsx = JsxInspector.from(context);
 	return defineRuleListener({ JSXElement(node) {
 		if (resolver.resolve(node).domElementType !== "button") return;
-		if (jsx.hasAttribute(node, "type")) return;
+		if (hasAttribute(context, node, "type")) return;
 		context.report({
 			messageId: "missingTypeAttribute",
 			node: node.openingElement,
@@ -311,7 +298,7 @@ function create$12(context) {
 
 //#endregion
 //#region src/rules/no-missing-iframe-sandbox/no-missing-iframe-sandbox.ts
-const RULE_NAME$11 = "no-missing-iframe-sandbox";
+const RULE_NAME$10 = "no-missing-iframe-sandbox";
 var no_missing_iframe_sandbox_default = createRule({
 	meta: {
 		type: "problem",
@@ -324,17 +311,16 @@ var no_missing_iframe_sandbox_default = createRule({
 		},
 		schema: []
 	},
-	name: RULE_NAME$11,
-	create: create$11,
+	name: RULE_NAME$10,
+	create: create$10,
 	defaultOptions: []
 });
-function create$11(context) {
+function create$10(context) {
 	const resolver = createJsxElementResolver(context);
-	const jsx = JsxInspector.from(context);
 	return defineRuleListener({ JSXElement(node) {
 		const { domElementType } = resolver.resolve(node);
 		if (domElementType !== "iframe") return;
-		const sandboxProp = jsx.findAttribute(node, "sandbox");
+		const sandboxProp = findAttribute(context, node, "sandbox");
 		if (sandboxProp == null) {
 			context.report({
 				messageId: "missingSandboxAttribute",
@@ -349,7 +335,7 @@ function create$11(context) {
 			});
 			return;
 		}
-		const sandboxValue = jsx.resolveAttributeValue(sandboxProp);
+		const sandboxValue = resolveAttributeValue(context, sandboxProp);
 		if (typeof sandboxValue.toStatic() === "string") return;
 		if (sandboxValue.kind === "spreadProps" && typeof sandboxValue.getProperty("sandbox") === "string") return;
 		context.report({
@@ -367,33 +353,6 @@ function create$11(context) {
 	} });
 }
 
-//#endregion
-//#region src/rules/no-namespace/no-namespace.ts
-const RULE_NAME$10 = "no-namespace";
-var no_namespace_default = createRule({
-	meta: {
-		type: "problem",
-		docs: { description: "Enforces the absence of a 'namespace' in React elements." },
-		messages: { default: "A React component '{{name}}' must not be in a namespace, as React does not support them." },
-		schema: []
-	},
-	name: RULE_NAME$10,
-	create: create$10,
-	defaultOptions: []
-});
-function create$10(context) {
-	const jsx = JsxInspector.from(context);
-	return defineRuleListener({ JSXElement(node) {
-		const name = jsx.getElementType(node);
-		if (typeof name !== "string" || !name.includes(":")) return;
-		context.report({
-			data: { name },
-			messageId: "default",
-			node: node.openingElement.name
-		});
-	} });
-}
-
 //#endregion
 //#region src/rules/no-render-return-value/no-render-return-value.ts
 const RULE_NAME$9 = "no-render-return-value";
@@ -537,10 +496,9 @@ var no_script_url_default = createRule({
 	defaultOptions: []
 });
 function create$7(context) {
-	const jsx = JsxInspector.from(context);
 	return defineRuleListener({ JSXAttribute(node) {
 		if (node.name.type !== AST_NODE_TYPES.JSXIdentifier || node.value == null) return;
-		const value = jsx.resolveAttributeValue(node).toStatic();
+		const value = resolveAttributeValue(context, node).toStatic();
 		if (typeof value === "string" && RE_JAVASCRIPT_PROTOCOL.test(value)) context.report({
 			messageId: "default",
 			node: node.value
@@ -563,12 +521,11 @@ var no_string_style_prop_default = createRule({
 	defaultOptions: []
 });
 function create$6(context) {
-	const jsx = JsxInspector.from(context);
 	return defineRuleListener({ JSXElement(node) {
-		if (!jsx.isHostElement(node)) return;
-		const styleProp = jsx.findAttribute(node, "style");
+		if (!isHostElement(node)) return;
+		const styleProp = findAttribute(context, node, "style");
 		if (styleProp == null) return;
-		const styleValue = jsx.resolveAttributeValue(styleProp);
+		const styleValue = resolveAttributeValue(context, styleProp);
 		if (typeof styleValue.toStatic() === "string") context.report({
 			messageId: "default",
 			node: styleValue.node ?? styleProp
@@ -1739,12 +1696,11 @@ var no_unsafe_iframe_sandbox_default = createRule({
 });
 function create$4(context) {
 	const resolver = createJsxElementResolver(context);
-	const jsx = JsxInspector.from(context);
 	return defineRuleListener({ JSXElement(node) {
 		if (resolver.resolve(node).domElementType !== "iframe") return;
-		const sandboxProp = jsx.findAttribute(node, "sandbox");
+		const sandboxProp = findAttribute(context, node, "sandbox");
 		if (sandboxProp == null) return;
-		const sandboxValue = jsx.resolveAttributeValue(sandboxProp);
+		const sandboxValue = resolveAttributeValue(context, sandboxProp);
 		if (isUnsafeSandboxCombination(sandboxValue.kind === "spreadProps" ? sandboxValue.getProperty("sandbox") : sandboxValue.toStatic())) context.report({
 			messageId: "default",
 			node: sandboxValue.node ?? sandboxProp
@@ -1793,20 +1749,12 @@ var no_unsafe_target_blank_default = createRule({
 });
 function create$3(context) {
 	const resolver = createJsxElementResolver(context);
-	const jsx = JsxInspector.from(context);
 	return defineRuleListener({ JSXElement(node) {
 		const { domElementType } = resolver.resolve(node);
 		if (domElementType !== "a") return;
-		const findAttribute = (name) => jsx.findAttribute(node, name);
-		const targetProp = findAttribute("target");
-		if (targetProp == null) return;
-		const targetValue = jsx.resolveAttributeValue(targetProp);
-		if ((targetValue.kind === "spreadProps" ? targetValue.getProperty("target") : targetValue.toStatic()) !== "_blank") return;
-		const hrefProp = findAttribute("href");
-		if (hrefProp == null) return;
-		const hrefValue = jsx.resolveAttributeValue(hrefProp);
-		if (!isExternalLinkLike(hrefValue.kind === "spreadProps" ? hrefValue.getProperty("href") : hrefValue.toStatic())) return;
-		const relProp = findAttribute("rel");
+		if (getAttributeStaticValue(context, node, "target") !== "_blank") return;
+		if (!isExternalLinkLike(getAttributeStaticValue(context, node, "href"))) return;
+		const relProp = findAttribute(context, node, "rel");
 		if (relProp == null) {
 			context.report({
 				messageId: "default",
@@ -1820,8 +1768,7 @@ function create$3(context) {
 			});
 			return;
 		}
-		const relValue = jsx.resolveAttributeValue(relProp);
-		if (isSafeRel(relValue.kind === "spreadProps" ? relValue.getProperty("rel") : relValue.toStatic())) return;
+		if (isSafeRel(getAttributeStaticValue(context, node, "rel"))) return;
 		context.report({
 			messageId: "default",
 			node: relProp,
@@ -1931,13 +1878,10 @@ var no_void_elements_with_children_default = createRule({
 });
 function create$1(context) {
 	const resolver = createJsxElementResolver(context);
-	const jsx = JsxInspector.from(context);
 	return defineRuleListener({ JSXElement(node) {
 		const { domElementType } = resolver.resolve(node);
 		if (!voidElements.has(domElementType)) return;
-		const hasChildrenProp = jsx.hasAttribute(node, "children");
-		const hasDangerouslySetInnerHTML = jsx.hasAttribute(node, "dangerouslySetInnerHTML");
-		if (node.children.length > 0 || hasChildrenProp || hasDangerouslySetInnerHTML) context.report({
+		if (node.children.length > 0 || hasAnyAttribute(context, node, ["children", "dangerouslySetInnerHTML"])) context.report({
 			data: { elementType: domElementType },
 			messageId: "default",
 			node
@@ -2003,7 +1947,6 @@ const plugin = {
 		"no-hydrate": no_hydrate_default,
 		"no-missing-button-type": no_missing_button_type_default,
 		"no-missing-iframe-sandbox": no_missing_iframe_sandbox_default,
-		"no-namespace": no_namespace_default,
 		"no-render": no_render_default,
 		"no-render-return-value": no_render_return_value_default,
 		"no-script-url": no_script_url_default,
@@ -2032,7 +1975,6 @@ const rules$1 = {
 	"react-dom/no-find-dom-node": "error",
 	"react-dom/no-flush-sync": "error",
 	"react-dom/no-hydrate": "error",
-	"react-dom/no-namespace": "error",
 	"react-dom/no-render": "error",
 	"react-dom/no-render-return-value": "error",
 	"react-dom/no-script-url": "warn",

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-dom",
-  "version": "3.0.0",
+  "version": "4.0.0-beta.1",
   "description": "ESLint React's ESLint plugin for DOM related rules.",
   "keywords": [
     "react",
@@ -38,23 +38,24 @@
     "./package.json"
   ],
   "dependencies": {
-    "@typescript-eslint/scope-manager": "^8.57.0",
-    "@typescript-eslint/types": "^8.57.0",
-    "@typescript-eslint/utils": "^8.57.0",
+    "@typescript-eslint/scope-manager": "^8.57.2",
+    "@typescript-eslint/types": "^8.57.2",
+    "@typescript-eslint/utils": "^8.57.2",
     "compare-versions": "^6.1.1",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/ast": "3.0.0",
-    "@eslint-react/core": "3.0.0",
-    "@eslint-react/shared": "3.0.0",
-    "@eslint-react/var": "3.0.0"
+    "@eslint-react/ast": "4.0.0-beta.1",
+    "@eslint-react/core": "4.0.0-beta.1",
+    "@eslint-react/jsx": "4.0.0-beta.1",
+    "@eslint-react/shared": "4.0.0-beta.1",
+    "@eslint-react/var": "4.0.0-beta.1"
   },
   "devDependencies": {
     "@types/react": "^19.2.14",
     "@types/react-dom": "^19.2.3",
-    "eslint": "^10.0.3",
-    "tsdown": "^0.21.2",
-    "@local/eff": "3.0.0-beta.72",
-    "@local/configs": "0.0.0"
+    "eslint": "^10.1.0",
+    "tsdown": "^0.21.4",
+    "@local/configs": "0.0.0",
+    "@local/eff": "3.0.0-beta.72"
   },
   "peerDependencies": {
     "eslint": "^10.0.0",