eslint-plugin-react-dom 3.0.0-beta.32 → 3.0.0-beta.34

package/dist/index.js

@@ -23,7 +23,7 @@ var __exportAll = (all, no_symbols) => {
 //#endregion
 //#region package.json
 var name$2 = "eslint-plugin-react-dom";
-var version = "3.0.0-beta.32";
+var version = "3.0.0-beta.34";
 
 //#endregion
 //#region src/utils/create-jsx-element-resolver.ts
@@ -67,72 +67,72 @@ function getDocsUrl(ruleName) {
 const createRule = ESLintUtils.RuleCreator(getDocsUrl);
 
 //#endregion
-//#region src/rules/no-dangerously-set-innerhtml.ts
-const RULE_NAME$17 = "no-dangerously-set-innerhtml";
-const DSIH$1 = "dangerouslySetInnerHTML";
-var no_dangerously_set_innerhtml_default = createRule({
+//#region src/rules/no-dangerously-set-innerhtml-with-children/no-dangerously-set-innerhtml-with-children.ts
+const RULE_NAME$17 = "no-dangerously-set-innerhtml-with-children";
+var no_dangerously_set_innerhtml_with_children_default = createRule({
 	meta: {
 		type: "problem",
-		docs: { description: "Disallows DOM elements from using 'dangerouslySetInnerHTML'." },
-		messages: { default: "Using 'dangerouslySetInnerHTML' may have security implications." },
+		docs: { description: "Disallows DOM elements from using 'dangerouslySetInnerHTML' and 'children' at the same time." },
+		messages: { default: "A DOM component cannot use both children and 'dangerouslySetInnerHTML'." },
 		schema: []
 	},
 	name: RULE_NAME$17,
 	create: create$17,
 	defaultOptions: []
 });
+const DSIH$1 = "dangerouslySetInnerHTML";
+/**
+* Check if a JSX child node is considered significant (i.e., not just whitespace for formatting)
+* @param node The JSX child node to check
+* @returns `true` if the node is significant, `false` otherwise
+*/
+function isSignificantChildren(node) {
+	if (!core.isJsxText(node)) return true;
+	return !(node.raw.trim() === "" && node.raw.includes("\n"));
+}
 function create$17(context) {
 	if (!context.sourceCode.text.includes(DSIH$1)) return {};
 	return defineRuleListener({ JSXElement(node) {
-		const dsihProp = core.getJsxAttribute(context, node)(DSIH$1);
-		if (dsihProp == null) return;
+		const findJsxAttribute = core.getJsxAttribute(context, node);
+		if (findJsxAttribute(DSIH$1) == null) return;
+		const childrenPropOrNode = findJsxAttribute("children") ?? node.children.find(isSignificantChildren);
+		if (childrenPropOrNode == null) return;
 		context.report({
 			messageId: "default",
-			node: dsihProp
+			node: childrenPropOrNode
 		});
 	} });
 }
 
 //#endregion
-//#region src/rules/no-dangerously-set-innerhtml-with-children.ts
-const RULE_NAME$16 = "no-dangerously-set-innerhtml-with-children";
-var no_dangerously_set_innerhtml_with_children_default = createRule({
+//#region src/rules/no-dangerously-set-innerhtml/no-dangerously-set-innerhtml.ts
+const RULE_NAME$16 = "no-dangerously-set-innerhtml";
+const DSIH = "dangerouslySetInnerHTML";
+var no_dangerously_set_innerhtml_default = createRule({
 	meta: {
 		type: "problem",
-		docs: { description: "Disallows DOM elements from using 'dangerouslySetInnerHTML' and 'children' at the same time." },
-		messages: { default: "A DOM component cannot use both children and 'dangerouslySetInnerHTML'." },
+		docs: { description: "Disallows DOM elements from using 'dangerouslySetInnerHTML'." },
+		messages: { default: "Using 'dangerouslySetInnerHTML' may have security implications." },
 		schema: []
 	},
 	name: RULE_NAME$16,
 	create: create$16,
 	defaultOptions: []
 });
-const DSIH = "dangerouslySetInnerHTML";
-/**
-* Check if a JSX child node is considered significant (i.e., not just whitespace for formatting)
-* @param node The JSX child node to check
-* @returns `true` if the node is significant, `false` otherwise
-*/
-function isSignificantChildren(node) {
-	if (!core.isJsxText(node)) return true;
-	return !(node.raw.trim() === "" && node.raw.includes("\n"));
-}
 function create$16(context) {
 	if (!context.sourceCode.text.includes(DSIH)) return {};
 	return defineRuleListener({ JSXElement(node) {
-		const findJsxAttribute = core.getJsxAttribute(context, node);
-		if (findJsxAttribute(DSIH) == null) return;
-		const childrenPropOrNode = findJsxAttribute("children") ?? node.children.find(isSignificantChildren);
-		if (childrenPropOrNode == null) return;
+		const dsihProp = core.getJsxAttribute(context, node)(DSIH);
+		if (dsihProp == null) return;
 		context.report({
 			messageId: "default",
-			node: childrenPropOrNode
+			node: dsihProp
 		});
 	} });
 }
 
 //#endregion
-//#region src/rules/no-find-dom-node.ts
+//#region src/rules/no-find-dom-node/no-find-dom-node.ts
 const RULE_NAME$15 = "no-find-dom-node";
 var no_find_dom_node_default = createRule({
 	meta: {
@@ -168,7 +168,7 @@ function create$15(context) {
 }
 
 //#endregion
-//#region src/rules/no-flush-sync.ts
+//#region src/rules/no-flush-sync/no-flush-sync.ts
 const RULE_NAME$14 = "no-flush-sync";
 var no_flush_sync_default = createRule({
 	meta: {
@@ -204,7 +204,7 @@ function create$14(context) {
 }
 
 //#endregion
-//#region src/rules/no-hydrate.ts
+//#region src/rules/no-hydrate/no-hydrate.ts
 const RULE_NAME$13 = "no-hydrate";
 var no_hydrate_default = createRule({
 	meta: {
@@ -269,7 +269,7 @@ function getFix$2(context, node) {
 }
 
 //#endregion
-//#region src/rules/no-missing-button-type.ts
+//#region src/rules/no-missing-button-type/no-missing-button-type.ts
 const RULE_NAME$12 = "no-missing-button-type";
 const BUTTON_TYPES = [
 	"button",
@@ -309,7 +309,7 @@ function create$12(context) {
 }
 
 //#endregion
-//#region src/rules/no-missing-iframe-sandbox.ts
+//#region src/rules/no-missing-iframe-sandbox/no-missing-iframe-sandbox.ts
 const RULE_NAME$11 = "no-missing-iframe-sandbox";
 var no_missing_iframe_sandbox_default = createRule({
 	meta: {
@@ -365,7 +365,7 @@ function create$11(context) {
 }
 
 //#endregion
-//#region src/rules/no-namespace.ts
+//#region src/rules/no-namespace/no-namespace.ts
 const RULE_NAME$10 = "no-namespace";
 var no_namespace_default = createRule({
 	meta: {
@@ -391,14 +391,20 @@ function create$10(context) {
 }
 
 //#endregion
-//#region src/rules/no-render.ts
-const RULE_NAME$9 = "no-render";
-var no_render_default = createRule({
+//#region src/rules/no-render-return-value/no-render-return-value.ts
+const RULE_NAME$9 = "no-render-return-value";
+const banParentTypes = [
+	AST_NODE_TYPES.VariableDeclarator,
+	AST_NODE_TYPES.Property,
+	AST_NODE_TYPES.ReturnStatement,
+	AST_NODE_TYPES.ArrowFunctionExpression,
+	AST_NODE_TYPES.AssignmentExpression
+];
+var no_render_return_value_default = createRule({
 	meta: {
 		type: "problem",
-		docs: { description: "Replaces usage of 'ReactDOM.render()' with 'createRoot(node).render()'." },
-		fixable: "code",
-		messages: { default: "[Deprecated] Use 'createRoot(node).render()' instead." },
+		docs: { description: "Disallows the return value of 'ReactDOM.render'." },
+		messages: { default: "Do not depend on the return value from 'ReactDOM.render'." },
 		schema: []
 	},
 	name: RULE_NAME$9,
@@ -406,25 +412,21 @@ var no_render_default = createRule({
 	defaultOptions: []
 });
 function create$9(context) {
-	if (!context.sourceCode.text.includes("render")) return {};
-	if (compare(getSettingsFromContext(context).version, "18.0.0", "<")) return {};
 	const reactDomNames = new Set(["ReactDOM", "ReactDOM"]);
 	const renderNames = /* @__PURE__ */ new Set();
 	return defineRuleListener({
 		CallExpression(node) {
 			switch (true) {
-				case node.callee.type === AST_NODE_TYPES.Identifier && renderNames.has(node.callee.name):
+				case node.callee.type === AST_NODE_TYPES.Identifier && renderNames.has(node.callee.name) && banParentTypes.includes(node.parent.type):
 					context.report({
 						messageId: "default",
-						node,
-						fix: getFix$1(context, node)
+						node
 					});
 					return;
-				case node.callee.type === AST_NODE_TYPES.MemberExpression && node.callee.object.type === AST_NODE_TYPES.Identifier && node.callee.property.type === AST_NODE_TYPES.Identifier && node.callee.property.name === "render" && reactDomNames.has(node.callee.object.name):
+				case node.callee.type === AST_NODE_TYPES.MemberExpression && node.callee.object.type === AST_NODE_TYPES.Identifier && node.callee.property.type === AST_NODE_TYPES.Identifier && node.callee.property.name === "render" && reactDomNames.has(node.callee.object.name) && banParentTypes.includes(node.parent.type):
 					context.report({
 						messageId: "default",
-						node,
-						fix: getFix$1(context, node)
+						node
 					});
 					return;
 			}
@@ -445,36 +447,16 @@ function create$9(context) {
 		}
 	});
 }
-/**
-* Provides a fixer function to replace `render(app, container)` with `createRoot(container).render(app)`
-* @param context The rule context
-* @param node The `CallExpression` node to fix
-* @returns A fixer function or null if the fix cannot be applied
-*/
-function getFix$1(context, node) {
-	const getText = (n) => context.sourceCode.getText(n);
-	return (fixer) => {
-		const [arg0, arg1] = node.arguments;
-		if (arg0 == null || arg1 == null) return null;
-		return [fixer.insertTextBefore(context.sourceCode.ast, "import { createRoot } from \"react-dom/client\";\n"), fixer.replaceText(node, `createRoot(${getText(arg1)}).render(${getText(arg0)})`)];
-	};
-}
 
 //#endregion
-//#region src/rules/no-render-return-value.ts
-const RULE_NAME$8 = "no-render-return-value";
-const banParentTypes = [
-	AST_NODE_TYPES.VariableDeclarator,
-	AST_NODE_TYPES.Property,
-	AST_NODE_TYPES.ReturnStatement,
-	AST_NODE_TYPES.ArrowFunctionExpression,
-	AST_NODE_TYPES.AssignmentExpression
-];
-var no_render_return_value_default = createRule({
+//#region src/rules/no-render/no-render.ts
+const RULE_NAME$8 = "no-render";
+var no_render_default = createRule({
 	meta: {
 		type: "problem",
-		docs: { description: "Disallows the return value of 'ReactDOM.render'." },
-		messages: { default: "Do not depend on the return value from 'ReactDOM.render'." },
+		docs: { description: "Replaces usage of 'ReactDOM.render()' with 'createRoot(node).render()'." },
+		fixable: "code",
+		messages: { default: "[Deprecated] Use 'createRoot(node).render()' instead." },
 		schema: []
 	},
 	name: RULE_NAME$8,
@@ -482,21 +464,25 @@ var no_render_return_value_default = createRule({
 	defaultOptions: []
 });
 function create$8(context) {
+	if (!context.sourceCode.text.includes("render")) return {};
+	if (compare(getSettingsFromContext(context).version, "18.0.0", "<")) return {};
 	const reactDomNames = new Set(["ReactDOM", "ReactDOM"]);
 	const renderNames = /* @__PURE__ */ new Set();
 	return defineRuleListener({
 		CallExpression(node) {
 			switch (true) {
-				case node.callee.type === AST_NODE_TYPES.Identifier && renderNames.has(node.callee.name) && banParentTypes.includes(node.parent.type):
+				case node.callee.type === AST_NODE_TYPES.Identifier && renderNames.has(node.callee.name):
 					context.report({
 						messageId: "default",
-						node
+						node,
+						fix: getFix$1(context, node)
 					});
 					return;
-				case node.callee.type === AST_NODE_TYPES.MemberExpression && node.callee.object.type === AST_NODE_TYPES.Identifier && node.callee.property.type === AST_NODE_TYPES.Identifier && node.callee.property.name === "render" && reactDomNames.has(node.callee.object.name) && banParentTypes.includes(node.parent.type):
+				case node.callee.type === AST_NODE_TYPES.MemberExpression && node.callee.object.type === AST_NODE_TYPES.Identifier && node.callee.property.type === AST_NODE_TYPES.Identifier && node.callee.property.name === "render" && reactDomNames.has(node.callee.object.name):
 					context.report({
 						messageId: "default",
-						node
+						node,
+						fix: getFix$1(context, node)
 					});
 					return;
 			}
@@ -517,9 +503,23 @@ function create$8(context) {
 		}
 	});
 }
+/**
+* Provides a fixer function to replace `render(app, container)` with `createRoot(container).render(app)`
+* @param context The rule context
+* @param node The `CallExpression` node to fix
+* @returns A fixer function or null if the fix cannot be applied
+*/
+function getFix$1(context, node) {
+	const getText = (n) => context.sourceCode.getText(n);
+	return (fixer) => {
+		const [arg0, arg1] = node.arguments;
+		if (arg0 == null || arg1 == null) return null;
+		return [fixer.insertTextBefore(context.sourceCode.ast, "import { createRoot } from \"react-dom/client\";\n"), fixer.replaceText(node, `createRoot(${getText(arg1)}).render(${getText(arg0)})`)];
+	};
+}
 
 //#endregion
-//#region src/rules/no-script-url.ts
+//#region src/rules/no-script-url/no-script-url.ts
 const RULE_NAME$7 = "no-script-url";
 var no_script_url_default = createRule({
 	meta: {
@@ -544,7 +544,7 @@ function create$7(context) {
 }
 
 //#endregion
-//#region src/rules/no-string-style-prop.ts
+//#region src/rules/no-string-style-prop/no-string-style-prop.ts
 const RULE_NAME$6 = "no-string-style-prop";
 var no_string_style_prop_default = createRule({
 	meta: {
@@ -571,7 +571,7 @@ function create$6(context) {
 }
 
 //#endregion
-//#region src/rules/no-unknown-property.ts
+//#region src/rules/no-unknown-property/no-unknown-property.ts
 const RULE_NAME$5 = "no-unknown-property";
 const DEFAULTS = {
 	ignore: [],
@@ -1706,7 +1706,7 @@ function create$5(context) {
 }
 
 //#endregion
-//#region src/rules/no-unsafe-iframe-sandbox.ts
+//#region src/rules/no-unsafe-iframe-sandbox/no-unsafe-iframe-sandbox.ts
 const RULE_NAME$4 = "no-unsafe-iframe-sandbox";
 const UNSAFE_SANDBOX_VALUES = ["allow-scripts", "allow-same-origin"];
 /**
@@ -1746,7 +1746,7 @@ function create$4(context) {
 }
 
 //#endregion
-//#region src/rules/no-unsafe-target-blank.ts
+//#region src/rules/no-unsafe-target-blank/no-unsafe-target-blank.ts
 const RULE_NAME$3 = "no-unsafe-target-blank";
 /**
 * Check if a value appears to be an external link.
@@ -1825,7 +1825,7 @@ function create$3(context) {
 }
 
 //#endregion
-//#region src/rules/no-use-form-state.ts
+//#region src/rules/no-use-form-state/no-use-form-state.ts
 const RULE_NAME$2 = "no-use-form-state";
 var no_use_form_state_default = createRule({
 	meta: {
@@ -1887,7 +1887,7 @@ function getFix(context, node) {
 }
 
 //#endregion
-//#region src/rules/no-void-elements-with-children.ts
+//#region src/rules/no-void-elements-with-children/no-void-elements-with-children.ts
 const RULE_NAME$1 = "no-void-elements-with-children";
 const voidElements = new Set([
 	"area",
@@ -1935,7 +1935,7 @@ function create$1(context) {
 }
 
 //#endregion
-//#region src/rules/prefer-namespace-import.ts
+//#region src/rules/prefer-namespace-import/prefer-namespace-import.ts
 const RULE_NAME = "prefer-namespace-import";
 var prefer_namespace_import_default = createRule({
 	meta: {

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-dom",
-  "version": "3.0.0-beta.32",
+  "version": "3.0.0-beta.34",
   "description": "ESLint React's ESLint plugin for DOM related rules.",
   "keywords": [
     "react",
@@ -43,11 +43,11 @@
     "@typescript-eslint/utils": "canary",
     "compare-versions": "^6.1.1",
     "ts-pattern": "^5.9.0",
-    "@eslint-react/ast": "3.0.0-beta.32",
-    "@eslint-react/core": "3.0.0-beta.32",
-    "@eslint-react/shared": "3.0.0-beta.32",
-    "@eslint-react/eff": "3.0.0-beta.32",
-    "@eslint-react/var": "3.0.0-beta.32"
+    "@eslint-react/ast": "3.0.0-beta.34",
+    "@eslint-react/core": "3.0.0-beta.34",
+    "@eslint-react/shared": "3.0.0-beta.34",
+    "@eslint-react/var": "3.0.0-beta.34",
+    "@eslint-react/eff": "3.0.0-beta.34"
   },
   "devDependencies": {
     "@types/react": "^19.2.14",