eslint-plugin-react-dom 2.0.5-next.2 → 2.0.5-next.4

package/dist/index.js

@@ -1,5 +1,5 @@
 import { DEFAULT_ESLINT_REACT_SETTINGS, getConfigAdapters, getDocsUrl, getSettingsFromContext } from "@eslint-react/shared";
-import { getJsxAttribute, getJsxElementType, hasJsxAttribute, isJsxHostElement, isJsxText, resolveJsxAttributeValue } from "@eslint-react/core";
+import { getJsxAttribute, getJsxElementType, isJsxHostElement, isJsxText, resolveJsxAttributeValue } from "@eslint-react/core";
 import { ESLintUtils } from "@typescript-eslint/utils";
 import { AST_NODE_TYPES } from "@typescript-eslint/types";
 import { compare } from "compare-versions";
@@ -47,7 +47,7 @@ const settings = { "react-x": DEFAULT_ESLINT_REACT_SETTINGS };
 //#endregion
 //#region package.json
 var name = "eslint-plugin-react-dom";
-var version = "2.0.5-next.2";
+var version = "2.0.5-next.4";
 
 //#endregion
 //#region src/utils/create-jsx-element-resolver.ts
@@ -71,7 +71,7 @@ function createJsxElementResolver(context) {
 			jsxElementType: elementName
 		};
 		if (elementName === elementName.toLowerCase() || polymorphicPropName == null) return result;
-		const polymorphicProp = getJsxAttribute(context, node.openingElement.attributes, context.sourceCode.getScope(node))(polymorphicPropName);
+		const polymorphicProp = getJsxAttribute(context, node)(polymorphicPropName);
 		if (polymorphicProp != null) {
 			const staticValue = resolveJsxAttributeValue(context, polymorphicProp).toStatic(polymorphicPropName);
 			if (typeof staticValue === "string") return {
@@ -109,11 +109,11 @@ var no_dangerously_set_innerhtml_default = createRule({
 function create$17(context) {
 	if (!context.sourceCode.text.includes(DSIH$1)) return {};
 	return { JSXElement(node) {
-		const attr = getJsxAttribute(context, node.openingElement.attributes, context.sourceCode.getScope(node))(DSIH$1);
-		if (attr == null) return;
+		const dsihProp = getJsxAttribute(context, node)(DSIH$1);
+		if (dsihProp == null) return;
 		context.report({
 			messageId: "noDangerouslySetInnerhtml",
-			node: attr
+			node: dsihProp
 		});
 	} };
 }
@@ -138,9 +138,9 @@ var no_dangerously_set_innerhtml_with_children_default = createRule({
 });
 const DSIH = "dangerouslySetInnerHTML";
 /**
-* Checks if a JSX child node is considered significant (i.e., not just whitespace for formatting).
-* @param node The JSX child node to check.
-* @returns `true` if the node is significant, `false` otherwise.
+* Checks if a JSX child node is considered significant (i.e., not just whitespace for formatting)
+* @param node The JSX child node to check
+* @returns `true` if the node is significant, `false` otherwise
 */
 function isSignificantChildren(node) {
 	if (!isJsxText(node)) return true;
@@ -149,13 +149,13 @@ function isSignificantChildren(node) {
 function create$16(context) {
 	if (!context.sourceCode.text.includes(DSIH)) return {};
 	return { JSXElement(node) {
-		const findJsxAttribute = getJsxAttribute(context, node.openingElement.attributes, context.sourceCode.getScope(node));
+		const findJsxAttribute = getJsxAttribute(context, node);
 		if (findJsxAttribute(DSIH) == null) return;
-		const children = findJsxAttribute("children") ?? node.children.find(isSignificantChildren);
-		if (children == null) return;
+		const childrenPropOrNode = findJsxAttribute("children") ?? node.children.find(isSignificantChildren);
+		if (childrenPropOrNode == null) return;
 		context.report({
 			messageId: "noDangerouslySetInnerhtmlWithChildren",
-			node: children
+			node: childrenPropOrNode
 		});
 	} };
 }
@@ -341,7 +341,7 @@ function create$12(context) {
 	const resolver = createJsxElementResolver(context);
 	return { JSXElement(node) {
 		if (resolver.resolve(node).domElementType !== "button") return;
-		if (getJsxAttribute(context, node.openingElement.attributes, context.sourceCode.getScope(node))("type") != null) return;
+		if (getJsxAttribute(context, node)("type") != null) return;
 		context.report({
 			messageId: "noMissingButtonType",
 			node: node.openingElement,
@@ -362,14 +362,14 @@ var no_missing_iframe_sandbox_default = createRule({
 	meta: {
 		type: "problem",
 		docs: {
-			description: "Enforces explicit `sandbox` attribute for `iframe` elements.",
+			description: "Enforces explicit `sandbox` prop for `iframe` elements.",
 			[Symbol.for("rule_features")]: RULE_FEATURES$10
 		},
 		fixable: "code",
 		hasSuggestions: true,
 		messages: {
-			addIframeSandbox: "Add 'sandbox' attribute with value '{{value}}'.",
-			noMissingIframeSandbox: "Add missing 'sandbox' attribute on 'iframe' component."
+			addIframeSandbox: "Add 'sandbox' prop with value '{{value}}'.",
+			noMissingIframeSandbox: "Add missing 'sandbox' prop on 'iframe' component."
 		},
 		schema: []
 	},
@@ -382,8 +382,8 @@ function create$11(context) {
 	return { JSXElement(node) {
 		const { domElementType } = resolver.resolve(node);
 		if (domElementType !== "iframe") return;
-		const sandboxAttr = getJsxAttribute(context, node.openingElement.attributes, context.sourceCode.getScope(node))("sandbox");
-		if (sandboxAttr == null) {
+		const sandboxProp = getJsxAttribute(context, node)("sandbox");
+		if (sandboxProp == null) {
 			context.report({
 				messageId: "noMissingIframeSandbox",
 				node: node.openingElement,
@@ -397,17 +397,17 @@ function create$11(context) {
 			});
 			return;
 		}
-		const sandboxValue = resolveJsxAttributeValue(context, sandboxAttr);
+		const sandboxValue = resolveJsxAttributeValue(context, sandboxProp);
 		if (typeof sandboxValue.toStatic("sandbox") === "string") return;
 		context.report({
 			messageId: "noMissingIframeSandbox",
-			node: sandboxValue.node ?? sandboxAttr,
+			node: sandboxValue.node ?? sandboxProp,
 			suggest: [{
 				messageId: "addIframeSandbox",
 				data: { value: "" },
 				fix(fixer) {
 					if (sandboxValue.kind.startsWith("spread")) return null;
-					return fixer.replaceText(sandboxAttr, `sandbox=""`);
+					return fixer.replaceText(sandboxProp, `sandbox=""`);
 				}
 			}]
 		});
@@ -504,6 +504,12 @@ function create$9(context) {
 		}
 	};
 }
+/**
+* Provides a fixer function to replace `render(app, container)` with `createRoot(container).render(app)`
+* @param context The rule context
+* @param node The `CallExpression` node to fix
+* @returns A fixer function or null if the fix cannot be applied
+*/
 function getFix$1(context, node) {
 	const getText$1 = (n) => context.sourceCode.getText(n);
 	return (fixer) => {
@@ -625,12 +631,12 @@ var no_string_style_prop_default = createRule({
 function create$6(context) {
 	return { JSXElement(node) {
 		if (!isJsxHostElement(context, node)) return;
-		const styleAttr = getJsxAttribute(context, node.openingElement.attributes, context.sourceCode.getScope(node))("style");
-		if (styleAttr == null) return;
-		const styleValue = resolveJsxAttributeValue(context, styleAttr);
+		const styleProp = getJsxAttribute(context, node)("style");
+		if (styleProp == null) return;
+		const styleValue = resolveJsxAttributeValue(context, styleProp);
 		if (typeof styleValue.toStatic() === "string") context.report({
 			messageId: "noStringStyleProp",
-			node: styleValue.node ?? styleAttr
+			node: styleValue.node ?? styleProp
 		});
 	} };
 }
@@ -1775,9 +1781,11 @@ const RULE_NAME$4 = "no-unsafe-iframe-sandbox";
 const RULE_FEATURES$4 = [];
 const UNSAFE_SANDBOX_VALUES = ["allow-scripts", "allow-same-origin"];
 /**
-* Checks if the sandbox attribute value contains an unsafe combination.
-* @param value The value of the sandbox attribute.
-* @returns `true` if the value is a string and contains an unsafe combination, `false` otherwise.
+* Checks if the sandbox attribute value contains an unsafe combination
+* An iframe with both "allow-scripts" and "allow-same-origin" can remove its sandbox attribute,
+* making it as insecure as an iframe without any sandboxing
+* @param value The value of the sandbox attribute
+* @returns `true` if the value is a string and contains an unsafe combination, `false` otherwise
 */
 function isUnsafeSandboxCombination(value) {
 	if (typeof value !== "string") return false;
@@ -1801,13 +1809,13 @@ function create$4(context) {
 	const resolver = createJsxElementResolver(context);
 	return { JSXElement(node) {
 		if (resolver.resolve(node).domElementType !== "iframe") return;
-		const sandboxAttr = getJsxAttribute(context, node.openingElement.attributes, context.sourceCode.getScope(node))("sandbox");
-		if (sandboxAttr == null) return;
-		const sandboxValue = resolveJsxAttributeValue(context, sandboxAttr);
+		const sandboxProp = getJsxAttribute(context, node)("sandbox");
+		if (sandboxProp == null) return;
+		const sandboxValue = resolveJsxAttributeValue(context, sandboxProp);
 		const sandboxValueStatic = sandboxValue.toStatic("sandbox");
 		if (isUnsafeSandboxCombination(sandboxValueStatic)) context.report({
 			messageId: "noUnsafeIframeSandbox",
-			node: sandboxValue.node ?? sandboxAttr
+			node: sandboxValue.node ?? sandboxProp
 		});
 	} };
 }
@@ -1827,9 +1835,9 @@ function isExternalLinkLike(value) {
 	return value.startsWith("https://") || /^(?:\w+:|\/\/)/u.test(value);
 }
 /**
-* Checks if a rel attribute value contains the necessary security attributes.
+* Checks if a rel prop value contains the necessary security attributes.
 * At minimum, it should contain "noreferrer".
-* @param value - The rel attribute value to check
+* @param value - The rel prop value to check
 * @returns Whether the rel value is considered secure
 */
 function isSafeRel(value) {
@@ -1860,16 +1868,16 @@ function create$3(context) {
 	return { JSXElement(node) {
 		const { domElementType } = resolver.resolve(node);
 		if (domElementType !== "a") return;
-		const findAttribute = getJsxAttribute(context, node.openingElement.attributes, context.sourceCode.getScope(node));
-		const targetAttribute = findAttribute("target");
-		if (targetAttribute == null) return;
-		if (resolveJsxAttributeValue(context, targetAttribute).toStatic("target") !== "_blank") return;
-		const hrefAttribute = findAttribute("href");
-		if (hrefAttribute == null) return;
-		const hrefAttributeValue = resolveJsxAttributeValue(context, hrefAttribute).toStatic("href");
-		if (!isExternalLinkLike(hrefAttributeValue)) return;
-		const relAttribute = findAttribute("rel");
-		if (relAttribute == null) {
+		const findAttribute = getJsxAttribute(context, node);
+		const targetProp = findAttribute("target");
+		if (targetProp == null) return;
+		if (resolveJsxAttributeValue(context, targetProp).toStatic("target") !== "_blank") return;
+		const hrefProp = findAttribute("href");
+		if (hrefProp == null) return;
+		const hrefValue = resolveJsxAttributeValue(context, hrefProp).toStatic("href");
+		if (!isExternalLinkLike(hrefValue)) return;
+		const relProp = findAttribute("rel");
+		if (relProp == null) {
 			context.report({
 				messageId: "noUnsafeTargetBlank",
 				node: node.openingElement,
@@ -1882,15 +1890,15 @@ function create$3(context) {
 			});
 			return;
 		}
-		const relAttributeValue = resolveJsxAttributeValue(context, relAttribute).toStatic("rel");
-		if (isSafeRel(relAttributeValue)) return;
+		const relValue = resolveJsxAttributeValue(context, relProp).toStatic("rel");
+		if (isSafeRel(relValue)) return;
 		context.report({
 			messageId: "noUnsafeTargetBlank",
-			node: relAttribute,
+			node: relProp,
 			suggest: [{
 				messageId: "addRelNoreferrerNoopener",
 				fix(fixer) {
-					return fixer.replaceText(relAttribute, `rel="noreferrer noopener"`);
+					return fixer.replaceText(relProp, `rel="noreferrer noopener"`);
 				}
 			}]
 		});
@@ -1993,7 +2001,7 @@ var no_void_elements_with_children_default = createRule({
 			description: "Disallow `children` in void DOM elements.",
 			[Symbol.for("rule_features")]: RULE_FEATURES$1
 		},
-		messages: { noVoidElementsWithChildren: "'{{element}}' is a void element tag and must not have children." },
+		messages: { noVoidElementsWithChildren: "'{{elementType}}' is a void element tag and must not have children." },
 		schema: []
 	},
 	name: RULE_NAME$1,
@@ -2003,16 +2011,15 @@ var no_void_elements_with_children_default = createRule({
 function create$1(context) {
 	const resolver = createJsxElementResolver(context);
 	return { JSXElement(node) {
-		const { domElementType: elementName } = resolver.resolve(node);
-		if (!voidElements.has(elementName)) return;
-		const { attributes } = node.openingElement;
-		const initialScope = context.sourceCode.getScope(node);
-		const hasChildrenProp = hasJsxAttribute(context, "children", attributes, initialScope);
-		const hasDangerouslySetInnerHTML = hasJsxAttribute(context, "dangerouslySetInnerHTML", attributes, initialScope);
+		const { domElementType } = resolver.resolve(node);
+		if (!voidElements.has(domElementType)) return;
+		const findJsxAttribute = getJsxAttribute(context, node);
+		const hasChildrenProp = findJsxAttribute("children") != null;
+		const hasDangerouslySetInnerHTML = findJsxAttribute("dangerouslySetInnerHTML") != null;
 		if (node.children.length > 0 || hasChildrenProp || hasDangerouslySetInnerHTML) context.report({
 			messageId: "noVoidElementsWithChildren",
 			node,
-			data: { element: elementName }
+			data: { elementType: domElementType }
 		});
 	} };
 }

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-react-dom",
-  "version": "2.0.5-next.2",
+  "version": "2.0.5-next.4",
   "description": "ESLint React's ESLint plugin for React DOM related rules.",
   "keywords": [
     "react",
@@ -41,12 +41,12 @@
     "compare-versions": "^6.1.1",
     "string-ts": "^2.2.1",
     "ts-pattern": "^5.8.0",
-    "@eslint-react/core": "2.0.5-next.2",
-    "@eslint-react/kit": "2.0.5-next.2",
-    "@eslint-react/shared": "2.0.5-next.2",
-    "@eslint-react/var": "2.0.5-next.2",
-    "@eslint-react/ast": "2.0.5-next.2",
-    "@eslint-react/eff": "2.0.5-next.2"
+    "@eslint-react/ast": "2.0.5-next.4",
+    "@eslint-react/core": "2.0.5-next.4",
+    "@eslint-react/kit": "2.0.5-next.4",
+    "@eslint-react/eff": "2.0.5-next.4",
+    "@eslint-react/shared": "2.0.5-next.4",
+    "@eslint-react/var": "2.0.5-next.4"
   },
   "devDependencies": {
     "@types/react": "^19.1.16",