eslint-plugin-putout 28.0.5 → 28.2.0

package/eslint-v10/babel.js

@@ -0,0 +1,107 @@
+/**
+ * @fileoverview Wrapper around @babel-eslint/parser to make it work with ESLint v10.
+ * @author Milos Djermanovic
+ */
+
+'use strict';
+
+//-----------------------------------------------------------------------------
+// Requirements
+//-----------------------------------------------------------------------------
+const eslintScope = require('eslint-scope');
+
+const babelESLintParser = require('@babel/eslint-parser/experimental-worker');
+
+//------------------------------------------------------------------------------
+// Type Definitions
+//------------------------------------------------------------------------------
+/** @typedef {import("eslint-scope").ScopeManager} ScopeManager */
+//-----------------------------------------------------------------------------
+// Helpers
+//-----------------------------------------------------------------------------
+/**
+ * Add global variables and resolve references to all global variables.
+ * @this {ScopeManager}
+ * @param {string[]} names Names of global variables to add.
+ * @returns {void}
+ */
+function addGlobals(names) {
+    const [globalScope] = this.scopes;
+    
+    for (const name of names) {
+        let variable = globalScope.set.get(name);
+        
+        if (variable)
+            continue;
+        
+        variable = new eslintScope.Variable(name, globalScope);
+        
+        globalScope.variables.push(variable);
+        globalScope.set.set(name, variable);
+    }
+    
+    /*
+	 * "through" contains all references which definitions cannot be found.
+	 * Since we augment the global scope we need to update references
+	 * and remove the ones that were added.
+	 *
+	 * Also, babel-eslint's scope manager doesn't resolve references
+	 * to global `var` and `function` variables, so we'll resolve _all_
+	 * references to variables that exist in the global scope.
+	 */
+    globalScope.through = globalScope.through.filter((reference) => {
+        const {name} = reference.identifier;
+        const variable = globalScope.set.get(name);
+        
+        if (variable) {
+            /*
+			 * Links the variable and the reference.
+			 * And this reference is removed from `Scope#through`.
+			 */
+            reference.resolved = variable;
+            variable.references.push(reference);
+            
+            return false;
+        }
+        
+        return true;
+    });
+    
+    /*
+	 * "implicit" contains information about implicit global variables (those created
+	 * implicitly by assigning values to undeclared variables in non-strict code).
+	 * Since we augment the global scope, we need to remove the ones that were added.
+	 */
+    const {implicit} = globalScope;
+    
+    implicit.variables = implicit.variables.filter(({name}) => {
+        if (globalScope.set.has(name)) {
+            implicit.set.delete(name);
+            return false;
+        }
+        
+        return true;
+    });
+    // babel-eslint's scope manager doesn't produce "implicit.left"
+}
+
+//-----------------------------------------------------------------------------
+// Exports
+//-----------------------------------------------------------------------------
+module.exports = {
+    ...babelESLintParser,
+    parse(...args) {
+        const retv = babelESLintParser.parse(...args);
+        
+        retv.scopeManager.addGlobals = addGlobals;
+        
+        return retv;
+    },
+    parseForESLint(...args) {
+        const retv = babelESLintParser.parseForESLint(...args);
+        
+        retv.scopeManager.addGlobals = addGlobals;
+        
+        return retv;
+    },
+};

package/eslint-v10/ts.js

@@ -0,0 +1,106 @@
+/**
+ * @fileoverview Wrapper around @typescript-eslint/parser to make it work with ESLint v10.
+ * @author Milos Djermanovic
+ */
+
+'use strict';
+
+//-----------------------------------------------------------------------------
+// Requirements
+//-----------------------------------------------------------------------------
+const eslintScope = require('eslint-scope');
+const typescriptESLintParser = require('@typescript-eslint/parser');
+
+//------------------------------------------------------------------------------
+// Type Definitions
+//------------------------------------------------------------------------------
+/** @typedef {import("eslint-scope").ScopeManager} ScopeManager */
+//-----------------------------------------------------------------------------
+// Helpers
+//-----------------------------------------------------------------------------
+/**
+ * Add global variables and resolve references to all global variables.
+ * @this {ScopeManager}
+ * @param {string[]} names Names of global variables to add.
+ * @returns {void}
+ */
+function addGlobals(names) {
+    const [globalScope] = this.scopes;
+    
+    for (const name of names) {
+        let variable = globalScope.set.get(name);
+        
+        if (variable)
+            continue;
+        
+        variable = new eslintScope.Variable(name, globalScope);
+        
+        globalScope.variables.push(variable);
+        globalScope.set.set(name, variable);
+    }
+    
+    /*
+	 * "through" contains all references which definitions cannot be found.
+	 * Since we augment the global scope we need to update references
+	 * and remove the ones that were added.
+	 *
+	 * Also, typescript-eslint's scope manager doesn't resolve references
+	 * to global `var` and `function` variables, so we'll resolve _all_
+	 * references to variables that exist in the global scope.
+	 */
+    globalScope.through = globalScope.through.filter((reference) => {
+        const {name} = reference.identifier;
+        const variable = globalScope.set.get(name);
+        
+        if (variable) {
+            /*
+			 * Links the variable and the reference.
+			 * And this reference is removed from `Scope#through`.
+			 */
+            reference.resolved = variable;
+            variable.references.push(reference);
+            
+            return false;
+        }
+        
+        return true;
+    });
+    
+    /*
+	 * "implicit" contains information about implicit global variables (those created
+	 * implicitly by assigning values to undeclared variables in non-strict code).
+	 * Since we augment the global scope, we need to remove the ones that were added.
+	 */
+    const {implicit} = globalScope;
+    
+    implicit.variables = implicit.variables.filter(({name}) => {
+        if (globalScope.set.has(name)) {
+            implicit.set.delete(name);
+            return false;
+        }
+        
+        return true;
+    });
+    // typescript-eslint's scope manager doesn't produce "implicit.left"
+}
+
+//-----------------------------------------------------------------------------
+// Exports
+//-----------------------------------------------------------------------------
+module.exports = {
+    ...typescriptESLintParser,
+    parse(...args) {
+        const retv = typescriptESLintParser.parse(...args);
+        
+        retv.scopeManager.addGlobals = addGlobals;
+        
+        return retv;
+    },
+    parseForESLint(...args) {
+        const retv = typescriptESLintParser.parseForESLint(...args);
+        
+        retv.scopeManager.addGlobals = addGlobals;
+        
+        return retv;
+    },
+};

package/lib/long-properties-destructuring/index.js

@@ -5,6 +5,9 @@ const {isCorrectLoc} = require('../common');
 const {
     isImportDeclaration,
     isForOfStatement,
+    isIdentifier,
+    isSpreadElement,
+    isRestElement,
 } = types;
 
 const parseOptions = (options) => {
@@ -76,6 +79,9 @@ module.exports.filter = ({node}, options) => {
 
 function isCorrectPropertiesLength(properties, {maxLength}) {
     for (const prop of properties) {
+        if (!isIdentifier(prop.key) && !isSpreadElement(prop) && !isRestElement(prop))
+            return true;
+        
         const {name} = prop.key || prop.argument;
         
         if (name.length >= maxLength)

package/lib/markdown.mjs

@@ -1,6 +1,6 @@
 import parserOpts from '@putout/engine-parser/babel/options';
 import parserPlugins from '@putout/engine-parser/babel/plugins';
-import babel from '@babel/eslint-parser/experimental-worker';
+import babel from '#babel/eslint-parser/experimental-worker';
 import tsConfig from './ts.mjs';
 import {jsx} from './jsx.mjs';
 

package/lib/ts.mjs

@@ -1,8 +1,8 @@
 import {rules} from '@putout/eslint-config';
-import parser from '@typescript-eslint/parser';
 import tseslint from 'typescript-eslint';
 import tsPlugin from '@typescript-eslint/eslint-plugin';
 import stylistic from '@stylistic/eslint-plugin';
+import parser from '#typescript-eslint/parser';
 import {jsx} from './jsx.mjs';
 import * as plugin from './plugin.mjs';
 

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-putout",
-  "version": "28.0.5",
+  "version": "28.2.0",
   "type": "commonjs",
   "description": "ESLint plugin for 🐊Putout",
   "release": false,
@@ -12,7 +12,8 @@
     "url": "git+https://github.com/coderaiser/putout.git"
   },
   "exports": {
-    ".": "./lib/index.mjs"
+    ".": "./lib/index.mjs",
+    "./babel": "./eslint-v10/babel.js"
   },
   "keywords": [
     "putout",
@@ -51,6 +52,7 @@
     "eslint-plugin-n": "^17.0.0",
     "eslint-plugin-putout": "^28.0.0",
     "eslint-plugin-react": "^7.32.2",
+    "eslint-scope": "^9.0.0",
     "globals": "^16.0.0",
     "parse-import-specifiers": "^1.0.1",
     "try-catch": "^3.0.0",
@@ -63,7 +65,7 @@
     "@putout/plugin-eslint-plugin": "*",
     "@putout/test": "^14.0.0",
     "c8": "^10.0.0",
-    "eslint": "^9.0.0",
+    "eslint": "v10.0.0-alpha.0",
     "eslint-plugin-eslint-plugin": "^7.0.0",
     "madrun": "^11.0.0",
     "mocha": "^11.0.1",
@@ -71,6 +73,14 @@
     "simport": "^1.2.0",
     "supertape": "^11.0.3"
   },
+  "imports": {
+    "#typescript-eslint/parser": {
+      "default": "./eslint-v10/ts.js"
+    },
+    "#babel/eslint-parser/experimental-worker": {
+      "default": "./eslint-v10/babel.js"
+    }
+  },
   "engines": {
     "node": ">=20"
   },