eslint-plugin-putout 14.3.0 → 14.6.0

package/README.md

@@ -132,24 +132,24 @@ Disabled **ESLint** rules:
 
 Disabled 🐊**Putout** rules:
 
-- 🐲[`remove-empty`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-remove-empty#readme);
-- 🐲[`nodejs/remove-process-exit`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-nodejs#remove-process-exit#readme);
-- 🐲[`remove-unused-variables`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-remove-unused-variables#readme);
-- 🐲[`typescript/remove-unused-types`](https://github.com/coderaiser/putout/tree/v24.0.2/packages/plugin-typescript#remove-unused-types#readme);
-- 🐲[`remove-unused-for-of-variables`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-remove-unused-for-of-variables#readme);
-- 🐲[`remove-unused-expressions`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-removeunused-expressions#readme);
-- 🐲[`remove-unreferenced-variables`](https://github.com/coderaiser/putout/tree/24.1.0/packages/plugin-remove-unreferenced-variables#readme);
-- 🐲[`remove-useless-arguments`](https://github.com/coderaiser/putout/tree/master/packages/plugin-remove-useless-arguments#readme);
-- 🐲[`remove-useless-for-of`](https://github.com/coderaiser/putout/tree/master/packages/plugin-remove-useless-for-of#readme);
-- 🐲[`remove-useless-return`](https://github.com/coderaiser/putout/tree/master/packages/plugin-remove-useless-return#readme);
-- 🐲[`remove-useless-spread`](https://github.com/coderaiser/putout/tree/master/packages/plugin-remove-useless-spread/#readme#readme);
-- 🐲[`remove-useless-variables/rename`](https://github.com/coderaiser/putout/tree/master/packages/plugin-remove-useless-arguments#rename#readme);
-- 🐲[`remove-skip`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-tape#remove-skip);
-- 🐲[`remove-only`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-tape#remove-only);
-- 🐲[`remove-console`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-remove-console#readme);
-- 🐲[`remove-debugger`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-remove-debugger#readme);
-- 🐲[`remove-unreachable-code`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-remove-unreachable-code#readme);
-- 🐲[`convert-for-to-for-of`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-convert-for-to-for-of#readme);
+- ✅ [`remove-empty`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-remove-empty#readme);
+- ✅ [`nodejs/remove-process-exit`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-nodejs#remove-process-exit#readme);
+- ✅ [`remove-unused-variables`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-remove-unused-variables#readme);
+- ✅ [`typescript/remove-unused-types`](https://github.com/coderaiser/putout/tree/v24.0.2/packages/plugin-typescript#remove-unused-types#readme);
+- ✅ [`remove-unused-for-of-variables`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-remove-unused-for-of-variables#readme);
+- ✅ [`remove-unused-expressions`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-removeunused-expressions#readme);
+- ✅ [`remove-unreferenced-variables`](https://github.com/coderaiser/putout/tree/24.1.0/packages/plugin-remove-unreferenced-variables#readme);
+- ✅ [`remove-useless-arguments`](https://github.com/coderaiser/putout/tree/master/packages/plugin-remove-useless-arguments#readme);
+- ✅ [`remove-useless-for-of`](https://github.com/coderaiser/putout/tree/master/packages/plugin-remove-useless-for-of#readme);
+- ✅ [`remove-useless-return`](https://github.com/coderaiser/putout/tree/master/packages/plugin-remove-useless-return#readme);
+- ✅ [`remove-useless-spread`](https://github.com/coderaiser/putout/tree/master/packages/plugin-remove-useless-spread/#readme#readme);
+- ✅ [`remove-useless-variables/rename`](https://github.com/coderaiser/putout/tree/master/packages/plugin-remove-useless-arguments#rename#readme);
+- ✅ [`remove-skip`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-tape#remove-skip);
+- ✅ [`remove-only`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-tape#remove-only);
+- ✅ [`remove-console`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-remove-console#readme);
+- ✅ [`remove-debugger`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-remove-debugger#readme);
+- ✅ [`remove-unreachable-code`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-remove-unreachable-code#readme);
+- ✅ [`convert-for-to-for-of`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/plugin-convert-for-to-for-of#readme);
 
 ### safe+align
 

package/lib/destructuring-as-function-argument/README.md

@@ -1,12 +1,11 @@
-# Keep curly braces in one line when you use destructuring as function argument (`destructuring-as-function-argument`)
+# destructuring-as-function-argument
 
-When `putout` removes unused variable located in function argument object pattern, it formats in in a multiple lines.
+When 🐊[**Putout**](https://github.com/coderaiser/putout) [removes unused variables](https://github.com/coderaiser/putout/tree/master/packages/plugin-remove-unused-variables#readme) located in function argument object pattern, it formats it in a multiple lines.
+This rule aims keep curly braces in one line when you use destructuring as function argument.
 
-## Rule Details
+Part of [**eslint-plugin-putout**](https://github.com/coderaiser/putout/tree/master/packages/eslint-plugin-putout#rules).
 
-This rule aims to shorten destructuring of properties.
-
-Examples of **incorrect** code for this rule:
+## ❌ Example of incorrect code
 
 ```js
 const login = ({
@@ -16,7 +15,7 @@ const login = ({
 };
 ```
 
-Examples of **correct** code for this rule:
+## ✅ Example of correct code
 
 ```js
 const login = ({username, password}) => {

package/lib/keyword-spacing/index.js

@@ -87,13 +87,13 @@ function checkSwitch(text) {
 
 function fixCatch(text) {
     return text
-        .replace(/catch{/g, 'catch {')
-        .replace(/}catch/g, '} catch')
-        .replace(/catch \(/g, 'catch(');
+        .replaceAll('catch{', 'catch {')
+        .replaceAll('}catch', '} catch')
+        .replaceAll('catch (', 'catch(');
 }
 
 function fixSwitch(text) {
     return text
-        .replace(/switch \(/g, 'switch(');
+        .replaceAll('switch (', 'switch(');
 }
 

package/lib/newline-function-call-arguments/README.md

@@ -1,12 +1,11 @@
-# Keep curly braces in one line when property is single (`newline-function-call-arguments`)
+# newline-function-call-arguments
 
 Addition to eslint's [function-paren-newline](https://eslint.org/docs/rules/function-paren-newline)
+This rule aims to fix eslint transform adding new line after opening brace.
 
-## Rule Details
+Part of [**eslint-plugin-putout**](https://github.com/coderaiser/putout/tree/master/packages/eslint-plugin-putout#rules).
 
-This rule aims to fix eslint transform.
-
-Examples of **incorrect** code for this rule:
+## ❌ Example of incorrect code
 
 ```js
 const onConnectError = squad(superFn(connect_error),
@@ -15,7 +14,7 @@ const onConnectError = squad(superFn(connect_error),
     getDescription);
 ```
 
-Examples of **correct** code for this rule:
+## ✅ Example of correct code
 
 ```js
 const onConnectError = squad(

package/lib/no-unresolved/README.md

@@ -1,13 +1,19 @@
-# Check if path can be resolved and fix if cannot (`no-unresolved`)
+# no-unresolved
 
+Check if path can be resolved and fix if cannot.
 Similar to [`no-unresolved`](https://github.com/import-js/eslint-plugin-import/blob/HEAD/docs/rules/no-unresolved.md) from
-[`eslint-plugin-putout`](https://github.com/import-js/eslint-plugin-import). But supports only `ESM` and have `autofix`.
+[`eslint-plugin-import`](https://github.com/import-js/eslint-plugin-import). But supports only `ESM` and have `autofix`.
 
-## Rule Details
+Part of [`eslint-plugin-putout`](https://github.com/coderaiser/putout/tree/master/packages/eslint-plugin-putout#rules).
 
-This rule aims to fix `unresolved import`:
+[File extension is mandatory](https://nodejs.org/api/esm.html#esm_mandatory_file_extensions) and will produce an error from `node.js`:
 
-Examples of **incorrect** code for this rule:
+```
+Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/coderaiser/putout/y' imported from /Users/coderaiser/putout/x.mjs
+Did you mean to import ../y.js?
+```
+
+## ❌ Example of incorrect code
 
 ```js
 import x from './y';
@@ -18,14 +24,7 @@ export * as dir from './dir';
 export {m} from './y';
 ```
 
-[File extension is mandatory](https://nodejs.org/api/esm.html#esm_mandatory_file_extensions) and will produce an error from `node.js`:
-
-```
-Error [ERR_MODULE_NOT_FOUND]: Cannot find module '/Users/coderaiser/putout/y' imported from /Users/coderaiser/putout/x.mjs
-Did you mean to import ../y.js?
-```
-
-Examples of **correct** code for this rule:
+## ✅ Example of correct code
 
 ```js
 import x from './y.js';

package/lib/object-init/README.md

@@ -1,10 +1,10 @@
-# Keep each property on separate line when initializing an object(`object-init`)
+# object-init
 
-In the same way as eslint [object-property-newline](https://github.com/coderaiser/putout/tree/master/packages/eslint-plugin-putout/lib/multiple-properties-destructuring) but for initializing variables with `object expression`.
+Keep each property on separate line when initializing an object. In the same way as **ESLint** [`object-property-newline`](https://eslint.org/docs/rules/object-property-newline) but for initializing variables with [**Object Expression**](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Guide/Working_with_Objects).
 
-## Rule Details
+Part of [**eslint-plugin-putout**](https://github.com/coderaiser/putout/tree/master/packages/eslint-plugin-putout#rules).
 
-Examples of **incorrect** code for this rule:
+## ❌ Example of incorrect code
 
 ```js
 const user = {name};
@@ -12,7 +12,7 @@ const user = {name};
 module.exports = {lint: 'putout lint'};
 ```
 
-Examples of **correct** code for this rule:
+## ✅ Example of correct code
 
 ```js
 const user = {

package/lib/objects-braces-inside-array/README.md

@@ -1,8 +1,9 @@
-# Keep braces on the same line as brackets (`object-braces-inside-array`)
+# object-braces-inside-array
 
-## Rule Details
+Keep braces on the same line as brackets.
+Part of [**eslint-plugin-putout**](https://github.com/coderaiser/putout/tree/master/packages/eslint-plugin-putout#rules).
 
-Examples of **incorrect** code for this rule:
+## ❌ Example of incorrect code
 
 ```js
 const expected = [
@@ -15,7 +16,7 @@ const expected = [
 ];
 ```
 
-Examples of **correct** code for this rule:
+## ✅ Example of correct code
 
 ```js
 const expected = [{

package/lib/putout/index.js

@@ -58,6 +58,9 @@ module.exports = {
             parser: createParser(node),
         });
         
+        // remove parent nodes that was ignored before converting to babel
+        removeParent(ast);
+        
         const [error, places = []] = tryCatch(findPlaces, ast, text, resultOptions);
         
         if (error)
@@ -97,14 +100,20 @@ const fix = ({ast, text, node, source, resultOptions}) => (fixer) => {
     
     const [, last] = lastToken.range;
     
-    removeParent(ast);
     const code = print(ast);
     
     return fixer.replaceTextRange([0, last], code);
 };
 
+// 1. We cannot modify ESLint AST
+// 2. Parent nodes makes Recast go crazy, so they should be removed
+// 3. Recast creates original nodes with copies of each nodes
+// 4. Parser does nothing but returns original AST before estree to babel
+// 5. All this stuff made to gain performance benefit of avoiding a duble parsing: ESLint, and then Babel
+// 6. Always can be removed and switched to direct parsing by Putout, when benefits outweight supporting all of this magic
 const createParser = (node) => {
     const ast = copyAST(node);
+    removeParent(ast);
     
     const parser = {
         parse: returns(ast),
@@ -115,7 +124,7 @@ const createParser = (node) => {
 
 // ESLint adds parent to each node
 // it makes recase go crazy
-// so we better drop them
+// so we better drop them out
 //
 // https://github.com/eslint/eslint/blob/v8.4.0/lib/linter/linter.js#L964
 function removeParent(ast) {

package/lib/remove-empty-newline-after-import/README.md

@@ -1,10 +1,8 @@
-# Remove empty newline after import (`remove-empty-newline-after-import`)
+# remove-empty-newline-after-import
 
-## Rule Details
+This rule aims to remove empty newline after [`import` statement](https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Statements/import). Part of [**eslint-plugin-putout**](https://github.com/coderaiser/putout/tree/master/packages/eslint-plugin-putout#rules).
 
-This rule aims to remove empty newline after `import`.
-
-Examples of **incorrect** code for this rule:
+## ❌ Example of incorrect code
 
 ```js
 import {readFile} from 'fs';
@@ -14,7 +12,7 @@ import {promisify} from 'util';
 import index from './index.js';
 ```
 
-Examples of **correct** code for this rule:
+## ✅ Example of correct code
 
 ```js
 import {readFile} from 'fs';

package/lib/remove-empty-newline-after-import/index.js

@@ -68,6 +68,7 @@ module.exports = {
 
 function getImports(node) {
     const imports = [];
+    
     for (const current of node.body) {
         if (current.type === 'ImportDeclaration')
             imports.push(current);

package/lib/remove-empty-newline-after-last-element/README.md

@@ -1,7 +1,7 @@
 # remove-empty-newline-after-last-element
 
 Remove empty newline after last element.
-Part of [`eslint-plugin-putout`](https://github.com/coderaiser/putout/tree/master/packages/eslint-plugin-putout#rules).
+Part of [**eslint-plugin-putout**](https://github.com/coderaiser/putout/tree/master/packages/eslint-plugin-putout#rules).
 
 ## ❌ Example of incorrect code
 

package/lib/remove-empty-newline-before-first-specifier/README.md

@@ -1,10 +1,9 @@
-# Remove empty new line before first specifier (`remove-empty-newline-before-first-specifier`)
-
-## Rule Details
+# remove-empty-newline-before-first-specifier
 
 This rule aims to remove empty newline before first specifier.
+Part of [`eslint-plugin-putout`](https://github.com/coderaiser/putout/tree/master/packages/eslint-plugin-putout#rules).
 
-Examples of **incorrect** code for this rule:
+## ❌ Example of incorrect code
 
 ```js
 import {
@@ -20,7 +19,7 @@ push({
 });
 ```
 
-Examples of **correct** code for this rule:
+## ✅ Example of correct code
 
 ```js
 import {

package/lib/remove-empty-specifiers/README.md

@@ -1,16 +1,15 @@
-# Remove empty specifiers(`remove-empty-specifiers`)
-
-## Rule Details
+# remove-empty-specifiers
 
 This rule aims to remove empty specifiers.
+Part of [**eslint-plugin-putout**](https://github.com/coderaiser/putout/tree/master/packages/eslint-plugin-putout#rules).
 
-Examples of **incorrect** code for this rule:
+## ❌ Example of incorrect code
 
 ```js
 import putout, {} from 'putout';
 ```
 
-Examples of **correct** code for this rule:
+## ✅ Example of correct code
 
 ```js
 import putout from 'putout';

package/lib/remove-newline-from-empty-object/README.md

@@ -1,17 +1,16 @@
-# Remove new line in empty object (`remove-newline-from-empty-object`)
-
-## Rule Details
+# remove-newline-from-empty-object
 
 This rule aims to remove newline from empty object.
+Part of [`eslint-plugin-putout`](https://github.com/coderaiser/putout/tree/master/packages/eslint-plugin-putout#rules).
 
-Examples of **incorrect** code for this rule:
+## ❌ Example of incorrect code
 
 ```js
 const a = {
 };
 ```
 
-Examples of **correct** code for this rule:
+## ✅ Example of correct code
 
 ```js
 const a = {};

package/lib/ts.js

@@ -1,6 +1,7 @@
 'use strict';
 
 const {rules} = require('@putout/eslint-config');
+const warnOnUnsupportedTypeScriptVersion = false;
 
 const extensionRules = {
     'no-undef': 'off',
@@ -24,9 +25,7 @@ const extensionRules = {
     // broken
     '@typescript-eslint/indent': 'off',
     
-    'lines-between-class-members': 'off',
-    '@typescript-eslint/lines-between-class-members': 'error',
-    
+    '@typescript-eslint/lines-between-class-members': 'off',
     '@typescript-eslint/no-array-constructor': 'off',
     
     'no-extra-parens': 'off',
@@ -68,6 +67,7 @@ const ts = {
     files: '*.ts',
     parser: '@typescript-eslint/parser',
     parserOptions: {
+        warnOnUnsupportedTypeScriptVersion,
         ecmaFeatures: {
             jsx: false,
         },
@@ -94,6 +94,7 @@ module.exports = [
         ...ts,
         files: '*.tsx',
         parserOptions: {
+            warnOnUnsupportedTypeScriptVersion,
             ecmaFeatures: {
                 jsx: true,
             },
@@ -103,6 +104,7 @@ module.exports = [
 
 function convertPaddingLines([state, ...lines]) {
     const newLines = [];
+    
     for (const line of lines) {
         let {prev, next} = line;
         

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-putout",
-  "version": "14.3.0",
+  "version": "14.6.0",
   "type": "commonjs",
   "description": "eslint plugin for putout",
   "release": false,
@@ -52,7 +52,7 @@
     "@putout/test": "^5.0.0",
     "c8": "^7.5.0",
     "eslint": "^8.0.1",
-    "eslint-plugin-eslint-plugin": "^3.2.0",
+    "eslint-plugin-eslint-plugin": "^4.1.0",
     "madrun": "^9.0.0",
     "mocha": "^9.0.1",
     "montag": "^1.0.0",