eslint-plugin-putout 13.0.1 → 13.4.0

package/README.md

@@ -52,6 +52,7 @@ Then configure the rules you want to use under the rules section.
         "putout/remove-newline-from-empty-object": "error",
         "putout/remove-empty-newline-before-first-specifier": "error",
         "putout/remove-empty-newline-after-last-specifier": "error",
+        "putout/remove-empty-specifiers": "error",
         "putout/objects-braces-inside-array": "error",
         "putout/object-init": "error"
     }
@@ -79,6 +80,7 @@ Then configure the rules you want to use under the rules section.
 - [Remove newline from empty object](/packages/eslint-plugin-putout/lib/remove-newline-from-empty-object)
 - [Remove empty newline before first specifier](/packages/eslint-plugin-putout/lib/remove-empty-newline-before-first-specifier)
 - [Remove empty newline after last specifier](/packages/eslint-plugin-putout/lib/remove-empty-newline-after-last-specifier)
+- [Remove empty specifiers](/packages/eslint-plugin-putout/lib/remove-empty-specifiers)
 - [Objects braces inside array](/packages/eslint-plugin-putout/lib/objects-braces-inside-array)
 - [Object init](/packages/eslint-plugin-putout/lib/object-init)
 - [No unresolved](/packages/eslint-plugin-putout/lib/no-unresolved)
@@ -101,10 +103,6 @@ When using 🐊`Putout` in IDE with `--fix` on save, or when you want to disable
 }
 ```
 
-### safe+align
-
-When you want to enable ability to align spaces on empty lines, use `safe+align`.
-
 Disabled `ESLint` rules:
 
 - [`no-useless-return`](https://eslint.org/docs/rules/no-useless-return)
@@ -120,9 +118,15 @@ Disabled 🐊`Putout` rules:
 - [`remove-unused-expressions`](https://github.com/coderaiser/putout/tree/v24.0.0/packages);
 - [`remove-useless-return`](https://github.com/coderaiser/putout/tree/master/remove-useless-return);
 - [`remove-useless-arguments`](https://github.com/coderaiser/putout/tree/master/remove-useless-arguments);
+- [`remove-useless-variables/rename`](https://github.com/coderaiser/putout/tree/master/remove-useless-arguments#rename);
 - [`remove-skip`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/remove-skip);
 - [`remove-only`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/remove-only);
 - [`remove-console`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/remove-console);
 - [`remove-debugger`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/remove-debugger);
 - [`remove-unreachable-code`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/remove-unreachable-code);
 - [`convert-for-to-for-of`](https://github.com/coderaiser/putout/tree/v24.0.0/packages/convert-for-to-for-of);
+
+### safe+align
+
+When you want to enable ability to align spaces on empty lines, while have all benefits of `safe` preset: use `safe+align`.
+

package/lib/add-newline-before-function-call/index.js

@@ -33,6 +33,9 @@ module.exports.filter = ({text, node, getCommentsBefore, getSpacesBeforeNode}) =
     
     const spaces = getSpacesBeforeNode(node, text);
     
+    if (!spaces)
+        return false;
+    
     if (regExp.test(spaces))
         return false;
     
@@ -43,7 +46,6 @@ module.exports.filter = ({text, node, getCommentsBefore, getSpacesBeforeNode}) =
             continue;
         
         const prevA = body[i - 1];
-        const nextA = body[i + 1];
         
         if (!isVariableDeclaration(prevA))
             return false;
@@ -53,11 +55,7 @@ module.exports.filter = ({text, node, getCommentsBefore, getSpacesBeforeNode}) =
         if (regExp.test(spaces))
             return false;
         
-        if (!nextA)
-            return true;
-        
-        const nextSpaces = getSpacesBeforeNode(nextA);
-        return !regExp.test(nextSpaces);
+        return true;
     }
     
     return false;

package/lib/index.js

@@ -33,6 +33,7 @@ module.exports.rules = {
     ...getWrapRule('remove-newline-from-empty-object'),
     ...getWrapRule('remove-empty-newline-before-first-specifier'),
     ...getWrapRule('remove-empty-newline-after-last-specifier'),
+    ...getWrapRule('remove-empty-specifiers'),
     ...getWrapRule('objects-braces-inside-array'),
     ...getWrapRule('object-init'),
     ...getWrapRule('no-unresolved'),
@@ -70,6 +71,7 @@ const recommended = {
         'putout/remove-newline-from-empty-object': 'error',
         'putout/remove-empty-newline-before-first-specifier': 'error',
         'putout/remove-empty-newline-after-last-specifier': 'error',
+        'putout/remove-empty-specifiers': 'error',
         'putout/objects-braces-inside-array': 'error',
         'putout/object-init': 'error',
         'putout/no-unresolved': 'error',
@@ -111,6 +113,7 @@ const safe = {
                 'remove-unreachable-code': 'off',
                 'remove-useless-return': 'off',
                 'remove-useless-arguments': 'off',
+                'remove-useless-variables/rename': 'off',
                 'tape/remove-skip': 'off',
                 'tape/remove-only': 'off',
                 'remove-console': 'off',

package/lib/remove-empty-specifiers/README.md

@@ -0,0 +1,17 @@
+# Remove empty specifiers(`remove-empty-specifiers`)
+
+## Rule Details
+
+This rule aims to remove empty specifiers.
+
+Examples of **incorrect** code for this rule:
+
+```js
+import putout, {} from 'putout';
+```
+
+Examples of **correct** code for this rule:
+
+```js
+import putout from 'putout';
+```

package/lib/remove-empty-specifiers/index.js

@@ -0,0 +1,24 @@
+'use strict';
+
+module.exports.category = 'object';
+module.exports.report = () => 'Remove empty import specifiers';
+
+module.exports.filter = ({text, node, getCommentsInside}) => {
+    const comments = getCommentsInside(node);
+    
+    if (comments.length)
+        return false;
+    
+    return text.includes('{}');
+};
+
+module.exports.fix = ({text}) => {
+    return text
+        .replace('import {} from', 'import')
+        .replace(/,? {}/, '');
+};
+
+module.exports.include = () => [
+    'ImportDeclaration',
+];
+

package/lib/single-property-destructuring/index.js

@@ -26,7 +26,10 @@ module.exports.include = () => [
     'ImportDeclaration[specifiers.length=1]',
 ];
 
-module.exports.filter = ({node, text, getText}) => {
+module.exports.filter = ({node, text, getText, getCommentsInside}) => {
+    if (getCommentsInside(node).length)
+        return false;
+    
     const parentText = getText(node.parent);
     
     if (isImportDeclaration(node) && !compare(node.specifiers[0].local, node.specifiers[0].imported))

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-putout",
-  "version": "13.0.1",
+  "version": "13.4.0",
   "type": "commonjs",
   "description": "eslint plugin for putout",
   "release": false,