eslint-plugin-primer-react 8.5.0-rc.8aa385c → 8.5.1-rc.213acde

package/.github/workflows/check-for-changeset.yml

@@ -16,7 +16,7 @@ jobs:
     name: Check for changeset
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - name: 'Check for changeset'
         uses: brettcannon/check-for-changed-files@v1
         with:

package/.github/workflows/ci.yml

@@ -9,7 +9,7 @@ jobs:
   format:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - name: Use Node.js
         uses: actions/setup-node@v4
         with:
@@ -21,7 +21,7 @@ jobs:
   test:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - name: Use Node.js
         uses: actions/setup-node@v4
         with:
@@ -33,7 +33,7 @@ jobs:
   lint:
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v5
+      - uses: actions/checkout@v6
       - name: Use Node.js
         uses: actions/setup-node@v4
         with:

package/.github/workflows/release.yml

@@ -20,7 +20,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
         with:
           # This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
           fetch-depth: 0
@@ -31,7 +31,7 @@ jobs:
         with:
           app-id: ${{ vars.PRIMER_APP_ID_SHARED }}
           private-key: ${{ secrets.PRIMER_APP_PRIVATE_KEY_SHARED }}
-          
+
       - name: Set up Node.js
         uses: actions/setup-node@v6
         with:
@@ -56,7 +56,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
         with:
           # This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
           fetch-depth: 0
@@ -106,7 +106,7 @@ jobs:
     runs-on: ubuntu-latest
     steps:
       - name: Checkout repository
-        uses: actions/checkout@v5
+        uses: actions/checkout@v6
         with:
           # This makes Actions fetch all Git history so that Changesets can generate changelogs with the correct commits
           fetch-depth: 0

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # eslint-plugin-primer-react
 
+## 8.5.1
+
+### Patch Changes
+
+- [#461](https://github.com/primer/eslint-plugin-primer-react/pull/461) [`75ae0a5`](https://github.com/primer/eslint-plugin-primer-react/commit/75ae0a5cb1d4587b5481c8a459033206aae8e5c3) Thanks [@joshfarrant](https://github.com/joshfarrant)! - Export `enforce-button-for-link-with-no-href` rule, which flags `Link` components which don't have a `href`.
+
 ## 8.5.0
 
 ### Minor Changes
@@ -8,6 +14,8 @@
 
 ### Patch Changes
 
+- [#435](https://github.com/primer/eslint-plugin-primer-react/pull/435) [`aa12209`](https://github.com/primer/eslint-plugin-primer-react/commit/aa12209a5ede77f01217ff044192c2b4b15ae2ab) Thanks [@TylerJDev](https://github.com/TylerJDev)! - Adds `width` and `height` to `no-system-props` for `ConfirmationDialog`
+
 - [#454](https://github.com/primer/eslint-plugin-primer-react/pull/454) [`917f344`](https://github.com/primer/eslint-plugin-primer-react/commit/917f344f61beeb8bd5817e89456a135769319003) Thanks [@francinelucca](https://github.com/francinelucca)! - no-system-props: allow 'overflow' prop in Breadcrumbs
 
 ## 8.4.0

package/README.md

@@ -31,13 +31,26 @@ ESLint rules for Primer React
 
 ## Rules
 
-- [direct-slot-children](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/direct-slot-children.md)
-- [no-system-props](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/no-system-props.md)
-- [new-css-color-vars](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/new-css-color-vars.md)
-- [no-deprecated-props](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/no-deprecated-props.md)
-- [a11y-tooltip-interactive-trigger](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/a11y-tooltip-interactive-trigger.md)
 - [a11y-explicit-heading](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/a11y-explicit-heading.md)
 - [a11y-link-in-text-block](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/a11y-link-in-text-block.md)
+- [a11y-no-duplicate-form-labels](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/a11y-no-duplicate-form-labels.md)
+- [a11y-no-title-usage](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/a11y-no-title-usage.md)
 - [a11y-remove-disable-tooltip](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/a11y-remove-disable-tooltip.md)
+- [a11y-tooltip-interactive-trigger](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/a11y-tooltip-interactive-trigger.md)
 - [a11y-use-accessible-tooltip](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/a11y-use-accessible-tooltip.md)
+- [direct-slot-children](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/direct-slot-children.md)
+- [enforce-button-for-link-with-no-href](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/enforce-button-for-link-with-no-href.md)
+- [enforce-css-module-default-import](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/enforce-css-module-default-import.md)
+- [enforce-css-module-identifier-casing](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/enforce-css-module-identifier-casing.md)
+- [new-color-css-vars](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/new-color-css-vars.md)
+- [no-deprecated-entrypoints](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/no-deprecated-entrypoints.md)
 - [no-deprecated-experimental-components](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/no-deprecated-experimental-components.md)
+- [no-deprecated-props](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/no-deprecated-props.md)
+- [no-system-props](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/no-system-props.md)
+- [no-unnecessary-components](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/no-unnecessary-components.md)
+- [no-use-responsive-value](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/no-use-responsive-value.md)
+- [no-wildcard-imports](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/no-wildcard-imports.md)
+- [prefer-action-list-item-onselect](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/prefer-action-list-item-onselect.md)
+- [spread-props-first](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/spread-props-first.md)
+- [use-deprecated-from-deprecated](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/use-deprecated-from-deprecated.md)
+- [use-styled-react-import](https://github.com/primer/eslint-plugin-primer-react/blob/main/docs/rules/use-styled-react-import.md)

package/docs/rules/enforce-button-for-link-with-no-href.md

@@ -0,0 +1,41 @@
+# Enforce Button for Link with No href (enforce-button-for-link-with-no-href)
+
+Primer's `Link` component enables users to navigate between pages. Rendering it without an `href` makes the element behave like a button without the correct semantics, which negatively impacts accessibility. Use the `Button` component to trigger an action, or ensure the `Link` has a valid `href`.
+
+## Rule details
+
+This rule reports any `Link` from `@primer/react` that does not include an `href` prop.
+
+👎 Examples of **incorrect** code for this rule:
+
+```jsx
+/* eslint primer-react/enforce-button-for-link-with-no-href: "error" */
+import {Link} from '@primer/react'
+;<Link onClick={handleClick}>Save changes</Link>
+```
+
+```jsx
+/* eslint primer-react/enforce-button-for-link-with-no-href: "error" */
+import {Link} from '@primer/react'
+;<Link className="text-right">Learn more</Link>
+```
+
+👍 Examples of **correct** code for this rule:
+
+```jsx
+/* eslint primer-react/enforce-button-for-link-with-no-href: "error" */
+import {Link} from '@primer/react'
+;<Link href="https://primer.style/react">Read the docs</Link>
+```
+
+```jsx
+/* eslint primer-react/enforce-button-for-link-with-no-href: "error" */
+import {Button, Link} from '@primer/react'
+
+<Button onClick={handleClick}>Save changes</Button>
+<Link href={issueUrl}>View issue</Link>
+```
+
+## Options
+
+This rule has no options.

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-primer-react",
-  "version": "8.5.0-rc.8aa385c",
+  "version": "8.5.1-rc.213acde",
   "description": "ESLint rules for Primer React",
   "main": "src/index.js",
   "engines": {

package/src/index.js

@@ -1,27 +1,28 @@
 module.exports = {
   rules: {
-    'direct-slot-children': require('./rules/direct-slot-children'),
-    'no-deprecated-entrypoints': require('./rules/no-deprecated-entrypoints'),
-    'no-system-props': require('./rules/no-system-props'),
-    'no-deprecated-experimental-components': require('./rules/no-deprecated-experimental-components'),
-    'a11y-tooltip-interactive-trigger': require('./rules/a11y-tooltip-interactive-trigger'),
-    'new-color-css-vars': require('./rules/new-color-css-vars'),
     'a11y-explicit-heading': require('./rules/a11y-explicit-heading'),
-    'no-deprecated-props': require('./rules/no-deprecated-props'),
     'a11y-link-in-text-block': require('./rules/a11y-link-in-text-block'),
+    'a11y-no-duplicate-form-labels': require('./rules/a11y-no-duplicate-form-labels'),
+    'a11y-no-title-usage': require('./rules/a11y-no-title-usage'),
     'a11y-remove-disable-tooltip': require('./rules/a11y-remove-disable-tooltip'),
+    'a11y-tooltip-interactive-trigger': require('./rules/a11y-tooltip-interactive-trigger'),
     'a11y-use-accessible-tooltip': require('./rules/a11y-use-accessible-tooltip'),
-    'a11y-no-title-usage': require('./rules/a11y-no-title-usage'),
-    'a11y-no-duplicate-form-labels': require('./rules/a11y-no-duplicate-form-labels'),
-    'use-deprecated-from-deprecated': require('./rules/use-deprecated-from-deprecated'),
-    'no-wildcard-imports': require('./rules/no-wildcard-imports'),
+    'direct-slot-children': require('./rules/direct-slot-children'),
+    'enforce-button-for-link-with-no-href': require('./rules/enforce-button-for-link-with-no-href'),
+    'enforce-css-module-default-import': require('./rules/enforce-css-module-default-import'),
+    'enforce-css-module-identifier-casing': require('./rules/enforce-css-module-identifier-casing'),
+    'new-color-css-vars': require('./rules/new-color-css-vars'),
+    'no-deprecated-entrypoints': require('./rules/no-deprecated-entrypoints'),
+    'no-deprecated-experimental-components': require('./rules/no-deprecated-experimental-components'),
+    'no-deprecated-props': require('./rules/no-deprecated-props'),
+    'no-system-props': require('./rules/no-system-props'),
     'no-unnecessary-components': require('./rules/no-unnecessary-components'),
+    'no-use-responsive-value': require('./rules/no-use-responsive-value'),
+    'no-wildcard-imports': require('./rules/no-wildcard-imports'),
     'prefer-action-list-item-onselect': require('./rules/prefer-action-list-item-onselect'),
-    'enforce-css-module-identifier-casing': require('./rules/enforce-css-module-identifier-casing'),
-    'enforce-css-module-default-import': require('./rules/enforce-css-module-default-import'),
-    'use-styled-react-import': require('./rules/use-styled-react-import'),
     'spread-props-first': require('./rules/spread-props-first'),
-    'no-use-responsive-value': require('./rules/no-use-responsive-value'),
+    'use-deprecated-from-deprecated': require('./rules/use-deprecated-from-deprecated'),
+    'use-styled-react-import': require('./rules/use-styled-react-import'),
   },
   configs: {
     recommended: require('./configs/recommended'),

package/src/rules/__tests__/{enforce-button-for-link-with-nohref.test.js → enforce-button-for-link-with-no-href.test.js}

@@ -1,4 +1,4 @@
-const rule = require('../enforce-button-for-link-with-nohref')
+const rule = require('../enforce-button-for-link-with-no-href')
 const {RuleTester} = require('eslint')
 
 const ruleTester = new RuleTester({
@@ -13,7 +13,7 @@ const ruleTester = new RuleTester({
   },
 })
 
-ruleTester.run('enforce-button-for-link-with-nohref', rule, {
+ruleTester.run('enforce-button-for-link-with-no-href', rule, {
   valid: [
     // Link with href attribute
     `import {Link} from '@primer/react';

package/src/rules/no-system-props.js

@@ -24,6 +24,7 @@ const excludedComponentProps = new Map([
   ['Breadcrumbs', new Set(['overflow'])],
   ['Button', new Set(['alignContent'])],
   ['CircleOcticon', new Set(['size'])],
+  ['ConfirmationDialog', new Set(['width', 'height'])],
   ['Dialog', new Set(['width', 'height', 'position'])],
   ['IssueLabelToken', new Set(['size'])],
   ['Overlay', new Set(['width', 'height', 'maxHeight', 'position', 'top', 'right', 'bottom', 'left'])],