eslint-plugin-primer-react 7.0.0-rc.449d4ba → 7.0.0-rc.515dd2e

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (5) hide show
  1. package/CHANGELOG.md +0 -4
  2. package/package-lock.json +55 -82
  3. package/package.json +2 -2
  4. package/src/rules/__tests__/a11y-tooltip-interactive-trigger.test.js +0 -16
  5. package/src/rules/a11y-tooltip-interactive-trigger.js +3 -9
package/CHANGELOG.md CHANGED
@@ -12,10 +12,6 @@
12
12
 
13
13
  - [#258](https://github.com/primer/eslint-plugin-primer-react/pull/258) [`83f29f3`](https://github.com/primer/eslint-plugin-primer-react/commit/83f29f339999b9c21d95167bcc2680c1797cbab6) Thanks [@keithamus](https://github.com/keithamus)! - Add enforce-css-module-identifier-casing rule
14
14
 
15
- ### Patch Changes
16
-
17
- - [#314](https://github.com/primer/eslint-plugin-primer-react/pull/314) [`63ef9fd`](https://github.com/primer/eslint-plugin-primer-react/commit/63ef9fdf02a9c4b80528644a96fd81e366bce187) Thanks [@khiga8](https://github.com/khiga8)! - fix: Link to should be allowed to have tooltip
18
-
19
15
  ## 6.1.6
20
16
 
21
17
  ### Patch Changes
package/package-lock.json CHANGED
@@ -10,7 +10,7 @@
10
10
  "license": "MIT",
11
11
  "dependencies": {
12
12
  "@styled-system/props": "^5.1.5",
13
- "@typescript-eslint/utils": "8.24.0",
13
+ "@typescript-eslint/utils": "8.18.1",
14
14
  "eslint-plugin-github": "^5.0.1",
15
15
  "eslint-plugin-jsx-a11y": "^6.7.1",
16
16
  "eslint-traverse": "^1.0.0",
@@ -2349,15 +2349,14 @@
2349
2349
  }
2350
2350
  },
2351
2351
  "node_modules/@typescript-eslint/utils": {
2352
- "version": "8.24.0",
2353
- "resolved": "https://registry.npmjs.org/@typescript-eslint/utils/-/utils-8.24.0.tgz",
2354
- "integrity": "sha512-07rLuUBElvvEb1ICnafYWr4hk8/U7X9RDCOqd9JcAMtjh/9oRmcfN4yGzbPVirgMR0+HLVHehmu19CWeh7fsmQ==",
2355
- "license": "MIT",
2352
+ "version": "8.18.1",
2353
+ "resolved": "https://registry.npmjs.org/@typescript-eslint/utils/-/utils-8.18.1.tgz",
2354
+ "integrity": "sha512-8vikiIj2ebrC4WRdcAdDcmnu9Q/MXXwg+STf40BVfT8exDqBCUPdypvzcUPxEqRGKg9ALagZ0UWcYCtn+4W2iQ==",
2356
2355
  "dependencies": {
2357
2356
  "@eslint-community/eslint-utils": "^4.4.0",
2358
- "@typescript-eslint/scope-manager": "8.24.0",
2359
- "@typescript-eslint/types": "8.24.0",
2360
- "@typescript-eslint/typescript-estree": "8.24.0"
2357
+ "@typescript-eslint/scope-manager": "8.18.1",
2358
+ "@typescript-eslint/types": "8.18.1",
2359
+ "@typescript-eslint/typescript-estree": "8.18.1"
2361
2360
  },
2362
2361
  "engines": {
2363
2362
  "node": "^18.18.0 || ^20.9.0 || >=21.1.0"
@@ -2372,13 +2371,12 @@
2372
2371
  }
2373
2372
  },
2374
2373
  "node_modules/@typescript-eslint/utils/node_modules/@typescript-eslint/scope-manager": {
2375
- "version": "8.24.0",
2376
- "resolved": "https://registry.npmjs.org/@typescript-eslint/scope-manager/-/scope-manager-8.24.0.tgz",
2377
- "integrity": "sha512-HZIX0UByphEtdVBKaQBgTDdn9z16l4aTUz8e8zPQnyxwHBtf5vtl1L+OhH+m1FGV9DrRmoDuYKqzVrvWDcDozw==",
2378
- "license": "MIT",
2374
+ "version": "8.18.1",
2375
+ "resolved": "https://registry.npmjs.org/@typescript-eslint/scope-manager/-/scope-manager-8.18.1.tgz",
2376
+ "integrity": "sha512-HxfHo2b090M5s2+/9Z3gkBhI6xBH8OJCFjH9MhQ+nnoZqxU3wNxkLT+VWXWSFWc3UF3Z+CfPAyqdCTdoXtDPCQ==",
2379
2377
  "dependencies": {
2380
- "@typescript-eslint/types": "8.24.0",
2381
- "@typescript-eslint/visitor-keys": "8.24.0"
2378
+ "@typescript-eslint/types": "8.18.1",
2379
+ "@typescript-eslint/visitor-keys": "8.18.1"
2382
2380
  },
2383
2381
  "engines": {
2384
2382
  "node": "^18.18.0 || ^20.9.0 || >=21.1.0"
@@ -2389,10 +2387,9 @@
2389
2387
  }
2390
2388
  },
2391
2389
  "node_modules/@typescript-eslint/utils/node_modules/@typescript-eslint/types": {
2392
- "version": "8.24.0",
2393
- "resolved": "https://registry.npmjs.org/@typescript-eslint/types/-/types-8.24.0.tgz",
2394
- "integrity": "sha512-VacJCBTyje7HGAw7xp11q439A+zeGG0p0/p2zsZwpnMzjPB5WteaWqt4g2iysgGFafrqvyLWqq6ZPZAOCoefCw==",
2395
- "license": "MIT",
2390
+ "version": "8.18.1",
2391
+ "resolved": "https://registry.npmjs.org/@typescript-eslint/types/-/types-8.18.1.tgz",
2392
+ "integrity": "sha512-7uoAUsCj66qdNQNpH2G8MyTFlgerum8ubf21s3TSM3XmKXuIn+H2Sifh/ES2nPOPiYSRJWAk0fDkW0APBWcpfw==",
2396
2393
  "engines": {
2397
2394
  "node": "^18.18.0 || ^20.9.0 || >=21.1.0"
2398
2395
  },
@@ -2402,19 +2399,18 @@
2402
2399
  }
2403
2400
  },
2404
2401
  "node_modules/@typescript-eslint/utils/node_modules/@typescript-eslint/typescript-estree": {
2405
- "version": "8.24.0",
2406
- "resolved": "https://registry.npmjs.org/@typescript-eslint/typescript-estree/-/typescript-estree-8.24.0.tgz",
2407
- "integrity": "sha512-ITjYcP0+8kbsvT9bysygfIfb+hBj6koDsu37JZG7xrCiy3fPJyNmfVtaGsgTUSEuTzcvME5YI5uyL5LD1EV5ZQ==",
2408
- "license": "MIT",
2402
+ "version": "8.18.1",
2403
+ "resolved": "https://registry.npmjs.org/@typescript-eslint/typescript-estree/-/typescript-estree-8.18.1.tgz",
2404
+ "integrity": "sha512-z8U21WI5txzl2XYOW7i9hJhxoKKNG1kcU4RzyNvKrdZDmbjkmLBo8bgeiOJmA06kizLI76/CCBAAGlTlEeUfyg==",
2409
2405
  "dependencies": {
2410
- "@typescript-eslint/types": "8.24.0",
2411
- "@typescript-eslint/visitor-keys": "8.24.0",
2406
+ "@typescript-eslint/types": "8.18.1",
2407
+ "@typescript-eslint/visitor-keys": "8.18.1",
2412
2408
  "debug": "^4.3.4",
2413
2409
  "fast-glob": "^3.3.2",
2414
2410
  "is-glob": "^4.0.3",
2415
2411
  "minimatch": "^9.0.4",
2416
2412
  "semver": "^7.6.0",
2417
- "ts-api-utils": "^2.0.1"
2413
+ "ts-api-utils": "^1.3.0"
2418
2414
  },
2419
2415
  "engines": {
2420
2416
  "node": "^18.18.0 || ^20.9.0 || >=21.1.0"
@@ -2428,12 +2424,11 @@
2428
2424
  }
2429
2425
  },
2430
2426
  "node_modules/@typescript-eslint/utils/node_modules/@typescript-eslint/visitor-keys": {
2431
- "version": "8.24.0",
2432
- "resolved": "https://registry.npmjs.org/@typescript-eslint/visitor-keys/-/visitor-keys-8.24.0.tgz",
2433
- "integrity": "sha512-kArLq83QxGLbuHrTMoOEWO+l2MwsNS2TGISEdx8xgqpkbytB07XmlQyQdNDrCc1ecSqx0cnmhGvpX+VBwqqSkg==",
2434
- "license": "MIT",
2427
+ "version": "8.18.1",
2428
+ "resolved": "https://registry.npmjs.org/@typescript-eslint/visitor-keys/-/visitor-keys-8.18.1.tgz",
2429
+ "integrity": "sha512-Vj0WLm5/ZsD013YeUKn+K0y8p1M0jPpxOkKdbD1wB0ns53a5piVY02zjf072TblEweAbcYiFiPoSMF3kp+VhhQ==",
2435
2430
  "dependencies": {
2436
- "@typescript-eslint/types": "8.24.0",
2431
+ "@typescript-eslint/types": "8.18.1",
2437
2432
  "eslint-visitor-keys": "^4.2.0"
2438
2433
  },
2439
2434
  "engines": {
@@ -2448,7 +2443,6 @@
2448
2443
  "version": "2.0.1",
2449
2444
  "resolved": "https://registry.npmjs.org/brace-expansion/-/brace-expansion-2.0.1.tgz",
2450
2445
  "integrity": "sha512-XnAIvQ8eM+kC6aULx6wuQiwVsnzsi9d3WxzV3FpWTGA19F621kwdbsAcFKXgKUHZWsy+mY6iL1sHTxWEFCytDA==",
2451
- "license": "MIT",
2452
2446
  "dependencies": {
2453
2447
  "balanced-match": "^1.0.0"
2454
2448
  }
@@ -2457,7 +2451,6 @@
2457
2451
  "version": "4.2.0",
2458
2452
  "resolved": "https://registry.npmjs.org/eslint-visitor-keys/-/eslint-visitor-keys-4.2.0.tgz",
2459
2453
  "integrity": "sha512-UyLnSehNt62FFhSwjZlHmeokpRK59rcz29j+F1/aDgbkbRTk7wIc9XzdoasMUbRNKDM0qQt/+BJ4BrpFeABemw==",
2460
- "license": "Apache-2.0",
2461
2454
  "engines": {
2462
2455
  "node": "^18.18.0 || ^20.9.0 || >=21.1.0"
2463
2456
  },
@@ -2469,7 +2462,6 @@
2469
2462
  "version": "9.0.5",
2470
2463
  "resolved": "https://registry.npmjs.org/minimatch/-/minimatch-9.0.5.tgz",
2471
2464
  "integrity": "sha512-G6T0ZX48xgozx7587koeX9Ys2NYy6Gmv//P89sEte9V9whIapMNF4idKxnW2QtCcLiTWlb/wfCabAtAFWhhBow==",
2472
- "license": "ISC",
2473
2465
  "dependencies": {
2474
2466
  "brace-expansion": "^2.0.1"
2475
2467
  },
@@ -2481,10 +2473,9 @@
2481
2473
  }
2482
2474
  },
2483
2475
  "node_modules/@typescript-eslint/utils/node_modules/semver": {
2484
- "version": "7.7.1",
2485
- "resolved": "https://registry.npmjs.org/semver/-/semver-7.7.1.tgz",
2486
- "integrity": "sha512-hlq8tAfn0m/61p4BVRcPzIGr6LKiMwo4VM6dGi6pt4qcRkmNzTcWq6eCEjEh+qXjkMDvPlOFFSGwQjoEa6gyMA==",
2487
- "license": "ISC",
2476
+ "version": "7.6.3",
2477
+ "resolved": "https://registry.npmjs.org/semver/-/semver-7.6.3.tgz",
2478
+ "integrity": "sha512-oVekP1cKtI+CTDvHWYFUcMtsK/00wmAEfyqKfNdARm8u1wNVhSgaX7A8d4UuIlUI5e84iEwOhs7ZPYRmzU9U6A==",
2488
2479
  "bin": {
2489
2480
  "semver": "bin/semver.js"
2490
2481
  },
@@ -2492,18 +2483,6 @@
2492
2483
  "node": ">=10"
2493
2484
  }
2494
2485
  },
2495
- "node_modules/@typescript-eslint/utils/node_modules/ts-api-utils": {
2496
- "version": "2.0.1",
2497
- "resolved": "https://registry.npmjs.org/ts-api-utils/-/ts-api-utils-2.0.1.tgz",
2498
- "integrity": "sha512-dnlgjFSVetynI8nzgJ+qF62efpglpWRk8isUEWZGWlJYySCTD6aKvbUDu+zbPeDakk3bg5H4XpitHukgfL1m9w==",
2499
- "license": "MIT",
2500
- "engines": {
2501
- "node": ">=18.12"
2502
- },
2503
- "peerDependencies": {
2504
- "typescript": ">=4.8.4"
2505
- }
2506
- },
2507
2486
  "node_modules/@typescript-eslint/visitor-keys": {
2508
2487
  "version": "7.1.1",
2509
2488
  "resolved": "https://registry.npmjs.org/@typescript-eslint/visitor-keys/-/visitor-keys-7.1.1.tgz",
@@ -10300,51 +10279,51 @@
10300
10279
  }
10301
10280
  },
10302
10281
  "@typescript-eslint/utils": {
10303
- "version": "8.24.0",
10304
- "resolved": "https://registry.npmjs.org/@typescript-eslint/utils/-/utils-8.24.0.tgz",
10305
- "integrity": "sha512-07rLuUBElvvEb1ICnafYWr4hk8/U7X9RDCOqd9JcAMtjh/9oRmcfN4yGzbPVirgMR0+HLVHehmu19CWeh7fsmQ==",
10282
+ "version": "8.18.1",
10283
+ "resolved": "https://registry.npmjs.org/@typescript-eslint/utils/-/utils-8.18.1.tgz",
10284
+ "integrity": "sha512-8vikiIj2ebrC4WRdcAdDcmnu9Q/MXXwg+STf40BVfT8exDqBCUPdypvzcUPxEqRGKg9ALagZ0UWcYCtn+4W2iQ==",
10306
10285
  "requires": {
10307
10286
  "@eslint-community/eslint-utils": "^4.4.0",
10308
- "@typescript-eslint/scope-manager": "8.24.0",
10309
- "@typescript-eslint/types": "8.24.0",
10310
- "@typescript-eslint/typescript-estree": "8.24.0"
10287
+ "@typescript-eslint/scope-manager": "8.18.1",
10288
+ "@typescript-eslint/types": "8.18.1",
10289
+ "@typescript-eslint/typescript-estree": "8.18.1"
10311
10290
  },
10312
10291
  "dependencies": {
10313
10292
  "@typescript-eslint/scope-manager": {
10314
- "version": "8.24.0",
10315
- "resolved": "https://registry.npmjs.org/@typescript-eslint/scope-manager/-/scope-manager-8.24.0.tgz",
10316
- "integrity": "sha512-HZIX0UByphEtdVBKaQBgTDdn9z16l4aTUz8e8zPQnyxwHBtf5vtl1L+OhH+m1FGV9DrRmoDuYKqzVrvWDcDozw==",
10293
+ "version": "8.18.1",
10294
+ "resolved": "https://registry.npmjs.org/@typescript-eslint/scope-manager/-/scope-manager-8.18.1.tgz",
10295
+ "integrity": "sha512-HxfHo2b090M5s2+/9Z3gkBhI6xBH8OJCFjH9MhQ+nnoZqxU3wNxkLT+VWXWSFWc3UF3Z+CfPAyqdCTdoXtDPCQ==",
10317
10296
  "requires": {
10318
- "@typescript-eslint/types": "8.24.0",
10319
- "@typescript-eslint/visitor-keys": "8.24.0"
10297
+ "@typescript-eslint/types": "8.18.1",
10298
+ "@typescript-eslint/visitor-keys": "8.18.1"
10320
10299
  }
10321
10300
  },
10322
10301
  "@typescript-eslint/types": {
10323
- "version": "8.24.0",
10324
- "resolved": "https://registry.npmjs.org/@typescript-eslint/types/-/types-8.24.0.tgz",
10325
- "integrity": "sha512-VacJCBTyje7HGAw7xp11q439A+zeGG0p0/p2zsZwpnMzjPB5WteaWqt4g2iysgGFafrqvyLWqq6ZPZAOCoefCw=="
10302
+ "version": "8.18.1",
10303
+ "resolved": "https://registry.npmjs.org/@typescript-eslint/types/-/types-8.18.1.tgz",
10304
+ "integrity": "sha512-7uoAUsCj66qdNQNpH2G8MyTFlgerum8ubf21s3TSM3XmKXuIn+H2Sifh/ES2nPOPiYSRJWAk0fDkW0APBWcpfw=="
10326
10305
  },
10327
10306
  "@typescript-eslint/typescript-estree": {
10328
- "version": "8.24.0",
10329
- "resolved": "https://registry.npmjs.org/@typescript-eslint/typescript-estree/-/typescript-estree-8.24.0.tgz",
10330
- "integrity": "sha512-ITjYcP0+8kbsvT9bysygfIfb+hBj6koDsu37JZG7xrCiy3fPJyNmfVtaGsgTUSEuTzcvME5YI5uyL5LD1EV5ZQ==",
10307
+ "version": "8.18.1",
10308
+ "resolved": "https://registry.npmjs.org/@typescript-eslint/typescript-estree/-/typescript-estree-8.18.1.tgz",
10309
+ "integrity": "sha512-z8U21WI5txzl2XYOW7i9hJhxoKKNG1kcU4RzyNvKrdZDmbjkmLBo8bgeiOJmA06kizLI76/CCBAAGlTlEeUfyg==",
10331
10310
  "requires": {
10332
- "@typescript-eslint/types": "8.24.0",
10333
- "@typescript-eslint/visitor-keys": "8.24.0",
10311
+ "@typescript-eslint/types": "8.18.1",
10312
+ "@typescript-eslint/visitor-keys": "8.18.1",
10334
10313
  "debug": "^4.3.4",
10335
10314
  "fast-glob": "^3.3.2",
10336
10315
  "is-glob": "^4.0.3",
10337
10316
  "minimatch": "^9.0.4",
10338
10317
  "semver": "^7.6.0",
10339
- "ts-api-utils": "^2.0.1"
10318
+ "ts-api-utils": "^1.3.0"
10340
10319
  }
10341
10320
  },
10342
10321
  "@typescript-eslint/visitor-keys": {
10343
- "version": "8.24.0",
10344
- "resolved": "https://registry.npmjs.org/@typescript-eslint/visitor-keys/-/visitor-keys-8.24.0.tgz",
10345
- "integrity": "sha512-kArLq83QxGLbuHrTMoOEWO+l2MwsNS2TGISEdx8xgqpkbytB07XmlQyQdNDrCc1ecSqx0cnmhGvpX+VBwqqSkg==",
10322
+ "version": "8.18.1",
10323
+ "resolved": "https://registry.npmjs.org/@typescript-eslint/visitor-keys/-/visitor-keys-8.18.1.tgz",
10324
+ "integrity": "sha512-Vj0WLm5/ZsD013YeUKn+K0y8p1M0jPpxOkKdbD1wB0ns53a5piVY02zjf072TblEweAbcYiFiPoSMF3kp+VhhQ==",
10346
10325
  "requires": {
10347
- "@typescript-eslint/types": "8.24.0",
10326
+ "@typescript-eslint/types": "8.18.1",
10348
10327
  "eslint-visitor-keys": "^4.2.0"
10349
10328
  }
10350
10329
  },
@@ -10370,15 +10349,9 @@
10370
10349
  }
10371
10350
  },
10372
10351
  "semver": {
10373
- "version": "7.7.1",
10374
- "resolved": "https://registry.npmjs.org/semver/-/semver-7.7.1.tgz",
10375
- "integrity": "sha512-hlq8tAfn0m/61p4BVRcPzIGr6LKiMwo4VM6dGi6pt4qcRkmNzTcWq6eCEjEh+qXjkMDvPlOFFSGwQjoEa6gyMA=="
10376
- },
10377
- "ts-api-utils": {
10378
- "version": "2.0.1",
10379
- "resolved": "https://registry.npmjs.org/ts-api-utils/-/ts-api-utils-2.0.1.tgz",
10380
- "integrity": "sha512-dnlgjFSVetynI8nzgJ+qF62efpglpWRk8isUEWZGWlJYySCTD6aKvbUDu+zbPeDakk3bg5H4XpitHukgfL1m9w==",
10381
- "requires": {}
10352
+ "version": "7.6.3",
10353
+ "resolved": "https://registry.npmjs.org/semver/-/semver-7.6.3.tgz",
10354
+ "integrity": "sha512-oVekP1cKtI+CTDvHWYFUcMtsK/00wmAEfyqKfNdARm8u1wNVhSgaX7A8d4UuIlUI5e84iEwOhs7ZPYRmzU9U6A=="
10382
10355
  }
10383
10356
  }
10384
10357
  },
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "eslint-plugin-primer-react",
3
- "version": "7.0.0-rc.449d4ba",
3
+ "version": "7.0.0-rc.515dd2e",
4
4
  "description": "ESLint rules for Primer React",
5
5
  "main": "src/index.js",
6
6
  "scripts": {
@@ -34,7 +34,7 @@
34
34
  "eslint-traverse": "^1.0.0",
35
35
  "lodash": "^4.17.21",
36
36
  "styled-system": "^5.1.5",
37
- "@typescript-eslint/utils": "8.24.0",
37
+ "@typescript-eslint/utils": "8.18.1",
38
38
  "typescript": "^5.5.3"
39
39
  },
40
40
  "devDependencies": {
package/src/rules/__tests__/a11y-tooltip-interactive-trigger.test.js CHANGED
@@ -67,22 +67,6 @@ ruleTester.run('non-interactive-tooltip-trigger', rule, {
67
67
  </Link>
68
68
  </Tooltip>
69
69
  `,
70
- `
71
- import {Tooltip, Link} from '@primer/react';
72
- <Tooltip aria-label="product" direction="e">
73
- <Link to={productLink}>
74
- Product
75
- </Link>
76
- </Tooltip>
77
- `,
78
- `
79
- import {Tooltip, Link} from '@primer/react';
80
- <Tooltip aria-label="product" direction="e">
81
- <Link to="https://github.com">
82
- Product
83
- </Link>
84
- </Tooltip>
85
- `,
86
70
  ],
87
71
  invalid: [
88
72
  {
package/src/rules/a11y-tooltip-interactive-trigger.js CHANGED
@@ -23,7 +23,7 @@ const isAnchorTag = el => {
23
23
  }
24
24
 
25
25
  const isJSXValue = attributes => {
26
- const node = attributes.find(attribute => propName(attribute) === 'href' || propName(attribute))
26
+ const node = attributes.find(attribute => propName(attribute) === 'href')
27
27
  const isJSXExpression = node.value.type === 'JSXExpressionContainer' && node && typeof getPropValue(node) === 'string'
28
28
 
29
29
  return isJSXExpression
@@ -31,14 +31,8 @@ const isJSXValue = attributes => {
31
31
 
32
32
  const isInteractiveAnchor = child => {
33
33
  const hasHref = getJSXOpeningElementAttribute(child.openingElement, 'href')
34
- const hasTo = getJSXOpeningElementAttribute(child.openingElement, 'to')
35
-
36
- if (!hasHref && !hasTo) return false
37
-
38
- const href = hasHref
39
- ? getJSXOpeningElementAttribute(child.openingElement, 'href').value.value
40
- : getJSXOpeningElementAttribute(child.openingElement, 'to').value.value
41
-
34
+ if (!hasHref) return false
35
+ const href = getJSXOpeningElementAttribute(child.openingElement, 'href').value.value
42
36
  const hasJSXValue = isJSXValue(child.openingElement.attributes)
43
37
  const isAnchorInteractive = (typeof href === 'string' && href !== '') || hasJSXValue
44
38