eslint-plugin-prefer-let 3.0.1 → 4.0.1

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # eslint-plugin-prefer-let
 
+## \[4.0.1]
+
+- [`ee2ef1b`](https://github.com/thefrontside/javascript/commit/ee2ef1be18087421c2870eb2845b3235e1e10d58) allow var in TypeScript ambient declarations
+- [`02b89a4`](https://github.com/thefrontside/javascript/commit/02b89a41ecc9711cea3ef6131f9a2bde842ec4fe) Support the `using` declaration from explicit resource management
+
+## \[4.0.0]
+
+- [`e597fa9`](https://github.com/thefrontside/javascript/commit/e597fa93ce94f81d08d259895003a489ccc0021e) Support ESLint v9
+
 ## 3.0.1
 
 ### Patch Changes

package/README.md

@@ -8,7 +8,7 @@ long-standing conventions set forth by both formal symbolic logic and
 the practice of functional programming.
 
 Usage of the `const` keyword to bind an _intermediate_ value of a
-computation places emphasis on the compiler and and its role in
+computation places emphasis on the compiler and its role in
 ensuring that a _reference_ never changes. By contrast using `let` in
 the same situation reads, in plain English, the programmer's intent to
 declare a name value binding.

package/lib/rules/prefer-let.js

@@ -28,22 +28,40 @@ module.exports = {
     // Helpers
     //----------------------------------------------------------------------
 
+    function getScope(node) {
+      let sourceCode = context.sourceCode ?? context.getSourceCode();
+      return sourceCode.getScope
+        ? sourceCode.getScope(node)
+        : context.getScope();
+    }
+
     function isGlobalScope(node) {
-      return context.getScope().type === 'global';
+      return getScope(node).type === 'global';
     }
 
     function isModuleScope(node) {
-      return context.getScope().type === 'module';
+      return getScope(node).type === 'module';
     }
 
     function isProgramScope(node) {
-      return context.getScope().block.type === 'Program';
+      return getScope(node).block.type === 'Program';
     }
 
     function isTopLevelScope(node) {
       return isGlobalScope(node) || isModuleScope(node) || isProgramScope(node);
     }
 
+    function isInAmbientContext(node) {
+      let current = node.parent;
+      while (current) {
+        if (current.type === 'TSModuleDeclaration' && current.declare === true) {
+          return true;
+        }
+        current = current.parent;
+      }
+      return false;
+    }
+
     //----------------------------------------------------------------------
     // Public
     //----------------------------------------------------------------------
@@ -51,11 +69,14 @@ module.exports = {
     return {
       VariableDeclaration(node) {
         if (node.kind === 'var') {
+          if (isInAmbientContext(node)) {
+            return;
+          }
           context.report({
             message: 'prefer `let` over `var` to declare value bindings',
             node
           });
-        } else if (node.kind !== 'let' && !isTopLevelScope(node)) {
+        } else if (node.kind === 'const' && !isTopLevelScope(node)) {
           let constToken = sourceCode.getFirstToken(node);
 
           context.report({

package/package.json

@@ -1,7 +1,12 @@
 {
   "name": "eslint-plugin-prefer-let",
-  "version": "3.0.1",
+  "version": "4.0.1",
   "description": "Rule to prefer using `let` to bind names to values",
+  "repository": {
+    "type": "git",
+    "url": "git+https://github.com/thefrontside/javascript.git",
+    "directory": "packages/eslint-plugin-prefer-let"
+  },
   "keywords": [
     "eslint",
     "eslintplugin",
@@ -15,12 +20,13 @@
     "requireindex": "~1.2.0"
   },
   "devDependencies": {
-    "eslint": "^8.0.1",
+    "@typescript-eslint/parser": "^8.0.0",
+    "eslint": "^9.3.0",
+    "globals": "^15.3.0",
     "mocha": "^9.1.3"
   },
   "engines": {
     "node": ">=0.10.0"
   },
-  "license": "ISC",
-  "repository": "thefrontside/javascript"
+  "license": "ISC"
 }