eslint-plugin-playwright 2.2.1 → 2.3.0

package/README.md

@@ -142,6 +142,7 @@ CLI option\
 | [no-slowed-test](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-slowed-test.md)                           | Disallow usage of the `.slow` annotation                           |     |     | 💡  |
 | [no-standalone-expect](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-standalone-expect.md)               | Disallow using expect outside of `test` blocks                     | ✅  |     |     |
 | [no-unsafe-references](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-unsafe-references.md)               | Prevent unsafe variable references in `page.evaluate()`            | ✅  | 🔧  |     |
+| [no-unused-locators](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-unused-locators.md)                   | Disallow usage of page locators that are not used                  | ✅  |     |     |
 | [no-useless-await](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-useless-await.md)                       | Disallow unnecessary `await`s for Playwright methods               | ✅  | 🔧  |     |
 | [no-useless-not](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-useless-not.md)                           | Disallow usage of `not` matchers when a specific matcher exists    | ✅  | 🔧  |     |
 | [no-wait-for-navigation](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-wait-for-navigation.md)           | Disallow usage of `page.waitForNavigation()`                       | ✅  |     | 💡  |

package/dist/index.cjs

@@ -21,28 +21,6 @@ var __toESM = (mod, isNodeMode, target) => (target = mod != null ? __create(__ge
   isNodeMode || !mod || !mod.__esModule ? __defProp(target, "default", { value: mod, enumerable: true }) : target,
   mod
 ));
-var __accessCheck = (obj, member, msg) => {
-  if (!member.has(obj))
-    throw TypeError("Cannot " + msg);
-};
-var __privateGet = (obj, member, getter) => {
-  __accessCheck(obj, member, "read from private field");
-  return getter ? getter.call(obj) : member.get(obj);
-};
-var __privateAdd = (obj, member, value) => {
-  if (member.has(obj))
-    throw TypeError("Cannot add the same private member more than once");
-  member instanceof WeakSet ? member.add(obj) : member.set(obj, value);
-};
-var __privateSet = (obj, member, value, setter) => {
-  __accessCheck(obj, member, "write to private field");
-  setter ? setter.call(obj, value) : member.set(obj, value);
-  return value;
-};
-var __privateMethod = (obj, member, method) => {
-  __accessCheck(obj, member, "access private method");
-  return method;
-};
 
 // src/index.ts
 var import_globals = __toESM(require("globals"), 1);
@@ -106,43 +84,38 @@ var VALID_CHAINS = /* @__PURE__ */ new Set([
 ]);
 var joinChains = (a, b) => a && b ? [...a, ...b] : null;
 var isSupportedAccessor = (node, value) => isIdentifier(node, value) || isStringNode(node, value);
-var _nodes, _leaves, _buildChain, buildChain_fn;
 var Chain = class {
+  #nodes = null;
+  #leaves = /* @__PURE__ */ new WeakSet();
   constructor(node) {
-    __privateAdd(this, _buildChain);
-    __privateAdd(this, _nodes, null);
-    __privateAdd(this, _leaves, /* @__PURE__ */ new WeakSet());
-    __privateSet(this, _nodes, __privateMethod(this, _buildChain, buildChain_fn).call(this, node));
+    this.#nodes = this.#buildChain(node);
   }
   isLeaf(node) {
-    return __privateGet(this, _leaves).has(node);
+    return this.#leaves.has(node);
   }
   get nodes() {
-    return __privateGet(this, _nodes);
+    return this.#nodes;
   }
-};
-_nodes = new WeakMap();
-_leaves = new WeakMap();
-_buildChain = new WeakSet();
-buildChain_fn = function(node, insideCall = false) {
-  if (isSupportedAccessor(node)) {
-    if (insideCall) {
-      __privateGet(this, _leaves).add(node);
+  #buildChain(node, insideCall = false) {
+    if (isSupportedAccessor(node)) {
+      if (insideCall) {
+        this.#leaves.add(node);
+      }
+      return [node];
+    }
+    switch (node.type) {
+      case "TaggedTemplateExpression":
+        return this.#buildChain(node.tag);
+      case "MemberExpression":
+        return joinChains(
+          this.#buildChain(node.object),
+          this.#buildChain(node.property, insideCall)
+        );
+      case "CallExpression":
+        return this.#buildChain(node.callee, true);
+      default:
+        return null;
     }
-    return [node];
-  }
-  switch (node.type) {
-    case "TaggedTemplateExpression":
-      return __privateMethod(this, _buildChain, buildChain_fn).call(this, node.tag);
-    case "MemberExpression":
-      return joinChains(
-        __privateMethod(this, _buildChain, buildChain_fn).call(this, node.object),
-        __privateMethod(this, _buildChain, buildChain_fn).call(this, node.property, insideCall)
-      );
-    case "CallExpression":
-      return __privateMethod(this, _buildChain, buildChain_fn).call(this, node.callee, true);
-    default:
-      return null;
   }
 };
 var resolvePossibleAliasedGlobal = (context, global) => {
@@ -982,7 +955,7 @@ var no_duplicate_hooks_default = createRule({
         }
         const currentLayer = hookContexts[hookContexts.length - 1];
         const name = node.callee.type === "MemberExpression" ? getStringValue(node.callee.property) : "";
-        currentLayer[name] || (currentLayer[name] = 0);
+        currentLayer[name] ||= 0;
         currentLayer[name] += 1;
         if (currentLayer[name] > 1) {
           context.report({
@@ -1856,6 +1829,35 @@ var no_unsafe_references_default = createRule({
   }
 });
 
+// src/rules/no-unused-locators.ts
+var LOCATOR_REGEX = /locator|getBy(Role|Text|Label|Placeholder|AltText|Title|TestId)/;
+var no_unused_locators_default = createRule({
+  create(context) {
+    return {
+      CallExpression(node) {
+        if (!isPageMethod(node, LOCATOR_REGEX)) {
+          return;
+        }
+        if (node.parent.type === "ExpressionStatement" || node.parent.type === "AwaitExpression") {
+          context.report({ messageId: "noUnusedLocator", node });
+        }
+      }
+    };
+  },
+  meta: {
+    docs: {
+      category: "Possible Errors",
+      description: `Disallow usage of page locators that are not used`,
+      recommended: true,
+      url: "https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-unused-locators.md"
+    },
+    messages: {
+      noUnusedLocator: "Unused locator"
+    },
+    type: "problem"
+  }
+});
+
 // src/rules/no-useless-await.ts
 var locatorMethods = /* @__PURE__ */ new Set([
   "and",
@@ -3083,7 +3085,7 @@ var prefer_web_first_assertions_default = createRule({
           return;
         const method = getStringValue(call.callee.property);
         const methodConfig = methods3[method];
-        if (!methodConfig)
+        if (!Object.hasOwn(methods3, method))
           return;
         const notModifier = fnCall.modifiers.find(
           (mod) => getStringValue(mod) === "not"
@@ -3857,6 +3859,9 @@ var valid_test_tags_default = createRule({
         );
       }
     }
+    const extractTagsFromTitle = (title) => {
+      return title.match(/@[\S]+/g) || [];
+    };
     const validateTag = (tag, node) => {
       if (!tag.startsWith("@")) {
         context.report({
@@ -3899,6 +3904,15 @@ var valid_test_tags_default = createRule({
         const { type } = call;
         if (type !== "test" && type !== "describe" && type !== "step")
           return;
+        if (node.arguments.length > 0) {
+          const titleArg = node.arguments[0];
+          if (titleArg && titleArg.type === "Literal" && typeof titleArg.value === "string") {
+            const titleTags = extractTagsFromTitle(titleArg.value);
+            for (const tag of titleTags) {
+              validateTag(tag, node);
+            }
+          }
+        }
         if (node.arguments.length < 2)
           return;
         const optionsArg = node.arguments[1];
@@ -3938,7 +3952,7 @@ var valid_test_tags_default = createRule({
   },
   meta: {
     docs: {
-      description: "Enforce valid tag format in Playwright test blocks",
+      description: "Enforce valid tag format in Playwright test blocks and titles",
       recommended: true
     },
     messages: {
@@ -3955,7 +3969,11 @@ var valid_test_tags_default = createRule({
             items: {
               oneOf: [
                 { type: "string" },
-                { properties: { source: { type: "string" } }, type: "object" }
+                {
+                  additionalProperties: false,
+                  properties: { source: { type: "string" } },
+                  type: "object"
+                }
               ]
             },
             type: "array"
@@ -3964,7 +3982,11 @@ var valid_test_tags_default = createRule({
             items: {
               oneOf: [
                 { type: "string" },
-                { properties: { source: { type: "string" } }, type: "object" }
+                {
+                  additionalProperties: false,
+                  properties: { source: { type: "string" } },
+                  type: "object"
+                }
               ]
             },
             type: "array"
@@ -4223,6 +4245,7 @@ var index = {
     "no-slowed-test": no_slowed_test_default,
     "no-standalone-expect": no_standalone_expect_default,
     "no-unsafe-references": no_unsafe_references_default,
+    "no-unused-locators": no_unused_locators_default,
     "no-useless-await": no_useless_await_default,
     "no-useless-not": no_useless_not_default,
     "no-wait-for-navigation": no_wait_for_navigation_default,
@@ -4270,6 +4293,7 @@ var sharedConfig = {
     "playwright/no-skipped-test": "warn",
     "playwright/no-standalone-expect": "error",
     "playwright/no-unsafe-references": "error",
+    "playwright/no-unused-locators": "error",
     "playwright/no-useless-await": "warn",
     "playwright/no-useless-not": "warn",
     "playwright/no-wait-for-navigation": "error",
@@ -4279,6 +4303,7 @@ var sharedConfig = {
     "playwright/valid-describe-callback": "error",
     "playwright/valid-expect": "error",
     "playwright/valid-expect-in-promise": "error",
+    "playwright/valid-test-tags": "error",
     "playwright/valid-title": "error"
   }
 };

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "eslint-plugin-playwright",
   "description": "ESLint plugin for Playwright testing.",
-  "version": "2.2.1",
+  "version": "2.3.0",
   "repository": "https://github.com/playwright-community/eslint-plugin-playwright",
   "author": "Mark Skelton <mark@mskelton.dev>",
   "contributors": [
@@ -9,7 +9,7 @@
   ],
   "license": "MIT",
   "engines": {
-    "node": ">=16.6.0"
+    "node": ">=16.9.0"
   },
   "type": "module",
   "types": "./index.d.ts",
@@ -30,6 +30,6 @@
     "eslint": ">=8.40.0"
   },
   "dependencies": {
-    "globals": "^13.23.0"
+    "globals": "^16.4.0"
   }
 }