eslint-plugin-playwright 1.0.1 → 1.1.0

package/README.md

@@ -131,6 +131,7 @@ command line option.\
 | ✔  |     |     | [no-networkidle](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-networkidle.md)                           | Disallow usage of the `networkidle` option                        |
 |     |     |     | [no-nth-methods](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-nth-methods.md)                           | Disallow usage of `first()`, `last()`, and `nth()` methods        |
 | ✔  |     |     | [no-page-pause](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-page-pause.md)                             | Disallow using `page.pause()`                                     |
+| ✔  | 🔧  |     | [no-unsafe-references](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-unsafe-references.md)               | Prevent unsafe variable references in `page.evaluate()`           |
 |     | 🔧  |     | [no-get-by-title](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-get-by-title.md)                         | Disallow using `getByTitle()`                                     |
 |     |     |     | [no-raw-locators](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-raw-locators.md)                         | Disallow using raw locators                                       |
 | ✔  | 🔧  |     | [no-useless-await](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-useless-await.md)                       | Disallow unnecessary `await`s for Playwright methods              |

package/dist/index.d.mts

@@ -26,6 +26,7 @@ declare const _default: {
                         'no-raw-locators': eslint.Rule.RuleModule;
                         'no-restricted-matchers': eslint.Rule.RuleModule;
                         'no-skipped-test': eslint.Rule.RuleModule;
+                        'no-unsafe-references': eslint.Rule.RuleModule;
                         'no-useless-await': eslint.Rule.RuleModule;
                         'no-useless-not': eslint.Rule.RuleModule;
                         'no-wait-for-selector': eslint.Rule.RuleModule;
@@ -76,6 +77,7 @@ declare const _default: {
                         'no-raw-locators': eslint.Rule.RuleModule;
                         'no-restricted-matchers': eslint.Rule.RuleModule;
                         'no-skipped-test': eslint.Rule.RuleModule;
+                        'no-unsafe-references': eslint.Rule.RuleModule;
                         'no-useless-await': eslint.Rule.RuleModule;
                         'no-useless-not': eslint.Rule.RuleModule;
                         'no-wait-for-selector': eslint.Rule.RuleModule;
@@ -108,6 +110,7 @@ declare const _default: {
                 'playwright/no-networkidle': string;
                 'playwright/no-page-pause': string;
                 'playwright/no-skipped-test': string;
+                'playwright/no-unsafe-references': string;
                 'playwright/no-useless-await': string;
                 'playwright/no-useless-not': string;
                 'playwright/no-wait-for-selector': string;
@@ -158,6 +161,7 @@ declare const _default: {
                 'playwright/no-networkidle': string;
                 'playwright/no-page-pause': string;
                 'playwright/no-skipped-test': string;
+                'playwright/no-unsafe-references': string;
                 'playwright/no-useless-await': string;
                 'playwright/no-useless-not': string;
                 'playwright/no-wait-for-selector': string;
@@ -186,6 +190,7 @@ declare const _default: {
                 'playwright/no-networkidle': string;
                 'playwright/no-page-pause': string;
                 'playwright/no-skipped-test': string;
+                'playwright/no-unsafe-references': string;
                 'playwright/no-useless-await': string;
                 'playwright/no-useless-not': string;
                 'playwright/no-wait-for-selector': string;
@@ -213,6 +218,7 @@ declare const _default: {
         'no-raw-locators': eslint.Rule.RuleModule;
         'no-restricted-matchers': eslint.Rule.RuleModule;
         'no-skipped-test': eslint.Rule.RuleModule;
+        'no-unsafe-references': eslint.Rule.RuleModule;
         'no-useless-await': eslint.Rule.RuleModule;
         'no-useless-not': eslint.Rule.RuleModule;
         'no-wait-for-selector': eslint.Rule.RuleModule;

package/dist/index.d.ts

@@ -26,6 +26,7 @@ declare const _default: {
                         'no-raw-locators': eslint.Rule.RuleModule;
                         'no-restricted-matchers': eslint.Rule.RuleModule;
                         'no-skipped-test': eslint.Rule.RuleModule;
+                        'no-unsafe-references': eslint.Rule.RuleModule;
                         'no-useless-await': eslint.Rule.RuleModule;
                         'no-useless-not': eslint.Rule.RuleModule;
                         'no-wait-for-selector': eslint.Rule.RuleModule;
@@ -76,6 +77,7 @@ declare const _default: {
                         'no-raw-locators': eslint.Rule.RuleModule;
                         'no-restricted-matchers': eslint.Rule.RuleModule;
                         'no-skipped-test': eslint.Rule.RuleModule;
+                        'no-unsafe-references': eslint.Rule.RuleModule;
                         'no-useless-await': eslint.Rule.RuleModule;
                         'no-useless-not': eslint.Rule.RuleModule;
                         'no-wait-for-selector': eslint.Rule.RuleModule;
@@ -108,6 +110,7 @@ declare const _default: {
                 'playwright/no-networkidle': string;
                 'playwright/no-page-pause': string;
                 'playwright/no-skipped-test': string;
+                'playwright/no-unsafe-references': string;
                 'playwright/no-useless-await': string;
                 'playwright/no-useless-not': string;
                 'playwright/no-wait-for-selector': string;
@@ -158,6 +161,7 @@ declare const _default: {
                 'playwright/no-networkidle': string;
                 'playwright/no-page-pause': string;
                 'playwright/no-skipped-test': string;
+                'playwright/no-unsafe-references': string;
                 'playwright/no-useless-await': string;
                 'playwright/no-useless-not': string;
                 'playwright/no-wait-for-selector': string;
@@ -186,6 +190,7 @@ declare const _default: {
                 'playwright/no-networkidle': string;
                 'playwright/no-page-pause': string;
                 'playwright/no-skipped-test': string;
+                'playwright/no-unsafe-references': string;
                 'playwright/no-useless-await': string;
                 'playwright/no-useless-not': string;
                 'playwright/no-wait-for-selector': string;
@@ -213,6 +218,7 @@ declare const _default: {
         'no-raw-locators': eslint.Rule.RuleModule;
         'no-restricted-matchers': eslint.Rule.RuleModule;
         'no-skipped-test': eslint.Rule.RuleModule;
+        'no-unsafe-references': eslint.Rule.RuleModule;
         'no-useless-await': eslint.Rule.RuleModule;
         'no-useless-not': eslint.Rule.RuleModule;
         'no-wait-for-selector': eslint.Rule.RuleModule;

package/dist/index.js

@@ -123,6 +123,19 @@ function dig(node, identifier) {
 function isPageMethod(node, name) {
   return node.callee.type === "MemberExpression" && dig(node.callee.object, /(^(page|frame)|(Page|Frame)$)/) && isPropertyAccessor(node.callee, name);
 }
+function isFunction(node) {
+  return node.type === "ArrowFunctionExpression" || node.type === "FunctionExpression";
+}
+
+// src/utils/misc.ts
+var getAmountData = (amount) => ({
+  amount: amount.toString(),
+  s: amount === 1 ? "" : "s"
+});
+function getSourceCode(context) {
+  return context.sourceCode ?? context.getSourceCode();
+}
+var truthy = Boolean;
 
 // src/rules/expect-expect.ts
 function isAssertionCall(context, node, assertFunctionNames) {
@@ -134,7 +147,7 @@ var expect_expect_default = {
       assertFunctionNames: [],
       ...context.options?.[0] ?? {}
     };
-    const sourceCode = context.sourceCode ?? context.getSourceCode();
+    const sourceCode = getSourceCode(context);
     const unchecked = [];
     function checkExpressions(nodes) {
       for (const node of nodes) {
@@ -323,7 +336,7 @@ function getCallType(context, node, awaitableMatchers) {
 }
 var missing_playwright_await_default = {
   create(context) {
-    const sourceCode = context.sourceCode ?? context.getSourceCode();
+    const sourceCode = getSourceCode(context);
     const options = context.options[0] || {};
     const awaitableMatchers = /* @__PURE__ */ new Set([
       ...expectPlaywrightMatchers,
@@ -556,7 +569,7 @@ var no_focused_test_default = {
 
 // src/rules/no-force-option.ts
 function isForceOptionEnabled(node) {
-  const arg = node.arguments[node.arguments.length - 1];
+  const arg = node.arguments.at(-1);
   return arg?.type === "ObjectExpression" && arg.properties.find(
     (property) => property.type === "Property" && getStringValue(property.key) === "force" && isBooleanLiteral(property.value, true)
   );
@@ -901,7 +914,7 @@ var no_restricted_matchers_default = {
           context.report({
             data: { message: message ?? "", restriction },
             loc: {
-              end: chain[chain.length - 1].loc.end,
+              end: chain.at(-1).loc.end,
               start: chain[0].loc.start
             },
             messageId: message ? "restrictedWithMessage" : "restricted"
@@ -993,6 +1006,93 @@ var no_skipped_test_default = {
   }
 };
 
+// src/rules/no-unsafe-references.ts
+function collectVariables(scope) {
+  if (!scope)
+    return [];
+  return [
+    ...collectVariables(scope.upper),
+    ...scope.variables.map((ref) => ref.name)
+  ];
+}
+function addArgument(fixer, node, refs) {
+  if (!node.arguments.length)
+    return;
+  if (node.arguments.length === 1) {
+    return fixer.insertTextAfter(node.arguments[0], `, [${refs}]`);
+  }
+  const arr = node.arguments.at(-1);
+  if (!arr || arr.type !== "ArrayExpression")
+    return;
+  const lastItem = arr.elements.at(-1);
+  return lastItem ? fixer.insertTextAfter(lastItem, `, ${refs}`) : fixer.replaceText(arr, `[${refs}]`);
+}
+function getParen(sourceCode, node) {
+  let token = sourceCode.getFirstToken(node);
+  while (token && token.value !== "(") {
+    token = sourceCode.getTokenAfter(token);
+  }
+  return token;
+}
+function addParam(sourceCode, fixer, node, refs) {
+  const lastParam = node.params.at(-1);
+  if (lastParam) {
+    return fixer.insertTextAfter(lastParam, `, ${refs}`);
+  }
+  const token = getParen(sourceCode, node);
+  return token ? fixer.insertTextAfter(token, `[${refs}]`) : null;
+}
+var no_unsafe_references_default = {
+  create(context) {
+    return {
+      CallExpression(node) {
+        if (!isPageMethod(node, "evaluate"))
+          return;
+        const [fn] = node.arguments;
+        if (!fn || !isFunction(fn))
+          return;
+        const sourceCode = getSourceCode(context);
+        const { through, upper } = sourceCode.getScope(fn.body);
+        const allRefs = new Set(collectVariables(upper));
+        through.filter((ref) => allRefs.has(ref.identifier.name)).forEach((ref, i, arr) => {
+          const descriptor = {
+            data: { variable: ref.identifier.name },
+            messageId: "noUnsafeReference",
+            node: ref.identifier
+          };
+          if (i !== 0) {
+            context.report(descriptor);
+            return;
+          }
+          context.report({
+            ...descriptor,
+            fix(fixer) {
+              const refs = arr.map((ref2) => ref2.identifier.name).join(", ");
+              return [
+                addArgument(fixer, node, refs),
+                addParam(sourceCode, fixer, fn, refs)
+              ].filter(truthy);
+            }
+          });
+        });
+      }
+    };
+  },
+  meta: {
+    docs: {
+      category: "Possible Errors",
+      description: "Prevent unsafe variable references in page.evaluate()",
+      recommended: true,
+      url: "https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-unsafe-references.md"
+    },
+    fixable: "code",
+    messages: {
+      noUnsafeReference: 'Unsafe reference to variable "{{ variable }}" in page.evaluate()'
+    },
+    type: "problem"
+  }
+};
+
 // src/rules/no-useless-await.ts
 var locatorMethods = /* @__PURE__ */ new Set([
   "and",
@@ -1465,7 +1565,7 @@ var prefer_to_contain_default = {
         );
         context.report({
           fix(fixer) {
-            const sourceCode = context.sourceCode ?? context.getSourceCode();
+            const sourceCode = getSourceCode(context);
             const addNotModifier = matcherArg.type === "Literal" && matcherArg.value === !!notModifier;
             const fixes = [
               // remove the "includes" call entirely
@@ -1661,6 +1761,19 @@ var supportedMatchers = /* @__PURE__ */ new Set([
   "toBeTruthy",
   "toBeFalsy"
 ]);
+function dereference(context, node) {
+  if (node.type !== "Identifier") {
+    return node;
+  }
+  const sourceCode = getSourceCode(context);
+  const scope = sourceCode.getScope(node);
+  for (const ref of scope.references) {
+    const refParent = ref.identifier.parent;
+    if (refParent.type === "VariableDeclarator") {
+      return refParent.init;
+    }
+  }
+}
 var prefer_web_first_assertions_default = {
   create(context) {
     return {
@@ -1668,8 +1781,8 @@ var prefer_web_first_assertions_default = {
         const expectCall = parseExpectCall(context, node);
         if (!expectCall)
           return;
-        const [arg] = node.arguments;
-        if (arg.type !== "AwaitExpression" || arg.argument.type !== "CallExpression" || arg.argument.callee.type !== "MemberExpression") {
+        const arg = dereference(context, node.arguments[0]);
+        if (!arg || arg.type !== "AwaitExpression" || arg.argument.type !== "CallExpression" || arg.argument.callee.type !== "MemberExpression") {
           return;
         }
         if (!supportedMatchers.has(expectCall.matcherName))
@@ -1693,7 +1806,7 @@ var prefer_web_first_assertions_default = {
           },
           fix: (fixer) => {
             const methodArgs = arg.argument.type === "CallExpression" ? arg.argument.arguments : [];
-            const methodEnd = methodArgs.length ? methodArgs[methodArgs.length - 1].range[1] + 1 : callee.property.range[1] + 2;
+            const methodEnd = methodArgs.length ? methodArgs.at(-1).range[1] + 1 : callee.property.range[1] + 2;
             const fixes = [
               // Add await to the expect call
               fixer.insertTextBefore(node, "await "),
@@ -1791,12 +1904,6 @@ var require_soft_assertions_default = {
   }
 };
 
-// src/utils/misc.ts
-var getAmountData = (amount) => ({
-  amount: amount.toString(),
-  s: amount === 1 ? "" : "s"
-});
-
 // src/rules/require-top-level-describe.ts
 var require_top_level_describe_default = {
   create(context) {
@@ -2180,6 +2287,7 @@ var index = {
     "no-raw-locators": no_raw_locators_default,
     "no-restricted-matchers": no_restricted_matchers_default,
     "no-skipped-test": no_skipped_test_default,
+    "no-unsafe-references": no_unsafe_references_default,
     "no-useless-await": no_useless_await_default,
     "no-useless-not": no_useless_not_default,
     "no-wait-for-selector": no_wait_for_selector_default,
@@ -2212,6 +2320,7 @@ var sharedConfig = {
     "playwright/no-networkidle": "error",
     "playwright/no-page-pause": "warn",
     "playwright/no-skipped-test": "warn",
+    "playwright/no-unsafe-references": "error",
     "playwright/no-useless-await": "warn",
     "playwright/no-useless-not": "warn",
     "playwright/no-wait-for-selector": "warn",

package/dist/index.mjs

@@ -93,6 +93,9 @@ function dig(node, identifier) {
 function isPageMethod(node, name) {
   return node.callee.type === "MemberExpression" && dig(node.callee.object, /(^(page|frame)|(Page|Frame)$)/) && isPropertyAccessor(node.callee, name);
 }
+function isFunction(node) {
+  return node.type === "ArrowFunctionExpression" || node.type === "FunctionExpression";
+}
 var isTemplateLiteral, describeProperties, testHooks, expectSubCommands;
 var init_ast = __esm({
   "src/utils/ast.ts"() {
@@ -111,6 +114,22 @@ var init_ast = __esm({
   }
 });
 
+// src/utils/misc.ts
+function getSourceCode(context) {
+  return context.sourceCode ?? context.getSourceCode();
+}
+var getAmountData, truthy;
+var init_misc = __esm({
+  "src/utils/misc.ts"() {
+    "use strict";
+    getAmountData = (amount) => ({
+      amount: amount.toString(),
+      s: amount === 1 ? "" : "s"
+    });
+    truthy = Boolean;
+  }
+});
+
 // src/rules/expect-expect.ts
 function isAssertionCall(context, node, assertFunctionNames) {
   return isExpectCall(context, node) || assertFunctionNames.find((name) => dig(node.callee, name));
@@ -120,13 +139,14 @@ var init_expect_expect = __esm({
   "src/rules/expect-expect.ts"() {
     "use strict";
     init_ast();
+    init_misc();
     expect_expect_default = {
       create(context) {
         const options = {
           assertFunctionNames: [],
           ...context.options?.[0] ?? {}
         };
-        const sourceCode = context.sourceCode ?? context.getSourceCode();
+        const sourceCode = getSourceCode(context);
         const unchecked = [];
         function checkExpressions(nodes) {
           for (const node of nodes) {
@@ -275,6 +295,7 @@ var init_missing_playwright_await = __esm({
   "src/rules/missing-playwright-await.ts"() {
     "use strict";
     init_ast();
+    init_misc();
     validTypes = /* @__PURE__ */ new Set([
       "AwaitExpression",
       "ReturnStatement",
@@ -329,7 +350,7 @@ var init_missing_playwright_await = __esm({
     ];
     missing_playwright_await_default = {
       create(context) {
-        const sourceCode = context.sourceCode ?? context.getSourceCode();
+        const sourceCode = getSourceCode(context);
         const options = context.options[0] || {};
         const awaitableMatchers = /* @__PURE__ */ new Set([
           ...expectPlaywrightMatchers,
@@ -592,7 +613,7 @@ var init_no_focused_test = __esm({
 
 // src/rules/no-force-option.ts
 function isForceOptionEnabled(node) {
-  const arg = node.arguments[node.arguments.length - 1];
+  const arg = node.arguments.at(-1);
   return arg?.type === "ObjectExpression" && arg.properties.find(
     (property) => property.type === "Property" && getStringValue(property.key) === "force" && isBooleanLiteral(property.value, true)
   );
@@ -999,7 +1020,7 @@ var init_no_restricted_matchers = __esm({
               context.report({
                 data: { message: message ?? "", restriction },
                 loc: {
-                  end: chain[chain.length - 1].loc.end,
+                  end: chain.at(-1).loc.end,
                   start: chain[0].loc.start
                 },
                 messageId: message ? "restrictedWithMessage" : "restricted"
@@ -1100,6 +1121,101 @@ var init_no_skipped_test = __esm({
   }
 });
 
+// src/rules/no-unsafe-references.ts
+function collectVariables(scope) {
+  if (!scope)
+    return [];
+  return [
+    ...collectVariables(scope.upper),
+    ...scope.variables.map((ref) => ref.name)
+  ];
+}
+function addArgument(fixer, node, refs) {
+  if (!node.arguments.length)
+    return;
+  if (node.arguments.length === 1) {
+    return fixer.insertTextAfter(node.arguments[0], `, [${refs}]`);
+  }
+  const arr = node.arguments.at(-1);
+  if (!arr || arr.type !== "ArrayExpression")
+    return;
+  const lastItem = arr.elements.at(-1);
+  return lastItem ? fixer.insertTextAfter(lastItem, `, ${refs}`) : fixer.replaceText(arr, `[${refs}]`);
+}
+function getParen(sourceCode, node) {
+  let token = sourceCode.getFirstToken(node);
+  while (token && token.value !== "(") {
+    token = sourceCode.getTokenAfter(token);
+  }
+  return token;
+}
+function addParam(sourceCode, fixer, node, refs) {
+  const lastParam = node.params.at(-1);
+  if (lastParam) {
+    return fixer.insertTextAfter(lastParam, `, ${refs}`);
+  }
+  const token = getParen(sourceCode, node);
+  return token ? fixer.insertTextAfter(token, `[${refs}]`) : null;
+}
+var no_unsafe_references_default;
+var init_no_unsafe_references = __esm({
+  "src/rules/no-unsafe-references.ts"() {
+    "use strict";
+    init_ast();
+    init_misc();
+    no_unsafe_references_default = {
+      create(context) {
+        return {
+          CallExpression(node) {
+            if (!isPageMethod(node, "evaluate"))
+              return;
+            const [fn] = node.arguments;
+            if (!fn || !isFunction(fn))
+              return;
+            const sourceCode = getSourceCode(context);
+            const { through, upper } = sourceCode.getScope(fn.body);
+            const allRefs = new Set(collectVariables(upper));
+            through.filter((ref) => allRefs.has(ref.identifier.name)).forEach((ref, i, arr) => {
+              const descriptor = {
+                data: { variable: ref.identifier.name },
+                messageId: "noUnsafeReference",
+                node: ref.identifier
+              };
+              if (i !== 0) {
+                context.report(descriptor);
+                return;
+              }
+              context.report({
+                ...descriptor,
+                fix(fixer) {
+                  const refs = arr.map((ref2) => ref2.identifier.name).join(", ");
+                  return [
+                    addArgument(fixer, node, refs),
+                    addParam(sourceCode, fixer, fn, refs)
+                  ].filter(truthy);
+                }
+              });
+            });
+          }
+        };
+      },
+      meta: {
+        docs: {
+          category: "Possible Errors",
+          description: "Prevent unsafe variable references in page.evaluate()",
+          recommended: true,
+          url: "https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/no-unsafe-references.md"
+        },
+        fixable: "code",
+        messages: {
+          noUnsafeReference: 'Unsafe reference to variable "{{ variable }}" in page.evaluate()'
+        },
+        type: "problem"
+      }
+    };
+  }
+});
+
 // src/rules/no-useless-await.ts
 function isSupportedMethod(node) {
   if (node.callee.type !== "MemberExpression")
@@ -1617,6 +1733,7 @@ var init_prefer_to_contain = __esm({
   "src/rules/prefer-to-contain.ts"() {
     "use strict";
     init_ast();
+    init_misc();
     init_parseExpectCall();
     matchers = /* @__PURE__ */ new Set(["toBe", "toEqual", "toStrictEqual"]);
     isFixableIncludesCallExpression = (node) => node.type === "CallExpression" && node.callee.type === "MemberExpression" && isPropertyAccessor(node.callee, "includes") && node.arguments.length === 1 && node.arguments[0].type !== "SpreadElement";
@@ -1638,7 +1755,7 @@ var init_prefer_to_contain = __esm({
             );
             context.report({
               fix(fixer) {
-                const sourceCode = context.sourceCode ?? context.getSourceCode();
+                const sourceCode = getSourceCode(context);
                 const addNotModifier = matcherArg.type === "Literal" && matcherArg.value === !!notModifier;
                 const fixes = [
                   // remove the "includes" call entirely
@@ -1813,11 +1930,25 @@ var init_prefer_to_have_length = __esm({
 });
 
 // src/rules/prefer-web-first-assertions.ts
+function dereference(context, node) {
+  if (node.type !== "Identifier") {
+    return node;
+  }
+  const sourceCode = getSourceCode(context);
+  const scope = sourceCode.getScope(node);
+  for (const ref of scope.references) {
+    const refParent = ref.identifier.parent;
+    if (refParent.type === "VariableDeclarator") {
+      return refParent.init;
+    }
+  }
+}
 var methods3, supportedMatchers, prefer_web_first_assertions_default;
 var init_prefer_web_first_assertions = __esm({
   "src/rules/prefer-web-first-assertions.ts"() {
     "use strict";
     init_ast();
+    init_misc();
     init_parseExpectCall();
     methods3 = {
       getAttribute: {
@@ -1867,8 +1998,8 @@ var init_prefer_web_first_assertions = __esm({
             const expectCall = parseExpectCall(context, node);
             if (!expectCall)
               return;
-            const [arg] = node.arguments;
-            if (arg.type !== "AwaitExpression" || arg.argument.type !== "CallExpression" || arg.argument.callee.type !== "MemberExpression") {
+            const arg = dereference(context, node.arguments[0]);
+            if (!arg || arg.type !== "AwaitExpression" || arg.argument.type !== "CallExpression" || arg.argument.callee.type !== "MemberExpression") {
               return;
             }
             if (!supportedMatchers.has(expectCall.matcherName))
@@ -1892,7 +2023,7 @@ var init_prefer_web_first_assertions = __esm({
               },
               fix: (fixer) => {
                 const methodArgs = arg.argument.type === "CallExpression" ? arg.argument.arguments : [];
-                const methodEnd = methodArgs.length ? methodArgs[methodArgs.length - 1].range[1] + 1 : callee.property.range[1] + 2;
+                const methodEnd = methodArgs.length ? methodArgs.at(-1).range[1] + 1 : callee.property.range[1] + 2;
                 const fixes = [
                   // Add await to the expect call
                   fixer.insertTextBefore(node, "await "),
@@ -1999,18 +2130,6 @@ var init_require_soft_assertions = __esm({
   }
 });
 
-// src/utils/misc.ts
-var getAmountData;
-var init_misc = __esm({
-  "src/utils/misc.ts"() {
-    "use strict";
-    getAmountData = (amount) => ({
-      amount: amount.toString(),
-      s: amount === 1 ? "" : "s"
-    });
-  }
-});
-
 // src/rules/require-top-level-describe.ts
 var require_top_level_describe_default;
 var init_require_top_level_describe = __esm({
@@ -2418,6 +2537,7 @@ var require_src = __commonJS({
     init_no_raw_locators();
     init_no_restricted_matchers();
     init_no_skipped_test();
+    init_no_unsafe_references();
     init_no_useless_await();
     init_no_useless_not();
     init_no_wait_for_selector();
@@ -2452,6 +2572,7 @@ var require_src = __commonJS({
         "no-raw-locators": no_raw_locators_default,
         "no-restricted-matchers": no_restricted_matchers_default,
         "no-skipped-test": no_skipped_test_default,
+        "no-unsafe-references": no_unsafe_references_default,
         "no-useless-await": no_useless_await_default,
         "no-useless-not": no_useless_not_default,
         "no-wait-for-selector": no_wait_for_selector_default,
@@ -2484,6 +2605,7 @@ var require_src = __commonJS({
         "playwright/no-networkidle": "error",
         "playwright/no-page-pause": "warn",
         "playwright/no-skipped-test": "warn",
+        "playwright/no-unsafe-references": "error",
         "playwright/no-useless-await": "warn",
         "playwright/no-useless-not": "warn",
         "playwright/no-wait-for-selector": "warn",

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "eslint-plugin-playwright",
   "description": "ESLint plugin for Playwright testing.",
-  "version": "1.0.1",
+  "version": "1.1.0",
   "repository": "https://github.com/playwright-community/eslint-plugin-playwright",
   "author": "Mark Skelton <mark@mskelton.dev>",
   "packageManager": "pnpm@8.12.0",
@@ -12,6 +12,9 @@
   "workspaces": [
     "examples"
   ],
+  "engines": {
+    "node": ">=16.6.0"
+  },
   "types": "./dist/index.d.ts",
   "exports": {
     "import": {
@@ -37,6 +40,7 @@
   "devDependencies": {
     "@jest/globals": "^29.7.0",
     "@mskelton/eslint-config": "^8.4.0",
+    "@mskelton/semantic-release-config": "^1.0.1",
     "@types/eslint": "^8.44.3",
     "@types/estree": "^1.0.2",
     "@types/node": "^20.11.17",
@@ -47,7 +51,8 @@
     "eslint-plugin-sort": "^2.10.0",
     "jest": "^29.7.0",
     "prettier": "^3.0.3",
-    "semantic-release": "^22.0.5",
+    "prettier-plugin-jsdoc": "^1.3.0",
+    "semantic-release": "^23.0.2",
     "ts-jest": "^29.1.1",
     "tsup": "^8.0.1",
     "typescript": "^5.2.2"