eslint-plugin-playwright 0.17.0 → 0.18.0

package/README.md

@@ -101,7 +101,7 @@ under the `playwright` key. It supports the following settings:
   the presence of at least one assertion per test case. This allows such rules
   to recognise custom assertion functions as valid assertions. The global
   setting applies to all modules. The
-  [`expect-expect` rule accepts an option by the same name](./rules/expect-expect.md#additionalassertfunctionnames)
+  [`expect-expect` rule accepts an option by the same name](https://github.com/playwright-community/eslint-plugin-playwright/tree/main/docs/rules/expect-expect.md#additionalassertfunctionnames)
   to enable per-module configuration (.e.g, for module-specific custom assert
   functions).
 

package/lib/rules/expect-expect.js

@@ -4,7 +4,7 @@ const ast_1 = require("../utils/ast");
 const misc_1 = require("../utils/misc");
 function isAssertionCall(node, additionalAssertFunctionNames) {
     return ((0, ast_1.isExpectCall)(node) ||
-        additionalAssertFunctionNames.find((name) => (0, ast_1.isIdentifier)(node.callee, name)));
+        additionalAssertFunctionNames.find((name) => (0, ast_1.dig)(node.callee, name)));
 }
 exports.default = {
     create(context) {
@@ -25,7 +25,7 @@ exports.default = {
                     unchecked.push(node);
                 }
                 else if (isAssertionCall(node, additionalAssertFunctionNames)) {
-                    checkExpressions(context.getAncestors());
+                    checkExpressions(context.sourceCode.getAncestors(node));
                 }
             },
             'Program:exit'() {

package/lib/rules/no-skipped-test.js

@@ -5,11 +5,18 @@ exports.default = {
     create(context) {
         return {
             CallExpression(node) {
+                const options = context.options[0] || {};
+                const allowConditional = !!options.allowConditional;
                 const { callee } = node;
                 if (((0, ast_1.isTestIdentifier)(callee) || (0, ast_1.isDescribeCall)(node)) &&
                     callee.type === 'MemberExpression' &&
                     (0, ast_1.isPropertyAccessor)(callee, 'skip')) {
                     const isHook = (0, ast_1.isTest)(node) || (0, ast_1.isDescribeCall)(node);
+                    // If allowConditional is enabled and it's not a test/describe hook,
+                    // we ignore any `test.skip` calls that have no arguments.
+                    if (!isHook && allowConditional && node.arguments.length) {
+                        return;
+                    }
                     context.report({
                         messageId: 'noSkippedTest',
                         node: isHook ? callee.property : node,
@@ -43,6 +50,18 @@ exports.default = {
             noSkippedTest: 'Unexpected use of the `.skip()` annotation.',
             removeSkippedTestAnnotation: 'Remove the `.skip()` annotation.',
         },
+        schema: [
+            {
+                additionalProperties: false,
+                properties: {
+                    allowConditional: {
+                        default: false,
+                        type: 'boolean',
+                    },
+                },
+                type: 'object',
+            },
+        ],
         type: 'suggestion',
     },
 };

package/lib/utils/ast.js

@@ -1,6 +1,6 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
-exports.isPageMethod = exports.getMatchers = exports.isExpectCall = exports.getExpectType = exports.isTestHook = exports.isTest = exports.findParent = exports.isDescribeCall = exports.isTestIdentifier = exports.isPropertyAccessor = exports.isBooleanLiteral = exports.isStringLiteral = exports.isIdentifier = exports.getRawValue = exports.getStringValue = void 0;
+exports.isPageMethod = exports.dig = exports.getMatchers = exports.isExpectCall = exports.getExpectType = exports.isTestHook = exports.isTest = exports.findParent = exports.isDescribeCall = exports.isTestIdentifier = exports.isPropertyAccessor = exports.isBooleanLiteral = exports.isStringLiteral = exports.isIdentifier = exports.getRawValue = exports.getStringValue = void 0;
 function getStringValue(node) {
     if (!node)
         return '';
@@ -132,6 +132,7 @@ function dig(node, identifier) {
                 ? isIdentifier(node, identifier)
                 : false;
 }
+exports.dig = dig;
 function isPageMethod(node, name) {
     return (node.callee.type === 'MemberExpression' &&
         dig(node.callee.object, /(^(page|frame)|(Page|Frame)$)/) &&

package/package.json

@@ -1,7 +1,7 @@
 {
   "name": "eslint-plugin-playwright",
   "description": "ESLint plugin for Playwright testing.",
-  "version": "0.17.0",
+  "version": "0.18.0",
   "packageManager": "pnpm@8.8.0",
   "main": "lib/index.js",
   "repository": "https://github.com/playwright-community/eslint-plugin-playwright",