eslint-plugin-perfectionist 4.8.0 → 4.9.0

package/dist/rules/sort-array-includes/types.js

@@ -4,7 +4,7 @@ const commonJsonSchemas = require('../../utils/common-json-schemas.js')
 let allSelectors = ['literal', 'spread']
 let singleCustomGroupJsonSchema = {
   selector: commonJsonSchemas.buildCustomGroupSelectorJsonSchema(allSelectors),
-  elementNamePattern: commonJsonSchemas.elementNamePatternJsonSchema,
+  elementNamePattern: commonJsonSchemas.regexJsonSchema,
 }
 exports.allSelectors = allSelectors
 exports.singleCustomGroupJsonSchema = singleCustomGroupJsonSchema

package/dist/rules/sort-array-includes.js

@@ -27,6 +27,7 @@ const useGroups = require('../utils/use-groups.js')
 const complete = require('../utils/complete.js')
 let cachedGroupsByModifiersAndSelectors = /* @__PURE__ */ new Map()
 let defaultOptions = {
+  fallbackSort: { type: 'unsorted' },
   groupKind: 'literals-first',
   specialCharacters: 'keep',
   partitionByComment: false,
@@ -54,7 +55,6 @@ let jsonSchema = {
         singleCustomGroupJsonSchema: types.singleCustomGroupJsonSchema,
       }),
       useConfigurationIf: commonJsonSchemas.buildUseConfigurationIfJsonSchema(),
-      type: commonJsonSchemas.buildTypeJsonSchema({ withUnsorted: true }),
       partitionByComment: commonJsonSchemas.partitionByCommentJsonSchema,
       partitionByNewLine: commonJsonSchemas.partitionByNewLineJsonSchema,
       newlinesBetween: commonJsonSchemas.newlinesBetweenJsonSchema,
@@ -127,19 +127,11 @@ let sortArray = ({ availableMessageIds, elements, context }) => {
         .map(element => getNodeName({ sourceCode, element })),
       contextOptions: context.options,
     })
-  let completeOptions = complete.complete(
+  let options = complete.complete(
     matchedContextOptions[0],
     settings,
     defaultOptions,
   )
-  let { type } = completeOptions
-  if (type === 'unsorted') {
-    return
-  }
-  let options = {
-    ...completeOptions,
-    type,
-  }
   validateCustomSortConfiguration.validateCustomSortConfiguration(options)
   validateGeneratedGroupsConfiguration.validateGeneratedGroupsConfiguration({
     selectors: types.allSelectors,

package/dist/rules/sort-classes/types.js

@@ -26,15 +26,12 @@ let allModifiers = [
   'optional',
 ]
 let singleCustomGroupJsonSchema = {
-  decoratorNamePattern: {
-    description: 'Decorator name pattern filter.',
-    type: 'string',
-  },
   modifiers:
     commonJsonSchemas.buildCustomGroupModifiersJsonSchema(allModifiers),
   selector: commonJsonSchemas.buildCustomGroupSelectorJsonSchema(allSelectors),
-  elementValuePattern: commonJsonSchemas.elementValuePatternJsonSchema,
-  elementNamePattern: commonJsonSchemas.elementNamePatternJsonSchema,
+  decoratorNamePattern: commonJsonSchemas.regexJsonSchema,
+  elementValuePattern: commonJsonSchemas.regexJsonSchema,
+  elementNamePattern: commonJsonSchemas.regexJsonSchema,
 }
 exports.allModifiers = allModifiers
 exports.allSelectors = allSelectors

package/dist/rules/sort-classes.js

@@ -13,7 +13,9 @@ const doesCustomGroupMatch = require('./sort-classes/does-custom-group-match.js'
 const getEslintDisabledLines = require('../utils/get-eslint-disabled-lines.js')
 const isNodeEslintDisabled = require('../utils/is-node-eslint-disabled.js')
 const sortNodesByGroups = require('../utils/sort-nodes-by-groups.js')
+const getNodeDecorators = require('../utils/get-node-decorators.js')
 const createEslintRule = require('../utils/create-eslint-rule.js')
+const getDecoratorName = require('../utils/get-decorator-name.js')
 const reportAllErrors = require('../utils/report-all-errors.js')
 const shouldPartition = require('../utils/should-partition.js')
 const getGroupNumber = require('../utils/get-group-number.js')
@@ -51,6 +53,7 @@ let defaultOptions = {
     'unknown',
   ],
   ignoreCallbackDependenciesPatterns: [],
+  fallbackSort: { type: 'unsorted' },
   partitionByComment: false,
   partitionByNewLine: false,
   newlinesBetween: 'ignore',
@@ -185,8 +188,9 @@ const sortClasses = createEslintRule.createEslintRule({
                 'name' in nodeValue.callee ? nodeValue.callee.name : null
               shouldIgnore =
                 functionName !== null &&
-                options.ignoreCallbackDependenciesPatterns.some(pattern =>
-                  matches.matches(functionName, pattern),
+                matches.matches(
+                  functionName,
+                  options.ignoreCallbackDependenciesPatterns,
                 )
             }
             if (!shouldIgnore) {
@@ -227,7 +231,7 @@ const sortClasses = createEslintRule.createEslintRule({
         getOverloadSignatureGroups.getOverloadSignatureGroups(node.body)
       let formattedNodes = node.body.reduce(
         (accumulator, member) => {
-          var _a2, _b, _c
+          var _a2, _b, _c, _d, _e
           let name
           let dependencies = []
           let { defineGroup, getGroup } = useGroups.useGroups(options)
@@ -250,25 +254,73 @@ const sortClasses = createEslintRule.createEslintRule({
           let decorated = false
           let decorators = []
           if ('decorators' in member) {
-            decorated = member.decorators.length > 0
-            for (let decorator of member.decorators) {
-              if (decorator.expression.type === 'Identifier') {
-                decorators.push(decorator.expression.name)
-              } else if (
-                decorator.expression.type === 'CallExpression' &&
-                decorator.expression.callee.type === 'Identifier'
-              ) {
-                decorators.push(decorator.expression.callee.name)
-              }
-            }
+            decorators = getNodeDecorators
+              .getNodeDecorators(member)
+              .map(decorator =>
+                getDecoratorName.getDecoratorName({ sourceCode, decorator }),
+              )
+            decorated = decorators.length > 0
           }
           let memberValue
           let modifiers = []
           let selectors = []
           let addSafetySemicolonWhenInline = true
           switch (member.type) {
+            case 'TSAbstractPropertyDefinition':
+            case 'PropertyDefinition':
+              if ('static' in member && member.static) {
+                modifiers.push('static')
+              }
+              if ('declare' in member && member.declare) {
+                modifiers.push('declare')
+              }
+              if (member.type === 'TSAbstractPropertyDefinition') {
+                modifiers.push('abstract')
+              }
+              if (decorated) {
+                modifiers.push('decorated')
+              }
+              if ('override' in member && member.override) {
+                modifiers.push('override')
+              }
+              if ('readonly' in member && member.readonly) {
+                modifiers.push('readonly')
+              }
+              if (
+                'accessibility' in member &&
+                member.accessibility === 'protected'
+              ) {
+                modifiers.push('protected')
+              } else if (
+                ('accessibility' in member &&
+                  member.accessibility === 'private') ||
+                isPrivateHash
+              ) {
+                modifiers.push('private')
+              } else {
+                modifiers.push('public')
+              }
+              if ('optional' in member && member.optional) {
+                modifiers.push('optional')
+              }
+              if (
+                ((_b = member.value) == null ? void 0 : _b.type) ===
+                  'ArrowFunctionExpression' ||
+                ((_c = member.value) == null ? void 0 : _c.type) ===
+                  'FunctionExpression'
+              ) {
+                if (member.value.async) {
+                  modifiers.push('async')
+                }
+                selectors.push('function-property')
+              } else if (member.value) {
+                memberValue = sourceCode.getText(member.value)
+                dependencies = extractDependencies(member.value, member.static)
+              }
+              selectors.push('property')
+              break
             case 'TSAbstractMethodDefinition':
-            case 'MethodDefinition': {
+            case 'MethodDefinition':
               if (member.static) {
                 modifiers.push('static')
               }
@@ -307,9 +359,8 @@ const sortClasses = createEslintRule.createEslintRule({
               }
               selectors.push('method')
               break
-            }
             case 'TSAbstractAccessorProperty':
-            case 'AccessorProperty': {
+            case 'AccessorProperty':
               if (member.static) {
                 modifiers.push('static')
               }
@@ -331,8 +382,7 @@ const sortClasses = createEslintRule.createEslintRule({
               }
               selectors.push('accessor-property')
               break
-            }
-            case 'TSIndexSignature': {
+            case 'TSIndexSignature':
               if (member.static) {
                 modifiers.push('static')
               }
@@ -341,70 +391,11 @@ const sortClasses = createEslintRule.createEslintRule({
               }
               selectors.push('index-signature')
               break
-            }
-            case 'StaticBlock': {
+            case 'StaticBlock':
               addSafetySemicolonWhenInline = false
               selectors.push('static-block')
               dependencies = extractDependencies(member, true)
               break
-            }
-            default: {
-              if ('static' in member && member.static) {
-                modifiers.push('static')
-              }
-              if ('declare' in member && member.declare) {
-                modifiers.push('declare')
-              }
-              if (member.type === 'TSAbstractPropertyDefinition') {
-                modifiers.push('abstract')
-              }
-              if (decorated) {
-                modifiers.push('decorated')
-              }
-              if ('override' in member && member.override) {
-                modifiers.push('override')
-              }
-              if ('readonly' in member && member.readonly) {
-                modifiers.push('readonly')
-              }
-              if (
-                'accessibility' in member &&
-                member.accessibility === 'protected'
-              ) {
-                modifiers.push('protected')
-              } else if (
-                ('accessibility' in member &&
-                  member.accessibility === 'private') ||
-                isPrivateHash
-              ) {
-                modifiers.push('private')
-              } else {
-                modifiers.push('public')
-              }
-              if ('optional' in member && member.optional) {
-                modifiers.push('optional')
-              }
-              if ('value' in member && member.value) {
-                if (
-                  member.value.type === 'ArrowFunctionExpression' ||
-                  member.value.type === 'FunctionExpression'
-                ) {
-                  if (member.value.async) {
-                    modifiers.push('async')
-                  }
-                  selectors.push('function-property')
-                } else {
-                  memberValue = sourceCode.getText(member.value)
-                }
-                if (member.value.type !== 'TSEmptyBodyFunctionExpression') {
-                  dependencies = extractDependencies(
-                    member.value,
-                    member.static,
-                  )
-                }
-              }
-              selectors.push('property')
-            }
           }
           let predefinedGroups =
             generatePredefinedGroups.generatePredefinedGroups({
@@ -437,10 +428,10 @@ const sortClasses = createEslintRule.createEslintRule({
               overloadSignatures.includes(member),
             )
           let overloadSignatureGroupMember =
-            (_b = overloadSignatureGroups[overloadSignatureGroupMemberIndex]) ==
+            (_d = overloadSignatureGroups[overloadSignatureGroupMemberIndex]) ==
             null
               ? void 0
-              : _b.at(-1)
+              : _d.at(-1)
           let sortingNode = {
             dependencyName: getDependencyName({
               nodeNameWithoutStartingHash: name.startsWith('#')
@@ -470,7 +461,7 @@ const sortClasses = createEslintRule.createEslintRule({
             name,
           }
           let lastSortingNode =
-            (_c = accumulator.at(-1)) == null ? void 0 : _c.at(-1)
+            (_e = accumulator.at(-1)) == null ? void 0 : _e.at(-1)
           if (
             shouldPartition.shouldPartition({
               lastSortingNode,
@@ -540,21 +531,13 @@ const sortClasses = createEslintRule.createEslintRule({
       {
         properties: {
           ...commonJsonSchemas.commonJsonSchemas,
-          ignoreCallbackDependenciesPatterns: {
-            description:
-              'Patterns that should be ignored when detecting dependencies in method callbacks.',
-            items: {
-              type: 'string',
-            },
-            type: 'array',
-          },
           customGroups: commonJsonSchemas.buildCustomGroupsArrayJsonSchema({
             singleCustomGroupJsonSchema: types.singleCustomGroupJsonSchema,
           }),
+          ignoreCallbackDependenciesPatterns: commonJsonSchemas.regexJsonSchema,
           partitionByComment: commonJsonSchemas.partitionByCommentJsonSchema,
           partitionByNewLine: commonJsonSchemas.partitionByNewLineJsonSchema,
           newlinesBetween: commonJsonSchemas.newlinesBetweenJsonSchema,
-          type: commonJsonSchemas.buildTypeJsonSchema(),
           groups: commonJsonSchemas.groupsJsonSchema,
         },
         additionalProperties: false,

package/dist/rules/sort-decorators.js

@@ -4,10 +4,10 @@ const validateCustomSortConfiguration = require('../utils/validate-custom-sort-c
 const validateGroupsConfiguration = require('../utils/validate-groups-configuration.js')
 const getEslintDisabledLines = require('../utils/get-eslint-disabled-lines.js')
 const isNodeEslintDisabled = require('../utils/is-node-eslint-disabled.js')
-const getDecoratorName = require('./sort-decorators/get-decorator-name.js')
 const reportErrors = require('../utils/report-errors.js')
 const sortNodesByGroups = require('../utils/sort-nodes-by-groups.js')
 const getNodeDecorators = require('../utils/get-node-decorators.js')
+const getDecoratorName = require('../utils/get-decorator-name.js')
 const createEslintRule = require('../utils/create-eslint-rule.js')
 const reportAllErrors = require('../utils/report-all-errors.js')
 const shouldPartition = require('../utils/should-partition.js')
@@ -18,6 +18,7 @@ const isSortable = require('../utils/is-sortable.js')
 const useGroups = require('../utils/use-groups.js')
 const complete = require('../utils/complete.js')
 let defaultOptions = {
+  fallbackSort: { type: 'unsorted' },
   specialCharacters: 'keep',
   partitionByComment: false,
   sortOnProperties: true,
@@ -42,11 +43,11 @@ const sortDecorators = createEslintRule.createEslintRule({
       defaultOptions,
     )
     validateCustomSortConfiguration.validateCustomSortConfiguration(options)
-    validateGroupsConfiguration.validateGroupsConfiguration(
-      options.groups,
-      ['unknown'],
-      Object.keys(options.customGroups),
-    )
+    validateGroupsConfiguration.validateGroupsConfiguration({
+      allowedCustomGroups: Object.keys(options.customGroups),
+      allowedPredefinedGroups: ['unknown'],
+      options,
+    })
     return {
       Decorator: decorator => {
         if (!options.sortOnParameters) {
@@ -130,7 +131,6 @@ const sortDecorators = createEslintRule.createEslintRule({
           },
           partitionByComment: commonJsonSchemas.partitionByCommentJsonSchema,
           customGroups: commonJsonSchemas.customGroupsJsonSchema,
-          type: commonJsonSchemas.buildTypeJsonSchema(),
           groups: commonJsonSchemas.groupsJsonSchema,
         },
         additionalProperties: false,
@@ -165,7 +165,10 @@ let sortDecorators$1 = (context, options, decorators) => {
     (accumulator, decorator) => {
       var _a
       let { setCustomGroups, getGroup } = useGroups.useGroups(options)
-      let name = getDecoratorName.getDecoratorName(decorator)
+      let name = getDecoratorName.getDecoratorName({
+        sourceCode,
+        decorator,
+      })
       setCustomGroups(options.customGroups, name)
       let sortingNode = {
         isEslintDisabled: isNodeEslintDisabled.isNodeEslintDisabled(

package/dist/rules/sort-enums/types.js

@@ -2,7 +2,7 @@
 Object.defineProperty(exports, Symbol.toStringTag, { value: 'Module' })
 const commonJsonSchemas = require('../../utils/common-json-schemas.js')
 let singleCustomGroupJsonSchema = {
-  elementValuePattern: commonJsonSchemas.elementValuePatternJsonSchema,
-  elementNamePattern: commonJsonSchemas.elementNamePatternJsonSchema,
+  elementValuePattern: commonJsonSchemas.regexJsonSchema,
+  elementNamePattern: commonJsonSchemas.regexJsonSchema,
 }
 exports.singleCustomGroupJsonSchema = singleCustomGroupJsonSchema

package/dist/rules/sort-enums.js

@@ -22,6 +22,7 @@ const isSortable = require('../utils/is-sortable.js')
 const useGroups = require('../utils/use-groups.js')
 const complete = require('../utils/complete.js')
 let defaultOptions = {
+  fallbackSort: { type: 'unsorted' },
   partitionByComment: false,
   partitionByNewLine: false,
   specialCharacters: 'keep',
@@ -251,7 +252,6 @@ const sortEnums = createEslintRule.createEslintRule({
           partitionByComment: commonJsonSchemas.partitionByCommentJsonSchema,
           partitionByNewLine: commonJsonSchemas.partitionByNewLineJsonSchema,
           newlinesBetween: commonJsonSchemas.newlinesBetweenJsonSchema,
-          type: commonJsonSchemas.buildTypeJsonSchema(),
           groups: commonJsonSchemas.groupsJsonSchema,
         },
         additionalProperties: false,

package/dist/rules/sort-exports.js

@@ -13,6 +13,7 @@ const getSettings = require('../utils/get-settings.js')
 const sortNodes = require('../utils/sort-nodes.js')
 const complete = require('../utils/complete.js')
 let defaultOptions = {
+  fallbackSort: { type: 'unsorted' },
   specialCharacters: 'keep',
   partitionByComment: false,
   partitionByNewLine: false,
@@ -119,7 +120,6 @@ const sortExports = createEslintRule.createEslintRule({
           },
           partitionByComment: commonJsonSchemas.partitionByCommentJsonSchema,
           partitionByNewLine: commonJsonSchemas.partitionByNewLineJsonSchema,
-          type: commonJsonSchemas.buildTypeJsonSchema(),
         },
         additionalProperties: false,
         type: 'object',

package/dist/rules/sort-heritage-clauses.js

@@ -15,6 +15,7 @@ const isSortable = require('../utils/is-sortable.js')
 const useGroups = require('../utils/use-groups.js')
 const complete = require('../utils/complete.js')
 let defaultOptions = {
+  fallbackSort: { type: 'unsorted' },
   specialCharacters: 'keep',
   type: 'alphabetical',
   ignoreCase: true,
@@ -31,7 +32,6 @@ const sortHeritageClauses = createEslintRule.createEslintRule({
         properties: {
           ...commonJsonSchemas.commonJsonSchemas,
           customGroups: commonJsonSchemas.customGroupsJsonSchema,
-          type: commonJsonSchemas.buildTypeJsonSchema(),
           groups: commonJsonSchemas.groupsJsonSchema,
         },
         additionalProperties: false,
@@ -58,11 +58,11 @@ const sortHeritageClauses = createEslintRule.createEslintRule({
       defaultOptions,
     )
     validateCustomSortConfiguration.validateCustomSortConfiguration(options)
-    validateGroupsConfiguration.validateGroupsConfiguration(
-      options.groups,
-      ['unknown'],
-      Object.keys(options.customGroups),
-    )
+    validateGroupsConfiguration.validateGroupsConfiguration({
+      allowedCustomGroups: Object.keys(options.customGroups),
+      allowedPredefinedGroups: ['unknown'],
+      options,
+    })
     return {
       TSInterfaceDeclaration: declaration =>
         sortHeritageClauses$1(context, options, declaration.extends),

package/dist/rules/sort-imports.js

@@ -39,6 +39,7 @@ const sortImports = createEslintRule.createEslintRule({
           'unknown',
         ],
         customGroups: { value: {}, type: {} },
+        fallbackSort: { type: 'unsorted' },
         internalPattern: ['^~/.+'],
         partitionByComment: false,
         partitionByNewLine: false,
@@ -53,9 +54,8 @@ const sortImports = createEslintRule.createEslintRule({
         order: 'asc',
       }),
     )
-    validateGroupsConfiguration.validateGroupsConfiguration(
-      options.groups,
-      [
+    validateGroupsConfiguration.validateGroupsConfiguration({
+      allowedPredefinedGroups: [
         'side-effect-style',
         'external-type',
         'internal-type',
@@ -75,11 +75,12 @@ const sortImports = createEslintRule.createEslintRule({
         'style',
         'type',
       ],
-      [
+      allowedCustomGroups: [
         ...Object.keys(options.customGroups.type ?? {}),
         ...Object.keys(options.customGroups.value ?? {}),
       ],
-    )
+      options,
+    })
     validateCustomSortConfiguration.validateCustomSortConfiguration(options)
     validateNewlinesAndPartitionConfiguration.validateNewlinesAndPartitionConfiguration(
       options,
@@ -428,13 +429,6 @@ const sortImports = createEslintRule.createEslintRule({
             additionalProperties: false,
             type: 'object',
           },
-          internalPattern: {
-            description: 'Specifies the pattern for internal modules.',
-            items: {
-              type: 'string',
-            },
-            type: 'array',
-          },
           maxLineLength: {
             description: 'Specifies the maximum line length.',
             exclusiveMinimum: true,
@@ -458,7 +452,7 @@ const sortImports = createEslintRule.createEslintRule({
           partitionByComment: commonJsonSchemas.partitionByCommentJsonSchema,
           partitionByNewLine: commonJsonSchemas.partitionByNewLineJsonSchema,
           newlinesBetween: commonJsonSchemas.newlinesBetweenJsonSchema,
-          type: commonJsonSchemas.buildTypeJsonSchema(),
+          internalPattern: commonJsonSchemas.regexJsonSchema,
           groups: commonJsonSchemas.groupsJsonSchema,
         },
         definitions: {

package/dist/rules/sort-interfaces.js

@@ -3,6 +3,7 @@ const reportErrors = require('../utils/report-errors.js')
 const sortObjectTypes = require('./sort-object-types.js')
 const createEslintRule = require('../utils/create-eslint-rule.js')
 let defaultOptions = {
+  fallbackSort: { type: 'unsorted' },
   partitionByComment: false,
   partitionByNewLine: false,
   newlinesBetween: 'ignore',

package/dist/rules/sort-intersection-types.js

@@ -3,6 +3,7 @@ const reportErrors = require('../utils/report-errors.js')
 const sortUnionTypes = require('./sort-union-types.js')
 const createEslintRule = require('../utils/create-eslint-rule.js')
 let defaultOptions = {
+  fallbackSort: { type: 'unsorted' },
   specialCharacters: 'keep',
   newlinesBetween: 'ignore',
   partitionByComment: false,