eslint-plugin-perfectionist 3.0.0 → 3.1.1

package/dist/index.d.ts

@@ -1,7 +1,5 @@
 import { ClassicConfig } from '@typescript-eslint/utils/ts-eslint'
 import { FlatConfig } from '@typescript-eslint/utils/ts-eslint'
-import { ObjectExpression } from 'node_modules/@typescript-eslint/types/dist/generated/ast-spec'
-import { ObjectPattern } from 'node_modules/@typescript-eslint/types/dist/generated/ast-spec'
 import { RuleListener } from '@typescript-eslint/utils/ts-eslint'
 import { RuleModule } from '@typescript-eslint/utils/ts-eslint'
 
@@ -24,6 +22,7 @@ declare const _default: {
           ignoreCase: boolean
         }>,
       ],
+      unknown,
       RuleListener
     >
     'sort-intersection-types': RuleModule<
@@ -67,6 +66,7 @@ declare const _default: {
           ignoreCase: boolean
         }>,
       ],
+      unknown,
       RuleListener
     >
     'sort-svelte-attributes': RuleModule<
@@ -82,6 +82,7 @@ declare const _default: {
           ignoreCase: boolean
         }>,
       ],
+      unknown,
       RuleListener
     >
     'sort-astro-attributes': RuleModule<
@@ -97,6 +98,7 @@ declare const _default: {
           ignoreCase: boolean
         }>,
       ],
+      unknown,
       RuleListener
     >
     'sort-vue-attributes': RuleModule<
@@ -112,6 +114,7 @@ declare const _default: {
           ignoreCase: boolean
         }>,
       ],
+      unknown,
       RuleListener
     >
     'sort-array-includes': RuleModule<
@@ -124,6 +127,7 @@ declare const _default: {
           ignoreCase: boolean
         }>,
       ],
+      unknown,
       RuleListener
     >
     'sort-named-imports': RuleModule<
@@ -137,6 +141,7 @@ declare const _default: {
           ignoreCase: boolean
         }>,
       ],
+      unknown,
       RuleListener
     >
     'sort-named-exports': RuleModule<
@@ -149,6 +154,7 @@ declare const _default: {
           ignoreCase: boolean
         }>,
       ],
+      unknown,
       RuleListener
     >
     'sort-object-types': RuleModule<
@@ -164,6 +170,7 @@ declare const _default: {
           customGroups: {}
         }>,
       ],
+      unknown,
       RuleListener
     >
     'sort-union-types': RuleModule<
@@ -207,6 +214,7 @@ declare const _default: {
           ignoreCase: boolean
         }>,
       ],
+      unknown,
       RuleListener
     >
     'sort-switch-case': RuleModule<
@@ -218,6 +226,7 @@ declare const _default: {
           ignoreCase: boolean
         }>,
       ],
+      unknown,
       RuleListener
     >
     'sort-interfaces': RuleModule<
@@ -236,6 +245,7 @@ declare const _default: {
           ignoreCase: boolean
         }>,
       ],
+      unknown,
       RuleListener
     >
     'sort-jsx-props': RuleModule<
@@ -252,6 +262,7 @@ declare const _default: {
           ignoreCase: boolean
         }>,
       ],
+      unknown,
       RuleListener
     >
     'sort-classes': RuleModule<
@@ -268,6 +279,7 @@ declare const _default: {
           ignoreCase: boolean
         }>,
       ],
+      unknown,
       RuleListener
     >
     'sort-imports': RuleModule<
@@ -298,6 +310,7 @@ declare const _default: {
           ignoreCase: boolean
         }>,
       ],
+      unknown,
       RuleListener
     >
     'sort-exports': RuleModule<
@@ -309,16 +322,13 @@ declare const _default: {
           ignoreCase: boolean
         }>,
       ],
+      unknown,
       RuleListener
     >
     'sort-objects': RuleModule<
       'unexpectedObjectsOrder',
       [
         Partial<{
-          customIgnore: ((
-            object: ObjectExpression | ObjectPattern,
-            filename: string,
-          ) => boolean)[]
           customGroups: {
             [key: string]: string[] | string
           }
@@ -327,11 +337,13 @@ declare const _default: {
           groups: (string[] | string)[]
           partitionByNewLine: boolean
           styledComponents: boolean
+          destructureOnly: boolean
           ignorePattern: string[]
           order: 'desc' | 'asc'
           ignoreCase: boolean
         }>,
       ],
+      unknown,
       RuleListener
     >
     'sort-enums': RuleModule<
@@ -344,6 +356,7 @@ declare const _default: {
           ignoreCase: boolean
         }>,
       ],
+      unknown,
       RuleListener
     >
     'sort-maps': RuleModule<
@@ -355,6 +368,7 @@ declare const _default: {
           ignoreCase: boolean
         }>,
       ],
+      unknown,
       RuleListener
     >
   }

package/dist/rules/sort-array-includes.js

@@ -95,8 +95,8 @@ const sortArrayIncludes = createEslintRule.createEslintRule({
                         ? `${element.value}`
                         : sourceCode.text.slice(...element.range),
                     size: rangeToDiff.rangeToDiff(element.range),
+                    node: structuredClone(element),
                     type: element.type,
-                    node: element,
                     group,
                   })
                 }

package/dist/rules/sort-array-includes.mjs

@@ -94,8 +94,8 @@ const sortArrayIncludes = createEslintRule({
                         ? `${element.value}`
                         : sourceCode.text.slice(...element.range),
                     size: rangeToDiff(element.range),
+                    node: structuredClone(element),
                     type: element.type,
-                    node: element,
                     group,
                   })
                 }

package/dist/rules/sort-astro-attributes.js

@@ -132,8 +132,8 @@ const sortAstroAttributes = createEslintRule.createEslintRule({
                 defineGroup('multiline')
               }
               accumulator.at(-1).push({
+                node: structuredClone(attribute),
                 size: rangeToDiff.rangeToDiff(attribute.range),
-                node: attribute,
                 group: getGroup(),
                 name,
               })

package/dist/rules/sort-astro-attributes.mjs

@@ -132,8 +132,8 @@ const sortAstroAttributes = createEslintRule({
                 defineGroup('multiline')
               }
               accumulator.at(-1).push({
+                node: structuredClone(attribute),
                 size: rangeToDiff(attribute.range),
-                node: attribute,
                 group: getGroup(),
                 name,
               })

package/dist/rules/sort-classes.js

@@ -110,10 +110,12 @@ const sortClasses = createEslintRule.createEslintRule({
       groups: [
         'index-signature',
         'static-property',
+        'protected-property',
         'private-property',
         'property',
         'constructor',
         'static-method',
+        'protected-method',
         'private-method',
         'method',
         ['get-method', 'set-method'],
@@ -129,10 +131,12 @@ const sortClasses = createEslintRule.createEslintRule({
           groups: [
             'index-signature',
             'static-property',
+            'protected-property',
             'private-property',
             'property',
             'constructor',
             'static-method',
+            'protected-method',
             'private-method',
             'method',
             ['get-method', 'set-method'],
@@ -224,6 +228,7 @@ const sortClasses = createEslintRule.createEslintRule({
               if (member.kind === 'constructor') {
                 defineGroup('constructor')
               }
+              let isProtectedMethod = member.accessibility === 'protected'
               let isPrivateMethod =
                 member.accessibility === 'private' || isPrivate
               let isStaticMethod = member.static
@@ -245,6 +250,12 @@ const sortClasses = createEslintRule.createEslintRule({
               if (isStaticMethod) {
                 defineGroup('static-method')
               }
+              if (isProtectedMethod && isStaticMethod) {
+                defineGroup('static-protected-method')
+              }
+              if (isProtectedMethod) {
+                defineGroup('protected-method')
+              }
               if (member.kind === 'get') {
                 defineGroup('get-method')
               }
@@ -256,6 +267,9 @@ const sortClasses = createEslintRule.createEslintRule({
               defineGroup('index-signature')
             } else if (member.type === 'AccessorProperty') {
               if (decorated) {
+                if (member.accessibility === 'protected') {
+                  defineGroup('protected-decorated-accessor-property')
+                }
                 if (member.accessibility === 'private' || isPrivate) {
                   defineGroup('private-decorated-accessor-property')
                 }
@@ -263,11 +277,17 @@ const sortClasses = createEslintRule.createEslintRule({
               }
             } else if (member.type === 'PropertyDefinition') {
               if (decorated) {
+                if (member.accessibility === 'protected') {
+                  defineGroup('protected-decorated-property')
+                }
                 if (member.accessibility === 'private' || isPrivate) {
                   defineGroup('private-decorated-property')
                 }
                 defineGroup('decorated-property')
               }
+              if (member.accessibility === 'protected') {
+                defineGroup('protected-property')
+              }
               if (member.accessibility === 'private' || isPrivate) {
                 defineGroup('private-property')
               }
@@ -284,9 +304,9 @@ const sortClasses = createEslintRule.createEslintRule({
             }
             let value = {
               size: rangeToDiff.rangeToDiff(member.range),
+              node: structuredClone(member),
               group: getGroup(),
               dependencies,
-              node: member,
               name,
             }
             accumulator.at(-1).push(value)

package/dist/rules/sort-classes.mjs

@@ -109,10 +109,12 @@ const sortClasses = createEslintRule({
       groups: [
         'index-signature',
         'static-property',
+        'protected-property',
         'private-property',
         'property',
         'constructor',
         'static-method',
+        'protected-method',
         'private-method',
         'method',
         ['get-method', 'set-method'],
@@ -128,10 +130,12 @@ const sortClasses = createEslintRule({
           groups: [
             'index-signature',
             'static-property',
+            'protected-property',
             'private-property',
             'property',
             'constructor',
             'static-method',
+            'protected-method',
             'private-method',
             'method',
             ['get-method', 'set-method'],
@@ -221,6 +225,7 @@ const sortClasses = createEslintRule({
               if (member.kind === 'constructor') {
                 defineGroup('constructor')
               }
+              let isProtectedMethod = member.accessibility === 'protected'
               let isPrivateMethod =
                 member.accessibility === 'private' || isPrivate
               let isStaticMethod = member.static
@@ -242,6 +247,12 @@ const sortClasses = createEslintRule({
               if (isStaticMethod) {
                 defineGroup('static-method')
               }
+              if (isProtectedMethod && isStaticMethod) {
+                defineGroup('static-protected-method')
+              }
+              if (isProtectedMethod) {
+                defineGroup('protected-method')
+              }
               if (member.kind === 'get') {
                 defineGroup('get-method')
               }
@@ -253,6 +264,9 @@ const sortClasses = createEslintRule({
               defineGroup('index-signature')
             } else if (member.type === 'AccessorProperty') {
               if (decorated) {
+                if (member.accessibility === 'protected') {
+                  defineGroup('protected-decorated-accessor-property')
+                }
                 if (member.accessibility === 'private' || isPrivate) {
                   defineGroup('private-decorated-accessor-property')
                 }
@@ -260,11 +274,17 @@ const sortClasses = createEslintRule({
               }
             } else if (member.type === 'PropertyDefinition') {
               if (decorated) {
+                if (member.accessibility === 'protected') {
+                  defineGroup('protected-decorated-property')
+                }
                 if (member.accessibility === 'private' || isPrivate) {
                   defineGroup('private-decorated-property')
                 }
                 defineGroup('decorated-property')
               }
+              if (member.accessibility === 'protected') {
+                defineGroup('protected-property')
+              }
               if (member.accessibility === 'private' || isPrivate) {
                 defineGroup('private-property')
               }
@@ -281,9 +301,9 @@ const sortClasses = createEslintRule({
             }
             let value = {
               size: rangeToDiff(member.range),
+              node: structuredClone(member),
               group: getGroup(),
               dependencies,
-              node: member,
               name,
             }
             accumulator.at(-1).push(value)

package/dist/rules/sort-enums.js

@@ -75,9 +75,13 @@ const sortEnums = createEslintRule.createEslintRule({
   ],
   create: context => ({
     TSEnumDeclaration: node => {
+      let getMembers = nodeValue =>
+        /* v8 ignore next 2 */
+        // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
+        node.body.members || nodeValue.members
       if (
-        node.members.length > 1 &&
-        node.members.every(({ initializer }) => initializer)
+        getMembers(node).length > 1 &&
+        getMembers(node).every(({ initializer }) => initializer)
       ) {
         let options = complete.complete(context.options.at(0), {
           partitionByComment: false,
@@ -87,7 +91,7 @@ const sortEnums = createEslintRule.createEslintRule({
         })
         let sourceCode = getSourceCode.getSourceCode(context)
         let partitionComment = options.partitionByComment
-        let formattedMembers = node.members.reduce(
+        let formattedMembers = getMembers(node).reduce(
           (accumulator, member) => {
             let comment = getCommentBefore.getCommentBefore(member, sourceCode)
             if (
@@ -105,9 +109,9 @@ const sortEnums = createEslintRule.createEslintRule({
                 ? `${member.id.value}`
                 : `${sourceCode.text.slice(...member.id.range)}`
             let sortingNode = {
-              name,
-              node: member,
               size: rangeToDiff.rangeToDiff(member.range),
+              node: structuredClone(member),
+              name,
             }
             accumulator.at(-1).push(sortingNode)
             return accumulator

package/dist/rules/sort-enums.mjs

@@ -74,9 +74,13 @@ const sortEnums = createEslintRule({
   ],
   create: context => ({
     TSEnumDeclaration: node => {
+      let getMembers = nodeValue =>
+        /* v8 ignore next 2 */
+        // eslint-disable-next-line @typescript-eslint/no-unnecessary-condition
+        node.body.members || nodeValue.members
       if (
-        node.members.length > 1 &&
-        node.members.every(({ initializer }) => initializer)
+        getMembers(node).length > 1 &&
+        getMembers(node).every(({ initializer }) => initializer)
       ) {
         let options = complete(context.options.at(0), {
           partitionByComment: false,
@@ -86,7 +90,7 @@ const sortEnums = createEslintRule({
         })
         let sourceCode = getSourceCode(context)
         let partitionComment = options.partitionByComment
-        let formattedMembers = node.members.reduce(
+        let formattedMembers = getMembers(node).reduce(
           (accumulator, member) => {
             let comment = getCommentBefore(member, sourceCode)
             if (
@@ -101,9 +105,9 @@ const sortEnums = createEslintRule({
                 ? `${member.id.value}`
                 : `${sourceCode.text.slice(...member.id.range)}`
             let sortingNode = {
-              name,
-              node: member,
               size: rangeToDiff(member.range),
+              node: structuredClone(member),
+              name,
             }
             accumulator.at(-1).push(sortingNode)
             return accumulator

package/dist/rules/sort-exports.js

@@ -61,8 +61,8 @@ const sortExports = createEslintRule.createEslintRule({
     let registerNode = node => {
       parts.at(-1).push({
         size: rangeToDiff.rangeToDiff(node.range),
+        node: structuredClone(node),
         name: node.source.value,
-        node,
       })
     }
     return {

package/dist/rules/sort-exports.mjs

@@ -60,8 +60,8 @@ const sortExports = createEslintRule({
     let registerNode = node => {
       parts.at(-1).push({
         size: rangeToDiff(node.range),
+        node: structuredClone(node),
         name: node.source.value,
-        node,
       })
     }
     return {

package/dist/rules/sort-imports.js

@@ -245,10 +245,14 @@ const sortImports = createEslintRule.createEslintRule({
           'undici',
           'ws',
         ]
+        let builtinPrefixOnlyModules = ['sea', 'sqlite', 'test']
         return (
           node_module.builtinModules.includes(
             value.startsWith('node:') ? value.split('node:')[1] : value,
           ) ||
+          builtinPrefixOnlyModules.some(
+            module2 => `node:${module2}` === value,
+          ) ||
           (options.environment === 'bun' ? bunModules.includes(value) : false)
         )
       }
@@ -282,10 +286,14 @@ const sortImports = createEslintRule.createEslintRule({
         node.type === 'ImportDeclaration' ||
         node.type === 'VariableDeclaration'
       ) {
-        let value =
-          node.type === 'ImportDeclaration'
-            ? node.source.value
-            : node.declarations[0].init.arguments[0].value.toString().toString()
+        let value
+        if (node.type === 'ImportDeclaration') {
+          ;({ value } = node.source)
+        } else {
+          let decl = node.declarations[0].init
+          let declValue = decl.arguments[0].value
+          value = declValue.toString()
+        }
         setCustomGroups(options.customGroups.value, value)
         if (isSideEffectImport(node) && isStyle(value)) {
           defineGroup('side-effect-style')
@@ -330,13 +338,14 @@ const sortImports = createEslintRule.createEslintRule({
         }
       } else {
         let decl = node.declarations[0].init
-        name = decl.arguments[0].value.toString()
+        let { value } = decl.arguments[0]
+        name = value.toString()
       }
       nodes.push({
         size: rangeToDiff.rangeToDiff(node.range),
+        node: structuredClone(node),
         group: computeGroup(node),
         name,
-        node,
         ...(options.type === 'line-length' &&
           options.maxLineLength && {
             hasMultipleImportDeclarations: hasMultipleImportDeclarations(node),
@@ -347,11 +356,15 @@ const sortImports = createEslintRule.createEslintRule({
       TSImportEqualsDeclaration: registerNode,
       ImportDeclaration: registerNode,
       VariableDeclaration: node => {
+        var _a
         if (
           node.declarations[0].init &&
           node.declarations[0].init.type === 'CallExpression' &&
           node.declarations[0].init.callee.type === 'Identifier' &&
-          node.declarations[0].init.callee.name === 'require'
+          node.declarations[0].init.callee.name === 'require' &&
+          ((_a = node.declarations[0].init.arguments[0]) == null
+            ? void 0
+            : _a.type) === 'Literal'
         ) {
           registerNode(node)
         }
@@ -387,7 +400,7 @@ const sortImports = createEslintRule.createEslintRule({
               (accumulator, group) => [...accumulator, ...grouped[group]],
               [],
             )
-          for (let i = 0, max = formatted.length; i < max; i++) {
+          for (let max = formatted.length, i = 0; i < max; i++) {
             let node = formatted.at(i)
             fixes.push(
               fixer.replaceTextRange(

package/dist/rules/sort-imports.mjs

@@ -242,10 +242,12 @@ const sortImports = createEslintRule({
           'undici',
           'ws',
         ]
+        let builtinPrefixOnlyModules = ['sea', 'sqlite', 'test']
         return (
           builtinModules.includes(
             value.startsWith('node:') ? value.split('node:')[1] : value,
           ) ||
+          builtinPrefixOnlyModules.some(module => `node:${module}` === value) ||
           (options.environment === 'bun' ? bunModules.includes(value) : false)
         )
       }
@@ -279,10 +281,14 @@ const sortImports = createEslintRule({
         node.type === 'ImportDeclaration' ||
         node.type === 'VariableDeclaration'
       ) {
-        let value =
-          node.type === 'ImportDeclaration'
-            ? node.source.value
-            : node.declarations[0].init.arguments[0].value.toString().toString()
+        let value
+        if (node.type === 'ImportDeclaration') {
+          ;({ value } = node.source)
+        } else {
+          let decl = node.declarations[0].init
+          let declValue = decl.arguments[0].value
+          value = declValue.toString()
+        }
         setCustomGroups(options.customGroups.value, value)
         if (isSideEffectImport(node) && isStyle(value)) {
           defineGroup('side-effect-style')
@@ -327,13 +333,14 @@ const sortImports = createEslintRule({
         }
       } else {
         let decl = node.declarations[0].init
-        name = decl.arguments[0].value.toString()
+        let { value } = decl.arguments[0]
+        name = value.toString()
       }
       nodes.push({
         size: rangeToDiff(node.range),
+        node: structuredClone(node),
         group: computeGroup(node),
         name,
-        node,
         ...(options.type === 'line-length' &&
           options.maxLineLength && {
             hasMultipleImportDeclarations: hasMultipleImportDeclarations(node),
@@ -344,11 +351,15 @@ const sortImports = createEslintRule({
       TSImportEqualsDeclaration: registerNode,
       ImportDeclaration: registerNode,
       VariableDeclaration: node => {
+        var _a
         if (
           node.declarations[0].init &&
           node.declarations[0].init.type === 'CallExpression' &&
           node.declarations[0].init.callee.type === 'Identifier' &&
-          node.declarations[0].init.callee.name === 'require'
+          node.declarations[0].init.callee.name === 'require' &&
+          ((_a = node.declarations[0].init.arguments[0]) == null
+            ? void 0
+            : _a.type) === 'Literal'
         ) {
           registerNode(node)
         }
@@ -383,7 +394,7 @@ const sortImports = createEslintRule({
               (accumulator, group) => [...accumulator, ...grouped[group]],
               [],
             )
-          for (let i = 0, max = formatted.length; i < max; i++) {
+          for (let max = formatted.length, i = 0; i < max; i++) {
             let node = formatted.at(i)
             fixes.push(
               fixer.replaceTextRange(

package/dist/rules/sort-interfaces.js

@@ -176,7 +176,7 @@ const sortInterfaces = createEslintRule.createEslintRule({
               }
               let elementSortingNode = {
                 size: rangeToDiff.rangeToDiff(element.range),
-                node: element,
+                node: structuredClone(element),
                 name,
               }
               if (

package/dist/rules/sort-interfaces.mjs

@@ -176,7 +176,7 @@ const sortInterfaces = createEslintRule({
               }
               let elementSortingNode = {
                 size: rangeToDiff(element.range),
-                node: element,
+                node: structuredClone(element),
                 name,
               }
               if (

package/dist/rules/sort-intersection-types.js

@@ -145,8 +145,8 @@ const sortIntersectionTypes = createEslintRule.createEslintRule({
         return {
           name: sourceCode.text.slice(...type.range),
           size: rangeToDiff.rangeToDiff(type.range),
+          node: structuredClone(type),
           group: getGroup(),
-          node: type,
         }
       })
       pairwise.pairwise(nodes, (left, right) => {

package/dist/rules/sort-intersection-types.mjs

@@ -144,8 +144,8 @@ const sortIntersectionTypes = createEslintRule({
         return {
           name: sourceCode.text.slice(...type.range),
           size: rangeToDiff(type.range),
+          node: structuredClone(type),
           group: getGroup(),
-          node: type,
         }
       })
       pairwise(nodes, (left, right) => {