eslint-plugin-package-json 0.76.0 → 0.78.0

package/CHANGELOG.md

@@ -1,11 +1,23 @@
 # Changelog
 
-# [0.76.0](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/compare/v0.75.0...v0.76.0) (2025-11-15)
+# [0.78.0](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/compare/v0.77.0...v0.78.0) (2025-11-15)
+
+
+### Features
+
+* **valid-repository:** add new rule for validating `repository` ([#1393](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues/1393)) ([2b38e88](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/commit/2b38e881f60d357f9f73ad7a1aff159682542c42)), closes [#838](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues/838)
 
+# [0.77.0](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/compare/v0.76.0...v0.77.0) (2025-11-15)
+
+### Features
+
+- **unique-dependencies:** report cross-group duplicates ([#1398](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues/1398)) ([94b690e](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/commit/94b690e1996ec271ba743225ccecf66691f97e01)), closes [#1007](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues/1007)
+
+# [0.76.0](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/compare/v0.75.0...v0.76.0) (2025-11-15)
 
 ### Features
 
-* **valid-engines:** add new rule for validating `engines` ([#1397](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues/1397)) ([ba834f0](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/commit/ba834f00651b64f2bc0cf58cf41d768bd6cee5eb)), closes [#826](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues/826)
+- **valid-engines:** add new rule for validating `engines` ([#1397](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues/1397)) ([ba834f0](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/commit/ba834f00651b64f2bc0cf58cf41d768bd6cee5eb)), closes [#826](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues/826)
 
 # [0.75.0](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/compare/v0.73.0...v0.75.0) (2025-11-15)
 

package/README.md

@@ -237,6 +237,7 @@ The default settings don't conflict, and Prettier plugins can quickly fix up ord
 | [valid-peerDependencies](docs/rules/valid-peerDependencies.md)             | Enforce that the `peerDependencies` property is valid.                                                      | ✔️ ✅ |    |    |    |
 | [valid-private](docs/rules/valid-private.md)                               | Enforce that the `private` property is valid.                                                               | ✔️ ✅ |    |    |    |
 | [valid-publishConfig](docs/rules/valid-publishConfig.md)                   | Enforce that the `publishConfig` property is valid.                                                         | ✔️ ✅ |    |    |    |
+| [valid-repository](docs/rules/valid-repository.md)                         | Enforce that the `repository` property is valid.                                                            | ✔️ ✅ |    |    |    |
 | [valid-repository-directory](docs/rules/valid-repository-directory.md)     | Enforce that if repository directory is specified, it matches the path to the package.json file             | ✔️ ✅ |    | 💡 |    |
 | [valid-scripts](docs/rules/valid-scripts.md)                               | Enforce that the `scripts` property is valid.                                                               | ✔️ ✅ |    |    |    |
 | [valid-type](docs/rules/valid-type.md)                                     | Enforce that the `type` property is valid.                                                                  | ✔️ ✅ |    |    |    |

package/lib/rules/unique-dependencies.mjs

@@ -14,6 +14,12 @@ const dependencyPropertyNames = new Set([
 ]);
 const rule = createRule({
 	create(context) {
+		const dependenciesCache = {
+			dependencies: [],
+			devDependencies: [],
+			peerDependencies: []
+		};
+		const trackForCrossGroupUniqueness = Object.keys(dependenciesCache);
 		function check(elements, getNodeToRemove) {
 			const seen = /* @__PURE__ */ new Set();
 			for (const element of elements.filter(isNotNullish).filter(isJSONStringLiteral).reverse()) if (seen.has(element.value)) report(element, elements);
@@ -30,17 +36,38 @@ const rule = createRule({
 				});
 			}
 		}
-		return { "Program > JSONExpressionStatement > JSONObjectExpression > JSONProperty[key.type=JSONLiteral]"(node) {
-			if (!dependencyPropertyNames.has(node.key.value)) return;
-			switch (node.value.type) {
-				case "JSONArrayExpression":
-					check(node.value.elements, (element) => element);
-					break;
-				case "JSONObjectExpression":
-					check(node.value.properties.map((property) => property.key), (property) => property.parent);
-					break;
+		return {
+			"Program > JSONExpressionStatement > JSONObjectExpression > JSONProperty[key.type=JSONLiteral]"(node) {
+				if (!dependencyPropertyNames.has(node.key.value)) return;
+				switch (node.value.type) {
+					case "JSONArrayExpression":
+						check(node.value.elements, (element) => element);
+						break;
+					case "JSONObjectExpression":
+						check(node.value.properties.map((property) => property.key), (property) => property.parent);
+						if (trackForCrossGroupUniqueness.includes(node.key.value)) dependenciesCache[node.key.value] = node.value.properties;
+						break;
+				}
+			},
+			"Program:exit"() {
+				const dependencyNames = new Set(dependenciesCache.dependencies.map((node) => node.key).filter(isJSONStringLiteral).map((dependencyNameNode) => dependencyNameNode.value));
+				if (!dependencyNames.size) return;
+				for (const dependencyType of ["devDependencies", "peerDependencies"]) {
+					const otherDependencies = dependenciesCache[dependencyType];
+					for (const otherDependencyNode of otherDependencies) {
+						const otherDependencyKey = otherDependencyNode.key;
+						if (isJSONStringLiteral(otherDependencyKey) && dependencyNames.has(otherDependencyKey.value)) context.report({
+							messageId: "crossGroupDuplicate",
+							node: otherDependencyNode,
+							suggest: [{
+								fix: fixRemoveObjectProperty(context, otherDependencyNode),
+								messageId: "remove"
+							}]
+						});
+					}
+				}
 			}
-		} };
+		};
 	},
 	meta: {
 		docs: {
@@ -50,8 +77,9 @@ const rule = createRule({
 		},
 		hasSuggestions: true,
 		messages: {
-			overridden: "Package name is overridden by a duplicate listing later on.",
-			remove: "Remove this redundant dependency listing."
+			crossGroupDuplicate: "Dependency is also declared in \"dependencies\" and is redundant",
+			overridden: "Dependency is overridden by a duplicate entry later on",
+			remove: "Remove this redundant dependency"
 		},
 		schema: [],
 		type: "suggestion"

package/lib/rules/valid-properties.mjs

@@ -1,5 +1,5 @@
 import { createSimpleValidPropertyRule } from "../utils/createSimpleValidPropertyRule.mjs";
-import { validateAuthor, validateBin, validateBundleDependencies, validateConfig, validateContributors, validateCpu, validateDependencies, validateDescription, validateDirectories, validateEngines, validateExports, validateFiles, validateHomepage, validateKeywords, validateLicense, validateMain, validateMan, validateOs, validatePrivate, validatePublishConfig, validateScripts, validateType, validateWorkspaces } from "package-json-validator";
+import { validateAuthor, validateBin, validateBundleDependencies, validateConfig, validateContributors, validateCpu, validateDependencies, validateDescription, validateDirectories, validateEngines, validateExports, validateFiles, validateHomepage, validateKeywords, validateLicense, validateMain, validateMan, validateOs, validatePrivate, validatePublishConfig, validateRepository, validateScripts, validateType, validateWorkspaces } from "package-json-validator";
 
 //#region src/rules/valid-properties.ts
 const properties = [
@@ -29,6 +29,7 @@ const properties = [
 	["peerDependencies", validateDependencies],
 	["private", validatePrivate],
 	["publishConfig", validatePublishConfig],
+	["repository", validateRepository],
 	["scripts", validateScripts],
 	["type", validateType],
 	["workspaces", validateWorkspaces]

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "eslint-plugin-package-json",
-	"version": "0.76.0",
+	"version": "0.78.0",
 	"description": "Rules for consistent, readable, and valid package.json files. 🗂️",
 	"homepage": "https://github.com/JoshuaKGoldberg/eslint-plugin-package-json#readme",
 	"bugs": {