eslint-plugin-package-json 0.59.1 → 0.60.0

package/CHANGELOG.md

@@ -1,11 +1,17 @@
 # Changelog
 
-## [0.59.1](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/compare/v0.59.0...v0.59.1) (2025-10-30)
+# [0.60.0](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/compare/v0.59.1...v0.60.0) (2025-11-03)
+
+
+### Features
+
+* **valid-author:** create more precise reports ([#1337](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues/1337)) ([e79ff9a](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/commit/e79ff9ac602d85bf999686b018de6ace3a7bee36)), closes [#000](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues/000)
 
+## [0.59.1](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/compare/v0.59.0...v0.59.1) (2025-10-30)
 
 ### Bug Fixes
 
-* **deps:** update dependency validate-npm-package-name to v7 ([#1353](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues/1353)) ([be9970a](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/commit/be9970a18c73521906d1564ca461d94159e88807))
+- **deps:** update dependency validate-npm-package-name to v7 ([#1353](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues/1353)) ([be9970a](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/commit/be9970a18c73521906d1564ca461d94159e88807))
 
 # [0.59.0](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/compare/v0.58.0...v0.59.0) (2025-10-25)
 

package/lib/plugin.js

@@ -7,13 +7,14 @@ import { rules } from "./rules/require-properties.js";
 import { rule as rule$5 } from "./rules/restrict-dependency-ranges.js";
 import { rule as rule$6 } from "./rules/sort-collections.js";
 import { rule as rule$7 } from "./rules/unique-dependencies.js";
-import { rule as rule$8 } from "./rules/valid-bin.js";
-import { rule as rule$9 } from "./rules/valid-local-dependency.js";
-import { rule as rule$10 } from "./rules/valid-name.js";
-import { rule as rule$11 } from "./rules/valid-package-definition.js";
+import { rule as rule$8 } from "./rules/valid-author.js";
+import { rule as rule$9 } from "./rules/valid-bin.js";
+import { rule as rule$10 } from "./rules/valid-local-dependency.js";
+import { rule as rule$11 } from "./rules/valid-name.js";
+import { rule as rule$12 } from "./rules/valid-package-definition.js";
 import { rules as rules$1 } from "./rules/valid-properties.js";
-import { rule as rule$12 } from "./rules/valid-repository-directory.js";
-import { rule as rule$13 } from "./rules/valid-version.js";
+import { rule as rule$13 } from "./rules/valid-repository-directory.js";
+import { rule as rule$14 } from "./rules/valid-version.js";
 import { createRequire } from "node:module";
 import * as parserJsonc from "jsonc-eslint-parser";
 
@@ -30,14 +31,15 @@ const rules$2 = {
 	"sort-collections": rule$6,
 	"unique-dependencies": rule$7,
 	...rules$1,
-	"valid-bin": rule$8,
-	"valid-local-dependency": rule$9,
-	"valid-name": rule$10,
-	"valid-package-definition": rule$11,
-	"valid-repository-directory": rule$12,
-	"valid-version": rule$13
+	"valid-author": rule$8,
+	"valid-bin": rule$9,
+	"valid-local-dependency": rule$10,
+	"valid-name": rule$11,
+	"valid-package-definition": rule$12,
+	"valid-repository-directory": rule$13,
+	"valid-version": rule$14
 };
-const baseRecommendedRules = { ...Object.fromEntries(Object.entries(rules$2).filter(([, rule$14]) => rule$14.meta.docs?.recommended).map(([name$1]) => ["package-json/" + name$1, "error"])) };
+const baseRecommendedRules = { ...Object.fromEntries(Object.entries(rules$2).filter(([, rule$15]) => rule$15.meta.docs?.recommended).map(([name$1]) => ["package-json/" + name$1, "error"])) };
 const recommendedRules = {
 	...baseRecommendedRules,
 	"package-json/valid-package-definition": ["error", { ignoreProperties: Object.entries(baseRecommendedRules).filter(([name$1]) => name$1.startsWith("package-json/valid-") && name$1 !== "package-json/valid-package-definition").map(([name$1]) => name$1.replace("package-json/valid-", "")) }]

package/lib/rules/valid-author.d.ts

@@ -0,0 +1,6 @@
+import { PackageJsonRuleModule } from "../createRule.js";
+
+//#region src/rules/valid-author.d.ts
+declare const rule: PackageJsonRuleModule<[], []>;
+//#endregion
+export { rule };

package/lib/rules/valid-author.js

@@ -0,0 +1,39 @@
+import { createRule } from "../createRule.js";
+import { validateAuthor } from "package-json-validator";
+
+//#region src/rules/valid-author.ts
+const rule = createRule({
+	create(context) {
+		const reportIssues = (result, node) => {
+			if (result.errorMessages.length === 0) return;
+			if (result.issues.length) for (const issue of result.issues) context.report({
+				data: { error: issue.message },
+				messageId: "validationError",
+				node
+			});
+			const childrenWithIssues = result.childResults.filter((childResult) => childResult.errorMessages.length);
+			if (node.type === "JSONObjectExpression" && childrenWithIssues.length) for (const childResult of childrenWithIssues) {
+				const childNode = node.properties[childResult.index];
+				reportIssues(childResult, childNode);
+			}
+		};
+		return { "Program > JSONExpressionStatement > JSONObjectExpression > JSONProperty[key.value=author]"(node) {
+			const valueNode = node.value;
+			reportIssues(validateAuthor(JSON.parse(context.sourceCode.getText(valueNode))), valueNode);
+		} };
+	},
+	meta: {
+		docs: {
+			category: "Best Practices",
+			description: "Enforce that the `author` property is valid.",
+			recommended: true
+		},
+		messages: { validationError: `Invalid author: {{ error }}` },
+		schema: [],
+		type: "problem"
+	},
+	name: "valid-author"
+});
+
+//#endregion
+export { rule };

package/lib/rules/valid-bin.js

@@ -1,7 +1,7 @@
 import { createRule } from "../createRule.js";
 import { formatErrors } from "../utils/formatErrors.js";
-import { kebabCase } from "change-case";
 import { validateBin } from "package-json-validator";
+import { kebabCase } from "change-case";
 
 //#region src/rules/valid-bin.ts
 const rule = createRule({

package/lib/rules/valid-properties.js

@@ -1,9 +1,8 @@
 import { createSimpleValidPropertyRule } from "../utils/createSimpleValidPropertyRule.js";
-import { validateAuthor, validateBundleDependencies, validateConfig, validateCpu, validateDependencies, validateDescription, validateDirectories, validateExports, validateLicense, validateScripts, validateType } from "package-json-validator";
+import { validateBundleDependencies, validateConfig, validateCpu, validateDependencies, validateDescription, validateDirectories, validateExports, validateLicense, validateScripts, validateType } from "package-json-validator";
 
 //#region src/rules/valid-properties.ts
 const properties = [
-	["author", validateAuthor],
 	["bundleDependencies", {
 		aliases: ["bundledDependencies"],
 		validator: validateBundleDependencies

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "eslint-plugin-package-json",
-	"version": "0.59.1",
+	"version": "0.60.0",
 	"description": "Rules for consistent, readable, and valid package.json files. 🗂️",
 	"homepage": "https://github.com/JoshuaKGoldberg/eslint-plugin-package-json#readme",
 	"bugs": {
@@ -48,7 +48,7 @@
 		"detect-indent": "^7.0.2",
 		"detect-newline": "^4.0.1",
 		"eslint-fix-utils": "~0.4.0",
-		"package-json-validator": "~0.31.0",
+		"package-json-validator": "~0.32.1",
 		"semver": "^7.7.3",
 		"sort-object-keys": "^2.0.0",
 		"sort-package-json": "^3.4.0",
@@ -67,7 +67,7 @@
 		"console-fail-test": "0.5.0",
 		"eslint": "9.38.0",
 		"eslint-doc-generator": "2.3.0",
-		"eslint-plugin-eslint-plugin": "7.0.0",
+		"eslint-plugin-eslint-plugin": "7.2.0",
 		"eslint-plugin-jsdoc": "61.1.0",
 		"eslint-plugin-jsonc": "2.21.0",
 		"eslint-plugin-n": "17.23.1",