eslint-plugin-package-json 0.42.1 → 0.43.1

package/CHANGELOG.md

@@ -1,11 +1,23 @@
 # Changelog
 
-## [0.42.1](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/compare/v0.42.0...v0.42.1) (2025-07-01)
+## [0.43.1](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/compare/v0.43.0...v0.43.1) (2025-07-03)
+
+
+### Bug Fixes
+
+* disallow extra properties in rule options ([#1156](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues/1156)) ([4186e96](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/commit/4186e960c17a5397ac916184fc4341f9b26fc3d0))
 
+# [0.43.0](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/compare/v0.42.1...v0.43.0) (2025-07-02)
+
+### Features
+
+- **valid-scripts:** add new rule for validating scripts ([#1138](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues/1138)) ([99cc2a5](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/commit/99cc2a5d069bfff53885f0717b8a635767cb2c19)), closes [#839](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues/839)
+
+## [0.42.1](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/compare/v0.42.0...v0.42.1) (2025-07-01)
 
 ### Bug Fixes
 
-* **deps:** update dependency package-json-validator to ~0.17.0 ([#1152](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues/1152)) ([16239d0](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/commit/16239d084c245836549071a4e8ac2879b4f53f3e))
+- **deps:** update dependency package-json-validator to ~0.17.0 ([#1152](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/issues/1152)) ([16239d0](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/commit/16239d084c245836549071a4e8ac2879b4f53f3e))
 
 # [0.42.0](https://github.com/JoshuaKGoldberg/eslint-plugin-package-json/compare/v0.41.0...v0.42.0) (2025-06-25)
 

package/README.md

@@ -143,6 +143,7 @@ The default settings don't conflict, and Prettier plugins can quickly fix up ord
 | [valid-name](docs/rules/valid-name.md)                                 | Enforce that package names are valid npm package names                                            | ✔️ ✅ |    |    |    |
 | [valid-package-definition](docs/rules/valid-package-definition.md)     | Enforce that package.json has all properties required by the npm spec                             | ✔️ ✅ |    |    |    |
 | [valid-repository-directory](docs/rules/valid-repository-directory.md) | Enforce that if repository directory is specified, it matches the path to the package.json file   | ✔️ ✅ |    | 💡 |    |
+| [valid-scripts](docs/rules/valid-scripts.md)                           | Enforce that the `scripts` property is valid.                                                     | ✔️ ✅ |    |    |    |
 | [valid-type](docs/rules/valid-type.md)                                 | Enforce that the `type` property is valid.                                                        | ✔️ ✅ |    |    |    |
 | [valid-version](docs/rules/valid-version.md)                           | Enforce that package versions are valid semver specifiers                                         | ✔️ ✅ |    |    |    |
 

package/lib/plugin.js

@@ -14,6 +14,7 @@ import { rule as validLocalDependency } from "./rules/valid-local-dependency.js"
 import { rule as validName } from "./rules/valid-name.js";
 import { rule as validPackageDefinition } from "./rules/valid-package-definition.js";
 import { rule as validRepositoryDirectory } from "./rules/valid-repository-directory.js";
+import { rule as validScripts } from "./rules/valid-scripts.js";
 import { rule as validType } from "./rules/valid-type.js";
 import { rule as validVersion } from "./rules/valid-version.js";
 const require2 = createRequire(import.meta.url);
@@ -33,6 +34,7 @@ const rules = {
   "valid-name": validName,
   "valid-package-definition": validPackageDefinition,
   "valid-repository-directory": validRepositoryDirectory,
+  "valid-scripts": validScripts,
   "valid-type": validType,
   "valid-version": validVersion
 };

package/lib/rules/order-properties.js

@@ -96,6 +96,7 @@ const rule = createRule({
     },
     schema: [
       {
+        additionalProperties: false,
         properties: {
           order: {
             anyOf: [

package/lib/rules/repository-shorthand.js

@@ -101,6 +101,7 @@ const rule = createRule({
     },
     schema: [
       {
+        additionalProperties: false,
         properties: {
           form: {
             enum: ["object", "shorthand"],

package/lib/rules/valid-bin.js

@@ -64,6 +64,7 @@ const rule = createRule({
     },
     schema: [
       {
+        additionalProperties: false,
         properties: {
           enforceCase: {
             default: false,

package/lib/rules/valid-scripts.d.ts

@@ -0,0 +1,11 @@
+import * as eslint from 'eslint';
+import * as jsonc_eslint_parser from 'jsonc-eslint-parser';
+import { PackageJsonRuleContext } from '../createRule.js';
+import 'estree';
+
+declare const rule: {
+    create(context: PackageJsonRuleContext<unknown[]>): jsonc_eslint_parser.RuleListener;
+    meta: eslint.Rule.RuleMetaData;
+};
+
+export { rule };

package/lib/rules/valid-scripts.js

@@ -0,0 +1,40 @@
+import { validateScripts } from "package-json-validator";
+import { createRule } from "../createRule.js";
+import { formatErrors } from "../utils/formatErrors.js";
+const rule = createRule({
+  create(context) {
+    return {
+      "Program > JSONExpressionStatement > JSONObjectExpression > JSONProperty[key.value=scripts]"(node) {
+        const scriptValueNode = node.value;
+        const scriptValue = JSON.parse(
+          context.sourceCode.getText(scriptValueNode)
+        );
+        const errors = validateScripts(scriptValue);
+        if (errors.length) {
+          context.report({
+            data: {
+              errors: formatErrors(errors)
+            },
+            messageId: "validationError",
+            node: scriptValueNode
+          });
+        }
+      }
+    };
+  },
+  meta: {
+    docs: {
+      category: "Best Practices",
+      description: "Enforce that the `scripts` property is valid.",
+      recommended: true
+    },
+    messages: {
+      validationError: "Invalid scripts: {{ errors }}"
+    },
+    schema: [],
+    type: "problem"
+  }
+});
+export {
+  rule
+};

package/package.json

@@ -1,6 +1,6 @@
 {
 	"name": "eslint-plugin-package-json",
-	"version": "0.42.1",
+	"version": "0.43.1",
 	"description": "Rules for consistent, readable, and valid package.json files. 🗂️",
 	"homepage": "https://github.com/JoshuaKGoldberg/eslint-plugin-package-json#readme",
 	"bugs": {
@@ -46,9 +46,9 @@
 	"dependencies": {
 		"@altano/repository-tools": "^1.0.0",
 		"change-case": "^5.4.4",
-		"detect-indent": "7.0.1",
-		"detect-newline": "4.0.1",
-		"eslint-fix-utils": "^0.4.0",
+		"detect-indent": "^7.0.1",
+		"detect-newline": "^4.0.1",
+		"eslint-fix-utils": "~0.4.0",
 		"package-json-validator": "~0.17.0",
 		"semver": "^7.5.4",
 		"sort-object-keys": "^1.1.3",
@@ -68,7 +68,7 @@
 		"@vitest/coverage-v8": "3.2.0",
 		"@vitest/eslint-plugin": "1.2.0",
 		"console-fail-test": "0.5.0",
-		"create-typescript-app": "2.42.0",
+		"create-typescript-app": "2.46.1",
 		"eslint": "9.29.0",
 		"eslint-doc-generator": "2.2.0",
 		"eslint-plugin-eslint-plugin": "6.5.0",
@@ -89,7 +89,7 @@
 		"prettier": "3.6.0",
 		"prettier-plugin-curly": "0.3.1",
 		"prettier-plugin-packagejson": "2.5.10",
-		"prettier-plugin-sh": "0.17.1",
+		"prettier-plugin-sh": "0.18.0",
 		"release-it": "19.0.1",
 		"sentences-per-line": "0.3.0",
 		"tsup": "8.5.0",