eslint-plugin-node-security 4.0.0
This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
- package/CHANGELOG.md +83 -0
- package/README.md +50 -0
- package/package.json +79 -0
- package/src/index.d.ts +10 -0
- package/src/index.js +118 -0
- package/src/index.js.map +1 -0
- package/src/rules/detect-child-process/index.d.ts +30 -0
- package/src/rules/detect-child-process/index.js +535 -0
- package/src/rules/detect-child-process/index.js.map +1 -0
- package/src/rules/detect-eval-with-expression/index.d.ts +28 -0
- package/src/rules/detect-eval-with-expression/index.js +398 -0
- package/src/rules/detect-eval-with-expression/index.js.map +1 -0
- package/src/rules/detect-non-literal-fs-filename/index.d.ts +26 -0
- package/src/rules/detect-non-literal-fs-filename/index.js +460 -0
- package/src/rules/detect-non-literal-fs-filename/index.js.map +1 -0
- package/src/rules/detect-suspicious-dependencies/index.d.ts +12 -0
- package/src/rules/detect-suspicious-dependencies/index.js +77 -0
- package/src/rules/detect-suspicious-dependencies/index.js.map +1 -0
- package/src/rules/lock-file/index.d.ts +13 -0
- package/src/rules/lock-file/index.js +94 -0
- package/src/rules/lock-file/index.js.map +1 -0
- package/src/rules/no-arbitrary-file-access/index.d.ts +12 -0
- package/src/rules/no-arbitrary-file-access/index.js +201 -0
- package/src/rules/no-arbitrary-file-access/index.js.map +1 -0
- package/src/rules/no-buffer-overread/index.d.ts +39 -0
- package/src/rules/no-buffer-overread/index.js +612 -0
- package/src/rules/no-buffer-overread/index.js.map +1 -0
- package/src/rules/no-cryptojs/index.d.ts +24 -0
- package/src/rules/no-cryptojs/index.js +104 -0
- package/src/rules/no-cryptojs/index.js.map +1 -0
- package/src/rules/no-cryptojs-weak-random/index.d.ts +24 -0
- package/src/rules/no-cryptojs-weak-random/index.js +112 -0
- package/src/rules/no-cryptojs-weak-random/index.js.map +1 -0
- package/src/rules/no-data-in-temp-storage/index.d.ts +14 -0
- package/src/rules/no-data-in-temp-storage/index.js +99 -0
- package/src/rules/no-data-in-temp-storage/index.js.map +1 -0
- package/src/rules/no-deprecated-cipher-method/index.d.ts +23 -0
- package/src/rules/no-deprecated-cipher-method/index.js +118 -0
- package/src/rules/no-deprecated-cipher-method/index.js.map +1 -0
- package/src/rules/no-dynamic-dependency-loading/index.d.ts +12 -0
- package/src/rules/no-dynamic-dependency-loading/index.js +55 -0
- package/src/rules/no-dynamic-dependency-loading/index.js.map +1 -0
- package/src/rules/no-dynamic-require/index.d.ts +21 -0
- package/src/rules/no-dynamic-require/index.js +122 -0
- package/src/rules/no-dynamic-require/index.js.map +1 -0
- package/src/rules/no-ecb-mode/index.d.ts +23 -0
- package/src/rules/no-ecb-mode/index.js +113 -0
- package/src/rules/no-ecb-mode/index.js.map +1 -0
- package/src/rules/no-insecure-key-derivation/index.d.ts +24 -0
- package/src/rules/no-insecure-key-derivation/index.js +116 -0
- package/src/rules/no-insecure-key-derivation/index.js.map +1 -0
- package/src/rules/no-insecure-rsa-padding/index.d.ts +24 -0
- package/src/rules/no-insecure-rsa-padding/index.js +110 -0
- package/src/rules/no-insecure-rsa-padding/index.js.map +1 -0
- package/src/rules/no-pii-in-logs/index.d.ts +12 -0
- package/src/rules/no-pii-in-logs/index.js +74 -0
- package/src/rules/no-pii-in-logs/index.js.map +1 -0
- package/src/rules/no-self-signed-certs/index.d.ts +23 -0
- package/src/rules/no-self-signed-certs/index.js +116 -0
- package/src/rules/no-self-signed-certs/index.js.map +1 -0
- package/src/rules/no-sha1-hash/index.d.ts +24 -0
- package/src/rules/no-sha1-hash/index.js +128 -0
- package/src/rules/no-sha1-hash/index.js.map +1 -0
- package/src/rules/no-static-iv/index.d.ts +23 -0
- package/src/rules/no-static-iv/index.js +147 -0
- package/src/rules/no-static-iv/index.js.map +1 -0
- package/src/rules/no-timing-unsafe-compare/index.d.ts +23 -0
- package/src/rules/no-timing-unsafe-compare/index.js +114 -0
- package/src/rules/no-timing-unsafe-compare/index.js.map +1 -0
- package/src/rules/no-toctou-vulnerability/index.d.ts +26 -0
- package/src/rules/no-toctou-vulnerability/index.js +214 -0
- package/src/rules/no-toctou-vulnerability/index.js.map +1 -0
- package/src/rules/no-unsafe-dynamic-require/index.d.ts +19 -0
- package/src/rules/no-unsafe-dynamic-require/index.js +112 -0
- package/src/rules/no-unsafe-dynamic-require/index.js.map +1 -0
- package/src/rules/no-weak-cipher-algorithm/index.d.ts +25 -0
- package/src/rules/no-weak-cipher-algorithm/index.js +190 -0
- package/src/rules/no-weak-cipher-algorithm/index.js.map +1 -0
- package/src/rules/no-weak-hash-algorithm/index.d.ts +25 -0
- package/src/rules/no-weak-hash-algorithm/index.js +218 -0
- package/src/rules/no-weak-hash-algorithm/index.js.map +1 -0
- package/src/rules/no-zip-slip/index.d.ts +35 -0
- package/src/rules/no-zip-slip/index.js +451 -0
- package/src/rules/no-zip-slip/index.js.map +1 -0
- package/src/rules/prefer-native-crypto/index.d.ts +23 -0
- package/src/rules/prefer-native-crypto/index.js +124 -0
- package/src/rules/prefer-native-crypto/index.js.map +1 -0
- package/src/rules/require-dependency-integrity/index.d.ts +12 -0
- package/src/rules/require-dependency-integrity/index.js +70 -0
- package/src/rules/require-dependency-integrity/index.js.map +1 -0
- package/src/rules/require-secure-credential-storage/index.d.ts +12 -0
- package/src/rules/require-secure-credential-storage/index.js +54 -0
- package/src/rules/require-secure-credential-storage/index.js.map +1 -0
- package/src/rules/require-secure-deletion/index.d.ts +12 -0
- package/src/rules/require-secure-deletion/index.js +46 -0
- package/src/rules/require-secure-deletion/index.js.map +1 -0
- package/src/rules/require-storage-encryption/index.d.ts +12 -0
- package/src/rules/require-storage-encryption/index.js +54 -0
- package/src/rules/require-storage-encryption/index.js.map +1 -0
- package/src/types/index.d.ts +24 -0
- package/src/types/index.js +8 -0
- package/src/types/index.js.map +1 -0
|
@@ -0,0 +1,460 @@
|
|
|
1
|
+
"use strict";
|
|
2
|
+
/**
|
|
3
|
+
* Copyright (c) 2025 Ofri Peretz
|
|
4
|
+
* Licensed under the MIT License. Use of this source code is governed by the
|
|
5
|
+
* MIT license that can be found in the LICENSE file.
|
|
6
|
+
*/
|
|
7
|
+
Object.defineProperty(exports, "__esModule", { value: true });
|
|
8
|
+
exports.detectNonLiteralFsFilename = void 0;
|
|
9
|
+
const eslint_devkit_1 = require("@interlace/eslint-devkit");
|
|
10
|
+
const eslint_devkit_2 = require("@interlace/eslint-devkit");
|
|
11
|
+
const FS_OPERATIONS = [
|
|
12
|
+
{
|
|
13
|
+
method: 'readFile',
|
|
14
|
+
dangerous: true,
|
|
15
|
+
vulnerability: 'file-access',
|
|
16
|
+
safePattern: 'path.resolve(SAFE_DIR, path.basename(userInput))',
|
|
17
|
+
example: {
|
|
18
|
+
bad: 'fs.readFile(userPath, callback)',
|
|
19
|
+
good: 'const safePath = path.join(SAFE_UPLOADS_DIR, path.basename(userPath)); fs.readFile(safePath, callback)'
|
|
20
|
+
},
|
|
21
|
+
effort: '10-15 minutes'
|
|
22
|
+
},
|
|
23
|
+
{
|
|
24
|
+
method: 'writeFile',
|
|
25
|
+
dangerous: true,
|
|
26
|
+
vulnerability: 'file-access',
|
|
27
|
+
safePattern: 'path.resolve(SAFE_DIR, path.basename(userInput))',
|
|
28
|
+
example: {
|
|
29
|
+
bad: 'fs.writeFile(userPath, data, callback)',
|
|
30
|
+
good: 'const safePath = path.join(SAFE_WRITES_DIR, path.basename(userPath)); fs.writeFile(safePath, data, callback)'
|
|
31
|
+
},
|
|
32
|
+
effort: '10-15 minutes'
|
|
33
|
+
},
|
|
34
|
+
{
|
|
35
|
+
method: 'stat',
|
|
36
|
+
dangerous: true,
|
|
37
|
+
vulnerability: 'path-traversal',
|
|
38
|
+
safePattern: 'path.resolve(baseDir, userInput) with validation',
|
|
39
|
+
example: {
|
|
40
|
+
bad: 'fs.stat(userPath, callback)',
|
|
41
|
+
good: 'const resolvedPath = path.resolve(SAFE_DIR, userPath);\nif (!resolvedPath.startsWith(SAFE_DIR)) return;\nfs.stat(resolvedPath, callback)'
|
|
42
|
+
},
|
|
43
|
+
effort: '15-20 minutes'
|
|
44
|
+
},
|
|
45
|
+
{
|
|
46
|
+
method: 'readdir',
|
|
47
|
+
dangerous: true,
|
|
48
|
+
vulnerability: 'directory-traversal',
|
|
49
|
+
safePattern: 'Validate directory is within allowed paths',
|
|
50
|
+
example: {
|
|
51
|
+
bad: 'fs.readdir(userDir, callback)',
|
|
52
|
+
good: 'const resolvedDir = path.resolve(ALLOWED_DIRS, userDir);\nif (!resolvedDir.startsWith(ALLOWED_DIRS)) return;\nfs.readdir(resolvedDir, callback)'
|
|
53
|
+
},
|
|
54
|
+
effort: '15-20 minutes'
|
|
55
|
+
}
|
|
56
|
+
];
|
|
57
|
+
exports.detectNonLiteralFsFilename = (0, eslint_devkit_2.createRule)({
|
|
58
|
+
name: 'detect-non-literal-fs-filename',
|
|
59
|
+
meta: {
|
|
60
|
+
type: 'problem',
|
|
61
|
+
docs: {
|
|
62
|
+
description: 'Detects variable in filename argument of fs calls, which might allow an attacker to access anything on your system',
|
|
63
|
+
},
|
|
64
|
+
messages: {
|
|
65
|
+
// 🎯 Token optimization: 39% reduction (49→30 tokens) - template variables still work
|
|
66
|
+
fsPathTraversal: (0, eslint_devkit_1.formatLLMMessage)({
|
|
67
|
+
icon: '🔑',
|
|
68
|
+
issueName: 'Path traversal',
|
|
69
|
+
cwe: 'CWE-22',
|
|
70
|
+
description: 'Path traversal vulnerability',
|
|
71
|
+
severity: '{{riskLevel}}',
|
|
72
|
+
fix: '{{safePattern}}',
|
|
73
|
+
documentationLink: 'https://owasp.org/www-community/attacks/Path_Traversal',
|
|
74
|
+
}),
|
|
75
|
+
usePathResolve: (0, eslint_devkit_1.formatLLMMessage)({
|
|
76
|
+
icon: eslint_devkit_1.MessageIcons.INFO,
|
|
77
|
+
issueName: 'Use path.resolve',
|
|
78
|
+
description: 'Use path.resolve() to normalize paths',
|
|
79
|
+
severity: 'LOW',
|
|
80
|
+
fix: 'path.resolve(SAFE_DIR, userInput)',
|
|
81
|
+
documentationLink: 'https://nodejs.org/api/path.html#pathresolvepaths',
|
|
82
|
+
}),
|
|
83
|
+
validatePath: (0, eslint_devkit_1.formatLLMMessage)({
|
|
84
|
+
icon: eslint_devkit_1.MessageIcons.INFO,
|
|
85
|
+
issueName: 'Validate Path',
|
|
86
|
+
description: 'Validate resolved path starts with allowed base',
|
|
87
|
+
severity: 'LOW',
|
|
88
|
+
fix: 'if (!resolved.startsWith(SAFE_DIR)) throw new Error()',
|
|
89
|
+
documentationLink: 'https://owasp.org/www-community/attacks/Path_Traversal',
|
|
90
|
+
}),
|
|
91
|
+
useBasename: (0, eslint_devkit_1.formatLLMMessage)({
|
|
92
|
+
icon: eslint_devkit_1.MessageIcons.INFO,
|
|
93
|
+
issueName: 'Use path.basename',
|
|
94
|
+
description: 'Use path.basename() to strip directory components',
|
|
95
|
+
severity: 'LOW',
|
|
96
|
+
fix: 'path.basename(userInput)',
|
|
97
|
+
documentationLink: 'https://nodejs.org/api/path.html#pathbasenamepath-suffix',
|
|
98
|
+
}),
|
|
99
|
+
createSafeDir: (0, eslint_devkit_1.formatLLMMessage)({
|
|
100
|
+
icon: eslint_devkit_1.MessageIcons.INFO,
|
|
101
|
+
issueName: 'Define Safe Directory',
|
|
102
|
+
description: 'Define SAFE_DIR constant',
|
|
103
|
+
severity: 'LOW',
|
|
104
|
+
fix: 'const SAFE_DIR = path.resolve(__dirname, "uploads")',
|
|
105
|
+
documentationLink: 'https://owasp.org/www-community/attacks/Path_Traversal',
|
|
106
|
+
}),
|
|
107
|
+
whitelistExtensions: (0, eslint_devkit_1.formatLLMMessage)({
|
|
108
|
+
icon: eslint_devkit_1.MessageIcons.INFO,
|
|
109
|
+
issueName: 'Whitelist Extensions',
|
|
110
|
+
description: 'Whitelist allowed file extensions',
|
|
111
|
+
severity: 'LOW',
|
|
112
|
+
fix: 'const ALLOWED_EXT = [".txt", ".pdf"]; if (!ALLOWED_EXT.includes(ext)) throw',
|
|
113
|
+
documentationLink: 'https://owasp.org/www-community/attacks/Path_Traversal',
|
|
114
|
+
})
|
|
115
|
+
},
|
|
116
|
+
schema: [
|
|
117
|
+
{
|
|
118
|
+
type: 'object',
|
|
119
|
+
properties: {
|
|
120
|
+
allowLiterals: {
|
|
121
|
+
type: 'boolean',
|
|
122
|
+
default: false,
|
|
123
|
+
description: 'Allow literal string paths'
|
|
124
|
+
},
|
|
125
|
+
additionalMethods: {
|
|
126
|
+
type: 'array',
|
|
127
|
+
items: { type: 'string' },
|
|
128
|
+
default: [],
|
|
129
|
+
description: 'Additional fs methods to check'
|
|
130
|
+
},
|
|
131
|
+
allowedExtensions: {
|
|
132
|
+
type: 'array',
|
|
133
|
+
items: { type: 'string' },
|
|
134
|
+
default: [],
|
|
135
|
+
description: 'Allowed file extensions (e.g., [".txt", ".json"])'
|
|
136
|
+
}
|
|
137
|
+
},
|
|
138
|
+
additionalProperties: false,
|
|
139
|
+
},
|
|
140
|
+
],
|
|
141
|
+
},
|
|
142
|
+
defaultOptions: [
|
|
143
|
+
{
|
|
144
|
+
allowLiterals: false,
|
|
145
|
+
additionalMethods: []
|
|
146
|
+
},
|
|
147
|
+
],
|
|
148
|
+
create(context) {
|
|
149
|
+
const options = context.options[0] || {};
|
|
150
|
+
const { allowLiterals = false, additionalMethods = [] } = options || {};
|
|
151
|
+
/**
|
|
152
|
+
* File system methods that can be dangerous with user input
|
|
153
|
+
*/
|
|
154
|
+
const dangerousMethods = [
|
|
155
|
+
'readFile', 'readFileSync',
|
|
156
|
+
'writeFile', 'writeFileSync',
|
|
157
|
+
'appendFile', 'appendFileSync',
|
|
158
|
+
'stat', 'statSync',
|
|
159
|
+
'lstat', 'lstatSync',
|
|
160
|
+
'readdir', 'readdirSync',
|
|
161
|
+
'unlink', 'unlinkSync',
|
|
162
|
+
'mkdir', 'mkdirSync',
|
|
163
|
+
'rmdir', 'rmdirSync',
|
|
164
|
+
'access', 'accessSync',
|
|
165
|
+
'createReadStream', 'createWriteStream',
|
|
166
|
+
...additionalMethods
|
|
167
|
+
];
|
|
168
|
+
/**
|
|
169
|
+
* Check if a node is a literal string (safe)
|
|
170
|
+
*/
|
|
171
|
+
const isLiteralString = (node) => {
|
|
172
|
+
return node.type === 'Literal' && typeof node.value === 'string';
|
|
173
|
+
};
|
|
174
|
+
/**
|
|
175
|
+
* Check if path has dangerous patterns like ../ or ..\
|
|
176
|
+
*/
|
|
177
|
+
const hasTraversalPatterns = (pathStr) => {
|
|
178
|
+
return /\.\.[/\\]/.test(pathStr) || /^\.\.[/\\]/.test(pathStr);
|
|
179
|
+
};
|
|
180
|
+
/**
|
|
181
|
+
* Extract path argument from fs call
|
|
182
|
+
*/
|
|
183
|
+
const extractPathArgument = (node) => {
|
|
184
|
+
const method = node.callee.type === eslint_devkit_1.AST_NODE_TYPES.MemberExpression &&
|
|
185
|
+
node.callee.property.type === eslint_devkit_1.AST_NODE_TYPES.Identifier
|
|
186
|
+
? node.callee.property.name
|
|
187
|
+
: 'unknown';
|
|
188
|
+
const operation = FS_OPERATIONS.find(op => op.method === method) || null;
|
|
189
|
+
// First argument is usually the path
|
|
190
|
+
const pathNode = node.arguments.length > 0 ? node.arguments[0] : null;
|
|
191
|
+
const sourceCode = context.sourceCode || context.sourceCode;
|
|
192
|
+
const path = pathNode ? sourceCode.getText(pathNode) : '';
|
|
193
|
+
return { path, pathNode, method, operation };
|
|
194
|
+
};
|
|
195
|
+
/**
|
|
196
|
+
* Determine if the path argument is potentially dangerous
|
|
197
|
+
*/
|
|
198
|
+
const isDangerousPath = (pathNode, pathStr) => {
|
|
199
|
+
// Allow literals if configured
|
|
200
|
+
if (allowLiterals && pathNode && isLiteralString(pathNode)) {
|
|
201
|
+
return false;
|
|
202
|
+
}
|
|
203
|
+
// Check for obvious traversal patterns in literals
|
|
204
|
+
if (pathNode && isLiteralString(pathNode) && hasTraversalPatterns(pathStr)) {
|
|
205
|
+
return true;
|
|
206
|
+
}
|
|
207
|
+
// SAFE: path.join(__dirname, 'literal', 'path') with all literal args
|
|
208
|
+
if (pathNode && isSafePathConstruction(pathNode)) {
|
|
209
|
+
return false;
|
|
210
|
+
}
|
|
211
|
+
// SAFE: Path variable inside validated if-block with startsWith check
|
|
212
|
+
if (pathNode && hasPathValidation(pathNode)) {
|
|
213
|
+
return false;
|
|
214
|
+
}
|
|
215
|
+
// Any non-literal is dangerous
|
|
216
|
+
return !pathNode || !isLiteralString(pathNode);
|
|
217
|
+
};
|
|
218
|
+
/**
|
|
219
|
+
* Check if path is constructed safely using path.join/__dirname with literal args
|
|
220
|
+
*
|
|
221
|
+
* Safe patterns:
|
|
222
|
+
* - path.join(__dirname, 'data', 'file.json')
|
|
223
|
+
* - path.resolve(__dirname, 'uploads')
|
|
224
|
+
*/
|
|
225
|
+
const isSafePathConstruction = (pathNode) => {
|
|
226
|
+
if (pathNode.type !== eslint_devkit_1.AST_NODE_TYPES.CallExpression) {
|
|
227
|
+
return false;
|
|
228
|
+
}
|
|
229
|
+
const callee = pathNode.callee;
|
|
230
|
+
if (callee.type !== eslint_devkit_1.AST_NODE_TYPES.MemberExpression ||
|
|
231
|
+
callee.object.type !== eslint_devkit_1.AST_NODE_TYPES.Identifier ||
|
|
232
|
+
callee.object.name !== 'path' ||
|
|
233
|
+
callee.property.type !== eslint_devkit_1.AST_NODE_TYPES.Identifier) {
|
|
234
|
+
return false;
|
|
235
|
+
}
|
|
236
|
+
const method = callee.property.name;
|
|
237
|
+
if (!['join', 'resolve'].includes(method)) {
|
|
238
|
+
return false;
|
|
239
|
+
}
|
|
240
|
+
const args = pathNode.arguments;
|
|
241
|
+
if (args.length === 0) {
|
|
242
|
+
return false;
|
|
243
|
+
}
|
|
244
|
+
// First arg should be __dirname or a literal
|
|
245
|
+
const firstArg = args[0];
|
|
246
|
+
const isFirstArgSafe = (firstArg.type === eslint_devkit_1.AST_NODE_TYPES.Identifier && firstArg.name === '__dirname') ||
|
|
247
|
+
(firstArg.type === eslint_devkit_1.AST_NODE_TYPES.Literal && typeof firstArg.value === 'string');
|
|
248
|
+
if (!isFirstArgSafe) {
|
|
249
|
+
return false;
|
|
250
|
+
}
|
|
251
|
+
// All remaining args should be literals
|
|
252
|
+
for (let i = 1; i < args.length; i++) {
|
|
253
|
+
const arg = args[i];
|
|
254
|
+
if (arg.type !== eslint_devkit_1.AST_NODE_TYPES.Literal || typeof arg.value !== 'string') {
|
|
255
|
+
return false;
|
|
256
|
+
}
|
|
257
|
+
// Also check for traversal patterns in literals
|
|
258
|
+
if (hasTraversalPatterns(String(arg.value))) {
|
|
259
|
+
return false;
|
|
260
|
+
}
|
|
261
|
+
}
|
|
262
|
+
return true;
|
|
263
|
+
};
|
|
264
|
+
/**
|
|
265
|
+
* Check if the path variable has been validated with startsWith()
|
|
266
|
+
*
|
|
267
|
+
* Safe patterns:
|
|
268
|
+
* 1. Inside if-block: if (safePath.startsWith(SAFE_DIR)) { fs.readFileSync(safePath); }
|
|
269
|
+
* 2. After guard clause: if (!safePath.startsWith(SAFE_DIR)) { throw }; fs.readFileSync(safePath);
|
|
270
|
+
*/
|
|
271
|
+
const hasPathValidation = (pathNode) => {
|
|
272
|
+
if (pathNode.type !== eslint_devkit_1.AST_NODE_TYPES.Identifier) {
|
|
273
|
+
return false;
|
|
274
|
+
}
|
|
275
|
+
const varName = pathNode.name;
|
|
276
|
+
// AST-based validation detection (faster than getText + regex)
|
|
277
|
+
const isStartsWithOrIncludesCall = (testNode) => {
|
|
278
|
+
// Handle negation: !path.startsWith(...)
|
|
279
|
+
if (testNode.type === eslint_devkit_1.AST_NODE_TYPES.UnaryExpression &&
|
|
280
|
+
testNode.operator === '!' &&
|
|
281
|
+
testNode.argument.type === eslint_devkit_1.AST_NODE_TYPES.CallExpression) {
|
|
282
|
+
testNode = testNode.argument;
|
|
283
|
+
}
|
|
284
|
+
// Pattern: varName.startsWith(...) or varName.includes(...)
|
|
285
|
+
if (testNode.type === eslint_devkit_1.AST_NODE_TYPES.CallExpression &&
|
|
286
|
+
testNode.callee.type === eslint_devkit_1.AST_NODE_TYPES.MemberExpression &&
|
|
287
|
+
testNode.callee.object.type === eslint_devkit_1.AST_NODE_TYPES.Identifier &&
|
|
288
|
+
testNode.callee.object.name === varName &&
|
|
289
|
+
testNode.callee.property.type === eslint_devkit_1.AST_NODE_TYPES.Identifier &&
|
|
290
|
+
(testNode.callee.property.name === 'startsWith' ||
|
|
291
|
+
testNode.callee.property.name === 'includes')) {
|
|
292
|
+
return true;
|
|
293
|
+
}
|
|
294
|
+
return false;
|
|
295
|
+
};
|
|
296
|
+
const hasEarlyExit = (consequent) => {
|
|
297
|
+
if (consequent.type === eslint_devkit_1.AST_NODE_TYPES.BlockStatement) {
|
|
298
|
+
return consequent.body.some(stmt => stmt.type === eslint_devkit_1.AST_NODE_TYPES.ThrowStatement ||
|
|
299
|
+
stmt.type === eslint_devkit_1.AST_NODE_TYPES.ReturnStatement);
|
|
300
|
+
}
|
|
301
|
+
return consequent.type === eslint_devkit_1.AST_NODE_TYPES.ThrowStatement ||
|
|
302
|
+
consequent.type === eslint_devkit_1.AST_NODE_TYPES.ReturnStatement;
|
|
303
|
+
};
|
|
304
|
+
// Walk up to find enclosing IfStatement or BlockStatement
|
|
305
|
+
let current = pathNode.parent;
|
|
306
|
+
let foundFunctionBody = false;
|
|
307
|
+
while (current && !foundFunctionBody) {
|
|
308
|
+
// Check 1: Inside an if-block with validation
|
|
309
|
+
if (current.type === eslint_devkit_1.AST_NODE_TYPES.IfStatement) {
|
|
310
|
+
if (isStartsWithOrIncludesCall(current.test)) {
|
|
311
|
+
return true;
|
|
312
|
+
}
|
|
313
|
+
}
|
|
314
|
+
// Check 2: In a function body, look for preceding sibling if-statements with guard clause
|
|
315
|
+
if (current.type === eslint_devkit_1.AST_NODE_TYPES.BlockStatement && current.parent && (current.parent.type === eslint_devkit_1.AST_NODE_TYPES.FunctionDeclaration ||
|
|
316
|
+
current.parent.type === eslint_devkit_1.AST_NODE_TYPES.FunctionExpression ||
|
|
317
|
+
current.parent.type === eslint_devkit_1.AST_NODE_TYPES.ArrowFunctionExpression)) {
|
|
318
|
+
foundFunctionBody = true;
|
|
319
|
+
const blockBody = current.body;
|
|
320
|
+
const nodeIndex = blockBody.findIndex((stmt) => {
|
|
321
|
+
let check = pathNode;
|
|
322
|
+
while (check) {
|
|
323
|
+
if (check === stmt)
|
|
324
|
+
return true;
|
|
325
|
+
check = check.parent;
|
|
326
|
+
}
|
|
327
|
+
return false;
|
|
328
|
+
});
|
|
329
|
+
// Look at preceding statements for validation patterns with early exit
|
|
330
|
+
for (let i = 0; i < nodeIndex; i++) {
|
|
331
|
+
const stmt = blockBody[i];
|
|
332
|
+
if (stmt.type === eslint_devkit_1.AST_NODE_TYPES.IfStatement &&
|
|
333
|
+
isStartsWithOrIncludesCall(stmt.test) &&
|
|
334
|
+
hasEarlyExit(stmt.consequent)) {
|
|
335
|
+
return true;
|
|
336
|
+
}
|
|
337
|
+
}
|
|
338
|
+
}
|
|
339
|
+
current = current.parent;
|
|
340
|
+
}
|
|
341
|
+
return false;
|
|
342
|
+
};
|
|
343
|
+
/**
|
|
344
|
+
* Generate refactoring steps based on the operation
|
|
345
|
+
*/
|
|
346
|
+
const generateRefactoringSteps = (operation) => {
|
|
347
|
+
switch (operation.method) {
|
|
348
|
+
case 'readFile':
|
|
349
|
+
case 'writeFile':
|
|
350
|
+
return [
|
|
351
|
+
' 1. Define a SAFE_DIR constant for allowed operations',
|
|
352
|
+
' 2. Use path.basename() to strip directory components',
|
|
353
|
+
' 3. Combine with SAFE_DIR: path.join(SAFE_DIR, path.basename(userPath))',
|
|
354
|
+
' 4. Optionally validate file extensions',
|
|
355
|
+
' 5. Add error handling for invalid paths'
|
|
356
|
+
].join('\n');
|
|
357
|
+
case 'stat':
|
|
358
|
+
return [
|
|
359
|
+
' 1. Use path.resolve() to normalize the path',
|
|
360
|
+
' 2. Check if resolved path starts with allowed base directory',
|
|
361
|
+
' 3. Reject requests that escape the allowed directory',
|
|
362
|
+
' 4. Use path.relative() for additional validation',
|
|
363
|
+
' 5. Log security events for monitoring'
|
|
364
|
+
].join('\n');
|
|
365
|
+
case 'readdir':
|
|
366
|
+
return [
|
|
367
|
+
' 1. Resolve the directory path: path.resolve(ALLOWED_DIRS, userDir)',
|
|
368
|
+
' 2. Validate resolved path starts with ALLOWED_DIRS',
|
|
369
|
+
' 3. Check directory exists and is readable',
|
|
370
|
+
' 4. Consider whitelisting allowed directories',
|
|
371
|
+
' 5. Add rate limiting to prevent enumeration attacks'
|
|
372
|
+
].join('\n');
|
|
373
|
+
default:
|
|
374
|
+
return [
|
|
375
|
+
' 1. Identify the specific file operation needed',
|
|
376
|
+
' 2. Define safe base directories for operations',
|
|
377
|
+
' 3. Use path.resolve() and validate containment',
|
|
378
|
+
' 4. Sanitize user input (basename, extension validation)',
|
|
379
|
+
' 5. Add comprehensive error handling'
|
|
380
|
+
].join('\n');
|
|
381
|
+
}
|
|
382
|
+
};
|
|
383
|
+
/**
|
|
384
|
+
* Determine risk level based on the operation and path
|
|
385
|
+
*/
|
|
386
|
+
const determineRiskLevel = (operation, pathStr) => {
|
|
387
|
+
if (hasTraversalPatterns(pathStr)) {
|
|
388
|
+
return 'CRITICAL';
|
|
389
|
+
}
|
|
390
|
+
if (operation.dangerous) {
|
|
391
|
+
return 'HIGH';
|
|
392
|
+
}
|
|
393
|
+
return 'MEDIUM';
|
|
394
|
+
};
|
|
395
|
+
/**
|
|
396
|
+
* Check fs method calls for path traversal vulnerabilities
|
|
397
|
+
*/
|
|
398
|
+
const checkFsCall = (node) => {
|
|
399
|
+
// Check if it's an fs method call
|
|
400
|
+
if (node.callee.type !== 'MemberExpression' ||
|
|
401
|
+
node.callee.object.type !== 'Identifier' ||
|
|
402
|
+
node.callee.object.name !== 'fs' ||
|
|
403
|
+
node.callee.property.type !== 'Identifier') {
|
|
404
|
+
return;
|
|
405
|
+
}
|
|
406
|
+
const methodName = node.callee.property.name;
|
|
407
|
+
// Skip if not a dangerous method
|
|
408
|
+
if (!dangerousMethods.includes(methodName)) {
|
|
409
|
+
return;
|
|
410
|
+
}
|
|
411
|
+
const { path, pathNode, method, operation } = extractPathArgument(node);
|
|
412
|
+
// Check if the path argument is dangerous
|
|
413
|
+
if (!isDangerousPath(pathNode, path)) {
|
|
414
|
+
return;
|
|
415
|
+
}
|
|
416
|
+
const riskLevel = determineRiskLevel(operation || FS_OPERATIONS[0], path);
|
|
417
|
+
const steps = operation ? generateRefactoringSteps(operation) : 'Review file system access patterns';
|
|
418
|
+
const safePattern = operation?.safePattern || 'Use path.resolve() with validation';
|
|
419
|
+
context.report({
|
|
420
|
+
node,
|
|
421
|
+
messageId: 'fsPathTraversal',
|
|
422
|
+
data: {
|
|
423
|
+
method,
|
|
424
|
+
path,
|
|
425
|
+
riskLevel,
|
|
426
|
+
vulnerability: operation?.vulnerability || 'path traversal',
|
|
427
|
+
safePattern,
|
|
428
|
+
steps,
|
|
429
|
+
effort: operation?.effort || '15-20 minutes'
|
|
430
|
+
},
|
|
431
|
+
suggest: [
|
|
432
|
+
{
|
|
433
|
+
messageId: 'usePathResolve',
|
|
434
|
+
fix: () => null
|
|
435
|
+
},
|
|
436
|
+
{
|
|
437
|
+
messageId: 'validatePath',
|
|
438
|
+
fix: () => null
|
|
439
|
+
},
|
|
440
|
+
{
|
|
441
|
+
messageId: 'useBasename',
|
|
442
|
+
fix: () => null
|
|
443
|
+
},
|
|
444
|
+
{
|
|
445
|
+
messageId: 'createSafeDir',
|
|
446
|
+
fix: () => null
|
|
447
|
+
},
|
|
448
|
+
{
|
|
449
|
+
messageId: 'whitelistExtensions',
|
|
450
|
+
fix: () => null
|
|
451
|
+
}
|
|
452
|
+
]
|
|
453
|
+
});
|
|
454
|
+
};
|
|
455
|
+
return {
|
|
456
|
+
CallExpression: checkFsCall
|
|
457
|
+
};
|
|
458
|
+
},
|
|
459
|
+
});
|
|
460
|
+
//# sourceMappingURL=index.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../../../../packages/eslint-plugin-node-security/src/rules/detect-non-literal-fs-filename/index.ts"],"names":[],"mappings":";AAAA;;;;GAIG;;;AAWH,4DAA0F;AAC1F,4DAAsD;AAgCtD,MAAM,aAAa,GAAkB;IACnC;QACE,MAAM,EAAE,UAAU;QAClB,SAAS,EAAE,IAAI;QACf,aAAa,EAAE,aAAa;QAC5B,WAAW,EAAE,kDAAkD;QAC/D,OAAO,EAAE;YACP,GAAG,EAAE,iCAAiC;YACtC,IAAI,EAAE,wGAAwG;SAC/G;QACD,MAAM,EAAE,eAAe;KACxB;IACD;QACE,MAAM,EAAE,WAAW;QACnB,SAAS,EAAE,IAAI;QACf,aAAa,EAAE,aAAa;QAC5B,WAAW,EAAE,kDAAkD;QAC/D,OAAO,EAAE;YACP,GAAG,EAAE,wCAAwC;YAC7C,IAAI,EAAE,8GAA8G;SACrH;QACD,MAAM,EAAE,eAAe;KACxB;IACD;QACE,MAAM,EAAE,MAAM;QACd,SAAS,EAAE,IAAI;QACf,aAAa,EAAE,gBAAgB;QAC/B,WAAW,EAAE,kDAAkD;QAC/D,OAAO,EAAE;YACP,GAAG,EAAE,6BAA6B;YAClC,IAAI,EAAE,0IAA0I;SACjJ;QACD,MAAM,EAAE,eAAe;KACxB;IACD;QACE,MAAM,EAAE,SAAS;QACjB,SAAS,EAAE,IAAI;QACf,aAAa,EAAE,qBAAqB;QACpC,WAAW,EAAE,4CAA4C;QACzD,OAAO,EAAE;YACP,GAAG,EAAE,+BAA+B;YACpC,IAAI,EAAE,iJAAiJ;SACxJ;QACD,MAAM,EAAE,eAAe;KACxB;CACF,CAAC;AAEW,QAAA,0BAA0B,GAAG,IAAA,0BAAU,EAA0B;IAC5E,IAAI,EAAE,gCAAgC;IACtC,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,WAAW,EAAE,oHAAoH;SAClI;QACD,QAAQ,EAAE;YACR,sFAAsF;YACtF,eAAe,EAAE,IAAA,gCAAgB,EAAC;gBAChC,IAAI,EAAE,IAAI;gBACV,SAAS,EAAE,gBAAgB;gBAC3B,GAAG,EAAE,QAAQ;gBACb,WAAW,EAAE,8BAA8B;gBAC3C,QAAQ,EAAE,eAAe;gBACzB,GAAG,EAAE,iBAAiB;gBACtB,iBAAiB,EAAE,wDAAwD;aAC5E,CAAC;YACF,cAAc,EAAE,IAAA,gCAAgB,EAAC;gBAC/B,IAAI,EAAE,4BAAY,CAAC,IAAI;gBACvB,SAAS,EAAE,kBAAkB;gBAC7B,WAAW,EAAE,uCAAuC;gBACpD,QAAQ,EAAE,KAAK;gBACf,GAAG,EAAE,mCAAmC;gBACxC,iBAAiB,EAAE,mDAAmD;aACvE,CAAC;YACF,YAAY,EAAE,IAAA,gCAAgB,EAAC;gBAC7B,IAAI,EAAE,4BAAY,CAAC,IAAI;gBACvB,SAAS,EAAE,eAAe;gBAC1B,WAAW,EAAE,iDAAiD;gBAC9D,QAAQ,EAAE,KAAK;gBACf,GAAG,EAAE,uDAAuD;gBAC5D,iBAAiB,EAAE,wDAAwD;aAC5E,CAAC;YACF,WAAW,EAAE,IAAA,gCAAgB,EAAC;gBAC5B,IAAI,EAAE,4BAAY,CAAC,IAAI;gBACvB,SAAS,EAAE,mBAAmB;gBAC9B,WAAW,EAAE,mDAAmD;gBAChE,QAAQ,EAAE,KAAK;gBACf,GAAG,EAAE,0BAA0B;gBAC/B,iBAAiB,EAAE,0DAA0D;aAC9E,CAAC;YACF,aAAa,EAAE,IAAA,gCAAgB,EAAC;gBAC9B,IAAI,EAAE,4BAAY,CAAC,IAAI;gBACvB,SAAS,EAAE,uBAAuB;gBAClC,WAAW,EAAE,0BAA0B;gBACvC,QAAQ,EAAE,KAAK;gBACf,GAAG,EAAE,qDAAqD;gBAC1D,iBAAiB,EAAE,wDAAwD;aAC5E,CAAC;YACF,mBAAmB,EAAE,IAAA,gCAAgB,EAAC;gBACpC,IAAI,EAAE,4BAAY,CAAC,IAAI;gBACvB,SAAS,EAAE,sBAAsB;gBACjC,WAAW,EAAE,mCAAmC;gBAChD,QAAQ,EAAE,KAAK;gBACf,GAAG,EAAE,6EAA6E;gBAClF,iBAAiB,EAAE,wDAAwD;aAC5E,CAAC;SACH;QACD,MAAM,EAAE;YACN;gBACE,IAAI,EAAE,QAAQ;gBACd,UAAU,EAAE;oBACV,aAAa,EAAE;wBACb,IAAI,EAAE,SAAS;wBACf,OAAO,EAAE,KAAK;wBACd,WAAW,EAAE,4BAA4B;qBAC1C;oBACD,iBAAiB,EAAE;wBACjB,IAAI,EAAE,OAAO;wBACb,KAAK,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE;wBACzB,OAAO,EAAE,EAAE;wBACX,WAAW,EAAE,gCAAgC;qBAC9C;oBACD,iBAAiB,EAAE;wBACjB,IAAI,EAAE,OAAO;wBACb,KAAK,EAAE,EAAE,IAAI,EAAE,QAAQ,EAAE;wBACzB,OAAO,EAAE,EAAE;wBACX,WAAW,EAAE,mDAAmD;qBACjE;iBACF;gBACD,oBAAoB,EAAE,KAAK;aAC5B;SACF;KACF;IACD,cAAc,EAAE;QACd;YACE,aAAa,EAAE,KAAK;YACpB,iBAAiB,EAAE,EAAE;SACtB;KACF;IACD,MAAM,CAAC,OAAsD;QAC3D,MAAM,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC,CAAC,CAAC,IAAI,EAAE,CAAC;QACzC,MAAM,EACV,aAAa,GAAG,KAAK,EACf,iBAAiB,GAAG,EAAE,EAE3B,GAAY,OAAO,IAAI,EAAE,CAAC;QAEvB;;WAEG;QACH,MAAM,gBAAgB,GAAG;YACvB,UAAU,EAAE,cAAc;YAC1B,WAAW,EAAE,eAAe;YAC5B,YAAY,EAAE,gBAAgB;YAC9B,MAAM,EAAE,UAAU;YAClB,OAAO,EAAE,WAAW;YACpB,SAAS,EAAE,aAAa;YACxB,QAAQ,EAAE,YAAY;YACtB,OAAO,EAAE,WAAW;YACpB,OAAO,EAAE,WAAW;YACpB,QAAQ,EAAE,YAAY;YACtB,kBAAkB,EAAE,mBAAmB;YACvC,GAAG,iBAAiB;SACrB,CAAC;QAEF;;WAEG;QACH,MAAM,eAAe,GAAG,CAAC,IAAmB,EAAW,EAAE;YACvD,OAAO,IAAI,CAAC,IAAI,KAAK,SAAS,IAAI,OAAO,IAAI,CAAC,KAAK,KAAK,QAAQ,CAAC;QACnE,CAAC,CAAC;QAEF;;WAEG;QACH,MAAM,oBAAoB,GAAG,CAAC,OAAe,EAAW,EAAE;YACxD,OAAO,WAAW,CAAC,IAAI,CAAC,OAAO,CAAC,IAAI,YAAY,CAAC,IAAI,CAAC,OAAO,CAAC,CAAC;QACjE,CAAC,CAAC;QAEF;;WAEG;QACH,MAAM,mBAAmB,GAAG,CAAC,IAA6B,EAKxD,EAAE;YACF,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,8BAAc,CAAC,gBAAgB;gBACrD,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,8BAAc,CAAC,UAAU;gBACrD,CAAC,CAAC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI;gBAC3B,CAAC,CAAC,SAAS,CAAC;YAE5B,MAAM,SAAS,GAAG,aAAa,CAAC,IAAI,CAAC,EAAE,CAAC,EAAE,CAAC,EAAE,CAAC,MAAM,KAAK,MAAM,CAAC,IAAI,IAAI,CAAC;YAEzE,qCAAqC;YACrC,MAAM,QAAQ,GAAG,IAAI,CAAC,SAAS,CAAC,MAAM,GAAG,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,IAAI,CAAC;YACtE,MAAM,UAAU,GAAG,OAAO,CAAC,UAAU,IAAI,OAAO,CAAC,UAAU,CAAC;YAC5D,MAAM,IAAI,GAAG,QAAQ,CAAC,CAAC,CAAC,UAAU,CAAC,OAAO,CAAC,QAAQ,CAAC,CAAC,CAAC,CAAC,EAAE,CAAC;YAE1D,OAAO,EAAE,IAAI,EAAE,QAAQ,EAAE,MAAM,EAAE,SAAS,EAAE,CAAC;QAC/C,CAAC,CAAC;QAEF;;WAEG;QACH,MAAM,eAAe,GAAG,CAAC,QAA8B,EAAE,OAAe,EAAW,EAAE;YACnF,+BAA+B;YAC/B,IAAI,aAAa,IAAI,QAAQ,IAAI,eAAe,CAAC,QAAQ,CAAC,EAAE,CAAC;gBAC3D,OAAO,KAAK,CAAC;YACf,CAAC;YAED,mDAAmD;YACnD,IAAI,QAAQ,IAAI,eAAe,CAAC,QAAQ,CAAC,IAAI,oBAAoB,CAAC,OAAO,CAAC,EAAE,CAAC;gBAC3E,OAAO,IAAI,CAAC;YACd,CAAC;YAED,sEAAsE;YACtE,IAAI,QAAQ,IAAI,sBAAsB,CAAC,QAAQ,CAAC,EAAE,CAAC;gBACjD,OAAO,KAAK,CAAC;YACf,CAAC;YAED,sEAAsE;YACtE,IAAI,QAAQ,IAAI,iBAAiB,CAAC,QAAQ,CAAC,EAAE,CAAC;gBAC5C,OAAO,KAAK,CAAC;YACf,CAAC;YAED,+BAA+B;YAC/B,OAAO,CAAC,QAAQ,IAAI,CAAC,eAAe,CAAC,QAAQ,CAAC,CAAC;QACjD,CAAC,CAAC;QAEF;;;;;;WAMG;QACH,MAAM,sBAAsB,GAAG,CAAC,QAAuB,EAAW,EAAE;YAClE,IAAI,QAAQ,CAAC,IAAI,KAAK,8BAAc,CAAC,cAAc,EAAE,CAAC;gBACpD,OAAO,KAAK,CAAC;YACf,CAAC;YAED,MAAM,MAAM,GAAG,QAAQ,CAAC,MAAM,CAAC;YAC/B,IAAI,MAAM,CAAC,IAAI,KAAK,8BAAc,CAAC,gBAAgB;gBAC/C,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,8BAAc,CAAC,UAAU;gBAChD,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,MAAM;gBAC7B,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,8BAAc,CAAC,UAAU,EAAE,CAAC;gBACvD,OAAO,KAAK,CAAC;YACf,CAAC;YAED,MAAM,MAAM,GAAG,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC;YACpC,IAAI,CAAC,CAAC,MAAM,EAAE,SAAS,CAAC,CAAC,QAAQ,CAAC,MAAM,CAAC,EAAE,CAAC;gBAC1C,OAAO,KAAK,CAAC;YACf,CAAC;YAED,MAAM,IAAI,GAAG,QAAQ,CAAC,SAAS,CAAC;YAChC,IAAI,IAAI,CAAC,MAAM,KAAK,CAAC,EAAE,CAAC;gBACtB,OAAO,KAAK,CAAC;YACf,CAAC;YAED,6CAA6C;YAC7C,MAAM,QAAQ,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;YACzB,MAAM,cAAc,GAClB,CAAC,QAAQ,CAAC,IAAI,KAAK,8BAAc,CAAC,UAAU,IAAI,QAAQ,CAAC,IAAI,KAAK,WAAW,CAAC;gBAC9E,CAAC,QAAQ,CAAC,IAAI,KAAK,8BAAc,CAAC,OAAO,IAAI,OAAO,QAAQ,CAAC,KAAK,KAAK,QAAQ,CAAC,CAAC;YAEnF,IAAI,CAAC,cAAc,EAAE,CAAC;gBACpB,OAAO,KAAK,CAAC;YACf,CAAC;YAED,wCAAwC;YACxC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,IAAI,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;gBACrC,MAAM,GAAG,GAAG,IAAI,CAAC,CAAC,CAAC,CAAC;gBACpB,IAAI,GAAG,CAAC,IAAI,KAAK,8BAAc,CAAC,OAAO,IAAI,OAAO,GAAG,CAAC,KAAK,KAAK,QAAQ,EAAE,CAAC;oBACzE,OAAO,KAAK,CAAC;gBACf,CAAC;gBACD,gDAAgD;gBAChD,IAAI,oBAAoB,CAAC,MAAM,CAAC,GAAG,CAAC,KAAK,CAAC,CAAC,EAAE,CAAC;oBAC5C,OAAO,KAAK,CAAC;gBACf,CAAC;YACH,CAAC;YAED,OAAO,IAAI,CAAC;QACd,CAAC,CAAC;QAEF;;;;;;WAMG;QACH,MAAM,iBAAiB,GAAG,CAAC,QAAuB,EAAW,EAAE;YAC7D,IAAI,QAAQ,CAAC,IAAI,KAAK,8BAAc,CAAC,UAAU,EAAE,CAAC;gBAChD,OAAO,KAAK,CAAC;YACf,CAAC;YAED,MAAM,OAAO,GAAG,QAAQ,CAAC,IAAI,CAAC;YAE9B,+DAA+D;YAC/D,MAAM,0BAA0B,GAAG,CAAC,QAAuB,EAAW,EAAE;gBACtE,yCAAyC;gBACzC,IAAI,QAAQ,CAAC,IAAI,KAAK,8BAAc,CAAC,eAAe;oBAChD,QAAQ,CAAC,QAAQ,KAAK,GAAG;oBACzB,QAAQ,CAAC,QAAQ,CAAC,IAAI,KAAK,8BAAc,CAAC,cAAc,EAAE,CAAC;oBAC7D,QAAQ,GAAG,QAAQ,CAAC,QAAQ,CAAC;gBAC/B,CAAC;gBAED,4DAA4D;gBAC5D,IAAI,QAAQ,CAAC,IAAI,KAAK,8BAAc,CAAC,cAAc;oBAC/C,QAAQ,CAAC,MAAM,CAAC,IAAI,KAAK,8BAAc,CAAC,gBAAgB;oBACxD,QAAQ,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,8BAAc,CAAC,UAAU;oBACzD,QAAQ,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,OAAO;oBACvC,QAAQ,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,8BAAc,CAAC,UAAU;oBAC3D,CAAC,QAAQ,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY;wBAC9C,QAAQ,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,UAAU,CAAC,EAAE,CAAC;oBACnD,OAAO,IAAI,CAAC;gBACd,CAAC;gBACD,OAAO,KAAK,CAAC;YACf,CAAC,CAAC;YAEF,MAAM,YAAY,GAAG,CAAC,UAA8B,EAAW,EAAE;gBAC/D,IAAI,UAAU,CAAC,IAAI,KAAK,8BAAc,CAAC,cAAc,EAAE,CAAC;oBACtD,OAAO,UAAU,CAAC,IAAI,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CACjC,IAAI,CAAC,IAAI,KAAK,8BAAc,CAAC,cAAc;wBAC3C,IAAI,CAAC,IAAI,KAAK,8BAAc,CAAC,eAAe,CAC7C,CAAC;gBACJ,CAAC;gBACD,OAAO,UAAU,CAAC,IAAI,KAAK,8BAAc,CAAC,cAAc;oBACjD,UAAU,CAAC,IAAI,KAAK,8BAAc,CAAC,eAAe,CAAC;YAC5D,CAAC,CAAC;YAEF,0DAA0D;YAC1D,IAAI,OAAO,GAA8B,QAAQ,CAAC,MAAM,CAAC;YACzD,IAAI,iBAAiB,GAAG,KAAK,CAAC;YAE9B,OAAO,OAAO,IAAI,CAAC,iBAAiB,EAAE,CAAC;gBACrC,8CAA8C;gBAC9C,IAAI,OAAO,CAAC,IAAI,KAAK,8BAAc,CAAC,WAAW,EAAE,CAAC;oBAChD,IAAI,0BAA0B,CAAC,OAAO,CAAC,IAAI,CAAC,EAAE,CAAC;wBAC7C,OAAO,IAAI,CAAC;oBACd,CAAC;gBACH,CAAC;gBAED,0FAA0F;gBAC1F,IAAI,OAAO,CAAC,IAAI,KAAK,8BAAc,CAAC,cAAc,IAAI,OAAO,CAAC,MAAM,IAAI,CACpE,OAAO,CAAC,MAAM,CAAC,IAAI,KAAK,8BAAc,CAAC,mBAAmB;oBAC1D,OAAO,CAAC,MAAM,CAAC,IAAI,KAAK,8BAAc,CAAC,kBAAkB;oBACzD,OAAO,CAAC,MAAM,CAAC,IAAI,KAAK,8BAAc,CAAC,uBAAuB,CAAC,EAAE,CAAC;oBAEpE,iBAAiB,GAAG,IAAI,CAAC;oBACzB,MAAM,SAAS,GAAG,OAAO,CAAC,IAAI,CAAC;oBAC/B,MAAM,SAAS,GAAG,SAAS,CAAC,SAAS,CAAC,CAAC,IAAwB,EAAE,EAAE;wBACjE,IAAI,KAAK,GAA8B,QAAQ,CAAC;wBAChD,OAAO,KAAK,EAAE,CAAC;4BACb,IAAI,KAAK,KAAK,IAAI;gCAAE,OAAO,IAAI,CAAC;4BAChC,KAAK,GAAG,KAAK,CAAC,MAAM,CAAC;wBACvB,CAAC;wBACD,OAAO,KAAK,CAAC;oBACf,CAAC,CAAC,CAAC;oBAEH,uEAAuE;oBACvE,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,GAAG,SAAS,EAAE,CAAC,EAAE,EAAE,CAAC;wBACnC,MAAM,IAAI,GAAG,SAAS,CAAC,CAAC,CAAC,CAAC;wBAC1B,IAAI,IAAI,CAAC,IAAI,KAAK,8BAAc,CAAC,WAAW;4BACxC,0BAA0B,CAAC,IAAI,CAAC,IAAI,CAAC;4BACrC,YAAY,CAAC,IAAI,CAAC,UAAU,CAAC,EAAE,CAAC;4BAClC,OAAO,IAAI,CAAC;wBACd,CAAC;oBACH,CAAC;gBACH,CAAC;gBAED,OAAO,GAAG,OAAO,CAAC,MAAM,CAAC;YAC3B,CAAC;YAED,OAAO,KAAK,CAAC;QACf,CAAC,CAAC;QAEF;;WAEG;QACH,MAAM,wBAAwB,GAAG,CAAC,SAAsB,EAAU,EAAE;YAClE,QAAQ,SAAS,CAAC,MAAM,EAAE,CAAC;gBACzB,KAAK,UAAU,CAAC;gBAChB,KAAK,WAAW;oBACd,OAAO;wBACL,yDAAyD;wBACzD,yDAAyD;wBACzD,2EAA2E;wBAC3E,2CAA2C;wBAC3C,4CAA4C;qBAC7C,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;gBAEf,KAAK,MAAM;oBACT,OAAO;wBACL,gDAAgD;wBAChD,iEAAiE;wBACjE,yDAAyD;wBACzD,qDAAqD;wBACrD,0CAA0C;qBAC3C,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;gBAEf,KAAK,SAAS;oBACZ,OAAO;wBACL,uEAAuE;wBACvE,uDAAuD;wBACvD,8CAA8C;wBAC9C,iDAAiD;wBACjD,wDAAwD;qBACzD,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;gBAEf;oBACE,OAAO;wBACL,mDAAmD;wBACnD,mDAAmD;wBACnD,mDAAmD;wBACnD,4DAA4D;wBAC5D,wCAAwC;qBACzC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAC;YACjB,CAAC;QACH,CAAC,CAAC;QAEF;;WAEG;QACH,MAAM,kBAAkB,GAAG,CAAC,SAAsB,EAAE,OAAe,EAAU,EAAE;YAC7E,IAAI,oBAAoB,CAAC,OAAO,CAAC,EAAE,CAAC;gBAClC,OAAO,UAAU,CAAC;YACpB,CAAC;YAED,IAAI,SAAS,CAAC,SAAS,EAAE,CAAC;gBACxB,OAAO,MAAM,CAAC;YAChB,CAAC;YAED,OAAO,QAAQ,CAAC;QAClB,CAAC,CAAC;QAEF;;WAEG;QACH,MAAM,WAAW,GAAG,CAAC,IAA6B,EAAE,EAAE;YACpD,kCAAkC;YAClC,IAAI,IAAI,CAAC,MAAM,CAAC,IAAI,KAAK,kBAAkB;gBACvC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,YAAY;gBACxC,IAAI,CAAC,MAAM,CAAC,MAAM,CAAC,IAAI,KAAK,IAAI;gBAChC,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,KAAK,YAAY,EAAE,CAAC;gBAC/C,OAAO;YACT,CAAC;YAED,MAAM,UAAU,GAAG,IAAI,CAAC,MAAM,CAAC,QAAQ,CAAC,IAAI,CAAC;YAE7C,iCAAiC;YACjC,IAAI,CAAC,gBAAgB,CAAC,QAAQ,CAAC,UAAU,CAAC,EAAE,CAAC;gBAC3C,OAAO;YACT,CAAC;YAED,MAAM,EAAE,IAAI,EAAE,QAAQ,EAAE,MAAM,EAAE,SAAS,EAAE,GAAG,mBAAmB,CAAC,IAAI,CAAC,CAAC;YAExE,0CAA0C;YAC1C,IAAI,CAAC,eAAe,CAAC,QAAQ,EAAE,IAAI,CAAC,EAAE,CAAC;gBACrC,OAAO;YACT,CAAC;YAED,MAAM,SAAS,GAAG,kBAAkB,CAAC,SAAS,IAAI,aAAa,CAAC,CAAC,CAAC,EAAE,IAAI,CAAC,CAAC;YAC1E,MAAM,KAAK,GAAG,SAAS,CAAC,CAAC,CAAC,wBAAwB,CAAC,SAAS,CAAC,CAAC,CAAC,CAAC,oCAAoC,CAAC;YACrG,MAAM,WAAW,GAAG,SAAS,EAAE,WAAW,IAAI,oCAAoC,CAAC;YAEnF,OAAO,CAAC,MAAM,CAAC;gBACb,IAAI;gBACJ,SAAS,EAAE,iBAAiB;gBAC5B,IAAI,EAAE;oBACJ,MAAM;oBACN,IAAI;oBACJ,SAAS;oBACT,aAAa,EAAE,SAAS,EAAE,aAAa,IAAI,gBAAgB;oBAC3D,WAAW;oBACX,KAAK;oBACL,MAAM,EAAE,SAAS,EAAE,MAAM,IAAI,eAAe;iBAC7C;gBACD,OAAO,EAAE;oBACP;wBACE,SAAS,EAAE,gBAAgB;wBAC3B,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI;qBAChB;oBACD;wBACE,SAAS,EAAE,cAAc;wBACzB,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI;qBAChB;oBACD;wBACE,SAAS,EAAE,aAAa;wBACxB,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI;qBAChB;oBACD;wBACE,SAAS,EAAE,eAAe;wBAC1B,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI;qBAChB;oBACD;wBACE,SAAS,EAAE,qBAAqB;wBAChC,GAAG,EAAE,GAAG,EAAE,CAAC,IAAI;qBAChB;iBACF;aACF,CAAC,CAAC;QACL,CAAC,CAAC;QAEF,OAAO;YACL,cAAc,EAAE,WAAW;SAC5B,CAAC;IACJ,CAAC;CACF,CAAC,CAAC"}
|
|
@@ -0,0 +1,12 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* Copyright (c) 2025 Ofri Peretz
|
|
3
|
+
* Licensed under the MIT License. Use of this source code is governed by the
|
|
4
|
+
* MIT license that can be found in the LICENSE file.
|
|
5
|
+
*/
|
|
6
|
+
export interface Options {
|
|
7
|
+
}
|
|
8
|
+
type RuleOptions = [Options?];
|
|
9
|
+
export declare const detectSuspiciousDependencies: import("@typescript-eslint/utils/ts-eslint").RuleModule<"violationDetected", RuleOptions, unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
|
|
10
|
+
name: string;
|
|
11
|
+
};
|
|
12
|
+
export {};
|
|
@@ -0,0 +1,77 @@
|
|
|
1
|
+
"use strict";
|
|
2
|
+
/**
|
|
3
|
+
* Copyright (c) 2025 Ofri Peretz
|
|
4
|
+
* Licensed under the MIT License. Use of this source code is governed by the
|
|
5
|
+
* MIT license that can be found in the LICENSE file.
|
|
6
|
+
*/
|
|
7
|
+
Object.defineProperty(exports, "__esModule", { value: true });
|
|
8
|
+
exports.detectSuspiciousDependencies = void 0;
|
|
9
|
+
/**
|
|
10
|
+
* @fileoverview Detect potential typosquatting in dependencies
|
|
11
|
+
* @see https://owasp.org/www-project-mobile-top-10/
|
|
12
|
+
* @see https://cwe.mitre.org/data/definitions/506.html
|
|
13
|
+
*/
|
|
14
|
+
const eslint_devkit_1 = require("@interlace/eslint-devkit");
|
|
15
|
+
exports.detectSuspiciousDependencies = (0, eslint_devkit_1.createRule)({
|
|
16
|
+
name: 'detect-suspicious-dependencies',
|
|
17
|
+
meta: {
|
|
18
|
+
type: 'problem',
|
|
19
|
+
docs: {
|
|
20
|
+
description: 'Detect typosquatting in package names',
|
|
21
|
+
},
|
|
22
|
+
messages: {
|
|
23
|
+
violationDetected: (0, eslint_devkit_1.formatLLMMessage)({
|
|
24
|
+
icon: eslint_devkit_1.MessageIcons.SECURITY,
|
|
25
|
+
issueName: 'Suspicious Dependency',
|
|
26
|
+
cwe: 'CWE-506',
|
|
27
|
+
description: 'Suspicious package name detected - possible typosquatting',
|
|
28
|
+
severity: 'HIGH',
|
|
29
|
+
fix: 'Verify package authenticity on npm registry',
|
|
30
|
+
documentationLink: 'https://cwe.mitre.org/data/definitions/506.html',
|
|
31
|
+
})
|
|
32
|
+
},
|
|
33
|
+
schema: [],
|
|
34
|
+
},
|
|
35
|
+
defaultOptions: [],
|
|
36
|
+
create(context) {
|
|
37
|
+
const popularPackages = ['react', 'lodash', 'express', 'axios', 'webpack'];
|
|
38
|
+
function levenshtein(a, b) {
|
|
39
|
+
const matrix = [];
|
|
40
|
+
for (let i = 0; i <= b.length; i++) {
|
|
41
|
+
matrix[i] = [i];
|
|
42
|
+
}
|
|
43
|
+
for (let j = 0; j <= a.length; j++) {
|
|
44
|
+
matrix[0][j] = j;
|
|
45
|
+
}
|
|
46
|
+
for (let i = 1; i <= b.length; i++) {
|
|
47
|
+
for (let j = 1; j <= a.length; j++) {
|
|
48
|
+
if (b.charAt(i - 1) === a.charAt(j - 1)) {
|
|
49
|
+
matrix[i][j] = matrix[i - 1][j - 1];
|
|
50
|
+
}
|
|
51
|
+
else {
|
|
52
|
+
matrix[i][j] = Math.min(matrix[i - 1][j - 1] + 1, matrix[i][j - 1] + 1, matrix[i - 1][j] + 1);
|
|
53
|
+
}
|
|
54
|
+
}
|
|
55
|
+
}
|
|
56
|
+
return matrix[b.length][a.length];
|
|
57
|
+
}
|
|
58
|
+
return {
|
|
59
|
+
ImportDeclaration(node) {
|
|
60
|
+
const source = node.source.value;
|
|
61
|
+
if (typeof source === 'string' && !source.startsWith('.') && !source.startsWith('@')) {
|
|
62
|
+
for (const popular of popularPackages) {
|
|
63
|
+
const distance = levenshtein(source, popular);
|
|
64
|
+
if (distance > 0 && distance <= 2) {
|
|
65
|
+
context.report({
|
|
66
|
+
node,
|
|
67
|
+
messageId: 'violationDetected',
|
|
68
|
+
data: { name: source, similar: popular },
|
|
69
|
+
});
|
|
70
|
+
}
|
|
71
|
+
}
|
|
72
|
+
}
|
|
73
|
+
},
|
|
74
|
+
};
|
|
75
|
+
},
|
|
76
|
+
});
|
|
77
|
+
//# sourceMappingURL=index.js.map
|
|
@@ -0,0 +1 @@
|
|
|
1
|
+
{"version":3,"file":"index.js","sourceRoot":"","sources":["../../../../../../packages/eslint-plugin-node-security/src/rules/detect-suspicious-dependencies/index.ts"],"names":[],"mappings":";AAAA;;;;GAIG;;;AAEH;;;;GAIG;AAEH,4DAAsF;AAUzE,QAAA,4BAA4B,GAAG,IAAA,0BAAU,EAA0B;IAC9E,IAAI,EAAE,gCAAgC;IACtC,IAAI,EAAE;QACJ,IAAI,EAAE,SAAS;QACf,IAAI,EAAE;YACJ,WAAW,EAAE,uCAAuC;SACrD;QACD,QAAQ,EAAE;YACR,iBAAiB,EAAE,IAAA,gCAAgB,EAAC;gBAClC,IAAI,EAAE,4BAAY,CAAC,QAAQ;gBAC3B,SAAS,EAAE,uBAAuB;gBAClC,GAAG,EAAE,SAAS;gBACd,WAAW,EAAE,2DAA2D;gBACxE,QAAQ,EAAE,MAAM;gBAChB,GAAG,EAAE,6CAA6C;gBAClD,iBAAiB,EAAE,iDAAiD;aACrE,CAAC;SACH;QACD,MAAM,EAAE,EAAE;KACX;IACD,cAAc,EAAE,EAAE;IAClB,MAAM,CAAC,OAAO;QACZ,MAAM,eAAe,GAAG,CAAC,OAAO,EAAE,QAAQ,EAAE,SAAS,EAAE,OAAO,EAAE,SAAS,CAAC,CAAC;QAE3E,SAAS,WAAW,CAAC,CAAS,EAAE,CAAS;YACvC,MAAM,MAAM,GAAG,EAAE,CAAC;YAClB,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;gBACnC,MAAM,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC;YAClB,CAAC;YACD,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;gBACnC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC;YACnB,CAAC;YACD,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;gBACnC,KAAK,IAAI,CAAC,GAAG,CAAC,EAAE,CAAC,IAAI,CAAC,CAAC,MAAM,EAAE,CAAC,EAAE,EAAE,CAAC;oBACnC,IAAI,CAAC,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,CAAC,KAAK,CAAC,CAAC,MAAM,CAAC,CAAC,GAAG,CAAC,CAAC,EAAE,CAAC;wBACxC,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,GAAG,MAAM,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC;oBACtC,CAAC;yBAAM,CAAC;wBACN,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,CAAC,GAAG,IAAI,CAAC,GAAG,CACrB,MAAM,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,GAAG,CAAC,EACxB,MAAM,CAAC,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,GAAG,CAAC,EACpB,MAAM,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,CAAC,CAAC,GAAG,CAAC,CACrB,CAAC;oBACJ,CAAC;gBACH,CAAC;YACH,CAAC;YACD,OAAO,MAAM,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC,CAAC,CAAC,MAAM,CAAC,CAAC;QACpC,CAAC;QAED,OAAO;YACL,iBAAiB,CAAC,IAAgC;gBAChD,MAAM,MAAM,GAAG,IAAI,CAAC,MAAM,CAAC,KAAK,CAAC;gBACjC,IAAI,OAAO,MAAM,KAAK,QAAQ,IAAI,CAAC,MAAM,CAAC,UAAU,CAAC,GAAG,CAAC,IAAI,CAAC,MAAM,CAAC,UAAU,CAAC,GAAG,CAAC,EAAE,CAAC;oBACrF,KAAK,MAAM,OAAO,IAAI,eAAe,EAAE,CAAC;wBACtC,MAAM,QAAQ,GAAG,WAAW,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC;wBAC9C,IAAI,QAAQ,GAAG,CAAC,IAAI,QAAQ,IAAI,CAAC,EAAE,CAAC;4BAClC,OAAO,CAAC,MAAM,CAAC;gCACb,IAAI;gCACJ,SAAS,EAAE,mBAAmB;gCAC9B,IAAI,EAAE,EAAE,IAAI,EAAE,MAAM,EAAE,OAAO,EAAE,OAAO,EAAE;6BACzC,CAAC,CAAC;wBACL,CAAC;oBACH,CAAC;gBACH,CAAC;YACH,CAAC;SACF,CAAC;IACJ,CAAC;CACF,CAAC,CAAC"}
|
|
@@ -0,0 +1,13 @@
|
|
|
1
|
+
/**
|
|
2
|
+
* Copyright (c) 2025 Ofri Peretz
|
|
3
|
+
* Licensed under the MIT License. Use of this source code is governed by the
|
|
4
|
+
* MIT license that can be found in the LICENSE file.
|
|
5
|
+
*/
|
|
6
|
+
export interface Options {
|
|
7
|
+
packageManager?: 'npm' | 'yarn' | 'pnpm';
|
|
8
|
+
}
|
|
9
|
+
type RuleOptions = [Options?];
|
|
10
|
+
export declare const lockFile: import("@typescript-eslint/utils/ts-eslint").RuleModule<"violationDetected", RuleOptions, unknown, import("@typescript-eslint/utils/ts-eslint").RuleListener> & {
|
|
11
|
+
name: string;
|
|
12
|
+
};
|
|
13
|
+
export {};
|