eslint-plugin-node-dependencies 0.5.1 → 0.8.0

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
package/README.md CHANGED
@@ -119,13 +119,23 @@ The rules with the following star :star: are included in the `plugin:node-depend
119
119
  | Rule ID | Description | |
120
120
  |:--------|:------------|:---|
121
121
  | [node-dependencies/compat-engines](https://ota-meshi.github.io/eslint-plugin-node-dependencies/rules/compat-engines.html) | enforce the versions of the engines of the dependencies to be compatible. | :star: |
122
+ | [node-dependencies/no-dupe-deps](https://ota-meshi.github.io/eslint-plugin-node-dependencies/rules/no-dupe-deps.html) | disallow duplicate dependencies. | |
122
123
  | [node-dependencies/valid-semver](https://ota-meshi.github.io/eslint-plugin-node-dependencies/rules/valid-semver.html) | enforce versions that is valid as a semantic version. | :star: |
123
124
 
124
125
  ### Best Practices
125
126
 
126
127
  | Rule ID | Description | |
127
128
  |:--------|:------------|:---|
129
+ | [node-dependencies/absolute-version](https://ota-meshi.github.io/eslint-plugin-node-dependencies/rules/absolute-version.html) | require or disallow absolute version of dependency. | |
128
130
  | [node-dependencies/no-deprecated](https://ota-meshi.github.io/eslint-plugin-node-dependencies/rules/no-deprecated.html) | disallow having dependencies on deprecate packages. | |
131
+ | [node-dependencies/no-restricted-deps](https://ota-meshi.github.io/eslint-plugin-node-dependencies/rules/no-restricted-deps.html) | Disallows dependence on the specified package. | |
132
+
133
+ ### Stylistic Issues
134
+
135
+ | Rule ID | Description | |
136
+ |:--------|:------------|:---|
137
+ | [node-dependencies/prefer-caret-range-version](https://ota-meshi.github.io/eslint-plugin-node-dependencies/rules/prefer-caret-range-version.html) | require caret(`^`) version instead of range version. | :wrench: |
138
+ | [node-dependencies/prefer-tilde-range-version](https://ota-meshi.github.io/eslint-plugin-node-dependencies/rules/prefer-tilde-range-version.html) | require tilde(`~`) version instead of range version. | :wrench: |
129
139
 
130
140
  ### Deprecated
131
141
 
@@ -0,0 +1,159 @@
1
+ "use strict";
2
+ Object.defineProperty(exports, "__esModule", { value: true });
3
+ const jsonc_eslint_parser_1 = require("jsonc-eslint-parser");
4
+ const utils_1 = require("../utils");
5
+ const ast_utils_1 = require("../utils/ast-utils");
6
+ const regexp_1 = require("../utils/regexp");
7
+ const semver_1 = require("../utils/semver");
8
+ const PREFERS = ["always", "never", "ignore"];
9
+ const SCHEMA_FOR_DEPS_PROPERTIES = {
10
+ dependencies: { enum: PREFERS },
11
+ peerDependencies: { enum: PREFERS },
12
+ optionalDependencies: { enum: PREFERS },
13
+ devDependencies: { enum: PREFERS },
14
+ };
15
+ const DEFAULT = {
16
+ dependencies: "ignore",
17
+ peerDependencies: "ignore",
18
+ optionalDependencies: "ignore",
19
+ devDependencies: "always",
20
+ };
21
+ function stringToOption(option) {
22
+ return {
23
+ dependencies: option,
24
+ peerDependencies: option,
25
+ optionalDependencies: option,
26
+ devDependencies: option,
27
+ };
28
+ }
29
+ function objectToOption(option, defaults) {
30
+ return {
31
+ dependencies: option.dependencies || defaults.dependencies,
32
+ peerDependencies: option.peerDependencies || defaults.peerDependencies,
33
+ optionalDependencies: option.optionalDependencies || defaults.optionalDependencies,
34
+ devDependencies: option.devDependencies || defaults.devDependencies,
35
+ };
36
+ }
37
+ function parseOption(option) {
38
+ if (!option) {
39
+ return () => DEFAULT;
40
+ }
41
+ if (typeof option === "string") {
42
+ const objectOption = stringToOption(option);
43
+ return () => objectOption;
44
+ }
45
+ const baseOption = objectToOption(option, DEFAULT);
46
+ if (!option.overridePackages) {
47
+ return () => baseOption;
48
+ }
49
+ const overridePackages = Object.entries(option.overridePackages).map(([packageName, opt]) => {
50
+ const regexp = (0, regexp_1.toRegExp)(packageName);
51
+ return Object.assign({ test: (s) => regexp.test(s) }, (typeof opt === "string"
52
+ ? stringToOption(opt)
53
+ : objectToOption(opt, baseOption)));
54
+ });
55
+ return (name) => {
56
+ for (const overridePackage of overridePackages) {
57
+ if (overridePackage.test(name)) {
58
+ return overridePackage;
59
+ }
60
+ }
61
+ return baseOption;
62
+ };
63
+ }
64
+ exports.default = (0, utils_1.createRule)("absolute-version", {
65
+ meta: {
66
+ docs: {
67
+ description: "require or disallow absolute version of dependency.",
68
+ category: "Best Practices",
69
+ recommended: false,
70
+ },
71
+ schema: [
72
+ {
73
+ oneOf: [
74
+ { enum: PREFERS.filter((p) => p !== "ignore") },
75
+ {
76
+ type: "object",
77
+ properties: Object.assign(Object.assign({}, SCHEMA_FOR_DEPS_PROPERTIES), { overridePackages: {
78
+ type: "object",
79
+ patternProperties: {
80
+ "^(?:\\S+)$": {
81
+ oneOf: [
82
+ { enum: PREFERS },
83
+ {
84
+ type: "object",
85
+ properties: SCHEMA_FOR_DEPS_PROPERTIES,
86
+ additionalProperties: false,
87
+ },
88
+ ],
89
+ },
90
+ },
91
+ minProperties: 1,
92
+ additionalProperties: false,
93
+ } }),
94
+ additionalProperties: false,
95
+ },
96
+ ],
97
+ },
98
+ ],
99
+ messages: {},
100
+ type: "suggestion",
101
+ },
102
+ create(context) {
103
+ if (!context.parserServices.isJSON) {
104
+ return {};
105
+ }
106
+ const getOption = parseOption(context.options[0]);
107
+ function defineVisitor(visitName) {
108
+ return (node) => {
109
+ const ver = (0, jsonc_eslint_parser_1.getStaticJSONValue)(node.value);
110
+ if (typeof ver !== "string" || ver == null) {
111
+ return;
112
+ }
113
+ const name = String((0, ast_utils_1.getKeyFromJSONProperty)(node));
114
+ const option = getOption(name)[visitName];
115
+ const semver = (0, semver_1.getSemverRange)(ver);
116
+ if (semver == null) {
117
+ return;
118
+ }
119
+ if (option === "always") {
120
+ if (isAbsoluteVersion(semver)) {
121
+ return;
122
+ }
123
+ context.report({
124
+ loc: node.value.loc,
125
+ message: "Use the absolute version instead.",
126
+ });
127
+ }
128
+ else if (option === "never") {
129
+ if (!isAbsoluteVersion(semver)) {
130
+ return;
131
+ }
132
+ context.report({
133
+ loc: node.value.loc,
134
+ message: "Do not use the absolute version.",
135
+ });
136
+ }
137
+ };
138
+ }
139
+ return (0, utils_1.defineJsonVisitor)({
140
+ dependencies: defineVisitor("dependencies"),
141
+ peerDependencies: defineVisitor("peerDependencies"),
142
+ optionalDependencies: defineVisitor("optionalDependencies"),
143
+ devDependencies: defineVisitor("devDependencies"),
144
+ });
145
+ },
146
+ });
147
+ function isAbsoluteVersion(semver) {
148
+ for (const comparators of semver.set) {
149
+ for (const comparator of comparators) {
150
+ if ((0, semver_1.isAnyComparator)(comparator)) {
151
+ return false;
152
+ }
153
+ if (comparator.operator !== "=" && comparator.operator !== "") {
154
+ return false;
155
+ }
156
+ }
157
+ }
158
+ return true;
159
+ }
@@ -0,0 +1,88 @@
1
+ "use strict";
2
+ Object.defineProperty(exports, "__esModule", { value: true });
3
+ const utils_1 = require("../utils");
4
+ const ast_utils_1 = require("../utils/ast-utils");
5
+ const DEPS = [
6
+ "dependencies",
7
+ "peerDependencies",
8
+ "optionalDependencies",
9
+ "devDependencies",
10
+ ];
11
+ class AllowDuplicates {
12
+ constructor() {
13
+ this.edges = [];
14
+ }
15
+ add(d1, d2) {
16
+ this.edges.push([d1, d2]);
17
+ }
18
+ isAllowedDuplicate(dep1, dep2) {
19
+ return this.edges.some(([d1, d2]) => (d1 === dep1 && d2 === dep2) || (d2 === dep1 && d1 === dep2));
20
+ }
21
+ }
22
+ exports.default = (0, utils_1.createRule)("no-dupe-deps", {
23
+ meta: {
24
+ docs: {
25
+ description: "disallow duplicate dependencies.",
26
+ category: "Possible Errors",
27
+ recommended: false,
28
+ },
29
+ schema: [],
30
+ messages: {
31
+ duplicated: "Duplicated dependency '{{name}}'.",
32
+ },
33
+ type: "problem",
34
+ },
35
+ create(context) {
36
+ if (!context.parserServices.isJSON) {
37
+ return {};
38
+ }
39
+ const allowDuplicates = new AllowDuplicates();
40
+ allowDuplicates.add("devDependencies", "peerDependencies");
41
+ allowDuplicates.add("devDependencies", "optionalDependencies");
42
+ const maps = {
43
+ dependencies: new Map(),
44
+ peerDependencies: new Map(),
45
+ optionalDependencies: new Map(),
46
+ devDependencies: new Map(),
47
+ };
48
+ const reported = new Set();
49
+ function report(name, node) {
50
+ if (reported.has(node)) {
51
+ return;
52
+ }
53
+ reported.add(node);
54
+ context.report({
55
+ loc: node.key.loc,
56
+ messageId: "duplicated",
57
+ data: {
58
+ name,
59
+ },
60
+ });
61
+ }
62
+ function verify(depsName, name, node) {
63
+ for (const dep of DEPS) {
64
+ if (allowDuplicates.isAllowedDuplicate(dep, depsName)) {
65
+ continue;
66
+ }
67
+ const dupeNode = maps[dep].get(name);
68
+ if (dupeNode) {
69
+ report(name, dupeNode);
70
+ report(name, node);
71
+ }
72
+ }
73
+ }
74
+ function defineVisitor(depsName) {
75
+ return (node) => {
76
+ const name = String((0, ast_utils_1.getKeyFromJSONProperty)(node));
77
+ verify(depsName, name, node);
78
+ maps[depsName].set(name, node);
79
+ };
80
+ }
81
+ return (0, utils_1.defineJsonVisitor)({
82
+ dependencies: defineVisitor("dependencies"),
83
+ peerDependencies: defineVisitor("peerDependencies"),
84
+ optionalDependencies: defineVisitor("optionalDependencies"),
85
+ devDependencies: defineVisitor("devDependencies"),
86
+ });
87
+ },
88
+ });
@@ -0,0 +1,246 @@
1
+ "use strict";
2
+ Object.defineProperty(exports, "__esModule", { value: true });
3
+ const utils_1 = require("../utils");
4
+ const regexp_1 = require("../utils/regexp");
5
+ const semver_1 = require("semver");
6
+ const semver_2 = require("../utils/semver");
7
+ const ast_utils_1 = require("../utils/ast-utils");
8
+ const jsonc_eslint_parser_1 = require("jsonc-eslint-parser");
9
+ const meta_1 = require("../utils/meta");
10
+ const DEPS = [
11
+ "dependencies",
12
+ "peerDependencies",
13
+ "optionalDependencies",
14
+ ];
15
+ class Deps {
16
+ constructor() {
17
+ this.map = Object.create(null);
18
+ this.list = [];
19
+ }
20
+ push(name, ver) {
21
+ const version = (0, semver_2.getSemverRange)(ver);
22
+ if (version) {
23
+ const range = this.map[name];
24
+ if (range) {
25
+ const newRange = (0, semver_2.normalizeSemverRange)(range, version);
26
+ this.map[name] = newRange;
27
+ }
28
+ else {
29
+ this.map[name] = version;
30
+ }
31
+ return;
32
+ }
33
+ this.list.push([name, ver]);
34
+ }
35
+ pop() {
36
+ const resultForList = this.list.shift();
37
+ if (resultForList) {
38
+ return resultForList;
39
+ }
40
+ const [key] = Object.keys(this.map);
41
+ if (key) {
42
+ const range = this.map[key];
43
+ delete this.map[key];
44
+ return [key, (0, semver_2.normalizeVer)(range)];
45
+ }
46
+ return null;
47
+ }
48
+ }
49
+ class DeepValidateContext {
50
+ constructor(context, validator) {
51
+ this.deepValidatedCache = new Map();
52
+ this.context = context;
53
+ this.validator = validator;
54
+ }
55
+ buildDeepValidator(deepOption) {
56
+ return (n, v) => this.deepDepsValidate(n, v, deepOption);
57
+ }
58
+ deepDepsValidate(packageName, version, deepOption) {
59
+ const { validator: validate, context } = this;
60
+ const depsQueue = new Deps();
61
+ depsQueue.push(packageName, version);
62
+ let dep;
63
+ while ((dep = depsQueue.pop())) {
64
+ const key = `${dep[0]}@${dep[1]}`;
65
+ if (this.deepValidatedCache.has(key)) {
66
+ const result = this.deepValidatedCache.get(key);
67
+ if (result) {
68
+ return result;
69
+ }
70
+ }
71
+ else {
72
+ const result = validateWithoutCache(dep[0], dep[1]);
73
+ this.deepValidatedCache.set(key, result);
74
+ if (result) {
75
+ return result;
76
+ }
77
+ }
78
+ }
79
+ return null;
80
+ function validateWithoutCache(name, ver) {
81
+ const result = validate(name, ver);
82
+ if (result) {
83
+ return result;
84
+ }
85
+ for (const [n, v] of iterateDeps(name, ver)) {
86
+ const r = validate(n, v);
87
+ if (r) {
88
+ return r;
89
+ }
90
+ depsQueue.push(n, v);
91
+ }
92
+ return null;
93
+ }
94
+ function* iterateDeps(name, ver) {
95
+ yield* iterateDepsForMeta((0, meta_1.getMetaFromNodeModules)(name, ver, context));
96
+ if (deepOption === "server") {
97
+ const metaData = (0, meta_1.getMetaFromNpm)(name, ver);
98
+ for (const meta of metaData.cache) {
99
+ yield* iterateDepsForMeta(meta);
100
+ }
101
+ const metaList = metaData.get();
102
+ if (metaList) {
103
+ for (const meta of metaList) {
104
+ yield* iterateDepsForMeta(meta);
105
+ }
106
+ }
107
+ }
108
+ }
109
+ function* iterateDepsForMeta(meta) {
110
+ if (!meta) {
111
+ return;
112
+ }
113
+ for (const depName of DEPS) {
114
+ const deps = meta[depName];
115
+ if (!deps) {
116
+ continue;
117
+ }
118
+ for (const [n, v] of Object.entries(deps)) {
119
+ if (typeof v === "string") {
120
+ yield [n, v];
121
+ }
122
+ }
123
+ }
124
+ }
125
+ }
126
+ }
127
+ exports.default = (0, utils_1.createRule)("no-restricted-deps", {
128
+ meta: {
129
+ docs: {
130
+ description: "Disallows dependence on the specified package.",
131
+ category: "Best Practices",
132
+ recommended: false,
133
+ },
134
+ schema: {
135
+ type: "array",
136
+ items: {
137
+ oneOf: [
138
+ {
139
+ type: "string",
140
+ },
141
+ {
142
+ type: "object",
143
+ properties: {
144
+ package: { type: "string" },
145
+ version: { type: "string" },
146
+ message: { type: "string" },
147
+ deep: { enum: ["local", "server"] },
148
+ },
149
+ required: ["package"],
150
+ additionalProperties: false,
151
+ },
152
+ ],
153
+ },
154
+ uniqueItems: true,
155
+ minItems: 0,
156
+ },
157
+ messages: {
158
+ restricted: "{{message}}",
159
+ },
160
+ type: "suggestion",
161
+ },
162
+ create(context) {
163
+ if (!context.parserServices.isJSON) {
164
+ return {};
165
+ }
166
+ const validateForPackage = parseOptions(context.options);
167
+ function defineVisitor(_depsName) {
168
+ return (node) => {
169
+ const name = String((0, ast_utils_1.getKeyFromJSONProperty)(node));
170
+ const ver = String((0, jsonc_eslint_parser_1.getStaticJSONValue)(node.value));
171
+ const result = validateForPackage(name, ver);
172
+ if (!result) {
173
+ return;
174
+ }
175
+ context.report({
176
+ loc: node.loc,
177
+ messageId: "restricted",
178
+ data: result,
179
+ });
180
+ };
181
+ }
182
+ return (0, utils_1.defineJsonVisitor)({
183
+ dependencies: defineVisitor("dependencies"),
184
+ peerDependencies: defineVisitor("peerDependencies"),
185
+ optionalDependencies: defineVisitor("optionalDependencies"),
186
+ devDependencies: defineVisitor("devDependencies"),
187
+ });
188
+ function matchVersions(version, optionVersion) {
189
+ if (!optionVersion) {
190
+ return true;
191
+ }
192
+ const range = (0, semver_2.getSemverRange)(version);
193
+ return Boolean(range && (0, semver_1.intersects)(range, optionVersion));
194
+ }
195
+ function parseOption(option) {
196
+ if (typeof option === "string") {
197
+ const regexp = (0, regexp_1.toRegExp)(option);
198
+ return (n, _v) => {
199
+ if (regexp.test(n)) {
200
+ return {
201
+ message: `Depend on '${option}' is not allowed.`,
202
+ };
203
+ }
204
+ return null;
205
+ };
206
+ }
207
+ const regexp = (0, regexp_1.toRegExp)(option.package);
208
+ const version = option.version
209
+ ? (0, semver_2.getSemverRange)(option.version)
210
+ : null;
211
+ const validator = (n, v) => {
212
+ if (regexp.test(n) && matchVersions(v, version)) {
213
+ return {
214
+ message: option.message || buildDefaultMessage(option),
215
+ };
216
+ }
217
+ return null;
218
+ };
219
+ if (!option.deep) {
220
+ return validator;
221
+ }
222
+ const deepValidateContext = new DeepValidateContext(context, validator);
223
+ return deepValidateContext.buildDeepValidator(option.deep);
224
+ function buildDefaultMessage(objectOption) {
225
+ const versionForMessage = objectOption.version
226
+ ? `@${objectOption.version}`
227
+ : "";
228
+ if (objectOption.package.startsWith("/") && versionForMessage) {
229
+ return `Depend on '${objectOption.package} ${versionForMessage}' is not allowed.`;
230
+ }
231
+ return `Depend on '${objectOption.package}${versionForMessage}' is not allowed.`;
232
+ }
233
+ }
234
+ function parseOptions(options) {
235
+ const validators = options.map(parseOption);
236
+ return (packageName, version) => {
237
+ for (const validator of validators) {
238
+ const result = validator(packageName, version);
239
+ if (result)
240
+ return result;
241
+ }
242
+ return null;
243
+ };
244
+ }
245
+ },
246
+ });
@@ -0,0 +1,99 @@
1
+ "use strict";
2
+ Object.defineProperty(exports, "__esModule", { value: true });
3
+ const semver_1 = require("semver");
4
+ const utils_1 = require("../utils");
5
+ const semver_2 = require("../utils/semver");
6
+ const semver_range_1 = require("../utils/semver-range");
7
+ exports.default = (0, utils_1.createRule)("prefer-caret-range-version", {
8
+ meta: {
9
+ docs: {
10
+ description: "require caret(`^`) version instead of range version.",
11
+ category: "Stylistic Issues",
12
+ recommended: false,
13
+ },
14
+ fixable: "code",
15
+ schema: [],
16
+ messages: {},
17
+ type: "suggestion",
18
+ },
19
+ create(context) {
20
+ if (!context.parserServices.isJSON) {
21
+ return {};
22
+ }
23
+ const sourceCode = context.getSourceCode();
24
+ function convertToUseCaret(range) {
25
+ if (range.comparators.length !== 2) {
26
+ return null;
27
+ }
28
+ const start = range.comparators.find((c) => c.operator === ">=");
29
+ const end = range.comparators.find((c) => c.operator === "<");
30
+ if (!start || !end) {
31
+ return null;
32
+ }
33
+ const caretRangeText = `^${start.semver.version}`;
34
+ const caretRange = (0, semver_2.getSemverRange)(caretRangeText);
35
+ if (!caretRange) {
36
+ return null;
37
+ }
38
+ const caretEnd = caretRange.set[0].find((c) => c.operator === "<");
39
+ if (!caretEnd) {
40
+ return null;
41
+ }
42
+ if (caretEnd.semver.compare(end.semver) !== 0) {
43
+ const endPre = new semver_1.SemVer(`${end.semver.version}-0`);
44
+ if (caretEnd.semver.compare(endPre) !== 0) {
45
+ return null;
46
+ }
47
+ }
48
+ return caretRangeText;
49
+ }
50
+ function verifyRange(range, node) {
51
+ const fixedRange = convertToUseCaret(range);
52
+ if (!fixedRange) {
53
+ return;
54
+ }
55
+ context.report({
56
+ loc: {
57
+ start: sourceCode.getLocFromIndex(node.range[0] + range.range[0]),
58
+ end: sourceCode.getLocFromIndex(node.range[0] + range.range[1]),
59
+ },
60
+ message: `Use '${fixedRange}' syntax instead.`,
61
+ fix(fixer) {
62
+ return fixer.replaceTextRange(node.range, JSON.stringify(node.value.slice(0, range.range[0]) +
63
+ fixedRange +
64
+ node.value.slice(range.range[1])));
65
+ },
66
+ });
67
+ }
68
+ function verifyVersion(node) {
69
+ if (maybeDepId(node.value)) {
70
+ return;
71
+ }
72
+ for (const range of (0, semver_range_1.iterateSemverRanges)(node.value)) {
73
+ const lowerRange = range.value.toLowerCase();
74
+ if (!lowerRange.startsWith("~")) {
75
+ if (lowerRange.startsWith("^") ||
76
+ /^\d+$/u.test(range.value) ||
77
+ ((range.value.endsWith(".x") ||
78
+ range.value.endsWith(".*")) &&
79
+ !/\s+-\s+/u.test(range.value)))
80
+ continue;
81
+ }
82
+ verifyRange(range, node);
83
+ }
84
+ }
85
+ return (0, utils_1.defineJsonVisitor)({
86
+ "engines, dependencies, peerDependencies, devDependencies, optionalDependencies"(node) {
87
+ if (isJSONStringLiteral(node.value)) {
88
+ verifyVersion(node.value);
89
+ }
90
+ },
91
+ });
92
+ },
93
+ });
94
+ function isJSONStringLiteral(node) {
95
+ return node.type === "JSONLiteral" && typeof node.value === "string";
96
+ }
97
+ function maybeDepId(ver) {
98
+ return ver.includes("/") || ver.includes(":") || /^[-a-z]+$/.test(ver);
99
+ }
@@ -0,0 +1,100 @@
1
+ "use strict";
2
+ Object.defineProperty(exports, "__esModule", { value: true });
3
+ const semver_1 = require("semver");
4
+ const utils_1 = require("../utils");
5
+ const semver_2 = require("../utils/semver");
6
+ const semver_range_1 = require("../utils/semver-range");
7
+ exports.default = (0, utils_1.createRule)("prefer-tilde-range-version", {
8
+ meta: {
9
+ docs: {
10
+ description: "require tilde(`~`) version instead of range version.",
11
+ category: "Stylistic Issues",
12
+ recommended: false,
13
+ },
14
+ fixable: "code",
15
+ schema: [],
16
+ messages: {},
17
+ type: "suggestion",
18
+ },
19
+ create(context) {
20
+ if (!context.parserServices.isJSON) {
21
+ return {};
22
+ }
23
+ const sourceCode = context.getSourceCode();
24
+ function convertToUseTilde(range) {
25
+ if (range.comparators.length !== 2) {
26
+ return null;
27
+ }
28
+ const start = range.comparators.find((c) => c.operator === ">=");
29
+ const end = range.comparators.find((c) => c.operator === "<");
30
+ if (!start || !end) {
31
+ return null;
32
+ }
33
+ const tildeRangeText = `~${start.semver.version}`;
34
+ const tildeRange = (0, semver_2.getSemverRange)(tildeRangeText);
35
+ if (!tildeRange) {
36
+ return null;
37
+ }
38
+ const tildeEnd = tildeRange.set[0].find((c) => c.operator === "<");
39
+ if (!tildeEnd) {
40
+ return null;
41
+ }
42
+ if (tildeEnd.semver.compare(end.semver) !== 0) {
43
+ const endPre = new semver_1.SemVer(`${end.semver.version}-0`);
44
+ if (tildeEnd.semver.compare(endPre) !== 0) {
45
+ return null;
46
+ }
47
+ }
48
+ return tildeRangeText;
49
+ }
50
+ function verifyRange(range, node) {
51
+ const fixedRange = convertToUseTilde(range);
52
+ if (!fixedRange) {
53
+ return;
54
+ }
55
+ context.report({
56
+ loc: {
57
+ start: sourceCode.getLocFromIndex(node.range[0] + range.range[0]),
58
+ end: sourceCode.getLocFromIndex(node.range[0] + range.range[1]),
59
+ },
60
+ message: `Use '${fixedRange}' syntax instead.`,
61
+ fix(fixer) {
62
+ return fixer.replaceTextRange(node.range, JSON.stringify(node.value.slice(0, range.range[0]) +
63
+ fixedRange +
64
+ node.value.slice(range.range[1])));
65
+ },
66
+ });
67
+ }
68
+ function verifyVersion(node) {
69
+ if (maybeDepId(node.value)) {
70
+ return;
71
+ }
72
+ for (const range of (0, semver_range_1.iterateSemverRanges)(node.value)) {
73
+ const lowerRange = range.value.toLowerCase();
74
+ if (!lowerRange.startsWith("^")) {
75
+ if (lowerRange.startsWith("~") ||
76
+ /^\d+$/u.test(range.value) ||
77
+ /^\d+\.\d+$/u.test(range.value) ||
78
+ ((range.value.endsWith(".x") ||
79
+ range.value.endsWith(".*")) &&
80
+ !/\s+-\s+/u.test(range.value)))
81
+ continue;
82
+ }
83
+ verifyRange(range, node);
84
+ }
85
+ }
86
+ return (0, utils_1.defineJsonVisitor)({
87
+ "engines, dependencies, peerDependencies, devDependencies, optionalDependencies"(node) {
88
+ if (isJSONStringLiteral(node.value)) {
89
+ verifyVersion(node.value);
90
+ }
91
+ },
92
+ });
93
+ },
94
+ });
95
+ function isJSONStringLiteral(node) {
96
+ return node.type === "JSONLiteral" && typeof node.value === "string";
97
+ }
98
+ function maybeDepId(ver) {
99
+ return ver.includes("/") || ver.includes(":") || /^[-a-z]+$/.test(ver);
100
+ }
@@ -36,7 +36,7 @@ exports.default = (0, utils_1.createRule)("valid-semver", {
36
36
  });
37
37
  }
38
38
  },
39
- "dependencies, peerDependencies, devDependencies"(node) {
39
+ "dependencies, peerDependencies, devDependencies, optionalDependencies"(node) {
40
40
  const name = (0, ast_utils_1.getKeyFromJSONProperty)(node);
41
41
  if (typeof name !== "string") {
42
42
  return;
@@ -10,7 +10,8 @@ function getKeyFromJSONProperty(node) {
10
10
  exports.getKeyFromJSONProperty = getKeyFromJSONProperty;
11
11
  function getKey(node) {
12
12
  let parent = node.parent;
13
- while (parent.type === "JSONUnaryExpression") {
13
+ while (parent.type === "JSONUnaryExpression" ||
14
+ parent.type === "JSONBinaryExpression") {
14
15
  parent = parent.parent;
15
16
  }
16
17
  if (parent.type === "JSONExpressionStatement") {
@@ -18,6 +18,7 @@ const NPM_INFO_PROPERTIES = [
18
18
  "deprecated",
19
19
  "dependencies",
20
20
  "peerDependencies",
21
+ "optionalDependencies",
21
22
  "dist-tags",
22
23
  ];
23
24
  const CACHED_META_ROOT = path_1.default.join(__dirname, `../../.cached_meta`);
@@ -0,0 +1,21 @@
1
+ "use strict";
2
+ Object.defineProperty(exports, "__esModule", { value: true });
3
+ exports.toRegExp = void 0;
4
+ function toRegExp(str) {
5
+ const regexp = parseRegExp(str);
6
+ if (regexp) {
7
+ return regexp;
8
+ }
9
+ return { test: (s) => s === str };
10
+ }
11
+ exports.toRegExp = toRegExp;
12
+ function parseRegExp(str) {
13
+ if (!str.startsWith("/")) {
14
+ return null;
15
+ }
16
+ const lastSlashIndex = str.lastIndexOf("/");
17
+ if (lastSlashIndex <= 1) {
18
+ return null;
19
+ }
20
+ return new RegExp(str.slice(1, lastSlashIndex), str.slice(lastSlashIndex + 1));
21
+ }
@@ -4,13 +4,23 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
4
4
  };
5
5
  Object.defineProperty(exports, "__esModule", { value: true });
6
6
  exports.rules = void 0;
7
+ const absolute_version_1 = __importDefault(require("../rules/absolute-version"));
7
8
  const compat_engines_1 = __importDefault(require("../rules/compat-engines"));
8
9
  const no_deprecated_1 = __importDefault(require("../rules/no-deprecated"));
10
+ const no_dupe_deps_1 = __importDefault(require("../rules/no-dupe-deps"));
11
+ const no_restricted_deps_1 = __importDefault(require("../rules/no-restricted-deps"));
12
+ const prefer_caret_range_version_1 = __importDefault(require("../rules/prefer-caret-range-version"));
13
+ const prefer_tilde_range_version_1 = __importDefault(require("../rules/prefer-tilde-range-version"));
9
14
  const valid_engines_1 = __importDefault(require("../rules/valid-engines"));
10
15
  const valid_semver_1 = __importDefault(require("../rules/valid-semver"));
11
16
  exports.rules = [
17
+ absolute_version_1.default,
12
18
  compat_engines_1.default,
13
19
  no_deprecated_1.default,
20
+ no_dupe_deps_1.default,
21
+ no_restricted_deps_1.default,
22
+ prefer_caret_range_version_1.default,
23
+ prefer_tilde_range_version_1.default,
14
24
  valid_engines_1.default,
15
25
  valid_semver_1.default,
16
26
  ];
@@ -0,0 +1,38 @@
1
+ "use strict";
2
+ Object.defineProperty(exports, "__esModule", { value: true });
3
+ exports.iterateSemverRanges = void 0;
4
+ const semver_1 = require("./semver");
5
+ function* iterateSemverRanges(versionRanges) {
6
+ let startOffset = 0;
7
+ for (const strRange of versionRanges.split("||")) {
8
+ const result = toRangeResult(strRange, startOffset);
9
+ if (result) {
10
+ yield result;
11
+ }
12
+ startOffset += strRange.length + 2;
13
+ }
14
+ }
15
+ exports.iterateSemverRanges = iterateSemverRanges;
16
+ function toRangeResult(strRange, startOffset) {
17
+ let start = 0;
18
+ while (strRange.length > start && !strRange[start].trim()) {
19
+ start++;
20
+ }
21
+ let end = strRange.length;
22
+ while (end > start && !strRange[end - 1].trim()) {
23
+ end--;
24
+ }
25
+ const value = strRange.slice(start, end);
26
+ const range = (0, semver_1.getSemverRange)(value);
27
+ if (!range) {
28
+ return null;
29
+ }
30
+ if (range.set.length !== 1) {
31
+ return null;
32
+ }
33
+ return {
34
+ value,
35
+ comparators: range.set[0],
36
+ range: [startOffset + start, startOffset + end],
37
+ };
38
+ }
@@ -1,6 +1,6 @@
1
1
  "use strict";
2
2
  Object.defineProperty(exports, "__esModule", { value: true });
3
- exports.maxNextVersion = exports.normalizeSemverRange = exports.normalizeVer = exports.getSemverRange = void 0;
3
+ exports.isAnyComparator = exports.maxNextVersion = exports.normalizeSemverRange = exports.normalizeVer = exports.getSemverRange = void 0;
4
4
  const semver_1 = require("semver");
5
5
  function getSemverRange(value) {
6
6
  if (value == null) {
@@ -171,7 +171,7 @@ function maxNextVersion(range) {
171
171
  let max = null;
172
172
  let hasMin = false;
173
173
  for (const comparator of comparators) {
174
- if (!comparator.semver.version) {
174
+ if (isAnyComparator(comparator)) {
175
175
  return null;
176
176
  }
177
177
  const compVer = new semver_1.SemVer(comparator.semver.version);
@@ -204,3 +204,7 @@ function maxNextVersion(range) {
204
204
  return maxVer;
205
205
  }
206
206
  exports.maxNextVersion = maxNextVersion;
207
+ function isAnyComparator(comparator) {
208
+ return !comparator.semver.version;
209
+ }
210
+ exports.isAnyComparator = isAnyComparator;
package/package.json CHANGED
@@ -1,6 +1,6 @@
1
1
  {
2
2
  "name": "eslint-plugin-node-dependencies",
3
- "version": "0.5.1",
3
+ "version": "0.8.0",
4
4
  "description": "ESLint plugin to check Node.js dependencies.",
5
5
  "engines": {
6
6
  "node": "^12 || >=14"
@@ -41,6 +41,7 @@
41
41
  "json"
42
42
  ],
43
43
  "author": "Yosuke Ota (https://github.com/ota-meshi)",
44
+ "funding": "https://github.com/sponsors/ota-meshi",
44
45
  "license": "MIT",
45
46
  "bugs": {
46
47
  "url": "https://github.com/ota-meshi/eslint-plugin-node-dependencies/issues"
@@ -52,12 +53,12 @@
52
53
  "devDependencies": {
53
54
  "@ota-meshi/eslint-plugin": "^0.10.0",
54
55
  "@types/chai": "^4.2.18",
55
- "@types/eslint": "^7.2.0",
56
+ "@types/eslint": "^8.0.0",
56
57
  "@types/eslint-scope": "^3.7.0",
57
58
  "@types/eslint-visitor-keys": "^1.0.0",
58
- "@types/estree": "^0.0.50",
59
+ "@types/estree": "^0.0.51",
59
60
  "@types/mocha": "^9.0.0",
60
- "@types/node": "^14.14.39",
61
+ "@types/node": "^16.0.0",
61
62
  "@types/npm-package-arg": "^6.1.1",
62
63
  "@types/semver": "^7.3.8",
63
64
  "@typescript-eslint/eslint-plugin": "^5.0.0",
@@ -68,14 +69,14 @@
68
69
  "eslint-config-prettier": "^8.0.0",
69
70
  "eslint-plugin-eslint-comments": "^3.2.0",
70
71
  "eslint-plugin-eslint-plugin": "^4.0.0",
71
- "eslint-plugin-json-schema-validator": "^1.0.9",
72
- "eslint-plugin-jsonc": "^1.0.0",
72
+ "eslint-plugin-json-schema-validator": "^2.0.0",
73
+ "eslint-plugin-jsonc": "^2.0.0",
73
74
  "eslint-plugin-node": "^11.1.0",
74
- "eslint-plugin-node-dependencies": "^0.5.0",
75
+ "eslint-plugin-node-dependencies": "^0.7.0",
75
76
  "eslint-plugin-prettier": "^4.0.0",
76
77
  "eslint-plugin-regexp": "^1.0.0",
77
- "eslint-plugin-vue": "^7.5.0",
78
- "eslint-plugin-yml": "^0.10.0",
78
+ "eslint-plugin-vue": "^8.0.0",
79
+ "eslint-plugin-yml": "^0.14.0",
79
80
  "eslint4b": "^7.3.1",
80
81
  "mocha": "^9.0.0",
81
82
  "mocha-chai-jest-snapshot": "^1.1.2",
@@ -83,8 +84,9 @@
83
84
  "prettier": "^2.0.5",
84
85
  "raw-loader": "^4.0.1",
85
86
  "stylelint": "^14.0.0",
86
- "stylelint-config-standard": "^23.0.0",
87
- "stylelint-plugin-stylus": "^0.11.0",
87
+ "stylelint-config-recommended-vue": "^1.0.0",
88
+ "stylelint-config-standard": "^25.0.0",
89
+ "stylelint-plugin-stylus": "^0.13.0",
88
90
  "ts-node": "^10.0.0",
89
91
  "typescript": "^4.0.0",
90
92
  "vue-eslint-editor": "^1.1.0",
@@ -92,7 +94,7 @@
92
94
  "vuepress": "^1.5.2"
93
95
  },
94
96
  "dependencies": {
95
- "jsonc-eslint-parser": "^1.1.0",
97
+ "jsonc-eslint-parser": "^1 || ^2.0.2",
96
98
  "npm-package-arg": "^8.1.5",
97
99
  "semver": "^7.3.5"
98
100
  }