eslint-plugin-no-mistakes 0.93.0 → 0.95.0

package/README.md

@@ -47,6 +47,13 @@ See [options and examples](../../docs/eslint-rules/no-comment-phrases.md).
 `forbidden-member-chains` is an opt-in rule for configured static member-access chains.
 See [options and examples](../../docs/eslint-rules/forbidden-member-chains.md).
 
+`no-object-mutation` is an opt-in rule for shared object writes and mutating calls.
+See [options and examples](../../docs/eslint-rules/no-object-mutation.md).
+
+`postgres-no-async-sql-builder` is an opt-in rule for async SQL builders that never wait.
+It suggests removing `async` only when the visible contract allows a synchronous return, and it never autofixes.
+See [options and examples](../../docs/eslint-rules/postgres-no-async-sql-builder.md).
+
 `require-options-on-imported-call` requires a static options object on configured
 imports, globals with no local binding, and terminal methods with a matching receiver shape.
 See [options and examples](../../docs/eslint-rules/require-options-on-imported-call.md).

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-no-mistakes",
-  "version": "0.93.0",
+  "version": "0.95.0",
   "description": "ESLint and Oxlint rules that keep code static enough for no-mistakes analyzers and coding agents",
   "license": "MIT",
   "repository": {
@@ -22,10 +22,10 @@
   },
   "devDependencies": {
     "@typescript-eslint/parser": "^8.71.1",
-    "@vitest/coverage-v8": "^5.0.3",
+    "@vitest/coverage-v8": "^5.0.4",
     "eslint": "^10.12.0",
     "oxlint": "^1.87.0",
-    "vitest": "^5.0.3"
+    "vitest": "^5.0.4"
   },
   "peerDependencies": {
     "eslint": ">=9"

package/src/component-functions.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const { literalString } = require("./helpers");
+
 function nonEmptyStrings(value, fallback) {
   if (!Array.isArray(value)) {
     return fallback;
@@ -23,7 +25,7 @@ function unwrapExpression(node, opts) {
   if (node.type !== "CallExpression" || !isConfiguredWrapper(node.callee, opts)) {
     return node;
   }
-  for (const arg of node.arguments) {
+  for (const arg of wrapperArguments(node)) {
     const unwrapped = unwrapExpression(arg, opts);
     if (isFunctionNode(unwrapped)) {
       return unwrapped;
@@ -32,19 +34,49 @@ function unwrapExpression(node, opts) {
   return node;
 }
 
+function wrapperArguments(node) {
+  const args = node.arguments || [];
+  const name = staticCalleeName(node.callee);
+  if (name !== "call" && name !== "apply") return args;
+  if (args.some((arg) => arg?.type === "SpreadElement")) return [];
+  if (name === "call") return args.slice(1);
+  const list = args[1];
+  if (
+    list?.type !== "ArrayExpression" ||
+    list.elements.some((element) => !element || element.type === "SpreadElement")
+  ) {
+    return [];
+  }
+  return list.elements;
+}
+
 function isConfiguredWrapper(callee, opts) {
   const name = calleeName(callee);
   return Boolean(name && opts.wrappers.has(name));
 }
 
+function staticCalleeName(node) {
+  if (!node || node.type !== "MemberExpression") return null;
+  if (node.computed && node.property?.type === "Identifier") return null;
+  if (!node.computed && typeof node.property?.name === "string") return node.property.name;
+  return literalString(node.property);
+}
+
 function calleeName(node) {
-  if (node.type === "Identifier") {
-    return node.name;
-  }
-  if (node.type === "MemberExpression" && !node.computed) {
-    return node.property.name;
+  let current = node;
+  for (let depth = 0; depth < 4; depth += 1) {
+    while (current?.type === "ChainExpression") current = current.expression;
+    if (current?.type === "MemberExpression") {
+      const name = staticCalleeName(current);
+      if (name === "call" || name === "apply") {
+        current = current.object;
+        continue;
+      }
+      return name;
+    }
+    break;
   }
-  return null;
+  return current?.type === "Identifier" ? current.name : null;
 }
 
 function isFunctionNode(node) {

package/src/exported-component-definitions.js

@@ -0,0 +1,32 @@
+"use strict";
+
+const { functionFromExpression } = require("./component-functions");
+
+function collectTopLevelDefinition(statement, definitions, opts, aliases, exported) {
+  if (statement.type === "FunctionDeclaration" && statement.id) {
+    definitions.set(statement.id.name, { name: statement.id.name, fn: statement });
+    return;
+  }
+  if (statement.type !== "VariableDeclaration") {
+    return;
+  }
+  for (const declaration of statement.declarations) {
+    if (declaration.id.type !== "Identifier") {
+      continue;
+    }
+    const fn = functionFromExpression(declaration.init, opts);
+    if (fn) {
+      definitions.set(declaration.id.name, { name: declaration.id.name, fn });
+      continue;
+    }
+    if (declaration.init?.type === "Identifier" && declaration.parent?.kind === "const") {
+      aliases.push({
+        name: declaration.id.name,
+        target: declaration.init.name,
+        exported,
+      });
+    }
+  }
+}
+
+module.exports = { collectTopLevelDefinition };

package/src/exported-components.js

@@ -1,6 +1,7 @@
 "use strict";
 
 const { functionFromExpression, nonEmptyStrings } = require("./component-functions");
+const { collectTopLevelDefinition } = require("./exported-component-definitions");
 
 const DEFAULT_COMPONENT_NAME_PATTERN = "^[A-Z]";
 const DEFAULT_WRAPPERS = ["memo", "forwardRef", "observer"];
@@ -66,17 +67,34 @@ function collectExportedComponents(program, opts) {
   const namedExports = new Set();
   const defaultExports = new Set();
   const components = [];
+  const aliases = [];
 
   for (const statement of program.body) {
-    collectTopLevelDefinition(statement, definitions, opts);
+    collectTopLevelDefinition(statement, definitions, opts, aliases, false);
     if (statement.type === "ExportNamedDeclaration") {
-      collectNamedExport(statement, definitions, namedExports, defaultExports, components, opts);
+      collectNamedExport(
+        statement,
+        definitions,
+        namedExports,
+        defaultExports,
+        components,
+        opts,
+        aliases,
+      );
     }
     if (statement.type === "ExportDefaultDeclaration") {
       collectDefaultExport(statement, definitions, defaultExports, components, opts);
     }
   }
 
+  for (const alias of aliases) {
+    const target = definitions.get(alias.target);
+    if (!target) continue;
+    const definition = { name: alias.name, fn: target.fn };
+    definitions.set(alias.name, definition);
+    if (alias.exported && opts.exportTypes.has("named")) components.push(definition);
+  }
+
   pushExportedDefinitions(namedExports, definitions, components, opts.exportTypes.has("named"));
   pushExportedDefinitions(defaultExports, definitions, components, opts.exportTypes.has("default"));
   return uniqueComponents(components);
@@ -94,25 +112,6 @@ function pushExportedDefinitions(names, definitions, components, enabled) {
   }
 }
 
-function collectTopLevelDefinition(statement, definitions, opts) {
-  if (statement.type === "FunctionDeclaration" && statement.id) {
-    definitions.set(statement.id.name, { name: statement.id.name, fn: statement });
-    return;
-  }
-  if (statement.type !== "VariableDeclaration") {
-    return;
-  }
-  for (const declaration of statement.declarations) {
-    if (declaration.id.type !== "Identifier") {
-      continue;
-    }
-    const fn = functionFromExpression(declaration.init, opts);
-    if (fn) {
-      definitions.set(declaration.id.name, { name: declaration.id.name, fn });
-    }
-  }
-}
-
 function collectNamedExport(
   statement,
   definitions,
@@ -120,6 +119,7 @@ function collectNamedExport(
   defaultExports,
   components,
   opts,
+  aliases,
 ) {
   if (statement.source) {
     return;
@@ -133,7 +133,7 @@ function collectNamedExport(
     return;
   }
   if (statement.declaration?.type === "VariableDeclaration") {
-    collectTopLevelDefinition(statement.declaration, definitions, opts);
+    collectTopLevelDefinition(statement.declaration, definitions, opts, aliases, true);
     for (const declaration of statement.declaration.declarations) {
       const definition = definitions.get(declaration.id.name);
       if (declaration.id.type === "Identifier" && definition && opts.exportTypes.has("named")) {

package/src/fetch-call.js

@@ -0,0 +1,102 @@
+"use strict";
+
+const { unwrapExpression } = require("./rules/async-ast");
+const { logicalCall, memberPropertyName, propertyName } = require("./rules/module-mock-helpers");
+
+const LOCAL_BINDING_TYPES = new Set([
+  "Variable",
+  "Parameter",
+  "CatchClause",
+  "FunctionName",
+  "ImportBinding",
+  "ClassName",
+]);
+const FETCH_ROOTS = new Set(["globalThis", "window", "self", "global"]);
+
+function isFetchShadowed(scope) {
+  while (scope) {
+    const get = scope.set?.get;
+    const variable = typeof get === "function" ? get.call(scope.set, "fetch") : null;
+    if (variable) return variable.defs.some((def) => LOCAL_BINDING_TYPES.has(def.type));
+    if (!scope.set || typeof get !== "function") {
+      const fallback = scope.variables?.find((item) => item.name === "fetch");
+      if (fallback) return fallback.defs.some((def) => LOCAL_BINDING_TYPES.has(def.type));
+    }
+    scope = scope.upper;
+  }
+  return false;
+}
+
+function unboundRoot(node, context) {
+  if (node?.type !== "Identifier" || !FETCH_ROOTS.has(node.name)) return false;
+  let scope = context.sourceCode.getScope(node);
+  while (scope) {
+    const variable = scope.variables?.find((item) => item.name === node.name);
+    if (variable) return !variable.defs?.some((def) => LOCAL_BINDING_TYPES.has(def.type));
+    scope = scope.upper;
+  }
+  return true;
+}
+
+function bindingVariable(node, context) {
+  if (!context?.sourceCode?.getScope) return null;
+  let scope = context.sourceCode.getScope(node);
+  while (scope) {
+    const variable = scope.variables?.find((item) => item.name === node.name);
+    if (variable) return variable;
+    scope = scope.upper;
+  }
+  return null;
+}
+
+function fetchCallee(node, context, seen) {
+  node = unwrapExpression(node);
+  if (!node) return false;
+  const visiting = seen || new Set();
+  if (node.type === "MemberExpression") {
+    if (memberPropertyName(node) !== "fetch") return false;
+    return unboundRoot(unwrapExpression(node.object), context);
+  }
+  if (node.type === "Identifier") {
+    if (node.name === "fetch" && !isFetchShadowed(context?.sourceCode?.getScope?.(node)))
+      return true;
+    const variable = bindingVariable(node, context);
+    if (!variable || visiting.has(variable) || variable.defs.length !== 1) return false;
+    visiting.add(variable);
+    const def = variable.defs[0];
+    if (def.type !== "Variable" || def.parent?.kind !== "const") return false;
+    if (def.node.id.type === "Identifier") {
+      if (!def.node.init) return false;
+      return fetchCallee(def.node.init, context, visiting);
+    }
+    if (def.node.id.type !== "ObjectPattern") return false;
+    for (const item of def.node.id.properties) {
+      if (item.type === "Property") {
+        const value = item.value.type === "AssignmentPattern" ? item.value.left : item.value;
+        // `const { [name]: schedule }` names an expression, not the fetch property.
+        if (item.computed && item.key?.type === "Identifier") continue;
+        if (
+          value.type === "Identifier" &&
+          value.name === node.name &&
+          propertyName(item.key) === "fetch"
+        ) {
+          return unboundRoot(unwrapExpression(def.node.init), context);
+        }
+      }
+    }
+    return false;
+  }
+  return false;
+}
+
+function fetchInvocation(node, context) {
+  const invoked = logicalCall(node);
+  if (!invoked?.callee || !fetchCallee(invoked.callee, context)) return null;
+  return invoked.arguments;
+}
+
+function isFetchCall(node, context) {
+  return fetchInvocation(node, context) !== null;
+}
+
+module.exports = { fetchInvocation, isFetchCall };

package/src/helpers.js

@@ -1,5 +1,7 @@
 "use strict";
 
+const { fetchInvocation, isFetchCall } = require("./fetch-call");
+
 const DEFAULT_SELECTOR_ATTRIBUTES = ["data-testid", "data-pw"];
 const DEFAULT_NAMING_PATTERN = "^[a-z][a-z0-9]*(?:-[a-z0-9]+)*$";
 const INTERACTIVE_ELEMENTS = new Set(["button", "input", "select", "textarea"]);
@@ -134,40 +136,6 @@ function selectorValueNode(attribute) {
   return expression && expression.type !== "JSXEmptyExpression" ? expression : null;
 }
 
-const LOCAL_BINDING_TYPES = new Set([
-  "Variable",
-  "Parameter",
-  "CatchClause",
-  "FunctionName",
-  "ImportBinding",
-  "ClassName",
-]);
-
-function isFetchShadowed(scope) {
-  while (scope) {
-    const get = scope.set?.get;
-    const variable = typeof get === "function" ? get.call(scope.set, "fetch") : null;
-    if (variable) {
-      return variable.defs.some((def) => LOCAL_BINDING_TYPES.has(def.type));
-    }
-    if (!scope.set || typeof get !== "function") {
-      const fallback = scope.variables?.find((item) => item.name === "fetch");
-      if (fallback) {
-        return fallback.defs.some((def) => LOCAL_BINDING_TYPES.has(def.type));
-      }
-    }
-    scope = scope.upper;
-  }
-  return false;
-}
-
-function isFetchCall(node, context) {
-  if (node.callee.type !== "Identifier" || node.callee.name !== "fetch") {
-    return false;
-  }
-  return !isFetchShadowed(context.sourceCode.getScope(node));
-}
-
 function rule(meta, create) {
   return { meta, create };
 }
@@ -179,6 +147,7 @@ module.exports = {
   canonicalAttribute,
   cssSelectorValues,
   INTERACTIVE_ELEMENTS,
+  fetchInvocation,
   isFetchCall,
   isSelectorAttribute,
   isSelectorCall,

package/src/index.js

@@ -17,6 +17,7 @@ const rules = {
   "no-banned-import-outside-allowed-paths": require("./rules/no-banned-import-outside-allowed-paths"),
   "no-global-fetch-outside-helper": require("./rules/no-global-fetch-outside-helper"),
   "no-delete-property": require("./rules/no-delete-property"),
+  "no-object-mutation": require("./rules/no-object-mutation"),
   "no-import-only-test-files": require("./rules/no-import-only-test-files"),
   "no-inline-noop-promise-catch": require("./rules/no-inline-noop-promise-catch"),
   "no-placeholder-never-type-exports": require("./rules/no-placeholder-never-type-exports"),
@@ -37,7 +38,11 @@ const rules = {
   "react-no-iife-in-jsx": require("./rules/react-no-iife-in-jsx"),
   "playwright-unique": require("./rules/playwright-unique"),
   "postgres-cursor-call-contract": require("./rules/postgres-cursor-call-contract"),
+  "postgres-no-async-sql-builder": require("./rules/postgres-no-async-sql-builder"),
+  "postgres-no-correlated-sql-builder": require("./rules/postgres-no-correlated-sql-builder"),
+  "postgres-no-executor-adapter": require("./rules/postgres-no-executor-adapter"),
   "postgres-no-manual-transaction": require("./rules/postgres-no-manual-transaction"),
+  "postgres-no-nonliteral-sql-registry-key": require("./rules/postgres-no-nonliteral-sql-registry-key"),
   "postgres-no-unbounded-query-fanout": require("./rules/postgres-no-unbounded-query-fanout"),
   "react-no-nullish-react-node": require("./rules/react-no-nullish-react-node"),
   "react-no-use-promise-resolve": require("./rules/react-no-use-promise-resolve"),

package/src/rule-suppression.js

@@ -6,6 +6,7 @@ function ruleSuppression(context, ruleId, suppressionOptions) {
   const lines = new Set();
   let file = false;
   const source = context.sourceCode;
+  if (!source?.ast?.tokens || !source.getAllComments) return () => false;
   const first = source.ast.tokens[0];
   const requireReason = suppressionOptions?.requireReason === true;
   for (const comment of source.getAllComments()) {

package/src/rules/argv-main-values.js

@@ -1,7 +1,7 @@
 "use strict";
 const { unwrapExpression } = require("./async-ast");
 const { resolveVariable, memberPropertyName, isLocalRequire } = require("./async-target-bindings");
-const { literalString } = require("./module-mock-helpers");
+const { literalString, logicalCall } = require("./module-mock-helpers");
 
 function globalName(node, name, context) {
   if (node?.type !== "Identifier" || node.name !== name) return false;
@@ -51,6 +51,25 @@ function createClassifier(context, wrappers) {
       if (nodeProcess(node, context)) return PROCESS;
       if (globalName(node, "__filename", context)) return MAIN;
       const def = variable.defs.length === 1 ? variable.defs[0] : null;
+      if (def?.type === "ImportBinding" && def.node?.type === "ImportSpecifier") {
+        const imported = def.node.imported;
+        const importedName = imported?.type === "Literal" ? String(imported.value) : imported?.name;
+        if (
+          importedName === "argv" &&
+          ["process", "node:process"].includes(def.parent?.source?.value)
+        ) {
+          return ARGUMENTS;
+        }
+      }
+      if (
+        def?.type === "Variable" &&
+        def.parent?.kind === "const" &&
+        def.node?.id?.type === "ObjectPattern"
+      ) {
+        const key = objectPatternKey(def.node.id, node.name);
+        if (key === "argv" && classify(def.node.init, depth + 1) === PROCESS) return ARGUMENTS;
+        return 0;
+      }
       if (
         def?.type !== "Variable" ||
         def.parent.kind !== "const" ||
@@ -75,13 +94,7 @@ function createClassifier(context, wrappers) {
         return MAIN;
       const object = classify(node.object, depth + 1);
       if (object === PROCESS && name === "argv") return ARGUMENTS;
-      if (
-        object === ARGUMENTS &&
-        node.computed &&
-        node.property.type === "Literal" &&
-        node.property.value === 1
-      )
-        return ARGV;
+      if (object === ARGUMENTS && node.computed && staticIndexOne(node.property)) return ARGV;
       // A URL conversion's href preserves the same module/argv identity.
       if (
         name === "href" &&
@@ -91,19 +104,20 @@ function createClassifier(context, wrappers) {
         return object;
     }
     if (node.type === "CallExpression") {
-      const callee = unwrapExpression(node.callee);
+      const invoked = logicalCall(node);
+      if (!invoked) return 0;
+      const callee = unwrapExpression(invoked.callee);
       if (
         callee?.type === "MemberExpression" &&
         memberPropertyName(callee) === "at" &&
         classify(callee.object, depth + 1) === ARGUMENTS &&
-        node.arguments.length === 1 &&
-        node.arguments[0].type === "Literal" &&
-        node.arguments[0].value === 1
+        invoked.arguments.length === 1 &&
+        staticIndexOne(invoked.arguments[0])
       )
         return ARGV;
-      if (node.arguments.length !== 1 || node.arguments[0].type === "SpreadElement") return 0;
+      if (invoked.arguments.length !== 1 || invoked.arguments[0].type === "SpreadElement") return 0;
       if (globalName(callee, "Boolean", context) || wrappers.resolveCallTarget(node)) {
-        const value = classify(node.arguments[0], depth + 1);
+        const value = classify(invoked.arguments[0], depth + 1);
         return value === ARGV || value === MAIN ? value : 0;
       }
     }
@@ -111,4 +125,23 @@ function createClassifier(context, wrappers) {
   }
   return (node) => classify(node);
 }
+function staticIndexOne(node) {
+  if (!node) return false;
+  if (node.type === "Literal") return node.value === 1 || node.value === "1";
+  return literalString(node) === "1";
+}
+
+function objectPatternKey(pattern, name) {
+  for (const property of pattern.properties) {
+    if (property.type !== "Property") continue;
+    const value =
+      property.value.type === "AssignmentPattern" ? property.value.left : property.value;
+    if (value.type !== "Identifier" || value.name !== name) continue;
+    if (property.key.type === "Identifier" && !property.computed) return property.key.name;
+    if (property.key.type === "Literal") return String(property.key.value);
+    return literalString(property.key);
+  }
+  return null;
+}
+
 module.exports = { createClassifier, ARGV, MAIN };

package/src/rules/async-ast.js

@@ -6,6 +6,7 @@ const transparentExpressionTypes = new Set([
   "TSAsExpression",
   "TSTypeAssertion",
   "TSSatisfiesExpression",
+  "TSInstantiationExpression",
 ]);
 
 function isFunction(node) {
@@ -24,6 +25,18 @@ function findContainingFunction(node) {
   }
 }
 
+function findContainingRoot(node) {
+  return findContainingFunction(node) ?? findProgram(node);
+}
+
+function findProgram(node) {
+  let current = node;
+  while (current) {
+    if (current.type === "Program") return current;
+    current = current.parent;
+  }
+}
+
 function isTransparentExpression(node) {
   return transparentExpressionTypes.has(node?.type);
 }
@@ -34,6 +47,14 @@ function unwrapExpression(node) {
   return current;
 }
 
+function unwrapSequence(node) {
+  let current = unwrapExpression(node);
+  while (current?.type === "SequenceExpression") {
+    current = unwrapExpression(current.expressions.at(-1));
+  }
+  return current;
+}
+
 function unwrapTransparentParent(node) {
   let current = node;
   while (isTransparentExpression(current.parent)) current = current.parent;
@@ -81,10 +102,12 @@ function isUnconditionalBeforeReturn(node, block) {
 
 module.exports = {
   findContainingFunction,
+  findContainingRoot,
   isFunction,
   isTransparentExpression,
   isUnconditionalBeforeReturn,
   traverse,
   unwrapExpression,
+  unwrapSequence,
   unwrapTransparentParent,
 };

package/src/rules/async-call-disposition.js

@@ -5,19 +5,21 @@ const {
   findContainingFunction,
   isFunction,
   isTransparentExpression,
+  unwrapExpression,
   unwrapTransparentParent,
 } = require("./async-ast");
 const { targetOptionsSchema } = require("./async-schema");
 const { createTargetMatcher, memberPropertyName } = require("./async-targets");
 
 function isPromiseAllCall(node) {
+  const callee = unwrapExpression(node?.callee);
+  const object = unwrapExpression(callee?.object);
   return (
     node?.type === "CallExpression" &&
-    node.callee.type === "MemberExpression" &&
-    !node.callee.computed &&
-    node.callee.object.type === "Identifier" &&
-    node.callee.object.name === "Promise" &&
-    memberPropertyName(node.callee) === "all"
+    callee?.type === "MemberExpression" &&
+    object?.type === "Identifier" &&
+    object.name === "Promise" &&
+    memberPropertyName(callee) === "all"
   );
 }
 

package/src/rules/async-target-bindings.js

@@ -64,6 +64,29 @@ function recordObjectPatternBindings(pattern, source, recordDirect) {
   }
 }
 
+function stableConstInitializer(node, context, seen) {
+  if (node?.type !== "Identifier") return null;
+  const variable = resolveVariable(node, context);
+  if (
+    !variable ||
+    seen.has(variable) ||
+    variable.defs.length !== 1 ||
+    isReassigned(node, context)
+  ) {
+    return null;
+  }
+  const def = variable.defs[0];
+  if (
+    def.type !== "Variable" ||
+    def.parent?.kind !== "const" ||
+    def.node?.id?.type !== "Identifier"
+  ) {
+    return null;
+  }
+  seen.add(variable);
+  return def.node.init;
+}
+
 function namespaceSourceFromInit(init, context, namespaceBindings) {
   const expression = unwrapExpression(init);
   if (expression?.type !== "Identifier") return null;
@@ -77,4 +100,5 @@ module.exports = {
   namespaceSourceFromInit,
   recordObjectPatternBindings,
   resolveVariable,
+  stableConstInitializer,
 };