eslint-plugin-no-mistakes 0.60.0 → 0.61.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-no-mistakes",
-  "version": "0.60.0",
+  "version": "0.61.0",
   "description": "ESLint and Oxlint rules that keep code static enough for no-mistakes analyzers and coding agents",
   "license": "MIT",
   "repository": {

package/src/index.js

@@ -25,7 +25,6 @@ const rules = {
   "playwright-no-empty": require("./rules/playwright-no-empty"),
   "playwright-no-hoisted-unique-token": require("./rules/playwright-no-hoisted-unique-token"),
   "playwright-no-raw-scroll-pagination": require("./rules/playwright-no-raw-scroll-pagination"),
-  "playwright-no-set-timeout": require("./rules/playwright-no-set-timeout"),
   "playwright-prefer-get-by-test-id": require("./rules/playwright-prefer-get-by-test-id"),
   "playwright-require-exported-component-attribute": require("./rules/playwright-require-exported-component-attribute"),
   "playwright-require-interactive-test-id": require("./rules/playwright-require-interactive-test-id"),
@@ -92,7 +91,6 @@ plugin.configs.strict = {
     "no-mistakes/playwright-assertion-timeout-cap": "error",
     "no-mistakes/playwright-consistent-attribute": ["error", { canonicalAttribute: "data-pw" }],
     "no-mistakes/playwright-naming-convention": "error",
-    "no-mistakes/playwright-no-set-timeout": "error",
     "no-mistakes/playwright-prefer-get-by-test-id": "warn",
     "no-mistakes/playwright-require-interactive-test-id": "warn",
     "no-mistakes/playwright-selector-priority": "error",

package/src/rules/playwright-no-raw-scroll-pagination.js

@@ -33,8 +33,8 @@ function propertyName(node) {
 }
 
 // `page.waitForRequest(...)` / `page.waitForResponse(...)`, matched by property name only — the
-// object (page, frame, a locator, ...) doesn't matter, mirroring how `playwright-no-set-timeout`
-// matches `.waitForTimeout` regardless of receiver. A statically computed access
+// object (page, frame, a locator, ...) does not affect the cursor relationship.
+// A statically computed access
 // (`page["waitForRequest"]`) is just as unambiguous as dot access and is matched the same way.
 function isCursorWaitCall(node) {
   return (

package/src/rules/playwright-no-set-timeout.js

@@ -1,68 +0,0 @@
-"use strict";
-
-const { rule } = require("../helpers");
-
-const PLAYWRIGHT_PATH_PATTERN =
-  /(?:^|[/\\])(?:e2e|playwright)(?:[/\\]|$)|(?:^|[/\\])e2e\.(?:spec|test)\.[cm]?[jt]sx?$|\.pw\.(?:spec|test)\.[cm]?[jt]sx?$/;
-
-function isPlaywrightPath(filename) {
-  return PLAYWRIGHT_PATH_PATTERN.test(filename.replace(/\\/g, "/"));
-}
-
-function isWaitForTimeout(node) {
-  return (
-    node.callee.type === "MemberExpression" &&
-    propertyName(node.callee.property, node.callee.computed) === "waitForTimeout"
-  );
-}
-
-function propertyName(node, computed = false) {
-  if (node.type === "Literal") return String(node.value);
-  if (computed) return null;
-  return node.name;
-}
-
-function isGlobalSetTimeout(node, context) {
-  let scope = context.sourceCode.getScope(node);
-  while (scope) {
-    const get = scope.set?.get;
-    const variable =
-      typeof get === "function"
-        ? get.call(scope.set, "setTimeout")
-        : scope.variables.find((candidate) => candidate.name === "setTimeout");
-    if (variable) return variable.defs.length === 0;
-    scope = scope.upper;
-  }
-  return true;
-}
-
-module.exports = rule(
-  {
-    type: "problem",
-    docs: { description: "disallow fixed sleeps in Playwright tests", recommended: false },
-    schema: [],
-    messages: {
-      timeout:
-        "Do not use fixed sleeps (setTimeout()/waitForTimeout()) in Playwright tests. Wait for an observable condition instead.",
-    },
-  },
-  (context) => {
-    let isPlaywrightFile = isPlaywrightPath(context.filename);
-    return {
-      ImportDeclaration(node) {
-        if (node.source.value === "@playwright/test") isPlaywrightFile = true;
-      },
-      CallExpression(node) {
-        if (!isPlaywrightFile) return;
-        if (
-          (node.callee.type === "Identifier" &&
-            node.callee.name === "setTimeout" &&
-            isGlobalSetTimeout(node.callee, context)) ||
-          isWaitForTimeout(node)
-        ) {
-          context.report({ node, messageId: "timeout" });
-        }
-      },
-    };
-  },
-);