eslint-plugin-no-mistakes 0.12.0 → 0.13.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-no-mistakes",
-  "version": "0.12.0",
+  "version": "0.13.0",
   "description": "ESLint and Oxlint rules for deterministic no-mistakes code analysis",
   "license": "MIT",
   "repository": {
@@ -23,8 +23,8 @@
   "devDependencies": {
     "@typescript-eslint/parser": "^8.48.0",
     "@vitest/coverage-v8": "^4.1.6",
-    "eslint": "^10.3.0",
-    "oxlint": "^1.64.0",
+    "eslint": "^10.4.0",
+    "oxlint": "^1.65.0",
     "vitest": "^4.1.6"
   },
   "peerDependencies": {

package/src/rules/test-no-shared-state-helpers.js

@@ -2,6 +2,7 @@
 
 const TEST_CALLEES = new Set(["it", "test", "describe"]);
 const SETUP_CALLEES = new Set(["beforeEach", "afterEach", "beforeAll", "afterAll"]);
+const PER_TEST_CALLEES = new Set(["beforeEach", "afterEach"]);
 const MUTATING_METHODS = new Set(
   "add clear copyWithin delete fill pop push reverse set shift sort splice unshift".split(" "),
 );
@@ -25,15 +26,13 @@ function isTestCall(node) {
 
 function setupCallbackKind(node) {
   const name = calleeName(node.callee);
-  return name === "beforeEach" || name === "afterEach"
-    ? "per-test"
-    : name === "beforeAll" || name === "afterAll"
-      ? "once"
-      : null;
-}
-
-function isSetupCall(node) {
-  return SETUP_CALLEES.has(calleeName(node.callee));
+  if (PER_TEST_CALLEES.has(name)) return "per-test";
+  if (name === "beforeAll") return "before-once";
+  if (name === "afterAll") return "once";
+  if (node.callee.type !== "MemberExpression" || !TEST_CALLEES.has(name)) return null;
+  if (PER_TEST_CALLEES.has(node.callee.property.name)) return "per-test";
+  if (node.callee.property.name === "beforeAll") return "before-once";
+  return node.callee.property.name === "afterAll" ? "once" : null;
 }
 
 function collectPatternNames(node, names = new Set()) {
@@ -101,7 +100,8 @@ function isInlineTestCallback(node) {
 }
 
 function isInlineSetupCallback(node) {
-  return node.parent?.type === "CallExpression" && isSetupCall(node.parent);
+  const p = node.parent;
+  return p?.type === "CallExpression" && SETUP_CALLEES.has(calleeName(p.callee));
 }
 
 function isCalledFunction(node) {
@@ -152,12 +152,13 @@ function firstNamedCallbackArgument(args) {
   return args[0]?.type === "Identifier" ? args[0] : undefined;
 }
 
-function createCleanupTracker() {
+function createCleanupTracker(options = {}) {
   const pathsBySuite = new Map();
   const suiteStack = [];
-  let activeSuiteKey;
-  let replaySuiteKey;
+  let activeSuiteKey, replaySuiteKey;
   let nextSuiteId = 0;
+  const ao = options.allowBeforeAllAssignments;
+  const sKinds = new Set(ao ? ["per-test", "before-once"] : ["per-test"]);
 
   function currentSuiteKey() {
     return replaySuiteKey ?? suiteStack.join("/");
@@ -175,7 +176,7 @@ function createCleanupTracker() {
 
   return {
     beginSetup(kind, suiteKey = currentSuiteKey()) {
-      activeSuiteKey = kind === "per-test" ? suiteKey : undefined;
+      activeSuiteKey = sKinds.has(kind) ? suiteKey : undefined;
     },
     clearReplaySuite() {
       replaySuiteKey = undefined;
@@ -194,8 +195,7 @@ function createCleanupTracker() {
     remember(path) {
       if (!path || activeSuiteKey === undefined) return;
       const paths = pathsBySuite.get(activeSuiteKey) ?? new Set();
-      paths.add(path);
-      pathsBySuite.set(activeSuiteKey, paths);
+      pathsBySuite.set(activeSuiteKey, paths.add(path));
     },
     setReplaySuite(suiteKey) {
       replaySuiteKey = suiteKey;
@@ -214,7 +214,6 @@ module.exports = {
   isInlineTestCallback,
   isMutableInitializer,
   calleeName,
-  isSetupCall,
   isTestCall,
   mutatingCallPropertyName,
   mutatingCallTarget,

package/src/rules/test-no-shared-state.js

@@ -31,7 +31,7 @@ module.exports = rule(
   {
     type: "problem",
     docs: { description: "disallow mutable module-scope test state", recommended: false },
-    schema: [],
+    schema: [{ type: "object", properties: { allowBeforeAllAssignments: { type: "boolean" } } }],
     messages: {
       shared:
         "Shared mutable module-scope state between tests: use local variables inside each test instead.",
@@ -41,7 +41,8 @@ module.exports = rule(
     const mutableTopLevel = new Set();
     const pendingNamedCallbacks = [];
     const pendingNamedSetupCallbacks = [];
-    const cleanupTracker = createCleanupTracker();
+    const ruleOptions = context.options?.[0] ?? {};
+    const cleanupTracker = createCleanupTracker(ruleOptions);
     const viMockTracker = createViMockTracker(context, mutableTopLevel);
     const registryReports = createRegistryReports(
       context,
@@ -166,7 +167,7 @@ module.exports = rule(
         if (isTestCall(node)) {
           testDepth += 1;
           const callback = namedCallbackArgument(node.arguments);
-          if (callback) {
+          if (callback && !setupCallbackKind(node)) {
             pendingNamedCallbacks.push({
               declaration: resolveFunctionCallback(node, callback),
               suiteKey: cleanupTracker.currentSuiteKey(),

package/src/rules/vitest-mock-test-file-naming.js

@@ -19,6 +19,20 @@ const MOCK_METHODS = new Set([
   "setSystemTime",
 ]);
 
+const MOCK_CHAIN_METHODS = new Set([
+  "mockImplementation",
+  "mockImplementationOnce",
+  "mockReturnValue",
+  "mockReturnValueOnce",
+  "mockResolvedValue",
+  "mockResolvedValueOnce",
+  "mockRejectedValue",
+  "mockRejectedValueOnce",
+  "mockReset",
+  "mockRestore",
+  "mockClear",
+]);
+
 function isTestFile(filename) {
   return TEST_FILE_PATTERN.test(filename.replace(/\\/g, "/"));
 }
@@ -83,9 +97,13 @@ module.exports = rule(
   },
   (context) => {
     let usesMocking = false;
+    function isMockChainCall(node) {
+      if (node.callee.type !== "MemberExpression") return false;
+      return MOCK_CHAIN_METHODS.has(propertyName(node.callee.property));
+    }
     return {
       CallExpression(node) {
-        if (isMockingCall(node, context)) usesMocking = true;
+        if (isMockingCall(node, context) || isMockChainCall(node)) usesMocking = true;
       },
       "Program:exit"(node) {
         if (!isTestFile(context.filename)) return;