eslint-plugin-no-mistakes 0.11.0 → 0.12.0

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-no-mistakes",
-  "version": "0.11.0",
+  "version": "0.12.0",
   "description": "ESLint and Oxlint rules for deterministic no-mistakes code analysis",
   "license": "MIT",
   "repository": {

package/src/helpers.js

@@ -134,14 +134,28 @@ function selectorValueNode(attribute) {
   return expression && expression.type !== "JSXEmptyExpression" ? expression : null;
 }
 
-const LOCAL_BINDING_TYPES = new Set(["Variable", "Parameter", "CatchClause", "FunctionName"]);
+const LOCAL_BINDING_TYPES = new Set([
+  "Variable",
+  "Parameter",
+  "CatchClause",
+  "FunctionName",
+  "ImportBinding",
+  "ClassName",
+]);
 
 function isFetchShadowed(scope) {
   while (scope) {
-    const variable = scope.variables.find((v) => v.name === "fetch");
+    const get = scope.set?.get;
+    const variable = typeof get === "function" ? get.call(scope.set, "fetch") : null;
     if (variable) {
       return variable.defs.some((def) => LOCAL_BINDING_TYPES.has(def.type));
     }
+    if (!scope.set || typeof get !== "function") {
+      const fallback = scope.variables?.find((item) => item.name === "fetch");
+      if (fallback) {
+        return fallback.defs.some((def) => LOCAL_BINDING_TYPES.has(def.type));
+      }
+    }
     scope = scope.upper;
   }
   return false;

package/src/returned-jsx.js

@@ -17,7 +17,9 @@ function collectReturnBranches(node, branches) {
     return;
   }
   if (node.type === "ReturnStatement") {
-    branches.push(...jsxBranches(node.argument));
+    for (const branch of jsxBranches(node.argument)) {
+      branches.push(branch);
+    }
     return;
   }
   if (node.type === "ClassDeclaration" || node.type === "ClassExpression") {
@@ -101,7 +103,11 @@ function childNodes(node) {
       continue;
     }
     if (Array.isArray(value)) {
-      children.push(...value.filter(isAstNode));
+      for (const child of value) {
+        if (isAstNode(child)) {
+          children.push(child);
+        }
+      }
     } else if (isAstNode(value)) {
       children.push(value);
     }

package/src/rules/playwright-no-set-timeout.js

@@ -25,7 +25,11 @@ function propertyName(node, computed = false) {
 function isGlobalSetTimeout(node, context) {
   let scope = context.sourceCode.getScope(node);
   while (scope) {
-    const variable = scope.variables.find((candidate) => candidate.name === "setTimeout");
+    const get = scope.set?.get;
+    const variable =
+      typeof get === "function"
+        ? get.call(scope.set, "setTimeout")
+        : scope.variables.find((candidate) => candidate.name === "setTimeout");
     if (variable) return variable.defs.length === 0;
     scope = scope.upper;
   }

package/src/rules/test-no-shared-state-analysis.js

@@ -23,17 +23,24 @@ function isInsideUncalledNestedFunction(node, testDepth, setupDepth) {
   return false;
 }
 
-function isModuleMutable(context, mutableTopLevel, node, name) {
+function isModuleMutable({ context, mutableTopLevel, node, name }) {
   let scope = context.sourceCode.getScope(node);
   while (scope) {
-    const variable = scope.variables.find((candidate) => candidate.name === name);
-    if (variable) {
-      return (
-        mutableTopLevel.has(variable.name) &&
-        (variable.scope.type === "module" || variable.scope.block.type === "Program")
-      );
+    const get = scope.set?.get;
+    const variable = typeof get === "function" ? get.call(scope.set, name) : null;
+    const resolvedVariable =
+      variable ||
+      (typeof get !== "function" ? scope.variables?.find((item) => item.name === name) : null);
+
+    if (!resolvedVariable) {
+      scope = scope.upper;
+      continue;
     }
-    scope = scope.upper;
+
+    return (
+      mutableTopLevel.has(resolvedVariable.name) &&
+      (resolvedVariable.scope.type === "module" || resolvedVariable.scope.block.type === "Program")
+    );
   }
   return false;
 }
@@ -112,7 +119,7 @@ function createRegistryReports(context, mutableTopLevel, cleanupTracker, isCaptu
         testDepth > 0 &&
         setupDepth === 0 &&
         !isCaptured(name) &&
-        isModuleMutable(context, mutableTopLevel, node, name)
+        isModuleMutable({ context, mutableTopLevel, node, name })
       ) {
         pending.push({ node, path, suiteKey: cleanupTracker.currentSuiteKey() });
       }

package/src/rules/test-no-shared-state.js

@@ -1,6 +1,7 @@
 "use strict";
 
 const { rule } = require("../helpers");
+
 const {
   createRegistryReports,
   createViMockTracker,
@@ -9,6 +10,7 @@ const {
   isResetAssignment,
   walkSharedMutations,
 } = require("./test-no-shared-state-analysis");
+
 const {
   calleeName,
   collectPatternNames,
@@ -56,10 +58,9 @@ module.exports = rule(
         testDepth > 0 &&
         setupDepth === 0 &&
         !viMockTracker.isCaptured(name) &&
-        isModuleMutable(context, mutableTopLevel, node, name)
-      ) {
+        isModuleMutable({ context, mutableTopLevel, node, name })
+      )
         context.report({ node, messageId: "shared" });
-      }
     }
 
     function reportAssignment(node) {
@@ -73,10 +74,9 @@ module.exports = rule(
         name &&
         setupDepth > 0 &&
         mutableTopLevel.has(name) &&
-        isModuleMutable(context, mutableTopLevel, node, name)
-      ) {
+        isModuleMutable({ context, mutableTopLevel, node, name })
+      )
         cleanupTracker.remember(path);
-      }
     }
 
     function rememberCall(node) {
@@ -97,16 +97,36 @@ module.exports = rule(
       rememberSetupCleanup(node, mutationRootName(node.left), mutationPath(node.left.object));
     }
 
+    const mutationWalk = {
+      onAssignment: (assignment) => {
+        rememberAssignmentCleanup(assignment);
+        reportAssignment(assignment);
+      },
+      onCall: rememberCall,
+      onUpdate: (update) => reportIfShared(update, mutationRootName(update.argument)),
+    };
+
     function resolveFunctionCallback(node, callback) {
       let scope = context.sourceCode.getScope(node);
       while (scope) {
-        const variable = scope.variables.find((candidate) => candidate.name === callback.name);
-        const declaration = variable?.defs[0]?.node;
+        const get = scope.set?.get;
+        const resolvedVariable =
+          (typeof get === "function" ? get.call(scope.set, callback.name) : null) ||
+          (typeof get !== "function"
+            ? scope.variables?.find((item) => item.name === callback.name)
+            : null);
+
+        if (!resolvedVariable) {
+          scope = scope.upper;
+          continue;
+        }
+
+        const declaration = resolvedVariable.defs[0]?.node;
         if (declaration?.type === "FunctionDeclaration") return declaration;
         if (declaration?.type === "VariableDeclarator" && isFunctionNode(declaration.init)) {
           return declaration.init;
         }
-        scope = scope.upper;
+        return null;
       }
       return null;
     }
@@ -127,7 +147,7 @@ module.exports = rule(
           const previousSetupDepth = setupDepth;
           setupDepth = 1;
           cleanupTracker.beginSetup(kind, suiteKey);
-          checkSharedMutations(declaration.body);
+          walkSharedMutations(declaration.body, mutationWalk);
           setupDepth = previousSetupDepth;
           cleanupTracker.endSetup();
         }
@@ -135,7 +155,7 @@ module.exports = rule(
         for (const { declaration, suiteKey } of pendingNamedCallbacks) {
           if (!declaration) continue;
           cleanupTracker.setReplaySuite(suiteKey);
-          checkSharedMutations(declaration.body);
+          walkSharedMutations(declaration.body, mutationWalk);
           cleanupTracker.clearReplaySuite();
         }
         registryReports.flush();
@@ -154,15 +174,13 @@ module.exports = rule(
           }
         }
         const setupKind = setupCallbackKind(node);
-        if (setupKind) {
-          const callback = firstNamedCallbackArgument(node.arguments);
-          if (callback) {
-            pendingNamedSetupCallbacks.push({
-              declaration: resolveFunctionCallback(node, callback),
-              suiteKey: cleanupTracker.currentSuiteKey(),
-              kind: setupKind,
-            });
-          }
+        const setupCallback = setupKind && firstNamedCallbackArgument(node.arguments);
+        if (setupCallback) {
+          pendingNamedSetupCallbacks.push({
+            declaration: resolveFunctionCallback(node, setupCallback),
+            suiteKey: cleanupTracker.currentSuiteKey(),
+            kind: setupKind,
+          });
         }
         if (setupKind) {
           setupDepth += 1;
@@ -185,24 +203,9 @@ module.exports = rule(
           cleanupTracker.endSetup();
         }
         const isInsideNested = isInsideUncalledNestedFunction(node, testDepth, setupDepth);
-        if (!isInsideNested) {
-          rememberCall(node);
-        }
+        if (!isInsideNested) rememberCall(node);
         if (calleeName(node.callee) === "describe") cleanupTracker.exitSuite();
       },
     };
-
-    function checkSharedMutations(node) {
-      walkSharedMutations(node, {
-        onAssignment: (assignment) => {
-          rememberAssignmentCleanup(assignment);
-          reportAssignment(assignment);
-        },
-        onCall: (call) => {
-          rememberCall(call);
-        },
-        onUpdate: (update) => reportIfShared(update, mutationRootName(update.argument)),
-      });
-    }
   },
 );