eslint-plugin-no-jquery 2.4.0 → 2.7.0

package/src/rules/no-jquery-constructor.js

@@ -0,0 +1,31 @@
+'use strict';
+
+const utils = require( '../utils.js' );
+
+module.exports = {
+	meta: {
+		type: 'suggestion',
+		docs: {
+			description: 'Disallows the jQuery constructor `$()`.'
+		},
+		schema: []
+	},
+
+	create: function ( context ) {
+		return {
+			'CallExpression:exit': function ( node ) {
+				if (
+					node.callee.type !== 'Identifier' ||
+					!utils.isjQueryConstructor( context, node.callee.name )
+				) {
+					return;
+				}
+
+				context.report( {
+					node: node,
+					message: 'The jQuery constructor is not allowed'
+				} );
+			}
+		};
+	}
+};

package/src/rules/no-load-shorthand.js

@@ -14,7 +14,7 @@ module.exports = {
 
 	create: function ( context ) {
 		return {
-			CallExpression: function ( node ) {
+			'CallExpression:exit': function ( node ) {
 				if ( !(
 					node.callee.type === 'MemberExpression' &&
 					!utils.isjQueryConstructor( context, node.callee.object.name ) &&
@@ -30,7 +30,7 @@ module.exports = {
 					context.report( {
 						node: node,
 						message: 'Prefer .on or .trigger to .load',
-						fix: utils.eventShorthandFixer.bind( this, node )
+						fix: utils.eventShorthandFixer.bind( this, node, context )
 					} );
 				}
 			}

package/src/rules/no-noop.js

@@ -7,7 +7,7 @@ module.exports = utils.createUtilPropertyRule(
 	'Prefer `function(){}` to `$.noop`',
 	{
 		fixable: 'code',
-		fix: function ( node, fixer ) {
+		fix: function ( node, context, fixer ) {
 			return fixer.replaceText( node, '(function(){})' );
 		}
 	}

package/src/rules/no-now.js

@@ -4,10 +4,10 @@ const utils = require( '../utils.js' );
 
 module.exports = utils.createUtilMethodRule(
 	'now',
-	'Prefer `(new Date).getTime()` to `$.now`',
+	'Prefer `Date.now` to `$.now`',
 	{
 		fixable: 'code',
-		fix: function ( node, fixer ) {
+		fix: function ( node, context, fixer ) {
 			return fixer.replaceText( node.callee, 'Date.now' );
 		}
 	}

package/src/rules/no-on-ready.js

@@ -8,12 +8,13 @@ module.exports = {
 		docs: {
 			description: 'Disallows using the ready event on the document.'
 		},
+		fixable: 'code',
 		schema: []
 	},
 
 	create: function ( context ) {
 		return {
-			CallExpression: function ( node ) {
+			'CallExpression:exit': function ( node ) {
 				if (
 					node.callee.type !== 'MemberExpression' ||
 					node.callee.property.name !== 'on'
@@ -28,7 +29,21 @@ module.exports = {
 				if ( utils.isjQuery( context, node.callee ) ) {
 					context.report( {
 						node: node,
-						message: '.on("ready") is not allowed'
+						message: '.on("ready") is not allowed',
+						fix: function ( fixer ) {
+							if ( node.arguments.length > 1 ) {
+								return [
+									fixer.replaceText( node.callee.property, 'ready' ),
+									fixer.replaceTextRange(
+										[
+											node.arguments[ 0 ].range[ 0 ],
+											node.arguments[ 1 ].range[ 0 ]
+										],
+										''
+									)
+								];
+							}
+						}
 					} );
 				}
 			}

package/src/rules/no-other-methods.js

@@ -0,0 +1,121 @@
+'use strict';
+
+const utils = require( '../utils.js' );
+
+const methodsWithRules = [
+	'addClass',
+	'ajaxComplete',
+	'ajaxError',
+	'ajaxSend',
+	'ajaxStart',
+	'ajaxStop',
+	'ajaxSuccess',
+	'animate',
+	'attr',
+	'bind',
+	'blur',
+	'change',
+	'click',
+	'clone',
+	'closest',
+	'contextmenu',
+	'css',
+	'data',
+	'dblclick',
+	'delegate',
+	'die',
+	'each',
+	'fadeIn',
+	'fadeOut',
+	'fadeTo',
+	'fadeToggle',
+	'filter',
+	'find',
+	'focus',
+	'focusin',
+	'focusout',
+	'has',
+	'hasClass',
+	'hide',
+	'hover',
+	'html',
+	'is',
+	'keydown',
+	'keypress',
+	'keyup',
+	'live',
+	'load',
+	'map',
+	'mousedown',
+	'mouseenter',
+	'mouseleave',
+	'mousemove',
+	'mouseout',
+	'mouseover',
+	'mouseup',
+	'parent',
+	'parents',
+	'prop',
+	'ready',
+	'removeAttr',
+	'removeClass',
+	'removeData',
+	'removeProp',
+	'resize',
+	'scroll',
+	'select',
+	'serialize',
+	'serializeArray',
+	'show',
+	'size',
+	'slideDown',
+	'slideToggle',
+	'slideUp',
+	'submit',
+	'text',
+	'toggle',
+	'toggleClass',
+	'trigger',
+	'unbind',
+	'undelegate',
+	'unwrap',
+	'val',
+	'wrap',
+	'wrapAll',
+	'wrapInner'
+];
+
+module.exports = {
+	meta: {
+		type: 'suggestion',
+		docs: {
+			description: 'Disallows all methods not covered by more specific rules.'
+		},
+		schema: []
+	},
+
+	create: function ( context ) {
+		return {
+			'CallExpression:exit': function ( node ) {
+				if ( node.callee.type !== 'MemberExpression' ) {
+					return;
+				}
+				const name = node.callee.property.name;
+				if (
+					!name ||
+					methodsWithRules.includes( name ) ||
+					utils.isjQueryConstructor( context, node.callee.object.name )
+				) {
+					return;
+				}
+				if ( utils.isjQuery( context, node.callee ) ) {
+					context.report( {
+						node: node,
+						message: '.{{name}} is not allowed',
+						data: { name: name }
+					} );
+				}
+			}
+		};
+	}
+};

package/src/rules/no-other-utils.js

@@ -0,0 +1,88 @@
+'use strict';
+
+const utils = require( '../utils.js' );
+
+const utilsWithRules = [
+	'ajax',
+	'attr',
+	'camelCase',
+	'clone',
+	'contains',
+	'css',
+	'data',
+	'Deferred',
+	'each',
+	'error',
+	'escapeSelector',
+	'extend',
+	'filter',
+	'find',
+	'get',
+	'getJSON',
+	'getScript',
+	'globalEval',
+	'grep',
+	'hasData',
+	'holdReady',
+	'inArray',
+	'isArray',
+	'isEmptyObject',
+	'isFunction',
+	'isNumeric',
+	'isPlainObject',
+	'isWindow',
+	'map',
+	'merge',
+	'nodeName',
+	'noop',
+	'now',
+	'param',
+	'parseHTML',
+	'parseJSON',
+	'parseXML',
+	'post',
+	'prop',
+	'proxy',
+	'removeAttr',
+	'removeData',
+	'sub',
+	'text',
+	'trim',
+	'type',
+	'unique',
+	'when'
+];
+
+module.exports = {
+	meta: {
+		type: 'suggestion',
+		docs: {
+			description: 'Disallows all utilities not covered by more specific rules.'
+		},
+		schema: []
+	},
+
+	create: function ( context ) {
+		return {
+			'CallExpression:exit': function ( node ) {
+				if ( node.callee.type !== 'MemberExpression' ) {
+					return;
+				}
+				const name = node.callee.property.name;
+				if (
+					!name ||
+					utilsWithRules.includes( name ) ||
+					!utils.isjQueryConstructor( context, node.callee.object.name )
+				) {
+					return;
+				}
+
+				context.report( {
+					node: node,
+					message: '$.{{name}} is not allowed',
+					data: { name: name }
+				} );
+			}
+		};
+	}
+};

package/src/rules/no-parse-html-literal.js

@@ -40,8 +40,9 @@ module.exports = {
 				'The format of single tags can be specified using the `singleTagStyle` option:\n' +
 				'* `"minimal"` (default) no whitespace or self-closing i.e. `<div>`\n' +
 				'* `"self-closing"` no whitespace and self-closing i.e. `<div/>`\n' +
-				'* `"any"` no style enforced\n'
+				'* `"any"` no style enforced'
 		},
+		fixable: 'code',
 		schema: [
 			{
 				type: 'object',
@@ -57,7 +58,7 @@ module.exports = {
 
 	create: function ( context ) {
 		return {
-			CallExpression: function ( node ) {
+			'CallExpression:exit': function ( node ) {
 				let allowSingle,
 					message = 'Prefer DOM building to parsing HTML literals';
 
@@ -80,7 +81,7 @@ module.exports = {
 					) {
 						allowSingle = false;
 					} else if (
-						[ 'html', 'append', 'add' ].indexOf( node.callee.property.name ) !== -1 &&
+						[ 'html', 'append', 'add' ].includes( node.callee.property.name ) &&
 						utils.isjQuery( context, node )
 					) {
 						allowSingle = true;
@@ -91,6 +92,7 @@ module.exports = {
 					return;
 				}
 
+				let expectedTag;
 				const arg = node.arguments[ 0 ];
 				if ( allowSingle ) {
 					const value = arg && allLiteral( arg ) && joinLiterals( arg );
@@ -98,18 +100,21 @@ module.exports = {
 						// Empty or non-string, or non-HTML
 						return;
 					}
-					if ( rsingleTag.exec( value ) ) {
+					let match;
+					if ( ( match = rsingleTag.exec( value ) ) ) {
 						// Single tag
 						const singleTagStyle = ( context.options[ 0 ] && context.options[ 0 ].singleTagStyle ) || 'minimal';
 						if ( singleTagStyle === 'minimal' ) {
 							if ( !rsingleTagMinimal.exec( value ) ) {
-								message = 'Single tag must use the format: <tagname>';
+								expectedTag = '<' + match[ 1 ] + '>';
+								message = 'Single tag must use the format: ' + expectedTag;
 							} else {
 								return;
 							}
 						} else if ( singleTagStyle === 'self-closing' ) {
 							if ( !rsingleTagSelfClosing.exec( value ) ) {
-								message = 'Single tag must use the format: <tagname/>';
+								expectedTag = '<' + match[ 1 ] + '/>';
+								message = 'Single tag must use the format: ' + expectedTag;
 							} else {
 								return;
 							}
@@ -125,7 +130,13 @@ module.exports = {
 
 				context.report( {
 					node: node,
-					message: message
+					message: message,
+					fix: function ( fixer ) {
+						if ( expectedTag ) {
+							return fixer.replaceText( arg, '"' + expectedTag + '"' );
+						}
+						return null;
+					}
 				} );
 			}
 		};

package/src/rules/no-parse-json.js

@@ -7,7 +7,7 @@ module.exports = utils.createUtilMethodRule(
 	'Prefer `JSON.parse` to `$.parseJSON`',
 	{
 		fixable: 'code',
-		fix: function ( node, fixer ) {
+		fix: function ( node, context, fixer ) {
 			return fixer.replaceText( node.callee, 'JSON.parse' );
 		}
 	}

package/src/rules/no-parse-xml.js

@@ -4,5 +4,16 @@ const utils = require( '../utils.js' );
 
 module.exports = utils.createUtilMethodRule(
 	'parseXML',
-	'Prefer `DOMParser#parseFromString` to `$.parseXML`'
+	'Prefer `DOMParser#parseFromString` to `$.parseXML`',
+	{
+		fixable: 'code',
+		fix: function ( node, context, fixer ) {
+			if ( node.arguments.length ) {
+				return [
+					fixer.replaceText( node.callee, '( new window.DOMParser() ).parseFromString' ),
+					fixer.insertTextAfterRange( node.arguments[ 0 ].range, ', "text/xml"' )
+				];
+			}
+		}
+	}
 );

package/src/rules/no-proxy.js

@@ -4,5 +4,23 @@ const utils = require( '../utils.js' );
 
 module.exports = utils.createUtilMethodRule(
 	'proxy',
-	'Prefer `Function#bind` to `$.proxy`'
+	'Prefer `Function#bind` to `$.proxy`',
+	{
+		fixable: 'code',
+		fix: function ( node, context, fixer ) {
+			if (
+				node.arguments.length >= 2 &&
+				node.arguments[ 1 ].type !== 'Literal'
+			) {
+				const fnText = context.getSourceCode().getText( node.arguments[ 0 ] );
+				return [
+					fixer.replaceText( node.callee, fnText + '.bind' ),
+					fixer.removeRange( [
+						node.arguments[ 0 ].range[ 0 ],
+						node.arguments[ 1 ].range[ 0 ]
+					] )
+				];
+			}
+		}
+	}
 );

package/src/rules/no-ready-shorthand.js

@@ -4,5 +4,13 @@ const utils = require( '../utils.js' );
 
 module.exports = utils.createCollectionMethodRule(
 	'ready',
-	'Prefer `$()` to `.ready`'
+	'Prefer `$()` to `.ready`',
+	{
+		fixable: 'code',
+		fix: function ( node, context, fixer ) {
+			if ( node.parent.type === 'ExpressionStatement' ) {
+				return fixer.replaceText( node.callee, '$' );
+			}
+		}
+	}
 );

package/src/rules/no-ready.js

@@ -32,7 +32,7 @@ module.exports = {
 
 	create: function ( context ) {
 		return {
-			CallExpression: function ( node ) {
+			'CallExpression:exit': function ( node ) {
 				if ( isDirect( context, node ) || isChained( context, node ) ) {
 					context.report( {
 						node: node,

package/src/rules/no-size.js

@@ -7,8 +7,8 @@ module.exports = utils.createCollectionMethodRule(
 	'Prefer `.length` to `.size`',
 	{
 		fixable: 'code',
-		fix: function ( node, fixer ) {
-			return fixer.replaceTextRange( [ node.callee.property.start, node.end ], 'length' );
+		fix: function ( node, context, fixer ) {
+			return fixer.replaceTextRange( [ node.callee.property.range[ 0 ], node.range[ 1 ] ], 'length' );
 		}
 	}
 );

package/src/rules/no-sizzle.js

@@ -63,13 +63,13 @@ module.exports = {
 		];
 
 		return {
-			CallExpression: function ( node ) {
+			'CallExpression:exit': function ( node ) {
 				if (
 					!node.arguments[ 0 ] ||
 					!utils.isjQuery( context, node.callee ) ||
 					(
 						node.callee.type === 'MemberExpression' &&
-						traversals.indexOf( node.callee.property.name ) === -1
+						!traversals.includes( node.callee.property.name )
 					)
 				) {
 					return;

package/src/rules/no-submit.js

@@ -4,5 +4,6 @@ const utils = require( '../utils.js' );
 
 module.exports = utils.createCollectionMethodRule(
 	'submit',
-	'Prefer `EventTarget#dispatchEvent` + `HTMLFormElement#submit` to `.submit`'
+	'Prefer `EventTarget#dispatchEvent` + `HTMLFormElement#submit` to `.submit`',
+	{ deprecated: [ 'no-event-shorthand' ] }
 );

package/src/rules/no-unique.js

@@ -7,7 +7,7 @@ module.exports = utils.createUtilMethodRule(
 	'Prefer `$.uniqueSort` to `$.unique`',
 	{
 		fixable: 'code',
-		fix: function ( node, fixer ) {
+		fix: function ( node, context, fixer ) {
 			return fixer.replaceText( node.callee.property, 'uniqueSort' );
 		}
 	}

package/src/rules/variable-pattern.js

@@ -18,7 +18,8 @@ module.exports = {
 				// If the variable name is computed (e.g. foo[bar]) we
 				// can't be sure this is not correctly named.
 				!left.computed &&
-				utils.isjQuery( context, right )
+				// right can be null, e.g. `var x;`
+				right && utils.isjQuery( context, right )
 			) {
 				context.report( {
 					node: node,
@@ -28,10 +29,10 @@ module.exports = {
 		}
 
 		return {
-			AssignmentExpression: function ( node ) {
+			'AssignmentExpression:exit': function ( node ) {
 				test( node, node.left, node.right );
 			},
-			VariableDeclarator: function ( node ) {
+			'VariableDeclarator:exit': function ( node ) {
 				test( node, node.id, node.init );
 			}
 		};