eslint-plugin-no-arrow-this 1.2.0 → 1.3.0

package/dist/rules/no-arrow-this.js

@@ -0,0 +1,102 @@
+'use strict';
+
+module.exports = {
+	meta: {
+		type: 'suggestion',
+		docs: {
+			description: 'get rid of using "this" keyword in arrow functions',
+			category: 'code style~convention',
+			recommended: false
+		},
+		fixable: null,
+		schema: [
+			{
+				type: 'object',
+				properties: {
+					onlyGlobals: { type: 'boolean' }
+				},
+				additionalProperties: false
+			}
+		]
+	},
+	create (context) {
+		// lowercased name of AST Arrow Function
+		const AST_AF = 'ArrowFunctionExpression'.toLowerCase();
+		// lowercased name of AST Program Start
+		const AST_PRG = 'Program'.toLowerCase();
+
+		// Here are list of nodes for check breaking
+		// If one of them found, then everything is good
+		// And it is not necessary to check anymore else
+		const breakList = [
+			'FunctionDeclaration',
+			'FunctionExpression',
+			AST_PRG
+		].map(name => name.toLowerCase());
+
+		// This options allows to warn only situations
+		// When context of arrow function
+		// points Strict to Global or Window
+		const onlyGlobals = Boolean(
+			Array.isArray(context.options) &&
+			context.options[0] &&
+			context.options[0].onlyGlobals
+		);
+
+		// Warn message depends of onlyGlobals option
+		const name = onlyGlobals ? 'global "this"' : '"this"';
+
+		var type, parent;
+
+		// checking function depends of onlyGlobals
+		const prepareCheckFn = (node) => {
+			parent = node;
+
+			const switchParent = () => {
+				// switching AST node
+				// upper from current
+				parent = parent.parent;
+				type = parent.type.toLowerCase();
+			};
+
+			if (!onlyGlobals) {
+				return () => {
+					switchParent();
+					if (breakList.includes(type)) {
+						return null;
+					}
+					if (type === AST_AF) {
+						return true;
+					}
+					return false;
+				};
+			}
+
+			let found = false;
+			return () => {
+				switchParent();
+				if (breakList.includes(type)) {
+					return (found && type === AST_PRG) ? true : null;
+				}
+				if (type === AST_AF) {
+					found = true;
+				}
+				return false;
+			};
+
+		};
+
+		return {
+			ThisExpression (node) {
+				const check = prepareCheckFn(node);
+				var result = false;
+				while (result === false) {
+					result = check();
+				}
+				if (result) {
+					context.report({ node, message: `do not use ${name} in an arrow function` });
+				}
+			}
+		};
+	}
+};

package/example/index.js

@@ -1,31 +1,30 @@
 'use strict';
 
-const Linter = require('eslint').Linter;
-const linter = new Linter();
-
-linter.defineRules(require('../dist/index.js').rules);
+const { Linter } = require('eslint');
+const plugin = require('../dist/index.js');
 
+const linter = new Linter();
 const sample = require('fs').readFileSync('example/sample.js').toString();
 
-const config = require('../.eslintrc.js');
+const config = {
+	plugins: { 'no-arrow-this': plugin },
+	languageOptions: {
+		ecmaVersion: 2018,
+		sourceType: 'module'
+	},
+	rules: {}
+};
 
 console.log('\n1st test!');
 console.log('All suspicious condidions:\n\n');
-config.rules['no-arrow-this'] = 'warn';
-
-const results1 = linter.verify(
-	sample,
-	config
-);
+config.rules['no-arrow-this/no-arrow-this'] = 'warn';
+const results1 = linter.verify(sample, config);
 console.log(results1);
 
 console.log('\n\n2nd test!');
 console.log('Only [global~window] suspicious:\n\n');
-config.rules['no-arrow-this'] = ['warn', {
-	onlyGlobals : true
+config.rules['no-arrow-this/no-arrow-this'] = ['warn', {
+	onlyGlobals: true
 }];
-const results2 = linter.verify(
-	sample,
-	config
-);
-console.log(results2);
+const results2 = linter.verify(sample, config);
+console.log(results2);

package/package.json

@@ -1,12 +1,13 @@
 {
   "name": "eslint-plugin-no-arrow-this",
-  "version": "1.2.0",
+  "version": "1.3.0",
   "author": "went.out@gmail.com",
   "description": "ESLint rule plugin 4 warning \"this\" keyword inside of arrow functions",
   "main": "dist/index.js",
   "scripts": {
     "build": "rm -rf ./dist && mkdir ./dist && cp -r ./src/* ./dist",
-    "lint": "eslint src/ test/",
+    "prepack": "npm run build",
+    "lint": "eslint src/ test/ example/",
     "test": "mocha && echo 'NOW let me show an Example!' && npm run example",
     "example": "node example/index.js",
     "postinstall": "npm run build"
@@ -30,6 +31,7 @@
   },
   "files": [
     "README.md",
+    "dist",
     "src",
     "example"
   ],
@@ -44,15 +46,8 @@
   "engines": {
     "node": ">=8.11.3"
   },
-  "dependencies": {},
   "devDependencies": {
-    "babel-cli": "^6.26.0",
-    "babel-core": "^6.26.3",
-    "babel-eslint": "^8.2.6",
-    "babel-loader": "7.1.1",
-    "babel-register": "^6.26.0",
-    "babel-polyfill": "^6.26.0",
-    "eslint": "^5.3.0",
-    "mocha": "^5.2.0"
+    "eslint": "^9.39.5",
+    "mocha": "^11.2.0"
   }
 }

package/src/rules/no-arrow-this.js

@@ -1,82 +1,102 @@
 'use strict';
 
-module.exports = (context) => {
-	// lowercased name of AST Arrow Function
-	const AST_AF = 'ArrowFunctionExpression'.toLowerCase();
-	// lowercased name of AST Program Start
-	const AST_PRG = 'Program'.toLowerCase();
+module.exports = {
+	meta: {
+		type: 'suggestion',
+		docs: {
+			description: 'get rid of using "this" keyword in arrow functions',
+			category: 'code style~convention',
+			recommended: false
+		},
+		fixable: null,
+		schema: [
+			{
+				type: 'object',
+				properties: {
+					onlyGlobals: { type: 'boolean' }
+				},
+				additionalProperties: false
+			}
+		]
+	},
+	create (context) {
+		// lowercased name of AST Arrow Function
+		const AST_AF = 'ArrowFunctionExpression'.toLowerCase();
+		// lowercased name of AST Program Start
+		const AST_PRG = 'Program'.toLowerCase();
 
-	// Here are list of nodes for check breaking
-	// If one of them found, then everything is good
-	// And it is not necessary to check anymore else
-	const breakList = [
-		'FunctionDeclaration',
-		'FunctionExpression',
-		AST_PRG
-	].map(name => name.toLowerCase());
-	
-	// This options allows to warn only situations
-	// When context of arrow function 
-	// points Strict to Global or Window
-	const onlyGlobals = (
-		Array.isArray(context.options) &&
-		context.options[0] &&
-		context.options[0].onlyGlobals
-	) ? true : false;
-	
-	// Warn message depends of onlyGlobals option
-	const name = onlyGlobals ? 'global "this"' : '"this"';
-	
-	var type, parent;
-	
-	// checking function depends of onlyGlobals
-	const prepareCheckFn = (node) => {
-		parent = node;
-		
-		const switchParent = () => {
-			// switching AST node
-			// upper from current
-			parent = parent.parent;
-			type = parent.type.toLowerCase();
-		};
-		
-		if (!onlyGlobals) {
+		// Here are list of nodes for check breaking
+		// If one of them found, then everything is good
+		// And it is not necessary to check anymore else
+		const breakList = [
+			'FunctionDeclaration',
+			'FunctionExpression',
+			AST_PRG
+		].map(name => name.toLowerCase());
+
+		// This options allows to warn only situations
+		// When context of arrow function
+		// points Strict to Global or Window
+		const onlyGlobals = Boolean(
+			Array.isArray(context.options) &&
+			context.options[0] &&
+			context.options[0].onlyGlobals
+		);
+
+		// Warn message depends of onlyGlobals option
+		const name = onlyGlobals ? 'global "this"' : '"this"';
+
+		var type, parent;
+
+		// checking function depends of onlyGlobals
+		const prepareCheckFn = (node) => {
+			parent = node;
+
+			const switchParent = () => {
+				// switching AST node
+				// upper from current
+				parent = parent.parent;
+				type = parent.type.toLowerCase();
+			};
+
+			if (!onlyGlobals) {
+				return () => {
+					switchParent();
+					if (breakList.includes(type)) {
+						return null;
+					}
+					if (type === AST_AF) {
+						return true;
+					}
+					return false;
+				};
+			}
+
+			let found = false;
 			return () => {
 				switchParent();
 				if (breakList.includes(type)) {
-					return null;
+					return (found && type === AST_PRG) ? true : null;
 				}
 				if (type === AST_AF) {
-					return true;
+					found = true;
 				}
 				return false;
 			};
-		}
-		
-		let found = false;
-		return () => {
-			switchParent();
-			if (breakList.includes(type)) {
-				return (found && type === AST_PRG) ? true : null;
-			}
-			if (type === AST_AF) {
-				found = true;
-			}
-			return false;
+
 		};
-		
-	};
-	
-	return {
-		ThisExpression(node) {
-			const check = prepareCheckFn(node);
-			var result = false;
-			while (result === false) {
-				result = check();
-			}
-			if (result) {
-				context.report(node, `do not use ${name} in an arrow function`);
+
+		return {
+			ThisExpression (node) {
+				const check = prepareCheckFn(node);
+				var result = false;
+				while (result === false) {
+					result = check();
+				}
+				if (result) {
+					context.report({ node, message: `do not use ${name} in an arrow function` });
+				}
 			}
-		}
-	};
-};
+		};
+	}
+};