eslint-plugin-nextfriday 5.0.1 → 5.0.2

package/CHANGELOG.md

@@ -1,5 +1,14 @@
 # eslint-plugin-nextfriday
 
+## 5.0.2
+
+### Patch Changes
+
+- [#141](https://github.com/next-friday/eslint-plugin-nextfriday/pull/141) [`9a9ba41`](https://github.com/next-friday/eslint-plugin-nextfriday/commit/9a9ba415a7a188ec0f0180cefd807e562a489bc8) Thanks [@joetakara](https://github.com/joetakara)! - Expand `enforce-constant-case` to enforce SCREAMING_SNAKE_CASE on RegExp and bigint constants, and refine `new RegExp()` detection to skip dynamic arguments.
+  - RegExp literals (`/foo/`) and `new RegExp("foo", "g")` (all args must be string literals) are now flagged when named in camelCase at global scope.
+  - BigInt literals (`100n`, `-1n`) are now flagged consistently with number literals.
+  - `new RegExp(userInput)` and other non-literal RegExp constructors are intentionally ignored — only statically-constructed patterns are treated as magic values.
+
 ## 5.0.1
 
 ### Patch Changes

package/docs/rules/ENFORCE_CONSTANT_CASE.md

@@ -1,23 +1,25 @@
 # enforce-constant-case
 
-Enforce SCREAMING_SNAKE_CASE for global magic-number and magic-text constants.
+Enforce SCREAMING_SNAKE_CASE for global magic-number, magic-text, bigint, and RegExp constants.
 
 ## Rule Details
 
-This rule ensures that global-scope `const` declarations bound to a **magic number** or **magic text** literal use SCREAMING_SNAKE_CASE. The rule scope is intentionally narrow:
+This rule ensures that global-scope `const` declarations bound to a **magic literal** value use SCREAMING_SNAKE_CASE. The rule scope is intentionally narrow:
 
 - A magic text constant is a string literal: `const API_URL = "https://api.example.com"`
 - A magic number constant is a number literal (including a unary `-`/`+` over a numeric literal): `const PAGE_LIMIT = 10`, `const OFFSET = -1`
+- A bigint constant is a bigint literal (including a unary `-`/`+` over a bigint literal): `const BIG_LIMIT = 9007199254740993n`, `const NEGATIVE_BIG = -1n`
+- A RegExp constant is a regex literal, or a `new RegExp(...)` call whose arguments are **all** string literals: `const PHONE_REGEX = /^[0-9]+$/`, `const EMAIL_PATTERN = new RegExp("^.+@.+$", "g")`
 
-Anything else is **not** checked: booleans, RegExp, template literals (static or dynamic), arrays, objects, `as const` assertions, function calls, identifiers, member expressions, JSX. Use whatever name fits the value (`metadata`, `viewport`, `statusMap`, `phoneRegex`, `isEnabled`, etc.) — the rule will not flag it.
+Anything else is **not** checked: booleans, template literals (static or dynamic), arrays, objects, `as const` assertions, function calls, identifiers, member expressions, JSX, and `new RegExp(dynamicValue)` (where the pattern argument is non-literal). Use whatever name fits the value (`metadata`, `viewport`, `statusMap`, `isEnabled`, `dynamicPattern`, etc.) — the rule will not flag it.
 
 Only global scope (top-level of a file) is checked. Local scope constants inside functions are not checked by this rule.
 
 **Config files are exempt.** Files matching `*.config.{ts,mjs,cjs,js}`, `*.rc.*`, `*.setup.*`, `*.spec.*`, `*.test.*`, `.eslintrc*`, `.babelrc*`, and `.prettierrc*` skip this rule entirely. This avoids conflicts with framework conventions that require specific identifier names — e.g. Next.js expects `nextConfig` (not `NEXT_CONFIG`) in `next.config.ts`, Vite expects `config`, Tailwind expects `config`, etc.
 
-### Why magic numbers and magic text only?
+### Why only static literal values?
 
-Reserved framework export names commonly bind to objects (Next.js App Router exports `metadata`, `viewport`, `generateStaticParams`, `dynamic`, `revalidate`, `runtime`, `fetchCache`, `dynamicParams`, `preferredRegion`, `maxDuration`; React Server Components and others have similar patterns). Forcing SCREAMING_SNAKE_CASE on any static-shaped initializer would rename those exports and break framework integration. Restricting the rule to bare number and string literals keeps the convention where it adds value (avoiding magic constants scattered through code) without colliding with framework-owned names.
+Reserved framework export names commonly bind to objects (Next.js App Router exports `metadata`, `viewport`, `generateStaticParams`, `dynamic`, `revalidate`, `runtime`, `fetchCache`, `dynamicParams`, `preferredRegion`, `maxDuration`; React Server Components and others have similar patterns). Forcing SCREAMING_SNAKE_CASE on any static-shaped initializer would rename those exports and break framework integration. Restricting the rule to bare number, string, bigint, and statically-constructed RegExp values keeps the convention where it adds value (avoiding magic constants scattered through code) without colliding with framework-owned names or flagging dynamically-constructed patterns.
 
 ## Examples
 
@@ -29,6 +31,9 @@ const pageLimit = 10;
 const apiBaseUrl = "https://api.example.com";
 const negativeOne = -1;
 const default_theme = "dark";
+const phoneRegex = /^[0-9]{10}$/;
+const emailPattern = new RegExp("^.+@.+$");
+const bigLimit = 9007199254740993n;
 ```
 
 ### Correct
@@ -39,12 +44,15 @@ const PAGE_LIMIT = 10;
 const API_BASE_URL = "https://api.example.com";
 const NEGATIVE_ONE = -1;
 const DEFAULT_THEME = "dark";
+const PHONE_REGEX = /^[0-9]{10}$/;
+const EMAIL_PATTERN = new RegExp("^.+@.+$", "g");
+const BIG_LIMIT = 9007199254740993n;
 
 const isProduction = true;
 const hasAccess = false;
 const featureEnabled = true;
 
-const phoneRegex = /^[0-9]{10}$/;
+const dynamicPattern = new RegExp(userInput);
 const template = `hello world`;
 const skeletonItems = [1, 2, 3, 4, 5];
 const mapStyle = { height: "320px", width: "100%" };

package/lib/index.cjs

@@ -32,7 +32,7 @@ let emoji_regex = require("emoji-regex");
 emoji_regex = __toESM(emoji_regex, 1);
 //#region package.json
 var name = "eslint-plugin-nextfriday";
-var version = "5.0.1";
+var version = "5.0.2";
 //#endregion
 //#region src/rules/boolean-naming-prefix.ts
 const createRule$26 = _typescript_eslint_utils.ESLintUtils.RuleCreator((name) => `https://github.com/next-friday/eslint-plugin-nextfriday/blob/main/docs/rules/${name.replaceAll("-", "_").toUpperCase()}.md`);
@@ -162,10 +162,15 @@ const SCREAMING_SNAKE_CASE_REGEX$1 = /^[A-Z][A-Z0-9]*(?:_[A-Z0-9]+)*$/;
 const SNAKE_CASE_REGEX = /^[a-z]+_[a-z0-9_]*$/;
 const toScreamingSnakeCase = (str) => str.replace(/([a-z])([A-Z])/g, "$1_$2").replace(/([A-Z])([A-Z][a-z])/g, "$1_$2").toUpperCase();
 const isMagicLiteral = (init) => {
-	if (init.type === _typescript_eslint_utils.AST_NODE_TYPES.Literal) return typeof init.value === "string" || typeof init.value === "number";
+	if (init.type === _typescript_eslint_utils.AST_NODE_TYPES.Literal) return typeof init.value === "string" || typeof init.value === "number" || typeof init.value === "bigint" || "regex" in init;
 	if (init.type === _typescript_eslint_utils.AST_NODE_TYPES.UnaryExpression) {
 		const { argument, operator } = init;
-		return (operator === "-" || operator === "+") && argument.type === _typescript_eslint_utils.AST_NODE_TYPES.Literal && typeof argument.value === "number";
+		if (operator !== "-" && operator !== "+") return false;
+		return argument.type === _typescript_eslint_utils.AST_NODE_TYPES.Literal && (typeof argument.value === "number" || typeof argument.value === "bigint");
+	}
+	if (init.type === _typescript_eslint_utils.AST_NODE_TYPES.NewExpression) {
+		if (init.callee.type !== _typescript_eslint_utils.AST_NODE_TYPES.Identifier || init.callee.name !== "RegExp") return false;
+		return init.arguments.every((arg) => arg.type === _typescript_eslint_utils.AST_NODE_TYPES.Literal && typeof arg.value === "string");
 	}
 	return false;
 };
@@ -179,7 +184,7 @@ const enforceConstantCase = createRule$25({
 	name: "enforce-constant-case",
 	meta: {
 		type: "suggestion",
-		docs: { description: "Enforce SCREAMING_SNAKE_CASE for global magic-number and magic-text constants" },
+		docs: { description: "Enforce SCREAMING_SNAKE_CASE for global magic-number, magic-text, bigint, and RegExp constants" },
 		messages: {
 			useScreamingSnakeCase: "Constant '{{ name }}' should use SCREAMING_SNAKE_CASE. Rename to '{{ suggestion }}'.",
 			noSnakeCase: "Global constant '{{ name }}' should not use snake_case. Rename to '{{ suggestion }}'."