eslint-plugin-nextfriday 4.3.2 → 5.0.0

package/CHANGELOG.md

@@ -1,5 +1,43 @@
 # eslint-plugin-nextfriday
 
+## 5.0.0
+
+### Major Changes
+
+- [#136](https://github.com/next-friday/eslint-plugin-nextfriday/pull/136) [`d5dd064`](https://github.com/next-friday/eslint-plugin-nextfriday/commit/d5dd064c4de84ef90cc67cbb914e31288b13afab) Thanks [@joetakara](https://github.com/joetakara)! - fix `index-export-only` to allow string directive prologues (e.g. `"use strict"`) in index files — previously flagged as disallowed expression statements
+
+  fix `sort-imports` group ordering — `import type` now belongs to the same group as its source (external type after external value, internal alias type after internal alias value, etc.) and relative imports are split into parent (`../`) and current (`./`) sub-groups
+
+  fix `sort-imports` `checkOrder` return type — early-return now yields `false` instead of `undefined`, satisfying the declared `boolean` return type
+
+  remove `no-inline-default-export` rule — the rule conflicts with framework route handler patterns that require inline named function exports (`export async function GET`)
+
+  remove `no-nested-ternary` rule — duplicates ESLint's built-in `no-nested-ternary` with identical behavior; use the built-in rule directly instead
+
+  remove `enforce-property-case` rule — duplicates ESLint's built-in `camelcase` with `{ properties: "always" }`; use the built-in rule directly instead
+
+  remove `no-single-char-variables` rule — duplicates ESLint's built-in `id-length` with `{ min: 2, exceptions: ["_", "i", "j", "k", "n"] }`; use the built-in rule directly instead
+
+  remove `prefer-function-declaration` rule — duplicates ESLint's built-in `func-style` with `["declaration", { allowArrowFunctions: false }]`; use the built-in rule directly instead
+
+  remove `enforce-camel-case` rule — duplicates ESLint's built-in `camelcase`; use the built-in rule directly instead
+
+  remove `prefer-jsx-template-literals` rule — duplicates ESLint's built-in `prefer-template` with broader coverage; use the built-in rule directly instead
+
+  remove `no-redundant-fragment` rule — duplicates `eslint-plugin-react`'s `react/jsx-no-useless-fragment` with identical behavior; use the plugin rule directly instead
+
+  remove `react-props-destructure` rule — duplicates `eslint-plugin-react`'s `react/destructuring-assignment` with `["error", "always"]`; use the plugin rule directly instead
+
+## 4.4.0
+
+### Minor Changes
+
+- [#134](https://github.com/next-friday/eslint-plugin-nextfriday/pull/134) [`ae95cb8`](https://github.com/next-friday/eslint-plugin-nextfriday/commit/ae95cb840eb5e1a2f342e58958e0a44a94d4ae3d) Thanks [@joetakara](https://github.com/joetakara)! - remove `prefer-inline-type-export` rule
+
+  fix `prefer-import-type` incorrectly converting namespace imports used as JSX member expressions (e.g. `<Avatar.Root>`) to `import type`
+
+  update `prefer-props-with-children` to only flag optional `children?: ReactNode` — required `children: ReactNode` is no longer reported
+
 ## 4.3.2
 
 ### Patch Changes

package/README.md

@@ -50,7 +50,7 @@ export default [nextfriday.configs["nextjs/recommended"]];
 
 To use a preset and adjust individual rules, append a second config object after the preset. Later objects override earlier ones, so you can change severity, swap options, or add rules without re-declaring the entire preset.
 
-For example, start with the `react/recommended` preset (which runs `nextfriday/enforce-camel-case` and `nextfriday/enforce-props-suffix` as errors) and add a rule override on top:
+For example, start with the `react/recommended` preset (which runs `nextfriday/enforce-constant-case` and `nextfriday/enforce-props-suffix` as errors) and add a rule override on top:
 
 ```js
 import nextfriday from "eslint-plugin-nextfriday";
@@ -99,18 +99,14 @@ export default [
     },
     rules: {
       // Variable Naming
-      "nextfriday/no-single-char-variables": "error",
       "nextfriday/no-lazy-identifiers": "error",
       "nextfriday/boolean-naming-prefix": "error",
-      "nextfriday/enforce-camel-case": "error",
       "nextfriday/enforce-constant-case": "error",
-      "nextfriday/enforce-property-case": "error",
       "nextfriday/no-misleading-constant-case": "error",
 
       // Code Style
       "nextfriday/no-emoji": "error",
       "nextfriday/prefer-destructuring-params": "error",
-      "nextfriday/prefer-function-declaration": "error",
       "nextfriday/require-explicit-return-type": "error",
       "nextfriday/no-complex-inline-return": "error",
       "nextfriday/no-logic-in-params": "error",
@@ -125,7 +121,6 @@ export default [
       "nextfriday/no-inline-nested-object": "error",
       "nextfriday/no-inline-return-properties": "error",
       "nextfriday/prefer-async-await": "error",
-      "nextfriday/no-nested-ternary": "error",
       "nextfriday/prefer-guard-clause": "error",
 
       // Import Optimization
@@ -156,8 +151,6 @@ export default [
       "nextfriday/jsx-simple-props": "error",
       "nextfriday/jsx-sort-props": "error",
       "nextfriday/jsx-spread-props-last": "error",
-      "nextfriday/prefer-jsx-template-literals": "error",
-      "nextfriday/react-props-destructure": "error",
       "nextfriday/enforce-props-suffix": "error",
       "nextfriday/enforce-readonly-component-props": "error",
     },
@@ -208,7 +201,6 @@ export default [
     files: ["**/*.{test,spec}.{ts,tsx}"],
     rules: {
       "nextfriday/require-explicit-return-type": "off",
-      "nextfriday/no-single-char-variables": "off",
       "nextfriday/no-direct-date": "off",
     },
   },
@@ -335,7 +327,6 @@ export default [
     files: ["src/legacy/**/*.{ts,tsx}"],
     rules: {
       "nextfriday/no-relative-imports": "off",
-      "nextfriday/enforce-camel-case": "off",
     },
   },
 ];
@@ -382,7 +373,7 @@ When the warn-level preset surfaces hundreds of violations, fix them in this ord
 | Tier                                  | Examples                                                                                                                                              | Why first                                                                                                                       |
 | ------------------------------------- | ----------------------------------------------------------------------------------------------------------------------------------------------------- | ------------------------------------------------------------------------------------------------------------------------------- |
 | High — correctness and runtime safety | `no-direct-date`, `no-env-fallback`, `enforce-readonly-component-props`, `jsx-no-non-component-function`, `enforce-hook-naming`, `no-logic-in-params` | Each violation can mask a bug, leak config, or break React's rules of hooks. Fix before they ship.                              |
-| Medium — structure and naming         | `boolean-naming-prefix`, `enforce-camel-case`, `enforce-constant-case`, `enforce-props-suffix`, `prefer-import-type`                                  | No runtime impact, but inconsistent naming compounds review and onboarding cost. Fix once the high tier is clean.               |
+| Medium — structure and naming         | `boolean-naming-prefix`, `enforce-constant-case`, `enforce-props-suffix`, `prefer-import-type`                                                        | No runtime impact, but inconsistent naming compounds review and onboarding cost. Fix once the high tier is clean.               |
 | Low — formatting and ordering         | `sort-imports`, `sort-exports`, `sort-type-alphabetically`, `jsx-sort-props`, `newline-before-return`, `newline-after-multiline-block`, `no-emoji`    | Cosmetic. Most are auto-fixable, so a single `pnpm eslint --fix` pass typically clears the whole codebase. Save these for last. |
 
 In practice: turn the high tier on as `"error"` first, leave the medium tier as `"warn"` while you migrate, and run the auto-fixers for the low tier in a single dedicated PR.
@@ -395,12 +386,9 @@ In practice: turn the high tier on as `"error"` first, leave the medium tier as
 
 | Rule                                                                     | Description                                                           | Fixable |
 | ------------------------------------------------------------------------ | --------------------------------------------------------------------- | ------- |
-| [no-single-char-variables](docs/rules/NO_SINGLE_CHAR_VARIABLES.md)       | Disallow single character variable names (e.g., `d`, `u`, `l`)        | ❌      |
 | [no-lazy-identifiers](docs/rules/NO_LAZY_IDENTIFIERS.md)                 | Disallow lazy identifiers like `xxx`, `asdf`, `qwerty`                | ❌      |
 | [boolean-naming-prefix](docs/rules/BOOLEAN_NAMING_PREFIX.md)             | Enforce boolean variables to have prefix (is, has, should, can, etc.) | ❌      |
-| [enforce-camel-case](docs/rules/ENFORCE_CAMEL_CASE.md)                   | Ban snake_case and restrict PascalCase to React components            | ❌      |
 | [enforce-constant-case](docs/rules/ENFORCE_CONSTANT_CASE.md)             | Enforce SCREAMING_SNAKE_CASE for global static constant values        | ❌      |
-| [enforce-property-case](docs/rules/ENFORCE_PROPERTY_CASE.md)             | Enforce camelCase for unquoted object property keys                   | ❌      |
 | [no-misleading-constant-case](docs/rules/NO_MISLEADING_CONSTANT_CASE.md) | Disallow SCREAMING_SNAKE_CASE in local scope and for dynamic values   | ❌      |
 
 ### Code Style Rules
@@ -409,7 +397,6 @@ In practice: turn the high tier on as `"error"` first, leave the medium tier as
 | ---------------------------------------------------------------------------- | ---------------------------------------------------------------------- | ------- |
 | [no-emoji](docs/rules/NO_EMOJI.md)                                           | Disallow emoji characters in source code                               | ❌      |
 | [prefer-destructuring-params](docs/rules/PREFER_DESTRUCTURING_PARAMS.md)     | Enforce destructuring for functions with multiple parameters           | ❌      |
-| [prefer-function-declaration](docs/rules/PREFER_FUNCTION_DECLARATION.md)     | Enforce function declarations over arrow functions in .ts files        | ❌      |
 | [require-explicit-return-type](docs/rules/REQUIRE_EXPLICIT_RETURN_TYPE.md)   | Require explicit return types on functions for better documentation    | ❌      |
 | [no-complex-inline-return](docs/rules/NO_COMPLEX_INLINE_RETURN.md)           | Disallow complex inline expressions in return - extract to const first | ❌      |
 | [no-logic-in-params](docs/rules/NO_LOGIC_IN_PARAMS.md)                       | Disallow logic/conditions in function parameters - extract to const    | ❌      |
@@ -419,7 +406,6 @@ In practice: turn the high tier on as `"error"` first, leave the medium tier as
 | [enforce-service-naming](docs/rules/ENFORCE_SERVICE_NAMING.md)               | Enforce 'fetch' prefix for async functions in \*.service.ts files      | ❌      |
 | [enforce-sorted-destructuring](docs/rules/ENFORCE_SORTED_DESTRUCTURING.md)   | Enforce alphabetical sorting of destructured properties                | ✅      |
 | [no-env-fallback](docs/rules/NO_ENV_FALLBACK.md)                             | Disallow fallback values for environment variables                     | ❌      |
-| [no-inline-default-export](docs/rules/NO_INLINE_DEFAULT_EXPORT.md)           | Disallow inline default exports - declare first, then export           | ❌      |
 | [index-export-only](docs/rules/INDEX_EXPORT_ONLY.md)                         | Restrict index files to imports, re-exports, and type declarations     | ❌      |
 | [no-direct-date](docs/rules/NO_DIRECT_DATE.md)                               | Disallow direct usage of Date constructor and methods                  | ❌      |
 | [newline-after-multiline-block](docs/rules/NEWLINE_AFTER_MULTILINE_BLOCK.md) | Require a blank line after multi-line statements                       | ✅      |
@@ -427,7 +413,6 @@ In practice: turn the high tier on as `"error"` first, leave the medium tier as
 | [no-inline-nested-object](docs/rules/NO_INLINE_NESTED_OBJECT.md)             | Require nested objects and arrays to span multiple lines               | ✅      |
 | [no-inline-return-properties](docs/rules/NO_INLINE_RETURN_PROPERTIES.md)     | Require return object properties to use shorthand notation             | ❌      |
 | [prefer-async-await](docs/rules/PREFER_ASYNC_AWAIT.md)                       | Enforce async/await over .then() promise chains                        | ❌      |
-| [no-nested-ternary](docs/rules/NO_NESTED_TERNARY.md)                         | Disallow nested ternary expressions                                    | ❌      |
 | [prefer-guard-clause](docs/rules/PREFER_GUARD_CLAUSE.md)                     | Enforce guard clause pattern instead of nested if statements           | ❌      |
 | [no-helper-function-in-hook](docs/rules/NO_HELPER_FUNCTION_IN_HOOK.md)       | Disallow non-hook helper function definitions in hook files            | ❌      |
 | [no-helper-function-in-test](docs/rules/NO_HELPER_FUNCTION_IN_TEST.md)       | Disallow helper function definitions in test files                     | ❌      |
@@ -451,7 +436,6 @@ In practice: turn the high tier on as `"error"` first, leave the medium tier as
 | [no-nested-interface-declaration](docs/rules/NO_NESTED_INTERFACE_DECLARATION.md)           | Disallow inline object types in interface/type properties         | ❌      |
 | [prefer-named-param-types](docs/rules/PREFER_NAMED_PARAM_TYPES.md)                         | Enforce named types for function parameters with object types     | ❌      |
 | [prefer-inline-literal-union](docs/rules/PREFER_INLINE_LITERAL_UNION.md)                   | Enforce inlining literal union types for better IDE hover info    | ✅      |
-| [prefer-inline-type-export](docs/rules/PREFER_INLINE_TYPE_EXPORT.md)                       | Require type/interface exports inline at the declaration          | ✅      |
 | [prefer-interface-for-component-props](docs/rules/PREFER_INTERFACE_FOR_COMPONENT_PROPS.md) | Enforce interface over type alias for component prop declarations | ✅      |
 | [prefer-interface-over-inline-types](docs/rules/PREFER_INTERFACE_OVER_INLINE_TYPES.md)     | Enforce interface declarations over inline types for React props  | ❌      |
 | [sort-type-alphabetically](docs/rules/SORT_TYPE_ALPHABETICALLY.md)                         | Enforce A-Z sorting of properties within type groups              | ✅      |
@@ -475,10 +459,7 @@ In practice: turn the high tier on as `"error"` first, leave the medium tier as
 | [jsx-sort-props](docs/rules/JSX_SORT_PROPS.md)                                           | Enforce JSX props are sorted by value type                            | ✅      |
 | [jsx-spread-props-last](docs/rules/JSX_SPREAD_PROPS_LAST.md)                             | Enforce JSX spread attributes appear after all other props            | ❌      |
 | [no-ghost-wrapper](docs/rules/NO_GHOST_WRAPPER.md)                                       | Disallow bare `<div>`/`<span>` with no meaningful attributes          | ❌      |
-| [no-redundant-fragment](docs/rules/NO_REDUNDANT_FRAGMENT.md)                             | Disallow Fragments wrapping zero or one child                         | ❌      |
-| [prefer-jsx-template-literals](docs/rules/PREFER_JSX_TEMPLATE_LITERALS.md)               | Enforce template literals instead of mixing text and JSX expressions  | ✅      |
 | [prefer-props-with-children](docs/rules/PREFER_PROPS_WITH_CHILDREN.md)                   | Prefer PropsWithChildren over manually declaring children: ReactNode  | ❌      |
-| [react-props-destructure](docs/rules/REACT_PROPS_DESTRUCTURE.md)                         | Enforce destructuring props inside React component body               | ❌      |
 | [enforce-props-suffix](docs/rules/ENFORCE_PROPS_SUFFIX.md)                               | Enforce 'Props' suffix for interfaces and types in \*.tsx files       | ❌      |
 | [enforce-readonly-component-props](docs/rules/ENFORCE_READONLY_COMPONENT_PROPS.md)       | Enforce Readonly wrapper for React component props                    | ✅      |
 | [enforce-render-naming](docs/rules/ENFORCE_RENDER_NAMING.md)                             | Enforce 'render' prefix for variables holding JSX inside components   | ❌      |
@@ -489,26 +470,24 @@ In practice: turn the high tier on as `"error"` first, leave the medium tier as
 
 | Preset               | Severity | Base Rules | JSX Rules | Total Rules |
 | -------------------- | -------- | ---------- | --------- | ----------- |
-| `base`               | warn     | 42         | 0         | 42          |
-| `base/recommended`   | error    | 42         | 0         | 42          |
-| `react`              | warn     | 42         | 23        | 65          |
-| `react/recommended`  | error    | 42         | 23        | 65          |
-| `nextjs`             | warn     | 42         | 23        | 65          |
-| `nextjs/recommended` | error    | 42         | 23        | 65          |
+| `base`               | warn     | 43         | 0         | 43          |
+| `base/recommended`   | error    | 43         | 0         | 43          |
+| `react`              | warn     | 43         | 23        | 66          |
+| `react/recommended`  | error    | 43         | 23        | 66          |
+| `nextjs`             | warn     | 43         | 23        | 66          |
+| `nextjs/recommended` | error    | 43         | 23        | 66          |
 
 The `nextjs` and `nextjs/recommended` presets currently share the same rule set as `react` and `react/recommended`; they are kept as named aliases for ergonomics.
 
-### Base Configuration Rules (42 rules)
+### Base Configuration Rules (43 rules)
 
 Included in `base`, `base/recommended`, and all other presets:
 
 - `nextfriday/boolean-naming-prefix`
-- `nextfriday/enforce-camel-case`
 - `nextfriday/enforce-constant-case`
 - `nextfriday/enforce-hook-filename`
 - `nextfriday/enforce-hook-naming`
 - `nextfriday/enforce-test-filename`
-- `nextfriday/enforce-property-case`
 - `nextfriday/enforce-service-naming`
 - `nextfriday/enforce-sorted-destructuring`
 - `nextfriday/enforce-type-declaration-order`
@@ -519,7 +498,6 @@ Included in `base`, `base/recommended`, and all other presets:
 - `nextfriday/no-direct-date`
 - `nextfriday/no-emoji`
 - `nextfriday/no-env-fallback`
-- `nextfriday/no-inline-default-export`
 - `nextfriday/no-inline-nested-object`
 - `nextfriday/no-inline-return-properties`
 - `nextfriday/no-inline-type-import`
@@ -527,16 +505,12 @@ Included in `base`, `base/recommended`, and all other presets:
 - `nextfriday/no-logic-in-params`
 - `nextfriday/no-misleading-constant-case`
 - `nextfriday/no-nested-interface-declaration`
-- `nextfriday/no-nested-ternary`
 - `nextfriday/no-relative-imports`
-- `nextfriday/no-single-char-variables`
 - `nextfriday/prefer-async-await`
 - `nextfriday/prefer-destructuring-params`
-- `nextfriday/prefer-function-declaration`
 - `nextfriday/prefer-guard-clause`
 - `nextfriday/prefer-import-type`
 - `nextfriday/prefer-inline-literal-union`
-- `nextfriday/prefer-inline-type-export`
 - `nextfriday/prefer-named-param-types`
 - `nextfriday/prefer-react-import-types`
 - `nextfriday/require-explicit-return-type`
@@ -566,12 +540,9 @@ Additionally included in `react`, `react/recommended`, `nextjs`, `nextjs/recomme
 - `nextfriday/jsx-sort-props`
 - `nextfriday/jsx-spread-props-last`
 - `nextfriday/no-ghost-wrapper`
-- `nextfriday/no-redundant-fragment`
 - `nextfriday/prefer-interface-for-component-props`
 - `nextfriday/prefer-interface-over-inline-types`
-- `nextfriday/prefer-jsx-template-literals`
 - `nextfriday/prefer-props-with-children`
-- `nextfriday/react-props-destructure`
 
 ### Severity Levels
 

package/docs/rules/BOOLEAN_NAMING_PREFIX.md

@@ -101,5 +101,4 @@ If you need stricter coverage of object/class members, pair this rule with [`@ty
 
 ## Related Rules
 
-- [no-single-char-variables](./NO_SINGLE_CHAR_VARIABLES.md) - Disallows single character variable names
 - [@typescript-eslint/naming-convention](https://typescript-eslint.io/rules/naming-convention/) - More comprehensive naming convention rule

package/docs/rules/ENFORCE_CONSTANT_CASE.md

@@ -109,7 +109,6 @@ export default [
     rules: {
       "nextfriday/enforce-constant-case": "error",
       "nextfriday/no-misleading-constant-case": "error",
-      "nextfriday/enforce-camel-case": "error",
     },
   },
 ];
@@ -166,4 +165,3 @@ This plugin only supports ESLint 9+ flat config — legacy `.eslintrc` is not su
 ## Related Rules
 
 - [no-misleading-constant-case](NO_MISLEADING_CONSTANT_CASE.md) - Disallows SCREAMING_SNAKE_CASE in local scope and for dynamic values
-- [enforce-camel-case](ENFORCE_CAMEL_CASE.md) - Enforces camelCase for variables and functions

package/docs/rules/ENFORCE_READONLY_COMPONENT_PROPS.md

@@ -92,4 +92,3 @@ This rule is fixable using ESLint's `--fix` option. The fixer will automatically
 ## Related Rules
 
 - [`prefer-interface-over-inline-types`](./PREFER_INTERFACE_OVER_INLINE_TYPES.md) - Enforces interface declarations over inline types
-- [`react-props-destructure`](./REACT_PROPS_DESTRUCTURE.md) - Enforces destructuring props inside component body

package/docs/rules/INDEX_EXPORT_ONLY.md

@@ -43,6 +43,12 @@ console.log("loaded");
 
 ### Correct
 
+```ts
+"use strict";
+
+export { cn } from "./cn";
+```
+
 ```ts
 export { cn } from "./cn";
 export * from "./types";
@@ -66,6 +72,7 @@ export interface Bar {
 ## What This Rule Allows
 
 - `import` statements (including side-effect imports like `import "./styles.css"`)
+- String directive prologues (e.g. `"use strict"`)
 - Specifier-only `export` and `export ... from` re-exports
 - `export *` and `export * as ns` re-exports
 - `export default identifier` where the identifier comes from an import

package/docs/rules/NO_GHOST_WRAPPER.md

@@ -69,7 +69,3 @@ Any of the following attributes count as meaningful and silence the rule:
 ## When Not To Use It
 
 If your codebase intentionally uses bare `<div>` and `<span>` as structural placeholders, or if you rely on parent CSS selectors that target a fixed wrapper depth.
-
-## Related Rules
-
-- [no-redundant-fragment](NO_REDUNDANT_FRAGMENT.md)

package/docs/rules/NO_LAZY_IDENTIFIERS.md

@@ -78,7 +78,7 @@ Variables containing 4 or more consecutive keyboard row characters:
 
 ### Short Identifiers
 
-Identifiers shorter than 3 characters are ignored (use `no-single-char-variables` for those).
+Identifiers shorter than 3 characters are ignored (use the core ESLint `id-length` rule with `min: 2` for those).
 
 ### Underscore-Prefixed
 
@@ -95,5 +95,4 @@ const _unused = getValue();
 
 ## Related Rules
 
-- [no-single-char-variables](./NO_SINGLE_CHAR_VARIABLES.md) - Disallows single character variable names
 - [boolean-naming-prefix](./BOOLEAN_NAMING_PREFIX.md) - Enforces naming conventions for boolean variables

package/docs/rules/NO_MISLEADING_CONSTANT_CASE.md

@@ -73,4 +73,3 @@ If your project does not follow the convention that SCREAMING_SNAKE_CASE is rese
 ## Related Rules
 
 - [enforce-constant-case](ENFORCE_CONSTANT_CASE.md) - The complementary rule that enforces SCREAMING_SNAKE_CASE for global static constants
-- [enforce-camel-case](ENFORCE_CAMEL_CASE.md) - Enforces camelCase for variables and functions

package/docs/rules/PREFER_PROPS_WITH_CHILDREN.md

@@ -1,36 +1,24 @@
 # prefer-props-with-children
 
-Prefer `PropsWithChildren<T>` over manually declaring `children: ReactNode` in component props.
+Prefer `PropsWithChildren<T>` over manually declaring `children?: ReactNode` in component props.
 
 ## Rule Details
 
-This rule reports interfaces, type aliases, and inline parameter types that declare a `children` field typed as `ReactNode` (or `React.ReactNode`). React already provides the `PropsWithChildren<T>` helper for this exact case, so prefer it for consistency and to avoid restating the well-known `children` shape on every component.
+This rule reports interfaces, type aliases, and inline parameter types that declare an **optional** `children` field typed as `ReactNode` (or `React.ReactNode`). `PropsWithChildren<T>` already provides exactly this — an optional `children: ReactNode` — so the manual declaration is redundant.
 
-The rule only flags `children` whose type is exactly `ReactNode` (matching what `PropsWithChildren` provides). Other shapes such as `ReactElement`, render-prop functions, or unions like `ReactNode | string` are left alone.
+Required `children: ReactNode` (without `?`) is intentional and is not flagged, because `PropsWithChildren` cannot express required children.
+
+The rule only flags `children?` whose type is exactly `ReactNode`. Other shapes such as `ReactElement`, render-prop functions, or unions like `ReactNode | string` are left alone.
 
 ### Why?
 
-- `PropsWithChildren<T>` is the canonical type for components that accept children, making intent obvious at a glance.
-- It eliminates duplication of the `children` declaration across every component that accepts children.
-- It keeps the surrounding props focused on what is unique to the component.
+- `PropsWithChildren<T>` is the canonical type for components that optionally accept children, making intent obvious at a glance.
+- Required `children: ReactNode` (no `?`) cannot be replaced by `PropsWithChildren` — that case is intentional and not flagged.
 
 ## Examples
 
 ### Incorrect
 
-```tsx
-interface LayoutProps {
-  children: ReactNode;
-}
-```
-
-```tsx
-interface CardProps {
-  title: string;
-  children: ReactNode;
-}
-```
-
 ```tsx
 interface OptionalChildrenProps {
   children?: ReactNode;
@@ -39,25 +27,22 @@ interface OptionalChildrenProps {
 ```
 
 ```tsx
-interface ReactNamespaceProps {
-  children: React.ReactNode;
+interface LayoutProps {
+  children?: ReactNode;
 }
 ```
 
 ```tsx
 type WrapperProps = {
-  children: ReactNode;
+  children?: ReactNode;
   className: string;
 };
 ```
 
 ```tsx
-const Component = ({ children, label }: { children: ReactNode; label: string }) => (
-  <div>
-    {children}
-    {label}
-  </div>
-);
+interface ReactNamespaceProps {
+  children?: React.ReactNode;
+}
 ```
 
 ### Correct
@@ -79,12 +64,9 @@ type WrapperProps = PropsWithChildren<{
 ```
 
 ```tsx
-const Component = (props: Readonly<PropsWithChildren<{ label: string }>>) => (
-  <div>
-    {props.children}
-    {props.label}
-  </div>
-);
+interface RequiredChildrenProps {
+  children: ReactNode;
+}
 ```
 
 ```tsx
@@ -103,7 +85,7 @@ interface SlotProps {
 
 This rule should not be used if:
 
-- Your project intentionally avoids `PropsWithChildren` and prefers explicit `children` declarations.
+- Your project intentionally avoids `PropsWithChildren` and prefers explicit `children?` declarations.
 - You frequently use children types other than `ReactNode` (this rule already skips those cases).
 
 ## Related Rules

package/docs/rules/SORT_IMPORTS.md

@@ -17,12 +17,13 @@ This rule enforces that import statements are grouped and ordered by their sourc
 ### Import Group Order
 
 1. **Side-effect imports** — no specifiers (e.g., `import "./setup"`)
-2. **Node.js builtins** — `node:` prefix or known builtin names (e.g., `import fs from "node:fs"`)
-3. **External packages** — scoped or plain package names (e.g., `import React from "react"`)
-4. **Internal aliases** — paths starting with `@/`, `~/`, or `#` (e.g., `import { utils } from "@/lib/utils"`)
-5. **Relative imports** — paths starting with `.` (e.g., `import { foo } from "../foo"`)
+2. **Builtin** value → **builtin type**
+3. **External** value → **external type**
+4. **Internal alias** value → **internal alias type** — paths starting with `@/`, `~/`, or `#`
+5. **Parent relative** value → **parent relative type** — paths starting with `../` (any depth)
+6. **Relative** value → **relative type** — paths starting with `./`
 
-Type-only imports (`import type`) are skipped and do not affect ordering.
+Within each group, value imports come first, then `import type` for the same group.
 
 Non-contiguous imports (separated by other statements) are checked independently.
 
@@ -31,7 +32,13 @@ Non-contiguous imports (separated by other statements) are checked independently
 ### Incorrect
 
 ```ts
-// Bad: Relative before external
+// Bad: type import before value import in same group
+import type { Foo } from "some-lib";
+import { bar } from "some-lib";
+```
+
+```ts
+// Bad: relative before external
 import { foo } from "../foo";
 import React from "react";
 ```
@@ -51,19 +58,22 @@ import "./setup";
 ### Correct
 
 ```ts
-// Good: All 5 groups in correct order
 import "./setup";
+
 import fs from "node:fs";
+
 import React from "react";
+import type { FC } from "react";
+
 import { utils } from "@/lib/utils";
-import { foo } from "../foo";
-```
+import type { Utils } from "@/lib/utils";
 
-```ts
-// Good: Type imports can appear anywhere
-import type { FC } from "react";
-import { foo } from "../foo";
-import React from "react";
+import { foo } from "../../foo";
+import { bar } from "../bar";
+import type { Bar } from "../bar";
+
+import { baz } from "./baz";
+import type { Baz } from "./baz";
 ```
 
 ```ts