eslint-plugin-nextfriday 4.3.1 → 4.4.0

package/CHANGELOG.md

@@ -1,5 +1,21 @@
 # eslint-plugin-nextfriday
 
+## 4.4.0
+
+### Minor Changes
+
+- [#134](https://github.com/next-friday/eslint-plugin-nextfriday/pull/134) [`ae95cb8`](https://github.com/next-friday/eslint-plugin-nextfriday/commit/ae95cb840eb5e1a2f342e58958e0a44a94d4ae3d) Thanks [@joetakara](https://github.com/joetakara)! - remove `prefer-inline-type-export` rule
+
+  fix `prefer-import-type` incorrectly converting namespace imports used as JSX member expressions (e.g. `<Avatar.Root>`) to `import type`
+
+  update `prefer-props-with-children` to only flag optional `children?: ReactNode` — required `children: ReactNode` is no longer reported
+
+## 4.3.2
+
+### Patch Changes
+
+- [#132](https://github.com/next-friday/eslint-plugin-nextfriday/pull/132) [`5b2cb71`](https://github.com/next-friday/eslint-plugin-nextfriday/commit/5b2cb713b126917b1205fd54c6a1143d50aef7aa) Thanks [@joetakara](https://github.com/joetakara)! - fix 18 rules missing internal filename guards. `no-helper-function-in-hook` and `no-helper-function-in-test` now self-skip on non-matching files and are included in all presets — no consumer configuration required. all jsx rules now guard against non-jsx files using `isJsxFile()`, consistent with the established codebase pattern.
+
 ## 4.3.1
 
 ### Patch Changes

package/README.md

@@ -451,7 +451,6 @@ In practice: turn the high tier on as `"error"` first, leave the medium tier as
 | [no-nested-interface-declaration](docs/rules/NO_NESTED_INTERFACE_DECLARATION.md)           | Disallow inline object types in interface/type properties         | ❌      |
 | [prefer-named-param-types](docs/rules/PREFER_NAMED_PARAM_TYPES.md)                         | Enforce named types for function parameters with object types     | ❌      |
 | [prefer-inline-literal-union](docs/rules/PREFER_INLINE_LITERAL_UNION.md)                   | Enforce inlining literal union types for better IDE hover info    | ✅      |
-| [prefer-inline-type-export](docs/rules/PREFER_INLINE_TYPE_EXPORT.md)                       | Require type/interface exports inline at the declaration          | ✅      |
 | [prefer-interface-for-component-props](docs/rules/PREFER_INTERFACE_FOR_COMPONENT_PROPS.md) | Enforce interface over type alias for component prop declarations | ✅      |
 | [prefer-interface-over-inline-types](docs/rules/PREFER_INTERFACE_OVER_INLINE_TYPES.md)     | Enforce interface declarations over inline types for React props  | ❌      |
 | [sort-type-alphabetically](docs/rules/SORT_TYPE_ALPHABETICALLY.md)                         | Enforce A-Z sorting of properties within type groups              | ✅      |
@@ -489,16 +488,16 @@ In practice: turn the high tier on as `"error"` first, leave the medium tier as
 
 | Preset               | Severity | Base Rules | JSX Rules | Total Rules |
 | -------------------- | -------- | ---------- | --------- | ----------- |
-| `base`               | warn     | 42         | 0         | 42          |
-| `base/recommended`   | error    | 42         | 0         | 42          |
-| `react`              | warn     | 42         | 23        | 65          |
-| `react/recommended`  | error    | 42         | 23        | 65          |
-| `nextjs`             | warn     | 42         | 23        | 65          |
-| `nextjs/recommended` | error    | 42         | 23        | 65          |
+| `base`               | warn     | 43         | 0         | 43          |
+| `base/recommended`   | error    | 43         | 0         | 43          |
+| `react`              | warn     | 43         | 23        | 66          |
+| `react/recommended`  | error    | 43         | 23        | 66          |
+| `nextjs`             | warn     | 43         | 23        | 66          |
+| `nextjs/recommended` | error    | 43         | 23        | 66          |
 
 The `nextjs` and `nextjs/recommended` presets currently share the same rule set as `react` and `react/recommended`; they are kept as named aliases for ergonomics.
 
-### Base Configuration Rules (42 rules)
+### Base Configuration Rules (43 rules)
 
 Included in `base`, `base/recommended`, and all other presets:
 
@@ -536,7 +535,6 @@ Included in `base`, `base/recommended`, and all other presets:
 - `nextfriday/prefer-guard-clause`
 - `nextfriday/prefer-import-type`
 - `nextfriday/prefer-inline-literal-union`
-- `nextfriday/prefer-inline-type-export`
 - `nextfriday/prefer-named-param-types`
 - `nextfriday/prefer-react-import-types`
 - `nextfriday/require-explicit-return-type`

package/docs/rules/PREFER_PROPS_WITH_CHILDREN.md

@@ -1,36 +1,24 @@
 # prefer-props-with-children
 
-Prefer `PropsWithChildren<T>` over manually declaring `children: ReactNode` in component props.
+Prefer `PropsWithChildren<T>` over manually declaring `children?: ReactNode` in component props.
 
 ## Rule Details
 
-This rule reports interfaces, type aliases, and inline parameter types that declare a `children` field typed as `ReactNode` (or `React.ReactNode`). React already provides the `PropsWithChildren<T>` helper for this exact case, so prefer it for consistency and to avoid restating the well-known `children` shape on every component.
+This rule reports interfaces, type aliases, and inline parameter types that declare an **optional** `children` field typed as `ReactNode` (or `React.ReactNode`). `PropsWithChildren<T>` already provides exactly this — an optional `children: ReactNode` — so the manual declaration is redundant.
 
-The rule only flags `children` whose type is exactly `ReactNode` (matching what `PropsWithChildren` provides). Other shapes such as `ReactElement`, render-prop functions, or unions like `ReactNode | string` are left alone.
+Required `children: ReactNode` (without `?`) is intentional and is not flagged, because `PropsWithChildren` cannot express required children.
+
+The rule only flags `children?` whose type is exactly `ReactNode`. Other shapes such as `ReactElement`, render-prop functions, or unions like `ReactNode | string` are left alone.
 
 ### Why?
 
-- `PropsWithChildren<T>` is the canonical type for components that accept children, making intent obvious at a glance.
-- It eliminates duplication of the `children` declaration across every component that accepts children.
-- It keeps the surrounding props focused on what is unique to the component.
+- `PropsWithChildren<T>` is the canonical type for components that optionally accept children, making intent obvious at a glance.
+- Required `children: ReactNode` (no `?`) cannot be replaced by `PropsWithChildren` — that case is intentional and not flagged.
 
 ## Examples
 
 ### Incorrect
 
-```tsx
-interface LayoutProps {
-  children: ReactNode;
-}
-```
-
-```tsx
-interface CardProps {
-  title: string;
-  children: ReactNode;
-}
-```
-
 ```tsx
 interface OptionalChildrenProps {
   children?: ReactNode;
@@ -39,25 +27,22 @@ interface OptionalChildrenProps {
 ```
 
 ```tsx
-interface ReactNamespaceProps {
-  children: React.ReactNode;
+interface LayoutProps {
+  children?: ReactNode;
 }
 ```
 
 ```tsx
 type WrapperProps = {
-  children: ReactNode;
+  children?: ReactNode;
   className: string;
 };
 ```
 
 ```tsx
-const Component = ({ children, label }: { children: ReactNode; label: string }) => (
-  <div>
-    {children}
-    {label}
-  </div>
-);
+interface ReactNamespaceProps {
+  children?: React.ReactNode;
+}
 ```
 
 ### Correct
@@ -79,12 +64,9 @@ type WrapperProps = PropsWithChildren<{
 ```
 
 ```tsx
-const Component = (props: Readonly<PropsWithChildren<{ label: string }>>) => (
-  <div>
-    {props.children}
-    {props.label}
-  </div>
-);
+interface RequiredChildrenProps {
+  children: ReactNode;
+}
 ```
 
 ```tsx
@@ -103,7 +85,7 @@ interface SlotProps {
 
 This rule should not be used if:
 
-- Your project intentionally avoids `PropsWithChildren` and prefers explicit `children` declarations.
+- Your project intentionally avoids `PropsWithChildren` and prefers explicit `children?` declarations.
 - You frequently use children types other than `ReactNode` (this rule already skips those cases).
 
 ## Related Rules