eslint-plugin-nextfriday 4.3.1 → 4.3.2

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # eslint-plugin-nextfriday
 
+## 4.3.2
+
+### Patch Changes
+
+- [#132](https://github.com/next-friday/eslint-plugin-nextfriday/pull/132) [`5b2cb71`](https://github.com/next-friday/eslint-plugin-nextfriday/commit/5b2cb713b126917b1205fd54c6a1143d50aef7aa) Thanks [@joetakara](https://github.com/joetakara)! - fix 18 rules missing internal filename guards. `no-helper-function-in-hook` and `no-helper-function-in-test` now self-skip on non-matching files and are included in all presets — no consumer configuration required. all jsx rules now guard against non-jsx files using `isJsxFile()`, consistent with the established codebase pattern.
+
 ## 4.3.1
 
 ### Patch Changes

package/lib/index.cjs

@@ -32,7 +32,7 @@ let emoji_regex = require("emoji-regex");
 emoji_regex = __toESM(emoji_regex, 1);
 //#region package.json
 var name = "eslint-plugin-nextfriday";
-var version = "4.3.1";
+var version = "4.3.2";
 //#endregion
 //#region src/rules/boolean-naming-prefix.ts
 const createRule$32 = _typescript_eslint_utils.ESLintUtils.RuleCreator((name) => `https://github.com/next-friday/eslint-plugin-nextfriday/blob/main/docs/rules/${name.replaceAll("-", "_").toUpperCase()}.md`);
@@ -478,6 +478,7 @@ const enforceReadonlyComponentProps = _typescript_eslint_utils.ESLintUtils.RuleC
 	},
 	defaultOptions: [],
 	create(context) {
+		if (!isJsxFile(context.filename)) return {};
 		function hasJSXInConditional(node) {
 			return node.consequent.type === _typescript_eslint_utils.AST_NODE_TYPES.JSXElement || node.consequent.type === _typescript_eslint_utils.AST_NODE_TYPES.JSXFragment || node.alternate.type === _typescript_eslint_utils.AST_NODE_TYPES.JSXElement || node.alternate.type === _typescript_eslint_utils.AST_NODE_TYPES.JSXFragment;
 		}
@@ -897,6 +898,7 @@ const jsxNewlineBetweenElements = _typescript_eslint_utils.ESLintUtils.RuleCreat
 	},
 	defaultOptions: [],
 	create(context) {
+		if (!isJsxFile(context.filename)) return {};
 		const { sourceCode } = context;
 		function isSignificantJSXChild(node) {
 			return node.type === _typescript_eslint_utils.AST_NODE_TYPES.JSXElement || node.type === _typescript_eslint_utils.AST_NODE_TYPES.JSXFragment || node.type === _typescript_eslint_utils.AST_NODE_TYPES.JSXExpressionContainer;
@@ -1061,6 +1063,7 @@ const jsxNoInlineObjectProp = _typescript_eslint_utils.ESLintUtils.RuleCreator((
 	},
 	defaultOptions: [],
 	create(context) {
+		if (!isJsxFile(context.filename)) return {};
 		return { JSXAttribute(node) {
 			if (node.value?.type === _typescript_eslint_utils.AST_NODE_TYPES.JSXExpressionContainer && node.value.expression.type === _typescript_eslint_utils.AST_NODE_TYPES.ObjectExpression) context.report({
 				node: node.value,
@@ -1089,6 +1092,7 @@ const jsxNoNewlineSingleLineElements = createRule$21({
 	},
 	defaultOptions: [],
 	create(context) {
+		if (!isJsxFile(context.filename)) return {};
 		const { sourceCode } = context;
 		function checkSiblings(children) {
 			const nonWhitespace = children.filter((child) => !(child.type === _typescript_eslint_utils.AST_NODE_TYPES.JSXText && child.value.trim() === ""));
@@ -1292,6 +1296,7 @@ const jsxNoTernaryNull = createRule$19({
 	},
 	defaultOptions: [],
 	create(context) {
+		if (!isJsxFile(context.filename)) return {};
 		return { JSXExpressionContainer(node) {
 			const { expression } = node;
 			if (expression.type !== _typescript_eslint_utils.AST_NODE_TYPES.ConditionalExpression) return;
@@ -1332,6 +1337,7 @@ const jsxNoVariableInCallback = _typescript_eslint_utils.ESLintUtils.RuleCreator
 	},
 	defaultOptions: [],
 	create(context) {
+		if (!isJsxFile(context.filename)) return {};
 		function isInsideJSX(node) {
 			let current = node.parent;
 			while (current) {
@@ -1378,6 +1384,7 @@ const jsxRequireSuspense = _typescript_eslint_utils.ESLintUtils.RuleCreator((nam
 	},
 	defaultOptions: [],
 	create(context) {
+		if (!isJsxFile(context.filename)) return {};
 		const lazyComponents = /* @__PURE__ */ new Set();
 		const isInsideSuspense = (node) => {
 			let current = node.parent;
@@ -1419,6 +1426,7 @@ const jsxSimpleProps = _typescript_eslint_utils.ESLintUtils.RuleCreator((name) =
 	},
 	defaultOptions: [],
 	create(context) {
+		if (!isJsxFile(context.filename)) return {};
 		const allowedExpressionTypes = new Set([
 			_typescript_eslint_utils.AST_NODE_TYPES.Identifier,
 			_typescript_eslint_utils.AST_NODE_TYPES.Literal,
@@ -1538,6 +1546,7 @@ const jsxSortProps = createRule$18({
 	},
 	defaultOptions: [],
 	create(context) {
+		if (!isJsxFile(context.filename)) return {};
 		const { sourceCode } = context;
 		return { JSXOpeningElement(node) {
 			if (!hasUnsortedProps(node.attributes)) return;
@@ -1563,6 +1572,7 @@ const jsxSpreadPropsLast = _typescript_eslint_utils.ESLintUtils.RuleCreator((nam
 	},
 	defaultOptions: [],
 	create(context) {
+		if (!isJsxFile(context.filename)) return {};
 		return { JSXOpeningElement(node) {
 			const { attributes } = node;
 			let lastNonSpreadIndex = -1;
@@ -1806,6 +1816,7 @@ const noGhostWrapper = createRule$16({
 	},
 	defaultOptions: [],
 	create(context) {
+		if (!isJsxFile(context.filename)) return {};
 		return { JSXOpeningElement(node) {
 			if (node.name.type !== _typescript_eslint_utils.AST_NODE_TYPES.JSXIdentifier) return;
 			const tagName = node.name.name;
@@ -1830,6 +1841,8 @@ const noHelperFunctionInHook = _typescript_eslint_utils.ESLintUtils.RuleCreator(
 	},
 	defaultOptions: [],
 	create(context) {
+		const basename = path.default.basename(context.filename);
+		if (!(basename.endsWith(".hook.ts") || basename.endsWith(".hooks.ts"))) return {};
 		function isAtProgramLevel(node) {
 			const { parent } = node;
 			if (parent === void 0) return false;
@@ -1871,6 +1884,8 @@ const noHelperFunctionInTest = _typescript_eslint_utils.ESLintUtils.RuleCreator(
 	},
 	defaultOptions: [],
 	create(context) {
+		const basename = path.default.basename(context.filename);
+		if (!(basename.endsWith(".test.ts") || basename.endsWith(".test.tsx"))) return {};
 		return {
 			FunctionDeclaration(node) {
 				if (node.parent.type === _typescript_eslint_utils.AST_NODE_TYPES.Program) context.report({
@@ -2413,6 +2428,7 @@ const noRedundantFragment = createRule$10({
 	},
 	defaultOptions: [],
 	create(context) {
+		if (!isJsxFile(context.filename)) return {};
 		return {
 			JSXFragment(node) {
 				const count = countMeaningfulChildren(node.children);
@@ -3017,6 +3033,7 @@ const preferJSXTemplateLiterals = _typescript_eslint_utils.ESLintUtils.RuleCreat
 	},
 	defaultOptions: [],
 	create(context) {
+		if (!isJsxFile(context.filename)) return {};
 		function handleTextBeforeExpression(textNode, exprNode) {
 			const textValue = textNode.value;
 			const trimmedText = textValue.trim();
@@ -3128,6 +3145,7 @@ const preferPropsWithChildren = _typescript_eslint_utils.ESLintUtils.RuleCreator
 	},
 	defaultOptions: [],
 	create(context) {
+		if (!isJsxFile(context.filename)) return {};
 		function isReactNodeType(typeNode) {
 			if (!typeNode) return false;
 			if (typeNode.type !== _typescript_eslint_utils.AST_NODE_TYPES.TSTypeReference) return false;
@@ -3176,6 +3194,7 @@ const preferReactImportTypes = _typescript_eslint_utils.ESLintUtils.RuleCreator(
 	},
 	defaultOptions: [],
 	create(context) {
+		if (!isJsxFile(context.filename)) return {};
 		const reactTypes = new Set([
 			"ReactNode",
 			"ReactElement",
@@ -3288,6 +3307,7 @@ const reactPropsDestructure = _typescript_eslint_utils.ESLintUtils.RuleCreator((
 	},
 	defaultOptions: [],
 	create(context) {
+		if (!isJsxFile(context.filename)) return {};
 		function hasJSXInConditional(node) {
 			return node.consequent.type === _typescript_eslint_utils.AST_NODE_TYPES.JSXElement || node.consequent.type === _typescript_eslint_utils.AST_NODE_TYPES.JSXFragment || node.alternate.type === _typescript_eslint_utils.AST_NODE_TYPES.JSXElement || node.alternate.type === _typescript_eslint_utils.AST_NODE_TYPES.JSXFragment;
 		}
@@ -3793,6 +3813,8 @@ const baseRules = {
 	"nextfriday/no-direct-date": "warn",
 	"nextfriday/no-emoji": "warn",
 	"nextfriday/no-env-fallback": "warn",
+	"nextfriday/no-helper-function-in-hook": "warn",
+	"nextfriday/no-helper-function-in-test": "warn",
 	"nextfriday/no-inline-default-export": "warn",
 	"nextfriday/no-inline-nested-object": "warn",
 	"nextfriday/no-inline-return-properties": "warn",
@@ -3837,6 +3859,8 @@ const baseRecommendedRules = {
 	"nextfriday/no-direct-date": "error",
 	"nextfriday/no-emoji": "error",
 	"nextfriday/no-env-fallback": "error",
+	"nextfriday/no-helper-function-in-hook": "error",
+	"nextfriday/no-helper-function-in-test": "error",
 	"nextfriday/no-inline-default-export": "error",
 	"nextfriday/no-inline-nested-object": "error",
 	"nextfriday/no-inline-return-properties": "error",