eslint-plugin-nextfriday 3.2.0 → 3.2.1

package/lib/index.js

@@ -1,7 +1,7 @@
 // package.json
 var package_default = {
   name: "eslint-plugin-nextfriday",
-  version: "3.2.0",
+  version: "3.2.1",
   description: "A comprehensive ESLint plugin providing custom rules and configurations for Next Friday development workflows.",
   keywords: [
     "eslint",
@@ -408,40 +408,14 @@ var createRule3 = ESLintUtils3.RuleCreator(
 );
 var SCREAMING_SNAKE_CASE_REGEX = /^[A-Z][A-Z0-9]*(?:_[A-Z0-9]+)*$/;
 var SNAKE_CASE_REGEX2 = /^[a-z]+_[a-z0-9_]*$/;
-var BOOLEAN_PREFIXES2 = ["is", "has", "should", "can", "did", "will", "was", "are", "does", "had"];
 var toScreamingSnakeCase = (str) => str.replace(/([a-z])([A-Z])/g, "$1_$2").replace(/([A-Z])([A-Z][a-z])/g, "$1_$2").toUpperCase();
-var startsWithBooleanPrefix2 = (name) => BOOLEAN_PREFIXES2.some((prefix) => {
-  if (!name.startsWith(prefix)) {
-    return false;
-  }
-  if (name.length === prefix.length) {
-    return true;
-  }
-  const nextChar = name.charAt(prefix.length);
-  return nextChar === nextChar.toUpperCase() && nextChar !== nextChar.toLowerCase();
-});
-var isBooleanLiteral2 = (init) => init.type === AST_NODE_TYPES4.Literal && typeof init.value === "boolean";
-var isAsConstAssertion = (node) => node.type === AST_NODE_TYPES4.TSAsExpression && node.typeAnnotation.type === AST_NODE_TYPES4.TSTypeReference && node.typeAnnotation.typeName.type === AST_NODE_TYPES4.Identifier && node.typeAnnotation.typeName.name === "const";
-var isStaticValue2 = (init) => {
-  if (isAsConstAssertion(init)) {
-    return true;
-  }
+var isMagicLiteral = (init) => {
   if (init.type === AST_NODE_TYPES4.Literal) {
-    return true;
+    return typeof init.value === "string" || typeof init.value === "number";
   }
-  if (init.type === AST_NODE_TYPES4.UnaryExpression && init.argument.type === AST_NODE_TYPES4.Literal) {
-    return true;
-  }
-  if (init.type === AST_NODE_TYPES4.TemplateLiteral && init.expressions.length === 0) {
-    return true;
-  }
-  if (init.type === AST_NODE_TYPES4.ArrayExpression) {
-    return init.elements.every((el) => el !== null && el.type !== AST_NODE_TYPES4.SpreadElement && isStaticValue2(el));
-  }
-  if (init.type === AST_NODE_TYPES4.ObjectExpression) {
-    return init.properties.every(
-      (prop) => prop.type === AST_NODE_TYPES4.Property && isStaticValue2(prop.value)
-    );
+  if (init.type === AST_NODE_TYPES4.UnaryExpression) {
+    const { argument, operator } = init;
+    return (operator === "-" || operator === "+") && argument.type === AST_NODE_TYPES4.Literal && typeof argument.value === "number";
   }
   return false;
 };
@@ -455,13 +429,12 @@ var isGlobalScope2 = (node) => {
   }
   return false;
 };
-var isFunctionOrComponent = (init) => init.type === AST_NODE_TYPES4.ArrowFunctionExpression || init.type === AST_NODE_TYPES4.FunctionExpression;
 var enforceConstantCase = createRule3({
   name: "enforce-constant-case",
   meta: {
     type: "suggestion",
     docs: {
-      description: "Enforce SCREAMING_SNAKE_CASE for global constant static values"
+      description: "Enforce SCREAMING_SNAKE_CASE for global magic-number and magic-text constants"
     },
     messages: {
       useScreamingSnakeCase: "Constant '{{ name }}' should use SCREAMING_SNAKE_CASE. Rename to '{{ suggestion }}'.",
@@ -483,16 +456,10 @@ var enforceConstantCase = createRule3({
           if (declarator.id.type !== AST_NODE_TYPES4.Identifier || !declarator.init) {
             return;
           }
-          if (isFunctionOrComponent(declarator.init)) {
-            return;
-          }
-          if (!isStaticValue2(declarator.init)) {
+          if (!isMagicLiteral(declarator.init)) {
             return;
           }
           const { name } = declarator.id;
-          if (isBooleanLiteral2(declarator.init) && startsWithBooleanPrefix2(name)) {
-            return;
-          }
           if (SNAKE_CASE_REGEX2.test(name)) {
             context.report({
               node: declarator.id,
@@ -2822,9 +2789,9 @@ var createRule38 = ESLintUtils38.RuleCreator(
   (name) => `https://github.com/next-friday/eslint-plugin-nextfriday/blob/main/docs/rules/${name.replaceAll("-", "_").toUpperCase()}.md`
 );
 var SCREAMING_SNAKE_CASE_REGEX3 = /^[A-Z][A-Z0-9]*(?:_[A-Z0-9]+)*$/;
-var isAsConstAssertion2 = (node) => node.type === AST_NODE_TYPES36.TSAsExpression && node.typeAnnotation.type === AST_NODE_TYPES36.TSTypeReference && node.typeAnnotation.typeName.type === AST_NODE_TYPES36.Identifier && node.typeAnnotation.typeName.name === "const";
-var isStaticValue3 = (init) => {
-  if (isAsConstAssertion2(init)) {
+var isAsConstAssertion = (node) => node.type === AST_NODE_TYPES36.TSAsExpression && node.typeAnnotation.type === AST_NODE_TYPES36.TSTypeReference && node.typeAnnotation.typeName.type === AST_NODE_TYPES36.Identifier && node.typeAnnotation.typeName.name === "const";
+var isStaticValue2 = (init) => {
+  if (isAsConstAssertion(init)) {
     return true;
   }
   if (init.type === AST_NODE_TYPES36.Literal) {
@@ -2837,11 +2804,11 @@ var isStaticValue3 = (init) => {
     return true;
   }
   if (init.type === AST_NODE_TYPES36.ArrayExpression) {
-    return init.elements.every((el) => el !== null && el.type !== AST_NODE_TYPES36.SpreadElement && isStaticValue3(el));
+    return init.elements.every((el) => el !== null && el.type !== AST_NODE_TYPES36.SpreadElement && isStaticValue2(el));
   }
   if (init.type === AST_NODE_TYPES36.ObjectExpression) {
     return init.properties.every(
-      (prop) => prop.type === AST_NODE_TYPES36.Property && isStaticValue3(prop.value)
+      (prop) => prop.type === AST_NODE_TYPES36.Property && isStaticValue2(prop.value)
     );
   }
   return false;
@@ -2901,7 +2868,7 @@ var noMisleadingConstantCase = createRule38({
           if (!declarator.init) {
             return;
           }
-          if (!isStaticValue3(declarator.init)) {
+          if (!isStaticValue2(declarator.init)) {
             context.report({
               node: declarator.id,
               messageId: "dynamicScreamingCase",