eslint-plugin-nextfriday 3.1.0 → 3.2.0

package/CHANGELOG.md

@@ -1,5 +1,13 @@
 # eslint-plugin-nextfriday
 
+## 3.2.0
+
+### Minor Changes
+
+- [#118](https://github.com/next-friday/eslint-plugin-nextfriday/pull/118) [`143eee9`](https://github.com/next-friday/eslint-plugin-nextfriday/commit/143eee9fd0c6aed00e10677a6cad448dbdc9136e) Thanks [@joetakara](https://github.com/joetakara)! - Add `index-export-only` rule. Restricts `index.{js,jsx,ts,tsx}` files to imports, re-exports, and type/interface declarations only — flagging local function/class/variable declarations, inline `export const`/`export function`/`export class`, top-level expressions, and control flow. Type aliases, interfaces, and `export type` are allowed since they have no runtime cost. Included in `base`, `react`, and `nextjs` presets.
+
+- [#118](https://github.com/next-friday/eslint-plugin-nextfriday/pull/118) [`143eee9`](https://github.com/next-friday/eslint-plugin-nextfriday/commit/143eee9fd0c6aed00e10677a6cad448dbdc9136e) Thanks [@joetakara](https://github.com/joetakara)! - Add `no-inline-type-import` rule. Disallows inline `type` markers on import specifiers (`import { type Foo }` and `import { value, type Foo }`); auto-fix hoists single inline-type imports to `import type { ... }` and splits mixed value/type imports into two separate statements while preserving aliases, default specifiers, and quote style. Also strips redundant inline markers from existing `import type { ... }` statements. Included in `base`, `react`, and `nextjs` presets.
+
 ## 3.1.0
 
 ### Minor Changes

package/README.md

@@ -434,6 +434,7 @@ In practice: turn the high tier on as `"error"` first, leave the medium tier as
 | [enforce-sorted-destructuring](docs/rules/ENFORCE_SORTED_DESTRUCTURING.md)   | Enforce alphabetical sorting of destructured properties                | ✅      |
 | [no-env-fallback](docs/rules/NO_ENV_FALLBACK.md)                             | Disallow fallback values for environment variables                     | ❌      |
 | [no-inline-default-export](docs/rules/NO_INLINE_DEFAULT_EXPORT.md)           | Disallow inline default exports - declare first, then export           | ❌      |
+| [index-export-only](docs/rules/INDEX_EXPORT_ONLY.md)                         | Restrict index files to imports, re-exports, and type declarations     | ❌      |
 | [no-direct-date](docs/rules/NO_DIRECT_DATE.md)                               | Disallow direct usage of Date constructor and methods                  | ❌      |
 | [newline-after-multiline-block](docs/rules/NEWLINE_AFTER_MULTILINE_BLOCK.md) | Require a blank line after multi-line statements                       | ✅      |
 | [newline-before-return](docs/rules/NEWLINE_BEFORE_RETURN.md)                 | Require a blank line before return statements                          | ✅      |
@@ -449,6 +450,7 @@ In practice: turn the high tier on as `"error"` first, leave the medium tier as
 | Rule                                                                 | Description                                               | Fixable |
 | -------------------------------------------------------------------- | --------------------------------------------------------- | ------- |
 | [no-relative-imports](docs/rules/NO_RELATIVE_IMPORTS.md)             | Disallow relative imports with ../ - use absolute imports | ❌      |
+| [no-inline-type-import](docs/rules/NO_INLINE_TYPE_IMPORT.md)         | Disallow inline 'type' markers - hoist or split imports   | ✅      |
 | [prefer-import-type](docs/rules/PREFER_IMPORT_TYPE.md)               | Enforce using 'import type' for type-only imports         | ✅      |
 | [prefer-react-import-types](docs/rules/PREFER_REACT_IMPORT_TYPES.md) | Enforce direct imports from 'react' instead of React.X    | ✅      |
 | [sort-exports](docs/rules/SORT_EXPORTS.md)                           | Enforce a consistent ordering of export groups            | ✅      |
@@ -498,16 +500,16 @@ In practice: turn the high tier on as `"error"` first, leave the medium tier as
 
 | Preset               | Severity | Base Rules | JSX Rules | Next.js Rules | Total Rules |
 | -------------------- | -------- | ---------- | --------- | ------------- | ----------- |
-| `base`               | warn     | 40         | 0         | 0             | 40          |
-| `base/recommended`   | error    | 40         | 0         | 0             | 40          |
-| `react`              | warn     | 40         | 16        | 0             | 56          |
-| `react/recommended`  | error    | 40         | 16        | 0             | 56          |
-| `nextjs`             | warn     | 40         | 16        | 1             | 57          |
-| `nextjs/recommended` | error    | 40         | 16        | 1             | 57          |
+| `base`               | warn     | 42         | 0         | 0             | 42          |
+| `base/recommended`   | error    | 42         | 0         | 0             | 42          |
+| `react`              | warn     | 42         | 16        | 0             | 58          |
+| `react/recommended`  | error    | 42         | 16        | 0             | 58          |
+| `nextjs`             | warn     | 42         | 16        | 1             | 59          |
+| `nextjs/recommended` | error    | 42         | 16        | 1             | 59          |
 
 The `nextjs` and `nextjs/recommended` presets ship as an array of two flat-config objects: the rule set above, plus a routing override that disables `nextfriday/file-kebab-case` and `nextfriday/jsx-pascal-case` for files matching `app/**/*.{js,jsx,ts,tsx}`, `src/app/**/*.{js,jsx,ts,tsx}`, `pages/**/*.{js,jsx,ts,tsx}`, and `src/pages/**/*.{js,jsx,ts,tsx}`. Next.js owns the filenames in those directories (`page.tsx`, `layout.tsx`, `route.ts`, `middleware.ts`, etc.), so the plugin steps out of the way. ESLint 9+ flattens nested config arrays automatically, so spreading the preset works as expected.
 
-### Base Configuration Rules (40 rules)
+### Base Configuration Rules (42 rules)
 
 Included in `base`, `base/recommended`, and all other presets:
 
@@ -521,6 +523,7 @@ Included in `base`, `base/recommended`, and all other presets:
 - `nextfriday/enforce-sorted-destructuring`
 - `nextfriday/enforce-type-declaration-order`
 - `nextfriday/file-kebab-case`
+- `nextfriday/index-export-only`
 - `nextfriday/newline-after-multiline-block`
 - `nextfriday/newline-before-return`
 - `nextfriday/no-complex-inline-return`
@@ -530,6 +533,7 @@ Included in `base`, `base/recommended`, and all other presets:
 - `nextfriday/no-inline-default-export`
 - `nextfriday/no-inline-nested-object`
 - `nextfriday/no-inline-return-properties`
+- `nextfriday/no-inline-type-import`
 - `nextfriday/no-lazy-identifiers`
 - `nextfriday/no-logic-in-params`
 - `nextfriday/no-misleading-constant-case`

package/docs/rules/INDEX_EXPORT_ONLY.md

@@ -0,0 +1,88 @@
+# index-export-only
+
+Restrict `index` files to imports, re-exports, and type declarations only.
+
+## Rule Details
+
+This rule enforces that `index.{js,jsx,ts,tsx}` files act purely as barrel files. Any runtime declaration — functions, classes, variables, top-level expressions, or inline `export const`/`export function`/`export class` — must live in its own module and be re-exported from the index.
+
+The rule applies only when the basename of the file is `index`. Files like `index.test.ts`, `index.spec.ts`, or `index.d.ts` are not affected.
+
+### Why?
+
+Index files are entry points. Mixing implementation into them obscures where behavior lives, breaks file-based code navigation, and makes the import surface harder to refactor. A barrel file should describe the public API of a directory — nothing more.
+
+## Examples
+
+### Incorrect
+
+```ts
+import { clsx, type ClassValue } from "clsx";
+import { twMerge } from "tailwind-merge";
+
+function cn(...inputs: ClassValue[]): string {
+  return twMerge(clsx(inputs));
+}
+
+export { cn };
+```
+
+```ts
+export const VERSION = "1.0.0";
+
+export function helper() {
+  return 1;
+}
+
+export class Service {}
+```
+
+```ts
+console.log("loaded");
+```
+
+### Correct
+
+```ts
+export { cn } from "./cn";
+export * from "./types";
+export type { Props } from "./props";
+export { default as Button } from "./button";
+```
+
+```ts
+import button from "./button";
+
+export default button;
+```
+
+```ts
+export type Foo = string;
+export interface Bar {
+  id: string;
+}
+```
+
+## What This Rule Allows
+
+- `import` statements (including side-effect imports like `import "./styles.css"`)
+- Specifier-only `export` and `export ... from` re-exports
+- `export *` and `export * as ns` re-exports
+- `export default identifier` where the identifier comes from an import
+- Top-level `type` aliases and `interface` declarations (they have no runtime cost)
+- `export type` and `export interface` declarations
+
+## What This Rule Disallows
+
+- `function`, `class`, and `const`/`let`/`var` declarations at the top level
+- Inline `export function`, `export class`, `export const`, `export let`, `export var`
+- `export default` of a function/class/literal/object expression
+- Top-level expression statements and control flow (`console.log(...)`, `if`, `for`, etc.)
+
+## When Not To Use It
+
+If your project intentionally mixes implementation and re-exports in index files — for example, a single-file utility library where `index.ts` is the only source file — disable this rule.
+
+## Related Rules
+
+- [no-inline-default-export](./NO_INLINE_DEFAULT_EXPORT.md) - Disallow inline default and named exports across all files

package/docs/rules/NO_INLINE_TYPE_IMPORT.md

@@ -0,0 +1,86 @@
+# no-inline-type-import
+
+Disallow inline `type` markers on import specifiers. Use `import type` or split into a separate type-only import statement.
+
+> This rule is auto-fixable using `--fix`.
+
+## Rule Details
+
+This rule forbids the inline-`type` form `import { type Foo }` and the mixed form `import { value, type Foo }`. Type-only imports must be expressed at the statement level with `import type { ... }`. When value and type imports come from the same module, the rule splits them into two separate statements.
+
+### Why?
+
+Statement-level `import type` makes the runtime cost of every import unambiguous at a glance, simplifies tooling that distinguishes erased imports from real ones (bundlers, type-only emit, transpilers), and removes the need for readers to scan each specifier for an inline keyword.
+
+## Examples
+
+### Incorrect
+
+```ts
+import { type foo } from "bar";
+
+import { baz, type moo } from "mee";
+
+import Default, { value, type Foo } from "src";
+```
+
+### Correct
+
+```ts
+import type { foo } from "bar";
+
+import { baz } from "mee";
+import type { moo } from "mee";
+
+import Default, { value } from "src";
+import type { Foo } from "src";
+```
+
+## Auto-fixing
+
+The rule's `--fix` produces these transformations:
+
+```ts
+// Single inline type → hoisted
+import { type foo } from "bar";
+// becomes
+import type { foo } from "bar";
+
+// All inline types → hoisted
+import { type foo, type bar } from "src";
+// becomes
+import type { foo, bar } from "src";
+
+// Mixed value + inline type → split
+import { baz, type moo } from "mee";
+// becomes
+import { baz } from "mee";
+import type { moo } from "mee";
+
+// Default + inline type → split
+import Default, { type Foo } from "src";
+// becomes
+import Default from "src";
+import type { Foo } from "src";
+
+// Aliases are preserved
+import { foo as bar, type baz as qux } from "src";
+// becomes
+import { foo as bar } from "src";
+import type { baz as qux } from "src";
+
+// Redundant inline markers inside `import type` are stripped
+import type { foo, type bar } from "src";
+// becomes
+import type { foo, bar } from "src";
+```
+
+After auto-fix, other import-ordering rules (such as `sort-imports`) may re-order the resulting statements according to their own grouping rules.
+
+## When Not To Use It
+
+If your codebase intentionally uses the inline `type` form to keep value and type imports adjacent in a single statement, disable this rule.
+
+## Related Rules
+
+- [prefer-import-type](./PREFER_IMPORT_TYPE.md) - Hoists imports that are used only as types to `import type`. Complements this rule for usage-based detection.