eslint-plugin-nextfriday 1.3.0 → 1.5.0

package/lib/index.js

@@ -1,7 +1,7 @@
 // package.json
 var package_default = {
   name: "eslint-plugin-nextfriday",
-  version: "1.3.0",
+  version: "1.5.0",
   description: "A comprehensive ESLint plugin providing custom rules and configurations for Next Friday development workflows.",
   keywords: [
     "eslint",
@@ -51,8 +51,8 @@ var package_default = {
     "changeset:publish": "npm publish --provenance --access public",
     "changeset:version": "changeset version",
     clear: "rm -rf lib node_modules/.cache .eslintcache",
-    eslint: "eslint src --ext .js,.ts,.mjs --fix",
-    "eslint:check": "eslint src --ext .js,.ts,.mjs",
+    eslint: "eslint src --ext .js,.ts --fix",
+    "eslint:check": "eslint src --ext .js,.ts",
     preinstall: "npx only-allow pnpm",
     prepare: "husky",
     prepublishOnly: "pnpm run build",
@@ -341,13 +341,59 @@ var mdFilenameCaseRestriction = createRule4({
 });
 var md_filename_case_restriction_default = mdFilenameCaseRestriction;
 
+// src/rules/no-complex-inline-return.ts
+import { ESLintUtils as ESLintUtils5, AST_NODE_TYPES as AST_NODE_TYPES2 } from "@typescript-eslint/utils";
+var createRule5 = ESLintUtils5.RuleCreator(
+  (name) => `https://github.com/next-friday/eslint-plugin-nextfriday/blob/main/docs/rules/${name.replace(/-/g, "_").toUpperCase()}.md`
+);
+var noComplexInlineReturn = createRule5({
+  name: "no-complex-inline-return",
+  meta: {
+    type: "suggestion",
+    docs: {
+      description: "Disallow complex inline expressions in return statements - prefer extracting to a const first"
+    },
+    messages: {
+      noComplexInlineReturn: "Avoid returning complex expressions directly. Extract to a const variable first for better readability."
+    },
+    schema: []
+  },
+  defaultOptions: [],
+  create(context) {
+    const isComplexExpression = (node) => {
+      if (!node) return false;
+      if (node.type === AST_NODE_TYPES2.ConditionalExpression) {
+        return true;
+      }
+      if (node.type === AST_NODE_TYPES2.LogicalExpression) {
+        return true;
+      }
+      if (node.type === AST_NODE_TYPES2.NewExpression) {
+        return true;
+      }
+      return false;
+    };
+    return {
+      ReturnStatement(node) {
+        if (node.argument && isComplexExpression(node.argument)) {
+          context.report({
+            node: node.argument,
+            messageId: "noComplexInlineReturn"
+          });
+        }
+      }
+    };
+  }
+});
+var no_complex_inline_return_default = noComplexInlineReturn;
+
 // src/rules/no-emoji.ts
 import emojiRegex from "emoji-regex";
-import { ESLintUtils as ESLintUtils5 } from "@typescript-eslint/utils";
-var createRule5 = ESLintUtils5.RuleCreator(
+import { ESLintUtils as ESLintUtils6 } from "@typescript-eslint/utils";
+var createRule6 = ESLintUtils6.RuleCreator(
   (name) => `https://github.com/next-friday/eslint-plugin-nextfriday/blob/main/docs/rules/${name.replace(/-/g, "_").toUpperCase()}.md`
 );
-var noEmoji = createRule5({
+var noEmoji = createRule6({
   name: "no-emoji",
   meta: {
     type: "problem",
@@ -380,12 +426,65 @@ var noEmoji = createRule5({
 });
 var no_emoji_default = noEmoji;
 
+// src/rules/no-env-fallback.ts
+import { ESLintUtils as ESLintUtils7, AST_NODE_TYPES as AST_NODE_TYPES3 } from "@typescript-eslint/utils";
+var createRule7 = ESLintUtils7.RuleCreator(
+  (name) => `https://github.com/next-friday/eslint-plugin-nextfriday/blob/main/docs/rules/${name.replace(/-/g, "_").toUpperCase()}.md`
+);
+var noEnvFallback = createRule7({
+  name: "no-env-fallback",
+  meta: {
+    type: "problem",
+    docs: {
+      description: "Disallow fallback values for environment variables as they can be dangerous in production"
+    },
+    messages: {
+      noEnvFallback: "Avoid using fallback values with process.env. Environment variables should fail explicitly when missing rather than silently using a default value."
+    },
+    schema: []
+  },
+  defaultOptions: [],
+  create(context) {
+    const isProcessEnvAccess = (node) => {
+      if (node.type !== AST_NODE_TYPES3.MemberExpression) {
+        return false;
+      }
+      const { object } = node;
+      if (object.type !== AST_NODE_TYPES3.MemberExpression) {
+        return false;
+      }
+      const processNode = object.object;
+      const envNode = object.property;
+      return processNode.type === AST_NODE_TYPES3.Identifier && processNode.name === "process" && envNode.type === AST_NODE_TYPES3.Identifier && envNode.name === "env";
+    };
+    return {
+      LogicalExpression(node) {
+        if ((node.operator === "||" || node.operator === "??") && isProcessEnvAccess(node.left)) {
+          context.report({
+            node,
+            messageId: "noEnvFallback"
+          });
+        }
+      },
+      ConditionalExpression(node) {
+        if (isProcessEnvAccess(node.test)) {
+          context.report({
+            node,
+            messageId: "noEnvFallback"
+          });
+        }
+      }
+    };
+  }
+});
+var no_env_fallback_default = noEnvFallback;
+
 // src/rules/no-explicit-return-type.ts
-import { ESLintUtils as ESLintUtils6 } from "@typescript-eslint/utils";
-var createRule6 = ESLintUtils6.RuleCreator(
+import { ESLintUtils as ESLintUtils8 } from "@typescript-eslint/utils";
+var createRule8 = ESLintUtils8.RuleCreator(
   (name) => `https://github.com/next-friday/eslint-plugin-nextfriday/blob/main/docs/rules/${name.replace(/-/g, "_").toUpperCase()}.md`
 );
-var noExplicitReturnType = createRule6({
+var noExplicitReturnType = createRule8({
   name: "no-explicit-return-type",
   meta: {
     type: "suggestion",
@@ -424,12 +523,76 @@ var noExplicitReturnType = createRule6({
 });
 var no_explicit_return_type_default = noExplicitReturnType;
 
+// src/rules/no-logic-in-params.ts
+import { ESLintUtils as ESLintUtils9, AST_NODE_TYPES as AST_NODE_TYPES4 } from "@typescript-eslint/utils";
+var createRule9 = ESLintUtils9.RuleCreator(
+  (name) => `https://github.com/next-friday/eslint-plugin-nextfriday/blob/main/docs/rules/${name.replace(/-/g, "_").toUpperCase()}.md`
+);
+var noLogicInParams = createRule9({
+  name: "no-logic-in-params",
+  meta: {
+    type: "suggestion",
+    docs: {
+      description: "Disallow logic or conditions in function parameters - extract to a const variable first"
+    },
+    messages: {
+      noLogicInParams: "Avoid logic or conditions in function parameters. Extract to a const variable first for better readability."
+    },
+    schema: []
+  },
+  defaultOptions: [],
+  create(context) {
+    const isComplexExpression = (node) => {
+      if (node.type === AST_NODE_TYPES4.SpreadElement) {
+        return false;
+      }
+      if (node.type === AST_NODE_TYPES4.ConditionalExpression) {
+        return true;
+      }
+      if (node.type === AST_NODE_TYPES4.LogicalExpression) {
+        return true;
+      }
+      if (node.type === AST_NODE_TYPES4.BinaryExpression) {
+        const logicalOperators = ["==", "===", "!=", "!==", "<", ">", "<=", ">=", "in", "instanceof"];
+        return logicalOperators.includes(node.operator);
+      }
+      if (node.type === AST_NODE_TYPES4.UnaryExpression) {
+        return node.operator === "!";
+      }
+      return false;
+    };
+    return {
+      CallExpression(node) {
+        node.arguments.forEach((arg) => {
+          if (isComplexExpression(arg)) {
+            context.report({
+              node: arg,
+              messageId: "noLogicInParams"
+            });
+          }
+        });
+      },
+      NewExpression(node) {
+        node.arguments.forEach((arg) => {
+          if (isComplexExpression(arg)) {
+            context.report({
+              node: arg,
+              messageId: "noLogicInParams"
+            });
+          }
+        });
+      }
+    };
+  }
+});
+var no_logic_in_params_default = noLogicInParams;
+
 // src/rules/prefer-destructuring-params.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES2, ESLintUtils as ESLintUtils7 } from "@typescript-eslint/utils";
-var createRule7 = ESLintUtils7.RuleCreator(
+import { AST_NODE_TYPES as AST_NODE_TYPES5, ESLintUtils as ESLintUtils10 } from "@typescript-eslint/utils";
+var createRule10 = ESLintUtils10.RuleCreator(
   (name) => `https://github.com/next-friday/eslint-plugin-nextfriday/blob/main/docs/rules/${name.replace(/-/g, "_").toUpperCase()}.md`
 );
-var preferDestructuringParams = createRule7({
+var preferDestructuringParams = createRule10({
   name: "prefer-destructuring-params",
   meta: {
     type: "suggestion",
@@ -445,18 +608,18 @@ var preferDestructuringParams = createRule7({
   create(context) {
     const isCallbackFunction = (node) => {
       const { parent } = node;
-      return parent?.type === AST_NODE_TYPES2.CallExpression;
+      return parent?.type === AST_NODE_TYPES5.CallExpression;
     };
     const isDeveloperFunction = (node) => {
-      if (node.type === AST_NODE_TYPES2.FunctionDeclaration) {
+      if (node.type === AST_NODE_TYPES5.FunctionDeclaration) {
         return true;
       }
-      if (node.type === AST_NODE_TYPES2.FunctionExpression || node.type === AST_NODE_TYPES2.ArrowFunctionExpression) {
+      if (node.type === AST_NODE_TYPES5.FunctionExpression || node.type === AST_NODE_TYPES5.ArrowFunctionExpression) {
         if (isCallbackFunction(node)) {
           return false;
         }
         const { parent } = node;
-        return parent?.type === AST_NODE_TYPES2.VariableDeclarator || parent?.type === AST_NODE_TYPES2.AssignmentExpression || parent?.type === AST_NODE_TYPES2.Property || parent?.type === AST_NODE_TYPES2.MethodDefinition;
+        return parent?.type === AST_NODE_TYPES5.VariableDeclarator || parent?.type === AST_NODE_TYPES5.AssignmentExpression || parent?.type === AST_NODE_TYPES5.Property || parent?.type === AST_NODE_TYPES5.MethodDefinition;
       }
       return false;
     };
@@ -468,7 +631,7 @@ var preferDestructuringParams = createRule7({
       if (!isDeveloperFunction(node)) {
         return;
       }
-      if (node.type === AST_NODE_TYPES2.FunctionDeclaration && node.id) {
+      if (node.type === AST_NODE_TYPES5.FunctionDeclaration && node.id) {
         const functionName = node.id.name;
         if (functionName.startsWith("_") || functionName.includes("$") || /^[A-Z][a-zA-Z]*$/.test(functionName)) {
           return;
@@ -478,7 +641,7 @@ var preferDestructuringParams = createRule7({
         return;
       }
       const hasNonDestructuredParams = node.params.some(
-        (param) => param.type !== AST_NODE_TYPES2.ObjectPattern && param.type !== AST_NODE_TYPES2.RestElement
+        (param) => param.type !== AST_NODE_TYPES5.ObjectPattern && param.type !== AST_NODE_TYPES5.RestElement
       );
       if (hasNonDestructuredParams) {
         context.report({
@@ -497,11 +660,11 @@ var preferDestructuringParams = createRule7({
 var prefer_destructuring_params_default = preferDestructuringParams;
 
 // src/rules/prefer-import-type.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES3, ESLintUtils as ESLintUtils8 } from "@typescript-eslint/utils";
-var createRule8 = ESLintUtils8.RuleCreator(
+import { AST_NODE_TYPES as AST_NODE_TYPES6, ESLintUtils as ESLintUtils11 } from "@typescript-eslint/utils";
+var createRule11 = ESLintUtils11.RuleCreator(
   (name) => `https://github.com/next-friday/eslint-plugin-nextfriday/blob/main/docs/rules/${name.replace(/-/g, "_").toUpperCase()}.md`
 );
-var preferImportType = createRule8({
+var preferImportType = createRule11({
   name: "prefer-import-type",
   meta: {
     type: "suggestion",
@@ -532,14 +695,14 @@ var preferImportType = createRule8({
         return;
       }
       const isTypeOnlyImport = node.specifiers.every((specifier) => {
-        if (specifier.type === AST_NODE_TYPES3.ImportDefaultSpecifier) {
+        if (specifier.type === AST_NODE_TYPES6.ImportDefaultSpecifier) {
           return false;
         }
-        if (specifier.type === AST_NODE_TYPES3.ImportNamespaceSpecifier) {
+        if (specifier.type === AST_NODE_TYPES6.ImportNamespaceSpecifier) {
           return false;
         }
-        if (specifier.type === AST_NODE_TYPES3.ImportSpecifier) {
-          const importedName = specifier.imported.type === AST_NODE_TYPES3.Identifier ? specifier.imported.name : specifier.imported.value;
+        if (specifier.type === AST_NODE_TYPES6.ImportSpecifier) {
+          const importedName = specifier.imported.type === AST_NODE_TYPES6.Identifier ? specifier.imported.name : specifier.imported.value;
           const isKnownTypeOnly = node.source.value === "@typescript-eslint/utils" && ["TSESTree", "RuleContext"].includes(importedName) || node.source.value === "react" && ["Component", "ComponentProps", "ReactNode", "FC", "JSX", "ReactElement", "PropsWithChildren"].includes(
             importedName
           ) || importedName.endsWith("Type") || importedName.endsWith("Interface") || importedName.endsWith("Props");
@@ -567,11 +730,11 @@ var preferImportType = createRule8({
 var prefer_import_type_default = preferImportType;
 
 // src/rules/prefer-interface-over-inline-types.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES4, ESLintUtils as ESLintUtils9 } from "@typescript-eslint/utils";
-var createRule9 = ESLintUtils9.RuleCreator(
+import { AST_NODE_TYPES as AST_NODE_TYPES7, ESLintUtils as ESLintUtils12 } from "@typescript-eslint/utils";
+var createRule12 = ESLintUtils12.RuleCreator(
   (name) => `https://github.com/next-friday/eslint-plugin-nextfriday/blob/main/docs/rules/${name.replace(/-/g, "_").toUpperCase()}.md`
 );
-var preferInterfaceOverInlineTypes = createRule9({
+var preferInterfaceOverInlineTypes = createRule12({
   name: "prefer-interface-over-inline-types",
   meta: {
     type: "suggestion",
@@ -587,54 +750,54 @@ var preferInterfaceOverInlineTypes = createRule9({
   defaultOptions: [],
   create(context) {
     function hasJSXInConditional(node) {
-      return node.consequent.type === AST_NODE_TYPES4.JSXElement || node.consequent.type === AST_NODE_TYPES4.JSXFragment || node.alternate.type === AST_NODE_TYPES4.JSXElement || node.alternate.type === AST_NODE_TYPES4.JSXFragment;
+      return node.consequent.type === AST_NODE_TYPES7.JSXElement || node.consequent.type === AST_NODE_TYPES7.JSXFragment || node.alternate.type === AST_NODE_TYPES7.JSXElement || node.alternate.type === AST_NODE_TYPES7.JSXFragment;
     }
     function hasJSXInLogical(node) {
-      return node.right.type === AST_NODE_TYPES4.JSXElement || node.right.type === AST_NODE_TYPES4.JSXFragment;
+      return node.right.type === AST_NODE_TYPES7.JSXElement || node.right.type === AST_NODE_TYPES7.JSXFragment;
     }
     function hasJSXReturn(block) {
       return block.body.some((stmt) => {
-        if (stmt.type === AST_NODE_TYPES4.ReturnStatement && stmt.argument) {
-          return stmt.argument.type === AST_NODE_TYPES4.JSXElement || stmt.argument.type === AST_NODE_TYPES4.JSXFragment || stmt.argument.type === AST_NODE_TYPES4.ConditionalExpression && hasJSXInConditional(stmt.argument) || stmt.argument.type === AST_NODE_TYPES4.LogicalExpression && hasJSXInLogical(stmt.argument);
+        if (stmt.type === AST_NODE_TYPES7.ReturnStatement && stmt.argument) {
+          return stmt.argument.type === AST_NODE_TYPES7.JSXElement || stmt.argument.type === AST_NODE_TYPES7.JSXFragment || stmt.argument.type === AST_NODE_TYPES7.ConditionalExpression && hasJSXInConditional(stmt.argument) || stmt.argument.type === AST_NODE_TYPES7.LogicalExpression && hasJSXInLogical(stmt.argument);
         }
         return false;
       });
     }
     function isReactComponent(node) {
-      if (node.type === AST_NODE_TYPES4.ArrowFunctionExpression) {
-        if (node.body.type === AST_NODE_TYPES4.JSXElement || node.body.type === AST_NODE_TYPES4.JSXFragment) {
+      if (node.type === AST_NODE_TYPES7.ArrowFunctionExpression) {
+        if (node.body.type === AST_NODE_TYPES7.JSXElement || node.body.type === AST_NODE_TYPES7.JSXFragment) {
           return true;
         }
-        if (node.body.type === AST_NODE_TYPES4.BlockStatement) {
+        if (node.body.type === AST_NODE_TYPES7.BlockStatement) {
           return hasJSXReturn(node.body);
         }
-      } else if (node.type === AST_NODE_TYPES4.FunctionExpression || node.type === AST_NODE_TYPES4.FunctionDeclaration) {
-        if (node.body && node.body.type === AST_NODE_TYPES4.BlockStatement) {
+      } else if (node.type === AST_NODE_TYPES7.FunctionExpression || node.type === AST_NODE_TYPES7.FunctionDeclaration) {
+        if (node.body && node.body.type === AST_NODE_TYPES7.BlockStatement) {
           return hasJSXReturn(node.body);
         }
       }
       return false;
     }
     function isInlineTypeAnnotation(node) {
-      if (node.type === AST_NODE_TYPES4.TSTypeLiteral) {
+      if (node.type === AST_NODE_TYPES7.TSTypeLiteral) {
         return true;
       }
-      if (node.type === AST_NODE_TYPES4.TSTypeReference && node.typeArguments) {
-        return node.typeArguments.params.some((param) => param.type === AST_NODE_TYPES4.TSTypeLiteral);
+      if (node.type === AST_NODE_TYPES7.TSTypeReference && node.typeArguments) {
+        return node.typeArguments.params.some((param) => param.type === AST_NODE_TYPES7.TSTypeLiteral);
       }
-      if (node.type === AST_NODE_TYPES4.TSUnionType) {
+      if (node.type === AST_NODE_TYPES7.TSUnionType) {
         return node.types.some((type) => isInlineTypeAnnotation(type));
       }
       return false;
     }
     function hasInlineObjectType(node) {
-      if (node.type === AST_NODE_TYPES4.TSTypeLiteral) {
+      if (node.type === AST_NODE_TYPES7.TSTypeLiteral) {
         return true;
       }
-      if (node.type === AST_NODE_TYPES4.TSTypeReference && node.typeArguments) {
-        return node.typeArguments.params.some((param) => param.type === AST_NODE_TYPES4.TSTypeLiteral);
+      if (node.type === AST_NODE_TYPES7.TSTypeReference && node.typeArguments) {
+        return node.typeArguments.params.some((param) => param.type === AST_NODE_TYPES7.TSTypeLiteral);
       }
-      if (node.type === AST_NODE_TYPES4.TSUnionType) {
+      if (node.type === AST_NODE_TYPES7.TSUnionType) {
         return node.types.some((type) => hasInlineObjectType(type));
       }
       return false;
@@ -647,7 +810,7 @@ var preferInterfaceOverInlineTypes = createRule9({
         return;
       }
       const param = node.params[0];
-      if (param.type === AST_NODE_TYPES4.Identifier && param.typeAnnotation) {
+      if (param.type === AST_NODE_TYPES7.Identifier && param.typeAnnotation) {
         const { typeAnnotation } = param.typeAnnotation;
         if (isInlineTypeAnnotation(typeAnnotation) && hasInlineObjectType(typeAnnotation)) {
           context.report({
@@ -667,11 +830,11 @@ var preferInterfaceOverInlineTypes = createRule9({
 var prefer_interface_over_inline_types_default = preferInterfaceOverInlineTypes;
 
 // src/rules/prefer-named-param-types.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES5, ESLintUtils as ESLintUtils10 } from "@typescript-eslint/utils";
-var createRule10 = ESLintUtils10.RuleCreator(
+import { AST_NODE_TYPES as AST_NODE_TYPES8, ESLintUtils as ESLintUtils13 } from "@typescript-eslint/utils";
+var createRule13 = ESLintUtils13.RuleCreator(
   (name) => `https://github.com/next-friday/eslint-plugin-nextfriday/blob/main/docs/rules/${name.replace(/-/g, "_").toUpperCase()}.md`
 );
-var preferNamedParamTypes = createRule10({
+var preferNamedParamTypes = createRule13({
   name: "prefer-named-param-types",
   meta: {
     type: "suggestion",
@@ -686,16 +849,16 @@ var preferNamedParamTypes = createRule10({
   defaultOptions: [],
   create(context) {
     function hasInlineObjectType(param) {
-      if (param.type === AST_NODE_TYPES5.AssignmentPattern) {
+      if (param.type === AST_NODE_TYPES8.AssignmentPattern) {
         return hasInlineObjectType(param.left);
       }
-      if (param.type === AST_NODE_TYPES5.ObjectPattern) {
-        if (param.typeAnnotation?.typeAnnotation.type === AST_NODE_TYPES5.TSTypeLiteral) {
+      if (param.type === AST_NODE_TYPES8.ObjectPattern) {
+        if (param.typeAnnotation?.typeAnnotation.type === AST_NODE_TYPES8.TSTypeLiteral) {
           return true;
         }
       }
-      if (param.type === AST_NODE_TYPES5.Identifier) {
-        if (param.typeAnnotation?.typeAnnotation.type === AST_NODE_TYPES5.TSTypeLiteral) {
+      if (param.type === AST_NODE_TYPES8.Identifier) {
+        if (param.typeAnnotation?.typeAnnotation.type === AST_NODE_TYPES8.TSTypeLiteral) {
           return true;
         }
       }
@@ -729,11 +892,11 @@ var preferNamedParamTypes = createRule10({
 var prefer_named_param_types_default = preferNamedParamTypes;
 
 // src/rules/prefer-react-import-types.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES6, ESLintUtils as ESLintUtils11 } from "@typescript-eslint/utils";
-var createRule11 = ESLintUtils11.RuleCreator(
+import { AST_NODE_TYPES as AST_NODE_TYPES9, ESLintUtils as ESLintUtils14 } from "@typescript-eslint/utils";
+var createRule14 = ESLintUtils14.RuleCreator(
   (name) => `https://github.com/next-friday/eslint-plugin-nextfriday/blob/main/docs/rules/${name.replace(/-/g, "_").toUpperCase()}.md`
 );
-var preferReactImportTypes = createRule11({
+var preferReactImportTypes = createRule14({
   name: "prefer-react-import-types",
   meta: {
     type: "suggestion",
@@ -809,7 +972,7 @@ var preferReactImportTypes = createRule11({
     ]);
     const allReactExports = /* @__PURE__ */ new Set([...reactTypes, ...reactRuntimeExports]);
     function checkMemberExpression(node) {
-      if (node.object.type === AST_NODE_TYPES6.Identifier && node.object.name === "React" && node.property.type === AST_NODE_TYPES6.Identifier && allReactExports.has(node.property.name)) {
+      if (node.object.type === AST_NODE_TYPES9.Identifier && node.object.name === "React" && node.property.type === AST_NODE_TYPES9.Identifier && allReactExports.has(node.property.name)) {
         const typeName = node.property.name;
         const isType = reactTypes.has(typeName);
         const importStatement = isType ? `import type { ${typeName} } from "react"` : `import { ${typeName} } from "react"`;
@@ -826,7 +989,7 @@ var preferReactImportTypes = createRule11({
     return {
       MemberExpression: checkMemberExpression,
       "TSTypeReference > TSQualifiedName": (node) => {
-        if (node.left.type === AST_NODE_TYPES6.Identifier && node.left.name === "React" && node.right.type === AST_NODE_TYPES6.Identifier && allReactExports.has(node.right.name)) {
+        if (node.left.type === AST_NODE_TYPES9.Identifier && node.left.name === "React" && node.right.type === AST_NODE_TYPES9.Identifier && allReactExports.has(node.right.name)) {
           const typeName = node.right.name;
           const isType = reactTypes.has(typeName);
           const importStatement = isType ? `import type { ${typeName} } from "react"` : `import { ${typeName} } from "react"`;
@@ -846,11 +1009,11 @@ var preferReactImportTypes = createRule11({
 var prefer_react_import_types_default = preferReactImportTypes;
 
 // src/rules/react-props-destructure.ts
-import { AST_NODE_TYPES as AST_NODE_TYPES7, ESLintUtils as ESLintUtils12 } from "@typescript-eslint/utils";
-var createRule12 = ESLintUtils12.RuleCreator(
+import { AST_NODE_TYPES as AST_NODE_TYPES10, ESLintUtils as ESLintUtils15 } from "@typescript-eslint/utils";
+var createRule15 = ESLintUtils15.RuleCreator(
   (name) => `https://github.com/next-friday/eslint-plugin-nextfriday/blob/main/docs/rules/${name.replace(/-/g, "_").toUpperCase()}.md`
 );
-var reactPropsDestructure = createRule12({
+var reactPropsDestructure = createRule15({
   name: "react-props-destructure",
   meta: {
     type: "suggestion",
@@ -866,29 +1029,29 @@ var reactPropsDestructure = createRule12({
   defaultOptions: [],
   create(context) {
     function hasJSXInConditional(node) {
-      return node.consequent.type === AST_NODE_TYPES7.JSXElement || node.consequent.type === AST_NODE_TYPES7.JSXFragment || node.alternate.type === AST_NODE_TYPES7.JSXElement || node.alternate.type === AST_NODE_TYPES7.JSXFragment;
+      return node.consequent.type === AST_NODE_TYPES10.JSXElement || node.consequent.type === AST_NODE_TYPES10.JSXFragment || node.alternate.type === AST_NODE_TYPES10.JSXElement || node.alternate.type === AST_NODE_TYPES10.JSXFragment;
     }
     function hasJSXInLogical(node) {
-      return node.right.type === AST_NODE_TYPES7.JSXElement || node.right.type === AST_NODE_TYPES7.JSXFragment;
+      return node.right.type === AST_NODE_TYPES10.JSXElement || node.right.type === AST_NODE_TYPES10.JSXFragment;
     }
     function hasJSXReturn(block) {
       return block.body.some((stmt) => {
-        if (stmt.type === AST_NODE_TYPES7.ReturnStatement && stmt.argument) {
-          return stmt.argument.type === AST_NODE_TYPES7.JSXElement || stmt.argument.type === AST_NODE_TYPES7.JSXFragment || stmt.argument.type === AST_NODE_TYPES7.ConditionalExpression && hasJSXInConditional(stmt.argument) || stmt.argument.type === AST_NODE_TYPES7.LogicalExpression && hasJSXInLogical(stmt.argument);
+        if (stmt.type === AST_NODE_TYPES10.ReturnStatement && stmt.argument) {
+          return stmt.argument.type === AST_NODE_TYPES10.JSXElement || stmt.argument.type === AST_NODE_TYPES10.JSXFragment || stmt.argument.type === AST_NODE_TYPES10.ConditionalExpression && hasJSXInConditional(stmt.argument) || stmt.argument.type === AST_NODE_TYPES10.LogicalExpression && hasJSXInLogical(stmt.argument);
         }
         return false;
       });
     }
     function isReactComponent(node) {
-      if (node.type === AST_NODE_TYPES7.ArrowFunctionExpression) {
-        if (node.body.type === AST_NODE_TYPES7.JSXElement || node.body.type === AST_NODE_TYPES7.JSXFragment) {
+      if (node.type === AST_NODE_TYPES10.ArrowFunctionExpression) {
+        if (node.body.type === AST_NODE_TYPES10.JSXElement || node.body.type === AST_NODE_TYPES10.JSXFragment) {
           return true;
         }
-        if (node.body.type === AST_NODE_TYPES7.BlockStatement) {
+        if (node.body.type === AST_NODE_TYPES10.BlockStatement) {
           return hasJSXReturn(node.body);
         }
-      } else if (node.type === AST_NODE_TYPES7.FunctionExpression || node.type === AST_NODE_TYPES7.FunctionDeclaration) {
-        if (node.body && node.body.type === AST_NODE_TYPES7.BlockStatement) {
+      } else if (node.type === AST_NODE_TYPES10.FunctionExpression || node.type === AST_NODE_TYPES10.FunctionDeclaration) {
+        if (node.body && node.body.type === AST_NODE_TYPES10.BlockStatement) {
           return hasJSXReturn(node.body);
         }
       }
@@ -902,9 +1065,9 @@ var reactPropsDestructure = createRule12({
         return;
       }
       const param = node.params[0];
-      if (param.type === AST_NODE_TYPES7.ObjectPattern) {
-        const properties = param.properties.filter((prop) => prop.type === AST_NODE_TYPES7.Property).map((prop) => {
-          if (prop.key.type === AST_NODE_TYPES7.Identifier) {
+      if (param.type === AST_NODE_TYPES10.ObjectPattern) {
+        const properties = param.properties.filter((prop) => prop.type === AST_NODE_TYPES10.Property).map((prop) => {
+          if (prop.key.type === AST_NODE_TYPES10.Identifier) {
             return prop.key.name;
           }
           return null;
@@ -940,8 +1103,11 @@ var rules = {
   "file-kebab-case": file_kebab_case_default,
   "jsx-pascal-case": jsx_pascal_case_default,
   "md-filename-case-restriction": md_filename_case_restriction_default,
+  "no-complex-inline-return": no_complex_inline_return_default,
   "no-emoji": no_emoji_default,
+  "no-env-fallback": no_env_fallback_default,
   "no-explicit-return-type": no_explicit_return_type_default,
+  "no-logic-in-params": no_logic_in_params_default,
   "prefer-destructuring-params": prefer_destructuring_params_default,
   "prefer-import-type": prefer_import_type_default,
   "prefer-interface-over-inline-types": prefer_interface_over_inline_types_default,
@@ -961,7 +1127,10 @@ var baseRules = {
   "nextfriday/no-explicit-return-type": "warn",
   "nextfriday/prefer-import-type": "warn",
   "nextfriday/prefer-named-param-types": "warn",
-  "nextfriday/prefer-react-import-types": "warn"
+  "nextfriday/prefer-react-import-types": "warn",
+  "nextfriday/no-complex-inline-return": "warn",
+  "nextfriday/no-logic-in-params": "warn",
+  "nextfriday/no-env-fallback": "warn"
 };
 var baseRecommendedRules = {
   "nextfriday/no-emoji": "error",
@@ -971,7 +1140,10 @@ var baseRecommendedRules = {
   "nextfriday/no-explicit-return-type": "error",
   "nextfriday/prefer-import-type": "error",
   "nextfriday/prefer-named-param-types": "error",
-  "nextfriday/prefer-react-import-types": "error"
+  "nextfriday/prefer-react-import-types": "error",
+  "nextfriday/no-complex-inline-return": "error",
+  "nextfriday/no-logic-in-params": "error",
+  "nextfriday/no-env-fallback": "error"
 };
 var jsxRules = {
   "nextfriday/jsx-pascal-case": "warn",