eslint-plugin-nextfriday 1.21.0 → 1.22.0

package/CHANGELOG.md

@@ -1,5 +1,11 @@
 # eslint-plugin-nextfriday
 
+## 1.22.0
+
+### Minor Changes
+
+- [#92](https://github.com/next-friday/eslint-plugin-nextfriday/pull/92) [`432b4b4`](https://github.com/next-friday/eslint-plugin-nextfriday/commit/432b4b49cabc0d6ea9289441b13e7442d328614f) Thanks [@joetakara](https://github.com/joetakara)! - Rework enforce-service-naming rule to ban misleading prefixes (set, delete, do, handle) instead of forcing fetch prefix. Allow single-property inline nested objects in no-inline-nested-object rule. Fix documentation inconsistencies across README, rule docs, and configuration presets. Update dependencies to resolve security vulnerabilities.
+
 ## 1.21.0
 
 ### Minor Changes

package/README.md

@@ -78,12 +78,14 @@ export default [
       "nextfriday/no-single-char-variables": "error",
       "nextfriday/no-lazy-identifiers": "error",
       "nextfriday/boolean-naming-prefix": "error",
+      "nextfriday/enforce-camel-case": "error",
       "nextfriday/enforce-constant-case": "error",
+      "nextfriday/enforce-property-case": "error",
+      "nextfriday/no-misleading-constant-case": "error",
 
       // File Naming
       "nextfriday/file-kebab-case": "error",
       "nextfriday/jsx-pascal-case": "error",
-      "nextfriday/md-filename-case-restriction": "error",
 
       // Code Style
       "nextfriday/no-emoji": "error",
@@ -97,9 +99,11 @@ export default [
       "nextfriday/enforce-sorted-destructuring": "error",
       "nextfriday/no-env-fallback": "error",
       "nextfriday/no-inline-default-export": "error",
+      "nextfriday/no-direct-date": "error",
       "nextfriday/newline-after-multiline-block": "error",
       "nextfriday/newline-before-return": "error",
       "nextfriday/no-inline-nested-object": "error",
+      "nextfriday/no-inline-return-properties": "error",
       "nextfriday/prefer-async-await": "error",
       "nextfriday/enforce-curly-newline": "error",
       "nextfriday/no-nested-ternary": "error",
@@ -162,11 +166,10 @@ export default [
 
 ### File Naming Rules
 
-| Rule                                                                       | Description                                          | Fixable |
-| -------------------------------------------------------------------------- | ---------------------------------------------------- | ------- |
-| [file-kebab-case](docs/rules/FILE_KEBAB_CASE.md)                           | Enforce kebab-case filenames for .ts and .js files   | ❌      |
-| [jsx-pascal-case](docs/rules/JSX_PASCAL_CASE.md)                           | Enforce PascalCase filenames for .jsx and .tsx files | ❌      |
-| [md-filename-case-restriction](docs/rules/MD_FILENAME_CASE_RESTRICTION.md) | Enforce SNAKE_CASE filenames for .md files           | ❌      |
+| Rule                                             | Description                                          | Fixable |
+| ------------------------------------------------ | ---------------------------------------------------- | ------- |
+| [file-kebab-case](docs/rules/FILE_KEBAB_CASE.md) | Enforce kebab-case filenames for .ts and .js files   | ❌      |
+| [jsx-pascal-case](docs/rules/JSX_PASCAL_CASE.md) | Enforce PascalCase filenames for .jsx and .tsx files | ❌      |
 
 ### Code Style Rules
 
@@ -246,26 +249,27 @@ export default [
 
 | Preset               | Severity | Base Rules | JSX Rules | Next.js Rules | Total Rules |
 | -------------------- | -------- | ---------- | --------- | ------------- | ----------- |
-| `base`               | warn     | 37         | 0         | 0             | 37          |
-| `base/recommended`   | error    | 37         | 0         | 0             | 37          |
-| `react`              | warn     | 37         | 15        | 0             | 52          |
-| `react/recommended`  | error    | 37         | 15        | 0             | 52          |
-| `nextjs`             | warn     | 37         | 15        | 1             | 53          |
-| `nextjs/recommended` | error    | 37         | 15        | 1             | 53          |
+| `base`               | warn     | 40         | 0         | 0             | 40          |
+| `base/recommended`   | error    | 40         | 0         | 0             | 40          |
+| `react`              | warn     | 40         | 15        | 0             | 55          |
+| `react/recommended`  | error    | 40         | 15        | 0             | 55          |
+| `nextjs`             | warn     | 40         | 15        | 1             | 56          |
+| `nextjs/recommended` | error    | 40         | 15        | 1             | 56          |
 
-### Base Configuration Rules (37 rules)
+### Base Configuration Rules (40 rules)
 
 Included in `base`, `base/recommended`, and all other presets:
 
 - `nextfriday/boolean-naming-prefix`
+- `nextfriday/enforce-camel-case`
 - `nextfriday/enforce-constant-case`
 - `nextfriday/enforce-curly-newline`
 - `nextfriday/enforce-hook-naming`
+- `nextfriday/enforce-property-case`
 - `nextfriday/enforce-service-naming`
 - `nextfriday/enforce-sorted-destructuring`
 - `nextfriday/enforce-type-declaration-order`
 - `nextfriday/file-kebab-case`
-- `nextfriday/md-filename-case-restriction`
 - `nextfriday/newline-after-multiline-block`
 - `nextfriday/newline-before-return`
 - `nextfriday/no-complex-inline-return`
@@ -274,8 +278,10 @@ Included in `base`, `base/recommended`, and all other presets:
 - `nextfriday/no-env-fallback`
 - `nextfriday/no-inline-default-export`
 - `nextfriday/no-inline-nested-object`
+- `nextfriday/no-inline-return-properties`
 - `nextfriday/no-lazy-identifiers`
 - `nextfriday/no-logic-in-params`
+- `nextfriday/no-misleading-constant-case`
 - `nextfriday/no-nested-interface-declaration`
 - `nextfriday/no-nested-ternary`
 - `nextfriday/no-relative-imports`
@@ -339,7 +345,7 @@ Additionally included in `nextjs`, `nextjs/recommended` only:
 
 ## Agent Skill
 
-This plugin ships with an [Agent Skill](https://github.com/anthropics/skills) that teaches AI coding assistants (Claude Code, Cursor, etc.) all 53 rules so they generate compliant code from the start.
+This plugin ships with an [Agent Skill](https://github.com/anthropics/skills) that teaches AI coding assistants (Claude Code, Cursor, etc.) all 56 rules so they generate compliant code from the start.
 
 ```bash
 npx skills add next-friday/eslint-plugin-nextfriday --skill eslint-plugin-nextfriday

package/docs/rules/ENFORCE_CURLY_NEWLINE.md

@@ -16,35 +16,29 @@ This rule manages curly braces for `IfStatement` based on visual layout (line br
 ### Incorrect
 
 ```ts
-// Single-line with braces (BAD)
 if (!data) {
   return [];
 }
 if (x > 0) {
   doSomething();
 }
+```
 
-// Multi-line without braces (BAD)
+```ts
 if (veryLongCondition && anotherCondition) return [];
-
-if (condition) doSomething();
 ```
 
 ### Correct
 
 ```ts
-// Single-line without braces (GOOD)
 if (!data) return [];
 if (x > 0) doSomething();
+```
 
-// Multi-line with braces (GOOD)
+```ts
 if (veryLongCondition && anotherCondition) {
   return [];
 }
-
-if (condition) {
-  doSomething();
-}
 ```
 
 ## Auto-Fix

package/docs/rules/ENFORCE_SERVICE_NAMING.md

@@ -1,48 +1,60 @@
 # enforce-service-naming
 
-Enforce `fetch` prefix for async functions in `*.service.ts` files instead of `get` or `load`.
+Ban misleading function name prefixes in `*.service.ts` files.
 
 ## Rule Details
 
-This rule ensures consistent naming conventions for service layer functions. In `*.service.ts` files, async data-fetching functions should use the `fetch` prefix to clearly indicate they perform network/API calls.
+This rule flags misleading prefixes on async exported functions in `*.service.ts` files. It does not force a specific prefix — developers choose based on intent.
 
 ### Why?
 
-- **Clarity**: `fetch` clearly indicates a network operation, while `get` is ambiguous (could be synchronous accessor)
-- **Consistency**: Standardizes naming across all service files
-- **Semantics**: `fetch` aligns with the Fetch API and implies async data retrieval
+Service functions represent API/network calls. Certain prefixes are misleading in this context:
+
+- `set` implies a local setter, not an API call
+- `delete` is a JS reserved word that may conflict
+- `do` is vague and conveys no intent
+- `handle` is typically for UI event handlers, not service operations
+
+### Banned Prefixes
+
+| Prefix   | Why banned                                | Suggested alternatives    |
+| -------- | ----------------------------------------- | ------------------------- |
+| `set`    | Implies local setter, not API call        | `update`, `save`, `patch` |
+| `delete` | JS reserved word, may conflict            | `remove`, `archive`       |
+| `do`     | Vague, no intent                          | `submit`, `process`       |
+| `handle` | Vague, typically for event handlers in UI | `create`, `verify`        |
 
 ## Examples
 
 ### Incorrect
 
 ```ts
-// article.service.ts
-export async function getArticles() {}
-export async function loadFaq() {}
-export async function getUserById() {}
-export const getUsers = async () => {};
+// profile.service.ts
+export async function setProfile(data: ProfileRequest) {}
+export async function deleteComment(id: string) {}
+export async function doLogin(credentials: LoginRequest) {}
+export async function handlePayment(data: PaymentRequest) {}
 ```
 
 ### Correct
 
 ```ts
-// article.service.ts
+// profile.service.ts
+export async function getArticles() {}
 export async function fetchArticles() {}
-export async function fetchFaqList() {}
-export async function fetchUserById() {}
-export const fetchUsers = async () => {};
+export async function searchArticles(query: string) {}
+export async function createOrder(data: OrderRequest) {}
+export async function updateProfile(id: string, data: ProfileRequest) {}
+export async function removeComment(id: string) {}
+export async function verifyEmail(token: string) {}
 
 // Non-async functions can use any prefix
-export function getArticleById(id: string) {}
+export function setLocalState(value: string) {}
 
-// Other prefixes are allowed
-export async function createUser() {}
-export async function updateArticle() {}
-export async function deleteComment() {}
+// Non-exported functions are not checked
+async function handleInternal() {}
 ```
 
 ## When Not To Use It
 
-- If your project uses different naming conventions for service functions
-- If you prefer `get`/`load` prefixes for data-fetching operations
+If your project does not follow a service layer pattern or has different naming conventions for service functions.

package/docs/rules/JSX_NO_TERNARY_NULL.md

@@ -39,4 +39,4 @@ If your team prefers explicit ternary expressions for conditional rendering, eve
 
 ## Related Rules
 
-- [no-nested-ternary](JSX_NO_TERNARY_NULL.md)
+- [no-nested-ternary](NO_NESTED_TERNARY.md)

package/docs/rules/NO_INLINE_NESTED_OBJECT.md

@@ -1,10 +1,10 @@
 # no-inline-nested-object
 
-Require nested objects and arrays to span multiple lines.
+Require nested objects and arrays with multiple properties to span multiple lines.
 
 ## Rule Details
 
-This rule enforces that when an object property's value is another object or array, it should span multiple lines rather than being written inline. This improves readability and makes diffs cleaner when properties are added or removed.
+This rule enforces that when an object property's value is another object or array with more than one element, it should span multiple lines rather than being written inline. Single-property nested objects are allowed inline. This improves readability and makes diffs cleaner when properties are added or removed.
 
 ## Examples
 
@@ -25,6 +25,12 @@ const routes = {
 
 ### Correct
 
+```ts
+const config = {
+  database: { host: "localhost" },
+};
+```
+
 ```ts
 const config = {
   database: {
@@ -65,8 +71,8 @@ const initialState = {
 
 ## When Not To Use It
 
-If you prefer compact inline nested objects for simple cases, or if your team has different formatting preferences.
+If you prefer compact inline nested objects for all cases, or if your team has different formatting preferences.
 
 ## Fixable
 
-This rule is auto-fixable. Running ESLint with the `--fix` flag will automatically expand inline nested objects and arrays to multiple lines.
+This rule is auto-fixable. Running ESLint with the `--fix` flag will automatically expand inline nested objects and arrays with multiple properties to multiple lines.

package/docs/rules/PREFER_INLINE_LITERAL_UNION.md

@@ -10,17 +10,17 @@ This rule detects type aliases that are unions of only literal values (strings,
 
 ### Why?
 
-When you hover over a prop in your IDE, a type alias shows the alias name (e.g., `ArticleFaqCategoryId`) instead of the actual values (`"articles" | "dharma" | "faq"`). Inlining literal unions gives immediate visibility into the allowed values without needing to jump to the type definition.
+When you hover over a prop in your IDE, a type alias shows the alias name (e.g., `Theme`) instead of the actual values (`"light" | "dark" | "system"`). Inlining literal unions gives immediate visibility into the allowed values without needing to jump to the type definition.
 
 ## Examples
 
 ### Incorrect
 
 ```ts
-type ArticleFaqCategoryId = "articles" | "dharma" | "faq";
+type Theme = "light" | "dark" | "system";
 
-interface ArticleFaqCategoryFilterProps {
-  activeCategoryId?: ArticleFaqCategoryId;
+interface SettingsProps {
+  theme?: Theme;
 }
 ```
 
@@ -43,8 +43,8 @@ interface Props {
 ### Correct
 
 ```ts
-interface ArticleFaqCategoryFilterProps {
-  activeCategoryId?: "articles" | "dharma" | "faq";
+interface SettingsProps {
+  theme?: "light" | "dark" | "system";
 }
 ```