eslint-plugin-new-with-error 2.0.0 → 3.0.0

package/CHANGELOG

@@ -1,3 +1,15 @@
+# [3.0.0](https://github.com/Trott/eslint-plugin-new-with-error/compare/v2.0.0...v3.0.0) (2021-11-18)
+
+
+### chore
+
+* test all versions of ESLint that we support ([#24](https://github.com/Trott/eslint-plugin-new-with-error/issues/24)) ([221a5fc](https://github.com/Trott/eslint-plugin-new-with-error/commit/221a5fc3ff799b54c7fb5ff3c6d87856e190605d))
+
+
+### BREAKING CHANGES
+
+* drop support for Node.js < 12.x.
+
 # Changelog
 
 ## 2.0.0

package/index.js

@@ -1,4 +1,4 @@
-'use strict';
+'use strict'
 
 module.exports = {
   rules: {
@@ -7,4 +7,4 @@ module.exports = {
   rulesConfig: {
     'new-with-error': 1
   }
-};
+}

package/lib/rules/new-with-error.js

@@ -4,29 +4,27 @@
  * @copyright Rich Trott. All rights reserved.
  * See LICENSE file in root directory for full license.
  */
-"use strict";
+'use strict'
 
-//------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------
 // Rule Definition
-//------------------------------------------------------------------------------
+// ------------------------------------------------------------------------------
 
-module.exports = function(context) {
+module.exports = function (context) {
+  const defaultErrorsList = ['Error', 'EvalError', 'RangeError', 'ReferenceError', 'SyntaxError', 'TypeError', 'URIError']
 
-    var defaultErrorsList = ['Error', 'EvalError', 'RangeError', 'ReferenceError', 'SyntaxError', 'TypeError', 'URIError'];
+  const errorList = context.options.length !== 0 ? context.options : defaultErrorsList
 
-    var errorList = context.options.length !== 0 ? context.options : defaultErrorsList;
+  // --------------------------------------------------------------------------
+  // Public
+  // --------------------------------------------------------------------------
 
-    //--------------------------------------------------------------------------
-    // Public
-    //--------------------------------------------------------------------------
+  return {
 
-    return {
-
-        'ThrowStatement': function(node) {
-            if (node.argument.type === 'CallExpression' && errorList.indexOf(node.argument.callee.name) !== -1) {
-                context.report(node, 'Use new keyword when throwing.');
-            }
-        }
-    };
-
-};
+    ThrowStatement: function (node) {
+      if (node.argument.type === 'CallExpression' && errorList.indexOf(node.argument.callee.name) !== -1) {
+        context.report(node, 'Use new keyword when throwing.')
+      }
+    }
+  }
+}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "eslint-plugin-new-with-error",
-  "version": "2.0.0",
+  "version": "3.0.0",
   "description": "Require `throw new Error()` and not `throw Error()`",
   "repository": "https://github.com/Trott/eslint-plugin-new-with-error",
   "directories": {
@@ -8,7 +8,9 @@
     "test": "tests"
   },
   "scripts": {
-    "test": "node tests/lib/rules/new-with-error.js"
+    "pretest": "standard",
+    "test": "for eslintVersion in 2.13.1 3 4 5 6 7 8; do npm install --no-save eslint@${eslintVersion} && c8 --check-coverage --branches 100 --functions 100 --lines 100 node tests/lib/rules/new-with-error.js || exit 1; done",
+    "posttest": "npm ci"
   },
   "keywords": [
     "eslint",
@@ -20,7 +22,37 @@
     "eslint": ">=2.13.1"
   },
   "devDependencies": {
-    "eslint": "^5.0.1"
+    "@semantic-release/changelog": "^6.0.1",
+    "@semantic-release/git": "^10.0.1",
+    "c8": "^7.10.0",
+    "eslint": "^8.2.0",
+    "semantic-release": "^18.0.0",
+    "standard": "^16.0.4"
   },
-  "dependencies": {}
+  "release": {
+    "branches": [
+      "main"
+    ],
+    "plugins": [
+      "@semantic-release/commit-analyzer",
+      "@semantic-release/release-notes-generator",
+      [
+        "@semantic-release/changelog",
+        {
+          "changelogFile": "CHANGELOG"
+        }
+      ],
+      "@semantic-release/npm",
+      [
+        "@semantic-release/git",
+        {
+          "assets": [
+            "CHANGELOG",
+            "package.json"
+          ],
+          "message": "chore(release): ${nextRelease.version} [skip ci]\n\n${nextRelease.notes}"
+        }
+      ]
+    ]
+  }
 }

package/docs/rules/new-with-error.md

@@ -1,36 +0,0 @@
-# Require `throw new Error()` rather than `throw Error()` (new-with-error)
-
-This is a style requirement of Node.js core code. Perhaps you will find it useful too.
-
-
-## Rule Details
-
-This rule aims to make sure that there is consistency with how Errors are thrown.
-
-The following patterns are considered warnings:
-
-```js
-
-throw Error('foo');
-
-```
-
-The following patterns are not warnings:
-
-```js
-
-throw new Error('foo');
-
-```
-
-### Options
-
-You can include an array of Error types you want checked (SyntaxError, ReferenceError, etc.). Or don't provide it and you'll get checks on Error, EvalError, RangeError, ReferenceError, SyntaxError, TypeError, and URIError.
-
-## When Not To Use It
-
-If you don't care if there's a mix of `throw Error()` and `throw new Error()` in your code, then this is not the rule for you.
-
-## Further Reading
-
-* https://github.com/nodejs/node/pull/3714

package/tests/lib/rules/new-with-error.js

@@ -1,51 +0,0 @@
-/**
- * @fileoverview Require `throw new Error()` rather than `throw Error()`
- * @author Rich Trott
- * @copyright 2015 Rich Trott. All rights reserved.
- * See LICENSE file in root directory for full license.
- */
-"use strict";
-
-//------------------------------------------------------------------------------
-// Requirements
-//------------------------------------------------------------------------------
-
-var rule = require("../../../lib/rules/new-with-error"),
-
-    RuleTester = require("eslint").RuleTester;
-
-
-//------------------------------------------------------------------------------
-// Tests
-//------------------------------------------------------------------------------
-
-var ruleTester = new RuleTester();
-ruleTester.run("new-with-error", rule, {
-
-    valid: [
-        {
-            code: "throw new Error();"
-        },
-        {
-            code: "throw SyntaxError();",
-            options: ['Error']
-        }
-    ],
-
-    invalid: [
-        {
-            code: "throw Error();",
-            errors: [{
-                message: "Use new keyword when throwing.",
-                type: "ThrowStatement"
-            }]
-        },
-        {
-            code: "throw SyntaxError();",
-            errors: [{
-                message: "Use new keyword when throwing.",
-                type: "ThrowStatement"
-            }]
-        }
-    ]
-});