eslint-plugin-n 17.17.0 → 17.18.0

package/lib/rules/no-deprecated-api.js

@@ -16,6 +16,9 @@ const getSemverRange = require("../util/get-semver-range")
 const extendTrackmapWithNodePrefix = require("../util/extend-trackmap-with-node-prefix")
 const unprefixNodeColon = require("../util/unprefix-node-colon")
 const { getScope } = require("../util/eslint-compat")
+const {
+    iterateProcessGetBuiltinModuleReferences,
+} = require("../util/iterate-process-get-builtin-module-references")
 
 /** @typedef {import('../unsupported-features/types.js').DeprecatedInfo} DeprecatedInfo */
 /**
@@ -842,6 +845,10 @@ module.exports = {
                 }
                 for (const report of [
                     ...tracker.iterateCjsReferences(modules),
+                    ...iterateProcessGetBuiltinModuleReferences(
+                        tracker,
+                        modules
+                    ),
                     ...tracker.iterateEsmReferences(modules),
                 ]) {
                     const { node, path, type, info } = report

package/lib/rules/no-unpublished-import.js

@@ -9,6 +9,7 @@ const getAllowModules = require("../util/get-allow-modules")
 const getConvertPath = require("../util/get-convert-path")
 const getResolvePaths = require("../util/get-resolve-paths")
 const getResolverConfig = require("../util/get-resolver-config")
+const getTryExtensions = require("../util/get-try-extensions")
 const visitImport = require("../util/visit-import")
 
 /**
@@ -18,6 +19,7 @@ const visitImport = require("../util/visit-import")
  *     convertPath?: import('../util/get-convert-path').ConvertPath;
  *     resolvePaths?: import('../util/get-resolve-paths').ResolvePaths;
  *     resolverConfig?: import('../util/get-resolver-config').ResolverConfig;
+ *     tryExtensions?: import('../util/get-try-extensions').TryExtensions;
  *     ignoreTypeImport?: boolean;
  *     ignorePrivate?: boolean;
  *   }?
@@ -42,6 +44,7 @@ module.exports = {
                     convertPath: getConvertPath.schema,
                     resolvePaths: getResolvePaths.schema,
                     resolverConfig: getResolverConfig.schema,
+                    tryExtensions: getTryExtensions.schema,
                     ignoreTypeImport: { type: "boolean", default: false },
                     ignorePrivate: { type: "boolean", default: true },
                 },

package/lib/rules/prefer-node-protocol.js

@@ -4,7 +4,10 @@
  */
 "use strict"
 
-const { getStringIfConstant } = require("@eslint-community/eslint-utils")
+const {
+    getStringIfConstant,
+    getPropertyName,
+} = require("@eslint-community/eslint-utils")
 
 const { Range } = require("semver")
 
@@ -15,6 +18,10 @@ const {
     NodeBuiltinModules,
 } = require("../unsupported-features/node-builtins.js")
 
+/**
+ * @typedef { 'import' | 'require' | 'getBuiltinModule' } ModuleStyle
+ */
+
 /**
  * @param {string} name The name of the node module
  * @returns {boolean}
@@ -38,10 +45,15 @@ function isStringLiteral(node) {
 
 /**
  * @param {import('eslint').Rule.RuleContext} context
- * @param {import('../util/import-target.js').ModuleStyle} moduleStyle
+ * @param {ModuleStyle} moduleStyle
  * @returns {boolean}
  */
 function isEnablingThisRule(context, moduleStyle) {
+    // The availability of `process.getBuiltinModule()` means that `node:` protocol is supported.
+    if (moduleStyle === "getBuiltinModule") {
+        return true
+    }
+
     const version = getConfiguredNodeVersion(context)
 
     // Only check Node.js version because this rule is meaningless if configured Node.js version doesn't match semver range.
@@ -81,7 +93,7 @@ function isValidRequireArgument(node) {
 /**
  * @param {import('estree').Node | null | undefined} node
  * @param {import('eslint').Rule.RuleContext} context
- * @param {import('../util/import-target.js').ModuleStyle} moduleStyle
+ * @param {ModuleStyle} moduleStyle
  */
 function validate(node, context, moduleStyle) {
     if (node == null) {
@@ -96,7 +108,10 @@ function validate(node, context, moduleStyle) {
         return
     }
 
-    if (moduleStyle === "require" && !isValidRequireArgument(node)) {
+    if (
+        (moduleStyle === "require" || moduleStyle === "getBuiltinModule") &&
+        !isValidRequireArgument(node)
+    ) {
         return
     }
 
@@ -126,6 +141,25 @@ function validate(node, context, moduleStyle) {
     })
 }
 
+/**
+ * @param {import('estree').Expression | import('estree').Super} node
+ */
+function isProcess(node) {
+    if (node.type === "Identifier" && node.name === "process") {
+        return true
+    }
+    if (node.type === "MemberExpression") {
+        if (getPropertyName(node) !== "process") {
+            return false
+        }
+        return (
+            node.object.type === "Identifier" &&
+            node.object.name === "globalThis"
+        )
+    }
+    return false
+}
+
 /** @type {import('./rule-module').RuleModule} */
 module.exports = {
     meta: {
@@ -158,15 +192,25 @@ module.exports = {
                 }
 
                 if (
-                    node.optional ||
-                    node.arguments.length !== 1 ||
-                    node.callee.type !== "Identifier" ||
-                    node.callee.name !== "require"
+                    !node.optional &&
+                    node.arguments.length === 1 &&
+                    node.callee.type === "Identifier" &&
+                    node.callee.name === "require"
                 ) {
-                    return
+                    return validate(node.arguments[0], context, "require")
+                }
+                if (
+                    node.arguments.length >= 1 &&
+                    node.callee.type === "MemberExpression" &&
+                    isProcess(node.callee.object) &&
+                    getPropertyName(node.callee) === "getBuiltinModule"
+                ) {
+                    return validate(
+                        node.arguments[0],
+                        context,
+                        "getBuiltinModule"
+                    )
                 }
-
-                return validate(node.arguments[0], context, "require")
             },
 
             ExportAllDeclaration(node) {

package/lib/rules/prefer-promises/dns.js

@@ -10,6 +10,9 @@ const {
     ReferenceTracker,
 } = require("@eslint-community/eslint-utils")
 const { getScope } = require("../../util/eslint-compat")
+const {
+    iterateProcessGetBuiltinModuleReferences,
+} = require("../../util/iterate-process-get-builtin-module-references")
 
 /** @type {import('@eslint-community/eslint-utils').TraceMap<boolean>} */
 const dns = {
@@ -63,6 +66,10 @@ module.exports = {
                 const tracker = new ReferenceTracker(scope, { mode: "legacy" })
                 const references = [
                     ...tracker.iterateCjsReferences(traceMap),
+                    ...iterateProcessGetBuiltinModuleReferences(
+                        tracker,
+                        traceMap
+                    ),
                     ...tracker.iterateEsmReferences(traceMap),
                 ]
 

package/lib/rules/prefer-promises/fs.js

@@ -6,6 +6,9 @@
 
 const { CALL, ReferenceTracker } = require("@eslint-community/eslint-utils")
 const { getScope } = require("../../util/eslint-compat")
+const {
+    iterateProcessGetBuiltinModuleReferences,
+} = require("../../util/iterate-process-get-builtin-module-references")
 
 /** @type {import('@eslint-community/eslint-utils').TraceMap<boolean>} */
 const traceMap = {
@@ -61,6 +64,10 @@ module.exports = {
                 const tracker = new ReferenceTracker(scope, { mode: "legacy" })
                 const references = [
                     ...tracker.iterateCjsReferences(traceMap),
+                    ...iterateProcessGetBuiltinModuleReferences(
+                        tracker,
+                        traceMap
+                    ),
                     ...tracker.iterateEsmReferences(traceMap),
                 ]
 

package/lib/unsupported-features/node-builtins-modules/https.js

@@ -5,7 +5,7 @@ const { READ } = require("@eslint-community/eslint-utils")
 /**
  * @satisfies {import('../types.js').SupportVersionTraceMap}
  */
-const http = {
+const https = {
     globalAgent: { [READ]: { supported: ["0.5.9"] } },
     createServer: { [READ]: { supported: ["0.3.4"] } },
     get: { [READ]: { supported: ["0.3.6"] } },
@@ -18,12 +18,12 @@ const http = {
  * @satisfies {import('../types.js').SupportVersionTraceMap}
  */
 module.exports = {
-    http: {
+    https: {
         [READ]: { supported: ["0.3.4"] },
-        ...http,
+        ...https,
     },
-    "node:http": {
+    "node:https": {
         [READ]: { supported: ["14.13.1", "12.20.0"] },
-        ...http,
+        ...https,
     },
 }

package/lib/unsupported-features/node-builtins.js

@@ -37,6 +37,7 @@ const NodeBuiltinModules = {
     ...require("./node-builtins-modules/sea.js"),
     ...require("./node-builtins-modules/stream.js"),
     ...require("./node-builtins-modules/string_decoder.js"),
+    ...require("./node-builtins-modules/sqlite.js"),
     ...require("./node-builtins-modules/test.js"),
     ...require("./node-builtins-modules/timers.js"),
     ...require("./node-builtins-modules/tls.js"),

package/lib/util/check-prefer-global.js

@@ -6,6 +6,9 @@
 
 const { ReferenceTracker } = require("@eslint-community/eslint-utils")
 const { getScope } = require("../util/eslint-compat")
+const {
+    iterateProcessGetBuiltinModuleReferences,
+} = require("../util/iterate-process-get-builtin-module-references")
 /**
  * @typedef TraceMap
  * @property {import('@eslint-community/eslint-utils').TraceMap<boolean>} globals
@@ -43,6 +46,10 @@ class Verifier {
 
         for (const { node } of [
             ...tracker.iterateCjsReferences(traceMap.modules),
+            ...iterateProcessGetBuiltinModuleReferences(
+                tracker,
+                traceMap.modules
+            ),
             ...tracker.iterateEsmReferences(traceMap.modules),
         ]) {
             context.report({ node, messageId: "preferGlobal" })

package/lib/util/check-unsupported-builtins.js

@@ -11,6 +11,9 @@ const getSemverRange = require("./get-semver-range")
 const unprefixNodeColon = require("./unprefix-node-colon")
 const semverRangeSubset = require("semver/ranges/subset")
 const { getScope } = require("../util/eslint-compat")
+const {
+    iterateProcessGetBuiltinModuleReferences,
+} = require("./iterate-process-get-builtin-module-references")
 
 /**
  * Parses the options.
@@ -158,6 +161,10 @@ module.exports.checkUnsupportedBuiltins = function checkUnsupportedBuiltins(
     const tracker = new ReferenceTracker(scope, { mode: "legacy" })
     const references = [
         ...tracker.iterateCjsReferences(traceMap.modules ?? {}),
+        ...iterateProcessGetBuiltinModuleReferences(
+            tracker,
+            traceMap.modules ?? {}
+        ),
         ...tracker.iterateEsmReferences(traceMap.modules ?? {}),
         ...tracker.iterateGlobalReferences(traceMap.globals ?? {}),
     ]

package/lib/util/iterate-process-get-builtin-module-references.js

@@ -0,0 +1,56 @@
+"use strict"
+const {
+    CALL,
+    getStringIfConstant,
+    READ,
+} = require("@eslint-community/eslint-utils")
+const processGetBuiltinModuleCall = {
+    process: {
+        getBuiltinModule: {
+            [CALL]: true,
+        },
+    },
+}
+/**
+ * Iterate the references of process.getBuiltinModule() modules.
+ * @template Info
+ * @param {import("@eslint-community/eslint-utils").ReferenceTracker} tracker The reference tracker.
+ * @param {import("@eslint-community/eslint-utils").TraceMap<Info>} traceMap The trace map.
+ * @returns {IterableIterator<import("@eslint-community/eslint-utils").Reference<Info>>} The iterator.
+ */
+function* iterateProcessGetBuiltinModuleReferences(tracker, traceMap) {
+    for (const { node } of tracker.iterateGlobalReferences(
+        processGetBuiltinModuleCall
+    )) {
+        if (node.type !== "CallExpression") continue
+        const key = node.arguments[0] && getStringIfConstant(node.arguments[0])
+        if (key == null) {
+            continue
+        }
+        const nextTraceMap = Object.hasOwn(traceMap, key) && traceMap[key]
+        if (!nextTraceMap) {
+            continue
+        }
+
+        if (nextTraceMap[READ]) {
+            yield {
+                node,
+                path: [key],
+                type: READ,
+                info: nextTraceMap[READ],
+            }
+        }
+
+        for (const ref of tracker.iteratePropertyReferences(
+            node,
+            nextTraceMap
+        )) {
+            yield {
+                ...ref,
+                path: [key, ...ref.path],
+            }
+        }
+    }
+}
+
+module.exports = { iterateProcessGetBuiltinModuleReferences }

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "eslint-plugin-n",
-    "version": "17.17.0",
+    "version": "17.18.0",
     "description": "Additional ESLint's rules for Node.js",
     "engines": {
         "node": "^18.18.0 || ^20.9.0 || >=21.1.0"