eslint-plugin-n 17.13.2 → 17.15.0

package/lib/rules/no-extraneous-import.js

@@ -8,6 +8,7 @@ const { checkExtraneous, messages } = require("../util/check-extraneous")
 const getAllowModules = require("../util/get-allow-modules")
 const getConvertPath = require("../util/get-convert-path")
 const getResolvePaths = require("../util/get-resolve-paths")
+const getResolverConfig = require("../util/get-resolver-config")
 const visitImport = require("../util/visit-import")
 
 /** @type {import('eslint').Rule.RuleModule} */
@@ -28,6 +29,7 @@ module.exports = {
                     allowModules: getAllowModules.schema,
                     convertPath: getConvertPath.schema,
                     resolvePaths: getResolvePaths.schema,
+                    resolverConfig: getResolverConfig.schema,
                 },
                 additionalProperties: false,
             },

package/lib/rules/no-extraneous-require.js

@@ -8,6 +8,7 @@ const { checkExtraneous, messages } = require("../util/check-extraneous")
 const getAllowModules = require("../util/get-allow-modules")
 const getConvertPath = require("../util/get-convert-path")
 const getResolvePaths = require("../util/get-resolve-paths")
+const getResolverConfig = require("../util/get-resolver-config")
 const getTryExtensions = require("../util/get-try-extensions")
 const visitRequire = require("../util/visit-require")
 
@@ -29,6 +30,7 @@ module.exports = {
                     allowModules: getAllowModules.schema,
                     convertPath: getConvertPath.schema,
                     resolvePaths: getResolvePaths.schema,
+                    resolverConfig: getResolverConfig.schema,
                     tryExtensions: getTryExtensions.schema,
                 },
                 additionalProperties: false,

package/lib/rules/no-missing-import.js

@@ -7,6 +7,7 @@
 const { checkExistence, messages } = require("../util/check-existence")
 const getAllowModules = require("../util/get-allow-modules")
 const getResolvePaths = require("../util/get-resolve-paths")
+const getResolverConfig = require("../util/get-resolver-config")
 const getTryExtensions = require("../util/get-try-extensions")
 const getTSConfig = require("../util/get-tsconfig")
 const getTypescriptExtensionMap = require("../util/get-typescript-extension-map")
@@ -29,6 +30,7 @@ module.exports = {
                 properties: {
                     allowModules: getAllowModules.schema,
                     resolvePaths: getResolvePaths.schema,
+                    resolverConfig: getResolverConfig.schema,
                     tryExtensions: getTryExtensions.schema,
                     ignoreTypeImport: { type: "boolean", default: false },
                     tsconfigPath: getTSConfig.schema,

package/lib/rules/no-missing-require.js

@@ -7,6 +7,7 @@
 const { checkExistence, messages } = require("../util/check-existence")
 const getAllowModules = require("../util/get-allow-modules")
 const getResolvePaths = require("../util/get-resolve-paths")
+const getResolverConfig = require("../util/get-resolver-config")
 const getTSConfig = require("../util/get-tsconfig")
 const getTryExtensions = require("../util/get-try-extensions")
 const getTypescriptExtensionMap = require("../util/get-typescript-extension-map")
@@ -30,6 +31,7 @@ module.exports = {
                     allowModules: getAllowModules.schema,
                     tryExtensions: getTryExtensions.schema,
                     resolvePaths: getResolvePaths.schema,
+                    resolverConfig: getResolverConfig.schema,
                     typescriptExtensionMap: getTypescriptExtensionMap.schema,
                     tsconfigPath: getTSConfig.schema,
                 },

package/lib/rules/no-sync.js

@@ -4,23 +4,13 @@
  */
 "use strict"
 
-const allowedAtRootLevelSelector = [
+const selectors = [
     // fs.readFileSync()
-    ":function MemberExpression > Identifier[name=/Sync$/]",
     // readFileSync.call(null, 'path')
-    ":function MemberExpression > Identifier[name=/Sync$/]",
+    "CallExpression > MemberExpression.callee Identifier[name=/Sync$/]",
     // readFileSync()
-    ":function :not(MemberExpression) > Identifier[name=/Sync$/]",
-].join(",")
-
-const disallowedAtRootLevelSelector = [
-    // fs.readFileSync()
-    "MemberExpression > Identifier[name=/Sync$/]",
-    // readFileSync.call(null, 'path')
-    "MemberExpression > Identifier[name=/Sync$/]",
-    // readFileSync()
-    ":not(MemberExpression) > Identifier[name=/Sync$/]",
-].join(",")
+    "CallExpression > Identifier[name=/Sync$/]",
+]
 
 /** @type {import('eslint').Rule.RuleModule} */
 module.exports = {
@@ -40,6 +30,11 @@ module.exports = {
                         type: "boolean",
                         default: false,
                     },
+                    ignores: {
+                        type: "array",
+                        items: { type: "string" },
+                        default: [],
+                    },
                 },
                 additionalProperties: false,
             },
@@ -50,17 +45,22 @@ module.exports = {
     },
 
     create(context) {
-        const selector = context.options[0]?.allowAtRootLevel
-            ? allowedAtRootLevelSelector
-            : disallowedAtRootLevelSelector
+        const options = context.options[0] ?? {}
+        const ignores = options.ignores ?? []
 
+        const selector = options.allowAtRootLevel
+            ? selectors.map(selector => `:function ${selector}`)
+            : selectors
         return {
             /**
-             * [node description]
              * @param {import('estree').Identifier & {parent: import('estree').Node}} node
              * @returns {void}
              */
-            [selector](node) {
+            [selector.join(",")](node) {
+                if (ignores.includes(node.name)) {
+                    return
+                }
+
                 context.report({
                     node: node.parent,
                     messageId: "noSync",

package/lib/rules/no-unpublished-import.js

@@ -8,6 +8,7 @@ const { checkPublish, messages } = require("../util/check-publish")
 const getAllowModules = require("../util/get-allow-modules")
 const getConvertPath = require("../util/get-convert-path")
 const getResolvePaths = require("../util/get-resolve-paths")
+const getResolverConfig = require("../util/get-resolver-config")
 const visitImport = require("../util/visit-import")
 
 /** @type {import('eslint').Rule.RuleModule} */
@@ -28,6 +29,7 @@ module.exports = {
                     allowModules: getAllowModules.schema,
                     convertPath: getConvertPath.schema,
                     resolvePaths: getResolvePaths.schema,
+                    resolverConfig: getResolverConfig.schema,
                     ignoreTypeImport: { type: "boolean", default: false },
                     ignorePrivate: { type: "boolean", default: true },
                 },

package/lib/rules/no-unpublished-require.js

@@ -8,6 +8,7 @@ const { checkPublish, messages } = require("../util/check-publish")
 const getAllowModules = require("../util/get-allow-modules")
 const getConvertPath = require("../util/get-convert-path")
 const getResolvePaths = require("../util/get-resolve-paths")
+const getResolverConfig = require("../util/get-resolver-config")
 const getTryExtensions = require("../util/get-try-extensions")
 const visitRequire = require("../util/visit-require")
 
@@ -29,6 +30,7 @@ module.exports = {
                     allowModules: getAllowModules.schema,
                     convertPath: getConvertPath.schema,
                     resolvePaths: getResolvePaths.schema,
+                    resolverConfig: getResolverConfig.schema,
                     tryExtensions: getTryExtensions.schema,
                     ignorePrivate: { type: "boolean", default: true },
                 },

package/lib/unsupported-features/node-builtins-modules/module.js

@@ -20,10 +20,12 @@ const Module = {
         },
     },
     enableCompileCache: { [READ]: { experimental: ["22.8.0"] } },
+    findPackageJSON: { [READ]: { experimental: ["23.2.0"] } },
     flushCompileCache: { [READ]: { experimental: ["23.0.0", "22.10.0"] } },
     getCompileCacheDir: { [READ]: { experimental: ["22.8.0"] } },
     isBuiltin: { [READ]: { supported: ["18.6.0", "16.17.0"] } },
     register: { [READ]: { experimental: ["20.6.0"] } },
+    stripTypeScriptTypes: { [READ]: { experimental: ["23.2.0"] } },
     syncBuiltinESMExports: { [READ]: { supported: ["12.12.0"] } },
     findSourceMap: { [READ]: { supported: ["13.7.0", "12.17.0"] } },
     SourceMap: { [READ]: { supported: ["13.7.0", "12.17.0"] } },

package/lib/unsupported-features/node-builtins-modules/process.js

@@ -55,6 +55,7 @@ const process = {
             experimental: ["11.8.0"],
             supported: ["13.12.0", "12.17.0"],
         },
+        excludeEnv: { [READ]: { supported: ["23.3.0"] } },
     },
     sourceMapsEnabled: { [READ]: { experimental: ["20.7.0"] } },
     stdin: {

package/lib/unsupported-features/node-builtins-modules/sqlite.js

@@ -8,6 +8,9 @@ const { READ } = require("@eslint-community/eslint-utils")
 const sqlite = {
     DatabaseSync: { [READ]: { supported: ["22.5.0"] } },
     StatementSync: { [READ]: { supported: ["22.5.0"] } },
+    SQLITE_CHANGESET_OMIT: { [READ]: { supported: ["22.12.0"] } },
+    SQLITE_CHANGESET_REPLACE: { [READ]: { supported: ["22.12.0"] } },
+    SQLITE_CHANGESET_ABORT: { [READ]: { supported: ["22.12.0"] } },
 }
 
 /**

package/lib/unsupported-features/node-builtins-modules/util.js

@@ -94,10 +94,13 @@ const util = {
     deprecate: { [READ]: { supported: ["0.8.0"] } },
     format: { [READ]: { supported: ["0.5.3"] } },
     formatWithOptions: { [READ]: { supported: ["10.0.0"] } },
-    getCallSite: { [READ]: { experimental: ["22.9.0"] } },
+    getCallSite: {
+        [READ]: { deprecated: ["23.3.0", "22.12.0"], experimental: ["22.9.0"] },
+    },
+    getCallSites: { [READ]: { experimental: ["23.3.0", "22.12.0"] } },
     getSystemErrorName: { [READ]: { supported: ["9.7.0", "8.12.0"] } },
     getSystemErrorMap: { [READ]: { supported: ["16.0.0", "14.17.0"] } },
-    getSystemErrorMessage: { [READ]: { supported: ["23.1.0"] } },
+    getSystemErrorMessage: { [READ]: { supported: ["23.1.0", "22.12.0"] } },
     inherits: { [READ]: { supported: ["0.3.0"] } },
     inspect: {
         [READ]: { supported: ["0.3.0"] },

package/lib/util/enumerate-property-names.js

@@ -15,15 +15,16 @@ const unprefixNodeColon = require("./unprefix-node-colon")
  * Enumerate property names of a given object recursively.
  * @param {TraceMap} traceMap The map for APIs to enumerate.
  * @param {string[]} [path] The path to the current map.
- * @param {WeakSet<TraceMap>} [recursionSet] A WeakSet used to block recursion (eg Module, Module.Module, Module.Module.Module)
+ * @param {{ [key: string]: WeakSet<TraceMap> }} [recursion] An object to block recursion (per module)
  * @returns {IterableIterator<string>} The property names of the map.
  */
-function* enumeratePropertyNames(
-    traceMap,
-    path = [],
-    recursionSet = new WeakSet()
-) {
-    if (recursionSet.has(traceMap)) {
+function* enumeratePropertyNames(traceMap, path = [], recursion = {}) {
+    const recursionSet =
+        typeof path[0] === "string"
+            ? (recursion[path[0]] ??= new WeakSet())
+            : undefined
+
+    if (recursionSet?.has(traceMap)) {
         return
     }
 
@@ -48,11 +49,8 @@ function* enumeratePropertyNames(
             yield childName
         }
 
-        yield* enumeratePropertyNames(
-            childValue,
-            childPath,
-            recursionSet.add(traceMap)
-        )
+        recursionSet?.add(traceMap)
+        yield* enumeratePropertyNames(childValue, childPath, recursion)
     }
 }
 

package/lib/util/get-resolver-config.js

@@ -0,0 +1,47 @@
+/**
+ * @author Toru Nagashima
+ * See LICENSE file in root directory for full license.
+ */
+"use strict"
+
+/**
+ * @typedef {Partial<import('enhanced-resolve').ResolveOptions>} ResolverConfig
+ */
+
+/** @type {ResolverConfig} */
+const DEFAULT_VALUE = {}
+
+/**
+ * Gets `resolverConfig` property from a given option object.
+ *
+ * @param {{ resolverConfig: ResolverConfig } | undefined} option - An option object to get.
+ * @returns {ResolverConfig | undefined} The `allowModules` value, or `null`.
+ */
+function get(option) {
+    if (option?.resolverConfig) return option.resolverConfig
+}
+
+/**
+ * Gets "resolverConfig" setting.
+ *
+ * 1. This checks `options` property, then returns it if exists.
+ * 2. This checks `settings.n` | `settings.node` property, then returns it if exists.
+ * 3. This returns `[]`.
+ *
+ * @param {import('eslint').Rule.RuleContext} context - The rule context.
+ * @returns {ResolverConfig} A resolver config object.
+ */
+module.exports = function getResolverConfig(context, optionIndex = 0) {
+    return (
+        get(context.options?.[optionIndex]) ??
+        get(context.settings?.n) ??
+        get(context.settings?.node) ??
+        DEFAULT_VALUE
+    )
+}
+
+module.exports.schema = {
+    type: "object",
+    properties: {},
+    additionalProperties: true,
+}

package/lib/util/import-target.js

@@ -71,6 +71,7 @@ function getTSConfigAliases(context) {
  * @typedef Options
  * @property {string[]} [extensions]
  * @property {string[]} [paths]
+ * @property {Partial<import('enhanced-resolve').ResolveOptions>} [resolverConfig]
  * @property {string} basedir
  */
 /** @typedef { 'unknown' | 'relative' | 'absolute' | 'node' | 'npm' | 'http' } ModuleType */
@@ -323,6 +324,11 @@ module.exports = class ImportTarget {
             ).backward
         }
 
+        this.resolverConfig = {
+            ...this.resolverConfig,
+            ...this.options.resolverConfig,
+        }
+
         const requireResolve = resolver.create.sync(this.resolverConfig)
 
         const cwd = this.context.settings?.cwd ?? process.cwd()

package/lib/util/visit-import.js

@@ -7,6 +7,7 @@
 const path = require("path")
 const { isBuiltin } = require("node:module")
 const getResolvePaths = require("./get-resolve-paths")
+const getResolverConfig = require("./get-resolver-config")
 const getTryExtensions = require("./get-try-extensions")
 const ImportTarget = require("./import-target")
 const stripImportPathParams = require("./strip-import-path-params")
@@ -41,8 +42,9 @@ module.exports = function visitImport(
         path.resolve(context.filename ?? context.getFilename())
     )
     const paths = getResolvePaths(context, optionIndex)
+    const resolverConfig = getResolverConfig(context, optionIndex)
     const extensions = getTryExtensions(context, optionIndex)
-    const options = { basedir, paths, extensions }
+    const options = { basedir, paths, extensions, resolverConfig }
 
     /**
      * @param {(

package/lib/util/visit-require.js

@@ -12,6 +12,7 @@ const {
 } = require("@eslint-community/eslint-utils")
 const { isBuiltin } = require("node:module")
 const getResolvePaths = require("./get-resolve-paths")
+const getResolverConfig = require("./get-resolver-config")
 const getTryExtensions = require("./get-try-extensions")
 const ImportTarget = require("./import-target")
 const stripImportPathParams = require("./strip-import-path-params")
@@ -42,8 +43,9 @@ module.exports = function visitRequire(
         path.resolve(context.filename ?? context.getFilename())
     )
     const paths = getResolvePaths(context)
+    const resolverConfig = getResolverConfig(context)
     const extensions = getTryExtensions(context)
-    const options = { basedir, paths, extensions }
+    const options = { basedir, paths, extensions, resolverConfig }
 
     return {
         "Program:exit"(node) {

package/package.json

@@ -1,6 +1,6 @@
 {
     "name": "eslint-plugin-n",
-    "version": "17.13.2",
+    "version": "17.15.0",
     "description": "Additional ESLint's rules for Node.js",
     "engines": {
         "node": "^18.18.0 || ^20.9.0 || >=21.1.0"