eslint-plugin-n 17.11.0 → 17.12.0

package/lib/rules/no-path-concat.js

@@ -10,6 +10,7 @@ const {
     ReferenceTracker,
     getStringIfConstant,
 } = require("@eslint-community/eslint-utils")
+const { hasParentNode } = require("../util/has-parent-node.js")
 
 /**
  * Get the first char of the specified template element.
@@ -27,18 +28,21 @@ function collectFirstCharsOfTemplateElement(
     globalScope,
     outNextChars
 ) {
-    const element = node.quasis[i].value.cooked
+    const element = node.quasis[i]?.value.cooked
 
     if (element == null) {
         return
     }
-    if (element !== "") {
-        outNextChars.push(element[0])
+
+    const first = element[0]
+    if (first) {
+        outNextChars.push(first)
         return
     }
+
     if (node.expressions.length > i) {
         collectFirstChars(
-            node.expressions[i],
+            node.expressions.at(i),
             sepNodes,
             globalScope,
             outNextChars
@@ -48,14 +52,14 @@ function collectFirstCharsOfTemplateElement(
 
 /**
  * Get the first char of a given node.
- * @param {import('estree').Node} node The `TemplateLiteral` node to get.
+ * @param {import('estree').Node | undefined} node The `TemplateLiteral` node to get.
  * @param {Set<import('estree').Node>} sepNodes The nodes of `path.sep`.
  * @param {import("eslint").Scope.Scope} globalScope The global scope object.
  * @param {string[]} outNextChars The array to collect chars.
  * @returns {void}
  */
 function collectFirstChars(node, sepNodes, globalScope, outNextChars) {
-    switch (node.type) {
+    switch (node?.type) {
         case "AssignmentExpression":
             collectFirstChars(node.right, sepNodes, globalScope, outNextChars)
             break
@@ -102,13 +106,19 @@ function collectFirstChars(node, sepNodes, globalScope, outNextChars) {
         case "MemberExpression":
             if (sepNodes.has(node)) {
                 outNextChars.push(path.sep)
-                break
+            } else {
+                const str = getStringIfConstant(node, globalScope)?.at(0)
+                if (str) {
+                    outNextChars.push(str)
+                }
             }
-        // fallthrough
+            break
         default: {
-            const str = getStringIfConstant(node, globalScope)
-            if (str) {
-                outNextChars.push(str[0])
+            if (node) {
+                const str = getStringIfConstant(node, globalScope)?.at(0)
+                if (str) {
+                    outNextChars.push(str)
+                }
             }
         }
     }
@@ -122,37 +132,39 @@ function collectFirstChars(node, sepNodes, globalScope, outNextChars) {
 function isPathSeparator(c) {
     return c === "/" || c === path.sep
 }
-/** @typedef {import('estree').Identifier & { parent: import('estree').Node }} Identifier */
 
 /**
  * Check if the given Identifier node is followed by string concatenation with a
  * path separator.
- * @param {Identifier} node The `__dirname` or `__filename` node to check.
+ * @param {import('estree').Identifier} node The `__dirname` or `__filename` node to check.
  * @param {Set<import('estree').Node>} sepNodes The nodes of `path.sep`.
  * @param {import("eslint").Scope.Scope} globalScope The global scope object.
  * @returns {boolean} `true` if the given Identifier node is followed by string
  * concatenation with a path separator.
  */
 function isConcat(node, sepNodes, globalScope) {
-    const parent = node.parent
+    if (!hasParentNode(node)) {
+        return false
+    }
+
     /** @type {string[]} */
     const nextChars = []
 
     if (
-        parent.type === "BinaryExpression" &&
-        parent.operator === "+" &&
-        parent.left === node
+        node.parent.type === "BinaryExpression" &&
+        node.parent.operator === "+" &&
+        node.parent.left === node
     ) {
         collectFirstChars(
-            parent.right,
+            node.parent.right,
             sepNodes,
             globalScope,
             /* out */ nextChars
         )
-    } else if (parent.type === "TemplateLiteral") {
+    } else if (node.parent.type === "TemplateLiteral") {
         collectFirstCharsOfTemplateElement(
-            parent,
-            parent.expressions.indexOf(node) + 1,
+            node.parent,
+            node.parent.expressions.indexOf(node) + 1,
             sepNodes,
             globalScope,
             /* out */ nextChars
@@ -208,16 +220,12 @@ module.exports = {
                     __filename: { [READ]: true },
                 })) {
                     if (
-                        isConcat(
-                            /** @type {Identifier} */ (node),
-                            sepNodes,
-                            globalScope
-                        )
+                        node.type === "Identifier" &&
+                        hasParentNode(node) &&
+                        isConcat(node, sepNodes, globalScope)
                     ) {
                         context.report({
-                            node: /** @type {import('estree').Node & { parent: import('estree').Node }}*/ (
-                                node
-                            ).parent,
+                            node: node.parent,
                             messageId: "usePathFunctions",
                         })
                     }

package/lib/rules/no-unsupported-features/es-syntax.js

@@ -54,18 +54,27 @@ const ruleMap = Object.entries(features).map(([ruleId, meta]) => {
         ignoreKeys.add(ignoreName)
     }
 
-    return {
+    const supported = getSemverRange(meta.supported ?? "<0")
+    if (supported == null) {
+        throw new Error(`Invalid semver Range: "${meta.supported}"`)
+    }
+    /** @type {RuleMap} */
+    const rule = {
         ruleId: ruleId,
         feature: ruleIdNegated,
         ignoreNames: ignoreNames,
-        supported: /** @type {import("semver").Range} */ (
-            getSemverRange(meta.supported ?? "<0")
-        ),
-        strictMode: meta.strictMode
-            ? getSemverRange(meta.strictMode)
-            : undefined,
+        supported: supported,
         deprecated: Boolean(meta.deprecated),
     }
+
+    if (meta.strictMode) {
+        const range = getSemverRange(meta.strictMode)
+        if (range) {
+            rule.strictMode = range
+        }
+    }
+
+    return rule
 })
 
 /**

package/lib/rules/prefer-node-protocol.js

@@ -4,8 +4,9 @@
  */
 "use strict"
 
+const { Range } = require("semver")
+
 const getConfiguredNodeVersion = require("../util/get-configured-node-version")
-const getSemverRange = require("../util/get-semver-range")
 const visitImport = require("../util/visit-import")
 const visitRequire = require("../util/visit-require")
 const mergeVisitorsInPlace = require("../util/merge-visitors-in-place")
@@ -23,12 +24,8 @@ function isBuiltin(name) {
 
 const messageId = "preferNodeProtocol"
 
-const supportedRangeForEsm = /** @type {import('semver').Range} */ (
-    getSemverRange("^12.20.0 || >= 14.13.1")
-)
-const supportedRangeForCjs = /** @type {import('semver').Range} */ (
-    getSemverRange("^14.18.0 || >= 16.0.0")
-)
+const supportedRangeForEsm = new Range("^12.20.0 || >= 14.13.1")
+const supportedRangeForCjs = new Range("^14.18.0 || >= 16.0.0")
 
 /** @type {import('eslint').Rule.RuleModule} */
 module.exports = {
@@ -86,7 +83,7 @@ module.exports = {
         }
 
         /**
-         * @param {import('estree').Node} node
+         * @param {import('estree').Node} [node]
          * @returns {node is import('estree').Literal}
          */
         function isStringLiteral(node) {
@@ -156,12 +153,12 @@ module.exports = {
                             continue
                         }
 
-                        const { value } = /** @type {{ value: string }}*/ (node)
                         if (
-                            typeof value !== "string" ||
-                            value.startsWith("node:") ||
-                            !isBuiltin(value) ||
-                            !isBuiltin(`node:${value}`)
+                            !("value" in node) ||
+                            typeof node.value !== "string" ||
+                            node.value.startsWith("node:") ||
+                            !isBuiltin(node.value) ||
+                            !isBuiltin(`node:${node.value}`)
                         ) {
                             continue
                         }
@@ -170,7 +167,7 @@ module.exports = {
                             node,
                             messageId,
                             data: {
-                                moduleName: value,
+                                moduleName: node.value,
                             },
                             fix(fixer) {
                                 const firstCharacterIndex =

package/lib/rules/prefer-promises/dns.js

@@ -10,30 +10,33 @@ const {
     ReferenceTracker,
 } = require("@eslint-community/eslint-utils")
 
+/** @type {import('@eslint-community/eslint-utils').TraceMap<boolean>} */
+const dns = {
+    lookup: { [CALL]: true },
+    lookupService: { [CALL]: true },
+    Resolver: { [CONSTRUCT]: true },
+    getServers: { [CALL]: true },
+    resolve: { [CALL]: true },
+    resolve4: { [CALL]: true },
+    resolve6: { [CALL]: true },
+    resolveAny: { [CALL]: true },
+    resolveCname: { [CALL]: true },
+    resolveMx: { [CALL]: true },
+    resolveNaptr: { [CALL]: true },
+    resolveNs: { [CALL]: true },
+    resolvePtr: { [CALL]: true },
+    resolveSoa: { [CALL]: true },
+    resolveSrv: { [CALL]: true },
+    resolveTxt: { [CALL]: true },
+    reverse: { [CALL]: true },
+    setServers: { [CALL]: true },
+}
+
 /** @type {import('@eslint-community/eslint-utils').TraceMap<boolean>} */
 const traceMap = {
-    dns: {
-        lookup: { [CALL]: true },
-        lookupService: { [CALL]: true },
-        Resolver: { [CONSTRUCT]: true },
-        getServers: { [CALL]: true },
-        resolve: { [CALL]: true },
-        resolve4: { [CALL]: true },
-        resolve6: { [CALL]: true },
-        resolveAny: { [CALL]: true },
-        resolveCname: { [CALL]: true },
-        resolveMx: { [CALL]: true },
-        resolveNaptr: { [CALL]: true },
-        resolveNs: { [CALL]: true },
-        resolvePtr: { [CALL]: true },
-        resolveSoa: { [CALL]: true },
-        resolveSrv: { [CALL]: true },
-        resolveTxt: { [CALL]: true },
-        reverse: { [CALL]: true },
-        setServers: { [CALL]: true },
-    },
+    dns: dns,
+    "node:dns": dns,
 }
-traceMap["node:dns"] = traceMap.dns
 
 /** @type {import('eslint').Rule.RuleModule} */
 module.exports = {
@@ -65,7 +68,14 @@ module.exports = {
 
                 for (const { node, path } of references) {
                     const name = path[path.length - 1]
-                    const isClass = name[0] === name[0].toUpperCase()
+                    if (name == null) {
+                        continue
+                    }
+                    const firstLetter = name[0]
+                    if (firstLetter == null) {
+                        continue
+                    }
+                    const isClass = firstLetter === firstLetter.toUpperCase()
                     context.report({
                         node,
                         messageId: isClass

package/lib/rules/prefer-promises/fs.js

@@ -65,7 +65,11 @@ module.exports = {
                 ]
 
                 for (const { node, path } of references) {
-                    const name = path[path.length - 1]
+                    const name = path.at(-1)
+                    if (name == null) {
+                        continue
+                    }
+
                     context.report({
                         node,
                         messageId: "preferPromises",

package/lib/unsupported-features/node-builtins-modules/assert.js

@@ -2,7 +2,9 @@
 
 const { READ } = require("@eslint-community/eslint-utils")
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 const assert = {
     assert: { [READ]: { supported: ["0.5.9"] } },
     deepEqual: { [READ]: { supported: ["0.1.21"] } },
@@ -38,6 +40,7 @@ const assert = {
             deprecated: ["20.1.0"],
         },
     },
+    strict: {},
 }
 
 assert.strict = {
@@ -45,7 +48,9 @@ assert.strict = {
     [READ]: { supported: ["9.9.0", "8.13.0"] },
 }
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 module.exports = {
     assert: {
         ...assert,

package/lib/unsupported-features/node-builtins-modules/async_hooks.js

@@ -2,7 +2,9 @@
 
 const { READ } = require("@eslint-community/eslint-utils")
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 const async_hooks = {
     createHook: { [READ]: { experimental: ["8.1.0"] } },
     executionAsyncResource: { [READ]: { experimental: ["13.9.0", "12.17.0"] } },
@@ -25,7 +27,9 @@ const async_hooks = {
     },
 }
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 module.exports = {
     async_hooks: {
         [READ]: {

package/lib/unsupported-features/node-builtins-modules/buffer.js

@@ -2,7 +2,9 @@
 
 const { CONSTRUCT, READ } = require("@eslint-community/eslint-utils")
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 const buffer = {
     constants: { [READ]: { supported: ["8.2.0"] } },
     INSPECT_MAX_BYTES: { [READ]: { supported: ["0.5.4"] } },
@@ -43,7 +45,9 @@ const buffer = {
     },
 }
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 module.exports = {
     buffer: {
         [READ]: { supported: ["0.1.90"] },

package/lib/unsupported-features/node-builtins-modules/child_process.js

@@ -2,7 +2,9 @@
 
 const { READ } = require("@eslint-community/eslint-utils")
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 const child_process = {
     exec: { [READ]: { supported: ["0.1.90"] } },
     execFile: { [READ]: { supported: ["0.1.91"] } },
@@ -14,7 +16,9 @@ const child_process = {
     ChildProcess: { [READ]: { supported: ["2.2.0"] } },
 }
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 module.exports = {
     child_process: {
         [READ]: { supported: ["0.1.90"] },

package/lib/unsupported-features/node-builtins-modules/cluster.js

@@ -2,7 +2,9 @@
 
 const { READ } = require("@eslint-community/eslint-utils")
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 const cluster = {
     isMaster: { [READ]: { supported: ["0.8.1"], deprecated: ["16.0.0"] } },
     isPrimary: { [READ]: { supported: ["16.0.0"] } },
@@ -18,7 +20,9 @@ const cluster = {
     Worker: { [READ]: { supported: ["0.7.0"] } },
 }
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 module.exports = {
     cluster: {
         [READ]: { supported: ["0.7.0"] },

package/lib/unsupported-features/node-builtins-modules/console.js

@@ -2,7 +2,9 @@
 
 const { READ } = require("@eslint-community/eslint-utils")
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 const console = {
     profile: { [READ]: { supported: ["8.0.0"] } },
     profileEnd: { [READ]: { supported: ["8.0.0"] } },
@@ -34,7 +36,9 @@ const console = {
     // timelineEnd: { [READ]: { supported: ["8.0.0"] } },
 }
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 module.exports = {
     console: {
         [READ]: { supported: ["0.1.100"] },

package/lib/unsupported-features/node-builtins-modules/crypto.js

@@ -2,7 +2,9 @@
 
 const { CALL, CONSTRUCT, READ } = require("@eslint-community/eslint-utils")
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 const WebCrypto = {
     [READ]: { experimental: ["15.0.0"], supported: ["19.0.0"] },
     subtle: {
@@ -24,7 +26,9 @@ const WebCrypto = {
     randomUUID: { [READ]: { supported: ["16.7.0"] } },
 }
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 const crypto = {
     constants: { [READ]: { supported: ["6.3.0"] } },
     fips: { [READ]: { supported: ["6.0.0"], deprecated: ["10.0.0"] } },
@@ -125,7 +129,9 @@ const crypto = {
     X509Certificate: { [READ]: { supported: ["15.6.0"] } },
 }
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 module.exports = {
     crypto: {
         [READ]: { supported: ["0.1.92"] },

package/lib/unsupported-features/node-builtins-modules/dgram.js

@@ -2,13 +2,17 @@
 
 const { READ } = require("@eslint-community/eslint-utils")
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 const dgram = {
     createSocket: { [READ]: { supported: ["0.1.99"] } },
     Socket: { [READ]: { supported: ["0.1.99"] } },
 }
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 module.exports = {
     dgram: {
         [READ]: { supported: ["0.1.99"] },

package/lib/unsupported-features/node-builtins-modules/diagnostics_channel.js

@@ -2,7 +2,9 @@
 
 const { READ } = require("@eslint-community/eslint-utils")
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 const diagnostics_channel = {
     hasSubscribers: { [READ]: { supported: ["15.1.0", "14.17.0"] } },
     channel: { [READ]: { supported: ["15.1.0", "14.17.0"] } },
@@ -13,7 +15,9 @@ const diagnostics_channel = {
     TracingChannel: { [READ]: { experimental: ["19.9.0"] } },
 }
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 module.exports = {
     diagnostics_channel: {
         [READ]: {

package/lib/unsupported-features/node-builtins-modules/dns.js

@@ -2,7 +2,9 @@
 
 const { READ } = require("@eslint-community/eslint-utils")
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 const dns = {
     Resolver: { [READ]: { supported: ["8.3.0"] } },
     getServers: { [READ]: { supported: ["0.11.3"] } },
@@ -56,7 +58,9 @@ const dns = {
     },
 }
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 module.exports = {
     dns: { ...dns, [READ]: { supported: ["0.1.16"] } },
     "node:dns": { ...dns, [READ]: { supported: ["14.13.1", "12.20.0"] } },

package/lib/unsupported-features/node-builtins-modules/domain.js

@@ -2,13 +2,17 @@
 
 const { READ } = require("@eslint-community/eslint-utils")
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 const domain = {
     create: { [READ]: { supported: ["0.7.8"] } },
     Domain: { [READ]: { supported: ["0.7.8"] } },
 }
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 module.exports = {
     domain: {
         [READ]: {

package/lib/unsupported-features/node-builtins-modules/events.js

@@ -2,7 +2,9 @@
 
 const { READ } = require("@eslint-community/eslint-utils")
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 const EventEmitterStatic = {
     defaultMaxListeners: { [READ]: { supported: ["0.11.2"] } },
     errorMonitor: { [READ]: { supported: ["13.6.0", "12.17.0"] } },
@@ -27,7 +29,9 @@ const EventEmitterStatic = {
     addAbortListener: { [READ]: { experimental: ["20.5.0", "18.18.0"] } },
 }
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 const events = {
     Event: { [READ]: { experimental: ["14.5.0"], supported: ["15.4.0"] } },
     EventTarget: {
@@ -59,7 +63,9 @@ const events = {
     ...EventEmitterStatic,
 }
 
-/** @type {import('../types.js').SupportVersionTraceMap} */
+/**
+ * @satisfies {import('../types.js').SupportVersionTraceMap}
+ */
 module.exports = {
     events: {
         [READ]: { supported: ["0.1.26"] },